[GitHub] flink pull request #6239: [FLINK-9004][tests] Implement Jepsen tests to test...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/6239#discussion_r199690915 --- Diff: jepsen-flink/README.md --- @@ -0,0 +1,60 @@ +# jepsen.flink + +A Clojure project based on the

[jira] [Commented] (FLINK-9004) Cluster test: Run general purpose job with failures with Yarn session

[ https://issues.apache.org/jira/browse/FLINK-9004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530873#comment-16530873 ] ASF GitHub Bot commented on FLINK-9004: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-9636) Network buffer leaks in requesting a batch of segments during canceling

[ https://issues.apache.org/jira/browse/FLINK-9636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530783#comment-16530783 ] ASF GitHub Bot commented on FLINK-9636: --- Github user zhijiangW commented on a diff in the pull

[jira] [Commented] (FLINK-9636) Network buffer leaks in requesting a batch of segments during canceling

[ https://issues.apache.org/jira/browse/FLINK-9636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530782#comment-16530782 ] ASF GitHub Bot commented on FLINK-9636: --- Github user zhijiangW commented on the issue:

[GitHub] flink pull request #6238: [FLINK-9636][network] fix inconsistency with faile...

Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/6238#discussion_r199676237 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/NetworkBufferPool.java --- @@ -147,7 +151,12 @@ public void

[GitHub] flink issue #6238: [FLINK-9636][network] fix inconsistency with failed buffe...

Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/6238 Thanks for fixing this bug. :) I think there is another potential bug in polling segments from queue during task canceling process, and I pointed out it in the above codes. ---

[jira] [Issue Comment Deleted] (FLINK-9411) Support parquet rolling sink writer

[ https://issues.apache.org/jira/browse/FLINK-9411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangminglei updated FLINK-9411: Comment: was deleted (was: Thanks for your feedback, [~StephanEwen]. What you mean is that every

[jira] [Comment Edited] (FLINK-8554) Upgrade AWS SDK

[ https://issues.apache.org/jira/browse/FLINK-8554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507192#comment-16507192 ] Ted Yu edited comment on FLINK-8554 at 7/3/18 2:32 AM: --- Or use this JIRA for the

[jira] [Updated] (FLINK-9048) LocalFlinkMiniClusterITCase#testLocalFlinkMiniClusterWithMultipleTaskManagers sometimes fails

[ https://issues.apache.org/jira/browse/FLINK-9048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-9048: -- Labels: local-job-runner (was: ) >

[jira] [Commented] (FLINK-9185) Potential null dereference in PrioritizedOperatorSubtaskState#resolvePrioritizedAlternatives

[ https://issues.apache.org/jira/browse/FLINK-9185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530728#comment-16530728 ] Ted Yu commented on FLINK-9185: --- lgtm > Potential null dereference in >

[GitHub] flink pull request #6239: [FLINK-9004][tests] Implement Jepsen tests to test...

Github user yanghua commented on a diff in the pull request: https://github.com/apache/flink/pull/6239#discussion_r199664502 --- Diff: jepsen-flink/README.md --- @@ -0,0 +1,60 @@ +# jepsen.flink + +A Clojure project based on the

[jira] [Commented] (FLINK-9004) Cluster test: Run general purpose job with failures with Yarn session

[ https://issues.apache.org/jira/browse/FLINK-9004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530673#comment-16530673 ] ASF GitHub Bot commented on FLINK-9004: --- Github user yanghua commented on a diff in the pull

[jira] [Updated] (FLINK-7593) Generated plan does not create correct groups

[ https://issues.apache.org/jira/browse/FLINK-7593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunhui Shi updated FLINK-7593: --- Attachment: flink-good-plan.json > Generated plan does not create correct groups >

[jira] [Commented] (FLINK-7593) Generated plan does not create correct groups

[ https://issues.apache.org/jira/browse/FLINK-7593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530665#comment-16530665 ] Chunhui Shi commented on FLINK-7593: Yes, I built a small project for the code. And I have reproduced

[jira] [Commented] (FLINK-9695) Add option for Mesos executor to forcefully pull Docker images

[ https://issues.apache.org/jira/browse/FLINK-9695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530489#comment-16530489 ] ASF GitHub Bot commented on FLINK-9695: --- Github user lishim commented on the issue:

[GitHub] flink issue #6232: [FLINK-9695] [mesos] Add option for Mesos executor to for...

Github user lishim commented on the issue: https://github.com/apache/flink/pull/6232 Hi @tillrohrmann. Thank you for your comment. I have updated the code to conform to other configuration options. ---

[GitHub] flink pull request #6237: [FLINK-9567][runtime][yarn] Fix the bug that Flink...

Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6237 ---

[jira] [Commented] (FLINK-9567) Flink does not release resource in Yarn Cluster mode

[ https://issues.apache.org/jira/browse/FLINK-9567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530478#comment-16530478 ] ASF GitHub Bot commented on FLINK-9567: --- Github user asfgit closed the pull request at:

[jira] [Resolved] (FLINK-9567) Flink does not release resource in Yarn Cluster mode

[ https://issues.apache.org/jira/browse/FLINK-9567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-9567. -- Resolution: Fixed Fix Version/s: 1.5.1 Fixed via 1.6.0:

[jira] [Commented] (FLINK-9004) Cluster test: Run general purpose job with failures with Yarn session

[ https://issues.apache.org/jira/browse/FLINK-9004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530445#comment-16530445 ] ASF GitHub Bot commented on FLINK-9004: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #6239: [FLINK-9004][tests] Implement Jepsen tests to test...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/6239#discussion_r199622404 --- Diff: jepsen-flink/README.md --- @@ -0,0 +1,60 @@ +# jepsen.flink + +A Clojure project based on the

[jira] [Commented] (FLINK-9061) add entropy to s3 path for better scalability

[ https://issues.apache.org/jira/browse/FLINK-9061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530389#comment-16530389 ] Jamie Grier commented on FLINK-9061: [~ind_rc] Initial changes look good.  Are you going to try to

[jira] [Commented] (FLINK-9004) Cluster test: Run general purpose job with failures with Yarn session

[ https://issues.apache.org/jira/browse/FLINK-9004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530310#comment-16530310 ] ASF GitHub Bot commented on FLINK-9004: --- Github user zentol commented on a diff in the pull

[GitHub] flink pull request #6239: [FLINK-9004][tests] Implement Jepsen tests to test...

Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6239#discussion_r199592285 --- Diff: jepsen-flink/README.md --- @@ -0,0 +1,60 @@ +# jepsen.flink + +A Clojure project based on the

[jira] [Commented] (FLINK-9696) Deep toString for arrays/map in SQL client

[ https://issues.apache.org/jira/browse/FLINK-9696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530181#comment-16530181 ] ASF GitHub Bot commented on FLINK-9696: --- Github user snuyanzin commented on the issue:

[GitHub] flink issue #6233: [FLINK-9696] Deep toString for array/map sql types

Github user snuyanzin commented on the issue: https://github.com/apache/flink/pull/6233 @hequn8128 thank you for your idea about Row. I used it in tests. Also I checked usages of `org.apache.flink.table.client.cli.CliStrings#NULL_COLUMN` it was added only recently and used only in

[jira] [Commented] (FLINK-9696) Deep toString for arrays/map in SQL client

[ https://issues.apache.org/jira/browse/FLINK-9696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530177#comment-16530177 ] ASF GitHub Bot commented on FLINK-9696: --- Github user snuyanzin commented on a diff in the pull

[GitHub] flink pull request #6233: [FLINK-9696] Deep toString for array/map sql types

Github user snuyanzin commented on a diff in the pull request: https://github.com/apache/flink/pull/6233#discussion_r199559926 --- Diff: flink-libraries/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliUtilsTest.java --- @@ -0,0 +1,108 @@ +/* + *

[jira] [Commented] (FLINK-9424) BlobClientSslTest does not work in all environments

[ https://issues.apache.org/jira/browse/FLINK-9424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530162#comment-16530162 ] Maxim Neverov commented on FLINK-9424: -- Had this problem. According to [this

[jira] [Commented] (FLINK-9641) Pulsar Source Connector

[ https://issues.apache.org/jira/browse/FLINK-9641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530152#comment-16530152 ] ASF GitHub Bot commented on FLINK-9641: --- Github user yanghua commented on a diff in the pull

[jira] [Commented] (FLINK-9641) Pulsar Source Connector

[ https://issues.apache.org/jira/browse/FLINK-9641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530150#comment-16530150 ] ASF GitHub Bot commented on FLINK-9641: --- Github user yanghua commented on a diff in the pull

[jira] [Commented] (FLINK-9641) Pulsar Source Connector

[ https://issues.apache.org/jira/browse/FLINK-9641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530151#comment-16530151 ] ASF GitHub Bot commented on FLINK-9641: --- Github user yanghua commented on a diff in the pull

[jira] [Commented] (FLINK-9641) Pulsar Source Connector

[ https://issues.apache.org/jira/browse/FLINK-9641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530153#comment-16530153 ] ASF GitHub Bot commented on FLINK-9641: --- Github user yanghua commented on a diff in the pull

[GitHub] flink pull request #6200: [FLINK-9641] [streaming-connectors] Flink pulsar s...

Github user yanghua commented on a diff in the pull request: https://github.com/apache/flink/pull/6200#discussion_r199548194 --- Diff: flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/streaming/connectors/pulsar/PulsarConsumerSource.java --- @@ -0,0 +1,203

[GitHub] flink pull request #6200: [FLINK-9641] [streaming-connectors] Flink pulsar s...

Github user yanghua commented on a diff in the pull request: https://github.com/apache/flink/pull/6200#discussion_r199546643 --- Diff: flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/streaming/connectors/pulsar/Defaults.java --- @@ -0,0 +1,30 @@ +/*

[GitHub] flink pull request #6200: [FLINK-9641] [streaming-connectors] Flink pulsar s...

Github user yanghua commented on a diff in the pull request: https://github.com/apache/flink/pull/6200#discussion_r199549195 --- Diff: flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/streaming/connectors/pulsar/PulsarSourceBase.java --- @@ -0,0 +1,30 @@

[GitHub] flink pull request #6200: [FLINK-9641] [streaming-connectors] Flink pulsar s...

Github user yanghua commented on a diff in the pull request: https://github.com/apache/flink/pull/6200#discussion_r199551693 --- Diff: flink-connectors/flink-connector-pulsar/src/test/java/org/apache/flink/streaming/connectors/pulsar/PulsarConsumerSourceTests.java --- @@ -0,0

[jira] [Commented] (FLINK-9351) RM stop assigning slot to Job because the TM killed before connecting to JM successfully

[ https://issues.apache.org/jira/browse/FLINK-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530137#comment-16530137 ] ASF GitHub Bot commented on FLINK-9351: --- Github user sihuazhou closed the pull request at:

[GitHub] flink pull request #6133: [FLINK-9351][Distributed Coordination] RM stop ass...

Github user sihuazhou closed the pull request at: https://github.com/apache/flink/pull/6133 ---

[jira] [Created] (FLINK-9705) Failed to close kafka producer - Interrupted while joining ioThread

Sayat Satybaldiyev created FLINK-9705: - Summary: Failed to close kafka producer - Interrupted while joining ioThread Key: FLINK-9705 URL: https://issues.apache.org/jira/browse/FLINK-9705 Project:

[jira] [Created] (FLINK-9704) QueryableState E2E test failed on travis

Chesnay Schepler created FLINK-9704: --- Summary: QueryableState E2E test failed on travis Key: FLINK-9704 URL: https://issues.apache.org/jira/browse/FLINK-9704 Project: Flink Issue Type:

[jira] [Commented] (FLINK-9688) ATAN2 Sql Function support

[ https://issues.apache.org/jira/browse/FLINK-9688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530104#comment-16530104 ] ASF GitHub Bot commented on FLINK-9688: --- Github user snuyanzin commented on a diff in the pull

[GitHub] flink pull request #6223: [FLINK-9688] ATAN2 sql function support

Github user snuyanzin commented on a diff in the pull request: https://github.com/apache/flink/pull/6223#discussion_r199543936 --- Diff: docs/dev/table/sql.md --- @@ -1510,6 +1510,17 @@ ATAN(numeric) + + +{% highlight text

[jira] [Updated] (FLINK-9622) DistributedCacheDfsTest failed on travis

[ https://issues.apache.org/jira/browse/FLINK-9622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-9622: Fix Version/s: (was: 1.5.1) > DistributedCacheDfsTest failed on travis >

[jira] [Commented] (FLINK-9622) DistributedCacheDfsTest failed on travis

[ https://issues.apache.org/jira/browse/FLINK-9622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530097#comment-16530097 ] Till Rohrmann commented on FLINK-9622: -- The problem seems to be that we don't create the parent

[jira] [Assigned] (FLINK-9622) DistributedCacheDfsTest failed on travis

[ https://issues.apache.org/jira/browse/FLINK-9622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-9622: Assignee: Till Rohrmann > DistributedCacheDfsTest failed on travis >

[jira] [Updated] (FLINK-9622) DistributedCacheDfsTest failed on travis

[ https://issues.apache.org/jira/browse/FLINK-9622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-9622: - Fix Version/s: 1.5.1 > DistributedCacheDfsTest failed on travis >

[jira] [Closed] (FLINK-9519) table example jar did not copy into example dir

[ https://issues.apache.org/jira/browse/FLINK-9519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang closed FLINK-9519. --- Resolution: Won't Fix > table example jar did not copy into example dir >

[jira] [Commented] (FLINK-9688) ATAN2 Sql Function support

[ https://issues.apache.org/jira/browse/FLINK-9688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530083#comment-16530083 ] ASF GitHub Bot commented on FLINK-9688: --- Github user hequn8128 commented on a diff in the pull

[jira] [Commented] (FLINK-9519) table example jar did not copy into example dir

[ https://issues.apache.org/jira/browse/FLINK-9519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530082#comment-16530082 ] vinoyang commented on FLINK-9519: - [~fhueske] sorry, I forgot, thanks for reminding, closing... > table

[jira] [Commented] (FLINK-9688) ATAN2 Sql Function support

[ https://issues.apache.org/jira/browse/FLINK-9688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530081#comment-16530081 ] ASF GitHub Bot commented on FLINK-9688: --- Github user hequn8128 commented on a diff in the pull

[GitHub] flink pull request #6223: [FLINK-9688] ATAN2 sql function support

Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/6223#discussion_r199537675 --- Diff: docs/dev/table/sql.md --- @@ -1510,6 +1510,17 @@ ATAN(numeric) + + +{% highlight text

[jira] [Commented] (FLINK-9688) ATAN2 Sql Function support

[ https://issues.apache.org/jira/browse/FLINK-9688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530080#comment-16530080 ] ASF GitHub Bot commented on FLINK-9688: --- Github user hequn8128 commented on a diff in the pull

[GitHub] flink pull request #6223: [FLINK-9688] ATAN2 sql function support

Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/6223#discussion_r199537034 --- Diff: docs/dev/table/sql.md --- @@ -1510,6 +1510,17 @@ ATAN(numeric) + + +{% highlight text

[GitHub] flink pull request #6223: [FLINK-9688] ATAN2 sql function support

Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/6223#discussion_r199537075 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/FunctionGenerator.scala --- @@ -300,6 +300,24 @@ object

[jira] [Commented] (FLINK-9581) Redundant spaces for Collect at sql.md

[ https://issues.apache.org/jira/browse/FLINK-9581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530060#comment-16530060 ] ASF GitHub Bot commented on FLINK-9581: --- Github user fhueske commented on the issue:

[jira] [Commented] (FLINK-9674) Remove 65s sleep in QueryableState E2E test

[ https://issues.apache.org/jira/browse/FLINK-9674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530061#comment-16530061 ] ASF GitHub Bot commented on FLINK-9674: --- Github user yanghua commented on the issue:

[GitHub] flink issue #6216: [FLINK-9674][tests] Replace hard-coded sleeps in QS E2E t...

Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6216 +1 ---

[GitHub] flink issue #6161: [hotfix] [docs][FLINK-9581] Typo: extra spaces removed to...

Github user fhueske commented on the issue: https://github.com/apache/flink/pull/6161 Thanks @snuyanzin! +1 to merge ---

[jira] [Commented] (FLINK-9519) table example jar did not copy into example dir

[ https://issues.apache.org/jira/browse/FLINK-9519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530055#comment-16530055 ] Fabian Hueske commented on FLINK-9519: -- Hi [~yanghua], should we close this issue as well (like

[jira] [Commented] (FLINK-9004) Cluster test: Run general purpose job with failures with Yarn session

[ https://issues.apache.org/jira/browse/FLINK-9004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530047#comment-16530047 ] ASF GitHub Bot commented on FLINK-9004: --- Github user yanghua commented on a diff in the pull

[jira] [Commented] (FLINK-9004) Cluster test: Run general purpose job with failures with Yarn session

[ https://issues.apache.org/jira/browse/FLINK-9004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530048#comment-16530048 ] ASF GitHub Bot commented on FLINK-9004: --- Github user yanghua commented on a diff in the pull

[GitHub] flink pull request #6239: [FLINK-9004][tests] Implement Jepsen tests to test...

Github user yanghua commented on a diff in the pull request: https://github.com/apache/flink/pull/6239#discussion_r199527828 --- Diff: jepsen-flink/README.md --- @@ -0,0 +1,60 @@ +# jepsen.flink + +A Clojure project based on the

[GitHub] flink pull request #6239: [FLINK-9004][tests] Implement Jepsen tests to test...

Github user yanghua commented on a diff in the pull request: https://github.com/apache/flink/pull/6239#discussion_r199527590 --- Diff: jepsen-flink/README.md --- @@ -0,0 +1,60 @@ +# jepsen.flink + +A Clojure project based on the

[jira] [Closed] (FLINK-9351) RM stop assigning slot to Job because the TM killed before connecting to JM successfully

[ https://issues.apache.org/jira/browse/FLINK-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sihua Zhou closed FLINK-9351. - Resolution: Duplicate This issue have been fixed by the way in the PR of

[jira] [Updated] (FLINK-9622) DistributedCacheDfsTest failed on travis

[ https://issues.apache.org/jira/browse/FLINK-9622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-9622: - Fix Version/s: 1.6.0 > DistributedCacheDfsTest failed on travis >

[jira] [Commented] (FLINK-9622) DistributedCacheDfsTest failed on travis

[ https://issues.apache.org/jira/browse/FLINK-9622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530030#comment-16530030 ] Till Rohrmann commented on FLINK-9622: -- Another instance:

[jira] [Commented] (FLINK-9491) Implement timer data structure based on RocksDB

[ https://issues.apache.org/jira/browse/FLINK-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530008#comment-16530008 ] ASF GitHub Bot commented on FLINK-9491: --- Github user sihuazhou commented on the issue:

[GitHub] flink issue #6228: [FLINK-9491] Implement timer data structure based on Rock...

Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/6228 +1 from my side ---

[jira] [Assigned] (FLINK-9636) Network buffer leaks in requesting a batch of segments during canceling

[ https://issues.apache.org/jira/browse/FLINK-9636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-9636: Assignee: Nico Kruber > Network buffer leaks in requesting a batch of segments during

[jira] [Commented] (FLINK-9633) Flink doesn't use the Savepoint path's filesystem to create the OuptutStream on Task.

[ https://issues.apache.org/jira/browse/FLINK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529993#comment-16529993 ] ASF GitHub Bot commented on FLINK-9633: --- Github user sihuazhou commented on the issue:

[GitHub] flink issue #6194: [FLINK-9633][checkpoint] Use savepoint path's file system...

Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/6194 Hi @tillrohrmann I added a unit test `FsCheckpointStorageTest#testResolveCheckpointStorageLocation()` to guard the changes. But I still use one `mock` for creating two different file systems(one

[jira] [Commented] (FLINK-9688) ATAN2 Sql Function support

[ https://issues.apache.org/jira/browse/FLINK-9688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529952#comment-16529952 ] ASF GitHub Bot commented on FLINK-9688: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-9688) ATAN2 Sql Function support

[ https://issues.apache.org/jira/browse/FLINK-9688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529955#comment-16529955 ] ASF GitHub Bot commented on FLINK-9688: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-9688) ATAN2 Sql Function support

[ https://issues.apache.org/jira/browse/FLINK-9688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529957#comment-16529957 ] ASF GitHub Bot commented on FLINK-9688: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-9004) Cluster test: Run general purpose job with failures with Yarn session

[ https://issues.apache.org/jira/browse/FLINK-9004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529959#comment-16529959 ] ASF GitHub Bot commented on FLINK-9004: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-9688) ATAN2 Sql Function support

[ https://issues.apache.org/jira/browse/FLINK-9688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529951#comment-16529951 ] ASF GitHub Bot commented on FLINK-9688: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-9688) ATAN2 Sql Function support

[ https://issues.apache.org/jira/browse/FLINK-9688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529953#comment-16529953 ] ASF GitHub Bot commented on FLINK-9688: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-9688) ATAN2 Sql Function support

[ https://issues.apache.org/jira/browse/FLINK-9688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529956#comment-16529956 ] ASF GitHub Bot commented on FLINK-9688: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-9688) ATAN2 Sql Function support

[ https://issues.apache.org/jira/browse/FLINK-9688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529954#comment-16529954 ] ASF GitHub Bot commented on FLINK-9688: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #6239: [FLINK-9004][tests] Implement Jepsen tests to test...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/6239#discussion_r199507669 --- Diff: jepsen-flink/docker/nodes --- @@ -0,0 +1,3 @@ +n1 --- End diff -- file must be excluded from RAT plugin ---

[GitHub] flink pull request #6223: [FLINK-9688] ATAN2 sql function support

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/6223#discussion_r199500643 --- Diff: docs/dev/table/sql.md --- @@ -1510,6 +1510,17 @@ ATAN(numeric) + + +{% highlight text %}

[GitHub] flink pull request #6223: [FLINK-9688] ATAN2 sql function support

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/6223#discussion_r199504092 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/mathExpressions.scala --- @@ -243,6 +243,16 @@ case class

[GitHub] flink pull request #6223: [FLINK-9688] ATAN2 sql function support

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/6223#discussion_r199501131 --- Diff: docs/dev/table/tableApi.md --- @@ -3748,6 +3759,17 @@ NUMERIC.atan() + + +{% highlight

[GitHub] flink pull request #6223: [FLINK-9688] ATAN2 sql function support

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/6223#discussion_r199500973 --- Diff: docs/dev/table/tableApi.md --- @@ -2184,6 +2184,17 @@ NUMERIC.atan() + + +{% highlight

[GitHub] flink pull request #6223: [FLINK-9688] ATAN2 sql function support

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/6223#discussion_r199501083 --- Diff: docs/dev/table/tableApi.md --- @@ -3748,6 +3759,17 @@ NUMERIC.atan() + + +{% highlight

[GitHub] flink pull request #6223: [FLINK-9688] ATAN2 sql function support

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/6223#discussion_r199500813 --- Diff: docs/dev/table/sql.md --- @@ -1510,6 +1510,17 @@ ATAN(numeric) + + +{% highlight text %}

[GitHub] flink pull request #6223: [FLINK-9688] ATAN2 sql function support

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/6223#discussion_r199501001 --- Diff: docs/dev/table/tableApi.md --- @@ -2184,6 +2184,17 @@ NUMERIC.atan() + + +{% highlight

[jira] [Commented] (FLINK-9696) Deep toString for arrays/map in SQL client

[ https://issues.apache.org/jira/browse/FLINK-9696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529945#comment-16529945 ] ASF GitHub Bot commented on FLINK-9696: --- Github user hequn8128 commented on a diff in the pull

[GitHub] flink pull request #6233: [FLINK-9696] Deep toString for array/map sql types

Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/6233#discussion_r199506183 --- Diff: flink-libraries/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliUtilsTest.java --- @@ -0,0 +1,108 @@ +/* + *

[jira] [Commented] (FLINK-9696) Deep toString for arrays/map in SQL client

[ https://issues.apache.org/jira/browse/FLINK-9696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529941#comment-16529941 ] ASF GitHub Bot commented on FLINK-9696: --- Github user hequn8128 commented on a diff in the pull

[jira] [Commented] (FLINK-9696) Deep toString for arrays/map in SQL client

[ https://issues.apache.org/jira/browse/FLINK-9696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529940#comment-16529940 ] ASF GitHub Bot commented on FLINK-9696: --- Github user hequn8128 commented on a diff in the pull

[GitHub] flink pull request #6233: [FLINK-9696] Deep toString for array/map sql types

Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/6233#discussion_r199504811 --- Diff: flink-libraries/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliUtilsTest.java --- @@ -0,0 +1,108 @@ +/* + *

[GitHub] flink pull request #6233: [FLINK-9696] Deep toString for array/map sql types

Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/6233#discussion_r199504779 --- Diff: flink-libraries/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliUtilsTest.java --- @@ -0,0 +1,108 @@ +/* + *

[jira] [Closed] (FLINK-8650) Add tests and documentation for WINDOW clause

[ https://issues.apache.org/jira/browse/FLINK-8650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-8650. Resolution: Fixed Fix Version/s: 1.5.1 1.4.3 1.6.0

[jira] [Commented] (FLINK-9681) Make sure minRetentionTime not equal to maxRetentionTime

[ https://issues.apache.org/jira/browse/FLINK-9681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529850#comment-16529850 ] Fabian Hueske commented on FLINK-9681: -- Hi [~hequn8128], You are right. Setting both parameters to

[jira] [Commented] (FLINK-8650) Add tests and documentation for WINDOW clause

[ https://issues.apache.org/jira/browse/FLINK-8650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529847#comment-16529847 ] ASF GitHub Bot commented on FLINK-8650: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #6226: [FLINK-8650] Tests for WINDOW clause and documenta...

Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6226 ---

[jira] [Commented] (FLINK-8650) Add tests and documentation for WINDOW clause

[ https://issues.apache.org/jira/browse/FLINK-8650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529838#comment-16529838 ] ASF GitHub Bot commented on FLINK-8650: --- Github user fhueske commented on the issue:

[GitHub] flink issue #6226: [FLINK-8650] Tests for WINDOW clause and documentation up...

Github user fhueske commented on the issue: https://github.com/apache/flink/pull/6226 Thanks for the update @snuyanzin. Looks good. Will merge it. ---

  1   2   3   >