[jira] [Commented] (FLINK-10471) State TTL cleanup using RocksDb compaction filter

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696481#comment-16696481 ] ASF GitHub Bot commented on FLINK-10471: Aitozi commented on a change in pull re

[GitHub] Aitozi commented on a change in pull request #7163: [FLINK-10471][State TTL] State TTL cleanup using RocksDb compaction filter

2018-11-22 Thread GitBox
Aitozi commented on a change in pull request #7163: [FLINK-10471][State TTL] State TTL cleanup using RocksDb compaction filter URL: https://github.com/apache/flink/pull/7163#discussion_r235862583 ## File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache

[jira] [Updated] (FLINK-9461) Disentangle flink-connector-kafka from flink-table and flink-json

2018-11-22 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang updated FLINK-9461: Issue Type: Sub-task (was: Improvement) Parent: FLINK-10598 > Disentangle flink-connector-kafka fr

[jira] [Commented] (FLINK-10009) Fix the casting problem for function TIMESTAMPADD in Table

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696469#comment-16696469 ] ASF GitHub Bot commented on FLINK-10009: wuchong commented on issue #7155: [FLIN

[GitHub] wuchong commented on issue #7155: [FLINK-10009] [table] Fix the casting problem for function TIMESTAMPADD in Table

2018-11-22 Thread GitBox
wuchong commented on issue #7155: [FLINK-10009] [table] Fix the casting problem for function TIMESTAMPADD in Table URL: https://github.com/apache/flink/pull/7155#issuecomment-441170727 Thanks @XuQianJin-Stars for looking into this. I think it's fine to separate it into different issues.

[jira] [Commented] (FLINK-8577) Implement proctime DataStream to Table upsert conversion.

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696467#comment-16696467 ] ASF GitHub Bot commented on FLINK-8577: --- hequn8128 commented on a change in pull re

[GitHub] hequn8128 commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2018-11-22 Thread GitBox
hequn8128 commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r235835262 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/c

[jira] [Commented] (FLINK-10009) Fix the casting problem for function TIMESTAMPADD in Table

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696463#comment-16696463 ] ASF GitHub Bot commented on FLINK-10009: XuQianJin-Stars commented on issue #715

[GitHub] XuQianJin-Stars commented on issue #7155: [FLINK-10009] [table] Fix the casting problem for function TIMESTAMPADD in Table

2018-11-22 Thread GitBox
XuQianJin-Stars commented on issue #7155: [FLINK-10009] [table] Fix the casting problem for function TIMESTAMPADD in Table URL: https://github.com/apache/flink/pull/7155#issuecomment-441170550 @sunjincheng121 @wuchong I have opened a new isuse to track timestampadd's time type handling

[jira] [Created] (FLINK-10994) The bug of timestampadd handles time

2018-11-22 Thread xuqianjin (JIRA)
xuqianjin created FLINK-10994: - Summary: The bug of timestampadd handles time Key: FLINK-10994 URL: https://issues.apache.org/jira/browse/FLINK-10994 Project: Flink Issue Type: Bug Comp

[jira] [Commented] (FLINK-8577) Implement proctime DataStream to Table upsert conversion.

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696452#comment-16696452 ] ASF GitHub Bot commented on FLINK-8577: --- hequn8128 commented on a change in pull re

[GitHub] Aitozi commented on issue #7163: [FLINK-10471][State TTL] State TTL cleanup using RocksDb compaction filter

2018-11-22 Thread GitBox
Aitozi commented on issue #7163: [FLINK-10471][State TTL] State TTL cleanup using RocksDb compaction filter URL: https://github.com/apache/flink/pull/7163#issuecomment-441169167 Really great work đź‘Ť. LGTM! But if the rocksdb community do not merge the patch recently, do we have to maintain

[jira] [Commented] (FLINK-10471) State TTL cleanup using RocksDb compaction filter

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696453#comment-16696453 ] ASF GitHub Bot commented on FLINK-10471: Aitozi commented on issue #7163: [FLINK

[GitHub] hequn8128 commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2018-11-22 Thread GitBox
hequn8128 commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r235858319 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/p

[jira] [Commented] (FLINK-10993) Bring bloomfilter as a public API

2018-11-22 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696450#comment-16696450 ] vinoyang commented on FLINK-10993: -- [~fhue...@gmail.com] [~trohrm...@apache.org] What d

[jira] [Created] (FLINK-10993) Bring bloomfilter as a public API

2018-11-22 Thread vinoyang (JIRA)
vinoyang created FLINK-10993: Summary: Bring bloomfilter as a public API Key: FLINK-10993 URL: https://issues.apache.org/jira/browse/FLINK-10993 Project: Flink Issue Type: New Feature C

[jira] [Commented] (FLINK-10009) Fix the casting problem for function TIMESTAMPADD in Table

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696441#comment-16696441 ] ASF GitHub Bot commented on FLINK-10009: XuQianJin-Stars commented on issue #715

[jira] [Commented] (FLINK-10471) State TTL cleanup using RocksDb compaction filter

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696447#comment-16696447 ] ASF GitHub Bot commented on FLINK-10471: Aitozi commented on a change in pull re

[GitHub] Aitozi commented on a change in pull request #7163: [FLINK-10471][State TTL] State TTL cleanup using RocksDb compaction filter

2018-11-22 Thread GitBox
Aitozi commented on a change in pull request #7163: [FLINK-10471][State TTL] State TTL cleanup using RocksDb compaction filter URL: https://github.com/apache/flink/pull/7163#discussion_r235857546 ## File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache

[GitHub] XuQianJin-Stars commented on issue #7155: [FLINK-10009] [table] Fix the casting problem for function TIMESTAMPADD in Table

2018-11-22 Thread GitBox
XuQianJin-Stars commented on issue #7155: [FLINK-10009] [table] Fix the casting problem for function TIMESTAMPADD in Table URL: https://github.com/apache/flink/pull/7155#issuecomment-441167275 hi @sunjincheng121 @wuchong I have just tested calcite, and found that the parsing `timestampa

[jira] [Commented] (FLINK-10471) State TTL cleanup using RocksDb compaction filter

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696432#comment-16696432 ] ASF GitHub Bot commented on FLINK-10471: Aitozi commented on a change in pull re

[jira] [Commented] (FLINK-9477) Support SQL 2016 JSON functions in Flink SQL

2018-11-22 Thread Shuyi Chen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696440#comment-16696440 ] Shuyi Chen commented on FLINK-9477: --- Thanks [~x1q1j1]. Once Calcite 1.18 is released an

[jira] [Commented] (FLINK-10471) State TTL cleanup using RocksDb compaction filter

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696434#comment-16696434 ] ASF GitHub Bot commented on FLINK-10471: Aitozi commented on a change in pull re

[GitHub] Aitozi commented on a change in pull request #7163: [FLINK-10471][State TTL] State TTL cleanup using RocksDb compaction filter

2018-11-22 Thread GitBox
Aitozi commented on a change in pull request #7163: [FLINK-10471][State TTL] State TTL cleanup using RocksDb compaction filter URL: https://github.com/apache/flink/pull/7163#discussion_r235855216 ## File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache

[GitHub] Aitozi commented on a change in pull request #7163: [FLINK-10471][State TTL] State TTL cleanup using RocksDb compaction filter

2018-11-22 Thread GitBox
Aitozi commented on a change in pull request #7163: [FLINK-10471][State TTL] State TTL cleanup using RocksDb compaction filter URL: https://github.com/apache/flink/pull/7163#discussion_r235855263 ## File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache

[jira] [Commented] (FLINK-10471) State TTL cleanup using RocksDb compaction filter

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696430#comment-16696430 ] ASF GitHub Bot commented on FLINK-10471: Aitozi commented on a change in pull re

[GitHub] Aitozi commented on a change in pull request #7163: [FLINK-10471][State TTL] State TTL cleanup using RocksDb compaction filter

2018-11-22 Thread GitBox
Aitozi commented on a change in pull request #7163: [FLINK-10471][State TTL] State TTL cleanup using RocksDb compaction filter URL: https://github.com/apache/flink/pull/7163#discussion_r235855216 ## File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache

[jira] [Updated] (FLINK-10653) Introduce Pluggable Shuffle Manager Architecture

2018-11-22 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhijiang updated FLINK-10653: - Summary: Introduce Pluggable Shuffle Manager Architecture (was: Fine-grained Shuffle System) > Introdu

[jira] [Commented] (FLINK-8577) Implement proctime DataStream to Table upsert conversion.

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696411#comment-16696411 ] ASF GitHub Bot commented on FLINK-8577: --- hequn8128 commented on a change in pull re

[jira] [Updated] (FLINK-10653) Fine-grained Shuffle System

2018-11-22 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhijiang updated FLINK-10653: - Affects Version/s: (was: 2.0.0) > Fine-grained Shuffle System > --- > >

[jira] [Updated] (FLINK-10653) Fine-grained Shuffle System

2018-11-22 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhijiang updated FLINK-10653: - Description: This is the umbrella issue for improving shuffle architecture. Shuffle is the process of d

[GitHub] hequn8128 commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2018-11-22 Thread GitBox
hequn8128 commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r235852606 ## File path: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/r

[jira] [Updated] (FLINK-10653) Fine-grained Shuffle System

2018-11-22 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhijiang updated FLINK-10653: - Fix Version/s: 2.0.0 > Fine-grained Shuffle System > --- > > Key

[jira] [Closed] (FLINK-8477) Add api to support for user to skip the first incomplete window data

2018-11-22 Thread aitozi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] aitozi closed FLINK-8477. - Resolution: Won't Fix > Add api to support for user to skip the first incomplete window data > --

[jira] [Commented] (FLINK-8577) Implement proctime DataStream to Table upsert conversion.

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696399#comment-16696399 ] ASF GitHub Bot commented on FLINK-8577: --- dianfu commented on a change in pull reque

[jira] [Commented] (FLINK-8577) Implement proctime DataStream to Table upsert conversion.

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696398#comment-16696398 ] ASF GitHub Bot commented on FLINK-8577: --- dianfu commented on a change in pull reque

[GitHub] dianfu commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2018-11-22 Thread GitBox
dianfu commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r235850176 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runt

[GitHub] dianfu commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2018-11-22 Thread GitBox
dianfu commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r235849985 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan

[jira] [Closed] (FLINK-10343) Expose setCurrentKey method to streamRuntimeContext

2018-11-22 Thread aitozi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] aitozi closed FLINK-10343. -- Resolution: Won't Fix > Expose setCurrentKey method to streamRuntimeContext >

[jira] [Commented] (FLINK-10009) Fix the casting problem for function TIMESTAMPADD in Table

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696386#comment-16696386 ] ASF GitHub Bot commented on FLINK-10009: XuQianJin-Stars removed a comment on is

[GitHub] XuQianJin-Stars removed a comment on issue #7155: [FLINK-10009] [table] Fix the casting problem for function TIMESTAMPADD in Table

2018-11-22 Thread GitBox
XuQianJin-Stars removed a comment on issue #7155: [FLINK-10009] [table] Fix the casting problem for function TIMESTAMPADD in Table URL: https://github.com/apache/flink/pull/7155#issuecomment-441156439 @sunjincheng121 I have just tested calcite, and found that the parsing `timestampadd(MINU

[jira] [Commented] (FLINK-10009) Fix the casting problem for function TIMESTAMPADD in Table

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696383#comment-16696383 ] ASF GitHub Bot commented on FLINK-10009: XuQianJin-Stars edited a comment on iss

[jira] [Commented] (FLINK-8577) Implement proctime DataStream to Table upsert conversion.

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696382#comment-16696382 ] ASF GitHub Bot commented on FLINK-8577: --- hequn8128 commented on a change in pull re

[GitHub] XuQianJin-Stars edited a comment on issue #7155: [FLINK-10009] [table] Fix the casting problem for function TIMESTAMPADD in Table

2018-11-22 Thread GitBox
XuQianJin-Stars edited a comment on issue #7155: [FLINK-10009] [table] Fix the casting problem for function TIMESTAMPADD in Table URL: https://github.com/apache/flink/pull/7155#issuecomment-441156439 @sunjincheng121 I have just tested calcite, and found that the parsing `timestampadd(MINUT

[GitHub] hequn8128 commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2018-11-22 Thread GitBox
hequn8128 commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r235847810 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/r

[GitHub] XuQianJin-Stars commented on issue #7155: [FLINK-10009] [table] Fix the casting problem for function TIMESTAMPADD in Table

2018-11-22 Thread GitBox
XuQianJin-Stars commented on issue #7155: [FLINK-10009] [table] Fix the casting problem for function TIMESTAMPADD in Table URL: https://github.com/apache/flink/pull/7155#issuecomment-441156439 @sunjincheng121 I have just tested calcite, and found that the parsing `timestampadd(MINUTE, 1, t

[jira] [Commented] (FLINK-10009) Fix the casting problem for function TIMESTAMPADD in Table

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696381#comment-16696381 ] ASF GitHub Bot commented on FLINK-10009: XuQianJin-Stars commented on issue #715

[jira] [Commented] (FLINK-10929) Add support for Apache Arrow

2018-11-22 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696351#comment-16696351 ] vinoyang commented on FLINK-10929: -- Hi [~fhueske]  I believe that Flink Streaming will

[jira] [Commented] (FLINK-10958) Add overload support for user defined function

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696347#comment-16696347 ] ASF GitHub Bot commented on FLINK-10958: sunjincheng121 commented on issue #7152

[jira] [Commented] (FLINK-10009) Fix the casting problem for function TIMESTAMPADD in Table

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696350#comment-16696350 ] ASF GitHub Bot commented on FLINK-10009: sunjincheng121 commented on issue #7155

[GitHub] sunjincheng121 commented on issue #7155: [FLINK-10009] [table] Fix the casting problem for function TIMESTAMPADD in Table

2018-11-22 Thread GitBox
sunjincheng121 commented on issue #7155: [FLINK-10009] [table] Fix the casting problem for function TIMESTAMPADD in Table URL: https://github.com/apache/flink/pull/7155#issuecomment-441149693 Yes @XuQianJin-Stars you are right! I think after you update the PR. It's good to merged!

[jira] [Commented] (FLINK-10009) Fix the casting problem for function TIMESTAMPADD in Table

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696348#comment-16696348 ] ASF GitHub Bot commented on FLINK-10009: XuQianJin-Stars commented on issue #715

[jira] [Updated] (FLINK-10990) Pre-check timespan in meterview to avoid NAN

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10990: --- Labels: pull-request-available (was: ) > Pre-check timespan in meterview to avoid NAN > ---

[GitHub] XuQianJin-Stars commented on issue #7155: [FLINK-10009] [table] Fix the casting problem for function TIMESTAMPADD in Table

2018-11-22 Thread GitBox
XuQianJin-Stars commented on issue #7155: [FLINK-10009] [table] Fix the casting problem for function TIMESTAMPADD in Table URL: https://github.com/apache/flink/pull/7155#issuecomment-441149457 @sunjincheng121 Thank you very much. Yes, my logic does not support time now. I think what you pr

[GitHub] sunjincheng121 commented on issue #7152: [FLINK-10958] [table] Add overload support for user defined function

2018-11-22 Thread GitBox
sunjincheng121 commented on issue #7152: [FLINK-10958] [table] Add overload support for user defined function URL: https://github.com/apache/flink/pull/7152#issuecomment-441149059 @dianfu Thanks for the update! I think the PR is in a good shape. +1 to merged. Best, Jincheng --

[jira] [Commented] (FLINK-10009) Fix the casting problem for function TIMESTAMPADD in Table

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696344#comment-16696344 ] ASF GitHub Bot commented on FLINK-10009: wuchong commented on issue #7155: [FLIN

[GitHub] wuchong commented on issue #7155: [FLINK-10009] [table] Fix the casting problem for function TIMESTAMPADD in Table

2018-11-22 Thread GitBox
wuchong commented on issue #7155: [FLINK-10009] [table] Fix the casting problem for function TIMESTAMPADD in Table URL: https://github.com/apache/flink/pull/7155#issuecomment-441148554 Thanks for the work @XuQianJin-Stars , the commit looks good to me.

[jira] [Commented] (FLINK-10990) Pre-check timespan in meterview to avoid NAN

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696343#comment-16696343 ] ASF GitHub Bot commented on FLINK-10990: Aitozi commented on issue #7165: [FLINK

[GitHub] Aitozi opened a new pull request #7165: [FLINK-10990][Metric]Pre-check timespan in meterview to avoid NAN

2018-11-22 Thread GitBox
Aitozi opened a new pull request #7165: [FLINK-10990][Metric]Pre-check timespan in meterview to avoid NAN URL: https://github.com/apache/flink/pull/7165 ## What is the purpose of the change In the metric tool MeterView. If user use the meterview with the timespan smaller than UPDATE

[jira] [Commented] (FLINK-10990) Pre-check timespan in meterview to avoid NAN

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696341#comment-16696341 ] ASF GitHub Bot commented on FLINK-10990: Aitozi opened a new pull request #7165:

[GitHub] Aitozi commented on issue #7165: [FLINK-10990][Metric]Pre-check timespan in meterview to avoid NAN

2018-11-22 Thread GitBox
Aitozi commented on issue #7165: [FLINK-10990][Metric]Pre-check timespan in meterview to avoid NAN URL: https://github.com/apache/flink/pull/7165#issuecomment-441148480 cc @zentol This is an automated message from the Apache

[jira] [Commented] (FLINK-10009) Fix the casting problem for function TIMESTAMPADD in Table

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696340#comment-16696340 ] ASF GitHub Bot commented on FLINK-10009: sunjincheng121 commented on issue #7155

[GitHub] sunjincheng121 commented on issue #7155: [FLINK-10009] [table] Fix the casting problem for function TIMESTAMPADD in Table

2018-11-22 Thread GitBox
sunjincheng121 commented on issue #7155: [FLINK-10009] [table] Fix the casting problem for function TIMESTAMPADD in Table URL: https://github.com/apache/flink/pull/7155#issuecomment-441148157 @XuQianJin-Stars Thanks for the PR! The changes looks good to me. Here hope you can do one m

[jira] [Updated] (FLINK-10972) Enhancements to Flink Table API

2018-11-22 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-10972: Description: With the continuous efforts from the community, the Flink system has been continuous

[jira] [Commented] (FLINK-10958) Add overload support for user defined function

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696333#comment-16696333 ] ASF GitHub Bot commented on FLINK-10958: dianfu commented on issue #7152: [FLINK

[GitHub] dianfu commented on issue #7152: [FLINK-10958] [table] Add overload support for user defined function

2018-11-22 Thread GitBox
dianfu commented on issue #7152: [FLINK-10958] [table] Add overload support for user defined function URL: https://github.com/apache/flink/pull/7152#issuecomment-441146732 @sunjincheng121 thanks a lot for the review. I have updated the PR according to your comments. Could you help to take

[jira] [Commented] (FLINK-10009) Fix the casting problem for function TIMESTAMPADD in Table

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696321#comment-16696321 ] ASF GitHub Bot commented on FLINK-10009: XuQianJin-Stars commented on issue #715

[GitHub] XuQianJin-Stars commented on issue #7155: [FLINK-10009] [table] Fix the casting problem for function TIMESTAMPADD in Table

2018-11-22 Thread GitBox
XuQianJin-Stars commented on issue #7155: [FLINK-10009] [table] Fix the casting problem for function TIMESTAMPADD in Table URL: https://github.com/apache/flink/pull/7155#issuecomment-441142981 @twalthr Thank you very much for helping me modify the title of this PR. Could you help me check

[jira] [Commented] (FLINK-8577) Implement proctime DataStream to Table upsert conversion.

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696312#comment-16696312 ] ASF GitHub Bot commented on FLINK-8577: --- hequn8128 commented on a change in pull re

[jira] [Commented] (FLINK-8577) Implement proctime DataStream to Table upsert conversion.

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696315#comment-16696315 ] ASF GitHub Bot commented on FLINK-8577: --- hequn8128 commented on a change in pull re

[GitHub] hequn8128 commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2018-11-22 Thread GitBox
hequn8128 commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r235835509 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/p

[jira] [Commented] (FLINK-8577) Implement proctime DataStream to Table upsert conversion.

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696311#comment-16696311 ] ASF GitHub Bot commented on FLINK-8577: --- hequn8128 commented on a change in pull re

[GitHub] hequn8128 commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2018-11-22 Thread GitBox
hequn8128 commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r235835262 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/c

[GitHub] hequn8128 commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2018-11-22 Thread GitBox
hequn8128 commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r235835262 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/c

[jira] [Commented] (FLINK-10992) Jepsen: Do not use /tmp as HDFS Data Directory

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696290#comment-16696290 ] ASF GitHub Bot commented on FLINK-10992: GJL opened a new pull request #7164: [F

[GitHub] GJL opened a new pull request #7164: [FLINK-10992][tests] Revise Hadoop configuration.

2018-11-22 Thread GitBox
GJL opened a new pull request #7164: [FLINK-10992][tests] Revise Hadoop configuration. URL: https://github.com/apache/flink/pull/7164 ## What is the purpose of the change Revise Hadoop configuration to improve HDFS stability in tests. ## Brief change log - *Do not use /tm

[jira] [Updated] (FLINK-10992) Jepsen: Do not use /tmp as HDFS Data Directory

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10992: --- Labels: pull-request-available (was: ) > Jepsen: Do not use /tmp as HDFS Data Directory > -

[jira] [Updated] (FLINK-10992) Jepsen: Do not use /tmp as HDFS Data Directory

2018-11-22 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao updated FLINK-10992: - Affects Version/s: 1.8.0 > Jepsen: Do not use /tmp as HDFS Data Directory >

[jira] [Closed] (FLINK-10951) Disable enforcing of YARN container virtual memory limits in tests

2018-11-22 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao closed FLINK-10951. Resolution: Fixed Fixed via 1.8 33f3de010c59897e9ec9277484195e2845e8a5f6 1.7 70623d3f7f40f382bca26b3ba8c9c

[jira] [Commented] (FLINK-10951) Disable enforcing of YARN container virtual memory limits in tests

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696266#comment-16696266 ] ASF GitHub Bot commented on FLINK-10951: GJL closed pull request #7149: [FLINK-1

[GitHub] GJL closed pull request #7149: [FLINK-10951][tests] Set yarn.nodemanager.vmem-check-enabled to false

2018-11-22 Thread GitBox
GJL closed pull request #7149: [FLINK-10951][tests] Set yarn.nodemanager.vmem-check-enabled to false URL: https://github.com/apache/flink/pull/7149 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[jira] [Created] (FLINK-10992) Jepsen: Do not use /tmp as HDFS Data Directory

2018-11-22 Thread Gary Yao (JIRA)
Gary Yao created FLINK-10992: Summary: Jepsen: Do not use /tmp as HDFS Data Directory Key: FLINK-10992 URL: https://issues.apache.org/jira/browse/FLINK-10992 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-4582) Allow FlinkKinesisConsumer to adapt for AWS DynamoDB Streams

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696228#comment-16696228 ] ASF GitHub Bot commented on FLINK-4582: --- yxu-valleytider commented on issue #6968:

[GitHub] yxu-valleytider commented on issue #6968: [FLINK-4582] [kinesis] Consuming data from DynamoDB streams to flink

2018-11-22 Thread GitBox
yxu-valleytider commented on issue #6968: [FLINK-4582] [kinesis] Consuming data from DynamoDB streams to flink URL: https://github.com/apache/flink/pull/6968#issuecomment-44240 Adjusted package name based on comments. PTAL @tweise @tzulitai

[jira] [Commented] (FLINK-10971) Dependency convergence issue when building flink-s3-fs-presto

2018-11-22 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696220#comment-16696220 ] Ufuk Celebi commented on FLINK-10971: - Since the RC is not suffering from this probl

[jira] [Commented] (FLINK-10471) State TTL cleanup using RocksDb compaction filter

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696212#comment-16696212 ] ASF GitHub Bot commented on FLINK-10471: azagrebin opened a new pull request #71

[jira] [Updated] (FLINK-10471) State TTL cleanup using RocksDb compaction filter

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10471: --- Labels: pull-request-available (was: ) > State TTL cleanup using RocksDb compaction filter

[GitHub] azagrebin opened a new pull request #7163: [FLINK-10471][State TTL] State TTL cleanup using RocksDb compaction filter

2018-11-22 Thread GitBox
azagrebin opened a new pull request #7163: [FLINK-10471][State TTL] State TTL cleanup using RocksDb compaction filter URL: https://github.com/apache/flink/pull/7163 ## What is the purpose of the change This PR introduces a Flink specific RocksDb compaction filter to clean up expired

[jira] [Updated] (FLINK-10991) Dockerfile in flink-container does not work with RocksDBStatebackend

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10991: --- Labels: pull-request-available (was: ) > Dockerfile in flink-container does not work with R

[jira] [Commented] (FLINK-10991) Dockerfile in flink-container does not work with RocksDBStatebackend

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696188#comment-16696188 ] ASF GitHub Bot commented on FLINK-10991: knaufk opened a new pull request #7162:

[GitHub] knaufk opened a new pull request #7162: FLINK-10991 [docker] Added libc6-compat package to all alpine-based Flink imag…

2018-11-22 Thread GitBox
knaufk opened a new pull request #7162: FLINK-10991 [docker] Added libc6-compat package to all alpine-based Flink imag… URL: https://github.com/apache/flink/pull/7162 ## What is the purpose of the change Flink images based on Dockerfile in the Flink repository should work with Rocks

[jira] [Created] (FLINK-10991) Dockerfile in flink-container does not work with RocksDBStatebackend

2018-11-22 Thread Konstantin Knauf (JIRA)
Konstantin Knauf created FLINK-10991: Summary: Dockerfile in flink-container does not work with RocksDBStatebackend Key: FLINK-10991 URL: https://issues.apache.org/jira/browse/FLINK-10991 Project:

[jira] [Commented] (FLINK-10842) Waiting loops are broken in e2e/common.sh

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696161#comment-16696161 ] ASF GitHub Bot commented on FLINK-10842: azagrebin commented on a change in pull

[GitHub] azagrebin commented on a change in pull request #7073: [FLINK-10842][E2E tests] fix broken waiting loops in common.sh

2018-11-22 Thread GitBox
azagrebin commented on a change in pull request #7073: [FLINK-10842][E2E tests] fix broken waiting loops in common.sh URL: https://github.com/apache/flink/pull/7073#discussion_r235796341 ## File path: flink-end-to-end-tests/test-scripts/common.sh ## @@ -242,30 +245,45 @@ f

[jira] [Commented] (FLINK-10452) Expose Additional Metrics to Reason about Statesize

2018-11-22 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696156#comment-16696156 ] Steven Zhen Wu commented on FLINK-10452: I saw two tickets that I filed are mark

[jira] [Created] (FLINK-10990) Pre-check timespan in meterview to avoid NAN

2018-11-22 Thread aitozi (JIRA)
aitozi created FLINK-10990: -- Summary: Pre-check timespan in meterview to avoid NAN Key: FLINK-10990 URL: https://issues.apache.org/jira/browse/FLINK-10990 Project: Flink Issue Type: Bug Co

[jira] [Updated] (FLINK-10989) OrcRowInputFormat uses two different file systems

2018-11-22 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-10989: -- Description: The {{OrcRowInputFormat}} seems to use two different {{FileSystem}}. The Flink {

[jira] [Created] (FLINK-10989) OrcRowInputFormat uses two different file systems

2018-11-22 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-10989: - Summary: OrcRowInputFormat uses two different file systems Key: FLINK-10989 URL: https://issues.apache.org/jira/browse/FLINK-10989 Project: Flink Issue Typ

[jira] [Created] (FLINK-10988) Improve debugging / visibility of job state

2018-11-22 Thread Scott Sue (JIRA)
Scott Sue created FLINK-10988: - Summary: Improve debugging / visibility of job state Key: FLINK-10988 URL: https://issues.apache.org/jira/browse/FLINK-10988 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-10842) Waiting loops are broken in e2e/common.sh

2018-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696053#comment-16696053 ] ASF GitHub Bot commented on FLINK-10842: twalthr commented on a change in pull r

  1   2   3   >