[GitHub] [flink] twalthr commented on a change in pull request #8360: [FLINK-12393][table-common] Add the user-facing classes of the new type system

2019-05-08 Thread GitBox
twalthr commented on a change in pull request #8360: [FLINK-12393][table-common] Add the user-facing classes of the new type system URL: https://github.com/apache/flink/pull/8360#discussion_r282347087 ## File path:

[jira] [Assigned] (FLINK-9410) Replace NMClient with NMClientAsync in YarnResourceManager

2019-05-08 Thread zhangminglei (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangminglei reassigned FLINK-9410: --- Assignee: zhangminglei (was: lihongli) > Replace NMClient with NMClientAsync in

[jira] [Created] (FLINK-12456) Wrong CharType convertion in type_utils.py

2019-05-08 Thread Jingsong Lee (JIRA)
Jingsong Lee created FLINK-12456: Summary: Wrong CharType convertion in type_utils.py Key: FLINK-12456 URL: https://issues.apache.org/jira/browse/FLINK-12456 Project: Flink Issue Type: Bug

[GitHub] [flink] wuchong commented on issue #8376: [FLINK-12392] [table-planner-blink] Port FlinkRelMetadataQuery into Java to avoid compiling error with Scala 2.12

2019-05-08 Thread GitBox
wuchong commented on issue #8376: [FLINK-12392] [table-planner-blink] Port FlinkRelMetadataQuery into Java to avoid compiling error with Scala 2.12 URL: https://github.com/apache/flink/pull/8376#issuecomment-490752948 Thanks for digging into this. LGTM. Will merge after

[GitHub] [flink] flinkbot commented on issue #8377: [FLINK-12455][python] Move the packaging of pyflink to flink-dist

2019-05-08 Thread GitBox
flinkbot commented on issue #8377: [FLINK-12455][python] Move the packaging of pyflink to flink-dist URL: https://github.com/apache/flink/pull/8377#issuecomment-490752300 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review

[jira] [Updated] (FLINK-12455) Move the packaging of pyflink to flink-dist

2019-05-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12455: --- Labels: pull-request-available (was: ) > Move the packaging of pyflink to flink-dist >

[GitHub] [flink] dianfu opened a new pull request #8377: [FLINK-12455][python] Move the packaging of pyflink to flink-dist

2019-05-08 Thread GitBox
dianfu opened a new pull request #8377: [FLINK-12455][python] Move the packaging of pyflink to flink-dist URL: https://github.com/apache/flink/pull/8377 ## What is the purpose of the change *This pull request moves the packaging of pyflink to flink-dist for the following reasons: *

[jira] [Updated] (FLINK-12455) Move the packaging of pyflink to flink-dist

2019-05-08 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated FLINK-12455: Summary: Move the packaging of pyflink to flink-dist (was: Move the package of pyflink to flink-dist) >

[GitHub] [flink] bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282339745 ## File path:

[GitHub] [flink] bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282339745 ## File path:

[GitHub] [flink] bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282337775 ## File path:

[GitHub] [flink] bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282339745 ## File path:

[GitHub] [flink] bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282337926 ## File path:

[GitHub] [flink] bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282337926 ## File path:

[GitHub] [flink] bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282337775 ## File path:

[GitHub] [flink] HuangZhenQiu commented on issue #8303: [FLINK-12343]add file replication config for yarn configuration

2019-05-08 Thread GitBox
HuangZhenQiu commented on issue #8303: [FLINK-12343]add file replication config for yarn configuration URL: https://github.com/apache/flink/pull/8303#issuecomment-490741884 @xintongsong @tillrohrmann @rmetzger Thanks for the informative comments. The verified the solution end to end.

[jira] [Created] (FLINK-12455) Move the package of pyflink to flink-dist

2019-05-08 Thread Dian Fu (JIRA)
Dian Fu created FLINK-12455: --- Summary: Move the package of pyflink to flink-dist Key: FLINK-12455 URL: https://issues.apache.org/jira/browse/FLINK-12455 Project: Flink Issue Type: Sub-task

[GitHub] [flink] wuchong commented on a change in pull request #8360: [FLINK-12393][table-common] Add the user-facing classes of the new type system

2019-05-08 Thread GitBox
wuchong commented on a change in pull request #8360: [FLINK-12393][table-common] Add the user-facing classes of the new type system URL: https://github.com/apache/flink/pull/8360#discussion_r282335432 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #8360: [FLINK-12393][table-common] Add the user-facing classes of the new type system

2019-05-08 Thread GitBox
wuchong commented on a change in pull request #8360: [FLINK-12393][table-common] Add the user-facing classes of the new type system URL: https://github.com/apache/flink/pull/8360#discussion_r282334560 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #8360: [FLINK-12393][table-common] Add the user-facing classes of the new type system

2019-05-08 Thread GitBox
wuchong commented on a change in pull request #8360: [FLINK-12393][table-common] Add the user-facing classes of the new type system URL: https://github.com/apache/flink/pull/8360#discussion_r282334300 ## File path:

[GitHub] [flink] chunweilei commented on a change in pull request #8266: [FLINK-9904]Allow users to control MaxDirectMemorySize

2019-05-08 Thread GitBox
chunweilei commented on a change in pull request #8266: [FLINK-9904]Allow users to control MaxDirectMemorySize URL: https://github.com/apache/flink/pull/8266#discussion_r282333076 ## File path: flink-dist/src/main/flink-bin/bin/config.sh ## @@ -429,6 +430,11 @@ if [ -z

[GitHub] [flink] eaglewatcherwb edited a comment on issue #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy

2019-05-08 Thread GitBox
eaglewatcherwb edited a comment on issue #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy URL: https://github.com/apache/flink/pull/8309#issuecomment-490734729 Hi, @GJL @tillrohrmann , I have updated the PR based on the latest master. Would you mind to begin

[GitHub] [flink] eaglewatcherwb edited a comment on issue #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy

2019-05-08 Thread GitBox
eaglewatcherwb edited a comment on issue #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy URL: https://github.com/apache/flink/pull/8309#issuecomment-490734729 Hi, @GJL @tillrohrmann , I have updated the PR based on the latest master. Would you mind to begin

[jira] [Updated] (FLINK-12454) Add custom check options for lint-python.sh

2019-05-08 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-12454: Labels: (was: Python) > Add custom check options for lint-python.sh >

[jira] [Updated] (FLINK-12454) Add custom check options for lint-python.sh

2019-05-08 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-12454: Labels: Python (was: ) > Add custom check options for lint-python.sh >

[jira] [Updated] (FLINK-12454) Add custom check options for lint-python.sh

2019-05-08 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-12454: Description: At present, int-python.sh has Python compatibility checks and code style checks. By

[jira] [Created] (FLINK-12454) Add custom check options for lint-python.sh

2019-05-08 Thread sunjincheng (JIRA)
sunjincheng created FLINK-12454: --- Summary: Add custom check options for lint-python.sh Key: FLINK-12454 URL: https://issues.apache.org/jira/browse/FLINK-12454 Project: Flink Issue Type:

[GitHub] [flink] eaglewatcherwb commented on issue #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy

2019-05-08 Thread GitBox
eaglewatcherwb commented on issue #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy URL: https://github.com/apache/flink/pull/8309#issuecomment-490734729 Hi, @GJL @tillrohrmann , I have updated the PR based on the latest master. Would you mind to begin another

[GitHub] [flink] eaglewatcherwb edited a comment on issue #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy

2019-05-08 Thread GitBox
eaglewatcherwb edited a comment on issue #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy URL: https://github.com/apache/flink/pull/8309#issuecomment-490734729 Hi, @GJL @tillrohrmann , I have updated the PR based on the latest master. Would you mind to begin

[GitHub] [flink] godfreyhe opened a new pull request #8376: [FLINK-12392] [table-planner-blink] Port FlinkRelMetadataQuery into Java to avoid compiling error with Scala 2.12

2019-05-08 Thread GitBox
godfreyhe opened a new pull request #8376: [FLINK-12392] [table-planner-blink] Port FlinkRelMetadataQuery into Java to avoid compiling error with Scala 2.12 URL: https://github.com/apache/flink/pull/8376 ## What is the purpose of the change *Port FlinkRelMetadataQuery into Java

[jira] [Updated] (FLINK-12392) FlinkRelMetadataQuery does not compile with Scala 2.12

2019-05-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12392: --- Labels: pull-request-available (was: ) > FlinkRelMetadataQuery does not compile with Scala

[GitHub] [flink] flinkbot commented on issue #8376: [FLINK-12392] [table-planner-blink] Port FlinkRelMetadataQuery into Java to avoid compiling error with Scala 2.12

2019-05-08 Thread GitBox
flinkbot commented on issue #8376: [FLINK-12392] [table-planner-blink] Port FlinkRelMetadataQuery into Java to avoid compiling error with Scala 2.12 URL: https://github.com/apache/flink/pull/8376#issuecomment-490732935 Thanks a lot for your contribution to the Apache Flink project. I'm the

[jira] [Assigned] (FLINK-12392) FlinkRelMetadataQuery does not compile with Scala 2.12

2019-05-08 Thread godfrey he (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he reassigned FLINK-12392: -- Assignee: godfrey he > FlinkRelMetadataQuery does not compile with Scala 2.12 >

[GitHub] [flink] wenhuitang commented on issue #7805: [FLINK-11697] Add readMapReduceTextFile API for HadoopInputs.

2019-05-08 Thread GitBox
wenhuitang commented on issue #7805: [FLINK-11697] Add readMapReduceTextFile API for HadoopInputs. URL: https://github.com/apache/flink/pull/7805#issuecomment-490729884 Open another PR(https://github.com/apache/flink/pull/8375) due to this pr from unknown repository. So close this one.

[GitHub] [flink] flinkbot commented on issue #8375: [FLINK-11697] Add readMapReduceTextFile API for HadoopInputs.

2019-05-08 Thread GitBox
flinkbot commented on issue #8375: [FLINK-11697] Add readMapReduceTextFile API for HadoopInputs. URL: https://github.com/apache/flink/pull/8375#issuecomment-490729901 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your

[GitHub] [flink] wenhuitang closed pull request #7805: [FLINK-11697] Add readMapReduceTextFile API for HadoopInputs.

2019-05-08 Thread GitBox
wenhuitang closed pull request #7805: [FLINK-11697] Add readMapReduceTextFile API for HadoopInputs. URL: https://github.com/apache/flink/pull/7805 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] wenhuitang opened a new pull request #8375: [FLINK-11697] Add readMapReduceTextFile API for HadoopInputs.

2019-05-08 Thread GitBox
wenhuitang opened a new pull request #8375: [FLINK-11697] Add readMapReduceTextFile API for HadoopInputs. URL: https://github.com/apache/flink/pull/8375 ## What is the purpose of the change This pull request Add readMapReduceTextFile API for HadoopInputs.

[jira] [Updated] (FLINK-12453) StreamExecGlobalGroupAggregate construct wrong args for AggsHandlerCodeGenerator

2019-05-08 Thread Jingsong Lee (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee updated FLINK-12453: - Description: In generateAggsHandler:  val generator = new AggsHandlerCodeGenerator(  

[GitHub] [flink] wenhuitang commented on issue #7810: [FLINK-11698] Add readMapRedTextFile API for HadoopInputs.

2019-05-08 Thread GitBox
wenhuitang commented on issue #7810: [FLINK-11698] Add readMapRedTextFile API for HadoopInputs. URL: https://github.com/apache/flink/pull/7810#issuecomment-490729368 Open another PR(https://github.com/apache/flink/pull/8374) due to this pr from unknown repository. So close this one.

[GitHub] [flink] wenhuitang closed pull request #7810: [FLINK-11698] Add readMapRedTextFile API for HadoopInputs.

2019-05-08 Thread GitBox
wenhuitang closed pull request #7810: [FLINK-11698] Add readMapRedTextFile API for HadoopInputs. URL: https://github.com/apache/flink/pull/7810 This is an automated message from the Apache Git Service. To respond to the

[jira] [Created] (FLINK-12453) StreamExecGlobalGroupAggregate construct wrong args for AggsHandlerCodeGenerator

2019-05-08 Thread Jingsong Lee (JIRA)
Jingsong Lee created FLINK-12453: Summary: StreamExecGlobalGroupAggregate construct wrong args for AggsHandlerCodeGenerator Key: FLINK-12453 URL: https://issues.apache.org/jira/browse/FLINK-12453

[GitHub] [flink] flinkbot commented on issue #8374: [FLINK-11698] Add readMapRedTextFile API for HadoopInputs.

2019-05-08 Thread GitBox
flinkbot commented on issue #8374: [FLINK-11698] Add readMapRedTextFile API for HadoopInputs. URL: https://github.com/apache/flink/pull/8374#issuecomment-490729202 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your

[GitHub] [flink] wenhuitang opened a new pull request #8374: [FLINK-11698] Add readMapRedTextFile API for HadoopInputs.

2019-05-08 Thread GitBox
wenhuitang opened a new pull request #8374: [FLINK-11698] Add readMapRedTextFile API for HadoopInputs. URL: https://github.com/apache/flink/pull/8374 ## What is the purpose of the change This pull request Add readMapRedTextFile API for HadoopInputs.

[GitHub] [flink] xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282322682 ## File path:

[jira] [Assigned] (FLINK-12375) flink-container job jar does not have read permissions

2019-05-08 Thread Yun Tang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang reassigned FLINK-12375: Assignee: Yun Tang > flink-container job jar does not have read permissions >

[GitHub] [flink] xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282321982 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282322716 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282322682 ## File path:

[GitHub] [flink] tianchen92 commented on a change in pull request #8266: [FLINK-9904]Allow users to control MaxDirectMemorySize

2019-05-08 Thread GitBox
tianchen92 commented on a change in pull request #8266: [FLINK-9904]Allow users to control MaxDirectMemorySize URL: https://github.com/apache/flink/pull/8266#discussion_r282321092 ## File path: flink-dist/src/main/flink-bin/bin/config.sh ## @@ -429,6 +430,11 @@ if [ -z

[GitHub] [flink] xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282320563 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282320535 ## File path:

[jira] [Commented] (FLINK-12437) Taskmanager doesn't initiate registration after jobmanager marks it terminated

2019-05-08 Thread Abdul Qadeer (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836032#comment-16836032 ] Abdul Qadeer commented on FLINK-12437: -- [~rmetzger] I don't expect a fix to be made available for

[GitHub] [flink] sunhaibotb edited a comment on issue #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface

2019-05-08 Thread GitBox
sunhaibotb edited a comment on issue #8124: [FLINK-11877] Implement the runtime handling of the InputSelectable interface URL: https://github.com/apache/flink/pull/8124#issuecomment-490388025 @pnowojski , the code has been updated and it relies on the latest version of

[GitHub] [flink] walterddr commented on issue #8324: [FLINK-11921][table] Upgrade to calcite 1.19

2019-05-08 Thread GitBox
walterddr commented on issue #8324: [FLINK-11921][table] Upgrade to calcite 1.19 URL: https://github.com/apache/flink/pull/8324#issuecomment-490712462 @wuchong can you also help take a look at the upgrade? Thanks This is an

[GitHub] [flink] walterddr commented on issue #8324: [FLINK-11921][table] Upgrade to calcite 1.19

2019-05-08 Thread GitBox
walterddr commented on issue #8324: [FLINK-11921][table] Upgrade to calcite 1.19 URL: https://github.com/apache/flink/pull/8324#issuecomment-490712398 @flinkbot attention @wuchong This is an automated message from the

[jira] [Commented] (FLINK-12392) FlinkRelMetadataQuery does not compile with Scala 2.12

2019-05-08 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836018#comment-16836018 ] Jark Wu commented on FLINK-12392: - Sure [~twalthr], we will figure it out today. >

[GitHub] [flink] xuefuz commented on issue #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
xuefuz commented on issue #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#issuecomment-490709606 > @xuefuz @lirui-apache thanks for your review! The build failure is unrelated (python api issue). If there's no more

[GitHub] [flink] bowenli86 commented on issue #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
bowenli86 commented on issue #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#issuecomment-490695098 Rebased to latest master to resolve conflicts. Will wait for a green build before proceeding

[jira] [Closed] (FLINK-12417) Unify ReadableCatalog and ReadableWritableCatalog interfaces to Catalog interface

2019-05-08 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li closed FLINK-12417. Resolution: Fixed merged in 1.9.0: c954780c9fb2c0cc5b3730caff7e99bacbd534ba > Unify ReadableCatalog and

[GitHub] [flink] asfgit closed pull request #8365: [FLINK-12417][table] Unify ReadableCatalog and ReadableWritableCatalog interfaces to Catalog interface

2019-05-08 Thread GitBox
asfgit closed pull request #8365: [FLINK-12417][table] Unify ReadableCatalog and ReadableWritableCatalog interfaces to Catalog interface URL: https://github.com/apache/flink/pull/8365 This is an automated message from the

[GitHub] [flink] bowenli86 commented on issue #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
bowenli86 commented on issue #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#issuecomment-490692748 @xuefuz @lirui-apache thanks for your review! The build failure is unrelated (python api issue). If there's no more

[GitHub] [flink] bowenli86 commented on issue #8365: [FLINK-12417][table] Unify ReadableCatalog and ReadableWritableCatalog interfaces to Catalog interface

2019-05-08 Thread GitBox
bowenli86 commented on issue #8365: [FLINK-12417][table] Unify ReadableCatalog and ReadableWritableCatalog interfaces to Catalog interface URL: https://github.com/apache/flink/pull/8365#issuecomment-490692552 @xuefuz thanks for your review! ReadableCatalog.java is already deleted.

[GitHub] [flink] xuefuz commented on issue #8365: [FLINK-12417][table] Unify ReadableCatalog and ReadableWritableCatalog interfaces to Catalog interface

2019-05-08 Thread GitBox
xuefuz commented on issue #8365: [FLINK-12417][table] Unify ReadableCatalog and ReadableWritableCatalog interfaces to Catalog interface URL: https://github.com/apache/flink/pull/8365#issuecomment-490680574 Yes. Let's delete ReadableCatalog.java and the PR is good to go. Thanks.

[GitHub] [flink] xuefuz commented on issue #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
xuefuz commented on issue #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#issuecomment-490680873 ok. sounds good. thanks. This is an automated message

[GitHub] [flink] bowenli86 edited a comment on issue #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
bowenli86 edited a comment on issue #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#issuecomment-490654662 > Thanks for refactoring the code. It looks much cleaner now. > > However, I still noticed there are

[GitHub] [flink] bowenli86 commented on issue #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
bowenli86 commented on issue #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#issuecomment-490654662 > Thanks for refactoring the code. It looks much cleaner now. > > However, I still noticed there are still a

[GitHub] [flink] bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282251157 ## File path:

[GitHub] [flink] bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282251084 ## File path:

[jira] [Created] (FLINK-12452) alterTable() should ensure existing base table and the new one are of the same type

2019-05-08 Thread Bowen Li (JIRA)
Bowen Li created FLINK-12452: Summary: alterTable() should ensure existing base table and the new one are of the same type Key: FLINK-12452 URL: https://issues.apache.org/jira/browse/FLINK-12452 Project:

[GitHub] [flink] bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282244476 ## File path:

[GitHub] [flink] bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282239896 ## File path:

[GitHub] [flink] bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282238893 ## File path:

[GitHub] [flink] bowenli86 commented on issue #8365: [FLINK-12417][table] Unify ReadableCatalog and ReadableWritableCatalog interfaces to Catalog interface

2019-05-08 Thread GitBox
bowenli86 commented on issue #8365: [FLINK-12417][table] Unify ReadableCatalog and ReadableWritableCatalog interfaces to Catalog interface URL: https://github.com/apache/flink/pull/8365#issuecomment-490639242 > Changes look good to me. However, I wonder if we should get ride of

[GitHub] [flink] StefanRRichter commented on a change in pull request #8361: [FLINK-12434][network] Replace listeners with CompletableFuture in InputGates

2019-05-08 Thread GitBox
StefanRRichter commented on a change in pull request #8361: [FLINK-12434][network] Replace listeners with CompletableFuture in InputGates URL: https://github.com/apache/flink/pull/8361#discussion_r282212329 ## File path:

[GitHub] [flink] StefanRRichter commented on a change in pull request #8361: [FLINK-12434][network] Replace listeners with CompletableFuture in InputGates

2019-05-08 Thread GitBox
StefanRRichter commented on a change in pull request #8361: [FLINK-12434][network] Replace listeners with CompletableFuture in InputGates URL: https://github.com/apache/flink/pull/8361#discussion_r282213460 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282206462 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282205173 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282203125 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282205441 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282203601 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282203452 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282201837 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282199916 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282198787 ## File path:

[jira] [Comment Edited] (FLINK-12381) W/o HA, upon a full restart, checkpointing crashes

2019-05-08 Thread Henrik (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835800#comment-16835800 ] Henrik edited comment on FLINK-12381 at 5/8/19 6:34 PM: Yes, you can see it like

[jira] [Comment Edited] (FLINK-12379) Parallelism in job/GCS/Hadoop: Could not finalize the pending checkpoint

2019-05-08 Thread Henrik (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835505#comment-16835505 ] Henrik edited comment on FLINK-12379 at 5/8/19 6:29 PM: Yes, it's the

[jira] [Commented] (FLINK-12381) W/o HA, upon a full restart, checkpointing crashes

2019-05-08 Thread Henrik (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835800#comment-16835800 ] Henrik commented on FLINK-12381: Yes, you can see it like that (a new cluster), I suppose. So does that

[GitHub] [flink] kisimple commented on issue #7757: [FLINK-11630] Triggers the termination of all running Tasks when shutting down TaskExecutor

2019-05-08 Thread GitBox
kisimple commented on issue #7757: [FLINK-11630] Triggers the termination of all running Tasks when shutting down TaskExecutor URL: https://github.com/apache/flink/pull/7757#issuecomment-490593540 Hi @azagrebin Sorry for the delay, I have addressed your comments, and I haven't reproduced

[GitHub] [flink] bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
bowenli86 commented on a change in pull request #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#discussion_r282181650 ## File path:

[GitHub] [flink] bowenli86 commented on issue #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog

2019-05-08 Thread GitBox
bowenli86 commented on issue #8353: [FLINK-12233][hive] Support table related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8353#issuecomment-490590162 @xuefuz @lirui-apache thanks for your review. please take another look.

[GitHub] [flink] XuQianJin-Stars commented on issue #8300: [FLINK-11638][docs-zh] Translate Savepoints page into Chinese

2019-05-08 Thread GitBox
XuQianJin-Stars commented on issue #8300: [FLINK-11638][docs-zh] Translate Savepoints page into Chinese URL: https://github.com/apache/flink/pull/8300#issuecomment-490584204 hi @klion26 Thank you for your review. I have modified it

[jira] [Commented] (FLINK-10455) Potential Kafka producer leak in case of failures

2019-05-08 Thread Chris Slotterback (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835749#comment-16835749 ] Chris Slotterback commented on FLINK-10455: --- The way I was able to reproduce this was forcing

[jira] [Closed] (FLINK-12448) FlinkKafkaProducer late closure after class loader

2019-05-08 Thread Chris Slotterback (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Slotterback closed FLINK-12448. - Resolution: Duplicate > FlinkKafkaProducer late closure after class loader >

[jira] [Created] (FLINK-12451) [Bitwise Functions] Add BIT_XOR function supported in Table API and SQL

2019-05-08 Thread Zhanchun Zhang (JIRA)
Zhanchun Zhang created FLINK-12451: -- Summary: [Bitwise Functions] Add BIT_XOR function supported in Table API and SQL Key: FLINK-12451 URL: https://issues.apache.org/jira/browse/FLINK-12451 Project:

[jira] [Created] (FLINK-12450) [Bitwise Functions] Add BIT_LSHIFT, BIT_RSHIFT functions supported in Table API and SQL

2019-05-08 Thread Zhanchun Zhang (JIRA)
Zhanchun Zhang created FLINK-12450: -- Summary: [Bitwise Functions] Add BIT_LSHIFT, BIT_RSHIFT functions supported in Table API and SQL Key: FLINK-12450 URL: https://issues.apache.org/jira/browse/FLINK-12450

[jira] [Created] (FLINK-12449) [Bitwise Functions] Add BIT_AND, BIT_OR functions supported in Table API and SQL

2019-05-08 Thread Zhanchun Zhang (JIRA)
Zhanchun Zhang created FLINK-12449: -- Summary: [Bitwise Functions] Add BIT_AND, BIT_OR functions supported in Table API and SQL Key: FLINK-12449 URL: https://issues.apache.org/jira/browse/FLINK-12449

[GitHub] [flink] zhijiangW commented on issue #8242: [FLINK-6227][network] Introduce the DataConsumptionException for downstream task failure

2019-05-08 Thread GitBox
zhijiangW commented on issue #8242: [FLINK-6227][network] Introduce the DataConsumptionException for downstream task failure URL: https://github.com/apache/flink/pull/8242#issuecomment-490529494 Thanks for the further review @tillrohrmann . Let me try to explain above two concerns.

[jira] [Updated] (FLINK-10455) Potential Kafka producer leak in case of failures

2019-05-08 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-10455: -- Fix Version/s: (was: 1.6.3) 1.8.1 1.9.0

[GitHub] [flink] pnowojski commented on a change in pull request #8361: [FLINK-12434][network] Replace listeners with CompletableFuture in InputGates

2019-05-08 Thread GitBox
pnowojski commented on a change in pull request #8361: [FLINK-12434][network] Replace listeners with CompletableFuture in InputGates URL: https://github.com/apache/flink/pull/8361#discussion_r28202 ## File path:

[GitHub] [flink] pnowojski commented on a change in pull request #8361: [FLINK-12434][network] Replace listeners with CompletableFuture in InputGates

2019-05-08 Thread GitBox
pnowojski commented on a change in pull request #8361: [FLINK-12434][network] Replace listeners with CompletableFuture in InputGates URL: https://github.com/apache/flink/pull/8361#discussion_r282110599 ## File path:

  1   2   3   >