[jira] [Commented] (FLINK-12939) Translate "Apache Kafka Connector" page into Chinese

2019-07-18 Thread Jeff Yang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888583#comment-16888583 ] Jeff Yang commented on FLINK-12939: --- Hi, [~jark],[~Tison], If an error occurs with en

[GitHub] [flink] twalthr commented on a change in pull request #9049: [FLINK-13176][SQL CLI] remember current catalog and database in SQL CLI SessionContext

2019-07-18 Thread GitBox
twalthr commented on a change in pull request #9049: [FLINK-13176][SQL CLI] remember current catalog and database in SQL CLI SessionContext URL: https://github.com/apache/flink/pull/9049#discussion_r305222073 ## File path: flink-table/flink-sql-client/src/main/java/org/apache/flink

[jira] [Commented] (FLINK-12249) Type equivalence check fails for Window Aggregates

2019-07-18 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888579#comment-16888579 ] Jark Wu commented on FLINK-12249: - I'm fine with postpone this fixing. But if the fixing

[GitHub] [flink] twalthr commented on a change in pull request #9049: [FLINK-13176][SQL CLI] remember current catalog and database in SQL CLI SessionContext

2019-07-18 Thread GitBox
twalthr commented on a change in pull request #9049: [FLINK-13176][SQL CLI] remember current catalog and database in SQL CLI SessionContext URL: https://github.com/apache/flink/pull/9049#discussion_r305221777 ## File path: flink-table/flink-sql-client/src/test/java/org/apache/flink

[GitHub] [flink] flinkbot commented on issue #9176: [hotfix][client] Fix PreviewPlanEnvironment missing set up field "plan"

2019-07-18 Thread GitBox
flinkbot commented on issue #9176: [hotfix][client] Fix PreviewPlanEnvironment missing set up field "plan" URL: https://github.com/apache/flink/pull/9176#issuecomment-513113444 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to rev

[jira] [Commented] (FLINK-13037) Translate "Concepts -> Glossary" page into Chinese

2019-07-18 Thread Konstantin Knauf (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888577#comment-16888577 ] Konstantin Knauf commented on FLINK-13037: -- [~highfei2...@126.com] Thank you!.

[GitHub] [flink] TisonKun opened a new pull request #9176: [hotfix][client] Fix PreviewPlanEnvironment missing set up field "plan"

2019-07-18 Thread GitBox
TisonKun opened a new pull request #9176: [hotfix][client] Fix PreviewPlanEnvironment missing set up field "plan" URL: https://github.com/apache/flink/pull/9176 ## What is the purpose of the change Fix PreviewPlanEnvironment missing set up field "plan". ## Brief change log

[jira] [Created] (FLINK-13333) Potentially NPE of preview plan functionality

2019-07-18 Thread TisonKun (JIRA)
TisonKun created FLINK-1: Summary: Potentially NPE of preview plan functionality Key: FLINK-1 URL: https://issues.apache.org/jira/browse/FLINK-1 Project: Flink Issue Type: Bug Aff

[GitHub] [flink] wuchong commented on issue #9168: [FLINK-13286][table-api] Port connector related validators to api-java-bridge

2019-07-18 Thread GitBox
wuchong commented on issue #9168: [FLINK-13286][table-api] Port connector related validators to api-java-bridge URL: https://github.com/apache/flink/pull/9168#issuecomment-513111642 Others looks good to me. This is an automa

[GitHub] [flink] wuchong commented on issue #9168: [FLINK-13286][table-api] Port connector related validators to api-java-bridge

2019-07-18 Thread GitBox
wuchong commented on issue #9168: [FLINK-13286][table-api] Port connector related validators to api-java-bridge URL: https://github.com/apache/flink/pull/9168#issuecomment-513111442 Hi @JingsongLi , I think we should also move the corresponding tests to table-api or table-common, because

[jira] [Commented] (FLINK-12249) Type equivalence check fails for Window Aggregates

2019-07-18 Thread godfrey he (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888570#comment-16888570 ] godfrey he commented on FLINK-12249: i and [~hequn8128] found a minimal change way t

[jira] [Created] (FLINK-13332) PackagedProgram#isUsingInteractiveMode implemented error prone

2019-07-18 Thread TisonKun (JIRA)
TisonKun created FLINK-13332: Summary: PackagedProgram#isUsingInteractiveMode implemented error prone Key: FLINK-13332 URL: https://issues.apache.org/jira/browse/FLINK-13332 Project: Flink Issue

[jira] [Resolved] (FLINK-13302) DateTimeUtils.unixDateCeil returns the same value as unixDateFloor does

2019-07-18 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu resolved FLINK-13302. - Resolution: Fixed Fixed in 1.10.0: 763dad49dcfe96fa56fb88da0a4d7d53e148f337 Fixed in 1.9.0: e81bf96af9f1

[jira] [Commented] (FLINK-12249) Type equivalence check fails for Window Aggregates

2019-07-18 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888564#comment-16888564 ] Dawid Wysakowicz commented on FLINK-12249: -- I think this is not a prominent bug

[GitHub] [flink] asfgit closed pull request #9160: FLINK-13302][table-planner] DateTimeUtils.unixDateCeil returns the same value as unixDateFloor does

2019-07-18 Thread GitBox
asfgit closed pull request #9160: FLINK-13302][table-planner] DateTimeUtils.unixDateCeil returns the same value as unixDateFloor does URL: https://github.com/apache/flink/pull/9160 This is an automated message from the Apach

[GitHub] [flink] highfei2011 commented on issue #9173: [FLINK-13037][docs-zh] Translate "Concepts -> Glossary" page into Chinese

2019-07-18 Thread GitBox
highfei2011 commented on issue #9173: [FLINK-13037][docs-zh] Translate "Concepts -> Glossary" page into Chinese URL: https://github.com/apache/flink/pull/9173#issuecomment-513103448 Hi, @wuchong , @TisonKun , Thanks for reminding, I have deleted, please take a look again. ---

[GitHub] [flink] wuchong commented on issue #9160: FLINK-13302][table-planner] DateTimeUtils.unixDateCeil returns the same value as unixDateFloor does

2019-07-18 Thread GitBox
wuchong commented on issue #9160: FLINK-13302][table-planner] DateTimeUtils.unixDateCeil returns the same value as unixDateFloor does URL: https://github.com/apache/flink/pull/9160#issuecomment-513102133 Travis passed: https://travis-ci.com/flink-ci/flink/builds/119598057 Merging --

[jira] [Updated] (FLINK-13314) Correct resultType of some PlannerExpression when operands contains DecimalTypeInfo or BigDecimalTypeInfo in Blink planner

2019-07-18 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young updated FLINK-13314: --- Priority: Blocker (was: Critical) > Correct resultType of some PlannerExpression when operands cont

[jira] [Resolved] (FLINK-13269) copy RelDecorrelator & FlinkFilterJoinRule to flink planner to fix CALCITE-3169 & CALCITE-3170

2019-07-18 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu resolved FLINK-13269. - Resolution: Fixed Fixed in 1.10.0: 32ad3fa960681ffc8c21179b6592f6e0a6875c11 Fixed in 1.9.0: 5bff82205ee2

[jira] [Updated] (FLINK-13271) Add documentation for all the new features of blink planner

2019-07-18 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young updated FLINK-13271: --- Priority: Blocker (was: Critical) > Add documentation for all the new features of blink planner > -

[GitHub] [flink] wuchong commented on issue #9173: [FLINK-13037][docs-zh] Translate "Concepts -> Glossary" page into Chinese

2019-07-18 Thread GitBox
wuchong commented on issue #9173: [FLINK-13037][docs-zh] Translate "Concepts -> Glossary" page into Chinese URL: https://github.com/apache/flink/pull/9173#issuecomment-513100389 I agree with @TisonKun , it would be better to translate the existing file first and then add additional glossar

[GitHub] [flink] flinkbot commented on issue #9175: [FLINK-12038] [test] fix YARNITCase random fail

2019-07-18 Thread GitBox
flinkbot commented on issue #9175: [FLINK-12038] [test] fix YARNITCase random fail URL: https://github.com/apache/flink/pull/9175#issuecomment-513088306 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. W

[jira] [Updated] (FLINK-12038) YARNITCase stalls on travis

2019-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12038: --- Labels: pull-request-available test-stability (was: test-stability) > YARNITCase stalls on

[GitHub] [flink] shuai-xu opened a new pull request #9175: [FLINK-12038] [test] fix YARNITCase random fail

2019-07-18 Thread GitBox
shuai-xu opened a new pull request #9175: [FLINK-12038] [test] fix YARNITCase random fail URL: https://github.com/apache/flink/pull/9175 ## What is the purpose of the change This pr fix that the YARNITCase may random fail due to [YARN-2853](https://issues.apache.org/jira/browse/

[jira] [Updated] (FLINK-13269) copy RelDecorrelator & FlinkFilterJoinRule to flink planner to fix CALCITE-3169 & CALCITE-3170

2019-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-13269: --- Labels: pull-request-available (was: ) > copy RelDecorrelator & FlinkFilterJoinRule to flin

[GitHub] [flink] asfgit closed pull request #9122: [FLINK-13269] [table] copy RelDecorrelator & FlinkFilterJoinRule to flink planner to fix CALCITE-3169 & CALCITE-3170

2019-07-18 Thread GitBox
asfgit closed pull request #9122: [FLINK-13269] [table] copy RelDecorrelator & FlinkFilterJoinRule to flink planner to fix CALCITE-3169 & CALCITE-3170 URL: https://github.com/apache/flink/pull/9122 This is an automated messa

[GitHub] [flink] godfreyhe commented on issue #9083: [FLINK-13116] [table-planner-blink] Supports catalog statistics in blink planner

2019-07-18 Thread GitBox
godfreyhe commented on issue #9083: [FLINK-13116] [table-planner-blink] Supports catalog statistics in blink planner URL: https://github.com/apache/flink/pull/9083#issuecomment-513086622 hi @zentol , this PR is in the 1.9 plan. I hope this PR could merge into 1.9, and that could make the h

[GitHub] [flink] wuchong commented on issue #9113: [FLINK-13222] [runtime] Add documentation for failover strategy option

2019-07-18 Thread GitBox
wuchong commented on issue #9113: [FLINK-13222] [runtime] Add documentation for failover strategy option URL: https://github.com/apache/flink/pull/9113#issuecomment-513086127 Thanks for updating the Chinese documentation as well. It looks good to me. I only left a minor comment about the

[GitHub] [flink] wuchong commented on a change in pull request #9113: [FLINK-13222] [runtime] Add documentation for failover strategy option

2019-07-18 Thread GitBox
wuchong commented on a change in pull request #9113: [FLINK-13222] [runtime] Add documentation for failover strategy option URL: https://github.com/apache/flink/pull/9113#discussion_r305198169 ## File path: docs/dev/task_failure_recovery.zh.md ## @@ -260,4 +265,49 @@ env.s

[jira] [Created] (FLINK-13331) Add TestMiniClusters to maintain cache share cluster between Tests

2019-07-18 Thread Jingsong Lee (JIRA)
Jingsong Lee created FLINK-13331: Summary: Add TestMiniClusters to maintain cache share cluster between Tests Key: FLINK-13331 URL: https://issues.apache.org/jira/browse/FLINK-13331 Project: Flink

[GitHub] [flink] wuchong commented on issue #9122: [FLINK-13269] [table] copy RelDecorrelator & FlinkFilterJoinRule to flink planner to fix CALCITE-3169 & CALCITE-3170

2019-07-18 Thread GitBox
wuchong commented on issue #9122: [FLINK-13269] [table] copy RelDecorrelator & FlinkFilterJoinRule to flink planner to fix CALCITE-3169 & CALCITE-3170 URL: https://github.com/apache/flink/pull/9122#issuecomment-513084773 Thanks @godfreyhe . -

[jira] [Assigned] (FLINK-13330) Remove unnecessary to reduce testing time in blink

2019-07-18 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-13330: --- Assignee: Jingsong Lee > Remove unnecessary to reduce testing time in blink > -

[GitHub] [flink] flinkbot commented on issue #9174: [FLINK-13330][table-planner-blink] Remove unnecessary to reduce testing time in blink

2019-07-18 Thread GitBox
flinkbot commented on issue #9174: [FLINK-13330][table-planner-blink] Remove unnecessary to reduce testing time in blink URL: https://github.com/apache/flink/pull/9174#issuecomment-513082991 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the commu

[jira] [Updated] (FLINK-13330) Remove unnecessary to reduce testing time in blink

2019-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-13330: --- Labels: pull-request-available (was: ) > Remove unnecessary to reduce testing time in blink

[GitHub] [flink] JingsongLi opened a new pull request #9174: [FLINK-13330][table-planner-blink] Remove unnecessary to reduce testing time in blink

2019-07-18 Thread GitBox
JingsongLi opened a new pull request #9174: [FLINK-13330][table-planner-blink] Remove unnecessary to reduce testing time in blink URL: https://github.com/apache/flink/pull/9174 ## What is the purpose of the change Some tests are unnecessary. ## Verifying this change

[jira] [Created] (FLINK-13330) Remove unnecessary to reduce testing time in blink

2019-07-18 Thread Jingsong Lee (JIRA)
Jingsong Lee created FLINK-13330: Summary: Remove unnecessary to reduce testing time in blink Key: FLINK-13330 URL: https://issues.apache.org/jira/browse/FLINK-13330 Project: Flink Issue Type

[jira] [Commented] (FLINK-13318) Blink planner tests failing on Scala 2.12

2019-07-18 Thread godfrey he (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888496#comment-16888496 ] godfrey he commented on FLINK-13318: i fix it now > Blink planner tests failing on

[jira] [Commented] (FLINK-13329) Set env config for sql jobs

2019-07-18 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888493#comment-16888493 ] Jark Wu commented on FLINK-13329: - Hi [~julien1987], do you have any plan about this? B

[GitHub] [flink] zhuzhurk commented on a change in pull request #9113: [FLINK-13222] [runtime] Add documentation for failover strategy option

2019-07-18 Thread GitBox
zhuzhurk commented on a change in pull request #9113: [FLINK-13222] [runtime] Add documentation for failover strategy option URL: https://github.com/apache/flink/pull/9113#discussion_r305193941 ## File path: docs/dev/task_failure_recovery.md ## @@ -264,4 +268,44 @@ The clu

[jira] [Commented] (FLINK-12249) Type equivalence check fails for Window Aggregates

2019-07-18 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888491#comment-16888491 ] Jark Wu commented on FLINK-12249: - What would be the effort if we make `WindowAggregate`

[jira] [Commented] (FLINK-13238) Reduce blink planner's testing time

2019-07-18 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888489#comment-16888489 ] Jark Wu commented on FLINK-13238: - Hi [~lzljs3620320], I assigned it to you. I think we

[jira] [Assigned] (FLINK-13238) Reduce blink planner's testing time

2019-07-18 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-13238: --- Assignee: Jingsong Lee > Reduce blink planner's testing time > ---

[GitHub] [flink] bowenli86 commented on issue #9172: [FLINK-13313][table] create CatalogTableBuilder to support building CatalogTable from descriptors

2019-07-18 Thread GitBox
bowenli86 commented on issue #9172: [FLINK-13313][table] create CatalogTableBuilder to support building CatalogTable from descriptors URL: https://github.com/apache/flink/pull/9172#issuecomment-513079203 cc @twalthr @xuefuz @lirui-apache @zjuwangg -

[GitHub] [flink] JingsongLi commented on a change in pull request #9168: [FLINK-13286][table-api] Port connector related validators to api-java-bridge

2019-07-18 Thread GitBox
JingsongLi commented on a change in pull request #9168: [FLINK-13286][table-api] Port connector related validators to api-java-bridge URL: https://github.com/apache/flink/pull/9168#discussion_r305192167 ## File path: flink-table/flink-table-api-java-bridge/src/main/java/org/apache

[jira] [Comment Edited] (FLINK-13318) Blink planner tests failing on Scala 2.12

2019-07-18 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888486#comment-16888486 ] Jark Wu edited comment on FLINK-13318 at 7/19/19 3:41 AM: -- cc [

[jira] [Commented] (FLINK-13318) Blink planner tests failing on Scala 2.12

2019-07-18 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888486#comment-16888486 ] Jark Wu commented on FLINK-13318: - cc [~godfreyhe] > Blink planner tests failing on Sca

[GitHub] [flink] godfreyhe commented on a change in pull request #9168: [FLINK-13286][table-api] Port connector related validators to api-java-bridge

2019-07-18 Thread GitBox
godfreyhe commented on a change in pull request #9168: [FLINK-13286][table-api] Port connector related validators to api-java-bridge URL: https://github.com/apache/flink/pull/9168#discussion_r305189384 ## File path: flink-table/flink-table-api-java-bridge/src/main/java/org/apache/

[jira] [Commented] (FLINK-12038) YARNITCase stalls on travis

2019-07-18 Thread shuai.xu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888482#comment-16888482 ] shuai.xu commented on FLINK-12038: -- This failure can be easily re-produced in my local

[GitHub] [flink] zjuwangg commented on issue #9130: [FLINK-13274]Refactor HiveTableSourceTest using HiveRunner

2019-07-18 Thread GitBox
zjuwangg commented on issue #9130: [FLINK-13274]Refactor HiveTableSourceTest using HiveRunner URL: https://github.com/apache/flink/pull/9130#issuecomment-513072890 @bowenli86 The [ci build](https://travis-ci.com/flink-ci/flink/jobs/217107050) failed for Kinesis end-to-end test while th

[jira] [Commented] (FLINK-13238) Reduce blink planner's testing time

2019-07-18 Thread Jingsong Lee (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888466#comment-16888466 ] Jingsong Lee commented on FLINK-13238: -- [~ykt836] [~jark] Can you assign this ticke

[GitHub] [flink] zjuwangg commented on issue #9118: [FLINK-13206][sql client]replace `use database xxx` with `use xxx` in sql client parser

2019-07-18 Thread GitBox
zjuwangg commented on issue #9118: [FLINK-13206][sql client]replace `use database xxx` with `use xxx` in sql client parser URL: https://github.com/apache/flink/pull/9118#issuecomment-513070976 @bowenli86 I have tested in my traivs account, there is a failure in blink-planner that is not re

[jira] [Assigned] (FLINK-13321) In Blink Planner, Join a udf with constant arguments or without argument in TableAPI query does not work now

2019-07-18 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-13321: --- Assignee: Jing Zhang > In Blink Planner, Join a udf with constant arguments or without argument in

[GitHub] [flink] godfreyhe commented on issue #9141: [FLINK-12249][table] Fix type equivalence check problems for Window Aggregates

2019-07-18 Thread GitBox
godfreyhe commented on issue #9141: [FLINK-12249][table] Fix type equivalence check problems for Window Aggregates URL: https://github.com/apache/flink/pull/9141#issuecomment-513070691 > @dawidwys Thanks for your comments. I think you are right. > > We had a discussion just now. (wit

[jira] [Commented] (FLINK-13037) Translate "Concepts -> Glossary" page into Chinese

2019-07-18 Thread Jeff Yang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888463#comment-16888463 ] Jeff Yang commented on FLINK-13037: --- Hi,[~jark], Please take a look . [https://github.

[GitHub] [flink] flinkbot commented on issue #9173: [FLINK-13037][docs] Translate "Concepts -> Glossary" page into Chinese

2019-07-18 Thread GitBox
flinkbot commented on issue #9173: [FLINK-13037][docs] Translate "Concepts -> Glossary" page into Chinese URL: https://github.com/apache/flink/pull/9173#issuecomment-513069667 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to revi

[GitHub] [flink] ifndef-SleePy commented on issue #9072: [FLINK-11630] Wait for the termination of all running Tasks when shutting down TaskExecutor

2019-07-18 Thread GitBox
ifndef-SleePy commented on issue #9072: [FLINK-11630] Wait for the termination of all running Tasks when shutting down TaskExecutor URL: https://github.com/apache/flink/pull/9072#issuecomment-513069756 Hi @azagrebin Thank you for explanation. Nice work to take the old PR over! Anyway

[GitHub] [flink] highfei2011 opened a new pull request #9173: [FLINK-13037][docs] Translate "Concepts -> Glossary" page into Chinese

2019-07-18 Thread GitBox
highfei2011 opened a new pull request #9173: [FLINK-13037][docs] Translate "Concepts -> Glossary" page into Chinese URL: https://github.com/apache/flink/pull/9173 ## What is the purpose of the change *Translate "Concepts -> Glossary" page into Chinese.* ## Brief ch

[jira] [Updated] (FLINK-13037) Translate "Concepts -> Glossary" page into Chinese

2019-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-13037: --- Labels: pull-request-available (was: ) > Translate "Concepts -> Glossary" page into Chinese

[jira] [Created] (FLINK-13329) Set env config for sql jobs

2019-07-18 Thread XuPingyong (JIRA)
XuPingyong created FLINK-13329: -- Summary: Set env config for sql jobs Key: FLINK-13329 URL: https://issues.apache.org/jira/browse/FLINK-13329 Project: Flink Issue Type: Task Components

[GitHub] [flink] godfreyhe commented on issue #9146: [FLINK-13284] [table-planner-blink] Correct some builtin functions' r…

2019-07-18 Thread GitBox
godfreyhe commented on issue #9146: [FLINK-13284] [table-planner-blink] Correct some builtin functions' r… URL: https://github.com/apache/flink/pull/9146#issuecomment-513062687 > @godfreyhe @JingsongLi Agree with you that we should offer a deterministic semantic for those 'dirty data', I t

[GitHub] [flink] godfreyhe commented on a change in pull request #9162: [FLINK-13321][table-planner-blink] Fix bug in Blink Planner, Join a udf with constant arguments or without argument in TableAPI

2019-07-18 Thread GitBox
godfreyhe commented on a change in pull request #9162: [FLINK-13321][table-planner-blink] Fix bug in Blink Planner, Join a udf with constant arguments or without argument in TableAPI query does not work now URL: https://github.com/apache/flink/pull/9162#discussion_r305179097 ## Fil

[GitHub] [flink] godfreyhe commented on a change in pull request #9162: [FLINK-13321][table-planner-blink] Fix bug in Blink Planner, Join a udf with constant arguments or without argument in TableAPI

2019-07-18 Thread GitBox
godfreyhe commented on a change in pull request #9162: [FLINK-13321][table-planner-blink] Fix bug in Blink Planner, Join a udf with constant arguments or without argument in TableAPI query does not work now URL: https://github.com/apache/flink/pull/9162#discussion_r305179186 ## Fil

[jira] [Commented] (FLINK-13037) Translate "Concepts -> Glossary" page into Chinese

2019-07-18 Thread Jeff Yang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888433#comment-16888433 ] Jeff Yang commented on FLINK-13037: --- Hi, [~jark] [~knaufk] ,I have aready translated t

[jira] [Closed] (FLINK-12723) Adds a wiki page about setting up a Python Table API development environment

2019-07-18 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng closed FLINK-12723. --- Resolution: Fixed Fix Version/s: 1.9.0 Fixed in master: ee668541c7b39a30f74e44465e686153df191

[jira] [Updated] (FLINK-12723) Adds a wiki page about setting up a Python Table API development environment

2019-07-18 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-12723: Fix Version/s: 1.10.0 > Adds a wiki page about setting up a Python Table API development environme

[GitHub] [flink] xintongsong commented on a change in pull request #9105: [FLINK-13241][Yarn/Mesos] Fix Yarn/MesosResourceManager setting managed memory size into wrong configuration instance.

2019-07-18 Thread GitBox
xintongsong commented on a change in pull request #9105: [FLINK-13241][Yarn/Mesos] Fix Yarn/MesosResourceManager setting managed memory size into wrong configuration instance. URL: https://github.com/apache/flink/pull/9105#discussion_r305173128 ## File path: flink-runtime/src/main

[GitHub] [flink] sunhaibotb commented on issue #8471: [FLINK-12529][runtime] Release record-deserializer buffers timely to improve the efficiency of heap usage on taskmanager

2019-07-18 Thread GitBox
sunhaibotb commented on issue #8471: [FLINK-12529][runtime] Release record-deserializer buffers timely to improve the efficiency of heap usage on taskmanager URL: https://github.com/apache/flink/pull/8471#issuecomment-513053581 The code has been updated and the travis is green (flinkbot do

[jira] [Comment Edited] (FLINK-12249) Type equivalence check fails for Window Aggregates

2019-07-18 Thread godfrey he (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16887834#comment-16887834 ] godfrey he edited comment on FLINK-12249 at 7/19/19 1:23 AM: -

[jira] [Created] (FLINK-13328) add IT case for reading and writing generic table metadata via HiveCatalog

2019-07-18 Thread Bowen Li (JIRA)
Bowen Li created FLINK-13328: Summary: add IT case for reading and writing generic table metadata via HiveCatalog Key: FLINK-13328 URL: https://issues.apache.org/jira/browse/FLINK-13328 Project: Flink

[jira] [Commented] (FLINK-11205) Task Manager Metaspace Memory Leak

2019-07-18 Thread Joey Echeverria (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888411#comment-16888411 ] Joey Echeverria commented on FLINK-11205: - I didn't get a chance to reproduce th

[jira] [Commented] (FLINK-11843) Dispatcher fails to recover jobs if leader change happens during JobManagerRunner termination

2019-07-18 Thread TisonKun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888402#comment-16888402 ] TisonKun commented on FLINK-11843: -- [~stevenz3wu] I have sent an email to you :- ) > D

[jira] [Commented] (FLINK-11568) Exception in Kinesis ShardConsumer hidden by InterruptedException

2019-07-18 Thread Thomas Weise (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888383#comment-16888383 ] Thomas Weise commented on FLINK-11568: -- Missed to resolve this when merging the PR.

[jira] [Resolved] (FLINK-11568) Exception in Kinesis ShardConsumer hidden by InterruptedException

2019-07-18 Thread Thomas Weise (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Weise resolved FLINK-11568. -- Resolution: Fixed Fix Version/s: 1.9.0 > Exception in Kinesis ShardConsumer hidden by I

[GitHub] [flink] TengHu commented on issue #8885: [FLINK-12855] [streaming-java][window-assigners] Add functionality that staggers panes on partitions to distribute workload.

2019-07-18 Thread GitBox
TengHu commented on issue #8885: [FLINK-12855] [streaming-java][window-assigners] Add functionality that staggers panes on partitions to distribute workload. URL: https://github.com/apache/flink/pull/8885#issuecomment-512990774 @zentol @twalthr @StefanRRichter Can you guys take a look at t

[GitHub] [flink] GJL commented on a change in pull request #9060: [FLINK-13145][tests] Run HA dataset E2E test with new RestartPipelinedRegionStrategy

2019-07-18 Thread GitBox
GJL commented on a change in pull request #9060: [FLINK-13145][tests] Run HA dataset E2E test with new RestartPipelinedRegionStrategy URL: https://github.com/apache/flink/pull/9060#discussion_r305113537 ## File path: flink-end-to-end-tests/flink-dataset-fine-grained-recovery-test/s

[GitHub] [flink] GJL commented on a change in pull request #9060: [FLINK-13145][tests] Run HA dataset E2E test with new RestartPipelinedRegionStrategy

2019-07-18 Thread GitBox
GJL commented on a change in pull request #9060: [FLINK-13145][tests] Run HA dataset E2E test with new RestartPipelinedRegionStrategy URL: https://github.com/apache/flink/pull/9060#discussion_r305113144 ## File path: flink-end-to-end-tests/flink-dataset-fine-grained-recovery-test/s

[GitHub] [flink] flinkbot commented on issue #9172: [FLINK-13313][table] create CatalogTableBuilder to support building CatalogTable from descriptors

2019-07-18 Thread GitBox
flinkbot commented on issue #9172: [FLINK-13313][table] create CatalogTableBuilder to support building CatalogTable from descriptors URL: https://github.com/apache/flink/pull/9172#issuecomment-512975941 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I he

[jira] [Updated] (FLINK-13313) create CatalogTableBuilder to support building CatalogTable from descriptors

2019-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-13313: --- Labels: pull-request-available (was: ) > create CatalogTableBuilder to support building Cat

[GitHub] [flink] bowenli86 opened a new pull request #9172: [FLINK-13313][table] create CatalogTableBuilder to support building CatalogTable from descriptors

2019-07-18 Thread GitBox
bowenli86 opened a new pull request #9172: [FLINK-13313][table] create CatalogTableBuilder to support building CatalogTable from descriptors URL: https://github.com/apache/flink/pull/9172 ## What is the purpose of the change This PR adds `CatalogTableBuilder` as a replacement of `Ex

[jira] [Closed] (FLINK-13327) Blink planner not compiling with Scala 2.12

2019-07-18 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz closed FLINK-13327. Resolution: Fixed Fixed in master via: abeb1f5cc73e33800d0af1367f345d1bf2f2822d 1.9: 0faa6

[jira] [Closed] (FLINK-13312) move tests for data type mappings between Flink and Hive into its own test class

2019-07-18 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li closed FLINK-13312. Resolution: Fixed merged in 1.10.0: 9783d88463ace4c728de3f5861efd42c2c07e23e 1.9.0: d230aac5a479891b3d5

[jira] [Updated] (FLINK-13312) move tests for data type mappings between Flink and Hive into its own test class

2019-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-13312: --- Labels: pull-request-available (was: ) > move tests for data type mappings between Flink an

[GitHub] [flink] asfgit closed pull request #9151: [FLINK-13312][hive] move tests for data type mappings between Flink and Hive into its own test class

2019-07-18 Thread GitBox
asfgit closed pull request #9151: [FLINK-13312][hive] move tests for data type mappings between Flink and Hive into its own test class URL: https://github.com/apache/flink/pull/9151 This is an automated message from the Apac

[GitHub] [flink] bowenli86 commented on issue #9151: [FLINK-12755][hive] move tests for data type mappings between Flink and Hive into its own test class

2019-07-18 Thread GitBox
bowenli86 commented on issue #9151: [FLINK-12755][hive] move tests for data type mappings between Flink and Hive into its own test class URL: https://github.com/apache/flink/pull/9151#issuecomment-512932626 @xuefuz thanks for your review! the kafka test failure in CI is unrelated. Me

[GitHub] [flink] xuefuz commented on issue #9167: [FLINK-13279][table] Fallback to the builtin catalog when looking for registered tables.

2019-07-18 Thread GitBox
xuefuz commented on issue #9167: [FLINK-13279][table] Fallback to the builtin catalog when looking for registered tables. URL: https://github.com/apache/flink/pull/9167#issuecomment-512920634 @dawidwys Thanks for working on this. I have some concerns about the approach and posted my commen

[jira] [Commented] (FLINK-13279) not able to query table registered in catalogs in SQL CLI

2019-07-18 Thread Xuefu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888197#comment-16888197 ] Xuefu Zhang commented on FLINK-13279: - [~dawidwys] thanks for looking into this. Aft

[GitHub] [flink] sjwiesman commented on a change in pull request #9161: [FLINK-13262][docs] Add documentation for the new Table & SQL API type system

2019-07-18 Thread GitBox
sjwiesman commented on a change in pull request #9161: [FLINK-13262][docs] Add documentation for the new Table & SQL API type system URL: https://github.com/apache/flink/pull/9161#discussion_r305030971 ## File path: docs/dev/table/types.md ## @@ -0,0 +1,1201 @@ +--- +title

[GitHub] [flink] sjwiesman commented on a change in pull request #9161: [FLINK-13262][docs] Add documentation for the new Table & SQL API type system

2019-07-18 Thread GitBox
sjwiesman commented on a change in pull request #9161: [FLINK-13262][docs] Add documentation for the new Table & SQL API type system URL: https://github.com/apache/flink/pull/9161#discussion_r304912777 ## File path: docs/dev/table/types.md ## @@ -0,0 +1,1201 @@ +--- +title

[GitHub] [flink] sjwiesman commented on a change in pull request #9161: [FLINK-13262][docs] Add documentation for the new Table & SQL API type system

2019-07-18 Thread GitBox
sjwiesman commented on a change in pull request #9161: [FLINK-13262][docs] Add documentation for the new Table & SQL API type system URL: https://github.com/apache/flink/pull/9161#discussion_r304912777 ## File path: docs/dev/table/types.md ## @@ -0,0 +1,1201 @@ +--- +title

[GitHub] [flink] sjwiesman commented on a change in pull request #9161: [FLINK-13262][docs] Add documentation for the new Table & SQL API type system

2019-07-18 Thread GitBox
sjwiesman commented on a change in pull request #9161: [FLINK-13262][docs] Add documentation for the new Table & SQL API type system URL: https://github.com/apache/flink/pull/9161#discussion_r305029535 ## File path: docs/dev/table/types.md ## @@ -0,0 +1,1201 @@ +--- +title

[GitHub] [flink] sjwiesman commented on a change in pull request #9161: [FLINK-13262][docs] Add documentation for the new Table & SQL API type system

2019-07-18 Thread GitBox
sjwiesman commented on a change in pull request #9161: [FLINK-13262][docs] Add documentation for the new Table & SQL API type system URL: https://github.com/apache/flink/pull/9161#discussion_r305024945 ## File path: docs/dev/table/types.md ## @@ -0,0 +1,1201 @@ +--- +title

[GitHub] [flink] sjwiesman commented on a change in pull request #9161: [FLINK-13262][docs] Add documentation for the new Table & SQL API type system

2019-07-18 Thread GitBox
sjwiesman commented on a change in pull request #9161: [FLINK-13262][docs] Add documentation for the new Table & SQL API type system URL: https://github.com/apache/flink/pull/9161#discussion_r305025804 ## File path: docs/dev/table/types.md ## @@ -0,0 +1,1201 @@ +--- +title

[GitHub] [flink] sjwiesman commented on a change in pull request #9161: [FLINK-13262][docs] Add documentation for the new Table & SQL API type system

2019-07-18 Thread GitBox
sjwiesman commented on a change in pull request #9161: [FLINK-13262][docs] Add documentation for the new Table & SQL API type system URL: https://github.com/apache/flink/pull/9161#discussion_r305027128 ## File path: docs/dev/table/types.md ## @@ -0,0 +1,1201 @@ +--- +title

[GitHub] [flink] sjwiesman commented on a change in pull request #9161: [FLINK-13262][docs] Add documentation for the new Table & SQL API type system

2019-07-18 Thread GitBox
sjwiesman commented on a change in pull request #9161: [FLINK-13262][docs] Add documentation for the new Table & SQL API type system URL: https://github.com/apache/flink/pull/9161#discussion_r305025907 ## File path: docs/dev/table/types.md ## @@ -0,0 +1,1201 @@ +--- +title

[GitHub] [flink] sjwiesman commented on a change in pull request #9161: [FLINK-13262][docs] Add documentation for the new Table & SQL API type system

2019-07-18 Thread GitBox
sjwiesman commented on a change in pull request #9161: [FLINK-13262][docs] Add documentation for the new Table & SQL API type system URL: https://github.com/apache/flink/pull/9161#discussion_r305027613 ## File path: docs/dev/table/types.md ## @@ -0,0 +1,1201 @@ +--- +title

[GitHub] [flink] sjwiesman commented on a change in pull request #9161: [FLINK-13262][docs] Add documentation for the new Table & SQL API type system

2019-07-18 Thread GitBox
sjwiesman commented on a change in pull request #9161: [FLINK-13262][docs] Add documentation for the new Table & SQL API type system URL: https://github.com/apache/flink/pull/9161#discussion_r305026501 ## File path: docs/dev/table/types.md ## @@ -0,0 +1,1201 @@ +--- +title

[GitHub] [flink] sjwiesman commented on a change in pull request #9161: [FLINK-13262][docs] Add documentation for the new Table & SQL API type system

2019-07-18 Thread GitBox
sjwiesman commented on a change in pull request #9161: [FLINK-13262][docs] Add documentation for the new Table & SQL API type system URL: https://github.com/apache/flink/pull/9161#discussion_r305022907 ## File path: docs/dev/table/types.md ## @@ -0,0 +1,1201 @@ +--- +title

[GitHub] [flink] sjwiesman commented on a change in pull request #9161: [FLINK-13262][docs] Add documentation for the new Table & SQL API type system

2019-07-18 Thread GitBox
sjwiesman commented on a change in pull request #9161: [FLINK-13262][docs] Add documentation for the new Table & SQL API type system URL: https://github.com/apache/flink/pull/9161#discussion_r305024070 ## File path: docs/dev/table/types.md ## @@ -0,0 +1,1201 @@ +--- +title

[GitHub] [flink] sjwiesman commented on a change in pull request #9161: [FLINK-13262][docs] Add documentation for the new Table & SQL API type system

2019-07-18 Thread GitBox
sjwiesman commented on a change in pull request #9161: [FLINK-13262][docs] Add documentation for the new Table & SQL API type system URL: https://github.com/apache/flink/pull/9161#discussion_r305024625 ## File path: docs/dev/table/types.md ## @@ -0,0 +1,1201 @@ +--- +title

[GitHub] [flink] sjwiesman commented on a change in pull request #9161: [FLINK-13262][docs] Add documentation for the new Table & SQL API type system

2019-07-18 Thread GitBox
sjwiesman commented on a change in pull request #9161: [FLINK-13262][docs] Add documentation for the new Table & SQL API type system URL: https://github.com/apache/flink/pull/9161#discussion_r304912777 ## File path: docs/dev/table/types.md ## @@ -0,0 +1,1201 @@ +--- +title

  1   2   3   4   5   >