[GitHub] [flink] flinkbot edited a comment on issue #9484: [FLINK-13774][table] Expression DSL use should resolve Expressions in blink

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9484: [FLINK-13774][table] Expression DSL 
use should resolve Expressions in blink
URL: https://github.com/apache/flink/pull/9484#issuecomment-522628616
 
 
   
   ## CI report:
   
   * 9559898f9d03c5aad327febdcd6fcd6a2d3e99f2 : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/123744310)
   * 5104e3ba53a3fb347b5c065d8dfdfcb10ad959ed : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123746834)
   * 7e28e22701c3f56fd8e1cddfb862d0f48c1d417e : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123753968)
   * 7b4e88c349ddf809576a7c75ac2a9bcc779a157d : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/123855476)
   * 3596dbe1d9e542b57034858c54394fd95ed0702c : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123873737)
   * dbd62f46c2a8ecf741657fd33ae7a1b6af08795d : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123899928)
   * c881e76a22f32ef3845f31322b4b47ca9a9639cb : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124204123)
   * cdf3c20204cdde60bf543eda2745e8337189ae86 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124227196)
   * 011fcc9807bde6b703d5b8c261f441a85815438f : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/124346038)
   * 533bf3e84ec960a17f96daa116c7c9b562bccd85 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124347378)
   * f67af16c35fc1964a2e3c1e8afd5e60067887147 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/124368048)
   * 693f9c19718955c7eda4903baf45761fcc447521 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/12485)
   * a9d553120a334d008fe21f6430966e798cd6ba1d : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/124898931)
   * e4d125f362b5766649846f10eae51085a8ed85e6 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/124902407)
   * 4a8f0206db2b45bea1a2ccd2a4d1a9282b592810 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/125017117)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9336: [FLINK-13548][Deployment/YARN]Support priority of the Flink YARN application

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9336: [FLINK-13548][Deployment/YARN]Support 
priority of the Flink YARN application
URL: https://github.com/apache/flink/pull/9336#issuecomment-517610510
 
 
   
   ## CI report:
   
   * 4fe9e1ba5707fb4d208290116bc172142e6be08a : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/121719017)
   * 346ed33756127b27aed16fc91d8ce81048186c06 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/121827648)
   * d9b31af0157fe9b2adf080575272502b6f2e0cb5 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/122217463)
   * eb8a3c29bbb32a99d5d8e5e8baaabc390f123663 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/122378181)
   * ef702e9abf75ba1a8d2eed162ba836febb8e7aab : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/122707201)
   * 031199ee8f41cdb9524c51fa06cf93d26983424c : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123320094)
   * 7b670462c1e233bcc92c536a140a47a7248c43d6 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123675131)
   * 0dbb8dc266ec0c10fd15cd2bd857434e2a636e21 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124332198)
   * 7c601e005b5976be9d330e032666502efd44fdb2 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/125017127)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9484: [FLINK-13774][table] Expression DSL use should resolve Expressions in blink

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9484: [FLINK-13774][table] Expression DSL 
use should resolve Expressions in blink
URL: https://github.com/apache/flink/pull/9484#issuecomment-522628616
 
 
   
   ## CI report:
   
   * 9559898f9d03c5aad327febdcd6fcd6a2d3e99f2 : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/123744310)
   * 5104e3ba53a3fb347b5c065d8dfdfcb10ad959ed : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123746834)
   * 7e28e22701c3f56fd8e1cddfb862d0f48c1d417e : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123753968)
   * 7b4e88c349ddf809576a7c75ac2a9bcc779a157d : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/123855476)
   * 3596dbe1d9e542b57034858c54394fd95ed0702c : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123873737)
   * dbd62f46c2a8ecf741657fd33ae7a1b6af08795d : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123899928)
   * c881e76a22f32ef3845f31322b4b47ca9a9639cb : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124204123)
   * cdf3c20204cdde60bf543eda2745e8337189ae86 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124227196)
   * 011fcc9807bde6b703d5b8c261f441a85815438f : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/124346038)
   * 533bf3e84ec960a17f96daa116c7c9b562bccd85 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124347378)
   * f67af16c35fc1964a2e3c1e8afd5e60067887147 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/124368048)
   * 693f9c19718955c7eda4903baf45761fcc447521 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/12485)
   * a9d553120a334d008fe21f6430966e798cd6ba1d : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/124898931)
   * e4d125f362b5766649846f10eae51085a8ed85e6 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/124902407)
   * 4a8f0206db2b45bea1a2ccd2a4d1a9282b592810 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/125017117)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9336: [FLINK-13548][Deployment/YARN]Support priority of the Flink YARN application

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9336: [FLINK-13548][Deployment/YARN]Support 
priority of the Flink YARN application
URL: https://github.com/apache/flink/pull/9336#issuecomment-517610510
 
 
   
   ## CI report:
   
   * 4fe9e1ba5707fb4d208290116bc172142e6be08a : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/121719017)
   * 346ed33756127b27aed16fc91d8ce81048186c06 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/121827648)
   * d9b31af0157fe9b2adf080575272502b6f2e0cb5 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/122217463)
   * eb8a3c29bbb32a99d5d8e5e8baaabc390f123663 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/122378181)
   * ef702e9abf75ba1a8d2eed162ba836febb8e7aab : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/122707201)
   * 031199ee8f41cdb9524c51fa06cf93d26983424c : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123320094)
   * 7b670462c1e233bcc92c536a140a47a7248c43d6 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123675131)
   * 0dbb8dc266ec0c10fd15cd2bd857434e2a636e21 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124332198)
   * 7c601e005b5976be9d330e032666502efd44fdb2 : UNKNOWN
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9484: [FLINK-13774][table] Expression DSL use should resolve Expressions in blink

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9484: [FLINK-13774][table] Expression DSL 
use should resolve Expressions in blink
URL: https://github.com/apache/flink/pull/9484#issuecomment-522628616
 
 
   
   ## CI report:
   
   * 9559898f9d03c5aad327febdcd6fcd6a2d3e99f2 : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/123744310)
   * 5104e3ba53a3fb347b5c065d8dfdfcb10ad959ed : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123746834)
   * 7e28e22701c3f56fd8e1cddfb862d0f48c1d417e : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123753968)
   * 7b4e88c349ddf809576a7c75ac2a9bcc779a157d : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/123855476)
   * 3596dbe1d9e542b57034858c54394fd95ed0702c : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123873737)
   * dbd62f46c2a8ecf741657fd33ae7a1b6af08795d : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123899928)
   * c881e76a22f32ef3845f31322b4b47ca9a9639cb : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124204123)
   * cdf3c20204cdde60bf543eda2745e8337189ae86 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124227196)
   * 011fcc9807bde6b703d5b8c261f441a85815438f : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/124346038)
   * 533bf3e84ec960a17f96daa116c7c9b562bccd85 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124347378)
   * f67af16c35fc1964a2e3c1e8afd5e60067887147 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/124368048)
   * 693f9c19718955c7eda4903baf45761fcc447521 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/12485)
   * a9d553120a334d008fe21f6430966e798cd6ba1d : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/124898931)
   * e4d125f362b5766649846f10eae51085a8ed85e6 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/124902407)
   * 4a8f0206db2b45bea1a2ccd2a4d1a9282b592810 : UNKNOWN
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] wzhero1 commented on a change in pull request #9336: [FLINK-13548][Deployment/YARN]Support priority of the Flink YARN application

2019-08-28 Thread GitBox
wzhero1 commented on a change in pull request #9336: 
[FLINK-13548][Deployment/YARN]Support priority of the Flink YARN application
URL: https://github.com/apache/flink/pull/9336#discussion_r318881188
 
 

 ##
 File path: 
flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java
 ##
 @@ -180,6 +180,22 @@
" Flink on YARN on an environment with a restrictive 
firewall, this option allows specifying a range of" +
" allowed ports.");
 
+   /**
+* A non-negative integer indicating the priority for submitting a 
Flink YARN application. It will only take effect
+* if YARN priority scheduling setting is enabled. Larger integer 
corresponds with higher priority. If priority is
+* negative or set to '-1'(default), Flink will unset yarn priority 
setting and use cluster default priority.
+*
+* @see https://hadoop.apache.org/docs/r2.8.5/hadoop-yarn/hadoop-yarn-site/CapacityScheduler.html;>YARN
 Capacity Scheduling Doc
+*/
+   public static final ConfigOption APPLICATION_PRIORITY =
+   key("yarn.application.priority")
+   .defaultValue(-1)
+   .withDescription("A non-negative integer indicating the 
priority for submitting a Flink YARN application. It" +
+   " will only take effect if YARN priority 
scheduling setting is enabled. Larger integer corresponds" +
+   " with higher priority. If priority is negative 
or set to '-1'(default), Flink will unset yarn priority" +
+   " setting and use cluster default priority. 
Please refer to YARN official documentation for specific" +
 
 Review comment:
   done


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9336: [FLINK-13548][Deployment/YARN]Support priority of the Flink YARN application

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9336: [FLINK-13548][Deployment/YARN]Support 
priority of the Flink YARN application
URL: https://github.com/apache/flink/pull/9336#issuecomment-517608148
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit 7c601e005b5976be9d330e032666502efd44fdb2 (Thu Aug 29 
04:28:40 UTC 2019)
   
✅no warnings
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] wzhero1 commented on a change in pull request #9336: [FLINK-13548][Deployment/YARN]Support priority of the Flink YARN application

2019-08-28 Thread GitBox
wzhero1 commented on a change in pull request #9336: 
[FLINK-13548][Deployment/YARN]Support priority of the Flink YARN application
URL: https://github.com/apache/flink/pull/9336#discussion_r318881035
 
 

 ##
 File path: 
flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java
 ##
 @@ -180,6 +180,25 @@
" Flink on YARN on an environment with a restrictive 
firewall, this option allows specifying a range of" +
" allowed ports.");
 
+   /**
+* A non-negative integer indicating the priority for submitting a 
Flink YARN application. It will only take effect
+* if the Hadoop version >= 2.8.5 and YARN priority scheduling setting 
is enabled. Larger integer corresponds with
+* higher priority. If priority is negative or set to '-1'(default), 
Flink will unset yarn priority setting and use
+* cluster default priority.
+*
+* @see https://hadoop.apache.org/docs/r2.8.5/hadoop-yarn/hadoop-yarn-site/CapacityScheduler.html;>YARN
 Capacity Scheduling Doc
+*/
+   public static final ConfigOption APPLICATION_PRIORITY =
+   key("yarn.application.priority")
+   .defaultValue(-1)
+   .withDescription(Description.builder()
+   .text("A non-negative integer indicating the 
priority for submitting a Flink YARN application. It" +
+   " will only take effect if the Hadoop 
version >= 2.8.5 and YARN priority scheduling setting is enabled." +
 
 Review comment:
   Hi @walterddr it's tested in our yarn cluster which is based on the 2.8.x.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] wzhero1 commented on a change in pull request #9336: [FLINK-13548][Deployment/YARN]Support priority of the Flink YARN application

2019-08-28 Thread GitBox
wzhero1 commented on a change in pull request #9336: 
[FLINK-13548][Deployment/YARN]Support priority of the Flink YARN application
URL: https://github.com/apache/flink/pull/9336#discussion_r318881146
 
 

 ##
 File path: docs/ops/deployment/yarn_setup.md
 ##
 @@ -262,6 +262,15 @@ Flink's YARN client has the following configuration 
parameters to control how to
 
 - `yarn.application-attempts`: The number of ApplicationMaster (+ its 
TaskManager containers) attempts. If this value is set to 1 (default), the 
entire YARN session will fail when the Application master fails. Higher values 
specify the number of restarts of the ApplicationMaster by YARN.
 
+## Setup for application priority on YARN
+
+Flink's YARN client has the following configuration parameters to setup 
application priority. These parameters can be set either from the 
`conf/flink-conf.yaml` or when starting the YARN session, using `-D` parameters.
+
+- `yarn.application.priority`: A non-negative integer indicating the priority 
for submitting a Flink YARN application. 
+It will only take effect if YARN priority scheduling setting is enabled. 
Larger integer corresponds with higher priority. 
+If priority is negative or set to '-1'(default), Flink will unset yarn 
priority setting and use cluster default priority. 
+Please refer to YARN official documentation for specific settings required to 
enable priority schedule for the targeted YARN version.
 
 Review comment:
   done


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] wzhero1 commented on a change in pull request #9336: [FLINK-13548][Deployment/YARN]Support priority of the Flink YARN application

2019-08-28 Thread GitBox
wzhero1 commented on a change in pull request #9336: 
[FLINK-13548][Deployment/YARN]Support priority of the Flink YARN application
URL: https://github.com/apache/flink/pull/9336#discussion_r318881157
 
 

 ##
 File path: docs/ops/deployment/yarn_setup.zh.md
 ##
 @@ -262,6 +262,15 @@ Flink's YARN client has the following configuration 
parameters to control how to
 
 - `yarn.application-attempts`: The number of ApplicationMaster (+ its 
TaskManager containers) attempts. If this value is set to 1 (default), the 
entire YARN session will fail when the Application master fails. Higher values 
specify the number of restarts of the ApplicationMaster by YARN.
 
+## Setup for application priority on YARN
+
+Flink's YARN client has the following configuration parameters to setup 
application priority. These parameters can be set either from the 
`conf/flink-conf.yaml` or when starting the YARN session, using `-D` parameters.
+
+- `yarn.application.priority`: A non-negative integer indicating the priority 
for submitting a Flink YARN application. 
+It will only take effect if YARN priority scheduling setting is enabled. 
Larger integer corresponds with higher priority. 
+If priority is negative or set to '-1'(default), Flink will unset yarn 
priority setting and use cluster default priority. 
+Please refer to YARN official documentation for specific settings required to 
enable priority schedule for the targeted YARN version.
 
 Review comment:
   done


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9336: [FLINK-13548][Deployment/YARN]Support priority of the Flink YARN application

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9336: [FLINK-13548][Deployment/YARN]Support 
priority of the Flink YARN application
URL: https://github.com/apache/flink/pull/9336#issuecomment-517608148
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit 7c601e005b5976be9d330e032666502efd44fdb2 (Thu Aug 29 
04:22:32 UTC 2019)
   
✅no warnings
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9484: [FLINK-13774][table] Expression DSL use should resolve Expressions in blink

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9484: [FLINK-13774][table] Expression DSL 
use should resolve Expressions in blink
URL: https://github.com/apache/flink/pull/9484#issuecomment-522623760
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit 4a8f0206db2b45bea1a2ccd2a4d1a9282b592810 (Thu Aug 29 
04:21:31 UTC 2019)
   
   **Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up 
to date!
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9336: [FLINK-13548][Deployment/YARN]Support priority of the Flink YARN application

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9336: [FLINK-13548][Deployment/YARN]Support 
priority of the Flink YARN application
URL: https://github.com/apache/flink/pull/9336#issuecomment-517608148
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit 0dbb8dc266ec0c10fd15cd2bd857434e2a636e21 (Thu Aug 29 
04:19:29 UTC 2019)
   
✅no warnings
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] wzhero1 commented on issue #9336: [FLINK-13548][Deployment/YARN]Support priority of the Flink YARN application

2019-08-28 Thread GitBox
wzhero1 commented on issue #9336: [FLINK-13548][Deployment/YARN]Support 
priority of the Flink YARN application
URL: https://github.com/apache/flink/pull/9336#issuecomment-526014631
 
 
   @tillrohrmann @walterddr Thank you very much for the discussion~ I think 
maybe there are two places we should test.
   1. the configuration we configured in Cli could be correctly parsed into 
YARN dynamic configuration. I found in 
`YARNSessionCapacitySchedulerITCase#testVCoresAreSet...()`, the method would 
getFlinkConfig by quering the yarn cluster. I added a priority config in this 
method, and it could correctly be parsed, which means the flinkConfiguration 
has the property when `AbstractYarnClusterDescriptor#startAppMaster()`,  so we 
can infer the property can be well configured in the 
`ApplicationSubmissionContext`(and debugging can confirm this Inference ). Also 
I found `FlinkYarnSessionCliTest#testConfigurationBeforeDeployment()` I added 
before is redundant so I have deleted this test.
   
https://github.com/apache/flink/blob/17e2747e575cc4d9847be76b5ce9a75a7b6707f7/flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNSessionCapacitySchedulerITCase.java#L254
   2. after sumbitting the application, we should get the priority report from 
`ApplicationReport` to check whether the priority config takes effect. 
`YARNSessionCapacitySchedulerITCase#testVCoresAreSet...()` also provides the 
way to check the `ApplicationReport`. But in hadoop-2.4.1 api, the 
`ApplicationReport` does not provide the `getPriority()` method(the method is 
supported after 2.8.0). So in current flink(hadoop version:2.4.1), we could not 
to test the `ApplicationReport`.
   
   Since currently `ApplicationSubmissionContext` is wrapped in the 
`AbstractYarnClusterDescriptor#startAppMaster` and hard to get and test, so I 
think maybe it is proper to test as I talked above. I sumbitted a new commit as 
I said, looking forward to your better ideas, thanks~


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9547: [FLINK-13877][hive] Support Hive version 2.1.0 and 2.1.1

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9547: [FLINK-13877][hive] Support Hive 
version 2.1.0 and 2.1.1
URL: https://github.com/apache/flink/pull/9547#issuecomment-525514771
 
 
   
   ## CI report:
   
   * c4f4353fcb2486fb375427e8f08f0e78b1a8c9a9 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/124828407)
   * b4db37b1c3f0b858183732495d06390a3023ae3c : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/125010094)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (FLINK-11937) Resolve small file problem in RocksDB incremental checkpoint

2019-08-28 Thread Yu Li (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-11937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16918258#comment-16918258
 ] 

Yu Li commented on FLINK-11937:
---

Thanks for the message and details about your in-production case [~hexiaoqiao]. 
And yes we will continue pushing this forward and try our best to make it in 
ASAP.

[~aljoscha] [~tzulitai] [~StephanEwen] FYI.

> Resolve small file problem in RocksDB incremental checkpoint
> 
>
> Key: FLINK-11937
> URL: https://issues.apache.org/jira/browse/FLINK-11937
> Project: Flink
>  Issue Type: New Feature
>  Components: Runtime / Checkpointing
>Reporter: Congxian Qiu(klion26)
>Assignee: Congxian Qiu(klion26)
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.10.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Currently when incremental checkpoint is enabled in RocksDBStateBackend a 
> separate file will be generated on DFS for each sst file. This may cause 
> “file flood” when running intensive workload (many jobs with high 
> parallelism) in big cluster. According to our observation in Alibaba 
> production, such file flood introduces at lease two drawbacks when using HDFS 
> as the checkpoint storage FileSystem: 1) huge number of RPC request issued to 
> NN which may burst its response queue; 2) huge number of files causes big 
> pressure on NN’s on-heap memory.
> In Flink we ever noticed similar small file flood problem and tried to 
> resolved it by introducing ByteStreamStateHandle(FLINK-2808), but this 
> solution has its limitation that if we configure the threshold too low there 
> will still be too many small files, while if too high the JM will finally 
> OOM, thus could hardly resolve the issue in case of using RocksDBStateBackend 
> with incremental snapshot strategy.
> We propose a new OutputStream called 
> FileSegmentCheckpointStateOutputStream(FSCSOS) to fix the problem. FSCSOS 
> will reuse the same underlying distributed file until its size exceeds a 
> preset threshold. We
> plan to complete the work in 3 steps: firstly introduce FSCSOS, secondly 
> resolve the specific storage amplification issue on FSCSOS, and lastly add an 
> option to reuse FSCSOS across multiple checkpoints to further reduce the DFS 
> file number.
> More details please refer to the attached design doc.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (FLINK-13808) Checkpoints expired by timeout may leak RocksDB files

2019-08-28 Thread Congxian Qiu(klion26) (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-13808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16918254#comment-16918254
 ] 

Congxian Qiu(klion26) commented on FLINK-13808:
---

Thanks for the ping [~carp84],  I'll take a look at this now.

> Checkpoints expired by timeout may leak RocksDB files
> -
>
> Key: FLINK-13808
> URL: https://issues.apache.org/jira/browse/FLINK-13808
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Checkpointing
>Affects Versions: 1.8.0, 1.8.1
> Environment: So far only reliably reproducible on a 4-node cluster 
> with parallelism ≥ 100. But do try 
> https://github.com/jcaesar/flink-rocksdb-file-leak
>Reporter: Julius Michaelis
>Priority: Minor
>
> A RocksDB state backend with HDFS checkpoints, with or without local 
> recovery, may leak files in {{io.tmp.dirs}} on checkpoint expiry by timeout.
> If the size of a checkpoint crosses what can be transferred during one 
> checkpoint timeout, checkpoints will continue to fail forever. If this is 
> combined with a quick rollover of SST files (e.g. due to a high density of 
> writes), this may quickly exhaust available disk space (or memory, as /tmp is 
> the default location).
> As a workaround, the jobmanager's REST API can be frequently queried for 
> failed checkpoints, and associated files deleted accordingly.
> I've tried investing the cause a little bit, but I'm stuck:
>  * {{Checkpoint 19 of job ac7efce3457d9d73b0a4f775a6ef46f8 expired before 
> completing.}} and similar gets printed, so
>  * [{{abortExpired}} is 
> invoked|https://github.com/apache/flink/blob/release-1.8.1/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java#L547-L549],
>  so
>  * [{{dispose}} is 
> invoked|https://github.com/apache/flink/blob/release-1.8.1/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpoint.java#L416],
>  so
>  * [{{cancelCaller}} is 
> invoked|https://github.com/apache/flink/blob/release-1.8.1/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpoint.java#L488],
>  so
>  * [the canceler is 
> invoked|https://github.com/apache/flink/blob/release-1.8.1/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpoint.java#L497]
>  ([through one more 
> layer|https://github.com/apache/flink/blob/release-1.8.1/flink-runtime/src/main/java/org/apache/flink/runtime/state/AsyncSnapshotCallable.java#L129]),
>  so
>  * [{{cleanup}} is 
> invoked|https://github.com/apache/flink/blob/release-1.8.1/flink-runtime/src/main/java/org/apache/flink/runtime/state/AsyncSnapshotCallable.java#L95],
>  (possibly [not from 
> {{cancel}}|https://github.com/apache/flink/blob/release-1.8.1/flink-runtime/src/main/java/org/apache/flink/runtime/state/AsyncSnapshotCallable.java#L84]),
>  so
>  * [{{cleanupProvidedResources}} is 
> invoked|https://github.com/apache/flink/blob/release-1.8.1/flink-runtime/src/main/java/org/apache/flink/runtime/state/AsyncSnapshotCallable.java#L162]
>  (this is the indirection that made me give up), so
>  * [this trace 
> log|https://github.com/apache/flink/blob/release-1.8.1/flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksIncrementalSnapshotStrategy.java#L372]
>  should be printed, but it isn't.
> I have some time to further investigate, but I'd appreciate help on finding 
> out where in this chain things go wrong.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (FLINK-13808) Checkpoints expired by timeout may leak RocksDB files

2019-08-28 Thread Yu Li (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-13808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16918253#comment-16918253
 ] 

Yu Li commented on FLINK-13808:
---

Thanks for the ping Stephan, just noticed.

[~klion26] Please take a look here, thanks.

> Checkpoints expired by timeout may leak RocksDB files
> -
>
> Key: FLINK-13808
> URL: https://issues.apache.org/jira/browse/FLINK-13808
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Checkpointing
>Affects Versions: 1.8.0, 1.8.1
> Environment: So far only reliably reproducible on a 4-node cluster 
> with parallelism ≥ 100. But do try 
> https://github.com/jcaesar/flink-rocksdb-file-leak
>Reporter: Julius Michaelis
>Priority: Minor
>
> A RocksDB state backend with HDFS checkpoints, with or without local 
> recovery, may leak files in {{io.tmp.dirs}} on checkpoint expiry by timeout.
> If the size of a checkpoint crosses what can be transferred during one 
> checkpoint timeout, checkpoints will continue to fail forever. If this is 
> combined with a quick rollover of SST files (e.g. due to a high density of 
> writes), this may quickly exhaust available disk space (or memory, as /tmp is 
> the default location).
> As a workaround, the jobmanager's REST API can be frequently queried for 
> failed checkpoints, and associated files deleted accordingly.
> I've tried investing the cause a little bit, but I'm stuck:
>  * {{Checkpoint 19 of job ac7efce3457d9d73b0a4f775a6ef46f8 expired before 
> completing.}} and similar gets printed, so
>  * [{{abortExpired}} is 
> invoked|https://github.com/apache/flink/blob/release-1.8.1/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java#L547-L549],
>  so
>  * [{{dispose}} is 
> invoked|https://github.com/apache/flink/blob/release-1.8.1/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpoint.java#L416],
>  so
>  * [{{cancelCaller}} is 
> invoked|https://github.com/apache/flink/blob/release-1.8.1/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpoint.java#L488],
>  so
>  * [the canceler is 
> invoked|https://github.com/apache/flink/blob/release-1.8.1/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpoint.java#L497]
>  ([through one more 
> layer|https://github.com/apache/flink/blob/release-1.8.1/flink-runtime/src/main/java/org/apache/flink/runtime/state/AsyncSnapshotCallable.java#L129]),
>  so
>  * [{{cleanup}} is 
> invoked|https://github.com/apache/flink/blob/release-1.8.1/flink-runtime/src/main/java/org/apache/flink/runtime/state/AsyncSnapshotCallable.java#L95],
>  (possibly [not from 
> {{cancel}}|https://github.com/apache/flink/blob/release-1.8.1/flink-runtime/src/main/java/org/apache/flink/runtime/state/AsyncSnapshotCallable.java#L84]),
>  so
>  * [{{cleanupProvidedResources}} is 
> invoked|https://github.com/apache/flink/blob/release-1.8.1/flink-runtime/src/main/java/org/apache/flink/runtime/state/AsyncSnapshotCallable.java#L162]
>  (this is the indirection that made me give up), so
>  * [this trace 
> log|https://github.com/apache/flink/blob/release-1.8.1/flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksIncrementalSnapshotStrategy.java#L372]
>  should be printed, but it isn't.
> I have some time to further investigate, but I'd appreciate help on finding 
> out where in this chain things go wrong.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [flink] flinkbot edited a comment on issue #9532: [hotfix][docs] Fix the dependent version of the hive connector error .

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9532: [hotfix][docs] Fix the dependent 
version of the hive connector error .
URL: https://github.com/apache/flink/pull/9532#issuecomment-524795310
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit d89edda46691593429ad804fdd0417e6008a0a39 (Thu Aug 29 
03:03:01 UTC 2019)
   
✅no warnings
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] wuchong commented on a change in pull request #9532: [hotfix][docs] Fix the dependent version of the hive connector error .

2019-08-28 Thread GitBox
wuchong commented on a change in pull request #9532: [hotfix][docs] Fix the 
dependent version of the hive connector error .
URL: https://github.com/apache/flink/pull/9532#discussion_r318868739
 
 

 ##
 File path: docs/dev/table/hive/index.md
 ##
 @@ -78,8 +78,8 @@ To integrate with Hive, users need the following 
dependencies in their project.
 
 
   org.apache.flink
-  flink-shaded-hadoop-2-uber-2.7.5-{{site.version}}
-  {{site.version}}
+  flink-shaded-hadoop-2-uber
+  2.7.5-7.0
 
 Review comment:
   However, it doesn't fix the shaded version. We still need a pull request to 
fix it.
   
   cc @bowenli86 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9478: [FLINK-13766][task] Refactor the implementation of StreamInputProcessor based on StreamTaskInput#emitNext

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9478: [FLINK-13766][task] Refactor the 
implementation of StreamInputProcessor based on StreamTaskInput#emitNext
URL: https://github.com/apache/flink/pull/9478#issuecomment-522373234
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit eec2a79613ec30b174e2e133c4e3844c5e27f443 (Thu Aug 29 
02:54:51 UTC 2019)
   
   **Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up 
to date!
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] zhijiangW commented on issue #9478: [FLINK-13766][task] Refactor the implementation of StreamInputProcessor based on StreamTaskInput#emitNext

2019-08-28 Thread GitBox
zhijiangW commented on issue #9478: [FLINK-13766][task] Refactor the 
implementation of StreamInputProcessor based on StreamTaskInput#emitNext
URL: https://github.com/apache/flink/pull/9478#issuecomment-525999658
 
 
   Thanks for the further review. The failure compilation is caused by 
`StreamTwoInputProcessor` which I have adjusted before because it would be 
removed finally by another ongoing PR. I could wait for that PR merged and 
rebase on that. Also wait for some progress in `SourceReader`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (FLINK-13887) ExecutionConfig#setDefaultInputDependencyConstraint should do NotNull check on params

2019-08-28 Thread Zhu Zhu (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-13887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhu Zhu updated FLINK-13887:

Description: 
If a user invokes ExecutionConfig#setDefaultInputDependencyConstraint(null) to 
set the defaultInputDependencyConstraint to be null, the scheduling topology 
building will throw NPE in ExecutionGraph creating stage, causing a master node 
fatal error.

Thus we need to do checkNotNull on the 
ExecutionConfig#setDefaultInputDependencyConstraint param to remind users in an 
early stage.

 

Exception is as blow:

2019-08-28T15:19:21.287+ ERROR 
org.apache.flink.runtime.entrypoint.ClusterEntrypoint         - Fatal error 
occurred in the cluster entrypoint.
 org.apache.flink.runtime.dispatcher.DispatcherException: Failed to take 
leadership with session id 2f8f7919-a81b-4529-ad57-9789dbf07707.
         at 
org.apache.flink.runtime.dispatcher.Dispatcher.lambda$null$30(Dispatcher.java:915)
         at 
java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760)
         at 
java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:736)
         at 
java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474)
         at 
java.util.concurrent.CompletableFuture.completeExceptionally(CompletableFuture.java:1977)
         at 
org.apache.flink.runtime.concurrent.FutureUtils$WaitingConjunctFuture.handleCompletedFuture(FutureUtils.java:691)
         at 
java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760)
         at 
java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:736)
         at 
java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474)
         at 
java.util.concurrent.CompletableFuture.postFire(CompletableFuture.java:561)
         at 
java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:739)
         at 
java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:442)
         at 
org.apache.flink.runtime.rpc.akka.AkkaRpcActor.handleRunAsync(AkkaRpcActor.java:397)
         at 
org.apache.flink.runtime.rpc.akka.AkkaRpcActor.handleRpcMessage(AkkaRpcActor.java:190)
         at 
org.apache.flink.runtime.rpc.akka.FencedAkkaRpcActor.handleRpcMessage(FencedAkkaRpcActor.java:74)
         at 
org.apache.flink.runtime.rpc.akka.AkkaRpcActor.handleMessage(AkkaRpcActor.java:152)
         at akka.japi.pf.UnitCaseStatement.apply(CaseStatements.scala:26)
         at akka.japi.pf.UnitCaseStatement.apply(CaseStatements.scala:21)
         at scala.PartialFunction.applyOrElse(PartialFunction.scala:123)
         at scala.PartialFunction.applyOrElse$(PartialFunction.scala:122)
         at akka.japi.pf.UnitCaseStatement.applyOrElse(CaseStatements.scala:21)
         at scala.PartialFunction$OrElse.applyOrElse(PartialFunction.scala:171)
         at scala.PartialFunction$OrElse.applyOrElse(PartialFunction.scala:172)
         at scala.PartialFunction$OrElse.applyOrElse(PartialFunction.scala:172)
         at akka.actor.Actor.aroundReceive(Actor.scala:517)
         at akka.actor.Actor.aroundReceive$(Actor.scala:515)
         at akka.actor.AbstractActor.aroundReceive(AbstractActor.scala:225)
         at akka.actor.ActorCell.receiveMessage(ActorCell.scala:592)
         at akka.actor.ActorCell.invoke(ActorCell.scala:561)
         at akka.dispatch.Mailbox.processMailbox(Mailbox.scala:258)
         at akka.dispatch.Mailbox.run(Mailbox.scala:225)
         at akka.dispatch.Mailbox.exec(Mailbox.scala:235)
         at akka.dispatch.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260)
         at 
akka.dispatch.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339)
         at 
akka.dispatch.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979)
         at 
akka.dispatch.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107)
 Caused by: java.lang.RuntimeException: 
org.apache.flink.runtime.client.JobExecutionException: Could not set up 
JobManager
         at 
org.apache.flink.util.function.CheckedSupplier.lambda$unchecked$0(CheckedSupplier.java:36)
         at 
java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1590)
         at akka.dispatch.TaskInvocation.run(AbstractDispatcher.scala:40)
         at 
akka.dispatch.ForkJoinExecutorConfigurator$AkkaForkJoinTask.exec(ForkJoinExecutorConfigurator.scala:44)
         ... 4 more
 Caused by: org.apache.flink.runtime.client.JobExecutionException: Could not 
set up JobManager
         at 
org.apache.flink.runtime.jobmaster.JobManagerRunner.(JobManagerRunner.java:152)
         at 
org.apache.flink.runtime.dispatcher.DefaultJobManagerRunnerFactory.createJobManagerRunner(DefaultJobManagerRunnerFactory.java:83)
         at 
org.apache.flink.runtime.dispatcher.Dispatcher.lambda$createJobManagerRunner$5(Dispatcher.java:375)
         at 

[jira] [Created] (FLINK-13887) ExecutionConfig#setDefaultInputDependencyConstraint should do NotNull check on params

2019-08-28 Thread Zhu Zhu (Jira)
Zhu Zhu created FLINK-13887:
---

 Summary: ExecutionConfig#setDefaultInputDependencyConstraint 
should do NotNull check on params
 Key: FLINK-13887
 URL: https://issues.apache.org/jira/browse/FLINK-13887
 Project: Flink
  Issue Type: Bug
  Components: Runtime / Coordination
Affects Versions: 1.9.0, 1.10.0
Reporter: Zhu Zhu


If a user invokes ExecutionConfig#setDefaultInputDependencyConstraint(null) to 
set the defaultInputDependencyConstraint to be null, the scheduling topology 
building will throw NPE in ExecutionGraph creating stage which causes a fatal 
error.

Thus we need to do checkNotNull on the 
ExecutionConfig#setDefaultInputDependencyConstraint param.

 

Exception is as blow:

2019-08-28T15:19:21.287+ ERROR 
org.apache.flink.runtime.entrypoint.ClusterEntrypoint         - Fatal error 
occurred in the cluster entrypoint.
org.apache.flink.runtime.dispatcher.DispatcherException: Failed to take 
leadership with session id 2f8f7919-a81b-4529-ad57-9789dbf07707.
        at 
org.apache.flink.runtime.dispatcher.Dispatcher.lambda$null$30(Dispatcher.java:915)
        at 
java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760)
        at 
java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:736)
        at 
java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474)
        at 
java.util.concurrent.CompletableFuture.completeExceptionally(CompletableFuture.java:1977)
        at 
org.apache.flink.runtime.concurrent.FutureUtils$WaitingConjunctFuture.handleCompletedFuture(FutureUtils.java:691)
        at 
java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760)
        at 
java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:736)
        at 
java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474)
        at 
java.util.concurrent.CompletableFuture.postFire(CompletableFuture.java:561)
        at 
java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:739)
        at 
java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:442)
        at 
org.apache.flink.runtime.rpc.akka.AkkaRpcActor.handleRunAsync(AkkaRpcActor.java:397)
        at 
org.apache.flink.runtime.rpc.akka.AkkaRpcActor.handleRpcMessage(AkkaRpcActor.java:190)
        at 
org.apache.flink.runtime.rpc.akka.FencedAkkaRpcActor.handleRpcMessage(FencedAkkaRpcActor.java:74)
        at 
org.apache.flink.runtime.rpc.akka.AkkaRpcActor.handleMessage(AkkaRpcActor.java:152)
        at akka.japi.pf.UnitCaseStatement.apply(CaseStatements.scala:26)
        at akka.japi.pf.UnitCaseStatement.apply(CaseStatements.scala:21)
        at scala.PartialFunction.applyOrElse(PartialFunction.scala:123)
        at scala.PartialFunction.applyOrElse$(PartialFunction.scala:122)
        at akka.japi.pf.UnitCaseStatement.applyOrElse(CaseStatements.scala:21)
        at scala.PartialFunction$OrElse.applyOrElse(PartialFunction.scala:171)
        at scala.PartialFunction$OrElse.applyOrElse(PartialFunction.scala:172)
        at scala.PartialFunction$OrElse.applyOrElse(PartialFunction.scala:172)
        at akka.actor.Actor.aroundReceive(Actor.scala:517)
        at akka.actor.Actor.aroundReceive$(Actor.scala:515)
        at akka.actor.AbstractActor.aroundReceive(AbstractActor.scala:225)
        at akka.actor.ActorCell.receiveMessage(ActorCell.scala:592)
        at akka.actor.ActorCell.invoke(ActorCell.scala:561)
        at akka.dispatch.Mailbox.processMailbox(Mailbox.scala:258)
        at akka.dispatch.Mailbox.run(Mailbox.scala:225)
        at akka.dispatch.Mailbox.exec(Mailbox.scala:235)
        at akka.dispatch.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260)
        at 
akka.dispatch.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339)
        at akka.dispatch.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979)
        at 
akka.dispatch.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107)
Caused by: java.lang.RuntimeException: 
org.apache.flink.runtime.client.JobExecutionException: Could not set up 
JobManager
        at 
org.apache.flink.util.function.CheckedSupplier.lambda$unchecked$0(CheckedSupplier.java:36)
        at 
java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1590)
        at akka.dispatch.TaskInvocation.run(AbstractDispatcher.scala:40)
        at 
akka.dispatch.ForkJoinExecutorConfigurator$AkkaForkJoinTask.exec(ForkJoinExecutorConfigurator.scala:44)
        ... 4 more
Caused by: org.apache.flink.runtime.client.JobExecutionException: Could not set 
up JobManager
        at 
org.apache.flink.runtime.jobmaster.JobManagerRunner.(JobManagerRunner.java:152)
        at 

[GitHub] [flink] flinkbot edited a comment on issue #9478: [FLINK-13766][task] Refactor the implementation of StreamInputProcessor based on StreamTaskInput#emitNext

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9478: [FLINK-13766][task] Refactor the 
implementation of StreamInputProcessor based on StreamTaskInput#emitNext
URL: https://github.com/apache/flink/pull/9478#issuecomment-522373234
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit eec2a79613ec30b174e2e133c4e3844c5e27f443 (Thu Aug 29 
02:51:48 UTC 2019)
   
   **Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up 
to date!
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] zhijiangW commented on a change in pull request #9478: [FLINK-13766][task] Refactor the implementation of StreamInputProcessor based on StreamTaskInput#emitNext

2019-08-28 Thread GitBox
zhijiangW commented on a change in pull request #9478: [FLINK-13766][task] 
Refactor the implementation of StreamInputProcessor based on 
StreamTaskInput#emitNext
URL: https://github.com/apache/flink/pull/9478#discussion_r318867046
 
 

 ##
 File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamTwoInputSelectableProcessor.java
 ##
 @@ -381,12 +333,28 @@ private ForwardingValveOutputHandler(
this.streamStatusMaintainer = 
checkNotNull(streamStatusMaintainer);
 
this.inputWatermarkGauge = inputWatermarkGauge;
+   this.numRecordsIn = checkNotNull(numRecordsIn);
 
this.inputIndex = inputIndex;
}
 
@Override
-   public void handleWatermark(Watermark watermark) throws 
Exception {
+   @SuppressWarnings("unchecked")
+   public void emitRecord(StreamRecord record) throws Exception {
+   synchronized (lock) {
+   numRecordsIn.inc();
+   if (inputIndex == 0) {
 
 Review comment:
   Yes, my only concern for this way is also for potential debugging issue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9547: [FLINK-13877][hive] Support Hive version 2.1.0 and 2.1.1

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9547: [FLINK-13877][hive] Support Hive 
version 2.1.0 and 2.1.1
URL: https://github.com/apache/flink/pull/9547#issuecomment-525514771
 
 
   
   ## CI report:
   
   * c4f4353fcb2486fb375427e8f08f0e78b1a8c9a9 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/124828407)
   * b4db37b1c3f0b858183732495d06390a3023ae3c : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/125010094)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (FLINK-13881) CEP within method should applied in every independent pattern

2019-08-28 Thread YufeiLiu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-13881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16918229#comment-16918229
 ] 

YufeiLiu commented on FLINK-13881:
--

Thanks for your patience, I will start a dissuss at the dev mailing list later.
Best.

> CEP within method should applied in every independent pattern
> -
>
> Key: FLINK-13881
> URL: https://issues.apache.org/jira/browse/FLINK-13881
> Project: Flink
>  Issue Type: Improvement
>  Components: Library / CEP
>Affects Versions: 1.9.0
>Reporter: YufeiLiu
>Priority: Major
>
> When I write a Pattern like this: 
> {code:java}
> Pattern.begin("start").where()
>   .followBy("middle0").where().within(Time.second(1))
>   .followBy("middle1").where().within(Time.second(2))
>   .followBy("middle2").where().within(Time.second(3))
> {code}
> the actual within time is the smallest: 1 second.
> I created a TimeCondition extends IterativeCondition, and I can get timestamp 
> of current event and previous computation state, then I compare them in 
> condition filter. Also make some change in NFACompiler, transform within as 
> StateTransition rather than a gobal property "windowTime" of NFA.
> It could work, but I dont know should I change the implementation of within 
> or create another syntax. 
> [~dawidwys] Is this meaningful? 



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [flink] flinkbot edited a comment on issue #9547: [FLINK-13877][hive] Support Hive version 2.1.0 and 2.1.1

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9547: [FLINK-13877][hive] Support Hive 
version 2.1.0 and 2.1.1
URL: https://github.com/apache/flink/pull/9547#issuecomment-525512048
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit b4db37b1c3f0b858183732495d06390a3023ae3c (Thu Aug 29 
02:37:36 UTC 2019)
   
   **Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up 
to date!
* **This pull request references an unassigned [Jira 
ticket](https://issues.apache.org/jira/browse/FLINK-13877).** According to the 
[code contribution 
guide](https://flink.apache.org/contributing/contribute-code.html), tickets 
need to be assigned before starting with the implementation work.
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] lirui-apache commented on a change in pull request #9547: [FLINK-13877][hive] Support Hive version 2.1.0 and 2.1.1

2019-08-28 Thread GitBox
lirui-apache commented on a change in pull request #9547: [FLINK-13877][hive] 
Support Hive version 2.1.0 and 2.1.1
URL: https://github.com/apache/flink/pull/9547#discussion_r318864785
 
 

 ##
 File path: 
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShimV210.java
 ##
 @@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.catalog.hive.client;
+
+import org.apache.flink.table.catalog.exceptions.CatalogException;
+
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.apache.hadoop.hive.metastore.HiveMetaStoreClient;
+import org.apache.hadoop.hive.metastore.IMetaStoreClient;
+import org.apache.hadoop.hive.metastore.RetryingMetaStoreClient;
+import org.apache.hadoop.hive.metastore.api.EnvironmentContext;
+import org.apache.hadoop.hive.metastore.api.InvalidOperationException;
+import org.apache.hadoop.hive.metastore.api.MetaException;
+import org.apache.hadoop.hive.metastore.api.Partition;
+import org.apache.thrift.TException;
+
+import java.lang.reflect.InvocationTargetException;
+import java.lang.reflect.Method;
+
+/**
+ * Shim for Hive version 2.1.0.
+ */
+public class HiveShimV210 extends HiveShimV122 {
+
+   @Override
+   public IMetaStoreClient getHiveMetastoreClient(HiveConf hiveConf) {
+   try {
+   Class[] constructorArgTypes = {HiveConf.class};
+   Object[] constructorArgs = {hiveConf};
+   Method method = 
RetryingMetaStoreClient.class.getMethod("getProxy", HiveConf.class,
 
 Review comment:
   Thanks for the details. Maybe we can add some comments for that?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] xuefuz commented on issue #9547: [FLINK-13877][hive] Support Hive version 2.1.0 and 2.1.1

2019-08-28 Thread GitBox
xuefuz commented on issue #9547: [FLINK-13877][hive] Support Hive version 2.1.0 
and 2.1.1
URL: https://github.com/apache/flink/pull/9547#issuecomment-525996476
 
 
   Added profile. @bowenli86 Can you take another look?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9547: [FLINK-13877][hive] Support Hive version 2.1.0 and 2.1.1

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9547: [FLINK-13877][hive] Support Hive 
version 2.1.0 and 2.1.1
URL: https://github.com/apache/flink/pull/9547#issuecomment-525514771
 
 
   
   ## CI report:
   
   * c4f4353fcb2486fb375427e8f08f0e78b1a8c9a9 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/124828407)
   * b4db37b1c3f0b858183732495d06390a3023ae3c : UNKNOWN
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9547: [FLINK-13877][hive] Support Hive version 2.1.0 and 2.1.1

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9547: [FLINK-13877][hive] Support Hive 
version 2.1.0 and 2.1.1
URL: https://github.com/apache/flink/pull/9547#issuecomment-525512048
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit b4db37b1c3f0b858183732495d06390a3023ae3c (Thu Aug 29 
02:33:32 UTC 2019)
   
   **Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up 
to date!
* **This pull request references an unassigned [Jira 
ticket](https://issues.apache.org/jira/browse/FLINK-13877).** According to the 
[code contribution 
guide](https://flink.apache.org/contributing/contribute-code.html), tickets 
need to be assigned before starting with the implementation work.
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9532: [hotfix][docs] Fix the dependent version of the hive connector error .

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9532: [hotfix][docs] Fix the dependent 
version of the hive connector error .
URL: https://github.com/apache/flink/pull/9532#issuecomment-524795310
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit d89edda46691593429ad804fdd0417e6008a0a39 (Thu Aug 29 
01:18:11 UTC 2019)
   
✅no warnings
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] yangjf2019 closed pull request #9532: [hotfix][docs] Fix the dependent version of the hive connector error .

2019-08-28 Thread GitBox
yangjf2019 closed pull request #9532: [hotfix][docs] Fix the dependent version 
of the hive connector error .
URL: https://github.com/apache/flink/pull/9532
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9532: [hotfix][docs] Fix the dependent version of the hive connector error .

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9532: [hotfix][docs] Fix the dependent 
version of the hive connector error .
URL: https://github.com/apache/flink/pull/9532#issuecomment-524795310
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit d89edda46691593429ad804fdd0417e6008a0a39 (Thu Aug 29 
00:51:42 UTC 2019)
   
✅no warnings
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] yangjf2019 commented on a change in pull request #9532: [hotfix][docs] Fix the dependent version of the hive connector error .

2019-08-28 Thread GitBox
yangjf2019 commented on a change in pull request #9532: [hotfix][docs] Fix the 
dependent version of the hive connector error .
URL: https://github.com/apache/flink/pull/9532#discussion_r318848475
 
 

 ##
 File path: docs/dev/table/hive/index.md
 ##
 @@ -78,8 +78,8 @@ To integrate with Hive, users need the following 
dependencies in their project.
 
 
   org.apache.flink
-  flink-shaded-hadoop-2-uber-2.7.5-{{site.version}}
-  {{site.version}}
+  flink-shaded-hadoop-2-uber
+  2.7.5-7.0
 
 Review comment:
   Hi, @wuchong @zentol , Thank you very much ! Someone has committed for this 
[PR](https://github.com/apache/flink/commit/614e9b73345c3ec09d55f75426968b7329c7953a),Maybe
 i will closed .


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (FLINK-13826) Support INSERT OVERWRITE for Hive connector

2019-08-28 Thread Bowen Li (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-13826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bowen Li updated FLINK-13826:
-
Fix Version/s: 1.10.0

> Support INSERT OVERWRITE for Hive connector
> ---
>
> Key: FLINK-13826
> URL: https://issues.apache.org/jira/browse/FLINK-13826
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Hive, Table SQL / Planner
>Reporter: Rui Li
>Assignee: Rui Li
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.10.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Closed] (FLINK-13826) Support INSERT OVERWRITE for Hive connector

2019-08-28 Thread Bowen Li (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-13826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bowen Li closed FLINK-13826.

Resolution: Fixed

merged in master: f38c5c068f072720eac615a4c00826e032bec466

> Support INSERT OVERWRITE for Hive connector
> ---
>
> Key: FLINK-13826
> URL: https://issues.apache.org/jira/browse/FLINK-13826
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Hive, Table SQL / Planner
>Reporter: Rui Li
>Assignee: Rui Li
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.10.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Assigned] (FLINK-13826) Support INSERT OVERWRITE for Hive connector

2019-08-28 Thread Bowen Li (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-13826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bowen Li reassigned FLINK-13826:


Assignee: Rui Li

> Support INSERT OVERWRITE for Hive connector
> ---
>
> Key: FLINK-13826
> URL: https://issues.apache.org/jira/browse/FLINK-13826
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Hive, Table SQL / Planner
>Reporter: Rui Li
>Assignee: Rui Li
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [flink] flinkbot edited a comment on issue #9519: [FLINK-13826][table-planner][hive] Support INSERT OVERWRITE for Hive …

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9519: [FLINK-13826][table-planner][hive] 
Support INSERT OVERWRITE for Hive …
URL: https://github.com/apache/flink/pull/9519#issuecomment-524218956
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit 64ade163c9072e6419a1bb037e45baf1d8c1f87f (Wed Aug 28 
22:19:59 UTC 2019)
   
   **Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up 
to date!
* **This pull request references an unassigned [Jira 
ticket](https://issues.apache.org/jira/browse/FLINK-13826).** According to the 
[code contribution 
guide](https://flink.apache.org/contributing/contribute-code.html), tickets 
need to be assigned before starting with the implementation work.
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] asfgit closed pull request #9519: [FLINK-13826][table-planner][hive] Support INSERT OVERWRITE for Hive …

2019-08-28 Thread GitBox
asfgit closed pull request #9519: [FLINK-13826][table-planner][hive] Support 
INSERT OVERWRITE for Hive …
URL: https://github.com/apache/flink/pull/9519
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] bowenli86 edited a comment on issue #9547: [FLINK-13877][hive] Support Hive version 2.1.0 and 2.1.1

2019-08-28 Thread GitBox
bowenli86 edited a comment on issue #9547: [FLINK-13877][hive] Support Hive 
version 2.1.0 and 2.1.1
URL: https://github.com/apache/flink/pull/9547#issuecomment-525941591
 
 
   can we add test profiles for new Hive versions? 
   
   I’d be more comfortable if we can at least run them manually until they have 
a testing plan (e.g. run in nightly build).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9547: [FLINK-13877][hive] Support Hive version 2.1.0 and 2.1.1

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9547: [FLINK-13877][hive] Support Hive 
version 2.1.0 and 2.1.1
URL: https://github.com/apache/flink/pull/9547#issuecomment-525512048
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit c4f4353fcb2486fb375427e8f08f0e78b1a8c9a9 (Wed Aug 28 
22:09:47 UTC 2019)
   
   **Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up 
to date!
* **This pull request references an unassigned [Jira 
ticket](https://issues.apache.org/jira/browse/FLINK-13877).** According to the 
[code contribution 
guide](https://flink.apache.org/contributing/contribute-code.html), tickets 
need to be assigned before starting with the implementation work.
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] bowenli86 commented on issue #9547: [FLINK-13877][hive] Support Hive version 2.1.0 and 2.1.1

2019-08-28 Thread GitBox
bowenli86 commented on issue #9547: [FLINK-13877][hive] Support Hive version 
2.1.0 and 2.1.1
URL: https://github.com/apache/flink/pull/9547#issuecomment-525941591
 
 
   can we add test profiles for new Hive versions? 
   
   I’d be more comfortable if we can at least run them manually.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9494: [FLINK-12847] [Connectors / Kinesis] update flink-connector-kinesis to use Apache 2.0 licensed code

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9494: [FLINK-12847] [Connectors / Kinesis] 
update flink-connector-kinesis to use Apache 2.0 licensed code
URL: https://github.com/apache/flink/pull/9494#issuecomment-523025067
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit 8e70b4f2c96109f83f6aa42a11ba42afe1b3924f (Wed Aug 28 
21:58:35 UTC 2019)
   
   **Warnings:**
* **3 pom.xml files were touched**: Check for build and licensing issues.
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] bowenli86 commented on issue #9494: [FLINK-12847] [Connectors / Kinesis] update flink-connector-kinesis to use Apache 2.0 licensed code

2019-08-28 Thread GitBox
bowenli86 commented on issue #9494: [FLINK-12847] [Connectors / Kinesis] update 
flink-connector-kinesis to use Apache 2.0 licensed code
URL: https://github.com/apache/flink/pull/9494#issuecomment-525938551
 
 
   > @bowenli86
   > 
   > these are referring to how to build for prior versions.
   > 
   > 樂 should this entire section be removed do you think. Leave in the mention 
of the licensing issue in prior versions, and then say something like "refer to 
the kinesis connector documentation for the version you are running" ?
   
   yeah, let's remove them. Flink has versioned docs with each release, users 
using an old kinesis connector should reference docs of a previous version


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9547: [FLINK-13877][hive] Support Hive version 2.1.0 and 2.1.1

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9547: [FLINK-13877][hive] Support Hive 
version 2.1.0 and 2.1.1
URL: https://github.com/apache/flink/pull/9547#issuecomment-525512048
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit c4f4353fcb2486fb375427e8f08f0e78b1a8c9a9 (Wed Aug 28 
20:47:18 UTC 2019)
   
   **Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up 
to date!
* **This pull request references an unassigned [Jira 
ticket](https://issues.apache.org/jira/browse/FLINK-13877).** According to the 
[code contribution 
guide](https://flink.apache.org/contributing/contribute-code.html), tickets 
need to be assigned before starting with the implementation work.
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] xuefuz commented on a change in pull request #9547: [FLINK-13877][hive] Support Hive version 2.1.0 and 2.1.1

2019-08-28 Thread GitBox
xuefuz commented on a change in pull request #9547: [FLINK-13877][hive] Support 
Hive version 2.1.0 and 2.1.1
URL: https://github.com/apache/flink/pull/9547#discussion_r318784062
 
 

 ##
 File path: 
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShimV210.java
 ##
 @@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.catalog.hive.client;
+
+import org.apache.flink.table.catalog.exceptions.CatalogException;
+
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.apache.hadoop.hive.metastore.HiveMetaStoreClient;
+import org.apache.hadoop.hive.metastore.IMetaStoreClient;
+import org.apache.hadoop.hive.metastore.RetryingMetaStoreClient;
+import org.apache.hadoop.hive.metastore.api.EnvironmentContext;
+import org.apache.hadoop.hive.metastore.api.InvalidOperationException;
+import org.apache.hadoop.hive.metastore.api.MetaException;
+import org.apache.hadoop.hive.metastore.api.Partition;
+import org.apache.thrift.TException;
+
+import java.lang.reflect.InvocationTargetException;
+import java.lang.reflect.Method;
+
+/**
+ * Shim for Hive version 2.1.0.
+ */
+public class HiveShimV210 extends HiveShimV122 {
+
+   @Override
+   public IMetaStoreClient getHiveMetastoreClient(HiveConf hiveConf) {
+   try {
+   Class[] constructorArgTypes = {HiveConf.class};
+   Object[] constructorArgs = {hiveConf};
+   Method method = 
RetryingMetaStoreClient.class.getMethod("getProxy", HiveConf.class,
 
 Review comment:
   The relevant JIRA is https://issues.apache.org/jira/browse/HIVE-15081


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] xuefuz commented on a change in pull request #9547: [FLINK-13877][hive] Support Hive version 2.1.0 and 2.1.1

2019-08-28 Thread GitBox
xuefuz commented on a change in pull request #9547: [FLINK-13877][hive] Support 
Hive version 2.1.0 and 2.1.1
URL: https://github.com/apache/flink/pull/9547#discussion_r318740225
 
 

 ##
 File path: 
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShimV210.java
 ##
 @@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.catalog.hive.client;
+
+import org.apache.flink.table.catalog.exceptions.CatalogException;
+
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.apache.hadoop.hive.metastore.HiveMetaStoreClient;
+import org.apache.hadoop.hive.metastore.IMetaStoreClient;
+import org.apache.hadoop.hive.metastore.RetryingMetaStoreClient;
+import org.apache.hadoop.hive.metastore.api.EnvironmentContext;
+import org.apache.hadoop.hive.metastore.api.InvalidOperationException;
+import org.apache.hadoop.hive.metastore.api.MetaException;
+import org.apache.hadoop.hive.metastore.api.Partition;
+import org.apache.thrift.TException;
+
+import java.lang.reflect.InvocationTargetException;
+import java.lang.reflect.Method;
+
+/**
+ * Shim for Hive version 2.1.0.
+ */
+public class HiveShimV210 extends HiveShimV122 {
+
+   @Override
+   public IMetaStoreClient getHiveMetastoreClient(HiveConf hiveConf) {
+   try {
+   Class[] constructorArgTypes = {HiveConf.class};
+   Object[] constructorArgs = {hiveConf};
+   Method method = 
RetryingMetaStoreClient.class.getMethod("getProxy", HiveConf.class,
 
 Review comment:
   Actually the implementation in HiveShimV230 is the first thing I tried. It 
didn't work. The reason is there was problem in getProxy(HiveConf hiveConf, 
boolean allowEmbedded) implementation. With that, when the method is invoked, 
it's looking for a 2-param constructor for HiveMetastoreClient, which isn't 
present.
   
   The problem seems getting fixed in 2.3. Here are the difference btwn the two:
   2.3
   ```
 public static IMetaStoreClient getProxy(
 HiveConf hiveConf, boolean allowEmbedded) throws MetaException {
   return getProxy(hiveConf, new Class[]{HiveConf.class, 
HiveMetaHookLoader.class, Boolean.class},
   new Object[]{hiveConf, null, allowEmbedded}, null, 
HiveMetaStoreClient.class.getName()
   );
 }
   
   ```
   2.1
   ```
 public static IMetaStoreClient getProxy(
 HiveConf hiveConf, boolean allowEmbedded) throws MetaException {
   return getProxy(hiveConf, new Class[]{HiveConf.class, Boolean.class},
   new Object[]{hiveConf, allowEmbedded}, null, 
HiveMetaStoreClient.class.getName()
   );
 }
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9383: [FLINK-13248] [runtime] Adding processing of downstream messages in AsyncWaitOperator's wait loops

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9383: [FLINK-13248] [runtime] Adding 
processing of downstream messages in AsyncWaitOperator's wait loops
URL: https://github.com/apache/flink/pull/9383#issuecomment-519130955
 
 
   
   ## CI report:
   
   * 5d8448c4813f5b362f98f898998f1278f062d807 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/122292142)
   * 4d628935e8899d6019566bfc93b5c688bc1835ec : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/122941321)
   * d7c0bd5edc65110910d79ca7c7bf2139672f8c02 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123229382)
   * b7a19fe5d83ee271e7560f90fbf07a7703937273 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123235786)
   * 7650b3b19b05ed6a121566d7c19d5e7bc71489fa : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123332630)
   * 2493723ebd2c307f47bbdfcf154a31ab97cda312 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123335647)
   * f3f0fe6d16ef3bba35d06a797196f94f372701ff : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123336279)
   * c6ee15104ee678c239367670773723920e34c26d : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123371348)
   * d0e4fbf25a8ff9982171ed982868b51ad851aaf0 : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/123472764)
   * 741386a495a5657bb654dcd0168f2d42873445e7 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/123476701)
   * 05e27c097851c65bd9a405b4aae376e2ef6c2b50 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123645059)
   * 8fba78f22bc6c0d042cb1dde270c02af08d98bbd : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/123696981)
   * 681ac331e4c0b547e1d410b448bc34ff651dbc6a : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/123698096)
   * e18739460fbcf7c59be3c9121fc26fc279e0353a : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123703814)
   * 670affbc0ae2883e93bb2f6ca3c1300fb78f26c5 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123726809)
   * 50a91cbc74c645576432d25d40e7a42190ac28e8 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123758034)
   * 2fba64d8e9fa4939c5a6c3fb3d758d55ca344b6c : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123842040)
   * 0507aa67d2f7183c3a7e4556fbf7732414647ac7 : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/123855539)
   * 9a293ae331986d8fae16f619158f1e59572cd1e9 : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/123856922)
   * 2bb1bc290a3fc8e4dc843be781063515e86509d8 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/123859379)
   * 9ff3bc6cdeaff18473a075076ae4931bbdae7173 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124474961)
   * bfc5c6d643c502ec3a7ba181d4a80286af08ca50 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124487989)
   * 0b54f92f49a56077b36856c4eda400938f2cda75 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124488476)
   * 97b0b55c896ce68a8540758a38321ddbfac139c5 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124489022)
   * fae34dfb176d977e452dd5a3e7af8838341e565f : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124489295)
   * f312b58169cdd3ce32d603c5ef410b98064c084c : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/124534465)
   * 4125a241c713c467c47cb49aacfea5b99bbe4b47 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124544764)
   * 8308ec556edf17ce57d9ff377f646f6f1bbd47fc : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124548686)
   * ffe70dd34f21b84eeb6f448ab1611e5a6a0ecaa3 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124550076)
   * b925c47fa923e0f90fd0a4ee0205ae29fe32662e : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124554252)
   * 7815bc0047f41fd2d5dc3dcbe4adbd7be514e0da : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124561559)
   * 5821301ec74ba680e5e530fe1f698ed5c12f4b11 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/124578295)
   * 9e6aa380dc9d286316c372981df091dea77b28df : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/124700113)
   * 355736bc75b13d3e9caeea1fb03c510019985bf8 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124765237)
   * 85a77bc0ffdd7a4e06e1a183950ec075b21f030f : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124872507)
   * e311962f6b0177494709cd66770bb4ef6ef11d3a : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/124889848)
   * 3d2d4be4b8b4430247a41a8e27e4305b82c99345 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/124929657)
   * 5701af5109106c4fc5c062e5f0501201429d61bf : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124974019)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the

[jira] [Commented] (FLINK-13025) Elasticsearch 7.x support

2019-08-28 Thread Leonid Ilyevsky (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-13025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16918045#comment-16918045
 ] 

Leonid Ilyevsky commented on FLINK-13025:
-

We certainly need a new connector for Elasticsearch 7.x.

I tried to work around that issue with deprecated 'type' field, and so I 
attempted to use flink-connector-elasticsearch6 with 
elasticsearch-rest-high-level-client version 7.3.1. Got fatal exception:

 

{{java.lang.NoSuchMethodError: 
org.elasticsearch.client.RestHighLevelClient.ping([Lorg/apache/http/Header;)Z}}
{\{ at 
org.apache.flink.streaming.connectors.elasticsearch6.Elasticsearch6ApiCallBridge.createClient(Elasticsearch6ApiCallBridge.java:81)}}

.

> Elasticsearch 7.x support
> -
>
> Key: FLINK-13025
> URL: https://issues.apache.org/jira/browse/FLINK-13025
> Project: Flink
>  Issue Type: New Feature
>  Components: Connectors / ElasticSearch
>Affects Versions: 1.8.0
>Reporter: Keegan Standifer
>Priority: Major
>
> Elasticsearch 7.0.0 was released in April of 2019: 
> [https://www.elastic.co/blog/elasticsearch-7-0-0-released]
> The latest elasticsearch connector is 
> [flink-connector-elasticsearch6|https://github.com/apache/flink/tree/master/flink-connectors/flink-connector-elasticsearch6]



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (FLINK-13874) StreamingFileSink fails to recover (truncate) properly

2019-08-28 Thread Gyula Fora (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-13874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16918043#comment-16918043
 ] 

Gyula Fora commented on FLINK-13874:


I increased the lease timeout to 5 minutes, it still failed sometimes but it 
could recover afterwards. Namenode logs don't seem to contain any additional 
information on what happened, why it was slow. It just looks normal...

> StreamingFileSink fails to recover (truncate) properly
> --
>
> Key: FLINK-13874
> URL: https://issues.apache.org/jira/browse/FLINK-13874
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / FileSystem
>Affects Versions: 1.9.0
>Reporter: Gyula Fora
>Priority: Blocker
>
> It seems that there might be some problem with the truncate / recovery logic 
> for the HadoopRecoverableFsDataOutputStream.
> I keep hitting the following error:
>  
> {noformat}
> java.io.IOException: Problem while truncating file: 
> hdfs:/user/root/flink/filesink/transaction-test1-text/2019-08-27--07/.part-1-1.inprogress.7e882941-ab98-4404-b16b-87a26256bf4d
>   at 
> org.apache.flink.runtime.fs.hdfs.HadoopRecoverableFsDataOutputStream.safelyTruncateFile(HadoopRecoverableFsDataOutputStream.java:166)
>   at 
> org.apache.flink.runtime.fs.hdfs.HadoopRecoverableFsDataOutputStream.(HadoopRecoverableFsDataOutputStream.java:89)
>   at 
> org.apache.flink.runtime.fs.hdfs.HadoopRecoverableWriter.recover(HadoopRecoverableWriter.java:72)
>   at 
> org.apache.flink.streaming.api.functions.sink.filesystem.Bucket.restoreInProgressFile(Bucket.java:140)
>   at 
> org.apache.flink.streaming.api.functions.sink.filesystem.Bucket.(Bucket.java:127)
>   at 
> org.apache.flink.streaming.api.functions.sink.filesystem.Bucket.restore(Bucket.java:396)
>   at 
> org.apache.flink.streaming.api.functions.sink.filesystem.DefaultBucketFactoryImpl.restoreBucket(DefaultBucketFactoryImpl.java:64)
>   at 
> org.apache.flink.streaming.api.functions.sink.filesystem.Buckets.handleRestoredBucketState(Buckets.java:177)
>   at 
> org.apache.flink.streaming.api.functions.sink.filesystem.Buckets.initializeActiveBuckets(Buckets.java:165)
>   at 
> org.apache.flink.streaming.api.functions.sink.filesystem.Buckets.initializeState(Buckets.java:149)
>   at 
> org.apache.flink.streaming.api.functions.sink.filesystem.StreamingFileSink.initializeState(StreamingFileSink.java:334)
>   at 
> org.apache.flink.streaming.util.functions.StreamingFunctionUtils.tryRestoreFunction(StreamingFunctionUtils.java:178)
>   at 
> org.apache.flink.streaming.util.functions.StreamingFunctionUtils.restoreFunctionState(StreamingFunctionUtils.java:160)
>   at 
> org.apache.flink.streaming.api.operators.AbstractUdfStreamOperator.initializeState(AbstractUdfStreamOperator.java:96)
>   at 
> org.apache.flink.streaming.api.operators.AbstractStreamOperator.initializeState(AbstractStreamOperator.java:281)
>   at 
> org.apache.flink.streaming.runtime.tasks.StreamTask.initializeState(StreamTask.java:878)
>   at 
> org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:392)
>   at org.apache.flink.runtime.taskmanager.Task.doRun(Task.java:705)
>   at org.apache.flink.runtime.taskmanager.Task.run(Task.java:530)
>   at java.lang.Thread.run(Thread.java:748)
> Caused by: 
> org.apache.hadoop.ipc.RemoteException(org.apache.hadoop.hdfs.protocol.AlreadyBeingCreatedException):
>  Failed to TRUNCATE_FILE 
> /user/root/flink/filesink/transaction-test1-text/2019-08-27--07/.part-1-1.inprogress.7e882941-ab98-4404-b16b-87a26256bf4d
>  for DFSClient_NONMAPREDUCE_-1189574442_56 on 172.31.114.177 because 
> DFSClient_NONMAPREDUCE_-1189574442_56 is already the current lease holder.
>   at 
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.recoverLeaseInternal(FSNamesystem.java:2522)
>   at 
> org.apache.hadoop.hdfs.server.namenode.FSDirTruncateOp.truncate(FSDirTruncateOp.java:119)
>   at 
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.truncate(FSNamesystem.java:2091)
>   at 
> org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.truncate(NameNodeRpcServer.java:1070)
>   at 
> org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.truncate(ClientNamenodeProtocolServerSideTranslatorPB.java:669)
>   at 
> org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java)
>   at 
> org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:523)
>   at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:991)
>   at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:869)
>   at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:815)
>   at 

[GitHub] [flink] flinkbot edited a comment on issue #9383: [FLINK-13248] [runtime] Adding processing of downstream messages in AsyncWaitOperator's wait loops

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9383: [FLINK-13248] [runtime] Adding 
processing of downstream messages in AsyncWaitOperator's wait loops
URL: https://github.com/apache/flink/pull/9383#issuecomment-519130955
 
 
   
   ## CI report:
   
   * 5d8448c4813f5b362f98f898998f1278f062d807 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/122292142)
   * 4d628935e8899d6019566bfc93b5c688bc1835ec : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/122941321)
   * d7c0bd5edc65110910d79ca7c7bf2139672f8c02 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123229382)
   * b7a19fe5d83ee271e7560f90fbf07a7703937273 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123235786)
   * 7650b3b19b05ed6a121566d7c19d5e7bc71489fa : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123332630)
   * 2493723ebd2c307f47bbdfcf154a31ab97cda312 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123335647)
   * f3f0fe6d16ef3bba35d06a797196f94f372701ff : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123336279)
   * c6ee15104ee678c239367670773723920e34c26d : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123371348)
   * d0e4fbf25a8ff9982171ed982868b51ad851aaf0 : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/123472764)
   * 741386a495a5657bb654dcd0168f2d42873445e7 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/123476701)
   * 05e27c097851c65bd9a405b4aae376e2ef6c2b50 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123645059)
   * 8fba78f22bc6c0d042cb1dde270c02af08d98bbd : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/123696981)
   * 681ac331e4c0b547e1d410b448bc34ff651dbc6a : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/123698096)
   * e18739460fbcf7c59be3c9121fc26fc279e0353a : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123703814)
   * 670affbc0ae2883e93bb2f6ca3c1300fb78f26c5 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123726809)
   * 50a91cbc74c645576432d25d40e7a42190ac28e8 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123758034)
   * 2fba64d8e9fa4939c5a6c3fb3d758d55ca344b6c : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123842040)
   * 0507aa67d2f7183c3a7e4556fbf7732414647ac7 : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/123855539)
   * 9a293ae331986d8fae16f619158f1e59572cd1e9 : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/123856922)
   * 2bb1bc290a3fc8e4dc843be781063515e86509d8 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/123859379)
   * 9ff3bc6cdeaff18473a075076ae4931bbdae7173 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124474961)
   * bfc5c6d643c502ec3a7ba181d4a80286af08ca50 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124487989)
   * 0b54f92f49a56077b36856c4eda400938f2cda75 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124488476)
   * 97b0b55c896ce68a8540758a38321ddbfac139c5 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124489022)
   * fae34dfb176d977e452dd5a3e7af8838341e565f : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124489295)
   * f312b58169cdd3ce32d603c5ef410b98064c084c : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/124534465)
   * 4125a241c713c467c47cb49aacfea5b99bbe4b47 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124544764)
   * 8308ec556edf17ce57d9ff377f646f6f1bbd47fc : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124548686)
   * ffe70dd34f21b84eeb6f448ab1611e5a6a0ecaa3 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124550076)
   * b925c47fa923e0f90fd0a4ee0205ae29fe32662e : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124554252)
   * 7815bc0047f41fd2d5dc3dcbe4adbd7be514e0da : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124561559)
   * 5821301ec74ba680e5e530fe1f698ed5c12f4b11 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/124578295)
   * 9e6aa380dc9d286316c372981df091dea77b28df : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/124700113)
   * 355736bc75b13d3e9caeea1fb03c510019985bf8 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124765237)
   * 85a77bc0ffdd7a4e06e1a183950ec075b21f030f : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124872507)
   * e311962f6b0177494709cd66770bb4ef6ef11d3a : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/124889848)
   * 3d2d4be4b8b4430247a41a8e27e4305b82c99345 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/124929657)
   * 5701af5109106c4fc5c062e5f0501201429d61bf : UNKNOWN
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this 

[GitHub] [flink] flinkbot edited a comment on issue #9383: [FLINK-13248] [runtime] Adding processing of downstream messages in AsyncWaitOperator's wait loops

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9383: [FLINK-13248] [runtime] Adding 
processing of downstream messages in AsyncWaitOperator's wait loops
URL: https://github.com/apache/flink/pull/9383#issuecomment-519129010
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit 5701af5109106c4fc5c062e5f0501201429d61bf (Wed Aug 28 
19:50:08 UTC 2019)
   
   **Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up 
to date!
* **This pull request references an unassigned [Jira 
ticket](https://issues.apache.org/jira/browse/FLINK-13248).** According to the 
[code contribution 
guide](https://flink.apache.org/contributing/contribute-code.html), tickets 
need to be assigned before starting with the implementation work.
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (FLINK-12598) Flink-shaded's shade-sources profile does not work anymore

2019-08-28 Thread Chesnay Schepler (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-12598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chesnay Schepler updated FLINK-12598:
-
Fix Version/s: (was: shaded-8.0)
   shaded-9.0

> Flink-shaded's shade-sources profile does not work anymore
> --
>
> Key: FLINK-12598
> URL: https://issues.apache.org/jira/browse/FLINK-12598
> Project: Flink
>  Issue Type: Bug
>  Components: BuildSystem / Shaded
>Affects Versions: shaded-7.0
>Reporter: Nico Kruber
>Priority: Critical
>  Labels: pull-request-available
> Fix For: shaded-9.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> {code}
> > mvn clean package -Pshade-sources
> ...
> [INFO] --- maven-shade-plugin:3.0.0:shade (shade-flink) @ 
> flink-shaded-hadoop-2 ---
> [INFO] Excluding org.apache.commons:commons-compress:jar:1.18 from the shaded 
> jar.
> [INFO] Excluding org.apache.avro:avro:jar:1.8.2 from the shaded jar.
> [INFO] Including org.codehaus.jackson:jackson-core-asl:jar:1.9.13 in the 
> shaded jar.
> [INFO] Including org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13 in the 
> shaded jar.
> [INFO] Excluding com.thoughtworks.paranamer:paranamer:jar:2.7 from the shaded 
> jar.
> [INFO] Excluding org.xerial.snappy:snappy-java:jar:1.1.4 from the shaded jar.
> [INFO] Excluding org.tukaani:xz:jar:1.5 from the shaded jar.
> [INFO] Excluding org.slf4j:slf4j-api:jar:1.7.7 from the shaded jar.
> [INFO] Including org.apache.hadoop:hadoop-common:jar:2.4.1 in the shaded jar.
> [INFO] Including org.apache.hadoop:hadoop-annotations:jar:2.4.1 in the shaded 
> jar.
> [INFO] Including com.google.guava:guava:jar:11.0.2 in the shaded jar.
> [INFO] Excluding commons-cli:commons-cli:jar:1.3.1 from the shaded jar.
> [INFO] Excluding org.apache.commons:commons-math3:jar:3.5 from the shaded jar.
> [INFO] Excluding xmlenc:xmlenc:jar:0.52 from the shaded jar.
> [INFO] Including commons-httpclient:commons-httpclient:jar:3.1 in the shaded 
> jar.
> [INFO] Excluding commons-codec:commons-codec:jar:1.10 from the shaded jar.
> [INFO] Excluding commons-io:commons-io:jar:2.4 from the shaded jar.
> [INFO] Excluding commons-net:commons-net:jar:3.1 from the shaded jar.
> [INFO] Excluding commons-collections:commons-collections:jar:3.2.2 from the 
> shaded jar.
> [INFO] Excluding javax.servlet:servlet-api:jar:2.5 from the shaded jar.
> [INFO] Excluding commons-el:commons-el:jar:1.0 from the shaded jar.
> [INFO] Excluding commons-logging:commons-logging:jar:1.1.3 from the shaded 
> jar.
> [INFO] Excluding log4j:log4j:jar:1.2.17 from the shaded jar.
> [INFO] Including net.java.dev.jets3t:jets3t:jar:0.9.0 in the shaded jar.
> [INFO] Including org.apache.httpcomponents:httpclient:jar:4.5.3 in the shaded 
> jar.
> [INFO] Including org.apache.httpcomponents:httpcore:jar:4.4.6 in the shaded 
> jar.
> [INFO] Excluding com.jamesmurty.utils:java-xmlbuilder:jar:0.4 from the shaded 
> jar.
> [INFO] Excluding commons-lang:commons-lang:jar:2.6 from the shaded jar.
> [INFO] Excluding commons-configuration:commons-configuration:jar:1.7 from the 
> shaded jar.
> [INFO] Excluding commons-digester:commons-digester:jar:1.8.1 from the shaded 
> jar.
> [INFO] Excluding org.slf4j:slf4j-log4j12:jar:1.7.15 from the shaded jar.
> [INFO] Including com.google.protobuf:protobuf-java:jar:2.5.0 in the shaded 
> jar.
> [INFO] Including org.apache.hadoop:hadoop-auth:jar:2.4.1 in the shaded jar.
> [INFO] Excluding com.jcraft:jsch:jar:0.1.42 from the shaded jar.
> [INFO] Including com.google.code.findbugs:jsr305:jar:1.3.9 in the shaded jar.
> [WARNING] Could not get sources for 
> com.google.code.findbugs:jsr305:jar:1.3.9:compile
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] flink-shaded 7.0 ... SUCCESS [  0.771 
> s]
> [INFO] flink-shaded-force-shading 7.0 . SUCCESS [  0.951 
> s]
> [INFO] flink-shaded-asm-6 6.2.1-7.0 ... SUCCESS [  1.469 
> s]
> [INFO] flink-shaded-guava-18 18.0-7.0 . SKIPPED
> [INFO] flink-shaded-netty-4 4.1.32.Final-7.0 .. SKIPPED
> [INFO] flink-shaded-netty-tcnative-dynamic 2.0.25.Final-7.0 SUCCESS [  2.195 
> s]
> [INFO] flink-shaded-jackson-parent 2.9.8-7.0 .. SUCCESS [  0.161 
> s]
> [INFO] flink-shaded-jackson-2 2.9.8-7.0 ... SKIPPED
> [INFO] flink-shaded-jackson-module-jsonSchema-2 2.9.8-7.0 . SKIPPED
> [INFO] flink-shaded-hadoop-2 2.4.1-7.0  FAILURE [  2.597 
> s]
> [INFO] flink-shaded-hadoop-2-uber 2.4.1-7.0 ... SKIPPED
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 

[jira] [Closed] (FLINK-13886) Need to develop flink-connector-elasticsearch7

2019-08-28 Thread Leonid Ilyevsky (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-13886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leonid Ilyevsky closed FLINK-13886.
---
Release Note: 
See https://issues.apache.org/jira/browse/FLINK-13025

  Resolution: Duplicate

> Need to develop flink-connector-elasticsearch7
> --
>
> Key: FLINK-13886
> URL: https://issues.apache.org/jira/browse/FLINK-13886
> Project: Flink
>  Issue Type: Improvement
>  Components: Connectors / ElasticSearch
>Affects Versions: 1.8.0, 1.8.1, 1.9.0
>Reporter: Leonid Ilyevsky
>Priority: Major
>
> The flink-connector-elasticsearch6 is not compatible with Elasticsearch 7.x.
> If you try to use elasticsearch-rest-high-level-client version 7.x with 
> flink-connector-elasticsearch6 instead of 6.x, you get fatal exception:
> {{java.lang.NoSuchMethodError: 
> org.elasticsearch.client.RestHighLevelClient.ping([Lorg/apache/http/Header;)Z}}
> {{ at 
> org.apache.flink.streaming.connectors.elasticsearch6.Elasticsearch6ApiCallBridge.createClient(Elasticsearch6ApiCallBridge.java:81)}}
> {{..}}
>  
> Some changes in Elastic 7.x make it necessary to use compatible client 
> library, specifically the deprecated 'type' element in the document 
> structure. 
> With 6.x client library the 'type' element is mandatory, so it has to be in 
> each document, but then the 7.x sever will send back a warning for every 
> single document. Workaround: suppress those warnings in the logging 
> configuration.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [flink] flinkbot edited a comment on issue #9547: [FLINK-13877][hive] Support Hive version 2.1.0 and 2.1.1

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9547: [FLINK-13877][hive] Support Hive 
version 2.1.0 and 2.1.1
URL: https://github.com/apache/flink/pull/9547#issuecomment-525512048
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit c4f4353fcb2486fb375427e8f08f0e78b1a8c9a9 (Wed Aug 28 
18:55:08 UTC 2019)
   
   **Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up 
to date!
* **This pull request references an unassigned [Jira 
ticket](https://issues.apache.org/jira/browse/FLINK-13877).** According to the 
[code contribution 
guide](https://flink.apache.org/contributing/contribute-code.html), tickets 
need to be assigned before starting with the implementation work.
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] xuefuz commented on a change in pull request #9547: [FLINK-13877][hive] Support Hive version 2.1.0 and 2.1.1

2019-08-28 Thread GitBox
xuefuz commented on a change in pull request #9547: [FLINK-13877][hive] Support 
Hive version 2.1.0 and 2.1.1
URL: https://github.com/apache/flink/pull/9547#discussion_r318740225
 
 

 ##
 File path: 
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShimV210.java
 ##
 @@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.catalog.hive.client;
+
+import org.apache.flink.table.catalog.exceptions.CatalogException;
+
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.apache.hadoop.hive.metastore.HiveMetaStoreClient;
+import org.apache.hadoop.hive.metastore.IMetaStoreClient;
+import org.apache.hadoop.hive.metastore.RetryingMetaStoreClient;
+import org.apache.hadoop.hive.metastore.api.EnvironmentContext;
+import org.apache.hadoop.hive.metastore.api.InvalidOperationException;
+import org.apache.hadoop.hive.metastore.api.MetaException;
+import org.apache.hadoop.hive.metastore.api.Partition;
+import org.apache.thrift.TException;
+
+import java.lang.reflect.InvocationTargetException;
+import java.lang.reflect.Method;
+
+/**
+ * Shim for Hive version 2.1.0.
+ */
+public class HiveShimV210 extends HiveShimV122 {
+
+   @Override
+   public IMetaStoreClient getHiveMetastoreClient(HiveConf hiveConf) {
+   try {
+   Class[] constructorArgTypes = {HiveConf.class};
+   Object[] constructorArgs = {hiveConf};
+   Method method = 
RetryingMetaStoreClient.class.getMethod("getProxy", HiveConf.class,
 
 Review comment:
   Actually the implementation in HiveShimV230 is the first thing I tried. It 
didn't work. The reason is that getProxy(HiveConf hiveConf, boolean 
allowEmbedded) actually calls the same getProxy() as what I did above, but with 
additional argument HiveMetaHookLoader.class. However, we don't have an 
instance of HiveMetaHookLoader.class, and a "null" value doens't work when when 
invoking the method. 
   
   You can try and probably get a better idea of what I'm talking about here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] xuefuz commented on a change in pull request #9547: [FLINK-13877][hive] Support Hive version 2.1.0 and 2.1.1

2019-08-28 Thread GitBox
xuefuz commented on a change in pull request #9547: [FLINK-13877][hive] Support 
Hive version 2.1.0 and 2.1.1
URL: https://github.com/apache/flink/pull/9547#discussion_r318740225
 
 

 ##
 File path: 
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShimV210.java
 ##
 @@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.catalog.hive.client;
+
+import org.apache.flink.table.catalog.exceptions.CatalogException;
+
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.apache.hadoop.hive.metastore.HiveMetaStoreClient;
+import org.apache.hadoop.hive.metastore.IMetaStoreClient;
+import org.apache.hadoop.hive.metastore.RetryingMetaStoreClient;
+import org.apache.hadoop.hive.metastore.api.EnvironmentContext;
+import org.apache.hadoop.hive.metastore.api.InvalidOperationException;
+import org.apache.hadoop.hive.metastore.api.MetaException;
+import org.apache.hadoop.hive.metastore.api.Partition;
+import org.apache.thrift.TException;
+
+import java.lang.reflect.InvocationTargetException;
+import java.lang.reflect.Method;
+
+/**
+ * Shim for Hive version 2.1.0.
+ */
+public class HiveShimV210 extends HiveShimV122 {
+
+   @Override
+   public IMetaStoreClient getHiveMetastoreClient(HiveConf hiveConf) {
+   try {
+   Class[] constructorArgTypes = {HiveConf.class};
+   Object[] constructorArgs = {hiveConf};
+   Method method = 
RetryingMetaStoreClient.class.getMethod("getProxy", HiveConf.class,
 
 Review comment:
   Actually the implementation in HiveShimV230 is the first thing I tried. It 
didn't work. The reason is that getProxy(HiveConf hiveConf, boolean 
allowEmbedded) actually calls the same getProxy() as what I did above, but with 
additional argument HiveMetaHookLoader.class. However, we don't have an 
instance of HiveMetaHookLoader.class, and a "null" value doens't work when when 
instantiate the method. 
   
   You can try and probably get a better idea of what I'm talking about here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9512: [FLINK-13819][coordination] Introduce State for RpcEndpoint

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9512: [FLINK-13819][coordination] Introduce 
State for RpcEndpoint
URL: https://github.com/apache/flink/pull/9512#issuecomment-523896786
 
 
   
   ## CI report:
   
   * 5e266fe1bb72d18901c9962a5049aedd04ffd632 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124214673)
   * dcaec3b90a5732154e8cfc3ccd3897171e6cb501 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124898979)
   * c3cfcfc3f76954a38be80e57b7ce43011956ed6e : UNKNOWN
   * c13b48c3c4fbc4ff09c8f42885a73d2e8db6c4e8 : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/124920417)
   * 0e907a8da0890ce836f35ee8ab852d4bd5078fec : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/124918054)
   * d42ea8ec58a6b10a6eff6c973bebf79a69b6 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/124934337)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9553: [FLINK-13883] Remove unused AkkaOptions related to Akka's death watch

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9553: [FLINK-13883] Remove unused 
AkkaOptions related to Akka's death watch
URL: https://github.com/apache/flink/pull/9553#issuecomment-525760619
 
 
   
   ## CI report:
   
   * 9c4b2d8b30e2d85035670f8cf95d4f4e21931526 : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/124920462)
   * dac927ea057a99c04f2300154ed04f1d836d5568 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/124932011)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9554: [FLNK-13885] Remove HighAvailabilityOptions#HA_JOB_DELAY

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9554: [FLNK-13885] Remove 
HighAvailabilityOptions#HA_JOB_DELAY
URL: https://github.com/apache/flink/pull/9554#issuecomment-525760686
 
 
   
   ## CI report:
   
   * e74dc8316d107e70604679c10be31e1501f83e2c : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/124920504)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9383: [FLINK-13248] [runtime] Adding processing of downstream messages in AsyncWaitOperator's wait loops

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9383: [FLINK-13248] [runtime] Adding 
processing of downstream messages in AsyncWaitOperator's wait loops
URL: https://github.com/apache/flink/pull/9383#issuecomment-519130955
 
 
   
   ## CI report:
   
   * 5d8448c4813f5b362f98f898998f1278f062d807 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/122292142)
   * 4d628935e8899d6019566bfc93b5c688bc1835ec : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/122941321)
   * d7c0bd5edc65110910d79ca7c7bf2139672f8c02 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123229382)
   * b7a19fe5d83ee271e7560f90fbf07a7703937273 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123235786)
   * 7650b3b19b05ed6a121566d7c19d5e7bc71489fa : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123332630)
   * 2493723ebd2c307f47bbdfcf154a31ab97cda312 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123335647)
   * f3f0fe6d16ef3bba35d06a797196f94f372701ff : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123336279)
   * c6ee15104ee678c239367670773723920e34c26d : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123371348)
   * d0e4fbf25a8ff9982171ed982868b51ad851aaf0 : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/123472764)
   * 741386a495a5657bb654dcd0168f2d42873445e7 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/123476701)
   * 05e27c097851c65bd9a405b4aae376e2ef6c2b50 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123645059)
   * 8fba78f22bc6c0d042cb1dde270c02af08d98bbd : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/123696981)
   * 681ac331e4c0b547e1d410b448bc34ff651dbc6a : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/123698096)
   * e18739460fbcf7c59be3c9121fc26fc279e0353a : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123703814)
   * 670affbc0ae2883e93bb2f6ca3c1300fb78f26c5 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123726809)
   * 50a91cbc74c645576432d25d40e7a42190ac28e8 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123758034)
   * 2fba64d8e9fa4939c5a6c3fb3d758d55ca344b6c : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/123842040)
   * 0507aa67d2f7183c3a7e4556fbf7732414647ac7 : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/123855539)
   * 9a293ae331986d8fae16f619158f1e59572cd1e9 : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/123856922)
   * 2bb1bc290a3fc8e4dc843be781063515e86509d8 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/123859379)
   * 9ff3bc6cdeaff18473a075076ae4931bbdae7173 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124474961)
   * bfc5c6d643c502ec3a7ba181d4a80286af08ca50 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124487989)
   * 0b54f92f49a56077b36856c4eda400938f2cda75 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124488476)
   * 97b0b55c896ce68a8540758a38321ddbfac139c5 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124489022)
   * fae34dfb176d977e452dd5a3e7af8838341e565f : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124489295)
   * f312b58169cdd3ce32d603c5ef410b98064c084c : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/124534465)
   * 4125a241c713c467c47cb49aacfea5b99bbe4b47 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124544764)
   * 8308ec556edf17ce57d9ff377f646f6f1bbd47fc : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124548686)
   * ffe70dd34f21b84eeb6f448ab1611e5a6a0ecaa3 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124550076)
   * b925c47fa923e0f90fd0a4ee0205ae29fe32662e : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124554252)
   * 7815bc0047f41fd2d5dc3dcbe4adbd7be514e0da : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124561559)
   * 5821301ec74ba680e5e530fe1f698ed5c12f4b11 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/124578295)
   * 9e6aa380dc9d286316c372981df091dea77b28df : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/124700113)
   * 355736bc75b13d3e9caeea1fb03c510019985bf8 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124765237)
   * 85a77bc0ffdd7a4e06e1a183950ec075b21f030f : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124872507)
   * e311962f6b0177494709cd66770bb4ef6ef11d3a : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/124889848)
   * 3d2d4be4b8b4430247a41a8e27e4305b82c99345 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/124929657)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:

[GitHub] [flink] flinkbot edited a comment on issue #9552: [FLINK-13884] Set default failure rate restart strategy delay to 0s

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9552: [FLINK-13884] Set default failure 
rate restart strategy delay to 0s
URL: https://github.com/apache/flink/pull/9552#issuecomment-525754671
 
 
   
   ## CI report:
   
   * b78e598a216202595f6fd4748ca0860af3468668 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124918117)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Resolved] (FLINK-13875) Add missing redirects to the flink documentation

2019-08-28 Thread Fabian Hueske (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-13875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fabian Hueske resolved FLINK-13875.
---
  Assignee: Seth Wiesman
Resolution: Fixed

Fixed for 1.9 with 7bba0b32e779612343e069cdbab15adc77d51c0e
Fixed for 1.10 with d93e6b01c9c495318d8e10348b2110f588092042

> Add missing redirects to the flink documentation
> 
>
> Key: FLINK-13875
> URL: https://issues.apache.org/jira/browse/FLINK-13875
> Project: Flink
>  Issue Type: Bug
>  Components: Documentation
>Reporter: Seth Wiesman
>Assignee: Seth Wiesman
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.10.0, 1.9.1
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Add the following redirects.
>  
> /examples_index.md => /getting_started/examples_index.md
> /examples_index.zh.md => /getting_started/examples_index.zh.md
> /tutorials_api_tutorials.md => /getting_started/tutorials_api_tutorials.md
> /tutorials_api_tutorials.zh.md => 
> /getting_started/tutorials_api_tutorials.zh.md
> /tutorials_datastream_api.md => /getting_started/tutorials_datastream_api.md
> /tutorials_datastream_api.zh.md => 
> /getting_started/tutorials_datastream_api.zh.md
> /tutorials_flink_on_windows.md => 
> /getting_started/tutorials_flink_on_windows.md
> /tutorials_flink_on_windows.zh.md => 
> /getting_started/tutorials_flink_on_windows.zh.md
> /tutorials_index.md => /getting_started/tutorials_index.md
> /tutorials_index.zh.md => /getting_started/tutorials_index.zh.md
> /tutorials_local_setup.md => /getting_started/tutorials_local_setup.md
> /tutorials_local_setup.zh.md => /getting_started/tutorials_local_setup.zh.md
> /tutorials_setup_instructions.md => 
> /getting_started/tutorials_setup_instructions.md
> /tutorials_setup_instructions.zh.md => 
> /getting_started/tutorials_setup_instructions.zh.md



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [flink] flinkbot edited a comment on issue #9541: [FLINK-13828][configuration] Deprecate ConfigConstants.LOCAL_START_WEBSERVER

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9541: [FLINK-13828][configuration] 
Deprecate ConfigConstants.LOCAL_START_WEBSERVER
URL: https://github.com/apache/flink/pull/9541#issuecomment-525229832
 
 
   
   ## CI report:
   
   * 0c08f3537572a5b56fb18b80ae29e0606bf79f95 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/124714646)
   * 61306fae1d4f94f4d27c684c1ec70401f381ba80 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124934374)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9513: [FLINK-13769][Coordination] Close RM connection in TaskExecutor.onStop and do not reconnect

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9513: [FLINK-13769][Coordination] Close RM 
connection in TaskExecutor.onStop and do not reconnect
URL: https://github.com/apache/flink/pull/9513#issuecomment-523900462
 
 
   
   ## CI report:
   
   * 6b2b50c6454864809e8f8bcb55713cb15bad9219 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124216179)
   * d6eff6cc6ad9cf874910355fcfa433c765d41c76 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124935677)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #8175: [FLINK-9787]Change ExecutionConfig#getGlobalJobParameters to return a…

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #8175: [FLINK-9787]Change 
ExecutionConfig#getGlobalJobParameters to return a…
URL: https://github.com/apache/flink/pull/8175#issuecomment-523993728
 
 
   
   ## CI report:
   
   * fe71dc563e7d69da189c9d74f84f34fa60486121 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/124256028)
   * 7715ecd95d24c074aa90b033eb705c0becb89af1 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124888331)
   * d8ed435512599aacc4a2cd8cd25c9321b8578cb1 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124913769)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Closed] (FLINK-13820) Breaking long function argument lists and chained method calls

2019-08-28 Thread Andrey Zagrebin (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-13820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrey Zagrebin closed FLINK-13820.
---
Resolution: Done

> Breaking long function argument lists and chained method calls
> --
>
> Key: FLINK-13820
> URL: https://issues.apache.org/jira/browse/FLINK-13820
> Project: Flink
>  Issue Type: Sub-task
>  Components: Documentation, Project Website
>Reporter: Andrey Zagrebin
>Assignee: Andrey Zagrebin
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Breaking the line of too long statements (line longness is yet to be fully 
> defined) to improve code readability in case of
>  * Long function argument lists (declaration or call): void func(type1 arg1, 
> type2 arg2, ...)
>  * Long sequence of chained calls: 
> list.stream().map(...).reduce(...).collect(...)...
> Rules:
>  * Break the list of arguments/calls if the line exceeds limit or earlier if 
> you believe that the breaking would improve the code readability
>  * If you break the line then each argument/call should have a separate line, 
> including the first one
>  * Each new line argument/call should have one extra indentation relative to 
> the line of the parent function name or called entity
>  * The opening parenthesis always stays on the line of the parent function 
> name
>  * The possible thrown exception list is never broken and stays on the same 
> last line
>  * The dot of a chained call is always on the line of that chained call 
> proceeding the call at the beginning
> Examples of breaking:
>  * Function arguments
> {code:java}
> public void func(
>     int arg1,
>     int arg2,
>     ...) throws E1, E2, E3 {
>     
> }{code}
>  * Chained method calls:
> {code:java}
> values
>     .stream()
>     .map(...)
>     .collect(...);{code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [flink] flinkbot edited a comment on issue #9554: [FLNK-13885] Remove HighAvailabilityOptions#HA_JOB_DELAY

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9554: [FLNK-13885] Remove 
HighAvailabilityOptions#HA_JOB_DELAY
URL: https://github.com/apache/flink/pull/9554#issuecomment-525758494
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit e74dc8316d107e70604679c10be31e1501f83e2c (Wed Aug 28 
15:54:55 UTC 2019)
   
   **Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up 
to date!
* **Invalid pull request title: No valid Jira ID provided**
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9553: [FLINK-13883] Remove unused AkkaOptions related to Akka's death watch

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9553: [FLINK-13883] Remove unused 
AkkaOptions related to Akka's death watch
URL: https://github.com/apache/flink/pull/9553#issuecomment-525754901
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit dac927ea057a99c04f2300154ed04f1d836d5568 (Wed Aug 28 
15:53:56 UTC 2019)
   
✅no warnings
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9464: [FLINK-13751][ml] Add Built-in vector types

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9464: [FLINK-13751][ml] Add Built-in vector 
types
URL: https://github.com/apache/flink/pull/9464#issuecomment-521998582
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit 2e74776b7ef4825f6878b6d1a1ccdb4a83bf3527 (Wed Aug 28 
15:42:48 UTC 2019)
   
   **Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up 
to date!
* **This pull request references an unassigned [Jira 
ticket](https://issues.apache.org/jira/browse/FLINK-13751).** According to the 
[code contribution 
guide](https://flink.apache.org/contributing/contribute-code.html), tickets 
need to be assigned before starting with the implementation work.
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] becketqin commented on issue #9464: [FLINK-13751][ml] Add Built-in vector types

2019-08-28 Thread GitBox
becketqin commented on issue #9464: [FLINK-13751][ml] Add Built-in vector types
URL: https://github.com/apache/flink/pull/9464#issuecomment-525802732
 
 
   Merged to master:
   11258f3ee15d3ff65f0e0f34b5fac79ee5c524d2


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] becketqin closed pull request #9464: [FLINK-13751][ml] Add Built-in vector types

2019-08-28 Thread GitBox
becketqin closed pull request #9464: [FLINK-13751][ml] Add Built-in vector types
URL: https://github.com/apache/flink/pull/9464
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9551: [FLINK-13882] Remove ProcessReaper

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9551: [FLINK-13882] Remove ProcessReaper
URL: https://github.com/apache/flink/pull/9551#issuecomment-525744822
 
 
   
   ## CI report:
   
   * 08d27f8b6d5b3ed2f0fb374a080605fff33f60b8 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/124913750)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9541: [FLINK-13828][configuration] Deprecate ConfigConstants.LOCAL_START_WEBSERVER

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9541: [FLINK-13828][configuration] 
Deprecate ConfigConstants.LOCAL_START_WEBSERVER
URL: https://github.com/apache/flink/pull/9541#issuecomment-525229832
 
 
   
   ## CI report:
   
   * 0c08f3537572a5b56fb18b80ae29e0606bf79f95 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/124714646)
   * 61306fae1d4f94f4d27c684c1ec70401f381ba80 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/124934374)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9512: [FLINK-13819][coordination] Introduce State for RpcEndpoint

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9512: [FLINK-13819][coordination] Introduce 
State for RpcEndpoint
URL: https://github.com/apache/flink/pull/9512#issuecomment-523896786
 
 
   
   ## CI report:
   
   * 5e266fe1bb72d18901c9962a5049aedd04ffd632 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124214673)
   * dcaec3b90a5732154e8cfc3ccd3897171e6cb501 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124898979)
   * c3cfcfc3f76954a38be80e57b7ce43011956ed6e : UNKNOWN
   * c13b48c3c4fbc4ff09c8f42885a73d2e8db6c4e8 : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/124920417)
   * 0e907a8da0890ce836f35ee8ab852d4bd5078fec : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/124918054)
   * d42ea8ec58a6b10a6eff6c973bebf79a69b6 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/124934337)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9513: [FLINK-13769][Coordination] Close RM connection in TaskExecutor.onStop and do not reconnect

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9513: [FLINK-13769][Coordination] Close RM 
connection in TaskExecutor.onStop and do not reconnect
URL: https://github.com/apache/flink/pull/9513#issuecomment-523900462
 
 
   
   ## CI report:
   
   * 6b2b50c6454864809e8f8bcb55713cb15bad9219 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124216179)
   * d6eff6cc6ad9cf874910355fcfa433c765d41c76 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/124935677)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9464: [FLINK-13751][ml] Add Built-in vector types

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9464: [FLINK-13751][ml] Add Built-in vector 
types
URL: https://github.com/apache/flink/pull/9464#issuecomment-521998582
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit 2e74776b7ef4825f6878b6d1a1ccdb4a83bf3527 (Wed Aug 28 
15:33:35 UTC 2019)
   
   **Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up 
to date!
* **This pull request references an unassigned [Jira 
ticket](https://issues.apache.org/jira/browse/FLINK-13751).** According to the 
[code contribution 
guide](https://flink.apache.org/contributing/contribute-code.html), tickets 
need to be assigned before starting with the implementation work.
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9553: [FLINK-13883] Remove unused AkkaOptions related to Akka's death watch

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9553: [FLINK-13883] Remove unused 
AkkaOptions related to Akka's death watch
URL: https://github.com/apache/flink/pull/9553#issuecomment-525760619
 
 
   
   ## CI report:
   
   * 9c4b2d8b30e2d85035670f8cf95d4f4e21931526 : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/124920462)
   * dac927ea057a99c04f2300154ed04f1d836d5568 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/124932011)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9541: [FLINK-13828][configuration] Deprecate ConfigConstants.LOCAL_START_WEBSERVER

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9541: [FLINK-13828][configuration] 
Deprecate ConfigConstants.LOCAL_START_WEBSERVER
URL: https://github.com/apache/flink/pull/9541#issuecomment-525229832
 
 
   
   ## CI report:
   
   * 0c08f3537572a5b56fb18b80ae29e0606bf79f95 : SUCCESS 
[Build](https://travis-ci.com/flink-ci/flink/builds/124714646)
   * 61306fae1d4f94f4d27c684c1ec70401f381ba80 : UNKNOWN
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9512: [FLINK-13819][coordination] Introduce State for RpcEndpoint

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9512: [FLINK-13819][coordination] Introduce 
State for RpcEndpoint
URL: https://github.com/apache/flink/pull/9512#issuecomment-523896786
 
 
   
   ## CI report:
   
   * 5e266fe1bb72d18901c9962a5049aedd04ffd632 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124214673)
   * dcaec3b90a5732154e8cfc3ccd3897171e6cb501 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124898979)
   * c3cfcfc3f76954a38be80e57b7ce43011956ed6e : UNKNOWN
   * c13b48c3c4fbc4ff09c8f42885a73d2e8db6c4e8 : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/124920417)
   * 0e907a8da0890ce836f35ee8ab852d4bd5078fec : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/124918054)
   * d42ea8ec58a6b10a6eff6c973bebf79a69b6 : UNKNOWN
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9513: [FLINK-13769][Coordination] Close RM connection in TaskExecutor.onStop and do not reconnect

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9513: [FLINK-13769][Coordination] Close RM 
connection in TaskExecutor.onStop and do not reconnect
URL: https://github.com/apache/flink/pull/9513#issuecomment-523900462
 
 
   
   ## CI report:
   
   * 6b2b50c6454864809e8f8bcb55713cb15bad9219 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124216179)
   * d6eff6cc6ad9cf874910355fcfa433c765d41c76 : UNKNOWN
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9519: [FLINK-13826][table-planner][hive] Support INSERT OVERWRITE for Hive …

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9519: [FLINK-13826][table-planner][hive] 
Support INSERT OVERWRITE for Hive …
URL: https://github.com/apache/flink/pull/9519#issuecomment-524222175
 
 
   
   ## CI report:
   
   * 285e200cf872b81b1dec964bf5cb1619e5f6d568 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124335889)
   * 784965db1e622f17c0bd2635b6a9f7bee5d48299 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124879978)
   * 64ade163c9072e6419a1bb037e45baf1d8c1f87f : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124913676)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9513: [FLINK-13769][Coordination] Close RM connection in TaskExecutor.onStop and do not reconnect

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9513: [FLINK-13769][Coordination] Close RM 
connection in TaskExecutor.onStop and do not reconnect
URL: https://github.com/apache/flink/pull/9513#issuecomment-523896867
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit d6eff6cc6ad9cf874910355fcfa433c765d41c76 (Wed Aug 28 
15:24:25 UTC 2019)
   
   **Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up 
to date!
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9551: [FLINK-13882] Remove ProcessReaper

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9551: [FLINK-13882] Remove ProcessReaper
URL: https://github.com/apache/flink/pull/9551#issuecomment-525740540
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit 08d27f8b6d5b3ed2f0fb374a080605fff33f60b8 (Wed Aug 28 
15:23:24 UTC 2019)
   
   **Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up 
to date!
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] azagrebin commented on issue #9513: [FLINK-13769][Coordination] Close RM connection in TaskExecutor.onStop and do not reconnect

2019-08-28 Thread GitBox
azagrebin commented on issue #9513: [FLINK-13769][Coordination] Close RM 
connection in TaskExecutor.onStop and do not reconnect
URL: https://github.com/apache/flink/pull/9513#issuecomment-525795034
 
 
   Thanks @tillrohrmann 
   Rebased, merging when the Travis is green


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] azagrebin edited a comment on issue #9513: [FLINK-13769][Coordination] Close RM connection in TaskExecutor.onStop and do not reconnect

2019-08-28 Thread GitBox
azagrebin edited a comment on issue #9513: [FLINK-13769][Coordination] Close RM 
connection in TaskExecutor.onStop and do not reconnect
URL: https://github.com/apache/flink/pull/9513#issuecomment-525795034
 
 
   Thanks for the review @tillrohrmann 
   Rebased, merging when the Travis is green


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9552: [FLINK-13884] Set default failure rate restart strategy delay to 0s

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9552: [FLINK-13884] Set default failure 
rate restart strategy delay to 0s
URL: https://github.com/apache/flink/pull/9552#issuecomment-525749290
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit b78e598a216202595f6fd4748ca0860af3468668 (Wed Aug 28 
15:21:22 UTC 2019)
   
✅no warnings
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] zentol commented on a change in pull request #9552: [FLINK-13884] Set default failure rate restart strategy delay to 0s

2019-08-28 Thread GitBox
zentol commented on a change in pull request #9552: [FLINK-13884] Set default 
failure rate restart strategy delay to 0s
URL: https://github.com/apache/flink/pull/9552#discussion_r318640674
 
 

 ##
 File path: 
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java
 ##
 @@ -93,7 +93,12 @@
 * It can be specified using Scala's FiniteDuration notation: "1 min", 
"20 s".
 */
@PublicEvolving
-   public static final String RESTART_STRATEGY_FAILURE_RATE_DELAY = 
"restart-strategy.failure-rate.delay";
 
 Review comment:
   For converting constants to options so far we followed a different approach: 
add new ConfigOptions into the appropriate `*Options` class, deprecate the 
existing constant in `ConfigConstants` and link to the new option.
   Ultimately, the goal is for ConfigConstants to be fully deprecated _at some 
point_.
   
   This may be a good opportunity to move all restart-related options into a 
dedicated or existing *Options class. This would have the added benefit that 
they'd be covered by the docs generator.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9551: [FLINK-13882] Remove ProcessReaper

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9551: [FLINK-13882] Remove ProcessReaper
URL: https://github.com/apache/flink/pull/9551#issuecomment-525740540
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit 08d27f8b6d5b3ed2f0fb374a080605fff33f60b8 (Wed Aug 28 
15:12:20 UTC 2019)
   
   **Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up 
to date!
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9512: [FLINK-13819][coordination] Introduce State for RpcEndpoint

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9512: [FLINK-13819][coordination] Introduce 
State for RpcEndpoint
URL: https://github.com/apache/flink/pull/9512#issuecomment-523894000
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit d42ea8ec58a6b10a6eff6c973bebf79a69b6 (Wed Aug 28 
15:12:13 UTC 2019)
   
   **Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up 
to date!
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] azagrebin commented on issue #9512: [FLINK-13819][coordination] Introduce State for RpcEndpoint

2019-08-28 Thread GitBox
azagrebin commented on issue #9512: [FLINK-13819][coordination] Introduce State 
for RpcEndpoint
URL: https://github.com/apache/flink/pull/9512#issuecomment-525789467
 
 
   Thanks @tillrohrmann @TisonKun
   Merging the PR when the Travis is green


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9512: [FLINK-13819][coordination] Introduce State for RpcEndpoint

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9512: [FLINK-13819][coordination] Introduce 
State for RpcEndpoint
URL: https://github.com/apache/flink/pull/9512#issuecomment-523894000
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit d42ea8ec58a6b10a6eff6c973bebf79a69b6 (Wed Aug 28 
15:09:08 UTC 2019)
   
   **Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up 
to date!
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9541: [FLINK-13828][configuration] Deprecate ConfigConstants.LOCAL_START_WEBSERVER

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9541: [FLINK-13828][configuration] 
Deprecate ConfigConstants.LOCAL_START_WEBSERVER
URL: https://github.com/apache/flink/pull/9541#issuecomment-525225609
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit 61306fae1d4f94f4d27c684c1ec70401f381ba80 (Wed Aug 28 
15:07:06 UTC 2019)
   
   **Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up 
to date!
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] TisonKun commented on a change in pull request #9541: [FLINK-13828][configuration] Deprecate ConfigConstants.LOCAL_START_WEBSERVER

2019-08-28 Thread GitBox
TisonKun commented on a change in pull request #9541: 
[FLINK-13828][configuration] Deprecate ConfigConstants.LOCAL_START_WEBSERVER
URL: https://github.com/apache/flink/pull/9541#discussion_r318634860
 
 

 ##
 File path: 
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/WebFrontendITCase.java
 ##
 @@ -209,45 +198,37 @@ public void getLogAndStdoutFiles() throws Exception {
}
 
@Test
-   public void getTaskManagerLogAndStdoutFiles() {
-   try {
-   String json = 
TestBaseUtils.getFromHTTP("http://localhost:; + getRestPort() + 
"/taskmanagers/");
+   public void getTaskManagerLogAndStdoutFiles() throws Exception {
+   String json = TestBaseUtils.getFromHTTP("http://localhost:; + 
getRestPort() + "/taskmanagers/");
 
-   ObjectMapper mapper = new ObjectMapper();
-   JsonNode parsed = mapper.readTree(json);
-   ArrayNode taskManagers = (ArrayNode) 
parsed.get("taskmanagers");
-   JsonNode taskManager = taskManagers.get(0);
-   String id = taskManager.get("id").asText();
+   ObjectMapper mapper = new ObjectMapper();
+   JsonNode parsed = mapper.readTree(json);
+   ArrayNode taskManagers = (ArrayNode) parsed.get("taskmanagers");
+   JsonNode taskManager = taskManagers.get(0);
+   String id = taskManager.get("id").asText();
 
-   WebMonitorUtils.LogFileLocation logFiles = 
WebMonitorUtils.LogFileLocation.find(CLUSTER_CONFIGURATION);
+   WebMonitorUtils.LogFileLocation logFiles = 
WebMonitorUtils.LogFileLocation.find(CLUSTER_CONFIGURATION);
 
-   //we check for job manager log files, since no separate 
taskmanager logs exist
-   FileUtils.writeStringToFile(logFiles.logFile, "job 
manager log");
-   String logs = 
TestBaseUtils.getFromHTTP("http://localhost:; + getRestPort() + 
"/taskmanagers/" + id + "/log");
-   assertTrue(logs.contains("job manager log"));
+   //we check for job manager log files, since no separate 
taskmanager logs exist
+   FileUtils.writeStringToFile(logFiles.logFile, "job manager 
log");
+   String logs = TestBaseUtils.getFromHTTP("http://localhost:; + 
getRestPort() + "/taskmanagers/" + id + "/log");
+   assertTrue(logs.contains("job manager log"));
 
-   FileUtils.writeStringToFile(logFiles.stdOutFile, "job 
manager out");
-   logs = TestBaseUtils.getFromHTTP("http://localhost:; + 
getRestPort() + "/taskmanagers/" + id + "/stdout");
-   assertTrue(logs.contains("job manager out"));
-   } catch (Exception e) {
-   e.printStackTrace();
-   fail(e.getMessage());
-   }
+   FileUtils.writeStringToFile(logFiles.stdOutFile, "job manager 
out");
+   logs = TestBaseUtils.getFromHTTP("http://localhost:; + 
getRestPort() + "/taskmanagers/" + id + "/stdout");
+   assertTrue(logs.contains("job manager out"));
}
 
@Test
-   public void getConfiguration() {
-   try {
-   String config = 
TestBaseUtils.getFromHTTP("http://localhost:; + getRestPort() + 
"/jobmanager/config");
+   public void getConfiguration() throws Exception {
+   String config = TestBaseUtils.getFromHTTP("http://localhost:; + 
getRestPort() + "/jobmanager/config");
+   Map conf = 
WebMonitorUtils.fromKeyValueJsonArray(config);
 
-   Map conf = 
WebMonitorUtils.fromKeyValueJsonArray(config);
-   assertEquals(
-   
CLUSTER_CONFIGURATION.getString(ConfigConstants.LOCAL_START_WEBSERVER, null),
-   
conf.get(ConfigConstants.LOCAL_START_WEBSERVER));
-   } catch (Exception e) {
-   e.printStackTrace();
-   fail(e.getMessage());
-   }
+   String expected = 
CLUSTER_CONFIGURATION.getString(TaskManagerOptions.MANAGED_MEMORY_SIZE);
+   String actual = 
conf.get(TaskManagerOptions.MANAGED_MEMORY_SIZE.key());
+
+   assertNotNull(actual);
 
 Review comment:
   I think this prevent the case `null == null` but if we add comment above and 
assume we always set `TaskManagerOptions.MANAGED_MEMORY_SIZE` I agree that we 
can remove this one.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] TisonKun commented on a change in pull request #9541: [FLINK-13828][configuration] Deprecate ConfigConstants.LOCAL_START_WEBSERVER

2019-08-28 Thread GitBox
TisonKun commented on a change in pull request #9541: 
[FLINK-13828][configuration] Deprecate ConfigConstants.LOCAL_START_WEBSERVER
URL: https://github.com/apache/flink/pull/9541#discussion_r318634860
 
 

 ##
 File path: 
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/WebFrontendITCase.java
 ##
 @@ -209,45 +198,37 @@ public void getLogAndStdoutFiles() throws Exception {
}
 
@Test
-   public void getTaskManagerLogAndStdoutFiles() {
-   try {
-   String json = 
TestBaseUtils.getFromHTTP("http://localhost:; + getRestPort() + 
"/taskmanagers/");
+   public void getTaskManagerLogAndStdoutFiles() throws Exception {
+   String json = TestBaseUtils.getFromHTTP("http://localhost:; + 
getRestPort() + "/taskmanagers/");
 
-   ObjectMapper mapper = new ObjectMapper();
-   JsonNode parsed = mapper.readTree(json);
-   ArrayNode taskManagers = (ArrayNode) 
parsed.get("taskmanagers");
-   JsonNode taskManager = taskManagers.get(0);
-   String id = taskManager.get("id").asText();
+   ObjectMapper mapper = new ObjectMapper();
+   JsonNode parsed = mapper.readTree(json);
+   ArrayNode taskManagers = (ArrayNode) parsed.get("taskmanagers");
+   JsonNode taskManager = taskManagers.get(0);
+   String id = taskManager.get("id").asText();
 
-   WebMonitorUtils.LogFileLocation logFiles = 
WebMonitorUtils.LogFileLocation.find(CLUSTER_CONFIGURATION);
+   WebMonitorUtils.LogFileLocation logFiles = 
WebMonitorUtils.LogFileLocation.find(CLUSTER_CONFIGURATION);
 
-   //we check for job manager log files, since no separate 
taskmanager logs exist
-   FileUtils.writeStringToFile(logFiles.logFile, "job 
manager log");
-   String logs = 
TestBaseUtils.getFromHTTP("http://localhost:; + getRestPort() + 
"/taskmanagers/" + id + "/log");
-   assertTrue(logs.contains("job manager log"));
+   //we check for job manager log files, since no separate 
taskmanager logs exist
+   FileUtils.writeStringToFile(logFiles.logFile, "job manager 
log");
+   String logs = TestBaseUtils.getFromHTTP("http://localhost:; + 
getRestPort() + "/taskmanagers/" + id + "/log");
+   assertTrue(logs.contains("job manager log"));
 
-   FileUtils.writeStringToFile(logFiles.stdOutFile, "job 
manager out");
-   logs = TestBaseUtils.getFromHTTP("http://localhost:; + 
getRestPort() + "/taskmanagers/" + id + "/stdout");
-   assertTrue(logs.contains("job manager out"));
-   } catch (Exception e) {
-   e.printStackTrace();
-   fail(e.getMessage());
-   }
+   FileUtils.writeStringToFile(logFiles.stdOutFile, "job manager 
out");
+   logs = TestBaseUtils.getFromHTTP("http://localhost:; + 
getRestPort() + "/taskmanagers/" + id + "/stdout");
+   assertTrue(logs.contains("job manager out"));
}
 
@Test
-   public void getConfiguration() {
-   try {
-   String config = 
TestBaseUtils.getFromHTTP("http://localhost:; + getRestPort() + 
"/jobmanager/config");
+   public void getConfiguration() throws Exception {
+   String config = TestBaseUtils.getFromHTTP("http://localhost:; + 
getRestPort() + "/jobmanager/config");
+   Map conf = 
WebMonitorUtils.fromKeyValueJsonArray(config);
 
-   Map conf = 
WebMonitorUtils.fromKeyValueJsonArray(config);
-   assertEquals(
-   
CLUSTER_CONFIGURATION.getString(ConfigConstants.LOCAL_START_WEBSERVER, null),
-   
conf.get(ConfigConstants.LOCAL_START_WEBSERVER));
-   } catch (Exception e) {
-   e.printStackTrace();
-   fail(e.getMessage());
-   }
+   String expected = 
CLUSTER_CONFIGURATION.getString(TaskManagerOptions.MANAGED_MEMORY_SIZE);
+   String actual = 
conf.get(TaskManagerOptions.MANAGED_MEMORY_SIZE.key());
+
+   assertNotNull(actual);
 
 Review comment:
   I think this prevent the case `null == null` but if we add comment above and 
assume we always set `TaskManagerOptions.MANAGED_MEMORY_SIZE` I agree with can 
remove this one.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9553: [FLINK-13883] Remove unused AkkaOptions related to Akka's death watch

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9553: [FLINK-13883] Remove unused 
AkkaOptions related to Akka's death watch
URL: https://github.com/apache/flink/pull/9553#issuecomment-525760619
 
 
   
   ## CI report:
   
   * 9c4b2d8b30e2d85035670f8cf95d4f4e21931526 : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/124920462)
   * dac927ea057a99c04f2300154ed04f1d836d5568 : UNKNOWN
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] flinkbot edited a comment on issue #9512: [FLINK-13819][coordination] Introduce State for RpcEndpoint

2019-08-28 Thread GitBox
flinkbot edited a comment on issue #9512: [FLINK-13819][coordination] Introduce 
State for RpcEndpoint
URL: https://github.com/apache/flink/pull/9512#issuecomment-523896786
 
 
   
   ## CI report:
   
   * 5e266fe1bb72d18901c9962a5049aedd04ffd632 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124214673)
   * dcaec3b90a5732154e8cfc3ccd3897171e6cb501 : FAILURE 
[Build](https://travis-ci.com/flink-ci/flink/builds/124898979)
   * c3cfcfc3f76954a38be80e57b7ce43011956ed6e : UNKNOWN
   * c13b48c3c4fbc4ff09c8f42885a73d2e8db6c4e8 : CANCELED 
[Build](https://travis-ci.com/flink-ci/flink/builds/124920417)
   * 0e907a8da0890ce836f35ee8ab852d4bd5078fec : PENDING 
[Build](https://travis-ci.com/flink-ci/flink/builds/124918054)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


  1   2   3   4   5   >