[GitHub] [flink] flinkbot edited a comment on issue #9634: [hotfix][runtime] Streaming runtime 1.9 improvements for debuggability
flinkbot edited a comment on issue #9634: [hotfix][runtime] Streaming runtime 1.9 improvements for debuggability URL: https://github.com/apache/flink/pull/9634#issuecomment-528758790 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 313d9b3295124b77fee967c76f63f5aef9bd3db8 (Mon Sep 09 04:42:50 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] zhijiangW commented on issue #9634: [hotfix][runtime] Streaming runtime 1.9 improvements for debuggability
zhijiangW commented on issue #9634: [hotfix][runtime] Streaming runtime 1.9 improvements for debuggability URL: https://github.com/apache/flink/pull/9634#issuecomment-529297356 @1u0 After confirming with @pnowojski , I think we could only make the hotfix of thread name in release-1.9, so could you retain only this commit in PR then I could merge it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9647: [FLINK-14005][hive] Support Hive version 2.2.0
flinkbot edited a comment on issue #9647: [FLINK-14005][hive] Support Hive version 2.2.0 URL: https://github.com/apache/flink/pull/9647#issuecomment-529283547 ## CI report: * cab04a32f620acef83f46bc111512b748b4acce8 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/126386345) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Comment Edited] (FLINK-13619) Update FlinkKafkaProducerMigrationOperatorTest to restore from 1.9 savepoint
[ https://issues.apache.org/jira/browse/FLINK-13619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925343#comment-16925343 ] Piotr Nowojski edited comment on FLINK-13619 at 9/9/19 4:05 AM: By a nature of this test, it's restoring from 0.11 version, it can not generate it's own resources. As it's stated in the java doc: {code:java} @Override public String getOperatorSnapshotPath(MigrationVersion version) { return "src/test/resources/kafka-0.11-migration-kafka-producer-flink-" + version + "-snapshot"; } /** * This test depends on the resources generated by {@link FlinkKafkaProducer011MigrationTest}. * Run {@link FlinkKafkaProducer011MigrationTest#writeSnapshot()} and copy the created resource * file to the path specified by the {@link #getOperatorSnapshotPath(MigrationVersion)} method. */ {code} Name {{kafka-migration-kafka-producer-flink.}} is used for the migration tests between Flink versions, while keeping the same Kafka version. was (Author: pnowojski): By a nature of this test, it's restoring from 0.11 version, it can not generate it's own resources. As it's stated in the java doc: {code:java} @Override public String getOperatorSnapshotPath(MigrationVersion version) { return "src/test/resources/kafka-0.11-migration-kafka-producer-flink-" + version + "-snapshot"; } /** * This test depends on the resources generated by {@link FlinkKafkaProducer011MigrationTest}. * Run {@link FlinkKafkaProducer011MigrationTest#writeSnapshot()} and copy the created resource * file to the path specified by the {@link #getOperatorSnapshotPath(MigrationVersion)} method. */ {code} Name {{kafka-migration-kafka-producer-flink.}} is reserved for the migration tests between Flink versions, while keeping the same Kafka version. > Update FlinkKafkaProducerMigrationOperatorTest to restore from 1.9 savepoint > > > Key: FLINK-13619 > URL: https://issues.apache.org/jira/browse/FLINK-13619 > Project: Flink > Issue Type: Sub-task > Components: Connectors / Kafka, Tests >Affects Versions: 1.10.0 >Reporter: Till Rohrmann >Assignee: vinoyang >Priority: Blocker > Fix For: 1.10.0 > > > Update {{FlinkKafkaProducerMigrationOperatorTest}} to restore from 1.9 > savepoint. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (FLINK-13619) Update FlinkKafkaProducerMigrationOperatorTest to restore from 1.9 savepoint
[ https://issues.apache.org/jira/browse/FLINK-13619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925343#comment-16925343 ] Piotr Nowojski commented on FLINK-13619: By a nature of this test, it's restoring from 0.11 version, it can not generate it's own resources. As it's stated in the java doc: {code:java} @Override public String getOperatorSnapshotPath(MigrationVersion version) { return "src/test/resources/kafka-0.11-migration-kafka-producer-flink-" + version + "-snapshot"; } /** * This test depends on the resources generated by {@link FlinkKafkaProducer011MigrationTest}. * Run {@link FlinkKafkaProducer011MigrationTest#writeSnapshot()} and copy the created resource * file to the path specified by the {@link #getOperatorSnapshotPath(MigrationVersion)} method. */ {code} Name {{kafka-migration-kafka-producer-flink.}} is reserved for the migration tests between Flink versions, while keeping the same Kafka version. > Update FlinkKafkaProducerMigrationOperatorTest to restore from 1.9 savepoint > > > Key: FLINK-13619 > URL: https://issues.apache.org/jira/browse/FLINK-13619 > Project: Flink > Issue Type: Sub-task > Components: Connectors / Kafka, Tests >Affects Versions: 1.10.0 >Reporter: Till Rohrmann >Assignee: vinoyang >Priority: Blocker > Fix For: 1.10.0 > > > Update {{FlinkKafkaProducerMigrationOperatorTest}} to restore from 1.9 > savepoint. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (FLINK-14006) Add doc for how to using Java UDFs in Python API
[ https://issues.apache.org/jira/browse/FLINK-14006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-14006: Description: Currently, user can not find out the doc for how to using Java UDFs in Python API. So we should add the detail doc. In [https://ci.apache.org/projects/flink/flink-docs-master/dev/table/udfs.html] only describe how to using the APIs, but do not mention how to add the JARs to the class path. was:Currently, user can not find out the doc for how to using Java UDFs in Python API. So we should add the detail doc. > Add doc for how to using Java UDFs in Python API > > > Key: FLINK-14006 > URL: https://issues.apache.org/jira/browse/FLINK-14006 > Project: Flink > Issue Type: Improvement > Components: API / Python, Documentation >Reporter: sunjincheng >Priority: Major > Fix For: 1.10.0 > > > Currently, user can not find out the doc for how to using Java UDFs in > Python API. So we should add the detail doc. > > In > [https://ci.apache.org/projects/flink/flink-docs-master/dev/table/udfs.html] > only describe how to using the APIs, but do not mention how to add the JARs > to the class path. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Created] (FLINK-14007) Add doc for how to using Java user-defined source/sink in Python API
sunjincheng created FLINK-14007: --- Summary: Add doc for how to using Java user-defined source/sink in Python API Key: FLINK-14007 URL: https://issues.apache.org/jira/browse/FLINK-14007 Project: Flink Issue Type: Improvement Components: API / Python, Documentation Reporter: sunjincheng Fix For: 1.10.0 Currently, user can not find out the doc for how to using Java user-defined source/sink in Python API. So we should add the detail doc. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [flink] flinkbot edited a comment on issue #9646: [FLINK-14004][task] Define SourceReader interface to verify the integration with StreamOneInputProcessor
flinkbot edited a comment on issue #9646: [FLINK-14004][task] Define SourceReader interface to verify the integration with StreamOneInputProcessor URL: https://github.com/apache/flink/pull/9646#issuecomment-529229460 ## CI report: * 4f286e24aa0bb04d8e6cc81d64dc7e9ac642b012 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/126367829) * 4208f77cade9cbf9c333e877225b2419e5e3e63e : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/126382681) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9647: [FLINK-14005][hive] Support Hive version 2.2.0
flinkbot edited a comment on issue #9647: [FLINK-14005][hive] Support Hive version 2.2.0 URL: https://github.com/apache/flink/pull/9647#issuecomment-529283547 ## CI report: * cab04a32f620acef83f46bc111512b748b4acce8 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/126386345) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (FLINK-14006) Add doc for how to using Java UDFs in Python API
sunjincheng created FLINK-14006: --- Summary: Add doc for how to using Java UDFs in Python API Key: FLINK-14006 URL: https://issues.apache.org/jira/browse/FLINK-14006 Project: Flink Issue Type: Improvement Components: API / Python, Documentation Reporter: sunjincheng Fix For: 1.10.0 Currently, user can not find out the doc for how to using Java UDFs in Python API. So we should add the detail doc. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [flink] flinkbot commented on issue #9647: [FLINK-14005][hive] Support Hive version 2.2.0
flinkbot commented on issue #9647: [FLINK-14005][hive] Support Hive version 2.2.0 URL: https://github.com/apache/flink/pull/9647#issuecomment-529283547 ## CI report: * cab04a32f620acef83f46bc111512b748b4acce8 : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #9647: [FLINK-14005][hive] Support Hive version 2.2.0
flinkbot commented on issue #9647: [FLINK-14005][hive] Support Hive version 2.2.0 URL: https://github.com/apache/flink/pull/9647#issuecomment-529282630 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit cab04a32f620acef83f46bc111512b748b4acce8 (Mon Sep 09 03:01:54 UTC 2019) **Warnings:** * **1 pom.xml files were touched**: Check for build and licensing issues. * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] xuefuz commented on issue #9647: [FLINK-14005][hive] Support Hive version 2.2.0
xuefuz commented on issue #9647: [FLINK-14005][hive] Support Hive version 2.2.0 URL: https://github.com/apache/flink/pull/9647#issuecomment-529282367 cc: @bowenli86 @lirui-apache @zjuwangg This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] xuefuz opened a new pull request #9647: [FLINK-14005][hive] Support Hive version 2.2.0
xuefuz opened a new pull request #9647: [FLINK-14005][hive] Support Hive version 2.2.0 URL: https://github.com/apache/flink/pull/9647 ## What is the purpose of the change Support Hive 2.2.0 ## Brief change log - Added new shim for the version - Adjust inheritance relationships between the shims ## Verifying this change This change is already covered by existing tests, and manually ran the tests for all versions. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (FLINK-14005) Support Hive version 2.2.0
[ https://issues.apache.org/jira/browse/FLINK-14005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xuefu Zhang updated FLINK-14005: Description: (was: Including 2.0.0 and 2.0.1.) > Support Hive version 2.2.0 > -- > > Key: FLINK-14005 > URL: https://issues.apache.org/jira/browse/FLINK-14005 > Project: Flink > Issue Type: Improvement > Components: Connectors / Hive >Reporter: Xuefu Zhang >Assignee: Xuefu Zhang >Priority: Major > Labels: pull-request-available > Fix For: 1.10.0 > > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Created] (FLINK-14005) Support Hive version 2.2.0
Xuefu Zhang created FLINK-14005: --- Summary: Support Hive version 2.2.0 Key: FLINK-14005 URL: https://issues.apache.org/jira/browse/FLINK-14005 Project: Flink Issue Type: Improvement Components: Connectors / Hive Reporter: Xuefu Zhang Assignee: Xuefu Zhang Fix For: 1.10.0 Including 2.0.0 and 2.0.1. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [flink] flinkbot edited a comment on issue #9635: [hotfix][runtime] Rename StreamTask's performDefaultAction method to processInput
flinkbot edited a comment on issue #9635: [hotfix][runtime] Rename StreamTask's performDefaultAction method to processInput URL: https://github.com/apache/flink/pull/9635#issuecomment-528762211 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 47780ee7ffe484a87e03f533d035f1fef50bb28b (Mon Sep 09 02:34:34 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] zhijiangW merged pull request #9635: [hotfix][runtime] Rename StreamTask's performDefaultAction method to processInput
zhijiangW merged pull request #9635: [hotfix][runtime] Rename StreamTask's performDefaultAction method to processInput URL: https://github.com/apache/flink/pull/9635 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9646: [FLINK-14004][task] Define SourceReader interface to verify the integration with StreamOneInputProcessor
flinkbot edited a comment on issue #9646: [FLINK-14004][task] Define SourceReader interface to verify the integration with StreamOneInputProcessor URL: https://github.com/apache/flink/pull/9646#issuecomment-529229460 ## CI report: * 4f286e24aa0bb04d8e6cc81d64dc7e9ac642b012 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/126367829) * 4208f77cade9cbf9c333e877225b2419e5e3e63e : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/126382681) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9646: [FLINK-14004][task] Define SourceReader interface to verify the integration with StreamOneInputProcessor
flinkbot edited a comment on issue #9646: [FLINK-14004][task] Define SourceReader interface to verify the integration with StreamOneInputProcessor URL: https://github.com/apache/flink/pull/9646#issuecomment-529229460 ## CI report: * 4f286e24aa0bb04d8e6cc81d64dc7e9ac642b012 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/126367829) * 4208f77cade9cbf9c333e877225b2419e5e3e63e : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #8479: [FLINK-11193][State Backends]Use user passed configuration overriding default configuration loading from file
flinkbot edited a comment on issue #8479: [FLINK-11193][State Backends]Use user passed configuration overriding default configuration loading from file URL: https://github.com/apache/flink/pull/8479#issuecomment-493753515 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 5ea92ef187594218f4eeb733df93a7e82a8d2bb9 (Mon Sep 09 01:12:08 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] Aitozi commented on issue #8479: [FLINK-11193][State Backends]Use user passed configuration overriding default configuration loading from file
Aitozi commented on issue #8479: [FLINK-11193][State Backends]Use user passed configuration overriding default configuration loading from file URL: https://github.com/apache/flink/pull/8479#issuecomment-529266944 Please take a look again when you have time, I have fixed following your comments. @azagrebin This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-13872) Translate Operations Playground to Chinese
[ https://issues.apache.org/jira/browse/FLINK-13872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925285#comment-16925285 ] Lord i Will commented on FLINK-13872: - [~fhueske] OK, i will fetch all and go ahead > Translate Operations Playground to Chinese > -- > > Key: FLINK-13872 > URL: https://issues.apache.org/jira/browse/FLINK-13872 > Project: Flink > Issue Type: Task > Components: chinese-translation, Documentation >Affects Versions: 1.9.0 >Reporter: Fabian Hueske >Assignee: Lord i Will >Priority: Major > > The [Operations > Playground|https://ci.apache.org/projects/flink/flink-docs-release-1.9/getting-started/docker-playgrounds/flink_operations_playground.html] > is a quick and convenient way to learn about Flink's operational features > (job submission, failure recovery, job updates, scaling, metrics). > We should translate it to Chinese as well. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [flink] flinkbot edited a comment on issue #9646: [FLINK-14004][task] Define SourceReader interface to verify the integration with StreamOneInputProcessor
flinkbot edited a comment on issue #9646: [FLINK-14004][task] Define SourceReader interface to verify the integration with StreamOneInputProcessor URL: https://github.com/apache/flink/pull/9646#issuecomment-529229460 ## CI report: * 4f286e24aa0bb04d8e6cc81d64dc7e9ac642b012 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/126367829) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9646: [FLINK-14004][task] Define SourceReader interface to verify the integration with StreamOneInputProcessor
flinkbot edited a comment on issue #9646: [FLINK-14004][task] Define SourceReader interface to verify the integration with StreamOneInputProcessor URL: https://github.com/apache/flink/pull/9646#issuecomment-529229460 ## CI report: * 4f286e24aa0bb04d8e6cc81d64dc7e9ac642b012 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/126367829) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-14003) Add access to customized state other than built in state types
[ https://issues.apache.org/jira/browse/FLINK-14003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925228#comment-16925228 ] Yu Li commented on FLINK-14003: --- Thanks for creating the JIRA and start the discussion [~dangdangdang]. To follow our [contribution guideline|https://flink.apache.org/contributing/contribute-code.html], let's first get consensus on the mailing list discussion, draft a FLIP and get it through, then come back to talk more about details (if necessary) in this JIRA. > Add access to customized state other than built in state types > -- > > Key: FLINK-14003 > URL: https://issues.apache.org/jira/browse/FLINK-14003 > Project: Flink > Issue Type: Wish > Components: Runtime / State Backends >Reporter: Shimin Yang >Priority: Minor > > Currently the keyed state backend supports states like value, list, map, > although they are quite useful, but it may not fits all user cases. > User can develop their customized state backend based on different data store > as a plugin, but they do not have access to customized state if the type is > not one of those built-in types. > I propose to add getPartitionedState method to RuntimeContext and > KeyedStateStore interface to allow user to access their customized state, and > it will not affect current code path. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [flink] flinkbot commented on issue #9646: [FLINK-14004][task] Define SourceReader interface to verify the integration with StreamOneInputProcessor
flinkbot commented on issue #9646: [FLINK-14004][task] Define SourceReader interface to verify the integration with StreamOneInputProcessor URL: https://github.com/apache/flink/pull/9646#issuecomment-529229460 ## CI report: * 4f286e24aa0bb04d8e6cc81d64dc7e9ac642b012 : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #9646: [FLINK-14004][task] Define SourceReader interface to verify the integration with StreamOneInputProcessor
flinkbot commented on issue #9646: [FLINK-14004][task] Define SourceReader interface to verify the integration with StreamOneInputProcessor URL: https://github.com/apache/flink/pull/9646#issuecomment-529228507 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 4f286e24aa0bb04d8e6cc81d64dc7e9ac642b012 (Sun Sep 08 18:14:58 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (FLINK-14004) Define SourceReader interface to verify the integration with StreamOneInputProcessor
[ https://issues.apache.org/jira/browse/FLINK-14004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-14004: --- Labels: pull-request-available (was: ) > Define SourceReader interface to verify the integration with > StreamOneInputProcessor > > > Key: FLINK-14004 > URL: https://issues.apache.org/jira/browse/FLINK-14004 > Project: Flink > Issue Type: Sub-task > Components: Runtime / Task >Reporter: zhijiang >Assignee: zhijiang >Priority: Minor > Labels: pull-request-available > > We already refactored the task input and output sides based on the new source > characters in FLIP-27. In order to further verify that the new source reader > could work well with the unified StreamOneInputProcessor in mailbox model, we > would design a unit test for integrating the whole process. In detail: > * Define SourceReader and SourceOutput relevant interfaces based on FLIP-27 > * Implement an example of stateless SourceReader (bounded sequence of > integers) > * Define SourceReaderOperator to integrate the SourceReader with > StreamOneInputProcessor > * Define SourceReaderStreamTask to execute the source input and implement a > unit test for it. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [flink] zhijiangW opened a new pull request #9646: [FLINK-14004][task] Define SourceReader interface to verify the integration with StreamOneInputProcessor
zhijiangW opened a new pull request #9646: [FLINK-14004][task] Define SourceReader interface to verify the integration with StreamOneInputProcessor URL: https://github.com/apache/flink/pull/9646 ## What is the purpose of the change We already refactored the task input and output sides based on the new source characters in FLIP-27. In order to further verify that the new source reader could work well with the unified `StreamOneInputProcessor` in mailbox model, we implement a unit test for integrating the whole process. In detail: - Define `SourceReader` and `SourceOutput` relevant interfaces based on FLIP-27. - Implement an example of stateless `SourceReader` (bounded sequence of integers). - Define `SourceReaderOperator` to integrate the SourceReader with `StreamOneInputProcessor`. - Define `SourceReaderStreamTask` to execute the source input and implement a unit test for it. Note: This PR is based on #9478 and #9483 , so only review the last commit for this PR scope. ## Brief change log - Define `SourceReader` and `SourceOutput` relevant interfaces based on FLIP-27. - Define `AbstractDataOutput` as the base class for both source output and network output. - Refactor the previous processes based on `AbstractDataOutput`. - Define `SourceReaderOperator` to wrap the `SourceReader`. - Define `SourceReaderStreamTask` to generate the source input and output for `StreamOneInputProcessor`. ## Verifying this change - Added unit test in `SourceReaderStreamTaskTest` for verifying that the source reader could be integrated well with `StreamOneInputProcessor`. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**yes** / no) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (FLINK-14004) Define SourceReader interface to verify the integration with StreamOneInputProcessor
zhijiang created FLINK-14004: Summary: Define SourceReader interface to verify the integration with StreamOneInputProcessor Key: FLINK-14004 URL: https://issues.apache.org/jira/browse/FLINK-14004 Project: Flink Issue Type: Sub-task Components: Runtime / Task Reporter: zhijiang Assignee: zhijiang We already refactored the task input and output sides based on the new source characters in FLIP-27. In order to further verify that the new source reader could work well with the unified StreamOneInputProcessor in mailbox model, we would design a unit test for integrating the whole process. In detail: * Define SourceReader and SourceOutput relevant interfaces based on FLIP-27 * Implement an example of stateless SourceReader (bounded sequence of integers) * Define SourceReaderOperator to integrate the SourceReader with StreamOneInputProcessor * Define SourceReaderStreamTask to execute the source input and implement a unit test for it. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (FLINK-7151) Add a function SQL DDL
[ https://issues.apache.org/jira/browse/FLINK-7151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925215#comment-16925215 ] Zhenqiu Huang commented on FLINK-7151: -- [~phoenixjiangnan] Please try to access it now. > Add a function SQL DDL > -- > > Key: FLINK-7151 > URL: https://issues.apache.org/jira/browse/FLINK-7151 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / API >Reporter: yuemeng >Assignee: Shuyi Chen >Priority: Critical > Fix For: 1.10.0 > > > Based on create function and table.we can register a udf,udaf,udtf use sql: > {code} > CREATE FUNCTION [IF NOT EXISTS] [catalog_name.db_name.]function_name AS > class_name [WITH (properties.)]; > DROP FUNCTION [IF EXISTS] [catalog_name.db_name.]function_name; > ALTER FUNCTION [IF EXISTS] [catalog_name.db_name.]function_name RENAME TO > new_name; > {code} > {code} > CREATE function 'TOPK' AS > 'com..aggregate.udaf.distinctUdaf.topk.ITopKUDAF'; > INSERT INTO db_sink SELECT id, TOPK(price, 5, 'DESC') FROM kafka_source GROUP > BY id; > {code} > This ticket can assume that the function class is already loaded in classpath > by users. Advanced syntax like to how to dynamically load udf libraries from > external locations can be on a separate ticket. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [flink] flinkbot edited a comment on issue #8479: [FLINK-11193][State Backends]Use user passed configuration overriding default configuration loading from file
flinkbot edited a comment on issue #8479: [FLINK-11193][State Backends]Use user passed configuration overriding default configuration loading from file URL: https://github.com/apache/flink/pull/8479#issuecomment-526521132 ## CI report: * fdd6f0e24a689b70d15b2dc190fc2fc3b0600bfa : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125200442) * 341702cb226b8c34f077e9350fa656e9e2b120d4 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125915214) * 5ea92ef187594218f4eeb733df93a7e82a8d2bb9 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/126359986) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #8479: [FLINK-11193][State Backends]Use user passed configuration overriding default configuration loading from file
flinkbot edited a comment on issue #8479: [FLINK-11193][State Backends]Use user passed configuration overriding default configuration loading from file URL: https://github.com/apache/flink/pull/8479#issuecomment-526521132 ## CI report: * fdd6f0e24a689b70d15b2dc190fc2fc3b0600bfa : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125200442) * 341702cb226b8c34f077e9350fa656e9e2b120d4 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125915214) * 5ea92ef187594218f4eeb733df93a7e82a8d2bb9 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/126359986) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #8479: [FLINK-11193][State Backends]Use user passed configuration overriding default configuration loading from file
flinkbot edited a comment on issue #8479: [FLINK-11193][State Backends]Use user passed configuration overriding default configuration loading from file URL: https://github.com/apache/flink/pull/8479#issuecomment-526521132 ## CI report: * fdd6f0e24a689b70d15b2dc190fc2fc3b0600bfa : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125200442) * 341702cb226b8c34f077e9350fa656e9e2b120d4 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125915214) * 5ea92ef187594218f4eeb733df93a7e82a8d2bb9 : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9433: [FLINK-13708] [table-planner-blink] transformations should be cleared after execution in blink planner
flinkbot edited a comment on issue #9433: [FLINK-13708] [table-planner-blink] transformations should be cleared after execution in blink planner URL: https://github.com/apache/flink/pull/9433#issuecomment-521131546 ## CI report: * 22d047614613c293a7aca416268449b3cabcad6a : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123164756) * 255e8d57f2eabf7fbfeefe73f10287493e8a5c2d : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123375768) * aacac7867ac81946a8e4427334e91c65c0d3e08f : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123451412) * e68d7394eaba76a806020b12bf4d3ea61cb4f8f3 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/123482934) * b77e7a21d562a83717793490573fab7dfe297b78 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/126357307) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9433: [FLINK-13708] [table-planner-blink] transformations should be cleared after execution in blink planner
flinkbot edited a comment on issue #9433: [FLINK-13708] [table-planner-blink] transformations should be cleared after execution in blink planner URL: https://github.com/apache/flink/pull/9433#issuecomment-521131546 ## CI report: * 22d047614613c293a7aca416268449b3cabcad6a : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123164756) * 255e8d57f2eabf7fbfeefe73f10287493e8a5c2d : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123375768) * aacac7867ac81946a8e4427334e91c65c0d3e08f : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123451412) * e68d7394eaba76a806020b12bf4d3ea61cb4f8f3 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/123482934) * b77e7a21d562a83717793490573fab7dfe297b78 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/126357307) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9433: [FLINK-13708] [table-planner-blink] transformations should be cleared after execution in blink planner
flinkbot edited a comment on issue #9433: [FLINK-13708] [table-planner-blink] transformations should be cleared after execution in blink planner URL: https://github.com/apache/flink/pull/9433#issuecomment-521131546 ## CI report: * 22d047614613c293a7aca416268449b3cabcad6a : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123164756) * 255e8d57f2eabf7fbfeefe73f10287493e8a5c2d : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123375768) * aacac7867ac81946a8e4427334e91c65c0d3e08f : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123451412) * e68d7394eaba76a806020b12bf4d3ea61cb4f8f3 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/123482934) * b77e7a21d562a83717793490573fab7dfe297b78 : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9433: [FLINK-13708] [table-planner-blink] transformations should be cleared after execution in blink planner
flinkbot edited a comment on issue #9433: [FLINK-13708] [table-planner-blink] transformations should be cleared after execution in blink planner URL: https://github.com/apache/flink/pull/9433#issuecomment-521129021 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit b77e7a21d562a83717793490573fab7dfe297b78 (Sun Sep 08 13:07:12 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] godfreyhe commented on issue #9433: [FLINK-13708] [table-planner-blink] transformations should be cleared after execution in blink planner
godfreyhe commented on issue #9433: [FLINK-13708] [table-planner-blink] transformations should be cleared after execution in blink planner URL: https://github.com/apache/flink/pull/9433#issuecomment-529200827 so sorry for late reply, and thanks all guys for the suggestion. The implementation of Blink `StreamExecutor` is same with Flink `StreamExecutor` now, except two added `getStreamGraph` methods: one is for `explain` method, and another is for sql client. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-13821) Website must link to License etc
[ https://issues.apache.org/jira/browse/FLINK-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925166#comment-16925166 ] Robert Metzger commented on FLINK-13821: Very nice, thank you! > Website must link to License etc > > > Key: FLINK-13821 > URL: https://issues.apache.org/jira/browse/FLINK-13821 > Project: Flink > Issue Type: Bug > Components: Project Website >Reporter: Sebb >Assignee: Robert Metzger >Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > ASF project websites must have certain links: > Apachecon > License > Thanks > Security > Sponsor/Donat > Please see: > https://whimsy.apache.org/site/project/flink -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [flink] flinkbot edited a comment on issue #9433: [FLINK-13708] [table-planner-blink] transformations should be cleared after execution in blink planner
flinkbot edited a comment on issue #9433: [FLINK-13708] [table-planner-blink] transformations should be cleared after execution in blink planner URL: https://github.com/apache/flink/pull/9433#issuecomment-521129021 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit b77e7a21d562a83717793490573fab7dfe297b78 (Sun Sep 08 13:00:04 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #8303: [FLINK-12343] [flink-yarn] add file replication config for yarn configuration
flinkbot edited a comment on issue #8303: [FLINK-12343] [flink-yarn] add file replication config for yarn configuration URL: https://github.com/apache/flink/pull/8303#issuecomment-511684151 ## CI report: * 6a7ca58b4a04f6dce250045e021702e67e82b893 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/119421914) * 4d38a8df0d59734c4b2386689a2f17b9f2b44b12 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/119441376) * 9c14836f8639e98d58cf7bb32e38b938b3843994 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/119577044) * 76186776c5620598a19234245bbd05dfdfb1c62c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/120113740) * 628ca7b316ad3968c90192a47a84dd01f26e2578 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/122381349) * d204a725ff3c8a046cbd1b84e34d9e3ae8aafeac : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123620485) * 143efadbdb6c4681569d5b412a175edfb1633b85 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123637809) * b78b64a82ed2a9a92886095ec42f06d5082ad830 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123671219) * 5145a0b9d6b320456bb971d96b9cc47707c8fd28 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125476639) * 0d4d944c28c59ca1caa6c453c347ec786b40d245 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125762588) * 91552c3804f5e96cc573e6ed48756f2b54c037d4 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125844084) * fbf6d2850b6aa7c303981e6f5b24b0da0956b820 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/126086321) * 45282a2139ec3c7196ba10b6fb829b0ec275 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/126350641) * cc515180d99fa35b482c61c2e264e77760e55dc5 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/126354591) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #8303: [FLINK-12343] [flink-yarn] add file replication config for yarn configuration
flinkbot edited a comment on issue #8303: [FLINK-12343] [flink-yarn] add file replication config for yarn configuration URL: https://github.com/apache/flink/pull/8303#issuecomment-511684151 ## CI report: * 6a7ca58b4a04f6dce250045e021702e67e82b893 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/119421914) * 4d38a8df0d59734c4b2386689a2f17b9f2b44b12 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/119441376) * 9c14836f8639e98d58cf7bb32e38b938b3843994 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/119577044) * 76186776c5620598a19234245bbd05dfdfb1c62c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/120113740) * 628ca7b316ad3968c90192a47a84dd01f26e2578 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/122381349) * d204a725ff3c8a046cbd1b84e34d9e3ae8aafeac : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123620485) * 143efadbdb6c4681569d5b412a175edfb1633b85 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123637809) * b78b64a82ed2a9a92886095ec42f06d5082ad830 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123671219) * 5145a0b9d6b320456bb971d96b9cc47707c8fd28 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125476639) * 0d4d944c28c59ca1caa6c453c347ec786b40d245 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125762588) * 91552c3804f5e96cc573e6ed48756f2b54c037d4 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125844084) * fbf6d2850b6aa7c303981e6f5b24b0da0956b820 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/126086321) * 45282a2139ec3c7196ba10b6fb829b0ec275 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/126350641) * cc515180d99fa35b482c61c2e264e77760e55dc5 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/126354591) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #8303: [FLINK-12343] [flink-yarn] add file replication config for yarn configuration
flinkbot edited a comment on issue #8303: [FLINK-12343] [flink-yarn] add file replication config for yarn configuration URL: https://github.com/apache/flink/pull/8303#issuecomment-511684151 ## CI report: * 6a7ca58b4a04f6dce250045e021702e67e82b893 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/119421914) * 4d38a8df0d59734c4b2386689a2f17b9f2b44b12 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/119441376) * 9c14836f8639e98d58cf7bb32e38b938b3843994 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/119577044) * 76186776c5620598a19234245bbd05dfdfb1c62c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/120113740) * 628ca7b316ad3968c90192a47a84dd01f26e2578 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/122381349) * d204a725ff3c8a046cbd1b84e34d9e3ae8aafeac : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123620485) * 143efadbdb6c4681569d5b412a175edfb1633b85 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123637809) * b78b64a82ed2a9a92886095ec42f06d5082ad830 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123671219) * 5145a0b9d6b320456bb971d96b9cc47707c8fd28 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125476639) * 0d4d944c28c59ca1caa6c453c347ec786b40d245 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125762588) * 91552c3804f5e96cc573e6ed48756f2b54c037d4 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125844084) * fbf6d2850b6aa7c303981e6f5b24b0da0956b820 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/126086321) * 45282a2139ec3c7196ba10b6fb829b0ec275 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/126350641) * cc515180d99fa35b482c61c2e264e77760e55dc5 : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #8303: [FLINK-12343] [flink-yarn] add file replication config for yarn configuration
flinkbot edited a comment on issue #8303: [FLINK-12343] [flink-yarn] add file replication config for yarn configuration URL: https://github.com/apache/flink/pull/8303#issuecomment-487385120 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit cc515180d99fa35b482c61c2e264e77760e55dc5 (Sun Sep 08 11:17:10 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ✅ 1. The [description] looks good. - Approved by @rmetzger [PMC] * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #8303: [FLINK-12343] [flink-yarn] add file replication config for yarn configuration
flinkbot edited a comment on issue #8303: [FLINK-12343] [flink-yarn] add file replication config for yarn configuration URL: https://github.com/apache/flink/pull/8303#issuecomment-511684151 ## CI report: * 6a7ca58b4a04f6dce250045e021702e67e82b893 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/119421914) * 4d38a8df0d59734c4b2386689a2f17b9f2b44b12 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/119441376) * 9c14836f8639e98d58cf7bb32e38b938b3843994 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/119577044) * 76186776c5620598a19234245bbd05dfdfb1c62c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/120113740) * 628ca7b316ad3968c90192a47a84dd01f26e2578 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/122381349) * d204a725ff3c8a046cbd1b84e34d9e3ae8aafeac : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123620485) * 143efadbdb6c4681569d5b412a175edfb1633b85 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123637809) * b78b64a82ed2a9a92886095ec42f06d5082ad830 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123671219) * 5145a0b9d6b320456bb971d96b9cc47707c8fd28 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125476639) * 0d4d944c28c59ca1caa6c453c347ec786b40d245 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125762588) * 91552c3804f5e96cc573e6ed48756f2b54c037d4 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125844084) * fbf6d2850b6aa7c303981e6f5b24b0da0956b820 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/126086321) * 45282a2139ec3c7196ba10b6fb829b0ec275 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/126350641) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #8303: [FLINK-12343] [flink-yarn] add file replication config for yarn configuration
flinkbot edited a comment on issue #8303: [FLINK-12343] [flink-yarn] add file replication config for yarn configuration URL: https://github.com/apache/flink/pull/8303#issuecomment-511684151 ## CI report: * 6a7ca58b4a04f6dce250045e021702e67e82b893 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/119421914) * 4d38a8df0d59734c4b2386689a2f17b9f2b44b12 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/119441376) * 9c14836f8639e98d58cf7bb32e38b938b3843994 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/119577044) * 76186776c5620598a19234245bbd05dfdfb1c62c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/120113740) * 628ca7b316ad3968c90192a47a84dd01f26e2578 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/122381349) * d204a725ff3c8a046cbd1b84e34d9e3ae8aafeac : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123620485) * 143efadbdb6c4681569d5b412a175edfb1633b85 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123637809) * b78b64a82ed2a9a92886095ec42f06d5082ad830 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123671219) * 5145a0b9d6b320456bb971d96b9cc47707c8fd28 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125476639) * 0d4d944c28c59ca1caa6c453c347ec786b40d245 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125762588) * 91552c3804f5e96cc573e6ed48756f2b54c037d4 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125844084) * fbf6d2850b6aa7c303981e6f5b24b0da0956b820 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/126086321) * 45282a2139ec3c7196ba10b6fb829b0ec275 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/126350641) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #8303: [FLINK-12343] [flink-yarn] add file replication config for yarn configuration
flinkbot edited a comment on issue #8303: [FLINK-12343] [flink-yarn] add file replication config for yarn configuration URL: https://github.com/apache/flink/pull/8303#issuecomment-511684151 ## CI report: * 6a7ca58b4a04f6dce250045e021702e67e82b893 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/119421914) * 4d38a8df0d59734c4b2386689a2f17b9f2b44b12 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/119441376) * 9c14836f8639e98d58cf7bb32e38b938b3843994 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/119577044) * 76186776c5620598a19234245bbd05dfdfb1c62c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/120113740) * 628ca7b316ad3968c90192a47a84dd01f26e2578 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/122381349) * d204a725ff3c8a046cbd1b84e34d9e3ae8aafeac : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123620485) * 143efadbdb6c4681569d5b412a175edfb1633b85 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123637809) * b78b64a82ed2a9a92886095ec42f06d5082ad830 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123671219) * 5145a0b9d6b320456bb971d96b9cc47707c8fd28 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125476639) * 0d4d944c28c59ca1caa6c453c347ec786b40d245 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125762588) * 91552c3804f5e96cc573e6ed48756f2b54c037d4 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125844084) * fbf6d2850b6aa7c303981e6f5b24b0da0956b820 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/126086321) * 45282a2139ec3c7196ba10b6fb829b0ec275 : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-14003) Add access to customized state other than built in state types
[ https://issues.apache.org/jira/browse/FLINK-14003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925116#comment-16925116 ] Shimin Yang commented on FLINK-14003: - [~carp84], what do you think? > Add access to customized state other than built in state types > -- > > Key: FLINK-14003 > URL: https://issues.apache.org/jira/browse/FLINK-14003 > Project: Flink > Issue Type: Wish > Components: Runtime / State Backends >Reporter: Shimin Yang >Priority: Minor > > Currently the keyed state backend supports states like value, list, map, > although they are quite useful, but it may not fits all user cases. > User can develop their customized state backend based on different data store > as a plugin, but they do not have access to customized state if the type is > not one of those built-in types. > I propose to add getPartitionedState method to RuntimeContext and > KeyedStateStore interface to allow user to access their customized state, and > it will not affect current code path. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Created] (FLINK-14003) Add access to customized state other than built in state types
Shimin Yang created FLINK-14003: --- Summary: Add access to customized state other than built in state types Key: FLINK-14003 URL: https://issues.apache.org/jira/browse/FLINK-14003 Project: Flink Issue Type: Wish Components: Runtime / State Backends Reporter: Shimin Yang Currently the keyed state backend supports states like value, list, map, although they are quite useful, but it may not fits all user cases. User can develop their customized state backend based on different data store as a plugin, but they do not have access to customized state if the type is not one of those built-in types. I propose to add getPartitionedState method to RuntimeContext and KeyedStateStore interface to allow user to access their customized state, and it will not affect current code path. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [flink] flinkbot edited a comment on issue #8303: [FLINK-12343] [flink-yarn] add file replication config for yarn configuration
flinkbot edited a comment on issue #8303: [FLINK-12343] [flink-yarn] add file replication config for yarn configuration URL: https://github.com/apache/flink/pull/8303#issuecomment-487385120 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 45282a2139ec3c7196ba10b6fb829b0ec275 (Sun Sep 08 08:51:35 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ✅ 1. The [description] looks good. - Approved by @rmetzger [PMC] * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9645: [FLINK-12584][connectors]Add Bucket File Syetem Table Sink
flinkbot edited a comment on issue #9645: [FLINK-12584][connectors]Add Bucket File Syetem Table Sink URL: https://github.com/apache/flink/pull/9645#issuecomment-529174577 ## CI report: * d7c56060a8dd37190f70e2bef40cf37d013c7a59 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/126347282) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9645: [FLINK-12584][connectors]Add Bucket File Syetem Table Sink
flinkbot edited a comment on issue #9645: [FLINK-12584][connectors]Add Bucket File Syetem Table Sink URL: https://github.com/apache/flink/pull/9645#issuecomment-529174577 ## CI report: * d7c56060a8dd37190f70e2bef40cf37d013c7a59 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/126347282) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #9645: [FLINK-12584][connectors]Add Bucket File Syetem Table Sink
flinkbot commented on issue #9645: [FLINK-12584][connectors]Add Bucket File Syetem Table Sink URL: https://github.com/apache/flink/pull/9645#issuecomment-529174577 ## CI report: * d7c56060a8dd37190f70e2bef40cf37d013c7a59 : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-12847) Update Kinesis Connectors to latest Apache licensed libraries
[ https://issues.apache.org/jira/browse/FLINK-12847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925088#comment-16925088 ] Bowen Li commented on FLINK-12847: -- [~carp84] LGTM, thanks! > Update Kinesis Connectors to latest Apache licensed libraries > - > > Key: FLINK-12847 > URL: https://issues.apache.org/jira/browse/FLINK-12847 > Project: Flink > Issue Type: Improvement > Components: Connectors / Kinesis >Reporter: Dyana Rose >Assignee: Dyana Rose >Priority: Major > Labels: pull-request-available > Fix For: 1.10.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Currently the referenced Kinesis Client Library and Kinesis Producer Library > code in the flink-connector-kinesis is licensed under the Amazon Software > License which is not compatible with the Apache License. This then requires a > fair amount of work in the CI pipeline and for users who want to use the > flink-connector-kinesis. > The Kinesis Client Library v2.x and the AWS Java SDK v2.x both are now on the > Apache 2.0 license. > [https://github.com/awslabs/amazon-kinesis-client/blob/master/LICENSE.txt] > [https://github.com/aws/aws-sdk-java-v2/blob/master/LICENSE.txt] > There is a PR for the Kinesis Producer Library to update it to the Apache 2.0 > license ([https://github.com/awslabs/amazon-kinesis-producer/pull/256]) > The task should include, but not limited to, upgrading KCL/KPL to new > versions of Apache 2.0 license, changing licenses and NOTICE files in > flink-connector-kinesis, and adding flink-connector-kinesis to build, CI and > artifact publishing pipeline, updating the build profiles, updating > documentation that references the license incompatibility > The expected outcome of this issue is that the flink-connector-kinesis will > be included with the standard build artifacts and will no longer need to be > built separately by users. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (FLINK-7151) Add a function SQL DDL
[ https://issues.apache.org/jira/browse/FLINK-7151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925087#comment-16925087 ] Bowen Li commented on FLINK-7151: - [~ZhenqiuHuang] the shared google doc is view-only, can you share one that people can comment on? > Add a function SQL DDL > -- > > Key: FLINK-7151 > URL: https://issues.apache.org/jira/browse/FLINK-7151 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / API >Reporter: yuemeng >Assignee: Shuyi Chen >Priority: Critical > Fix For: 1.10.0 > > > Based on create function and table.we can register a udf,udaf,udtf use sql: > {code} > CREATE FUNCTION [IF NOT EXISTS] [catalog_name.db_name.]function_name AS > class_name [WITH (properties.)]; > DROP FUNCTION [IF EXISTS] [catalog_name.db_name.]function_name; > ALTER FUNCTION [IF EXISTS] [catalog_name.db_name.]function_name RENAME TO > new_name; > {code} > {code} > CREATE function 'TOPK' AS > 'com..aggregate.udaf.distinctUdaf.topk.ITopKUDAF'; > INSERT INTO db_sink SELECT id, TOPK(price, 5, 'DESC') FROM kafka_source GROUP > BY id; > {code} > This ticket can assume that the function class is already loaded in classpath > by users. Advanced syntax like to how to dynamically load udf libraries from > external locations can be on a separate ticket. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [flink] flinkbot commented on issue #9645: [FLINK-12584][connectors]Add Bucket File Syetem Table Sink
flinkbot commented on issue #9645: [FLINK-12584][connectors]Add Bucket File Syetem Table Sink URL: https://github.com/apache/flink/pull/9645#issuecomment-529174106 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit d7c56060a8dd37190f70e2bef40cf37d013c7a59 (Sun Sep 08 06:25:08 UTC 2019) **Warnings:** * **5 pom.xml files were touched**: Check for build and licensing issues. Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (FLINK-12584) Add Bucket File Syetem Table Sink
[ https://issues.apache.org/jira/browse/FLINK-12584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12584: --- Labels: pull-request-available (was: ) > Add Bucket File Syetem Table Sink > - > > Key: FLINK-12584 > URL: https://issues.apache.org/jira/browse/FLINK-12584 > Project: Flink > Issue Type: New Feature > Components: Table SQL / API >Affects Versions: 1.8.0, 1.9.0 >Reporter: zhangjun >Assignee: zhangjun >Priority: Major > Labels: pull-request-available > > 1. *Motivation* > In flink, the file system (especially hdfs) is a very common output, but for > users using sql, it does not support directly using sql to write data to the > file system, so I want to add a bucket file system table sink, the user can > register it to StreamTableEnvironment, so that table api and sql api can > directly use the sink to write stream data to filesystem > 2.*example* > tEnv.connect(new Bucket().basePath("hdfs://localhost/tmp/flink-data")) > .withFormat(new Json().deriveSchema()) > .withSchema(new Schema() > .field("name", Types. STRING ()) > .field("age", Types. INT ()) > .inAppendMode() > .registerTableSink("myhdfssink"); > tEnv.sqlUpdate("insert into myhdfssink SELECT * FROM mytablesource"); > > 3.*Some ideas to achieve this function* > 1) Add a class Bucket which extends from ConnectorDescriptor, add some > properties, such as basePath. > 2) Add a class BucketValidator which extends from the > ConnectorDescriptorValidator and is used to check the bucket descriptor. > 3) Add a class FileSystemTableSink to implement the StreamTableSink > interface. In the emitDataStream method, construct StreamingFileSink for > writing data to filesystem according to different properties. > 4) Add a factory class FileSystemTableSinkFactory to implement the > StreamTableSinkFactory interface for constructing FileSystemTableSink > 5) The parameters of withFormat method is the implementation classes of the > FormatDescriptor interface, such as Json, Csv, and we can add Parquet、Orc > later. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [flink] zhangjun888 opened a new pull request #9645: [FLINK-12584][connectors]Add Bucket File Syetem Table Sink
zhangjun888 opened a new pull request #9645: [FLINK-12584][connectors]Add Bucket File Syetem Table Sink URL: https://github.com/apache/flink/pull/9645 ## What is the purpose of the change This PR adds support for Bucket Filesystem Table Sink to be used with Table & SQL API 、SQL Client、Python Api 、DDL. ## Brief change log - *Bucket Filesystem Table Sink* - *BucketFileSytem Table Sink Factory* - *Parquet FormatDescriptor* - *Unit tests* - *SQL Client end-to-end test* - *Website documentation* - *Python Api* ## Verifying this change - *Unit tests for descriptors, factory, and sink* - *SQL Client end-to-end test extended with Bucket Filesystm Table Sink* - *Python Api Unit tests* ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes ) - The serializers: (yes) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (yes) ## Documentation - Does this pull request introduce a new feature? (yes) - If yes, how is the feature documented? (docs) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services