[GitHub] [flink] flinkbot edited a comment on issue #8912: [FLINK-12709] [runtime] Implement new generation restart strategy loader which also respects legacy…

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #8912: [FLINK-12709] [runtime] Implement new generation restart strategy loader which also respects legacy… URL: https://github.com/apache/flink/pull/8912#issuecomment-527387437 ## CI report: * 1bd21c6cd2d430b9827b903e80f31c55bcb04750 : FAILURE

[GitHub] [flink] flinkbot edited a comment on issue #8912: [FLINK-12709] [runtime] Implement new generation restart strategy loader which also respects legacy…

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #8912: [FLINK-12709] [runtime] Implement new generation restart strategy loader which also respects legacy… URL: https://github.com/apache/flink/pull/8912#issuecomment-527387437 ## CI report: * 1bd21c6cd2d430b9827b903e80f31c55bcb04750 : FAILURE

[GitHub] [flink] flinkbot edited a comment on issue #8912: [FLINK-12709] [runtime] Implement new generation restart strategy loader which also respects legacy…

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #8912: [FLINK-12709] [runtime] Implement new generation restart strategy loader which also respects legacy… URL: https://github.com/apache/flink/pull/8912#issuecomment-527387437 ## CI report: * 1bd21c6cd2d430b9827b903e80f31c55bcb04750 : FAILURE

[GitHub] [flink] zhuzhurk commented on a change in pull request #8912: [FLINK-12709] [runtime] Implement new generation restart strategy loader which also respects legacy…

2019-09-12 Thread GitBox
zhuzhurk commented on a change in pull request #8912: [FLINK-12709] [runtime] Implement new generation restart strategy loader which also respects legacy… URL: https://github.com/apache/flink/pull/8912#discussion_r324026898 ## File path:

[GitHub] [flink] zhuzhurk commented on a change in pull request #8912: [FLINK-12709] [runtime] Implement new generation restart strategy loader which also respects legacy…

2019-09-12 Thread GitBox
zhuzhurk commented on a change in pull request #8912: [FLINK-12709] [runtime] Implement new generation restart strategy loader which also respects legacy… URL: https://github.com/apache/flink/pull/8912#discussion_r324024299 ## File path:

[GitHub] [flink] GatsbyNewton commented on issue #9673: [FLINK-14031][examples][table]Added the blink planner dependency and …

2019-09-12 Thread GitBox
GatsbyNewton commented on issue #9673: [FLINK-14031][examples][table]Added the blink planner dependency and … URL: https://github.com/apache/flink/pull/9673#issuecomment-531073836 Hi, @rmetzger. Could you please kindly help to review the code changes? Thank you.

[GitHub] [flink] flinkbot edited a comment on issue #8468: [FLINK-12399][table][table-planner] Fix FilterableTableSource does not change after applyPredicate

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #8468: [FLINK-12399][table][table-planner] Fix FilterableTableSource does not change after applyPredicate URL: https://github.com/apache/flink/pull/8468#issuecomment-524372146 ## CI report: * baae1632aabac35e6e08b402065857c4d67491f2 : FAILURE

[GitHub] [flink] xuefuz commented on a change in pull request #8859: [FLINK-12905][table-planner] Enable querying CatalogViews in legacy planner

2019-09-12 Thread GitBox
xuefuz commented on a change in pull request #8859: [FLINK-12905][table-planner] Enable querying CatalogViews in legacy planner URL: https://github.com/apache/flink/pull/8859#discussion_r323991792 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8859: [FLINK-12905][table-planner] Enable querying CatalogViews in legacy planner

2019-09-12 Thread GitBox
xuefuz commented on a change in pull request #8859: [FLINK-12905][table-planner] Enable querying CatalogViews in legacy planner URL: https://github.com/apache/flink/pull/8859#discussion_r323991807 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8859: [FLINK-12905][table-planner] Enable querying CatalogViews in legacy planner

2019-09-12 Thread GitBox
xuefuz commented on a change in pull request #8859: [FLINK-12905][table-planner] Enable querying CatalogViews in legacy planner URL: https://github.com/apache/flink/pull/8859#discussion_r323991723 ## File path:

[GitHub] [flink] flinkbot edited a comment on issue #8468: [FLINK-12399][table][table-planner] Fix FilterableTableSource does not change after applyPredicate

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #8468: [FLINK-12399][table][table-planner] Fix FilterableTableSource does not change after applyPredicate URL: https://github.com/apache/flink/pull/8468#issuecomment-524372146 ## CI report: * baae1632aabac35e6e08b402065857c4d67491f2 : FAILURE

[GitHub] [flink] flinkbot edited a comment on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink URL: https://github.com/apache/flink/pull/9581#issuecomment-526712737 Thanks a lot for your contribution to the Apache

[GitHub] [flink] flinkbot edited a comment on issue #8468: [FLINK-12399][table][table-planner] Fix FilterableTableSource does not change after applyPredicate

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #8468: [FLINK-12399][table][table-planner] Fix FilterableTableSource does not change after applyPredicate URL: https://github.com/apache/flink/pull/8468#issuecomment-524372146 ## CI report: * baae1632aabac35e6e08b402065857c4d67491f2 : FAILURE

[GitHub] [flink] yxu-valleytider commented on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink

2019-09-12 Thread GitBox
yxu-valleytider commented on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink URL: https://github.com/apache/flink/pull/9581#issuecomment-531038789 sorry for the delay @kl0u . Was side tracked by

[GitHub] [flink] flinkbot edited a comment on issue #8468: [FLINK-12399][table][table-planner] Fix FilterableTableSource does not change after applyPredicate

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #8468: [FLINK-12399][table][table-planner] Fix FilterableTableSource does not change after applyPredicate URL: https://github.com/apache/flink/pull/8468#issuecomment-493155027 Thanks a lot for your contribution to the Apache Flink project. I'm the

[GitHub] [flink] walterddr commented on a change in pull request #8468: [FLINK-12399][table][table-planner] Fix FilterableTableSource does not change after applyPredicate

2019-09-12 Thread GitBox
walterddr commented on a change in pull request #8468: [FLINK-12399][table][table-planner] Fix FilterableTableSource does not change after applyPredicate URL: https://github.com/apache/flink/pull/8468#discussion_r323980865 ## File path:

[GitHub] [flink] flinkbot edited a comment on issue #8468: [FLINK-12399][table][table-planner] Fix FilterableTableSource does not change after applyPredicate

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #8468: [FLINK-12399][table][table-planner] Fix FilterableTableSource does not change after applyPredicate URL: https://github.com/apache/flink/pull/8468#issuecomment-493155027 Thanks a lot for your contribution to the Apache Flink project. I'm the

[GitHub] [flink] flinkbot edited a comment on issue #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub URL: https://github.com/apache/flink/pull/9663#issuecomment-529930381 ## CI report: * 5bfec29d38218b1bd5236163a7f2dd2571afa8b2 : CANCELED

[jira] [Commented] (FLINK-14057) Add Remove Other Timers to TimerService

2019-09-12 Thread Jesse Anderson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928708#comment-16928708 ] Jesse Anderson commented on FLINK-14057: Of the ideas put forth, I like Elias' the best. I would

[jira] [Commented] (FLINK-13862) Remove or rewrite Execution Plan docs

2019-09-12 Thread Stephan Ewen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928682#comment-16928682 ] Stephan Ewen commented on FLINK-13862: -- Is that plan visualizer something we want to keep

[jira] [Commented] (FLINK-14057) Add Remove Other Timers to TimerService

2019-09-12 Thread Elias Levy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928676#comment-16928676 ] Elias Levy commented on FLINK-14057: Could also add {{replaceProcessingTimeTimer}} and

[GitHub] [flink] flinkbot edited a comment on issue #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub URL: https://github.com/apache/flink/pull/9663#issuecomment-529930381 ## CI report: * 5bfec29d38218b1bd5236163a7f2dd2571afa8b2 : CANCELED

[jira] [Commented] (FLINK-14072) Add a third-party maven repository for flink-shaded .

2019-09-12 Thread Jeff Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928668#comment-16928668 ] Jeff Yang commented on FLINK-14072: --- The [PR|https://github.com/apache/flink-shaded/pull/71]. > Add a

[jira] [Commented] (FLINK-14072) Add a third-party maven repository for flink-shaded .

2019-09-12 Thread Jeff Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928666#comment-16928666 ] Jeff Yang commented on FLINK-14072: --- Hi,[~Zentol] [~sunjincheng121] Please take a look, Thank you very

[jira] [Updated] (FLINK-14072) Add a third-party maven repository for flink-shaded .

2019-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-14072: --- Labels: pull-request-available (was: ) > Add a third-party maven repository for

[GitHub] [flink] flinkbot edited a comment on issue #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub URL: https://github.com/apache/flink/pull/9663#issuecomment-529930381 ## CI report: * 5bfec29d38218b1bd5236163a7f2dd2571afa8b2 : CANCELED

[GitHub] [flink] flinkbot edited a comment on issue #9013: [FLINK-13136] Fix documentation error about stopping job with restful api

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #9013: [FLINK-13136] Fix documentation error about stopping job with restful api URL: https://github.com/apache/flink/pull/9013#issuecomment-514125271 ## CI report: * 2d2908752122665dc6bc45ceb4aa28099755f8d5 : FAILURE

[jira] [Created] (FLINK-14072) Add a third-party maven repository for flink-shaded .

2019-09-12 Thread Jeff Yang (Jira)
Jeff Yang created FLINK-14072: - Summary: Add a third-party maven repository for flink-shaded . Key: FLINK-14072 URL: https://issues.apache.org/jira/browse/FLINK-14072 Project: Flink Issue Type:

[GitHub] [flink] flinkbot edited a comment on issue #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub URL: https://github.com/apache/flink/pull/9663#issuecomment-529928149 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review

[GitHub] [flink] flinkbot edited a comment on issue #9668: [hotfix][docs] Fix the wrong characters in the document(building.md, building.zh.md)

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #9668: [hotfix][docs] Fix the wrong characters in the document(building.md,building.zh.md) URL: https://github.com/apache/flink/pull/9668#issuecomment-530213212 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the

[GitHub] [flink] yangjf2019 commented on issue #9668: [hotfix][docs] Fix the wrong characters in the document(building.md, building.zh.md)

2019-09-12 Thread GitBox
yangjf2019 commented on issue #9668: [hotfix][docs] Fix the wrong characters in the document(building.md,building.zh.md) URL: https://github.com/apache/flink/pull/9668#issuecomment-530866521 Hi, @wuchong Delay your time, please take a look, thank you very much!

[jira] [Commented] (FLINK-13025) Elasticsearch 7.x support

2019-09-12 Thread Leonid Ilyevsky (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928593#comment-16928593 ] Leonid Ilyevsky commented on FLINK-13025: - [~StephanEwen] sure, will do. > Elasticsearch 7.x

[GitHub] [flink] flinkbot edited a comment on issue #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub URL: https://github.com/apache/flink/pull/9663#issuecomment-529930381 ## CI report: * 5bfec29d38218b1bd5236163a7f2dd2571afa8b2 : CANCELED

[GitHub] [flink] flinkbot edited a comment on issue #9013: [FLINK-13136] Fix documentation error about stopping job with restful api

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #9013: [FLINK-13136] Fix documentation error about stopping job with restful api URL: https://github.com/apache/flink/pull/9013#issuecomment-514125271 ## CI report: * 2d2908752122665dc6bc45ceb4aa28099755f8d5 : FAILURE

[GitHub] [flink] flinkbot edited a comment on issue #9013: [FLINK-13136] Fix documentation error about stopping job with restful api

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #9013: [FLINK-13136] Fix documentation error about stopping job with restful api URL: https://github.com/apache/flink/pull/9013#issuecomment-514125271 ## CI report: * 2d2908752122665dc6bc45ceb4aa28099755f8d5 : FAILURE

[jira] [Commented] (FLINK-13862) Remove or rewrite Execution Plan docs

2019-09-12 Thread Gary Yao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928568#comment-16928568 ] Gary Yao commented on FLINK-13862: -- {{planVisualizer.html}} was just a redirect to

[jira] [Updated] (FLINK-14066) pyflink building failure in master and 1.9.0 version

2019-09-12 Thread Gary Yao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao updated FLINK-14066: - Component/s: API / Python > pyflink building failure in master and 1.9.0 version >

[GitHub] [flink] flinkbot edited a comment on issue #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub URL: https://github.com/apache/flink/pull/9663#issuecomment-529930381 ## CI report: * 5bfec29d38218b1bd5236163a7f2dd2571afa8b2 : CANCELED

[GitHub] [flink] flinkbot edited a comment on issue #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub URL: https://github.com/apache/flink/pull/9663#issuecomment-529928149 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review

[GitHub] [flink] GJL commented on a change in pull request #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub

2019-09-12 Thread GitBox
GJL commented on a change in pull request #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub URL: https://github.com/apache/flink/pull/9663#discussion_r323756671 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultScheduler.java

[GitHub] [flink] flinkbot edited a comment on issue #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub URL: https://github.com/apache/flink/pull/9663#issuecomment-529928149 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review

[GitHub] [flink] zhuzhurk commented on a change in pull request #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub

2019-09-12 Thread GitBox
zhuzhurk commented on a change in pull request #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub URL: https://github.com/apache/flink/pull/9663#discussion_r323755152 ## File path:

[GitHub] [flink] flinkbot edited a comment on issue #9184: [FLINK-13339][ml] Add an implementation of pipeline's api

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #9184: [FLINK-13339][ml] Add an implementation of pipeline's api URL: https://github.com/apache/flink/pull/9184#issuecomment-513425405 ## CI report: * bd7ade5e0b57dc8577d7f864afcbbb24c2513e56 : FAILURE

[GitHub] [flink] flinkbot edited a comment on issue #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub URL: https://github.com/apache/flink/pull/9663#issuecomment-529930381 ## CI report: * 5bfec29d38218b1bd5236163a7f2dd2571afa8b2 : CANCELED

[GitHub] [flink] flinkbot edited a comment on issue #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub URL: https://github.com/apache/flink/pull/9663#issuecomment-529928149 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review

[GitHub] [flink] flinkbot edited a comment on issue #9184: [FLINK-13339][ml] Add an implementation of pipeline's api

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #9184: [FLINK-13339][ml] Add an implementation of pipeline's api URL: https://github.com/apache/flink/pull/9184#issuecomment-513425405 ## CI report: * bd7ade5e0b57dc8577d7f864afcbbb24c2513e56 : FAILURE

[GitHub] [flink] flinkbot edited a comment on issue #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub URL: https://github.com/apache/flink/pull/9663#issuecomment-529930381 ## CI report: * 5bfec29d38218b1bd5236163a7f2dd2571afa8b2 : CANCELED

[jira] [Commented] (FLINK-14066) pyflink building failure in master and 1.9.0 version

2019-09-12 Thread Xu Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928522#comment-16928522 ] Xu Yang commented on FLINK-14066: - Right now, I only focus on the building stage of pyflink. The

[GitHub] [flink] flinkbot edited a comment on issue #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub URL: https://github.com/apache/flink/pull/9663#issuecomment-529928149 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review

[GitHub] [flink] GJL commented on a change in pull request #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub

2019-09-12 Thread GitBox
GJL commented on a change in pull request #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub URL: https://github.com/apache/flink/pull/9663#discussion_r323737657 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub

2019-09-12 Thread GitBox
GJL commented on a change in pull request #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub URL: https://github.com/apache/flink/pull/9663#discussion_r323737277 ## File path:

[GitHub] [flink] flinkbot edited a comment on issue #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub URL: https://github.com/apache/flink/pull/9663#issuecomment-529928149 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review

[GitHub] [flink] GJL commented on a change in pull request #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub

2019-09-12 Thread GitBox
GJL commented on a change in pull request #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub URL: https://github.com/apache/flink/pull/9663#discussion_r323735412 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java

[GitHub] [flink] flinkbot edited a comment on issue #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub URL: https://github.com/apache/flink/pull/9663#issuecomment-529928149 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review

[GitHub] [flink] GJL commented on a change in pull request #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub

2019-09-12 Thread GitBox
GJL commented on a change in pull request #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub URL: https://github.com/apache/flink/pull/9663#discussion_r323735412 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java

[jira] [Commented] (FLINK-14034) In FlinkKafkaProducer, KafkaTransactionState should be made public or invoke should be made final

2019-09-12 Thread Stephan Ewen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928515#comment-16928515 ] Stephan Ewen commented on FLINK-14034: -- I would suggest to go with the variant that does not extend

[GitHub] [flink] GJL commented on a change in pull request #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub

2019-09-12 Thread GitBox
GJL commented on a change in pull request #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub URL: https://github.com/apache/flink/pull/9663#discussion_r323591961 ## File path:

[jira] [Commented] (FLINK-14002) FlinkKafkaProducer constructor that takes KafkaSerializationSchema shouldnt take default topic

2019-09-12 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928513#comment-16928513 ] Gyula Fora commented on FLINK-14002: I am bit busy in the next few days but I can definitely fix

[GitHub] [flink] GJL commented on a change in pull request #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub

2019-09-12 Thread GitBox
GJL commented on a change in pull request #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub URL: https://github.com/apache/flink/pull/9663#discussion_r323591961 ## File path:

[GitHub] [flink] flinkbot edited a comment on issue #9670: [FLINK-14049] [coordination] Add task name to error message for failed partition updates

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #9670: [FLINK-14049] [coordination] Add task name to error message for failed partition updates URL: https://github.com/apache/flink/pull/9670#issuecomment-530272387 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I

[GitHub] [flink] flinkbot edited a comment on issue #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub URL: https://github.com/apache/flink/pull/9663#issuecomment-529928149 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review

[GitHub] [flink] asfgit closed pull request #9670: [FLINK-14049] [coordination] Add task name to error message for failed partition updates

2019-09-12 Thread GitBox
asfgit closed pull request #9670: [FLINK-14049] [coordination] Add task name to error message for failed partition updates URL: https://github.com/apache/flink/pull/9670 This is an automated message from the Apache Git

[GitHub] [flink] GJL commented on a change in pull request #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub

2019-09-12 Thread GitBox
GJL commented on a change in pull request #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub URL: https://github.com/apache/flink/pull/9663#discussion_r323732826 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/LegacyScheduler.java

[GitHub] [flink] GJL commented on a change in pull request #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub

2019-09-12 Thread GitBox
GJL commented on a change in pull request #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub URL: https://github.com/apache/flink/pull/9663#discussion_r323732826 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/LegacyScheduler.java

[GitHub] [flink] flinkbot edited a comment on issue #9670: [FLINK-14049] [coordination] Add task name to error message for failed partition updates

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #9670: [FLINK-14049] [coordination] Add task name to error message for failed partition updates URL: https://github.com/apache/flink/pull/9670#issuecomment-530272387 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I

[GitHub] [flink] flinkbot edited a comment on issue #9184: [FLINK-13339][ml] Add an implementation of pipeline's api

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #9184: [FLINK-13339][ml] Add an implementation of pipeline's api URL: https://github.com/apache/flink/pull/9184#issuecomment-513425405 ## CI report: * bd7ade5e0b57dc8577d7f864afcbbb24c2513e56 : FAILURE

[GitHub] [flink] flinkbot edited a comment on issue #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub URL: https://github.com/apache/flink/pull/9663#issuecomment-529928149 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review

[GitHub] [flink] GJL commented on a change in pull request #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub

2019-09-12 Thread GitBox
GJL commented on a change in pull request #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub URL: https://github.com/apache/flink/pull/9663#discussion_r323732451 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultScheduler.java

[GitHub] [flink] StephanEwen commented on issue #9670: [FLINK-14049] [coordination] Add task name to error message for failed partition updates

2019-09-12 Thread GitBox
StephanEwen commented on issue #9670: [FLINK-14049] [coordination] Add task name to error message for failed partition updates URL: https://github.com/apache/flink/pull/9670#issuecomment-530819672 Thanks, merging this...

[GitHub] [flink] GJL commented on a change in pull request #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub

2019-09-12 Thread GitBox
GJL commented on a change in pull request #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub URL: https://github.com/apache/flink/pull/9663#discussion_r323731494 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub

2019-09-12 Thread GitBox
GJL commented on a change in pull request #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub URL: https://github.com/apache/flink/pull/9663#discussion_r323731494 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub

2019-09-12 Thread GitBox
GJL commented on a change in pull request #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub URL: https://github.com/apache/flink/pull/9663#discussion_r323731494 ## File path:

[GitHub] [flink] flinkbot edited a comment on issue #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub URL: https://github.com/apache/flink/pull/9663#issuecomment-529928149 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review

[GitHub] [flink] GJL commented on a change in pull request #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub

2019-09-12 Thread GitBox
GJL commented on a change in pull request #9663: [WIP][FLINK-12433][runtime] Implement DefaultScheduler stub URL: https://github.com/apache/flink/pull/9663#discussion_r323731161 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionVertex.java

[jira] [Commented] (FLINK-13025) Elasticsearch 7.x support

2019-09-12 Thread Stephan Ewen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928511#comment-16928511 ] Stephan Ewen commented on FLINK-13025: -- [~lilyevsky] would you be up to working closely together

[GitHub] [flink] flinkbot edited a comment on issue #9646: [FLINK-14004][task] Define SourceReader interface to verify the integration with StreamOneInputProcessor

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #9646: [FLINK-14004][task] Define SourceReader interface to verify the integration with StreamOneInputProcessor URL: https://github.com/apache/flink/pull/9646#issuecomment-529228507 Thanks a lot for your contribution to the Apache Flink project. I'm the

[GitHub] [flink] StephanEwen commented on issue #9646: [FLINK-14004][task] Define SourceReader interface to verify the integration with StreamOneInputProcessor

2019-09-12 Thread GitBox
StephanEwen commented on issue #9646: [FLINK-14004][task] Define SourceReader interface to verify the integration with StreamOneInputProcessor URL: https://github.com/apache/flink/pull/9646#issuecomment-530817767 I am also not sure why the runtime need to know about this interface. As far

[GitHub] [flink] flinkbot edited a comment on issue #9646: [FLINK-14004][task] Define SourceReader interface to verify the integration with StreamOneInputProcessor

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #9646: [FLINK-14004][task] Define SourceReader interface to verify the integration with StreamOneInputProcessor URL: https://github.com/apache/flink/pull/9646#issuecomment-529228507 Thanks a lot for your contribution to the Apache Flink project. I'm the

[jira] [Commented] (FLINK-14066) pyflink building failure in master and 1.9.0 version

2019-09-12 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928507#comment-16928507 ] Dian Fu commented on FLINK-14066: - I mean that for windows support, we need to consider both building

[jira] [Created] (FLINK-14071) [for Documents Improvement] Add explicit path where jars files should be put for pyflink development

2019-09-12 Thread Xu Yang (Jira)
Xu Yang created FLINK-14071: --- Summary: [for Documents Improvement] Add explicit path where jars files should be put for pyflink development Key: FLINK-14071 URL: https://issues.apache.org/jira/browse/FLINK-14071

[GitHub] [flink] StephanEwen commented on issue #9646: [FLINK-14004][task] Define SourceReader interface to verify the integration with StreamOneInputProcessor

2019-09-12 Thread GitBox
StephanEwen commented on issue #9646: [FLINK-14004][task] Define SourceReader interface to verify the integration with StreamOneInputProcessor URL: https://github.com/apache/flink/pull/9646#issuecomment-530816761 I think in that case there should be a placeholder interface in

[GitHub] [flink] flinkbot edited a comment on issue #9184: [FLINK-13339][ml] Add an implementation of pipeline's api

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #9184: [FLINK-13339][ml] Add an implementation of pipeline's api URL: https://github.com/apache/flink/pull/9184#issuecomment-513424964 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review

[GitHub] [flink] xuyang1706 commented on a change in pull request #9184: [FLINK-13339][ml] Add an implementation of pipeline's api

2019-09-12 Thread GitBox
xuyang1706 commented on a change in pull request #9184: [FLINK-13339][ml] Add an implementation of pipeline's api URL: https://github.com/apache/flink/pull/9184#discussion_r323724380 ## File path:

[GitHub] [flink] xuyang1706 commented on a change in pull request #9184: [FLINK-13339][ml] Add an implementation of pipeline's api

2019-09-12 Thread GitBox
xuyang1706 commented on a change in pull request #9184: [FLINK-13339][ml] Add an implementation of pipeline's api URL: https://github.com/apache/flink/pull/9184#discussion_r323724073 ## File path:

[GitHub] [flink] flinkbot edited a comment on issue #9184: [FLINK-13339][ml] Add an implementation of pipeline's api

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #9184: [FLINK-13339][ml] Add an implementation of pipeline's api URL: https://github.com/apache/flink/pull/9184#issuecomment-513424964 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review

[GitHub] [flink] xuyang1706 commented on a change in pull request #9184: [FLINK-13339][ml] Add an implementation of pipeline's api

2019-09-12 Thread GitBox
xuyang1706 commented on a change in pull request #9184: [FLINK-13339][ml] Add an implementation of pipeline's api URL: https://github.com/apache/flink/pull/9184#discussion_r323722921 ## File path:

[jira] [Commented] (FLINK-13417) Bump Zookeeper to 3.5.5

2019-09-12 Thread Stephan Ewen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928499#comment-16928499 ] Stephan Ewen commented on FLINK-13417: -- @Tison would it be safer to shade Flink's ZK and then let

[GitHub] [flink] flinkbot edited a comment on issue #9184: [FLINK-13339][ml] Add an implementation of pipeline's api

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #9184: [FLINK-13339][ml] Add an implementation of pipeline's api URL: https://github.com/apache/flink/pull/9184#issuecomment-513424964 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review

[GitHub] [flink] xuyang1706 edited a comment on issue #9184: [FLINK-13339][ml] Add an implementation of pipeline's api

2019-09-12 Thread GitBox
xuyang1706 edited a comment on issue #9184: [FLINK-13339][ml] Add an implementation of pipeline's api URL: https://github.com/apache/flink/pull/9184#issuecomment-530808471 > Hi @xuyang1706, > thanks for your work, I've just left a few comments, please look it then you will have time.

[GitHub] [flink] xuyang1706 commented on issue #9184: [FLINK-13339][ml] Add an implementation of pipeline's api

2019-09-12 Thread GitBox
xuyang1706 commented on issue #9184: [FLINK-13339][ml] Add an implementation of pipeline's api URL: https://github.com/apache/flink/pull/9184#issuecomment-530808471 > Hi @xuyang1706, > thanks for your work, I've just left a few comments, please look it then you will have time.

[GitHub] [flink] xuyang1706 commented on a change in pull request #9184: [FLINK-13339][ml] Add an implementation of pipeline's api

2019-09-12 Thread GitBox
xuyang1706 commented on a change in pull request #9184: [FLINK-13339][ml] Add an implementation of pipeline's api URL: https://github.com/apache/flink/pull/9184#discussion_r323717999 ## File path:

[GitHub] [flink] flinkbot edited a comment on issue #9184: [FLINK-13339][ml] Add an implementation of pipeline's api

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #9184: [FLINK-13339][ml] Add an implementation of pipeline's api URL: https://github.com/apache/flink/pull/9184#issuecomment-513424964 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review

[GitHub] [flink] xuyang1706 commented on a change in pull request #9184: [FLINK-13339][ml] Add an implementation of pipeline's api

2019-09-12 Thread GitBox
xuyang1706 commented on a change in pull request #9184: [FLINK-13339][ml] Add an implementation of pipeline's api URL: https://github.com/apache/flink/pull/9184#discussion_r323718017 ## File path:

[jira] [Updated] (FLINK-14066) pyflink building failure in master and 1.9.0 version

2019-09-12 Thread Xu Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xu Yang updated FLINK-14066: Summary: pyflink building failure in master and 1.9.0 version (was: bug of building pyflink in master

[jira] [Commented] (FLINK-14066) bug of building pyflink in master and 1.9.0 version

2019-09-12 Thread Xu Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928492#comment-16928492 ] Xu Yang commented on FLINK-14066: - Dear Dian Fu, tks for watching my issue. I know pyflink is not

[jira] [Updated] (FLINK-14066) bug of building pyflink in master and 1.9.0 version

2019-09-12 Thread Xu Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xu Yang updated FLINK-14066: Description: ATTENTION: This is a issue about building pyflink, not development. During we build

[jira] [Updated] (FLINK-14066) bug of building pyflink in master and 1.9.0 version

2019-09-12 Thread Xu Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xu Yang updated FLINK-14066: Environment: windows 10 enterprise x64(mentioned as build environment, not development environment.)

[GitHub] [flink] flinkbot edited a comment on issue #9013: [FLINK-13136] Fix documentation error about stopping job with restful api

2019-09-12 Thread GitBox
flinkbot edited a comment on issue #9013: [FLINK-13136] Fix documentation error about stopping job with restful api URL: https://github.com/apache/flink/pull/9013#issuecomment-509065631 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community

[GitHub] [flink] GJL commented on a change in pull request #9013: [FLINK-13136] Fix documentation error about stopping job with restful api

2019-09-12 Thread GitBox
GJL commented on a change in pull request #9013: [FLINK-13136] Fix documentation error about stopping job with restful api URL: https://github.com/apache/flink/pull/9013#discussion_r323702619 ## File path:

[jira] [Comment Edited] (FLINK-14070) Use TimeUtils to parse duration configs

2019-09-12 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928476#comment-16928476 ] Till Rohrmann edited comment on FLINK-14070 at 9/12/19 11:55 AM: - Nice

  1   2   3   >