[GitHub] [flink] flinkbot edited a comment on issue #10284: [FLINK-14735][scheduler] Improve scheduling of all-to-all partitions with ALL input constraint for legacy scheduler

2019-11-21 Thread GitBox
flinkbot edited a comment on issue #10284: [FLINK-14735][scheduler] Improve scheduling of all-to-all partitions with ALL input constraint for legacy scheduler URL: https://github.com/apache/flink/pull/10284#issuecomment-557162273 ## CI report: *

[GitHub] [flink] flinkbot edited a comment on issue #10289: [FLINK-14924][table sql / api] CsvTableSource can not config empty column as null

2019-11-21 Thread GitBox
flinkbot edited a comment on issue #10289: [FLINK-14924][table sql / api] CsvTableSource can not config empty column as null URL: https://github.com/apache/flink/pull/10289#issuecomment-557424125 ## CI report: * e668b7fee390243db8312cc7a4ce3b71fb6f15a3 : PENDING

[jira] [Commented] (FLINK-14924) CsvTableSource can not config empty column as null

2019-11-21 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979943#comment-16979943 ] Jingsong Lee commented on FLINK-14924: -- FYI: `CsvRowDeserializationSchema.Builder.setNullLiteral`.

[GitHub] [flink] docete commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner

2019-11-21 Thread GitBox
docete commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner URL: https://github.com/apache/flink/pull/10268#discussion_r349468600 ## File path:

[GitHub] [flink] flinkbot edited a comment on issue #10283: [FLINK-14735][scheduler] Improve scheduling of all-to-all partitions with ALL input constraint for legacy scheduler

2019-11-21 Thread GitBox
flinkbot edited a comment on issue #10283: [FLINK-14735][scheduler] Improve scheduling of all-to-all partitions with ALL input constraint for legacy scheduler URL: https://github.com/apache/flink/pull/10283#issuecomment-55716 ## CI report: *

[jira] [Commented] (FLINK-14924) CsvTableSource can not config empty column as null

2019-11-21 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979940#comment-16979940 ] Jingsong Lee commented on FLINK-14924: -- Just curious: I'm not sure if we should add `this empty

[GitHub] [flink] liupc edited a comment on issue #10269: [FLINK-14876]Putting xercesImpl related classes into alwaysParentFirstLoaderPatterns to avoid conflicts

2019-11-21 Thread GitBox
liupc edited a comment on issue #10269: [FLINK-14876]Putting xercesImpl related classes into alwaysParentFirstLoaderPatterns to avoid conflicts URL: https://github.com/apache/flink/pull/10269#issuecomment-557429329 hi @aljoscha , The hadoop version of our cluster is 2.6, so I changed

[GitHub] [flink] yanghua commented on issue #10288: [FLINK-14765] Remove STATE_UPDATER in Execution

2019-11-21 Thread GitBox
yanghua commented on issue #10288: [FLINK-14765] Remove STATE_UPDATER in Execution URL: https://github.com/apache/flink/pull/10288#issuecomment-557429438 cc @GJL This is an automated message from the Apache Git Service. To

[GitHub] [flink] docete commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner

2019-11-21 Thread GitBox
docete commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner URL: https://github.com/apache/flink/pull/10268#discussion_r349466855 ## File path:

[GitHub] [flink] liupc commented on issue #10269: [FLINK-14876]Putting xercesImpl related classes into alwaysParentFirstLoaderPatterns to avoid conflicts

2019-11-21 Thread GitBox
liupc commented on issue #10269: [FLINK-14876]Putting xercesImpl related classes into alwaysParentFirstLoaderPatterns to avoid conflicts URL: https://github.com/apache/flink/pull/10269#issuecomment-557429329 hi @aljoscha , The hadoop version of our cluster is 2.6, so I changed the

[jira] [Assigned] (FLINK-14924) CsvTableSource can not config empty column as null

2019-11-21 Thread Kurt Young (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young reassigned FLINK-14924: -- Assignee: Leonard Xu > CsvTableSource can not config empty column as null >

[jira] [Commented] (FLINK-14924) CsvTableSource can not config empty column as null

2019-11-21 Thread Kurt Young (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979937#comment-16979937 ] Kurt Young commented on FLINK-14924: Assigned to you [~Leonard Xu] > CsvTableSource can not config

[GitHub] [flink] KurtYoung commented on a change in pull request #10289: [FLINK-14924][table sql / api] CsvTableSource can not config empty column as null

2019-11-21 Thread GitBox
KurtYoung commented on a change in pull request #10289: [FLINK-14924][table sql / api] CsvTableSource can not config empty column as null URL: https://github.com/apache/flink/pull/10289#discussion_r349465056 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #10289: [FLINK-14924][table sql / api] CsvTableSource can not config empty column as null

2019-11-21 Thread GitBox
KurtYoung commented on a change in pull request #10289: [FLINK-14924][table sql / api] CsvTableSource can not config empty column as null URL: https://github.com/apache/flink/pull/10289#discussion_r349464983 ## File path:

[GitHub] [flink] zjuwangg commented on a change in pull request #10272: [FLINK-14878]Support `use catalog` through sqlUpdate() method in TableEnvironment

2019-11-21 Thread GitBox
zjuwangg commented on a change in pull request #10272: [FLINK-14878]Support `use catalog` through sqlUpdate() method in TableEnvironment URL: https://github.com/apache/flink/pull/10272#discussion_r348873978 ## File path:

[GitHub] [flink] flinkbot edited a comment on issue #10170: [FLINK-14722][hadoop] Optimize mapred.HadoopInputSplit to not serialize conf when split is not configurable

2019-11-21 Thread GitBox
flinkbot edited a comment on issue #10170: [FLINK-14722][hadoop] Optimize mapred.HadoopInputSplit to not serialize conf when split is not configurable URL: https://github.com/apache/flink/pull/10170#issuecomment-553318094 ## CI report: * 7ded222adb69e94dc572de2e3aa58d63e619f557

[jira] [Commented] (FLINK-14924) CsvTableSource can not config empty column as null

2019-11-21 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979930#comment-16979930 ] Leonard Xu commented on FLINK-14924: [~ykt836] Thanks for your tips, could you help assign this to

[GitHub] [flink] flinkbot edited a comment on issue #10287: [FLINK-14915][runtime] Remove the unnecessary param JobGraph from SchedulingStrategyFactory#createInstance

2019-11-21 Thread GitBox
flinkbot edited a comment on issue #10287: [FLINK-14915][runtime] Remove the unnecessary param JobGraph from SchedulingStrategyFactory#createInstance URL: https://github.com/apache/flink/pull/10287#issuecomment-557403940 ## CI report: * 91a9712e38f270006e6577e2976deb9993bb8243 :

[GitHub] [flink] docete commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner

2019-11-21 Thread GitBox
docete commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner URL: https://github.com/apache/flink/pull/10268#discussion_r349462103 ## File path:

[GitHub] [flink] flinkbot commented on issue #10289: [FLINK-14924][table sql / api] CsvTableSource can not config empty column as null

2019-11-21 Thread GitBox
flinkbot commented on issue #10289: [FLINK-14924][table sql / api] CsvTableSource can not config empty column as null URL: https://github.com/apache/flink/pull/10289#issuecomment-557424125 ## CI report: * e668b7fee390243db8312cc7a4ce3b71fb6f15a3 : UNKNOWN Bot commands

[GitHub] [flink] flinkbot edited a comment on issue #10288: [FLINK-14765] Remove STATE_UPDATER in Execution

2019-11-21 Thread GitBox
flinkbot edited a comment on issue #10288: [FLINK-14765] Remove STATE_UPDATER in Execution URL: https://github.com/apache/flink/pull/10288#issuecomment-557403970 ## CI report: * 018cc229676d6c6634ce4113342f46b42eb24416 : SUCCESS

[GitHub] [flink] flinkbot edited a comment on issue #10283: [FLINK-14735][scheduler] Improve scheduling of all-to-all partitions with ALL input constraint for legacy scheduler

2019-11-21 Thread GitBox
flinkbot edited a comment on issue #10283: [FLINK-14735][scheduler] Improve scheduling of all-to-all partitions with ALL input constraint for legacy scheduler URL: https://github.com/apache/flink/pull/10283#issuecomment-55716 ## CI report: *

[GitHub] [flink] zhuzhurk commented on issue #10283: [FLINK-14735][scheduler] Improve scheduling of all-to-all partitions with ALL input constraint for legacy scheduler

2019-11-21 Thread GitBox
zhuzhurk commented on issue #10283: [FLINK-14735][scheduler] Improve scheduling of all-to-all partitions with ALL input constraint for legacy scheduler URL: https://github.com/apache/flink/pull/10283#issuecomment-557423556 @flinkbot run travis

[GitHub] [flink] JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner

2019-11-21 Thread GitBox
JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner URL: https://github.com/apache/flink/pull/10268#discussion_r349461114 ## File path:

[GitHub] [flink] docete commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner

2019-11-21 Thread GitBox
docete commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner URL: https://github.com/apache/flink/pull/10268#discussion_r349460825 ## File path:

[GitHub] [flink] docete commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner

2019-11-21 Thread GitBox
docete commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner URL: https://github.com/apache/flink/pull/10268#discussion_r349460526 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner

2019-11-21 Thread GitBox
JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner URL: https://github.com/apache/flink/pull/10268#discussion_r349460592 ## File path:

[GitHub] [flink] flinkbot commented on issue #10289: [FLINK-14924][table sql / api] CsvTableSource can not config empty column as null

2019-11-21 Thread GitBox
flinkbot commented on issue #10289: [FLINK-14924][table sql / api] CsvTableSource can not config empty column as null URL: https://github.com/apache/flink/pull/10289#issuecomment-557422149 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the

[jira] [Updated] (FLINK-14924) CsvTableSource can not config empty column as null

2019-11-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-14924: --- Labels: pull-request-available (was: ) > CsvTableSource can not config empty column as

[GitHub] [flink] leonardBang opened a new pull request #10289: [FLINK-14924][table sql / api] CsvTableSource can not config empty column as null

2019-11-21 Thread GitBox
leonardBang opened a new pull request #10289: [FLINK-14924][table sql / api] CsvTableSource can not config empty column as null URL: https://github.com/apache/flink/pull/10289 CsvTableSource can not config empty column as null. ## What is the purpose of the change *This

[GitHub] [flink] JingsongLi commented on a change in pull request #10170: [FLINK-14722][hadoop] Optimize mapred.HadoopInputSplit to not serialize conf when split is not configurable

2019-11-21 Thread GitBox
JingsongLi commented on a change in pull request #10170: [FLINK-14722][hadoop] Optimize mapred.HadoopInputSplit to not serialize conf when split is not configurable URL: https://github.com/apache/flink/pull/10170#discussion_r349459373 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #10170: [FLINK-14722][hadoop] Optimize mapred.HadoopInputSplit to not serialize conf when split is not configurable

2019-11-21 Thread GitBox
JingsongLi commented on a change in pull request #10170: [FLINK-14722][hadoop] Optimize mapred.HadoopInputSplit to not serialize conf when split is not configurable URL: https://github.com/apache/flink/pull/10170#discussion_r349458534 ## File path:

[GitHub] [flink] docete commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner

2019-11-21 Thread GitBox
docete commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner URL: https://github.com/apache/flink/pull/10268#discussion_r349458280 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner

2019-11-21 Thread GitBox
wuchong commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner URL: https://github.com/apache/flink/pull/10268#discussion_r349458143 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner

2019-11-21 Thread GitBox
wuchong commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner URL: https://github.com/apache/flink/pull/10268#discussion_r349457521 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #10170: [FLINK-14722][hadoop] Optimize mapred.HadoopInputSplit to not serialize conf when split is not configurable

2019-11-21 Thread GitBox
JingsongLi commented on a change in pull request #10170: [FLINK-14722][hadoop] Optimize mapred.HadoopInputSplit to not serialize conf when split is not configurable URL: https://github.com/apache/flink/pull/10170#discussion_r349457137 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner

2019-11-21 Thread GitBox
wuchong commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner URL: https://github.com/apache/flink/pull/10268#discussion_r349456919 ## File path:

[GitHub] [flink] zhuzhurk commented on issue #10283: [FLINK-14735][scheduler] Improve scheduling of all-to-all partitions with ALL input constraint for legacy scheduler

2019-11-21 Thread GitBox
zhuzhurk commented on issue #10283: [FLINK-14735][scheduler] Improve scheduling of all-to-all partitions with ALL input constraint for legacy scheduler URL: https://github.com/apache/flink/pull/10283#issuecomment-557418923 @flinkbot run travis

[GitHub] [flink] docete commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner

2019-11-21 Thread GitBox
docete commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner URL: https://github.com/apache/flink/pull/10268#discussion_r349456703 ## File path:

[jira] [Commented] (FLINK-14872) Potential deadlock for task reading from blocking ResultPartition.

2019-11-21 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979921#comment-16979921 ] Jingsong Lee commented on FLINK-14872: -- Thanks [~kevin.cyj] and [~pnowojski], I provide some test 

[GitHub] [flink] KurtYoung commented on a change in pull request #10170: [FLINK-14722][hadoop] Optimize mapred.HadoopInputSplit to not serialize conf when split is not configurable

2019-11-21 Thread GitBox
KurtYoung commented on a change in pull request #10170: [FLINK-14722][hadoop] Optimize mapred.HadoopInputSplit to not serialize conf when split is not configurable URL: https://github.com/apache/flink/pull/10170#discussion_r349454919 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #10170: [FLINK-14722][hadoop] Optimize mapred.HadoopInputSplit to not serialize conf when split is not configurable

2019-11-21 Thread GitBox
KurtYoung commented on a change in pull request #10170: [FLINK-14722][hadoop] Optimize mapred.HadoopInputSplit to not serialize conf when split is not configurable URL: https://github.com/apache/flink/pull/10170#discussion_r349454800 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #10170: [FLINK-14722][hadoop] Optimize mapred.HadoopInputSplit to not serialize conf when split is not configurable

2019-11-21 Thread GitBox
KurtYoung commented on a change in pull request #10170: [FLINK-14722][hadoop] Optimize mapred.HadoopInputSplit to not serialize conf when split is not configurable URL: https://github.com/apache/flink/pull/10170#discussion_r349455337 ## File path:

[GitHub] [flink] flinkbot edited a comment on issue #10284: [FLINK-14735][scheduler] Improve scheduling of all-to-all partitions with ALL input constraint for legacy scheduler

2019-11-21 Thread GitBox
flinkbot edited a comment on issue #10284: [FLINK-14735][scheduler] Improve scheduling of all-to-all partitions with ALL input constraint for legacy scheduler URL: https://github.com/apache/flink/pull/10284#issuecomment-557162273 ## CI report: *

[GitHub] [flink] wuchong commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner

2019-11-21 Thread GitBox
wuchong commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner URL: https://github.com/apache/flink/pull/10268#discussion_r349454718 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner

2019-11-21 Thread GitBox
JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner URL: https://github.com/apache/flink/pull/10268#discussion_r349454379 ## File path:

[jira] [Commented] (FLINK-14902) JDBCTableSource support AsyncLookupFunction

2019-11-21 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979912#comment-16979912 ] Jingsong Lee commented on FLINK-14902: -- Hi [~hailong wang], I am very glad you can have a try. As

[GitHub] [flink] openinx commented on a change in pull request #10270: [FLINK-14672][sql-client] Make Executor stateful in sql client

2019-11-21 Thread GitBox
openinx commented on a change in pull request #10270: [FLINK-14672][sql-client] Make Executor stateful in sql client URL: https://github.com/apache/flink/pull/10270#discussion_r349451095 ## File path:

[GitHub] [flink] openinx commented on a change in pull request #10270: [FLINK-14672][sql-client] Make Executor stateful in sql client

2019-11-21 Thread GitBox
openinx commented on a change in pull request #10270: [FLINK-14672][sql-client] Make Executor stateful in sql client URL: https://github.com/apache/flink/pull/10270#discussion_r349451137 ## File path:

[GitHub] [flink] openinx commented on a change in pull request #10270: [FLINK-14672][sql-client] Make Executor stateful in sql client

2019-11-21 Thread GitBox
openinx commented on a change in pull request #10270: [FLINK-14672][sql-client] Make Executor stateful in sql client URL: https://github.com/apache/flink/pull/10270#discussion_r349453119 ## File path:

[GitHub] [flink] openinx commented on a change in pull request #10270: [FLINK-14672][sql-client] Make Executor stateful in sql client

2019-11-21 Thread GitBox
openinx commented on a change in pull request #10270: [FLINK-14672][sql-client] Make Executor stateful in sql client URL: https://github.com/apache/flink/pull/10270#discussion_r349452604 ## File path:

[GitHub] [flink] openinx commented on a change in pull request #10270: [FLINK-14672][sql-client] Make Executor stateful in sql client

2019-11-21 Thread GitBox
openinx commented on a change in pull request #10270: [FLINK-14672][sql-client] Make Executor stateful in sql client URL: https://github.com/apache/flink/pull/10270#discussion_r349452869 ## File path:

[GitHub] [flink] openinx commented on a change in pull request #10270: [FLINK-14672][sql-client] Make Executor stateful in sql client

2019-11-21 Thread GitBox
openinx commented on a change in pull request #10270: [FLINK-14672][sql-client] Make Executor stateful in sql client URL: https://github.com/apache/flink/pull/10270#discussion_r349450962 ## File path:

[GitHub] [flink] openinx commented on a change in pull request #10270: [FLINK-14672][sql-client] Make Executor stateful in sql client

2019-11-21 Thread GitBox
openinx commented on a change in pull request #10270: [FLINK-14672][sql-client] Make Executor stateful in sql client URL: https://github.com/apache/flink/pull/10270#discussion_r349448931 ## File path:

[GitHub] [flink] openinx commented on a change in pull request #10270: [FLINK-14672][sql-client] Make Executor stateful in sql client

2019-11-21 Thread GitBox
openinx commented on a change in pull request #10270: [FLINK-14672][sql-client] Make Executor stateful in sql client URL: https://github.com/apache/flink/pull/10270#discussion_r349452821 ## File path:

[GitHub] [flink] openinx commented on a change in pull request #10270: [FLINK-14672][sql-client] Make Executor stateful in sql client

2019-11-21 Thread GitBox
openinx commented on a change in pull request #10270: [FLINK-14672][sql-client] Make Executor stateful in sql client URL: https://github.com/apache/flink/pull/10270#discussion_r349448946 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #10271: [FLINK-14874] [table-planner-blink] add local aggregate to solve data skew for ROLLUP/CUBE case

2019-11-21 Thread GitBox
KurtYoung commented on a change in pull request #10271: [FLINK-14874] [table-planner-blink] add local aggregate to solve data skew for ROLLUP/CUBE case URL: https://github.com/apache/flink/pull/10271#discussion_r349452471 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #10271: [FLINK-14874] [table-planner-blink] add local aggregate to solve data skew for ROLLUP/CUBE case

2019-11-21 Thread GitBox
KurtYoung commented on a change in pull request #10271: [FLINK-14874] [table-planner-blink] add local aggregate to solve data skew for ROLLUP/CUBE case URL: https://github.com/apache/flink/pull/10271#discussion_r349451853 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #10271: [FLINK-14874] [table-planner-blink] add local aggregate to solve data skew for ROLLUP/CUBE case

2019-11-21 Thread GitBox
KurtYoung commented on a change in pull request #10271: [FLINK-14874] [table-planner-blink] add local aggregate to solve data skew for ROLLUP/CUBE case URL: https://github.com/apache/flink/pull/10271#discussion_r349452562 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #10271: [FLINK-14874] [table-planner-blink] add local aggregate to solve data skew for ROLLUP/CUBE case

2019-11-21 Thread GitBox
KurtYoung commented on a change in pull request #10271: [FLINK-14874] [table-planner-blink] add local aggregate to solve data skew for ROLLUP/CUBE case URL: https://github.com/apache/flink/pull/10271#discussion_r349451475 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner

2019-11-21 Thread GitBox
JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner URL: https://github.com/apache/flink/pull/10268#discussion_r349450409 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner

2019-11-21 Thread GitBox
JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner URL: https://github.com/apache/flink/pull/10268#discussion_r349451016 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner

2019-11-21 Thread GitBox
JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner URL: https://github.com/apache/flink/pull/10268#discussion_r349451884 ## File path:

[GitHub] [flink] flinkbot edited a comment on issue #10235: [FLINK-14839][config] Let JobGraph#classpaths become non-null

2019-11-21 Thread GitBox
flinkbot edited a comment on issue #10235: [FLINK-14839][config] Let JobGraph#classpaths become non-null URL: https://github.com/apache/flink/pull/10235#issuecomment-554960500 ## CI report: * 15f1c1aa065c1135098b8cec5a52200c82675243 : FAILURE

[GitHub] [flink] zhuzhurk commented on issue #10284: [FLINK-14735][scheduler] Improve scheduling of all-to-all partitions with ALL input constraint for legacy scheduler

2019-11-21 Thread GitBox
zhuzhurk commented on issue #10284: [FLINK-14735][scheduler] Improve scheduling of all-to-all partitions with ALL input constraint for legacy scheduler URL: https://github.com/apache/flink/pull/10284#issuecomment-557411317 @flinkbot run travis

[jira] [Closed] (FLINK-14886) Wrong result in scalar query using blink planner

2019-11-21 Thread Kurt Young (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-14886. -- Fix Version/s: 1.10.0 Assignee: Leonard Xu Resolution: Duplicate The reason is

[jira] [Commented] (FLINK-14902) JDBCTableSource support AsyncLookupFunction

2019-11-21 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979902#comment-16979902 ] Jark Wu commented on FLINK-14902: - Sure [~hailong wang]. Could you share a bit about how do you plan to

[GitHub] [flink] docete commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner

2019-11-21 Thread GitBox
docete commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner URL: https://github.com/apache/flink/pull/10268#discussion_r349450401 ## File path:

[jira] [Closed] (FLINK-14900) output contains null value when a is null in pattern where a <> 'String'

2019-11-21 Thread Kurt Young (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-14900. -- Assignee: Leonard Xu Resolution: Duplicate The reason is FLINK-14924 > output contains null

[jira] [Assigned] (FLINK-14902) JDBCTableSource support AsyncLookupFunction

2019-11-21 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-14902: --- Assignee: hailong wang > JDBCTableSource support AsyncLookupFunction >

[jira] [Closed] (FLINK-14895) same rank in rollup row with group row that all group key are null

2019-11-21 Thread Kurt Young (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-14895. -- Assignee: Leonard Xu Resolution: Duplicate The reason is FLINK-14924 > same rank in rollup row

[GitHub] [flink] flinkbot edited a comment on issue #10287: [FLINK-14915][runtime] Remove the unnecessary param JobGraph from SchedulingStrategyFactory#createInstance

2019-11-21 Thread GitBox
flinkbot edited a comment on issue #10287: [FLINK-14915][runtime] Remove the unnecessary param JobGraph from SchedulingStrategyFactory#createInstance URL: https://github.com/apache/flink/pull/10287#issuecomment-557403940 ## CI report: * 91a9712e38f270006e6577e2976deb9993bb8243 :

[jira] [Created] (FLINK-14925) the return type of TO_TIMESTAMP should be Timestamp(9) instead of Timestamp(3)

2019-11-21 Thread Zhenghua Gao (Jira)
Zhenghua Gao created FLINK-14925: Summary: the return type of TO_TIMESTAMP should be Timestamp(9) instead of Timestamp(3) Key: FLINK-14925 URL: https://issues.apache.org/jira/browse/FLINK-14925

[GitHub] [flink] flinkbot edited a comment on issue #10288: [FLINK-14765] Remove STATE_UPDATER in Execution

2019-11-21 Thread GitBox
flinkbot edited a comment on issue #10288: [FLINK-14765] Remove STATE_UPDATER in Execution URL: https://github.com/apache/flink/pull/10288#issuecomment-557403970 ## CI report: * 018cc229676d6c6634ce4113342f46b42eb24416 : PENDING

[GitHub] [flink] docete commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner

2019-11-21 Thread GitBox
docete commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner URL: https://github.com/apache/flink/pull/10268#discussion_r349449435 ## File path:

[jira] [Commented] (FLINK-14924) CsvTableSource can not config empty column as null

2019-11-21 Thread Kurt Young (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979898#comment-16979898 ] Kurt Young commented on FLINK-14924: we met this problem before in blink, you can check this codes: 

[GitHub] [flink] JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner

2019-11-21 Thread GitBox
JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner URL: https://github.com/apache/flink/pull/10268#discussion_r349447644 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner

2019-11-21 Thread GitBox
JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner URL: https://github.com/apache/flink/pull/10268#discussion_r349446929 ## File path:

[GitHub] [flink] docete commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner

2019-11-21 Thread GitBox
docete commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner URL: https://github.com/apache/flink/pull/10268#discussion_r349446907 ## File path:

[GitHub] [flink] openinx commented on issue #10270: [FLINK-14672][sql-client] Make Executor stateful in sql client

2019-11-21 Thread GitBox
openinx commented on issue #10270: [FLINK-14672][sql-client] Make Executor stateful in sql client URL: https://github.com/apache/flink/pull/10270#issuecomment-557406344 Sync with @aljoscha on wednesday, he should know the issue I working. Of course, feel free to feedback if anything I

[jira] [Created] (FLINK-14924) CsvTableSource can not config empty column as null

2019-11-21 Thread Leonard Xu (Jira)
Leonard Xu created FLINK-14924: -- Summary: CsvTableSource can not config empty column as null Key: FLINK-14924 URL: https://issues.apache.org/jira/browse/FLINK-14924 Project: Flink Issue Type:

[GitHub] [flink] JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner

2019-11-21 Thread GitBox
JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner URL: https://github.com/apache/flink/pull/10268#discussion_r349445639 ## File path:

[GitHub] [flink] JingsongLi commented on issue #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner

2019-11-21 Thread GitBox
JingsongLi commented on issue #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner URL: https://github.com/apache/flink/pull/10268#issuecomment-557404480 > `JavaUserDefinedScalarFunctions`.`JavaFunc5` Can you add a `LocalDateTime` too?

[GitHub] [flink] JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner

2019-11-21 Thread GitBox
JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner URL: https://github.com/apache/flink/pull/10268#discussion_r349445023 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner

2019-11-21 Thread GitBox
JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner URL: https://github.com/apache/flink/pull/10268#discussion_r349441793 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner

2019-11-21 Thread GitBox
JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner URL: https://github.com/apache/flink/pull/10268#discussion_r349440840 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner

2019-11-21 Thread GitBox
JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner URL: https://github.com/apache/flink/pull/10268#discussion_r349443459 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner

2019-11-21 Thread GitBox
JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner URL: https://github.com/apache/flink/pull/10268#discussion_r349431966 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner

2019-11-21 Thread GitBox
JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner URL: https://github.com/apache/flink/pull/10268#discussion_r349444601 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner

2019-11-21 Thread GitBox
JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner URL: https://github.com/apache/flink/pull/10268#discussion_r349444664 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner

2019-11-21 Thread GitBox
JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner URL: https://github.com/apache/flink/pull/10268#discussion_r349442524 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner

2019-11-21 Thread GitBox
JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner URL: https://github.com/apache/flink/pull/10268#discussion_r349443102 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner

2019-11-21 Thread GitBox
JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner URL: https://github.com/apache/flink/pull/10268#discussion_r349444341 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner

2019-11-21 Thread GitBox
JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner URL: https://github.com/apache/flink/pull/10268#discussion_r349444627 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner

2019-11-21 Thread GitBox
JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner URL: https://github.com/apache/flink/pull/10268#discussion_r349440800 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner

2019-11-21 Thread GitBox
JingsongLi commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner URL: https://github.com/apache/flink/pull/10268#discussion_r349444678 ## File path:

[GitHub] [flink] flinkbot commented on issue #10287: [FLINK-14915][runtime] Remove the unnecessary param JobGraph from SchedulingStrategyFactory#createInstance

2019-11-21 Thread GitBox
flinkbot commented on issue #10287: [FLINK-14915][runtime] Remove the unnecessary param JobGraph from SchedulingStrategyFactory#createInstance URL: https://github.com/apache/flink/pull/10287#issuecomment-557403940 ## CI report: * 91a9712e38f270006e6577e2976deb9993bb8243 :

[GitHub] [flink] flinkbot commented on issue #10288: [FLINK-14765] Remove STATE_UPDATER in Execution

2019-11-21 Thread GitBox
flinkbot commented on issue #10288: [FLINK-14765] Remove STATE_UPDATER in Execution URL: https://github.com/apache/flink/pull/10288#issuecomment-557403970 ## CI report: * 018cc229676d6c6634ce4113342f46b42eb24416 : UNKNOWN Bot commands The @flinkbot bot supports

[GitHub] [flink] docete commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner

2019-11-21 Thread GitBox
docete commented on a change in pull request #10268: [Flink-14599][table-planner-blink] Support precision of TimestampType in blink planner URL: https://github.com/apache/flink/pull/10268#discussion_r349443370 ## File path:

[jira] [Commented] (FLINK-14883) Resource management on state backends

2019-11-21 Thread Yu Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979880#comment-16979880 ] Yu Li commented on FLINK-14883: --- {quote} We have built FrocksDB release jar package on mac, linux32,

  1   2   3   4   5   6   7   >