[GitHub] [flink] klion26 commented on a change in pull request #13180: [FLINK-18962][checkpointing] Improve logging when checkpoint declined

2020-08-19 Thread GitBox
klion26 commented on a change in pull request #13180: URL: https://github.com/apache/flink/pull/13180#discussion_r473623138 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/AsyncCheckpointRunnable.java ## @@ -129,12 +129,10 @@ public

[GitHub] [flink] flinkbot edited a comment on pull request #13170: [FLINK-18937][python][doc] Add a Environemnt Setup section to the Installation document

2020-08-19 Thread GitBox
flinkbot edited a comment on pull request #13170: URL: https://github.com/apache/flink/pull/13170#issuecomment-674757748 ## CI report: * 74263dcb43129be2ba7c4015971a40a48b5e11af Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13203: [FLINK-18984][python][docs] Add tutorial documentation for Python DataStream API

2020-08-19 Thread GitBox
flinkbot edited a comment on pull request #13203: URL: https://github.com/apache/flink/pull/13203#issuecomment-676985457 ## CI report: * 7170e6d063f5c8e7ddf4104d4beca360be3d8136 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13188: [hotfix][docs] Translate building.md to building.zh.md

2020-08-19 Thread GitBox
flinkbot edited a comment on pull request #13188: URL: https://github.com/apache/flink/pull/13188#issuecomment-675323573 ## CI report: * 8301e1e53770c95e2f903526ac93e80e039cf4f2 Azure:

[GitHub] [flink] klion26 commented on a change in pull request #13180: [FLINK-18962][checkpointing] Improve logging when checkpoint declined

2020-08-19 Thread GitBox
klion26 commented on a change in pull request #13180: URL: https://github.com/apache/flink/pull/13180#discussion_r473613780 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/AsyncCheckpointRunnable.java ## @@ -129,12 +129,10 @@ public

[GitHub] [flink] flinkbot edited a comment on pull request #13171: [FLINK-18927][python][doc] Add Debugging document in Python Table API

2020-08-19 Thread GitBox
flinkbot edited a comment on pull request #13171: URL: https://github.com/apache/flink/pull/13171#issuecomment-674777423 ## CI report: * 577e982dfa3fd04f03f844f9fd32e561e41f856b Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13175: [FLINK-18955][Checkpointing] Add checkpoint path to job startup/restore message

2020-08-19 Thread GitBox
flinkbot edited a comment on pull request #13175: URL: https://github.com/apache/flink/pull/13175#issuecomment-674839926 ## CI report: * 0cc43ac38a2161bfd6c005782c08d2c70cc47e43 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13175: [FLINK-18955][Checkpointing] Add checkpoint path to job startup/restore message

2020-08-19 Thread GitBox
flinkbot edited a comment on pull request #13175: URL: https://github.com/apache/flink/pull/13175#issuecomment-674839926 ## CI report: * 0cc43ac38a2161bfd6c005782c08d2c70cc47e43 Azure:

[GitHub] [flink] curcur commented on pull request #13175: [FLINK-18955][Checkpointing] Add checkpoint path to job startup/restore message

2020-08-19 Thread GitBox
curcur commented on pull request #13175: URL: https://github.com/apache/flink/pull/13175#issuecomment-677059704 Test results after adding including checkpoint type information in `CompletedCheckpoint` ``` 8366 [flink-akka.actor.default-dispatcher-4] INFO

[GitHub] [flink] curcur removed a comment on pull request #13175: [FLINK-18955][Checkpointing] Add checkpoint path to job startup/restore message

2020-08-19 Thread GitBox
curcur removed a comment on pull request #13175: URL: https://github.com/apache/flink/pull/13175#issuecomment-677043774 ``` 8366 [flink-akka.actor.default-dispatcher-4] INFO org.apache.flink.runtime.checkpoint.CheckpointCoordinator [] - Restoring job 7aec7905c64fcf38ceb2b86e6193638d

[GitHub] [flink] curcur commented on pull request #13175: [FLINK-18955][Checkpointing] Add checkpoint path to job startup/restore message

2020-08-19 Thread GitBox
curcur commented on pull request #13175: URL: https://github.com/apache/flink/pull/13175#issuecomment-677043774 ``` 8366 [flink-akka.actor.default-dispatcher-4] INFO org.apache.flink.runtime.checkpoint.CheckpointCoordinator [] - Restoring job 7aec7905c64fcf38ceb2b86e6193638d from

[GitHub] [flink] flinkbot edited a comment on pull request #13188: [hotfix][docs] Translate building.md to building.zh.md

2020-08-19 Thread GitBox
flinkbot edited a comment on pull request #13188: URL: https://github.com/apache/flink/pull/13188#issuecomment-675323573 ## CI report: * d9e9ce1d0f0500087f60e0ebfaf78b682a146412 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13203: [FLINK-18984][python][docs] Add tutorial documentation for Python DataStream API

2020-08-19 Thread GitBox
flinkbot edited a comment on pull request #13203: URL: https://github.com/apache/flink/pull/13203#issuecomment-676985457 ## CI report: * 7170e6d063f5c8e7ddf4104d4beca360be3d8136 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13193: [FLINK-18918][python][docs] Add dedicated connector documentation for Python Table API

2020-08-19 Thread GitBox
flinkbot edited a comment on pull request #13193: URL: https://github.com/apache/flink/pull/13193#issuecomment-675460565 ## CI report: * ec8c4b3b4e25ecbe5e1397e30bd4aef7900c38af Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13188: [hotfix][docs] Translate building.md to building.zh.md

2020-08-19 Thread GitBox
flinkbot edited a comment on pull request #13188: URL: https://github.com/apache/flink/pull/13188#issuecomment-675323573 ## CI report: * 43492c04af59be981162de88a0952dbfc2894ba9 Azure:

[GitHub] [flink] flinkbot commented on pull request #13203: [FLINK-18984][python][docs] Add tutorial documentation for Python DataStream API

2020-08-19 Thread GitBox
flinkbot commented on pull request #13203: URL: https://github.com/apache/flink/pull/13203#issuecomment-676985457 ## CI report: * 7170e6d063f5c8e7ddf4104d4beca360be3d8136 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #13170: [FLINK-18937][python][doc] Add a Environemnt Setup section to the Installation document

2020-08-19 Thread GitBox
flinkbot edited a comment on pull request #13170: URL: https://github.com/apache/flink/pull/13170#issuecomment-674757748 ## CI report: * d97160a59b0c3e5f0ad70b3ecdcc6f4234e81fbd Azure:

[jira] [Assigned] (FLINK-18999) Temporary generic table doesn't work with HiveCatalog

2020-08-19 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee reassigned FLINK-18999: Assignee: Rui Li > Temporary generic table doesn't work with HiveCatalog >

[jira] [Commented] (FLINK-16839) Connectors Kinesis metrics can be disabled

2020-08-19 Thread Muchl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180945#comment-17180945 ] Muchl commented on FLINK-16839: --- is there any progress on this issue. can i add a kinesis metrics switch

[GitHub] [flink] flinkbot commented on pull request #13203: [FLINK-18984][python][docs] Add tutorial documentation for Python DataStream API

2020-08-19 Thread GitBox
flinkbot commented on pull request #13203: URL: https://github.com/apache/flink/pull/13203#issuecomment-676964944 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] curcur commented on a change in pull request #13175: [FLINK-18955][Checkpointing] Add checkpoint path to job startup/restore message

2020-08-19 Thread GitBox
curcur commented on a change in pull request #13175: URL: https://github.com/apache/flink/pull/13175#discussion_r473569690 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java ## @@ -1293,7 +1293,7 @@ private boolean

[GitHub] [flink] flinkbot edited a comment on pull request #13188: [hotfix][docs] Translate building.md to building.zh.md

2020-08-19 Thread GitBox
flinkbot edited a comment on pull request #13188: URL: https://github.com/apache/flink/pull/13188#issuecomment-675323573 ## CI report: * 43492c04af59be981162de88a0952dbfc2894ba9 Azure:

[jira] [Updated] (FLINK-18984) Add tutorial documentation for Python DataStream API

2020-08-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-18984: --- Labels: pull-request-available (was: ) > Add tutorial documentation for Python DataStream

[GitHub] [flink] flinkbot edited a comment on pull request #13170: [FLINK-18937][python][doc] Add a Environemnt Setup section to the Installation document

2020-08-19 Thread GitBox
flinkbot edited a comment on pull request #13170: URL: https://github.com/apache/flink/pull/13170#issuecomment-674757748 ## CI report: * d97160a59b0c3e5f0ad70b3ecdcc6f4234e81fbd Azure:

[GitHub] [flink] hequn8128 opened a new pull request #13203: [FLINK-18984][python][docs] Add tutorial documentation for Python DataStream API

2020-08-19 Thread GitBox
hequn8128 opened a new pull request #13203: URL: https://github.com/apache/flink/pull/13203 ## What is the purpose of the change This pull request adds tutorial documentation for Python DataStream API. ## Brief change log - Adds tutorial documentation for

[GitHub] [flink] hequn8128 commented on pull request #13203: [FLINK-18984][python][docs] Add tutorial documentation for Python DataStream API

2020-08-19 Thread GitBox
hequn8128 commented on pull request #13203: URL: https://github.com/apache/flink/pull/13203#issuecomment-676961064 CC @sjwiesman @shuiqiangchen This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] flinkbot edited a comment on pull request #13171: [FLINK-18927][python][doc] Add Debugging document in Python Table API

2020-08-19 Thread GitBox
flinkbot edited a comment on pull request #13171: URL: https://github.com/apache/flink/pull/13171#issuecomment-674777423 ## CI report: * 9474e60fe7211c3ad12d963c9417ced7ca4b24d7 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13024: [FLINK-18742][flink-clients] Some configuration args do not take effect at client

2020-08-19 Thread GitBox
flinkbot edited a comment on pull request #13024: URL: https://github.com/apache/flink/pull/13024#issuecomment-666148245 ## CI report: * eb611d5b39f997fa3e986b5d163cb65a44b4b0ba UNKNOWN * b2ae9dd70445adfb6e7b44deae46225841537b7d Azure:

[GitHub] [flink] oikomi commented on pull request #13177: [FLINK-18958] Lose column comment when create table

2020-08-19 Thread GitBox
oikomi commented on pull request #13177: URL: https://github.com/apache/flink/pull/13177#issuecomment-676945243 @wuchong OK , let's wait for FLINK-17793 . This is an automated message from the Apache Git Service. To respond

[GitHub] [flink] wbgentleman commented on pull request #13188: [hotfix][docs] Translate building.md to building.zh.md

2020-08-19 Thread GitBox
wbgentleman commented on pull request #13188: URL: https://github.com/apache/flink/pull/13188#issuecomment-676940732 I have done all the modification accordingly. Thank you very much. This is an automated message from the

[jira] [Commented] (FLINK-18999) Temporary generic table doesn't work with HiveCatalog

2020-08-19 Thread harold.miao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180941#comment-17180941 ] harold.miao commented on FLINK-18999: - [~lirui] sorry for the misunderstand, we focus on the other 

[GitHub] [flink] wbgentleman commented on pull request #13188: [hotfix][docs] Translate building.md to building.zh.md

2020-08-19 Thread GitBox
wbgentleman commented on pull request #13188: URL: https://github.com/apache/flink/pull/13188#issuecomment-676941627 @TisonKun @wuchong Please help to review again. Thank you. This is an automated message from the Apache Git

[GitHub] [flink] wbgentleman commented on a change in pull request #13188: [hotfix][docs] Translate building.md to building.zh.md

2020-08-19 Thread GitBox
wbgentleman commented on a change in pull request #13188: URL: https://github.com/apache/flink/pull/13188#discussion_r473565646 ## File path: docs/flinkDev/building.zh.md ## @@ -22,62 +22,63 @@ specific language governing permissions and limitations under the License. -->

[GitHub] [flink] flinkbot edited a comment on pull request #13171: [FLINK-18927][python][doc] Add Debugging document in Python Table API

2020-08-19 Thread GitBox
flinkbot edited a comment on pull request #13171: URL: https://github.com/apache/flink/pull/13171#issuecomment-674777423 ## CI report: * 9474e60fe7211c3ad12d963c9417ced7ca4b24d7 Azure:

[jira] [Closed] (FLINK-18995) Some Hive functions fail because they need to access SessionState

2020-08-19 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-18995. Resolution: Fixed master: 2fc0899dd3e818b0f60c5d5de2eba9d44b5375a6 > Some Hive functions fail

[GitHub] [flink] JingsongLi merged pull request #13197: [FLINK-18995][hive] Some Hive functions fail because they need to acc…

2020-08-19 Thread GitBox
JingsongLi merged pull request #13197: URL: https://github.com/apache/flink/pull/13197 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] wuchong commented on a change in pull request #13188: [hotfix][docs] Translate building.md to building.zh.md

2020-08-19 Thread GitBox
wuchong commented on a change in pull request #13188: URL: https://github.com/apache/flink/pull/13188#discussion_r473563665 ## File path: docs/flinkDev/building.zh.md ## @@ -22,62 +22,63 @@ specific language governing permissions and limitations under the License. -->

[jira] [Commented] (FLINK-18999) Temporary generic table doesn't work with HiveCatalog

2020-08-19 Thread Rui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180939#comment-17180939 ] Rui Li commented on FLINK-18999: [~oikomi] Let me know if you still want to work on this, otherwise I'll

[GitHub] [flink] HuangXingBo commented on pull request #13171: [FLINK-18927][python][doc] Add Debugging document in Python Table API

2020-08-19 Thread GitBox
HuangXingBo commented on pull request #13171: URL: https://github.com/apache/flink/pull/13171#issuecomment-676925486 Thanks a lot for @sjwiesman review. I have addressed the comments at the latest commit. This is an

[GitHub] [flink] flinkbot edited a comment on pull request #13188: [hotfix][docs] Translate building.md to building.zh.md

2020-08-19 Thread GitBox
flinkbot edited a comment on pull request #13188: URL: https://github.com/apache/flink/pull/13188#issuecomment-675323573 ## CI report: * 43492c04af59be981162de88a0952dbfc2894ba9 Azure:

[jira] [Issue Comment Deleted] (FLINK-18999) Temporary generic table doesn't work with HiveCatalog

2020-08-19 Thread harold.miao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] harold.miao updated FLINK-18999: Comment: was deleted (was: hi  all , we solved this issue in our production env , could you

[GitHub] [flink] wbgentleman commented on a change in pull request #13188: [hotfix][docs] Translate building.md to building.zh.md

2020-08-19 Thread GitBox
wbgentleman commented on a change in pull request #13188: URL: https://github.com/apache/flink/pull/13188#discussion_r473560100 ## File path: docs/flinkDev/building.zh.md ## @@ -22,62 +22,63 @@ specific language governing permissions and limitations under the License. -->

[GitHub] [flink] wuchong commented on pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

2020-08-19 Thread GitBox
wuchong commented on pull request #12880: URL: https://github.com/apache/flink/pull/12880#issuecomment-676895558 There are some failures in the build: ``` flake8 checks= ./pyflink/table/table_config.py:193:101: E501 line too long (105 > 100

[GitHub] [flink] wuchong merged pull request #12908: [FLINK-18449][table sql/api]Kafka topic discovery & partition discove…

2020-08-19 Thread GitBox
wuchong merged pull request #12908: URL: https://github.com/apache/flink/pull/12908 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Closed] (FLINK-18449) Make topic discovery and partition discovery configurable for FlinkKafkaConsumer in Table API

2020-08-19 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-18449. --- Resolution: Fixed Implemented in master (1.12.0): b8ee51b832d00d4615e249f384e13dcaa1f14ddf > Make topic

[GitHub] [flink] wuchong commented on a change in pull request #13188: [hotfix][docs] Translate building.md to building.zh.md

2020-08-19 Thread GitBox
wuchong commented on a change in pull request #13188: URL: https://github.com/apache/flink/pull/13188#discussion_r473557284 ## File path: docs/flinkDev/building.zh.md ## @@ -22,62 +22,63 @@ specific language governing permissions and limitations under the License. -->

[GitHub] [flink] flinkbot edited a comment on pull request #13193: [FLINK-18918][python][docs] Add dedicated connector documentation for Python Table API

2020-08-19 Thread GitBox
flinkbot edited a comment on pull request #13193: URL: https://github.com/apache/flink/pull/13193#issuecomment-675460565 ## CI report: * 3218091590ebac41d0351ff99aad0b2e6dc29cb6 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13188: [hotfix][docs] Translate building.md to building.zh.md

2020-08-19 Thread GitBox
flinkbot edited a comment on pull request #13188: URL: https://github.com/apache/flink/pull/13188#issuecomment-675323573 ## CI report: * 43492c04af59be981162de88a0952dbfc2894ba9 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13024: [FLINK-18742][flink-clients] Some configuration args do not take effect at client

2020-08-19 Thread GitBox
flinkbot edited a comment on pull request #13024: URL: https://github.com/apache/flink/pull/13024#issuecomment-666148245 ## CI report: * eb611d5b39f997fa3e986b5d163cb65a44b4b0ba UNKNOWN * b2ae9dd70445adfb6e7b44deae46225841537b7d Azure:

[GitHub] [flink] RocMarshal edited a comment on pull request #13172: [FLINK-18854][docs-zh] Translate the 'API Migration Guides' page of 'Application Development' into Chinese

2020-08-19 Thread GitBox
RocMarshal edited a comment on pull request #13172: URL: https://github.com/apache/flink/pull/13172#issuecomment-675233767 Hi, @XBaith @klion26 . Could you help me to review this PR if you have free time? Thank you.

[jira] [Commented] (FLINK-18999) Temporary generic table doesn't work with HiveCatalog

2020-08-19 Thread harold.miao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180933#comment-17180933 ] harold.miao commented on FLINK-18999: - hi  all , we solved this issue in our production env , could

[GitHub] [flink] Shawn-Hx commented on pull request #13093: [FLINK-18860][docs-zh] Translate "Execution Plans" page of "Managing Execution" into Chinese

2020-08-19 Thread GitBox
Shawn-Hx commented on pull request #13093: URL: https://github.com/apache/flink/pull/13093#issuecomment-676873411 Hi, @klion26 . This PR is ready to be reviewed. Would you please help to review it at your convenience ? Thank you ~

[GitHub] [flink] wbgentleman commented on a change in pull request #13188: [hotfix][docs] Translate building.md to building.zh.md

2020-08-19 Thread GitBox
wbgentleman commented on a change in pull request #13188: URL: https://github.com/apache/flink/pull/13188#discussion_r473554057 ## File path: docs/flinkDev/building.zh.md ## @@ -22,62 +22,63 @@ specific language governing permissions and limitations under the License. -->

[GitHub] [flink] wangzzu commented on pull request #13024: [FLINK-18742][flink-clients] Some configuration args do not take effect at client

2020-08-19 Thread GitBox
wangzzu commented on pull request #13024: URL: https://github.com/apache/flink/pull/13024#issuecomment-676867367 @kl0u Thanks for your review, I have modified on your suggestion. This is an automated message from the Apache

[jira] [Comment Edited] (FLINK-16408) Bind user code class loader to lifetime of a slot

2020-08-19 Thread Echo Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180929#comment-17180929 ] Echo Lee edited comment on FLINK-16408 at 8/20/20, 2:37 AM: [~trohrmann] 

[jira] [Commented] (FLINK-16408) Bind user code class loader to lifetime of a slot

2020-08-19 Thread Echo Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180929#comment-17180929 ] Echo Lee commented on FLINK-16408: -- [~trohrmann]  [~sewen]  I also found another phenomenon. We submit

[GitHub] [flink] flinkbot edited a comment on pull request #13193: [FLINK-18918][python][docs] Add dedicated connector documentation for Python Table API

2020-08-19 Thread GitBox
flinkbot edited a comment on pull request #13193: URL: https://github.com/apache/flink/pull/13193#issuecomment-675460565 ## CI report: * 3218091590ebac41d0351ff99aad0b2e6dc29cb6 Azure:

[GitHub] [flink] wangzzu commented on a change in pull request #13024: [FLINK-18742][flink-clients] Some configuration args do not take effect at client

2020-08-19 Thread GitBox
wangzzu commented on a change in pull request #13024: URL: https://github.com/apache/flink/pull/13024#discussion_r473552879 ## File path: flink-clients/src/main/java/org/apache/flink/client/program/PackagedProgram.java ## @@ -220,12 +220,47 @@ public ClassLoader

[GitHub] [flink] wangzzu commented on a change in pull request #13024: [FLINK-18742][flink-clients] Some configuration args do not take effect at client

2020-08-19 Thread GitBox
wangzzu commented on a change in pull request #13024: URL: https://github.com/apache/flink/pull/13024#discussion_r473547214 ## File path: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ## @@ -219,34 +219,49 @@ protected void run(String[] args) throws

[GitHub] [flink] wangzzu commented on a change in pull request #13024: [FLINK-18742][flink-clients] Some configuration args do not take effect at client

2020-08-19 Thread GitBox
wangzzu commented on a change in pull request #13024: URL: https://github.com/apache/flink/pull/13024#discussion_r473546650 ## File path: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ## @@ -219,34 +219,49 @@ protected void run(String[] args) throws

[GitHub] [flink] wangzzu commented on a change in pull request #13024: [FLINK-18742][flink-clients] Some configuration args do not take effect at client

2020-08-19 Thread GitBox
wangzzu commented on a change in pull request #13024: URL: https://github.com/apache/flink/pull/13024#discussion_r473546486 ## File path: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ## @@ -219,34 +219,49 @@ protected void run(String[] args) throws

[GitHub] [flink] hequn8128 commented on pull request #13193: [FLINK-18918][python][docs] Add dedicated connector documentation for Python Table API

2020-08-19 Thread GitBox
hequn8128 commented on pull request #13193: URL: https://github.com/apache/flink/pull/13193#issuecomment-676854960 @sjwiesman Thank you for your nice review. All comments have been addressed. This is an automated message

[GitHub] [flink] hequn8128 merged pull request #13192: [FLINK-18912][python][docs] Add Python api tutorial under Python GettingStart

2020-08-19 Thread GitBox
hequn8128 merged pull request #13192: URL: https://github.com/apache/flink/pull/13192 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (FLINK-18912) Add a Table API tutorial link(linked to try-flink/python_table_api.md) under the "Python API" -> "GettingStart" -> "Tutorial" section

2020-08-19 Thread Hequn Cheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180918#comment-17180918 ] Hequn Cheng commented on FLINK-18912: - Resolved in 1.12.0 via

[GitHub] [flink] hequn8128 commented on pull request #13192: [FLINK-18912][python][docs] Add Python api tutorial under Python GettingStart

2020-08-19 Thread GitBox
hequn8128 commented on pull request #13192: URL: https://github.com/apache/flink/pull/13192#issuecomment-676849042 @sjwiesman Thanks a lot for the review. Merging... This is an automated message from the Apache Git Service.

[jira] [Commented] (FLINK-18953) Add documentation for DataTypes in Python DataStream API

2020-08-19 Thread Hequn Cheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180917#comment-17180917 ] Hequn Cheng commented on FLINK-18953: - Resolved in 1.12.0 via

[jira] [Closed] (FLINK-18953) Add documentation for DataTypes in Python DataStream API

2020-08-19 Thread Hequn Cheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hequn Cheng closed FLINK-18953. --- Resolution: Resolved > Add documentation for DataTypes in Python DataStream API >

[GitHub] [flink] hequn8128 merged pull request #13199: [FLINK-18953][python][docs] Add documentation for DataTypes in Python DataStream API

2020-08-19 Thread GitBox
hequn8128 merged pull request #13199: URL: https://github.com/apache/flink/pull/13199 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] hequn8128 commented on pull request #13199: [FLINK-18953][python][docs] Add documentation for DataTypes in Python DataStream API

2020-08-19 Thread GitBox
hequn8128 commented on pull request #13199: URL: https://github.com/apache/flink/pull/13199#issuecomment-676847061 @sjwiesman @shuiqiangchen Thanks a lot for the review. The comments have all been addressed. Merging...

[GitHub] [flink] flinkbot edited a comment on pull request #13188: [hotfix][docs] Translate building.md to building.zh.md

2020-08-19 Thread GitBox
flinkbot edited a comment on pull request #13188: URL: https://github.com/apache/flink/pull/13188#issuecomment-675323573 ## CI report: * 5c37469ec372c4660283677e4984a8c87f5254a9 Azure:

[jira] [Commented] (FLINK-16768) HadoopS3RecoverableWriterITCase.testRecoverWithStateWithMultiPart hangs

2020-08-19 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180914#comment-17180914 ] Dian Fu commented on FLINK-16768: -

[jira] [Commented] (FLINK-13598) frocksdb doesn't have arm release

2020-08-19 Thread wangxiyuan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180907#comment-17180907 ] wangxiyuan commented on FLINK-13598: [~yunta] ,  hi, if you bump rocksdb to the version higher than

[GitHub] [flink] flinkbot edited a comment on pull request #13188: [hotfix][docs] Translate building.md to building.zh.md

2020-08-19 Thread GitBox
flinkbot edited a comment on pull request #13188: URL: https://github.com/apache/flink/pull/13188#issuecomment-675323573 ## CI report: * 5c37469ec372c4660283677e4984a8c87f5254a9 Azure:

[jira] [Updated] (FLINK-13598) frocksdb doesn't have arm release

2020-08-19 Thread wangxiyuan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wangxiyuan updated FLINK-13598: --- Attachment: image-2020-08-20-09-22-24-021.png > frocksdb doesn't have arm release >

[GitHub] [flink] wbgentleman commented on a change in pull request #13188: [hotfix][docs] Translate building.md to building.zh.md

2020-08-19 Thread GitBox
wbgentleman commented on a change in pull request #13188: URL: https://github.com/apache/flink/pull/13188#discussion_r473496456 ## File path: docs/flinkDev/building.zh.md ## @@ -22,62 +22,63 @@ specific language governing permissions and limitations under the License. -->

[GitHub] [flink] Yungthuis closed pull request #13202: Translate \docs\dev\table\hive\hive_streaming.zh.md into Chinese

2020-08-19 Thread GitBox
Yungthuis closed pull request #13202: URL: https://github.com/apache/flink/pull/13202 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Resolved] (FLINK-15299) Move ClientUtils#submitJob & ClientUtils#submitJobAndWaitForResult to test scope

2020-08-19 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen resolved FLINK-15299. --- Resolution: Fixed closed by dfb8a3be7f0d113032a28cf6a1b296725e5562f5 > Move ClientUtils#submitJob

[GitHub] [flink] TisonKun closed pull request #11469: [FLINK-15299][test] Move ClientUtils#submitJob & ClientUtils#submitJobAndWaitForResult to test scope

2020-08-19 Thread GitBox
TisonKun closed pull request #11469: URL: https://github.com/apache/flink/pull/11469 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] TisonKun commented on pull request #11469: [FLINK-15299][test] Move ClientUtils#submitJob & ClientUtils#submitJobAndWaitForResult to test scope

2020-08-19 Thread GitBox
TisonKun commented on pull request #11469: URL: https://github.com/apache/flink/pull/11469#issuecomment-676808794 @zentol Thanks for your review. Applying suggestion on merging. This is an automated message from the Apache

[GitHub] [flink] zentol commented on a change in pull request #11469: [FLINK-15299][test] Move ClientUtils#submitJob & ClientUtils#submitJobAndWaitForResult to test scope

2020-08-19 Thread GitBox
zentol commented on a change in pull request #11469: URL: https://github.com/apache/flink/pull/11469#discussion_r473362720 ## File path: flink-clients/src/test/java/org/apache/flink/client/program/rest/RestClusterClientTest.java ## @@ -458,6 +466,123 @@ public void

[GitHub] [flink] flinkbot edited a comment on pull request #13202: Translate \docs\dev\table\hive\hive_streaming.zh.md into Chinese

2020-08-19 Thread GitBox
flinkbot edited a comment on pull request #13202: URL: https://github.com/apache/flink/pull/13202#issuecomment-676563144 ## CI report: * 0d910371f9ae147693f2fa08be738a1b8d44aeaf Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #11469: [FLINK-15299][test] Move ClientUtils#submitJob & ClientUtils#submitJobAndWaitForResult to test scope

2020-08-19 Thread GitBox
flinkbot edited a comment on pull request #11469: URL: https://github.com/apache/flink/pull/11469#issuecomment-601972922 ## CI report: * 3d2c9e8aba9c73920380e988173015ef770f7f9f Azure:

[GitHub] [flink] sjwiesman commented on a change in pull request #13192: [FLINK-18912][python][docs] Add Python api tutorial under Python GettingStart

2020-08-19 Thread GitBox
sjwiesman commented on a change in pull request #13192: URL: https://github.com/apache/flink/pull/13192#discussion_r473290661 ## File path: docs/try-flink/python_table_api.md ## @@ -23,161 +23,9 @@ specific language governing permissions and limitations under the License.

[GitHub] [flink] sjwiesman commented on a change in pull request #13193: [FLINK-18918][python][docs] Add dedicated connector documentation for Python Table API

2020-08-19 Thread GitBox
sjwiesman commented on a change in pull request #13193: URL: https://github.com/apache/flink/pull/13193#discussion_r473290415 ## File path: docs/dev/python/user-guide/table/python_table_api_connectors.md ## @@ -0,0 +1,194 @@ +--- +title: "Connectors" +nav-parent_id:

[GitHub] [flink] sjwiesman commented on a change in pull request #13199: [FLINK-18953][python][docs] Add documentation for DataTypes in Python DataStream API

2020-08-19 Thread GitBox
sjwiesman commented on a change in pull request #13199: URL: https://github.com/apache/flink/pull/13199#discussion_r473290103 ## File path: docs/dev/python/user-guide/datastream/data_types.md ## @@ -0,0 +1,114 @@ +--- +title: "Data Types" +nav-parent_id: python_datastream_api

[GitHub] [flink] flinkbot edited a comment on pull request #13200: [FLINK-18553][table-api-java] Update set operations to new type system

2020-08-19 Thread GitBox
flinkbot edited a comment on pull request #13200: URL: https://github.com/apache/flink/pull/13200#issuecomment-676446467 ## CI report: * e6f4185252297bcb68b7cef24529f7a4aebe9fa2 Azure:

[GitHub] [flink] zentol commented on a change in pull request #13190: [FLINK-18986][kubernetes] Create ClusterClient only for attached deployments

2020-08-19 Thread GitBox
zentol commented on a change in pull request #13190: URL: https://github.com/apache/flink/pull/13190#discussion_r473221865 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesClusterClientFactory.java ## @@ -51,10 +51,7 @@ public boolean

[GitHub] [flink] zentol commented on a change in pull request #13190: [FLINK-18986][kubernetes] Create ClusterClient only for attached deployments

2020-08-19 Thread GitBox
zentol commented on a change in pull request #13190: URL: https://github.com/apache/flink/pull/13190#discussion_r473221865 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesClusterClientFactory.java ## @@ -51,10 +51,7 @@ public boolean

[jira] [Commented] (FLINK-13598) frocksdb doesn't have arm release

2020-08-19 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180733#comment-17180733 ] Yun Tang commented on FLINK-13598: -- [~wangxiyuan], first of all, we should bump the version of based

[GitHub] [flink] zentol commented on a change in pull request #13190: [FLINK-18986][kubernetes] Create ClusterClient only for attached deployments

2020-08-19 Thread GitBox
zentol commented on a change in pull request #13190: URL: https://github.com/apache/flink/pull/13190#discussion_r473220233 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/cli/KubernetesSessionCli.java ## @@ -88,6 +88,7 @@ public Configuration

[GitHub] [flink] zentol commented on a change in pull request #13190: [FLINK-18986][kubernetes] Create ClusterClient only for attached deployments

2020-08-19 Thread GitBox
zentol commented on a change in pull request #13190: URL: https://github.com/apache/flink/pull/13190#discussion_r473220233 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/cli/KubernetesSessionCli.java ## @@ -88,6 +88,7 @@ public Configuration

[GitHub] [flink] flinkbot edited a comment on pull request #13199: [FLINK-18953][python][docs] Add documentation for DataTypes in Python DataStream API

2020-08-19 Thread GitBox
flinkbot edited a comment on pull request #13199: URL: https://github.com/apache/flink/pull/13199#issuecomment-676387876 ## CI report: * c2d450efbdda3b25cafa41cc5b1323ab43630a38 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13202: Translate \docs\dev\table\hive\hive_streaming.zh.md into Chinese

2020-08-19 Thread GitBox
flinkbot edited a comment on pull request #13202: URL: https://github.com/apache/flink/pull/13202#issuecomment-676563144 ## CI report: * 0d910371f9ae147693f2fa08be738a1b8d44aeaf Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13201: [hotfix][docs] Fix typos and links in the new Source API docs

2020-08-19 Thread GitBox
flinkbot edited a comment on pull request #13201: URL: https://github.com/apache/flink/pull/13201#issuecomment-676517952 ## CI report: * c0c0fbcac00c9602d9d35c420af16e123e63cbd2 Azure:

[GitHub] [flink] zentol commented on a change in pull request #13190: [FLINK-18986][kubernetes] Create ClusterClient only for attached deployments

2020-08-19 Thread GitBox
zentol commented on a change in pull request #13190: URL: https://github.com/apache/flink/pull/13190#discussion_r473214901 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesClusterClientFactory.java ## @@ -51,10 +51,7 @@ public boolean

[GitHub] [flink] flinkbot commented on pull request #13202: Translate \docs\dev\table\hive\hive_streaming.zh.md into Chinese

2020-08-19 Thread GitBox
flinkbot commented on pull request #13202: URL: https://github.com/apache/flink/pull/13202#issuecomment-676563144 ## CI report: * 0d910371f9ae147693f2fa08be738a1b8d44aeaf UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot commented on pull request #13202: Translate \docs\dev\table\hive\hive_streaming.zh.md into Chinese

2020-08-19 Thread GitBox
flinkbot commented on pull request #13202: URL: https://github.com/apache/flink/pull/13202#issuecomment-676552544 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] Yungthuis commented on pull request #13202: Translate \docs\dev\table\hive\hive_streaming.zh.md into Chinese

2020-08-19 Thread GitBox
Yungthuis commented on pull request #13202: URL: https://github.com/apache/flink/pull/13202#issuecomment-676551987 hive_streaming.zh.md has been translated into Chinese This is an automated message from the Apache Git

[GitHub] [flink] Yungthuis opened a new pull request #13202: Translate \docs\dev\table\hive\hive_streaming.zh.md into Chinese

2020-08-19 Thread GitBox
Yungthuis opened a new pull request #13202: URL: https://github.com/apache/flink/pull/13202 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[GitHub] [flink-web] sjwiesman commented on a change in pull request #370: Add a blog post about the current state of Flink on Docker

2020-08-19 Thread GitBox
sjwiesman commented on a change in pull request #370: URL: https://github.com/apache/flink-web/pull/370#discussion_r473175127 ## File path: _posts/2020-08-20-flink-docker.md ## @@ -0,0 +1,90 @@ +--- +layout: post +title: "The State of Flink on Docker" +date:

  1   2   3   >