[GitHub] [flink] klion26 commented on a change in pull request #13212: [FLINK-18973][docs-zh] Translate the 'History Server' page of 'Debugging & Monitoring' into Chinese

2020-08-25 Thread GitBox
klion26 commented on a change in pull request #13212: URL: https://github.com/apache/flink/pull/13212#discussion_r477046283 ## File path: docs/monitoring/historyserver.zh.md ## @@ -22,62 +22,67 @@ specific language governing permissions and limitations under the License. -->

[jira] [Closed] (FLINK-11712) Add cost model for both batch and streaming

2020-08-25 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-11712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he closed FLINK-11712. -- Resolution: Resolved > Add cost model for both batch and streaming >

[GitHub] [flink-statefun] billyrrr commented on pull request #131: [FLINK-18968] Translate README.md to Chinese

2020-08-25 Thread GitBox
billyrrr commented on pull request #131: URL: https://github.com/apache/flink-statefun/pull/131#issuecomment-680671983 Hi, @carp84 Thank you for the review. I think that "stateful functions" should be translated to chinese to promote communications within people who primarily speak

[GitHub] [flink] flinkbot edited a comment on pull request #13225: [FLINK-18974][docs-zh]Translate the 'User-Defined Functions' page of "Application Development's DataStream API" into Chinese

2020-08-25 Thread GitBox
flinkbot edited a comment on pull request #13225: URL: https://github.com/apache/flink/pull/13225#issuecomment-678953566 ## CI report: * 6bfd27b44774c770a2d28ee9ca1bde0e11bfbe29 Azure:

[jira] [Commented] (FLINK-19025) table sql write orc file but hive2.1.1 can not read

2020-08-25 Thread Rui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184947#comment-17184947 ] Rui Li commented on FLINK-19025: [~McClone] The stacktrace indicates you're writing streaming data.

[jira] [Commented] (FLINK-19025) table sql write orc file but hive2.1.1 can not read

2020-08-25 Thread McClone (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184946#comment-17184946 ] McClone commented on FLINK-19025: - Exception in thread "main" java.lang.NoClassDefFoundError:

[GitHub] [flink] flinkbot edited a comment on pull request #13225: [FLINK-18974][docs-zh]Translate the 'User-Defined Functions' page of "Application Development's DataStream API" into Chinese

2020-08-25 Thread GitBox
flinkbot edited a comment on pull request #13225: URL: https://github.com/apache/flink/pull/13225#issuecomment-678953566 ## CI report: * 40658a82560ebc79ee2047a789db4fa003115099 Azure:

[jira] [Commented] (FLINK-19022) AkkaRpcActor failed to start but no exception information

2020-08-25 Thread tartarus (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184921#comment-17184921 ] tartarus commented on FLINK-19022: -- [~trohrmann] I want to confirm the little details. we pass a 

[GitHub] [flink] flinkbot edited a comment on pull request #13225: [FLINK-18974][docs-zh]Translate the 'User-Defined Functions' page of "Application Development's DataStream API" into Chinese

2020-08-25 Thread GitBox
flinkbot edited a comment on pull request #13225: URL: https://github.com/apache/flink/pull/13225#issuecomment-678953566 ## CI report: * 40658a82560ebc79ee2047a789db4fa003115099 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13244: [FLINK-18333][jdbc] UnsignedTypeConversionITCase failed caused by MariaDB4j "Asked to waitFor Program"

2020-08-25 Thread GitBox
flinkbot edited a comment on pull request #13244: URL: https://github.com/apache/flink/pull/13244#issuecomment-680535784 ## CI report: * f5fee133d28436ab73b03d05b1f6fadc8648f5d0 Azure:

[jira] [Commented] (FLINK-19025) table sql write orc file but hive2.1.1 can not read

2020-08-25 Thread Rui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184918#comment-17184918 ] Rui Li commented on FLINK-19025: Hey [~McClone], are you writing streaming data into hive orc table? If

[GitHub] [flink] zhuxiaoshang commented on pull request #13225: [FLINK-18974][docs-zh]Translate the 'User-Defined Functions' page of "Application Development's DataStream API" into Chinese

2020-08-25 Thread GitBox
zhuxiaoshang commented on pull request #13225: URL: https://github.com/apache/flink/pull/13225#issuecomment-680556966 Thanks for your review @RocMarshal.I have made some changes according to your suggestions. This is an

[GitHub] [flink] zhuxiaoshang commented on a change in pull request #13225: [FLINK-18974][docs-zh]Translate the 'User-Defined Functions' page of "Application Development's DataStream API" into Chinese

2020-08-25 Thread GitBox
zhuxiaoshang commented on a change in pull request #13225: URL: https://github.com/apache/flink/pull/13225#discussion_r477020865 ## File path: docs/dev/user_defined_functions.zh.md ## @@ -147,95 +142,75 @@ data.map (new RichMapFunction[String, Int] { -Rich functions

[GitHub] [flink] flinkbot commented on pull request #13244: [FLINK-18333][jdbc] UnsignedTypeConversionITCase failed caused by MariaDB4j "Asked to waitFor Program"

2020-08-25 Thread GitBox
flinkbot commented on pull request #13244: URL: https://github.com/apache/flink/pull/13244#issuecomment-680535784 ## CI report: * f5fee133d28436ab73b03d05b1f6fadc8648f5d0 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot commented on pull request #13244: [FLINK-18333][jdbc] UnsignedTypeConversionITCase failed caused by MariaDB4j "Asked to waitFor Program"

2020-08-25 Thread GitBox
flinkbot commented on pull request #13244: URL: https://github.com/apache/flink/pull/13244#issuecomment-680526208 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Updated] (FLINK-18333) UnsignedTypeConversionITCase failed caused by MariaDB4j "Asked to waitFor Program"

2020-08-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-18333: --- Labels: pull-request-available test-stability (was: test-stability) >

[GitHub] [flink] leonardBang opened a new pull request #13244: [FLINK-18333][jdbc] UnsignedTypeConversionITCase failed caused by MariaDB4j "Asked to waitFor Program"

2020-08-25 Thread GitBox
leonardBang opened a new pull request #13244: URL: https://github.com/apache/flink/pull/13244 ## What is the purpose of the change * This pull request fix up unstable test UnsignedTypeConversionITCase. ## Brief change log - Avoid using MariaDB4jRule to create a DB

[GitHub] [flink] flinkbot edited a comment on pull request #13243: [FLINK-18992][table] Fix Table API renameColumns method annotation error

2020-08-25 Thread GitBox
flinkbot edited a comment on pull request #13243: URL: https://github.com/apache/flink/pull/13243#issuecomment-680489296 ## CI report: * 7abb7dec5769d7d9569b17de97c477c989f67ed2 Azure:

[GitHub] [flink-benchmarks] zhijiangW commented on a change in pull request #2: [FLINK-19003][checkpointing] Add micro-benchmark for unaligned checkpoints

2020-08-25 Thread GitBox
zhijiangW commented on a change in pull request #2: URL: https://github.com/apache/flink-benchmarks/pull/2#discussion_r477009866 ## File path: src/main/java/org/apache/flink/benchmark/RemoteChannelThroughputBenchmark.java ## @@ -80,6 +84,7 @@ public void

[GitHub] [flink] flinkbot edited a comment on pull request #13186: [FLINK-18720][k8s] Migrate KubernetesResourceManager to the new KubernetesResourceManagerDriver

2020-08-25 Thread GitBox
flinkbot edited a comment on pull request #13186: URL: https://github.com/apache/flink/pull/13186#issuecomment-675299227 ## CI report: * 63c2f658cc309661c434451a5d8c0b38d2e748d3 Azure:

[GitHub] [flink] flinkbot commented on pull request #13243: [FLINK-18992][table] Fix Table API renameColumns method annotation error

2020-08-25 Thread GitBox
flinkbot commented on pull request #13243: URL: https://github.com/apache/flink/pull/13243#issuecomment-680489296 ## CI report: * 7abb7dec5769d7d9569b17de97c477c989f67ed2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink-benchmarks] zhijiangW commented on a change in pull request #2: [FLINK-19003][checkpointing] Add micro-benchmark for unaligned checkpoints

2020-08-25 Thread GitBox
zhijiangW commented on a change in pull request #2: URL: https://github.com/apache/flink-benchmarks/pull/2#discussion_r477008616 ## File path: src/main/java/org/apache/flink/benchmark/RemoteChannelThroughputBenchmark.java ## @@ -48,6 +49,9 @@ private MiniCluster

[GitHub] [flink] flinkbot commented on pull request #13243: [FLINK-18992][table] Fix Table API renameColumns method annotation error

2020-08-25 Thread GitBox
flinkbot commented on pull request #13243: URL: https://github.com/apache/flink/pull/13243#issuecomment-680478070 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Updated] (FLINK-18992) Table API renameColumns method annotation error

2020-08-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-18992: --- Labels: pull-request-available (was: ) > Table API renameColumns method annotation error >

[GitHub] [flink] Fin-chan opened a new pull request #13243: [FLINK-18992][table] Fix Table API renameColumns method annotation error

2020-08-25 Thread GitBox
Fin-chan opened a new pull request #13243: URL: https://github.com/apache/flink/pull/13243 Fix Table API renameColumns method annotation error ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather

[jira] [Commented] (FLINK-19025) table sql write orc file but hive2.1.1 can not read

2020-08-25 Thread McClone (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184887#comment-17184887 ] McClone commented on FLINK-19025: - It really has problems.Flink hive Code use some hive code,but

[GitHub] [flink] flinkbot edited a comment on pull request #13186: [FLINK-18720][k8s] Migrate KubernetesResourceManager to the new KubernetesResourceManagerDriver

2020-08-25 Thread GitBox
flinkbot edited a comment on pull request #13186: URL: https://github.com/apache/flink/pull/13186#issuecomment-675299227 ## CI report: * 63c2f658cc309661c434451a5d8c0b38d2e748d3 Azure:

[jira] [Commented] (FLINK-19025) table sql write orc file but hive2.1.1 can not read

2020-08-25 Thread McClone (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184885#comment-17184885 ] McClone commented on FLINK-19025: - Rui Li , Now i use hive connector  , but flink-hive need

[GitHub] [flink] xintongsong commented on pull request #13186: [FLINK-18720][k8s] Migrate KubernetesResourceManager to the new KubernetesResourceManagerDriver

2020-08-25 Thread GitBox
xintongsong commented on pull request #13186: URL: https://github.com/apache/flink/pull/13186#issuecomment-680452263 Thanks for the review, @tillrohrmann. I replied about the `flinkClientConfig`. The rest of the comments are addressed.

[GitHub] [flink] xintongsong commented on a change in pull request #13186: [FLINK-18720][k8s] Migrate KubernetesResourceManager to the new KubernetesResourceManagerDriver

2020-08-25 Thread GitBox
xintongsong commented on a change in pull request #13186: URL: https://github.com/apache/flink/pull/13186#discussion_r476996403 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesResourceManagerDriver.java ## @@ -0,0 +1,301 @@ +/* + * Licensed

[GitHub] [flink] xintongsong commented on a change in pull request #13186: [FLINK-18720][k8s] Migrate KubernetesResourceManager to the new KubernetesResourceManagerDriver

2020-08-25 Thread GitBox
xintongsong commented on a change in pull request #13186: URL: https://github.com/apache/flink/pull/13186#discussion_r476988674 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesResourceManagerDriver.java ## @@ -0,0 +1,301 @@ +/* + * Licensed

[GitHub] [flink] xintongsong commented on a change in pull request #13186: [FLINK-18720][k8s] Migrate KubernetesResourceManager to the new KubernetesResourceManagerDriver

2020-08-25 Thread GitBox
xintongsong commented on a change in pull request #13186: URL: https://github.com/apache/flink/pull/13186#discussion_r476986171 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/active/AbstractResourceManagerDriver.java ## @@ -0,0 +1,76 @@ +/*

[GitHub] [flink] xintongsong commented on a change in pull request #13186: [FLINK-18720][k8s] Migrate KubernetesResourceManager to the new KubernetesResourceManagerDriver

2020-08-25 Thread GitBox
xintongsong commented on a change in pull request #13186: URL: https://github.com/apache/flink/pull/13186#discussion_r476975877 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesResourceManagerDriver.java ## @@ -0,0 +1,301 @@ +/* + * Licensed

[GitHub] [flink] xintongsong commented on a change in pull request #13186: [FLINK-18720][k8s] Migrate KubernetesResourceManager to the new KubernetesResourceManagerDriver

2020-08-25 Thread GitBox
xintongsong commented on a change in pull request #13186: URL: https://github.com/apache/flink/pull/13186#discussion_r476973166 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesResourceManagerDriver.java ## @@ -0,0 +1,325 @@ +/* + * Licensed

[GitHub] [flink] xintongsong commented on a change in pull request #13186: [FLINK-18720][k8s] Migrate KubernetesResourceManager to the new KubernetesResourceManagerDriver

2020-08-25 Thread GitBox
xintongsong commented on a change in pull request #13186: URL: https://github.com/apache/flink/pull/13186#discussion_r476973166 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesResourceManagerDriver.java ## @@ -0,0 +1,325 @@ +/* + * Licensed

[jira] [Closed] (FLINK-19041) Add dependency management for ConnectedStream in Python DataStream API.

2020-08-25 Thread Hequn Cheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hequn Cheng closed FLINK-19041. --- Resolution: Resolved > Add dependency management for ConnectedStream in Python DataStream API. >

[jira] [Commented] (FLINK-19041) Add dependency management for ConnectedStream in Python DataStream API.

2020-08-25 Thread Hequn Cheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184825#comment-17184825 ] Hequn Cheng commented on FLINK-19041: - Resolved in 1.12.0 via

[GitHub] [flink] hequn8128 merged pull request #13236: [FLINK-19041][python] Add dependency management for ConnectedStream i…

2020-08-25 Thread GitBox
hequn8128 merged pull request #13236: URL: https://github.com/apache/flink/pull/13236 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] hequn8128 commented on pull request #13236: [FLINK-19041][python] Add dependency management for ConnectedStream i…

2020-08-25 Thread GitBox
hequn8128 commented on pull request #13236: URL: https://github.com/apache/flink/pull/13236#issuecomment-680393618 @shuiqiangchen Thanks a lot for fixing the bug. LGTM. This is an automated message from the Apache Git

[GitHub] [flink] zentol commented on a change in pull request #13163: [FLINK-16789][runtime] Support JMX RMI random port assign

2020-08-25 Thread GitBox
zentol commented on a change in pull request #13163: URL: https://github.com/apache/flink/pull/13163#discussion_r476790261 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/management/JMXService.java ## @@ -85,6 +86,9 @@ private static JMXServer

[GitHub] [flink] zentol commented on a change in pull request #13163: [FLINK-16789][runtime] Support JMX RMI random port assign

2020-08-25 Thread GitBox
zentol commented on a change in pull request #13163: URL: https://github.com/apache/flink/pull/13163#discussion_r476645574 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/management/JMXService.java ## @@ -85,6 +86,9 @@ private static JMXServer

[GitHub] [flink] walterddr commented on a change in pull request #13163: [FLINK-16789][runtime] Support JMX RMI random port assign

2020-08-25 Thread GitBox
walterddr commented on a change in pull request #13163: URL: https://github.com/apache/flink/pull/13163#discussion_r476778503 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/management/JMXService.java ## @@ -85,6 +86,9 @@ private static JMXServer

[jira] [Comment Edited] (FLINK-18192) Upgrade to Avro version 1.9.2 from 1.8.2

2020-08-25 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183877#comment-17183877 ] Chesnay Schepler edited comment on FLINK-18192 at 8/25/20, 9:31 PM:

[jira] [Commented] (FLINK-18546) Upgrade to Kafka Schema Registry Client 5.5.0

2020-08-25 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184742#comment-17184742 ] Chesnay Schepler commented on FLINK-18546: -- How would this work in terms of backwards

[GitHub] [flink] flinkbot edited a comment on pull request #13242: [FLINK-19009][metrics] Fixed the downtime metric issue and updated the comment

2020-08-25 Thread GitBox
flinkbot edited a comment on pull request #13242: URL: https://github.com/apache/flink/pull/13242#issuecomment-680108384 ## CI report: * fc6dc041ef06000c57767f9665c34ecc70cff6da Azure:

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

2020-08-25 Thread GitBox
AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r476683415 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java ## @@ -92,306 +90,173 @@

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

2020-08-25 Thread GitBox
AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r476678903 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamTaskNetworkInput.java ## @@ -159,10 +158,12 @@ public

[GitHub] [flink] morsapaes commented on a change in pull request #13203: [FLINK-18984][python][docs] Add tutorial documentation for Python DataStream API

2020-08-25 Thread GitBox
morsapaes commented on a change in pull request #13203: URL: https://github.com/apache/flink/pull/13203#discussion_r476650361 ## File path: docs/dev/python/getting-started/tutorial/datastream_tutorial.md ## @@ -0,0 +1,126 @@ +--- +title: "Python DataStream API Tutorial"

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

2020-08-25 Thread GitBox
AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r476677925 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointedInputGate.java ## @@ -74,34 +106,34 @@ public

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

2020-08-25 Thread GitBox
AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r476674004 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointedInputGate.java ## @@ -74,34 +106,34 @@ public

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

2020-08-25 Thread GitBox
AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r476675096 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointedInputGate.java ## @@ -63,9 +66,38 @@ */

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

2020-08-25 Thread GitBox
AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r476674004 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointedInputGate.java ## @@ -74,34 +106,34 @@ public

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

2020-08-25 Thread GitBox
AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r476673355 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointedInputGate.java ## @@ -63,9 +66,38 @@ */

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

2020-08-25 Thread GitBox
AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r476665640 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java ## @@ -195,28 +193,27 @@ void

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

2020-08-25 Thread GitBox
AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r476662192 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java ## @@ -770,34 +808,50 @@ void

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

2020-08-25 Thread GitBox
AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r476660758 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedSequenceNumberingViewReader.java ## @@ -133,14 +136,14 @@

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

2020-08-25 Thread GitBox
AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r476660921 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java ## @@ -621,61 +626,84 @@ public

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

2020-08-25 Thread GitBox
AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r476659669 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java ## @@ -171,19 +175,42 @@ private void

[GitHub] [flink] AHeise commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

2020-08-25 Thread GitBox
AHeise commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r476657231 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java ## @@ -171,19 +175,42 @@ private void

[GitHub] [flink] zentol commented on a change in pull request #13163: [FLINK-16789][runtime] Support JMX RMI random port assign

2020-08-25 Thread GitBox
zentol commented on a change in pull request #13163: URL: https://github.com/apache/flink/pull/13163#discussion_r476645574 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/management/JMXService.java ## @@ -85,6 +86,9 @@ private static JMXServer

[GitHub] [flink] flinkbot edited a comment on pull request #13239: [FLINK-19021][network] Various cleanups and refactorings of the ResultPartition

2020-08-25 Thread GitBox
flinkbot edited a comment on pull request #13239: URL: https://github.com/apache/flink/pull/13239#issuecomment-679946229 ## CI report: * fbf7c39bb2d6cb79f52a93efabe310cb2bafdee9 Azure:

[GitHub] [flink-training] alpinegizmo merged pull request #13: [FLINK-18630] Redo the LongRideAlerts solutions to cover a corner case

2020-08-25 Thread GitBox
alpinegizmo merged pull request #13: URL: https://github.com/apache/flink-training/pull/13 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink] flinkbot edited a comment on pull request #13240: [FLINK-19050][Documentation]

2020-08-25 Thread GitBox
flinkbot edited a comment on pull request #13240: URL: https://github.com/apache/flink/pull/13240#issuecomment-680007217 ## CI report: * 11e18bf9587cfcc3a948ead892c826114a03bb4c Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13236: [FLINK-19041][python] Add dependency management for ConnectedStream i…

2020-08-25 Thread GitBox
flinkbot edited a comment on pull request #13236: URL: https://github.com/apache/flink/pull/13236#issuecomment-679860054 ## CI report: * 5ed0da03dffc085997903aa6868e97ea98340433 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13241: [hotfix] Fix a typo in the watermark docs

2020-08-25 Thread GitBox
flinkbot edited a comment on pull request #13241: URL: https://github.com/apache/flink/pull/13241#issuecomment-680066941 ## CI report: * b8271b12c25e16aab38b9beb58d0f29835bee01a Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13034: [FLINK-9992][tests] Fix FsStorageLocationReferenceTest#testEncodeAndDecode by adding retries to generate a valid path

2020-08-25 Thread GitBox
flinkbot edited a comment on pull request #13034: URL: https://github.com/apache/flink/pull/13034#issuecomment-666932731 ## CI report: * db2c909c2b516c253c5f4f2afc1a0d200df72d85 Azure:

[GitHub] [flink] pnowojski commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

2020-08-25 Thread GitBox
pnowojski commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r476481681 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedSequenceNumberingViewReader.java ## @@ -133,14 +136,14

[GitHub] [flink] pnowojski commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

2020-08-25 Thread GitBox
pnowojski commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r476498494 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java ## @@ -621,61 +626,84 @@ public

[GitHub] [flink] pnowojski commented on a change in pull request #13228: [FLINK-19026][network] Improve threading model of CheckpointBarrierUnaligner

2020-08-25 Thread GitBox
pnowojski commented on a change in pull request #13228: URL: https://github.com/apache/flink/pull/13228#discussion_r476480862 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedSequenceNumberingViewReader.java ## @@ -133,14 +136,14

[GitHub] [flink] flinkbot edited a comment on pull request #13242: [FLINK-19009][metrics] Fixed the downtime metric issue and updated the comment

2020-08-25 Thread GitBox
flinkbot edited a comment on pull request #13242: URL: https://github.com/apache/flink/pull/13242#issuecomment-680108384 ## CI report: * fc6dc041ef06000c57767f9665c34ecc70cff6da Azure:

[jira] [Updated] (FLINK-19005) used metaspace grow on every execution

2020-08-25 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-19005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillermo Sánchez updated FLINK-19005: -- Attachment: (was: 0_executions.zip) > used metaspace grow on every execution >

[jira] [Updated] (FLINK-19005) used metaspace grow on every execution

2020-08-25 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-19005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillermo Sánchez updated FLINK-19005: -- Attachment: (was: WordCount_1_execution.zip) > used metaspace grow on every

[jira] [Updated] (FLINK-19005) used metaspace grow on every execution

2020-08-25 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-19005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillermo Sánchez updated FLINK-19005: -- Attachment: (was: WordCount_15_executions.zip) > used metaspace grow on every

[GitHub] [flink] flinkbot commented on pull request #13242: [FLINK-19009][metrics] Fixed the downtime metric issue and updated the comment

2020-08-25 Thread GitBox
flinkbot commented on pull request #13242: URL: https://github.com/apache/flink/pull/13242#issuecomment-680108384 ## CI report: * fc6dc041ef06000c57767f9665c34ecc70cff6da UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[jira] [Assigned] (FLINK-19013) Log start/end of state restoration

2020-08-25 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-19013: Assignee: Matt Wang > Log start/end of state restoration >

[GitHub] [flink] flinkbot commented on pull request #13242: [FLINK-19009][metrics] Fixed the downtime metric issue and updated the comment

2020-08-25 Thread GitBox
flinkbot commented on pull request #13242: URL: https://github.com/apache/flink/pull/13242#issuecomment-680105014 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] aljoscha closed pull request #13237: [FLINK-17159] Harden ElasticsearchSinkITCase

2020-08-25 Thread GitBox
aljoscha closed pull request #13237: URL: https://github.com/apache/flink/pull/13237 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] aljoscha commented on pull request #13237: [FLINK-17159] Harden ElasticsearchSinkITCase

2020-08-25 Thread GitBox
aljoscha commented on pull request #13237: URL: https://github.com/apache/flink/pull/13237#issuecomment-680103938 Merged! Thanks for the speedy review! (And for the (external) suggestion to use the liveness probe) This is

[jira] [Updated] (FLINK-19009) wrong way to calculate the "downtime" metric

2020-08-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-19009: --- Labels: pull-request-available (was: ) > wrong way to calculate the "downtime" metric >

[GitHub] [flink] Flyangz opened a new pull request #13242: [FLINK-19009][metrics] Fixed the downtime metric issue and updated the comment

2020-08-25 Thread GitBox
Flyangz opened a new pull request #13242: URL: https://github.com/apache/flink/pull/13242 ## What is the purpose of the change Currently the way to calculate the Flink system metric "downtime" is not consistent with the description in the doc, now the downtime is actually

[jira] [Closed] (FLINK-17159) ES6 ElasticsearchSinkITCase unstable

2020-08-25 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-17159. Fix Version/s: 1.11.2 1.12.0 Resolution: Fixed Fix on

[GitHub] [flink] flinkbot edited a comment on pull request #13217: [FLINK-16866] Make job submission non-blocking

2020-08-25 Thread GitBox
flinkbot edited a comment on pull request #13217: URL: https://github.com/apache/flink/pull/13217#issuecomment-678285884 ## CI report: * 3655fcea1966bfbcb85c86d6a159c354f20d6cc7 UNKNOWN * 52a49f0b0840aa9220de72d64c50a6b33f6adf92 Azure:

[jira] [Commented] (FLINK-17159) ES6 ElasticsearchSinkITCase unstable

2020-08-25 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184125#comment-17184125 ] Aljoscha Krettek commented on FLINK-17159: -- Potential fix on master:

[GitHub] [flink] RocMarshal commented on a change in pull request #13225: [FLINK-18974][docs-zh]Translate the 'User-Defined Functions' page of "Application Development's DataStream API" into Chinese

2020-08-25 Thread GitBox
RocMarshal commented on a change in pull request #13225: URL: https://github.com/apache/flink/pull/13225#discussion_r476500930 ## File path: docs/dev/user_defined_functions.zh.md ## @@ -23,16 +23,14 @@ specific language governing permissions and limitations under the License.

[GitHub] [flink] flinkbot edited a comment on pull request #13241: [hotfix] Fix a typo in the watermark docs

2020-08-25 Thread GitBox
flinkbot edited a comment on pull request #13241: URL: https://github.com/apache/flink/pull/13241#issuecomment-680066941 ## CI report: * b8271b12c25e16aab38b9beb58d0f29835bee01a Azure:

[GitHub] [flink] rmetzger commented on pull request #13217: [FLINK-16866] Make job submission non-blocking

2020-08-25 Thread GitBox
rmetzger commented on pull request #13217: URL: https://github.com/apache/flink/pull/13217#issuecomment-680075151 Thanks a lot for your extensive and detailed review. It was very helpful for me! I have addressed most of you your comments. I extended the `DispatcherJobTest`. I'm

[jira] [Commented] (FLINK-18695) Allow NettyBufferPool to allocate heap buffers

2020-08-25 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184102#comment-17184102 ] Chesnay Schepler commented on FLINK-18695: -- Given that we will allocate a heap memory anyway

[jira] [Updated] (FLINK-19005) used metaspace grow on every execution

2020-08-25 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-19005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillermo Sánchez updated FLINK-19005: -- Attachment: 0_executions.zip WordCount_1_execution.zip

[jira] [Commented] (FLINK-19013) Log start/end of state restoration

2020-08-25 Thread Matt Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184098#comment-17184098 ] Matt Wang commented on FLINK-19013: --- Agree it, it would be useful while debugging.  hi, [~chesnay] 

[GitHub] [flink] tillrohrmann commented on a change in pull request #13186: [FLINK-18720][k8s] Migrate KubernetesResourceManager to the new KubernetesResourceManagerDriver

2020-08-25 Thread GitBox
tillrohrmann commented on a change in pull request #13186: URL: https://github.com/apache/flink/pull/13186#discussion_r476473271 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesResourceManagerDriver.java ## @@ -0,0 +1,301 @@ +/* + * Licensed

[GitHub] [flink] flinkbot commented on pull request #13241: [hotfix] Fix a typo in the watermark docs

2020-08-25 Thread GitBox
flinkbot commented on pull request #13241: URL: https://github.com/apache/flink/pull/13241#issuecomment-680066941 ## CI report: * b8271b12c25e16aab38b9beb58d0f29835bee01a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #13217: [FLINK-16866] Make job submission non-blocking

2020-08-25 Thread GitBox
flinkbot edited a comment on pull request #13217: URL: https://github.com/apache/flink/pull/13217#issuecomment-678285884 ## CI report: * 3655fcea1966bfbcb85c86d6a159c354f20d6cc7 UNKNOWN * 52a49f0b0840aa9220de72d64c50a6b33f6adf92 Azure:

[GitHub] [flink] flinkbot commented on pull request #13241: [hotfix] Fix a typo in the watermark docs

2020-08-25 Thread GitBox
flinkbot commented on pull request #13241: URL: https://github.com/apache/flink/pull/13241#issuecomment-680063288 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] afedulov opened a new pull request #13241: [hotfix] Fix a typo in the watermark docs

2020-08-25 Thread GitBox
afedulov opened a new pull request #13241: URL: https://github.com/apache/flink/pull/13241 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Updated] (FLINK-19043) Translate the 'Logging' page of 'Debugging & Monitoring' into Chinese

2020-08-25 Thread Roc Marshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roc Marshal updated FLINK-19043: Summary: Translate the 'Logging' page of 'Debugging & Monitoring' into Chinese (was: Translate

[GitHub] [flink] flinkbot edited a comment on pull request #13238: [FLINK-19042][hive] Remove print table sink from HiveTableSourceITCas…

2020-08-25 Thread GitBox
flinkbot edited a comment on pull request #13238: URL: https://github.com/apache/flink/pull/13238#issuecomment-679946137 ## CI report: * e85e2428cac727ca774025ca106d2cb0c319e78e Azure:

[jira] [Commented] (FLINK-18695) Allow NettyBufferPool to allocate heap buffers

2020-08-25 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184089#comment-17184089 ] Yun Gao commented on FLINK-18695: - Hi [~chesnay] I also agree with you that there are both cases in the

[GitHub] [flink] flinkbot edited a comment on pull request #13239: [FLINK-19021][network] Various cleanups and refactorings of the ResultPartition

2020-08-25 Thread GitBox
flinkbot edited a comment on pull request #13239: URL: https://github.com/apache/flink/pull/13239#issuecomment-679946229 ## CI report: * af13efd2abeedd3f3d3a7db9e28d6a32456f8e52 Azure:

[jira] [Updated] (FLINK-19041) Add dependency management for ConnectedStream in Python DataStream API.

2020-08-25 Thread Hequn Cheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hequn Cheng updated FLINK-19041: Affects Version/s: 1.12.0 > Add dependency management for ConnectedStream in Python DataStream

[jira] [Commented] (FLINK-18695) Allow NettyBufferPool to allocate heap buffers

2020-08-25 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184076#comment-17184076 ] Chesnay Schepler commented on FLINK-18695: -- [~gaoyunhaii] there are certainly cases where

  1   2   3   >