KurtYoung commented on a change in pull request #15564:
URL: https://github.com/apache/flink/pull/15564#discussion_r612150467
##
File path:
flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/catalog/hive/HiveCatalogTest.java
##
@@ -78,4 +80,17 @@
[
https://issues.apache.org/jira/browse/FLINK-21748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kurt Young closed FLINK-21748.
--
Resolution: Fixed
fixed: b78ce3b9713c7b2792629d509a3951a96829012d
>
KurtYoung merged pull request #15563:
URL: https://github.com/apache/flink/pull/15563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
[
https://issues.apache.org/jira/browse/FLINK-21879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guowei Ma reopened FLINK-21879:
---
[
https://issues.apache.org/jira/browse/FLINK-21879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guowei Ma updated FLINK-21879:
--
Comment: was deleted
(was: another case
[
https://issues.apache.org/jira/browse/FLINK-22166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jingsong Lee closed FLINK-22166.
Resolution: Fixed
master (1.13): 0e82a998afbb1d4be4fbf1a48c2a232ccc53fb9c
> Empty values with
[
https://issues.apache.org/jira/browse/FLINK-22190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319910#comment-17319910
]
Arvid Heise commented on FLINK-22190:
-
1. You get byZeroException because you are dividing by 0 in
JingsongLi merged pull request #15571:
URL: https://github.com/apache/flink/pull/15571
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
[
https://issues.apache.org/jira/browse/FLINK-21879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319909#comment-17319909
]
Guowei Ma commented on FLINK-21879:
---
another case
chaozwn commented on pull request #15582:
URL: https://github.com/apache/flink/pull/15582#issuecomment-818457368
> What's the problem if we don't add it?
There are two descriptions on the original file that have been added to the
ParserResource.properties, and the calcite official
[
https://issues.apache.org/jira/browse/FLINK-22100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319906#comment-17319906
]
Guowei Ma commented on FLINK-22100:
---
[
https://issues.apache.org/jira/browse/FLINK-20747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319905#comment-17319905
]
Jingsong Lee commented on FLINK-20747:
--
I think this is caused by FLINK-13191, and is resolved by
[
https://issues.apache.org/jira/browse/FLINK-20747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jingsong Lee closed FLINK-20747.
Resolution: Duplicate
> ClassCastException when using MAX aggregate function
>
flinkbot edited a comment on pull request #15582:
URL: https://github.com/apache/flink/pull/15582#issuecomment-818444729
## CI report:
* a1730e1eca63cb5ae0ef0468a5ff76c9efdb5ccc Azure:
[
https://issues.apache.org/jira/browse/FLINK-21025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319904#comment-17319904
]
Guowei Ma commented on FLINK-21025:
---
flinkbot edited a comment on pull request #15564:
URL: https://github.com/apache/flink/pull/15564#issuecomment-817625124
## CI report:
* cd5ab564ce3aa46edd059bf1113f5053debc7418 Azure:
[
https://issues.apache.org/jira/browse/FLINK-21025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guowei Ma updated FLINK-21025:
--
Affects Version/s: 1.12.2
> SQLClientHBaseITCase fails when untarring HBase
>
leonardBang commented on pull request #15578:
URL: https://github.com/apache/flink/pull/15578#issuecomment-818454928
cc @wuchong could you help review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
wuchong commented on pull request #15582:
URL: https://github.com/apache/flink/pull/15582#issuecomment-818453831
What's the problem if we don't add it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/FLINK-22141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319900#comment-17319900
]
Yuan Mei commented on FLINK-22141:
--
TODO List:
1. Document limitation for support mysql xa
flinkbot commented on pull request #15582:
URL: https://github.com/apache/flink/pull/15582#issuecomment-818444729
## CI report:
* a1730e1eca63cb5ae0ef0468a5ff76c9efdb5ccc UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot
flinkbot commented on pull request #15582:
URL: https://github.com/apache/flink/pull/15582#issuecomment-818439853
Thanks a lot for your contribution to the Apache Flink project. I'm the
@flinkbot. I help the community
to review your pull request. We will use this comment to track the
[
https://issues.apache.org/jira/browse/FLINK-22250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-22250:
---
Labels: pull-request-available (was: )
> flink-sql-parser model Class ParserResource lack
chaozwn opened a new pull request #15582:
URL: https://github.com/apache/flink/pull/15582
…createSystemFunctionOnlySupportTemporary describe message.
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob
flinkbot edited a comment on pull request #15581:
URL: https://github.com/apache/flink/pull/15581#issuecomment-818431544
## CI report:
* 7e80f21e80bb9d5663d31cb19cd2811cb19037ec Azure:
flinkbot edited a comment on pull request #15564:
URL: https://github.com/apache/flink/pull/15564#issuecomment-817625124
## CI report:
* ad833779d272f0f35cb82b26f559131e2192cfee Azure:
WeiNan Zhao created FLINK-22250:
---
Summary: flink-sql-parser model Class ParserResource lack
ParserResource.properties
Key: FLINK-22250
URL: https://issues.apache.org/jira/browse/FLINK-22250
Project:
leonardBang commented on a change in pull request #15495:
URL: https://github.com/apache/flink/pull/15495#discussion_r612122508
##
File path:
godfreyhe commented on pull request #15307:
URL: https://github.com/apache/flink/pull/15307#issuecomment-818431839
@YuvalItzchakov , you can create a new pr to cherry pick this pr to 1.12
once this one is merged.
--
This is an automated message from the Apache Git Service.
To respond to
flinkbot commented on pull request #15581:
URL: https://github.com/apache/flink/pull/15581#issuecomment-818431544
## CI report:
* 7e80f21e80bb9d5663d31cb19cd2811cb19037ec UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot
flinkbot edited a comment on pull request #15564:
URL: https://github.com/apache/flink/pull/15564#issuecomment-817625124
## CI report:
* ad833779d272f0f35cb82b26f559131e2192cfee Azure:
Guowei Ma created FLINK-22249:
-
Summary: JobMasterStopWithSavepointITCase failed due to status is
FAILING
Key: FLINK-22249
URL: https://issues.apache.org/jira/browse/FLINK-22249
Project: Flink
[
https://issues.apache.org/jira/browse/FLINK-22100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319884#comment-17319884
]
Guowei Ma commented on FLINK-22100:
---
[
https://issues.apache.org/jira/browse/FLINK-22248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319883#comment-17319883
]
Guowei Ma commented on FLINK-22248:
---
[
https://issues.apache.org/jira/browse/FLINK-22100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319881#comment-17319881
]
Guowei Ma commented on FLINK-22100:
---
[
https://issues.apache.org/jira/browse/FLINK-22248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319880#comment-17319880
]
Guowei Ma commented on FLINK-22248:
---
YuvalItzchakov commented on pull request #15307:
URL: https://github.com/apache/flink/pull/15307#issuecomment-818426492
@godfreyhe It maybe better for me as well as my source is currently built on
top of 1.12 and still not entirely sure what changes go into 1.13.
--
This is an automated
[
https://issues.apache.org/jira/browse/FLINK-22245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jark Wu reassigned FLINK-22245:
---
Assignee: Shengkai Fang
> Reuse PrintUtils.MAX_COLUMN_WIDTH in CliChangelogResultView and
>
[
https://issues.apache.org/jira/browse/FLINK-22248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319879#comment-17319879
]
Guowei Ma commented on FLINK-22248:
---
[
https://issues.apache.org/jira/browse/FLINK-22248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guowei Ma updated FLINK-22248:
--
Priority: Critical (was: Major)
>
Guowei Ma created FLINK-22248:
-
Summary:
JobMasterStopWithSavepointITCase.suspendWithSavepointWithoutComplicationsShouldSucceedAndLeadJobToFinished
fail because of TestTimedOutException
Key: FLINK-22248
URL:
[
https://issues.apache.org/jira/browse/FLINK-21995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319877#comment-17319877
]
Guowei Ma commented on FLINK-21995:
---
[
https://issues.apache.org/jira/browse/FLINK-21995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guowei Ma updated FLINK-21995:
--
Affects Version/s: 1.11.3
>
godfreyhe commented on pull request #15307:
URL: https://github.com/apache/flink/pull/15307#issuecomment-818423595
AFAK, very few connectors implement filter push down. If any one needs this
fix in 1.12, we can cherry pick it to 1.12.
--
This is an automated message from the Apache Git
Spongebob created FLINK-22247:
-
Summary: can not pass AddressList when connecting to rabbitmq
Key: FLINK-22247
URL: https://issues.apache.org/jira/browse/FLINK-22247
Project: Flink
Issue Type:
[
https://issues.apache.org/jira/browse/FLINK-17510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319875#comment-17319875
]
Guowei Ma edited comment on FLINK-17510 at 4/13/21, 4:12 AM:
-
[
https://issues.apache.org/jira/browse/FLINK-17510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319875#comment-17319875
]
Guowei Ma commented on FLINK-17510:
---
[
https://issues.apache.org/jira/browse/FLINK-17510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319872#comment-17319872
]
Guowei Ma commented on FLINK-17510:
---
flinkbot commented on pull request #15581:
URL: https://github.com/apache/flink/pull/15581#issuecomment-818414998
Thanks a lot for your contribution to the Apache Flink project. I'm the
@flinkbot. I help the community
to review your pull request. We will use this comment to track the
flinkbot edited a comment on pull request #15580:
URL: https://github.com/apache/flink/pull/15580#issuecomment-818409161
## CI report:
* a5613bd98763175b59d5d2a3ecbf8a1cb047299a Azure:
flinkbot edited a comment on pull request #15568:
URL: https://github.com/apache/flink/pull/15568#issuecomment-817675780
## CI report:
* 0fadc09a8fa301dc7a46c5893d16390f76379853 Azure:
flinkbot edited a comment on pull request #15564:
URL: https://github.com/apache/flink/pull/15564#issuecomment-817625124
## CI report:
* a793f435a93300e271013c875f098f30568c9b19 Azure:
RocMarshal opened a new pull request #15581:
URL: https://github.com/apache/flink/pull/15581
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob
server, rather than through RPC. That way we avoid re-transferring
YuvalItzchakov commented on pull request #15307:
URL: https://github.com/apache/flink/pull/15307#issuecomment-818413801
@godfreyhe I just want to make sure since this is a critical fix on my end.
I can also backport to 1.12 if it helps.
--
This is an automated message from the Apache
godfreyhe commented on pull request #15307:
URL: https://github.com/apache/flink/pull/15307#issuecomment-818413113
@YuvalItzchakov master (1.13 now) is enough, do do you think ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/FLINK-22121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
godfrey he closed FLINK-22121.
--
Resolution: Fixed
Fixed in 1.13.0: a2c429d9a626d5f4ea47aa58a3e9f2da7ce1f47e
>
godfreyhe closed pull request #15498:
URL: https://github.com/apache/flink/pull/15498
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
flinkbot commented on pull request #15580:
URL: https://github.com/apache/flink/pull/15580#issuecomment-818409161
## CI report:
* a5613bd98763175b59d5d2a3ecbf8a1cb047299a UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot
flinkbot edited a comment on pull request #15568:
URL: https://github.com/apache/flink/pull/15568#issuecomment-817675780
## CI report:
* 0fadc09a8fa301dc7a46c5893d16390f76379853 Azure:
[
https://issues.apache.org/jira/browse/FLINK-22152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Huang Xingbo resolved FLINK-22152.
--
Resolution: Fixed
Merged into master via 2d2a6876681b34e46fd7c090a3c98272626828ba
> Fix the
HuangXingBo closed pull request #15575:
URL: https://github.com/apache/flink/pull/15575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
hameizi commented on pull request #15564:
URL: https://github.com/apache/flink/pull/15564#issuecomment-818406172
@KurtYoung I add test case in new commit. Please review. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
xiangtao created FLINK-22246:
Summary: when use HiveCatalog create table , can't set Table
owner property correctly
Key: FLINK-22246
URL: https://issues.apache.org/jira/browse/FLINK-22246
Project: Flink
[
https://issues.apache.org/jira/browse/FLINK-22157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
godfrey he closed FLINK-22157.
--
Resolution: Fixed
Fixed in 1.13.0: 92fbe7f1fe5f0eade036b4184cdbab8f9b791647
> Join & Select a part
YuvalItzchakov commented on pull request #15307:
URL: https://github.com/apache/flink/pull/15307#issuecomment-818405285
@godfreyhe Thanks! Will master be used to cut out the 1.13 release or do we
need to backport this to any other branch?
--
This is an automated message from the Apache
godfreyhe closed pull request #15540:
URL: https://github.com/apache/flink/pull/15540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
yittg commented on pull request #15501:
URL: https://github.com/apache/flink/pull/15501#issuecomment-818403355
Hi @wangyang0918 @tillrohrmann ,
So what do you think in summary?
* using shared indexed informer or not?
* provide a new interface to replace the old one?
--
godfreyhe commented on pull request #15307:
URL: https://github.com/apache/flink/pull/15307#issuecomment-818400010
@YuvalItzchakov Thanks for the quick update, I will do a minor improvement
in my local: extract a base test class for
PushFilterInCalcIntoTableSourceRuleTest,
flinkbot commented on pull request #15580:
URL: https://github.com/apache/flink/pull/15580#issuecomment-818399248
Thanks a lot for your contribution to the Apache Flink project. I'm the
@flinkbot. I help the community
to review your pull request. We will use this comment to track the
[
https://issues.apache.org/jira/browse/FLINK-22082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319842#comment-17319842
]
godfrey he commented on FLINK-22082:
Fixed in 1.13.0: 2bbb1ba4072b9f03f9d3f9a17e004b5fe1eb4aa9
>
[
https://issues.apache.org/jira/browse/FLINK-22245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-22245:
---
Labels: pull-request-available (was: )
> Reuse PrintUtils.MAX_COLUMN_WIDTH in
fsk119 opened a new pull request #15580:
URL: https://github.com/apache/flink/pull/15580
After fix, it looks like
https://user-images.githubusercontent.com/33114724/114491165-b731ba80-9c48-11eb-9077-e74f65b71462.png;>
--
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/FLINK-22245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shengkai Fang updated FLINK-22245:
--
Description:
The max column width in CliChangelogResultView and CliTableResultView is 25.
In
[
https://issues.apache.org/jira/browse/FLINK-22245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shengkai Fang updated FLINK-22245:
--
Attachment: sql-client.png
> Reuse PrintUtils.MAX_COLUMN_WIDTH in CliChangelogResultView and
[
https://issues.apache.org/jira/browse/FLINK-22245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shengkai Fang updated FLINK-22245:
--
Description:
The max column width in CliChangelogResultView and CliTableResultView is 25.
In
HuangXingBo commented on pull request #15575:
URL: https://github.com/apache/flink/pull/15575#issuecomment-818396906
The failed test has been recorded in
https://issues.apache.org/jira/browse/FLINK-20723 which is irrelevant to this
PR.
--
This is an automated message from the Apache
Shengkai Fang created FLINK-22245:
-
Summary: Reuse PrintUtils.MAX_COLUMN_WIDTH in
CliChangelogResultView and CliTableResultView
Key: FLINK-22245
URL: https://issues.apache.org/jira/browse/FLINK-22245
[
https://issues.apache.org/jira/browse/FLINK-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319840#comment-17319840
]
Huang Xingbo commented on FLINK-20723:
--
[
https://issues.apache.org/jira/browse/FLINK-22239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yuan Mei updated FLINK-22239:
-
Description:
JdbcXaSinkFunction uses Xa protocol/interface to implement exactly-once
guarantee (within
[
https://issues.apache.org/jira/browse/FLINK-22239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yuan Mei updated FLINK-22239:
-
Description:
JdbcXaSinkFunction uses Xa protocol/interface to implement exactly-once
guarantee (within
[
https://issues.apache.org/jira/browse/FLINK-21903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319832#comment-17319832
]
zhaoxing commented on FLINK-21903:
--
[~liguangyu] sorry,I have submitted a PR,cc [~jark] could you help
[
https://issues.apache.org/jira/browse/FLINK-21464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319831#comment-17319831
]
Shengkai Fang commented on FLINK-21464:
---
[~xiangtao] Thanks for your contribution. Will take a
[
https://issues.apache.org/jira/browse/FLINK-17948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shengkai Fang closed FLINK-17948.
-
Resolution: Fixed
> Use new type system for SQL Client collect sink
>
[
https://issues.apache.org/jira/browse/FLINK-17948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319821#comment-17319821
]
Shengkai Fang commented on FLINK-17948:
---
!image-2021-04-13-10-26-34-721.png!
solved
> Use new
[
https://issues.apache.org/jira/browse/FLINK-17948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shengkai Fang updated FLINK-17948:
--
Attachment: image-2021-04-13-10-26-34-721.png
> Use new type system for SQL Client collect
flinkbot edited a comment on pull request #15548:
URL: https://github.com/apache/flink/pull/15548#issuecomment-816538966
## CI report:
* 64160f09da52e0b873d1fbf1482bb7b6d7c7499e Azure:
[
https://issues.apache.org/jira/browse/FLINK-22134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319811#comment-17319811
]
Xintong Song commented on FLINK-22134:
--
Thanks for the quick response, [~rmetzger].
{quote}B1: This
[
https://issues.apache.org/jira/browse/FLINK-22134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xintong Song updated FLINK-22134:
-
Attachment: flink-xtsong-standalonejob-1-xtsong-mac.log
> Test the reactive mode
>
JingsongLi commented on a change in pull request #15568:
URL: https://github.com/apache/flink/pull/15568#discussion_r612078803
##
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/DecimalCastTest.scala
##
@@ -0,0 +1,203
[
https://issues.apache.org/jira/browse/FLINK-15509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shengkai Fang closed FLINK-15509.
-
Resolution: Not A Problem
> Use sql cilents create view occur Unexpected exception
>
[
https://issues.apache.org/jira/browse/FLINK-22181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319806#comment-17319806
]
Leonard Xu commented on FLINK-22181:
flinkbot edited a comment on pull request #15548:
URL: https://github.com/apache/flink/pull/15548#issuecomment-816538966
## CI report:
* 64160f09da52e0b873d1fbf1482bb7b6d7c7499e Azure:
fsk119 commented on pull request #15548:
URL: https://github.com/apache/flink/pull/15548#issuecomment-818373770
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
godfreyhe closed pull request #15493:
URL: https://github.com/apache/flink/pull/15493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
[
https://issues.apache.org/jira/browse/FLINK-22131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Huang Xingbo resolved FLINK-22131.
--
Resolution: Fixed
Merged into master via ba5cc583e1a086d6fc6e944ee90ec4aa1f4c2405
> Fix the
HuangXingBo closed pull request #15502:
URL: https://github.com/apache/flink/pull/15502
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
fsk119 edited a comment on pull request #15563:
URL: https://github.com/apache/flink/pull/15563#issuecomment-818371872
To reproduce this bug, I think we can add these codes in the
`CollectResultBase` constructor
```
try {
Thread.sleep(1000);
}
fsk119 commented on pull request #15563:
URL: https://github.com/apache/flink/pull/15563#issuecomment-818371872
To reproduce this bug, I think we can add these codes in the
`CollectResultBase` constructor
```
try {
Thread.sleep(1000);
} catch
KurtYoung removed a comment on pull request #15563:
URL: https://github.com/apache/flink/pull/15563#issuecomment-818368661
Could you explain a little bit why moving the thread.start() into child
class?
--
This is an automated message from the Apache Git Service.
To respond to the
KurtYoung commented on pull request #15564:
URL: https://github.com/apache/flink/pull/15564#issuecomment-818369438
@hameizi I'm pretty sure you fixed the bug and the change also LGTM. But by
adding a test case can help the project won't introduce the same bug by
accident in the future.
1 - 100 of 720 matches
Mail list logo