[jira] [Commented] (FLINK-23935) Flink docs: the browser will unexpectedly scroll after clicking the tabs

2021-10-24 Thread Yao Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17433570#comment-17433570 ] Yao Zhang commented on FLINK-23935: --- Could anyone help review this commit please? > Flink docs: the

[jira] [Commented] (FLINK-24597) RocksdbStateBackend getKeysAndNamespaces would return duplicate data when using MapState

2021-10-24 Thread Yue Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17433569#comment-17433569 ] Yue Ma commented on FLINK-24597: [~roman] could you please help to take a look at this issue  , thx ? 

[GitHub] [flink] flinkbot edited a comment on pull request #17554: [FLINK-24624][Kubernetes]Kill cluster when starting kubernetes session or application cluster failed

2021-10-24 Thread GitBox
flinkbot edited a comment on pull request #17554: URL: https://github.com/apache/flink/pull/17554#issuecomment-950550174 ## CI report: * 77e1b9059149c986fc2e35516ce33e3309b61cad Azure:

[GitHub] [flink] flinkbot commented on pull request #17554: [FLINK-24624][Kubernetes]Kill cluster when starting kubernetes session or application cluster failed

2021-10-24 Thread GitBox
flinkbot commented on pull request #17554: URL: https://github.com/apache/flink/pull/17554#issuecomment-950550557 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] flinkbot commented on pull request #17554: [FLINK-24624][Kubernetes]Kill cluster when starting kubernetes session or application cluster failed

2021-10-24 Thread GitBox
flinkbot commented on pull request #17554: URL: https://github.com/apache/flink/pull/17554#issuecomment-950550174 ## CI report: * 77e1b9059149c986fc2e35516ce33e3309b61cad UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] RocMarshal commented on pull request #17548: [FLINK-24383][streaming] Remove the deprecated SlidingTimeWindows, TumblingTimeWindows, BaseAlignedWindowAssigner.

2021-10-24 Thread GitBox
RocMarshal commented on pull request #17548: URL: https://github.com/apache/flink/pull/17548#issuecomment-950549753 Hi, @wuchong ,Could you help me to check this pr ?Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Updated] (FLINK-24624) Add clean up phase when kubernetes session start failed

2021-10-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24624: --- Labels: pull-request-available (was: ) > Add clean up phase when kubernetes session start

[GitHub] [flink] Aitozi opened a new pull request #17554: [FLINK-24624][Kubernetes]Kill cluster when starting kubernetes session or application cluster failed

2021-10-24 Thread GitBox
Aitozi opened a new pull request #17554: URL: https://github.com/apache/flink/pull/17554 ## What is the purpose of the change Make the exception try-catch cover the whole `deploySessionCluster` and `deployApplicationCluster` to make sure the kubernetes objects will be cleaned up

[GitHub] [flink] Airblader commented on a change in pull request #17332: [FLINK-24349]Support customized Calalogs via JDBC

2021-10-24 Thread GitBox
Airblader commented on a change in pull request #17332: URL: https://github.com/apache/flink/pull/17332#discussion_r735267747 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/JdbcDialect.java ## @@ -142,4 +143,16 @@

[jira] [Commented] (FLINK-23031) Support to emit window result with periodic or non_periodic

2021-10-24 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17433561#comment-17433561 ] Aitozi commented on FLINK-23031: Hi [~jark] [~godfreyhe] [~twalthr] anyone could help review this PR ?

[GitHub] [flink-ml] guoweiM commented on a change in pull request #12: [FLINK-6][iteration] add unbounded iteration.

2021-10-24 Thread GitBox
guoweiM commented on a change in pull request #12: URL: https://github.com/apache/flink-ml/pull/12#discussion_r735249190 ## File path: flink-ml-iteration/src/test/java/org/apache/flink/iteration/IterationConstructionTest.java ## @@ -0,0 +1,141 @@ +/* + * Licensed to the

[GitHub] [flink] xuyangzhong commented on a change in pull request #17537: [FLINK-19722][table-planner]Pushdown Watermark to SourceProvider (new Source)

2021-10-24 Thread GitBox
xuyangzhong commented on a change in pull request #17537: URL: https://github.com/apache/flink/pull/17537#discussion_r735247142 ## File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/sinkfunction/CollectionWatermarkSinkFunction.java

[GitHub] [flink] xuyangzhong commented on a change in pull request #17537: [FLINK-19722][table-planner]Pushdown Watermark to SourceProvider (new Source)

2021-10-24 Thread GitBox
xuyangzhong commented on a change in pull request #17537: URL: https://github.com/apache/flink/pull/17537#discussion_r735241016 ## File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/source/TestValuesSource.java ## @@ -0,0 +1,393

[jira] [Created] (FLINK-24627) Add some generic junit5 extensions to replace junit4 rules

2021-10-24 Thread Hang Ruan (Jira)
Hang Ruan created FLINK-24627: - Summary: Add some generic junit5 extensions to replace junit4 rules Key: FLINK-24627 URL: https://issues.apache.org/jira/browse/FLINK-24627 Project: Flink Issue

[jira] [Updated] (FLINK-23015) Implement streaming window Deduplicate operator

2021-10-24 Thread Kurt Young (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young updated FLINK-23015: --- Fix Version/s: 1.15.0 > Implement streaming window Deduplicate operator >

[jira] [Updated] (FLINK-21327) Support window TVF in batch mode

2021-10-24 Thread Kurt Young (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young updated FLINK-21327: --- Fix Version/s: 1.15.0 > Support window TVF in batch mode > > >

[GitHub] [flink] iyupeng commented on a change in pull request #17344: [FLINK-20895] [flink-table-planner] support local aggregate push down in table planner

2021-10-24 Thread GitBox
iyupeng commented on a change in pull request #17344: URL: https://github.com/apache/flink/pull/17344#discussion_r735225200 ## File path:

[GitHub] [flink] iyupeng commented on a change in pull request #17344: [FLINK-20895] [flink-table-planner] support local aggregate push down in table planner

2021-10-24 Thread GitBox
iyupeng commented on a change in pull request #17344: URL: https://github.com/apache/flink/pull/17344#discussion_r735222457 ## File path:

[GitHub] [flink] iyupeng commented on a change in pull request #17344: [FLINK-20895] [flink-table-planner] support local aggregate push down in table planner

2021-10-24 Thread GitBox
iyupeng commented on a change in pull request #17344: URL: https://github.com/apache/flink/pull/17344#discussion_r735221462 ## File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/agg/LocalAggregatePushDownITCase.scala ##

[GitHub] [flink] iyupeng commented on a change in pull request #17344: [FLINK-20895] [flink-table-planner] support local aggregate push down in table planner

2021-10-24 Thread GitBox
iyupeng commented on a change in pull request #17344: URL: https://github.com/apache/flink/pull/17344#discussion_r735221321 ## File path:

[GitHub] [flink] iyupeng commented on a change in pull request #17344: [FLINK-20895] [flink-table-planner] support local aggregate push down in table planner

2021-10-24 Thread GitBox
iyupeng commented on a change in pull request #17344: URL: https://github.com/apache/flink/pull/17344#discussion_r735219717 ## File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/agg/LocalAggregatePushDownITCase.scala ##

[GitHub] [flink] iyupeng commented on a change in pull request #17344: [FLINK-20895] [flink-table-planner] support local aggregate push down in table planner

2021-10-24 Thread GitBox
iyupeng commented on a change in pull request #17344: URL: https://github.com/apache/flink/pull/17344#discussion_r735219348 ## File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/TestValuesTableFactory.java ## @@ -867,27 +885,118

[GitHub] [flink] iyupeng commented on a change in pull request #17344: [FLINK-20895] [flink-table-planner] support local aggregate push down in table planner

2021-10-24 Thread GitBox
iyupeng commented on a change in pull request #17344: URL: https://github.com/apache/flink/pull/17344#discussion_r735219201 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/schema/TableSourceTable.scala ## @@ -131,4 +130,23 @@

[GitHub] [flink] baisui1981 removed a comment on pull request #17521: [FLINK-24558][API/DataStream]make parent ClassLoader variable which c…

2021-10-24 Thread GitBox
baisui1981 removed a comment on pull request #17521: URL: https://github.com/apache/flink/pull/17521#issuecomment-950471796 @AHeise , thanks for your reply , by checking of git histories commit logs , Maybe this issue is belong to `Command Line Client` more appropriate. @kl0u could you

[GitHub] [flink] baisui1981 commented on pull request #17521: [FLINK-24558][API/DataStream]make parent ClassLoader variable which c…

2021-10-24 Thread GitBox
baisui1981 commented on pull request #17521: URL: https://github.com/apache/flink/pull/17521#issuecomment-950471796 @AHeise , thanks for your reply , by checking of git histories commit logs , Maybe this issue is belong to `Command Line Client` more appropriate. @kl0u could you help me

[GitHub] [flink] iyupeng commented on a change in pull request #17344: [FLINK-20895] [flink-table-planner] support local aggregate push down in table planner

2021-10-24 Thread GitBox
iyupeng commented on a change in pull request #17344: URL: https://github.com/apache/flink/pull/17344#discussion_r735218756 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/FlinkBatchRuleSets.scala ## @@ -446,6 +446,9 @@

[GitHub] [flink] baisui1981 commented on pull request #17521: [FLINK-24558][API/DataStream]make parent ClassLoader variable which c…

2021-10-24 Thread GitBox
baisui1981 commented on pull request #17521: URL: https://github.com/apache/flink/pull/17521#issuecomment-950471638 @AHeise , thanks for your reply , by checking of git histories commit logs , Maybe this issue is belong to `Command Line Client` more appropriate. @kl0u could you help me

[GitHub] [flink] iyupeng commented on a change in pull request #17344: [FLINK-20895] [flink-table-planner] support local aggregate push down in table planner

2021-10-24 Thread GitBox
iyupeng commented on a change in pull request #17344: URL: https://github.com/apache/flink/pull/17344#discussion_r735218053 ## File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/agg/LocalAggregatePushDownITCase.scala ##

[GitHub] [flink] iyupeng commented on a change in pull request #17344: [FLINK-20895] [flink-table-planner] support local aggregate push down in table planner

2021-10-24 Thread GitBox
iyupeng commented on a change in pull request #17344: URL: https://github.com/apache/flink/pull/17344#discussion_r735217760 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/abilities/source/AggregatePushDownSpec.java ## @@ -0,0

[GitHub] [flink] flinkbot edited a comment on pull request #17344: [FLINK-20895] [flink-table-planner] support local aggregate push down in table planner

2021-10-24 Thread GitBox
flinkbot edited a comment on pull request #17344: URL: https://github.com/apache/flink/pull/17344#issuecomment-925952696 ## CI report: * 4ad29008075dc93463c07ce098cd7b1086104d7b Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17546: [FLINK-15987][tabel-planner-blink]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

2021-10-24 Thread GitBox
flinkbot edited a comment on pull request #17546: URL: https://github.com/apache/flink/pull/17546#issuecomment-949398959 ## CI report: * 51ffb83f52f0334094f425d86aa5dd178a107267 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17344: [FLINK-20895] [flink-table-planner] support local aggregate push down in table planner

2021-10-24 Thread GitBox
flinkbot edited a comment on pull request #17344: URL: https://github.com/apache/flink/pull/17344#issuecomment-925952696 ## CI report: * 4ad29008075dc93463c07ce098cd7b1086104d7b Azure:

[jira] [Updated] (FLINK-24626) Flink JDBC Sink may lose data in left join

2021-10-24 Thread Kenyore (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kenyore updated FLINK-24626: Description: The JDBC sink will lose some data while using  TableBufferReducedStatementExecutor and left

[jira] [Updated] (FLINK-24626) Flink JDBC Sink may lose data in left join

2021-10-24 Thread Kenyore (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kenyore updated FLINK-24626: Summary: Flink JDBC Sink may lose data in left join (was: Flink JDBC Sink may lose data in retract

[jira] [Updated] (FLINK-24558) dataStream can not use multiple classloaders

2021-10-24 Thread bai sui (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] bai sui updated FLINK-24558: Component/s: (was: API / DataStream) Command Line Client > dataStream can not use

[jira] [Created] (FLINK-24626) Flink JDBC Sink may lose data in retract stream

2021-10-24 Thread Kenyore (Jira)
Kenyore created FLINK-24626: --- Summary: Flink JDBC Sink may lose data in retract stream Key: FLINK-24626 URL: https://issues.apache.org/jira/browse/FLINK-24626 Project: Flink Issue Type: Bug

[GitHub] [flink] xuyangzhong commented on a change in pull request #17537: [FLINK-19722][table-planner]Pushdown Watermark to SourceProvider (new Source)

2021-10-24 Thread GitBox
xuyangzhong commented on a change in pull request #17537: URL: https://github.com/apache/flink/pull/17537#discussion_r735212556 ## File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/sinkfunction/CollectionWatermarkSinkFunction.java

[GitHub] [flink] xuyangzhong commented on a change in pull request #17537: [FLINK-19722][table-planner]Pushdown Watermark to SourceProvider (new Source)

2021-10-24 Thread GitBox
xuyangzhong commented on a change in pull request #17537: URL: https://github.com/apache/flink/pull/17537#discussion_r735210571 ## File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/sinkfunction/CollectionWatermarkSinkFunction.java

[GitHub] [flink] xuyangzhong commented on a change in pull request #17537: [FLINK-19722][table-planner]Pushdown Watermark to SourceProvider (new Source)

2021-10-24 Thread GitBox
xuyangzhong commented on a change in pull request #17537: URL: https://github.com/apache/flink/pull/17537#discussion_r735210503 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecTableSourceScan.java ##

[GitHub] [flink] flinkbot edited a comment on pull request #17546: [FLINK-15987][tabel-planner-blink]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

2021-10-24 Thread GitBox
flinkbot edited a comment on pull request #17546: URL: https://github.com/apache/flink/pull/17546#issuecomment-949398959 ## CI report: * 51ffb83f52f0334094f425d86aa5dd178a107267 Azure:

[jira] [Commented] (FLINK-24605) org.apache.flink.kafka.shaded.org.apache.kafka.clients.consumer.NoOffsetForPartitionException: Undefined offset with no reset policy for partitions

2021-10-24 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17433530#comment-17433530 ] Qingsheng Ren commented on FLINK-24605: --- Thanks for reporting this [~a_talukdar] ! I think it's a

[GitHub] [flink] flinkbot edited a comment on pull request #17546: [FLINK-15987][tabel-planner-blink]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

2021-10-24 Thread GitBox
flinkbot edited a comment on pull request #17546: URL: https://github.com/apache/flink/pull/17546#issuecomment-949398959 ## CI report: * 51ffb83f52f0334094f425d86aa5dd178a107267 Azure:

[GitHub] [flink] xuyangzhong commented on pull request #17546: [FLINK-15987][tabel-planner-blink]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

2021-10-24 Thread GitBox
xuyangzhong commented on pull request #17546: URL: https://github.com/apache/flink/pull/17546#issuecomment-950452711 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Closed] (FLINK-24613) Documentation on orc supported data types is outdated

2021-10-24 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-24613. Fix Version/s: 1.14.1 Resolution: Fixed Fixed via: master:

[GitHub] [flink] JingsongLi merged pull request #17543: [FLINK-24613][doc]Documentation on orc supported data types is outdated

2021-10-24 Thread GitBox
JingsongLi merged pull request #17543: URL: https://github.com/apache/flink/pull/17543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Comment Edited] (FLINK-20578) Cannot create empty array using ARRAY[]

2021-10-24 Thread Saad Ur Rahman (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17433476#comment-17433476 ] Saad Ur Rahman edited comment on FLINK-20578 at 10/24/21, 11:52 PM:

[jira] [Comment Edited] (FLINK-20578) Cannot create empty array using ARRAY[]

2021-10-24 Thread Saad Ur Rahman (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17433476#comment-17433476 ] Saad Ur Rahman edited comment on FLINK-20578 at 10/24/21, 10:38 PM:

[jira] [Updated] (FLINK-24350) Resuming Savepoint (hashmap, sync, scale up) end-to-end test fails due to ask timeout

2021-10-24 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-24350: --- Labels: stale-assigned test-stability (was: test-stability) I am the [Flink Jira

[jira] [Commented] (FLINK-24623) Prevent usage of EventTimeWindows when EventTime is disabled

2021-10-24 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17433513#comment-17433513 ] Till Rohrmann commented on FLINK-24623: --- Thanks for creating this ticket [~Dario]. cc [~arvid]. >

[jira] [Comment Edited] (FLINK-24592) FlinkSQL multiline parser improvements

2021-10-24 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17433499#comment-17433499 ] Sergey Nuyanzin edited comment on FLINK-24592 at 10/24/21, 7:47 PM:

[jira] [Commented] (FLINK-24592) FlinkSQL multiline parser improvements

2021-10-24 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17433499#comment-17433499 ] Sergey Nuyanzin commented on FLINK-24592: - Currently I have a version[1] supported all the

[GitHub] [flink] flinkbot edited a comment on pull request #17553: [Hotfix][git] Add 'flink-python/.idea/' into .gitignore file.

2021-10-24 Thread GitBox
flinkbot edited a comment on pull request #17553: URL: https://github.com/apache/flink/pull/17553#issuecomment-950337501 ## CI report: * 033f02a5aa2654a6c9c82047a6077542b973756b Azure:

[jira] [Comment Edited] (FLINK-20578) Cannot create empty array using ARRAY[]

2021-10-24 Thread Saad Ur Rahman (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17433476#comment-17433476 ] Saad Ur Rahman edited comment on FLINK-20578 at 10/24/21, 5:55 PM: --- As

[jira] [Commented] (FLINK-20578) Cannot create empty array using ARRAY[]

2021-10-24 Thread Saad Ur Rahman (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17433476#comment-17433476 ] Saad Ur Rahman commented on FLINK-20578: As I understand the problem we would need to override

[GitHub] [flink-ml] gaoyunhaii commented on a change in pull request #8: [FLINK-4][iteration] Add operator wrapper for all-round iterations.

2021-10-24 Thread GitBox
gaoyunhaii commented on a change in pull request #8: URL: https://github.com/apache/flink-ml/pull/8#discussion_r735137114 ## File path: flink-ml-iteration/src/main/java/org/apache/flink/iteration/proxy/ProxyOutput.java ## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache

[GitHub] [flink] flinkbot edited a comment on pull request #17553: [Hotfix][git] Add 'flink-python/.idea/' into .gitignore file.

2021-10-24 Thread GitBox
flinkbot edited a comment on pull request #17553: URL: https://github.com/apache/flink/pull/17553#issuecomment-950337501 ## CI report: * 078605c69cb264c9e212312b559f6fc2ec2f3114 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17553: [Hotfix][git] Add 'flink-python/.idea/' into .gitignore file.

2021-10-24 Thread GitBox
flinkbot edited a comment on pull request #17553: URL: https://github.com/apache/flink/pull/17553#issuecomment-950337501 ## CI report: * 078605c69cb264c9e212312b559f6fc2ec2f3114 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17553: [Hotfix][git] Add 'flink-python/.idea/' into .gitignore file.

2021-10-24 Thread GitBox
flinkbot edited a comment on pull request #17553: URL: https://github.com/apache/flink/pull/17553#issuecomment-950337501 ## CI report: * 078605c69cb264c9e212312b559f6fc2ec2f3114 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17553: [Hotfix][git] Add 'flink-python/.idea/' into .gitignore file.

2021-10-24 Thread GitBox
flinkbot edited a comment on pull request #17553: URL: https://github.com/apache/flink/pull/17553#issuecomment-950337501 ## CI report: * 078605c69cb264c9e212312b559f6fc2ec2f3114 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17553: [Hotfix][git] Add 'flink-python/.idea/' into .gitignore file.

2021-10-24 Thread GitBox
flinkbot edited a comment on pull request #17553: URL: https://github.com/apache/flink/pull/17553#issuecomment-950337501 ## CI report: * 078605c69cb264c9e212312b559f6fc2ec2f3114 Azure:

[GitHub] [flink-ml] gaoyunhaii commented on a change in pull request #8: [FLINK-4][iteration] Add operator wrapper for all-round iterations.

2021-10-24 Thread GitBox
gaoyunhaii commented on a change in pull request #8: URL: https://github.com/apache/flink-ml/pull/8#discussion_r735135046 ## File path: flink-ml-iteration/src/main/java/org/apache/flink/iteration/operator/AbstractWrapperOperator.java ## @@ -0,0 +1,164 @@ +/* + * Licensed to

[GitHub] [flink-ml] gaoyunhaii commented on a change in pull request #7: [FLINK-3][iteration] Implements the feedback mechanism and the controller operators.

2021-10-24 Thread GitBox
gaoyunhaii commented on a change in pull request #7: URL: https://github.com/apache/flink-ml/pull/7#discussion_r735134932 ## File path: flink-ml-iteration/src/test/java/org/apache/flink/iteration/typeinfo/IterationRecordSerializerTest.java ## @@ -0,0 +1,83 @@ +/* + * Licensed

[GitHub] [flink] flinkbot edited a comment on pull request #17553: [Hotfix][git] Add 'flink-python/.idea/' into .gitignore file.

2021-10-24 Thread GitBox
flinkbot edited a comment on pull request #17553: URL: https://github.com/apache/flink/pull/17553#issuecomment-950337501 ## CI report: * 078605c69cb264c9e212312b559f6fc2ec2f3114 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17553: [Hotfix][git] Add 'flink-python/.idea/' into .gitignore file.

2021-10-24 Thread GitBox
flinkbot edited a comment on pull request #17553: URL: https://github.com/apache/flink/pull/17553#issuecomment-950337501 ## CI report: * 078605c69cb264c9e212312b559f6fc2ec2f3114 Azure:

[jira] [Commented] (FLINK-24624) Add clean up phase when kubernetes session start failed

2021-10-24 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17433449#comment-17433449 ] Aitozi commented on FLINK-24624: So the {{client.stopAndCleanupCluster(clusterId)}} should cover the

[GitHub] [flink] flinkbot edited a comment on pull request #17553: [Hotfix][git] Add 'flink-python/.idea/' into .gitignore file.

2021-10-24 Thread GitBox
flinkbot edited a comment on pull request #17553: URL: https://github.com/apache/flink/pull/17553#issuecomment-950337501 ## CI report: * 078605c69cb264c9e212312b559f6fc2ec2f3114 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17553: [Hotfix][git] Add 'flink-python/.idea/' into .gitignore file.

2021-10-24 Thread GitBox
flinkbot edited a comment on pull request #17553: URL: https://github.com/apache/flink/pull/17553#issuecomment-950337501 ## CI report: * 078605c69cb264c9e212312b559f6fc2ec2f3114 Azure:

[jira] [Commented] (FLINK-24624) Add clean up phase when kubernetes session start failed

2021-10-24 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17433448#comment-17433448 ] Aitozi commented on FLINK-24624: After looking into the failure, It's caused by the lack of permission

[GitHub] [flink] flinkbot edited a comment on pull request #17553: [Hotfix][git] Add 'flink-python/.idea/' into .gitignore file.

2021-10-24 Thread GitBox
flinkbot edited a comment on pull request #17553: URL: https://github.com/apache/flink/pull/17553#issuecomment-950337501 ## CI report: * 078605c69cb264c9e212312b559f6fc2ec2f3114 Azure:

[GitHub] [flink-ml] gaoyunhaii commented on pull request #6: [FLINK-2][iteration] Add broadcast output to broadcast events to all the downstream tasks

2021-10-24 Thread GitBox
gaoyunhaii commented on pull request #6: URL: https://github.com/apache/flink-ml/pull/6#issuecomment-950341636 Very thanks @guoweiM for the review! I updated the PR to address the inline comments~ I also agree with we should push the broadcast functionality back to the runtime.

[GitHub] [flink] flinkbot edited a comment on pull request #17553: [Hotfix][git] Add 'flink-python/.idea/' into .gitignore file.

2021-10-24 Thread GitBox
flinkbot edited a comment on pull request #17553: URL: https://github.com/apache/flink/pull/17553#issuecomment-950337501 ## CI report: * 078605c69cb264c9e212312b559f6fc2ec2f3114 Azure:

[GitHub] [flink-ml] gaoyunhaii commented on a change in pull request #6: [FLINK-2][iteration] Add broadcast output to broadcast events to all the downstream tasks

2021-10-24 Thread GitBox
gaoyunhaii commented on a change in pull request #6: URL: https://github.com/apache/flink-ml/pull/6#discussion_r735132139 ## File path: flink-ml-iteration/src/main/java/org/apache/flink/iteration/broadcast/CountingBroadcastOutput.java ## @@ -0,0 +1,50 @@ +/* + * Licensed to

[GitHub] [flink] flinkbot edited a comment on pull request #17553: [Hotfix][git] Add 'flink-python/.idea/' into .gitignore file.

2021-10-24 Thread GitBox
flinkbot edited a comment on pull request #17553: URL: https://github.com/apache/flink/pull/17553#issuecomment-950337501 ## CI report: * 078605c69cb264c9e212312b559f6fc2ec2f3114 Azure:

[GitHub] [flink-ml] gaoyunhaii commented on a change in pull request #6: [FLINK-2][iteration] Add broadcast output to broadcast events to all the downstream tasks

2021-10-24 Thread GitBox
gaoyunhaii commented on a change in pull request #6: URL: https://github.com/apache/flink-ml/pull/6#discussion_r735131924 ## File path: flink-ml-iteration/src/main/java/org/apache/flink/iteration/broadcast/ChainingBroadcastOutput.java ## @@ -0,0 +1,43 @@ +/* + * Licensed to

[GitHub] [flink-ml] gaoyunhaii commented on a change in pull request #6: [FLINK-2][iteration] Add broadcast output to broadcast events to all the downstream tasks

2021-10-24 Thread GitBox
gaoyunhaii commented on a change in pull request #6: URL: https://github.com/apache/flink-ml/pull/6#discussion_r735131743 ## File path: flink-ml-iteration/src/main/java/org/apache/flink/iteration/broadcast/ChainingBroadcastOutput.java ## @@ -0,0 +1,43 @@ +/* + * Licensed to

[GitHub] [flink-ml] gaoyunhaii commented on pull request #5: [FLINK-1][iteration] Adds the iteration module and API

2021-10-24 Thread GitBox
gaoyunhaii commented on pull request #5: URL: https://github.com/apache/flink-ml/pull/5#issuecomment-950339981 Very thanks @guoweiM for the review! I updated the PR to fix the inline comments. Regarding the style of the api: during the discussion we indeed have another possible

[GitHub] [flink] flinkbot edited a comment on pull request #17553: [Hotfix][git] Add 'flink-python/.idea/' into .gitignore file.

2021-10-24 Thread GitBox
flinkbot edited a comment on pull request #17553: URL: https://github.com/apache/flink/pull/17553#issuecomment-950337501 ## CI report: * 078605c69cb264c9e212312b559f6fc2ec2f3114 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17553: [Hotfix][git] Add 'flink-python/.idea/' into .gitignore file.

2021-10-24 Thread GitBox
flinkbot edited a comment on pull request #17553: URL: https://github.com/apache/flink/pull/17553#issuecomment-950337501 ## CI report: * 078605c69cb264c9e212312b559f6fc2ec2f3114 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17553: [Hotfix][git] Add 'flink-python/.idea/' into .gitignore file.

2021-10-24 Thread GitBox
flinkbot edited a comment on pull request #17553: URL: https://github.com/apache/flink/pull/17553#issuecomment-950337501 ## CI report: * 078605c69cb264c9e212312b559f6fc2ec2f3114 Azure:

[GitHub] [flink] RocMarshal edited a comment on pull request #17463: [Hotfix][docs-zh] Fix typo in the 'SHOW COLUMNS' section.

2021-10-24 Thread GitBox
RocMarshal edited a comment on pull request #17463: URL: https://github.com/apache/flink/pull/17463#issuecomment-944947844 Hi, @klion26 , here is a minor typo. Would you like to help me to check it ? Thank you very much. -- This is an automated message from the Apache Git Service. To

[GitHub] [flink] flinkbot edited a comment on pull request #17553: [Hotfix][git] Add 'flink-python/.idea/' into .gitignore file.

2021-10-24 Thread GitBox
flinkbot edited a comment on pull request #17553: URL: https://github.com/apache/flink/pull/17553#issuecomment-950337501 ## CI report: * 078605c69cb264c9e212312b559f6fc2ec2f3114 Azure:

[GitHub] [flink] RocMarshal commented on pull request #17553: [Hotfix][git] Add 'flink-python/.idea/' into .gitignore file.

2021-10-24 Thread GitBox
RocMarshal commented on pull request #17553: URL: https://github.com/apache/flink/pull/17553#issuecomment-950337942 @dianfu Could you help me to check it ? Thank you very much. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] flinkbot commented on pull request #17553: [Hotfix][git] Add 'flink-python/.idea/' into .gitignore file.

2021-10-24 Thread GitBox
flinkbot commented on pull request #17553: URL: https://github.com/apache/flink/pull/17553#issuecomment-950337872 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] flinkbot edited a comment on pull request #17553: [Hotfix][git] Add 'flink-python/.idea/' into .gitignore file.

2021-10-24 Thread GitBox
flinkbot edited a comment on pull request #17553: URL: https://github.com/apache/flink/pull/17553#issuecomment-950337501 ## CI report: * 078605c69cb264c9e212312b559f6fc2ec2f3114 Azure:

[GitHub] [flink] flinkbot commented on pull request #17553: [Hotfix][git] Add 'flink-python/.idea/' into .gitignore file.

2021-10-24 Thread GitBox
flinkbot commented on pull request #17553: URL: https://github.com/apache/flink/pull/17553#issuecomment-950337501 ## CI report: * 078605c69cb264c9e212312b559f6fc2ec2f3114 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] RocMarshal opened a new pull request #17553: [Hotfix][gitignore] Add 'flink-python/.idea/' into .gitignore file.

2021-10-24 Thread GitBox
RocMarshal opened a new pull request #17553: URL: https://github.com/apache/flink/pull/17553 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring

[jira] [Comment Edited] (FLINK-24489) The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache

2021-10-24 Thread Yuepeng Pan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432915#comment-17432915 ] Yuepeng Pan edited comment on FLINK-24489 at 10/24/21, 2:04 PM:

[GitHub] [flink-ml] lindong28 opened a new pull request #19: Remove the library infra classes that need to be revisited.

2021-10-24 Thread GitBox
lindong28 opened a new pull request #19: URL: https://github.com/apache/flink-ml/pull/19 This PR removes the infra whose purpose, API and usage needs to be revisited. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (FLINK-23346) RocksDBStateBackend may core dump in flink_compactionfilterjni.cc

2021-10-24 Thread Congxian Qiu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17433434#comment-17433434 ] Congxian Qiu commented on FLINK-23346: -- [~yunta] sorry for the late reply. we don't notice the use

[jira] [Commented] (FLINK-24597) RocksdbStateBackend getKeysAndNamespaces would return duplicate data when using MapState

2021-10-24 Thread Congxian Qiu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17433432#comment-17433432 ] Congxian Qiu commented on FLINK-24597: -- [~mayuehappy] thanks for reporting this issue, I think this

[GitHub] [flink] echauchot commented on pull request #17501: [Draft][FLINK-21406][RecordFormat] build AvroParquetRecordFormat for the new FileSource

2021-10-24 Thread GitBox
echauchot commented on pull request #17501: URL: https://github.com/apache/flink/pull/17501#issuecomment-950315970 R:@echauchot @JingGe thanks a lot for your work ! If I may, I'd like to review this PR as I was the author of the `ParquetAvroInputFormat` for the older source. -- This

[GitHub] [flink] fsk119 commented on a change in pull request #17537: [FLINK-19722][table-planner]Pushdown Watermark to SourceProvider (new Source)

2021-10-24 Thread GitBox
fsk119 commented on a change in pull request #17537: URL: https://github.com/apache/flink/pull/17537#discussion_r735066347 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecTableSourceScan.java ## @@

[jira] [Created] (FLINK-24625) Expose the required kubernetes permission from the shell command

2021-10-24 Thread Aitozi (Jira)
Aitozi created FLINK-24625: -- Summary: Expose the required kubernetes permission from the shell command Key: FLINK-24625 URL: https://issues.apache.org/jira/browse/FLINK-24625 Project: Flink Issue

[jira] [Created] (FLINK-24624) Add clean up phase when kubernetes session start failed

2021-10-24 Thread Aitozi (Jira)
Aitozi created FLINK-24624: -- Summary: Add clean up phase when kubernetes session start failed Key: FLINK-24624 URL: https://issues.apache.org/jira/browse/FLINK-24624 Project: Flink Issue Type: