[GitHub] [flink] zzzzzzzs commented on pull request #20342: [FLINK-26939][Table SQL/API] Add TRANSLATE supported in SQL & Table API

2022-07-22 Thread GitBox
zzzs commented on PR #20342: URL: https://github.com/apache/flink/pull/20342#issuecomment-1193063464 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink-connector-elasticsearch] Recorvery closed pull request #26: fix the code of create a instance in the doc

2022-07-22 Thread GitBox
Recorvery closed pull request #26: fix the code of create a instance in the doc URL: https://github.com/apache/flink-connector-elasticsearch/pull/26 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink-connector-elasticsearch] Recorvery opened a new pull request, #26: fix the code of create a instance in the doc

2022-07-22 Thread GitBox
Recorvery opened a new pull request, #26: URL: https://github.com/apache/flink-connector-elasticsearch/pull/26 In this file,line 41 missed a right brackets ,may confused the learner . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Closed] (FLINK-27618) Support CumeDist

2022-07-22 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-27618. --- Resolution: Fixed Fixed in master: 8017a417515cb87b1d15ef1295ecac73126b40f8 > Support CumeDist >

[jira] [Closed] (FLINK-28451) HiveFunctionDefinitionFactory load udf using user classloader instead of thread context classloader

2022-07-22 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-28451. --- Resolution: Fixed Fixed in master: e13ae26e806eff403787d5b75e90008bcc13d8dc and

[GitHub] [flink] wuchong merged pull request #19727: [FLINK-27618][sql] Flink supports CUME_DIST function

2022-07-22 Thread GitBox
wuchong merged PR #19727: URL: https://github.com/apache/flink/pull/19727 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] wuchong closed pull request #20211: [FLINK-28451][hive] Use UserCodeClassloader instead of the current thread's classloader to load function

2022-07-22 Thread GitBox
wuchong closed pull request #20211: [FLINK-28451][hive] Use UserCodeClassloader instead of the current thread's classloader to load function URL: https://github.com/apache/flink/pull/20211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink-connector-elasticsearch] Recorvery closed pull request #25: Update Elasticsearch7SinkBuilder.java

2022-07-22 Thread GitBox
Recorvery closed pull request #25: Update Elasticsearch7SinkBuilder.java URL: https://github.com/apache/flink-connector-elasticsearch/pull/25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink-connector-elasticsearch] boring-cyborg[bot] commented on pull request #25: Update Elasticsearch7SinkBuilder.java

2022-07-22 Thread GitBox
boring-cyborg[bot] commented on PR #25: URL: https://github.com/apache/flink-connector-elasticsearch/pull/25#issuecomment-1193058526 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) --

[GitHub] [flink-connector-elasticsearch] Recorvery opened a new pull request, #25: Update Elasticsearch7SinkBuilder.java

2022-07-22 Thread GitBox
Recorvery opened a new pull request, #25: URL: https://github.com/apache/flink-connector-elasticsearch/pull/25 The example code is missing the right-hand parenthesis -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink] luoyuxia commented on a diff in pull request #20084: [FLINK-27988][table-planner] Let HiveTableSource extend from SupportStatisticsReport

2022-07-22 Thread GitBox
luoyuxia commented on code in PR #20084: URL: https://github.com/apache/flink/pull/20084#discussion_r928066455 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveSourceBuilder.java: ## @@ -315,7 +315,7 @@ private RowType

[GitHub] [flink] DavidLiu001 commented on a diff in pull request #20338: [FLINK-27536][Connectors / Common] Rename method parameter in AsyncSi…

2022-07-22 Thread GitBox
DavidLiu001 commented on code in PR #20338: URL: https://github.com/apache/flink/pull/20338#discussion_r927431507 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java: ## @@ -170,30 +170,30 @@ * the valid

[GitHub] [flink] zzzzzzzs commented on pull request #20323: [FLINK-26944][Table SQL/API] Add ADD_MONTHS supported in SQL and Table API

2022-07-22 Thread GitBox
zzzs commented on PR #20323: URL: https://github.com/apache/flink/pull/20323#issuecomment-1193042878 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (FLINK-26047) Support usrlib in HDFS for YARN application mode

2022-07-22 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang updated FLINK-26047: -- Fix Version/s: 1.16.0 > Support usrlib in HDFS for YARN application mode >

[jira] [Closed] (FLINK-26047) Support usrlib in HDFS for YARN application mode

2022-07-22 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang closed FLINK-26047. - Resolution: Fixed Fixed via: master: fc533b9d9c1252db124b4c1cb8365b3906b009cf > Support usrlib in

[GitHub] [flink] wangyang0918 merged pull request #19065: [FLINK-26047][yarn] Support remote usrlib in HDFS for YARN deployment

2022-07-22 Thread GitBox
wangyang0918 merged PR #19065: URL: https://github.com/apache/flink/pull/19065 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] zzzzzzzs commented on pull request #20342: [FLINK-26939][Table SQL/API] Add TRANSLATE supported in SQL & Table API

2022-07-22 Thread GitBox
zzzs commented on PR #20342: URL: https://github.com/apache/flink/pull/20342#issuecomment-1193036846 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] zstraw commented on pull request #17956: [FLINK-18779][table sql/planner]Support the SupportsFilterPushDown for LookupTableSource

2022-07-22 Thread GitBox
zstraw commented on PR #17956: URL: https://github.com/apache/flink/pull/17956#issuecomment-1193036249 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (FLINK-27851) Join can't access the pk from source table

2022-07-22 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-27851: --- Labels: pull-request-available stale-assigned (was: pull-request-available) I am the

[jira] [Created] (FLINK-28652) Amazon Linux 2 based Docker container for Flink

2022-07-22 Thread Alexey Petrenko (Jira)
Alexey Petrenko created FLINK-28652: --- Summary: Amazon Linux 2 based Docker container for Flink Key: FLINK-28652 URL: https://issues.apache.org/jira/browse/FLINK-28652 Project: Flink Issue

[jira] [Commented] (FLINK-28650) Flink SQL Parsing bug for METADATA

2022-07-22 Thread Jun Qin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17570124#comment-17570124 ] Jun Qin commented on FLINK-28650: - Thanks [~JasonLee]. Your example indeed works, and it is included in

[jira] [Created] (FLINK-28651) JarRunHandler ignores restore mode set in the configuration

2022-07-22 Thread Nuno Afonso (Jira)
Nuno Afonso created FLINK-28651: --- Summary: JarRunHandler ignores restore mode set in the configuration Key: FLINK-28651 URL: https://issues.apache.org/jira/browse/FLINK-28651 Project: Flink

[GitHub] [flink] hlteoh37 commented on a diff in pull request #20245: [FLINK-28487][connectors] Introduce configurable RateLimitingStrategy…

2022-07-22 Thread GitBox
hlteoh37 commented on code in PR #20245: URL: https://github.com/apache/flink/pull/20245#discussion_r927824434 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/strategy/RequestInfo.java: ## @@ -0,0 +1,67 @@ +/* + * Licensed to

[GitHub] [flink-kubernetes-operator] jeesmon opened a new pull request, #328: [FLINK-28637] Set explicit version for okhttp to fix vulnerability

2022-07-22 Thread GitBox
jeesmon opened a new pull request, #328: URL: https://github.com/apache/flink-kubernetes-operator/pull/328 ## What is the purpose of the change Setting explicit version for okhttp until we can upgrade to new version of JSODK with the fix. ## Brief change log - Setting

[GitHub] [flink] hlteoh37 commented on a diff in pull request #20245: [FLINK-28487][connectors] Introduce configurable RateLimitingStrategy…

2022-07-22 Thread GitBox
hlteoh37 commented on code in PR #20245: URL: https://github.com/apache/flink/pull/20245#discussion_r927823525 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java: ## @@ -344,69 +352,69 @@ public void

[jira] [Updated] (FLINK-28637) High vulnerability in flink-kubernetes-operator-1.1.0-shaded.jar

2022-07-22 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-28637: --- Fix Version/s: kubernetes-operator-1.1.1 kubernetes-operator-1.2.0 > High

[jira] [Updated] (FLINK-28637) High vulnerability in flink-kubernetes-operator-1.1.0-shaded.jar

2022-07-22 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-28637: --- Affects Version/s: kubernetes-operator-1.0.1 > High vulnerability in

[jira] [Assigned] (FLINK-28637) High vulnerability in flink-kubernetes-operator-1.1.0-shaded.jar

2022-07-22 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-28637: -- Assignee: Jeesmon Jacob > High vulnerability in flink-kubernetes-operator-1.1.0-shaded.jar >

[jira] [Updated] (FLINK-28637) High vulnerability in flink-kubernetes-operator-1.1.0-shaded.jar

2022-07-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-28637: --- Labels: pull-request-available (was: ) > High vulnerability in

[GitHub] [flink-kubernetes-operator] jeesmon opened a new pull request, #327: [FLINK-28637] Set explicit version for okhttp to fix vulnerability

2022-07-22 Thread GitBox
jeesmon opened a new pull request, #327: URL: https://github.com/apache/flink-kubernetes-operator/pull/327 ## What is the purpose of the change Setting explicit version for okhttp until we can upgrade to new version of JSODK with the fix. ## Brief change log - Setting

[jira] [Comment Edited] (FLINK-28637) High vulnerability in flink-kubernetes-operator-1.1.0-shaded.jar

2022-07-22 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17570097#comment-17570097 ] Gyula Fora edited comment on FLINK-28637 at 7/22/22 3:53 PM: - Personally I

[jira] [Commented] (FLINK-28637) High vulnerability in flink-kubernetes-operator-1.1.0-shaded.jar

2022-07-22 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17570097#comment-17570097 ] Gyula Fora commented on FLINK-28637: Personally I am not extremely confident in simply swapping out

[jira] [Commented] (FLINK-28637) High vulnerability in flink-kubernetes-operator-1.1.0-shaded.jar

2022-07-22 Thread Jeesmon Jacob (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17570096#comment-17570096 ] Jeesmon Jacob commented on FLINK-28637: --- [~mbalassi] Like JOSDK explicitly set okhttp version, can

[GitHub] [flink] pnowojski commented on a diff in pull request #20245: [FLINK-28487][connectors] Introduce configurable RateLimitingStrategy…

2022-07-22 Thread GitBox
pnowojski commented on code in PR #20245: URL: https://github.com/apache/flink/pull/20245#discussion_r927747602 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/strategy/AIMDScalingStrategy.java: ## @@ -0,0 +1,85 @@ +/* + *

[jira] [Commented] (FLINK-28650) Flink SQL Parsing bug for METADATA

2022-07-22 Thread JasonLee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17570073#comment-17570073 ] JasonLee commented on FLINK-28650: -- hi [~qinjunjerry] ,maybe u can try the following {code:java} //

[GitHub] [flink] zzzzzzzs commented on pull request #20323: [FLINK-26944][Table SQL/API] Add ADD_MONTHS supported in SQL and Table API

2022-07-22 Thread GitBox
zzzs commented on PR #20323: URL: https://github.com/apache/flink/pull/20323#issuecomment-1192681902 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] zzzzzzzs commented on pull request #20342: [FLINK-26939][Table SQL/API] Add TRANSLATE supported in SQL & Table API

2022-07-22 Thread GitBox
zzzs commented on PR #20342: URL: https://github.com/apache/flink/pull/20342#issuecomment-1192681393 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] zzzzzzzs commented on pull request #20342: [FLINK-26939][Table SQL/API] Add TRANSLATE supported in SQL & Table API

2022-07-22 Thread GitBox
zzzs commented on PR #20342: URL: https://github.com/apache/flink/pull/20342#issuecomment-1192674314 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Comment Edited] (FLINK-28231) Support Apache Ozone FileSystem

2022-07-22 Thread Xin Wen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17570064#comment-17570064 ] Xin Wen edited comment on FLINK-28231 at 7/22/22 2:53 PM: -- Hi [~bianqi] , can

[jira] [Commented] (FLINK-28231) Support Apache Ozone FileSystem

2022-07-22 Thread Xin Wen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17570064#comment-17570064 ] Xin Wen commented on FLINK-28231: - Hi bianqi, > Support Apache Ozone FileSystem >

[jira] [Commented] (FLINK-28637) High vulnerability in flink-kubernetes-operator-1.1.0-shaded.jar

2022-07-22 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-28637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17570063#comment-17570063 ] Márton Balassi commented on FLINK-28637: Fortunately both the Fabric8 and the JOSDK community

[jira] [Created] (FLINK-28650) Flink SQL Parsing bug for METADATA

2022-07-22 Thread Jun Qin (Jira)
Jun Qin created FLINK-28650: --- Summary: Flink SQL Parsing bug for METADATA Key: FLINK-28650 URL: https://issues.apache.org/jira/browse/FLINK-28650 Project: Flink Issue Type: Bug Affects

[jira] [Commented] (FLINK-28649) Allow adopting unmanaged jobs as FlinkSessionJob resource

2022-07-22 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17570053#comment-17570053 ] Gyula Fora commented on FLINK-28649: cc [~jeesmon]  > Allow adopting unmanaged jobs as

[jira] [Created] (FLINK-28649) Allow adopting unmanaged jobs as FlinkSessionJob resource

2022-07-22 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-28649: -- Summary: Allow adopting unmanaged jobs as FlinkSessionJob resource Key: FLINK-28649 URL: https://issues.apache.org/jira/browse/FLINK-28649 Project: Flink Issue

[jira] [Created] (FLINK-28648) Allow session deletion to block on any running job

2022-07-22 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-28648: -- Summary: Allow session deletion to block on any running job Key: FLINK-28648 URL: https://issues.apache.org/jira/browse/FLINK-28648 Project: Flink Issue Type:

[jira] [Commented] (FLINK-28648) Allow session deletion to block on any running job

2022-07-22 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17570051#comment-17570051 ] Gyula Fora commented on FLINK-28648: cc [~jeesmon]  > Allow session deletion to block on any

[GitHub] [flink] zzzzzzzs commented on pull request #20342: [FLINK-26939][Table SQL/API] Add TRANSLATE supported in SQL & Table API

2022-07-22 Thread GitBox
zzzs commented on PR #20342: URL: https://github.com/apache/flink/pull/20342#issuecomment-1192603439 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] fredia commented on a diff in pull request #19907: [FLINK-27692][state] Support local recovery for materialized part of changelog

2022-07-22 Thread GitBox
fredia commented on code in PR #19907: URL: https://github.com/apache/flink/pull/19907#discussion_r927677335 ## flink-tests/src/test/java/org/apache/flink/test/checkpointing/ChangelogLocalRecoveryITCase.java: ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] fredia commented on a diff in pull request #20152: [FLINK-27155][changelog] Reduce multiple reads to the same Changelog …

2022-07-22 Thread GitBox
fredia commented on code in PR #20152: URL: https://github.com/apache/flink/pull/20152#discussion_r927673437 ## flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogStateBackend.java: ## @@ -87,9 +87,14 @@ protected

[GitHub] [flink] zzzzzzzs commented on pull request #20323: [FLINK-26944][Table SQL/API] Add ADD_MONTHS supported in SQL and Table API

2022-07-22 Thread GitBox
zzzs commented on PR #20323: URL: https://github.com/apache/flink/pull/20323#issuecomment-1192597362 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] zzzzzzzs commented on pull request #20330: [FLINK-26940][Table SQL/API] Add SUBSTRING_INDEX supported in SQL & Table API

2022-07-22 Thread GitBox
zzzs commented on PR #20330: URL: https://github.com/apache/flink/pull/20330#issuecomment-1192596952 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] zentol commented on pull request #20332: [FLINK-28624][csv] Accept mapper/schema factories

2022-07-22 Thread GitBox
zentol commented on PR #20332: URL: https://github.com/apache/flink/pull/20332#issuecomment-1192596936 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink-docker] nferrario commented on a diff in pull request #117: [FLINK-28057] Fix LD_PRELOAD on ARM images

2022-07-22 Thread GitBox
nferrario commented on code in PR #117: URL: https://github.com/apache/flink-docker/pull/117#discussion_r927645868 ## 1.15/scala_2.12-java11-debian/docker-entrypoint.sh: ## @@ -91,7 +91,12 @@ prepare_configuration() { maybe_enable_jemalloc() { if [

[GitHub] [flink-docker] Myasuka commented on a diff in pull request #117: [FLINK-28057] Fix LD_PRELOAD on ARM images

2022-07-22 Thread GitBox
Myasuka commented on code in PR #117: URL: https://github.com/apache/flink-docker/pull/117#discussion_r927644004 ## 1.15/scala_2.12-java11-debian/docker-entrypoint.sh: ## @@ -91,7 +91,12 @@ prepare_configuration() { maybe_enable_jemalloc() { if [

[GitHub] [flink] rkhachatryan commented on pull request #20346: [FLINK-28647] Remove separate error handling and adjust documentation for CLAIM mode + RocksDB native savepoint

2022-07-22 Thread GitBox
rkhachatryan commented on PR #20346: URL: https://github.com/apache/flink/pull/20346#issuecomment-1192564645 Thanks for the review @fredia @dawidwys would you like to take a look as well? -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (FLINK-28390) Allows RocksDB to configure FIFO Compaction to reduce CPU overhead.

2022-07-22 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17570007#comment-17570007 ] Yun Tang commented on FLINK-28390: -- [~Ming Li] I don't think we should add such configurations in Flink

[GitHub] [flink] fredia commented on a diff in pull request #20103: [FLINK-28178][runtime-web] Show the delegated StateBackend and whethe…

2022-07-22 Thread GitBox
fredia commented on code in PR #20103: URL: https://github.com/apache/flink/pull/20103#discussion_r927635877 ## flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/job-checkpoints.component.html: ## @@ -551,15 +551,15 @@ -

[GitHub] [flink] amazhar1 commented on pull request #20327: [FLINK-28595][Connectors/kafka] KafkaSource should not read metadata of unmatched regex topics

2022-07-22 Thread GitBox
amazhar1 commented on PR #20327: URL: https://github.com/apache/flink/pull/20327#issuecomment-1192553353 I like it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (FLINK-28637) High vulnerability in flink-kubernetes-operator-1.1.0-shaded.jar

2022-07-22 Thread Jeesmon Jacob (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17570003#comment-17570003 ] Jeesmon Jacob commented on FLINK-28637: --- There is a new PR against OSDK to bump up okhttp version:

[jira] [Closed] (FLINK-28640) Let BlocklistDeclarativeSlotPool accept duplicate slot offers

2022-07-22 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu closed FLINK-28640. --- Resolution: Done Done via f6a22eaf99d4ba2ef03445bae54a0da7c39c4d1a > Let BlocklistDeclarativeSlotPool

[GitHub] [flink] zhuzhurk closed pull request #20341: [FLINK-28640][runtime] Let BlocklistDeclarativeSlotPool accept duplicate slot offers

2022-07-22 Thread GitBox
zhuzhurk closed pull request #20341: [FLINK-28640][runtime] Let BlocklistDeclarativeSlotPool accept duplicate slot offers URL: https://github.com/apache/flink/pull/20341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink] zhuzhurk commented on pull request #20341: [FLINK-28640][runtime] Let BlocklistDeclarativeSlotPool accept duplicate slot offers

2022-07-22 Thread GitBox
zhuzhurk commented on PR #20341: URL: https://github.com/apache/flink/pull/20341#issuecomment-1192544056 Merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] fredia commented on pull request #20346: [FLINK-28647] Remove separate error handling and adjust documentation for CLAIM mode + RocksDB native savepoint

2022-07-22 Thread GitBox
fredia commented on PR #20346: URL: https://github.com/apache/flink/pull/20346#issuecomment-1192540738 Thanks for the PR, LGTM(non-blinding). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink-web] gyfora commented on pull request #560: Kubernetes Operator Release 1.1.0

2022-07-22 Thread GitBox
gyfora commented on PR #560: URL: https://github.com/apache/flink-web/pull/560#issuecomment-1192537374 Thanks @mbalassi updated the post according to your suggestions :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink-kubernetes-operator] czy006 commented on pull request #308: [FLINK-28223] Add artifact-fetcher to the pod-template.yaml example

2022-07-22 Thread GitBox
czy006 commented on PR #308: URL: https://github.com/apache/flink-kubernetes-operator/pull/308#issuecomment-1192537029 @mbalassi sorry,i miss gamil. now on going do it,This will be completed in two days. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] flinkbot commented on pull request #20346: [FLINK-28647] Remove separate error handling and adjust documentation for CLAIM mode + RocksDB native savepoint

2022-07-22 Thread GitBox
flinkbot commented on PR #20346: URL: https://github.com/apache/flink/pull/20346#issuecomment-1192530151 ## CI report: * 1f802932319b3d68cfe4b02593ef714603acf1f5 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] luoyuxia commented on a diff in pull request #19727: [FLINK-27618][sql] Flink supports CUME_DIST function

2022-07-22 Thread GitBox
luoyuxia commented on code in PR #19727: URL: https://github.com/apache/flink/pull/19727#discussion_r927605133 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/generated/AggsHandleFunction.java: ## @@ -36,4 +36,10 @@ public interface

[GitHub] [flink] rkhachatryan closed pull request #20300: [WIP][FLINK-28597][state] Discard non-initial checkpoints without a delay

2022-07-22 Thread GitBox
rkhachatryan closed pull request #20300: [WIP][FLINK-28597][state] Discard non-initial checkpoints without a delay URL: https://github.com/apache/flink/pull/20300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] rkhachatryan commented on pull request #20300: [WIP][FLINK-28597][state] Discard non-initial checkpoints without a delay

2022-07-22 Thread GitBox
rkhachatryan commented on PR #20300: URL: https://github.com/apache/flink/pull/20300#issuecomment-119259 Superceded by #20313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] flinkbot commented on pull request #20345: [FLINK-28610][runtime] Enable speculative execution for sources

2022-07-22 Thread GitBox
flinkbot commented on PR #20345: URL: https://github.com/apache/flink/pull/20345#issuecomment-1192520232 ## CI report: * 155bb0b49452195dd01bad4772cf2e5692eed958 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-28647) Remove separate error handling and adjust documentation for CLAIM mode + RocksDB native savepoint

2022-07-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-28647: --- Labels: pull-request-available (was: ) > Remove separate error handling and adjust

[GitHub] [flink] rkhachatryan opened a new pull request, #20346: [FLINK-28647] Remove separate error handling and adjust documentation for CLAIM mode + RocksDB native savepoint

2022-07-22 Thread GitBox
rkhachatryan opened a new pull request, #20346: URL: https://github.com/apache/flink/pull/20346 ## What is the purpose of the change Please see ticket description (FLINK-28647). ## Brief changelog - update the docs (checkpoint folder **is** deleted but with a delay) -

[jira] [Updated] (FLINK-28610) Enable speculative execution of sources

2022-07-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-28610: --- Labels: pull-request-available (was: ) > Enable speculative execution of sources >

[GitHub] [flink] zhuzhurk opened a new pull request, #20345: [FLINK-28610][runtime] Enable speculative execution for sources

2022-07-22 Thread GitBox
zhuzhurk opened a new pull request, #20345: URL: https://github.com/apache/flink/pull/20345 ## What is the purpose of the change This PR enables speculative execution for sources and added IT cases for source speculation. ## Verifying this change - *Added integration

[jira] [Updated] (FLINK-28647) Remove separate error handling and adjust documentation for CLAIM mode + RocksDB native savepoint

2022-07-22 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan updated FLINK-28647: -- Description: After FLINK-25872, checkpoint folder deletion is not performed as long

[jira] [Created] (FLINK-28647) Remove separate error handling and adjust documentation for CLAIM mode + RocksDB native savepoint

2022-07-22 Thread Roman Khachatryan (Jira)
Roman Khachatryan created FLINK-28647: - Summary: Remove separate error handling and adjust documentation for CLAIM mode + RocksDB native savepoint Key: FLINK-28647 URL:

[jira] [Assigned] (FLINK-28610) Enable speculative execution of sources

2022-07-22 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu reassigned FLINK-28610: --- Assignee: Zhu Zhu > Enable speculative execution of sources >

[jira] [Closed] (FLINK-28146) Sync blocklist information between JobMaster & ResourceManager

2022-07-22 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu closed FLINK-28146. --- Fix Version/s: 1.16.0 Resolution: Done Done via 7b05a1b4c9a4ae664fb6b7c4bb85fb3ea6281505 > Sync

[jira] [Assigned] (FLINK-28640) Let BlocklistDeclarativeSlotPool accept duplicate slot offers

2022-07-22 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu reassigned FLINK-28640: --- Assignee: Lijie Wang > Let BlocklistDeclarativeSlotPool accept duplicate slot offers >

[GitHub] [flink] zhuzhurk closed pull request #20264: [FLINK-28146][runtime] Sync blocklist information between JobMaster & ResourceManager

2022-07-22 Thread GitBox
zhuzhurk closed pull request #20264: [FLINK-28146][runtime] Sync blocklist information between JobMaster & ResourceManager URL: https://github.com/apache/flink/pull/20264 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink] zhuzhurk commented on pull request #20264: [FLINK-28146][runtime] Sync blocklist information between JobMaster & ResourceManager

2022-07-22 Thread GitBox
zhuzhurk commented on PR #20264: URL: https://github.com/apache/flink/pull/20264#issuecomment-1192507409 Merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Closed] (FLINK-28586) Speculative execution for new sources

2022-07-22 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu closed FLINK-28586. --- Resolution: Done Done via 79d93f2512f6826baefb14c8dc9b59d419d7df0a 9af271f3108ce8af6b6972fabf5420b99e55fc71

[GitHub] [flink] zhuzhurk closed pull request #20299: [FLINK-28586] Enable speculative execution for new sources

2022-07-22 Thread GitBox
zhuzhurk closed pull request #20299: [FLINK-28586] Enable speculative execution for new sources URL: https://github.com/apache/flink/pull/20299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] zhuzhurk commented on pull request #20299: [FLINK-28586] Enable speculative execution for new sources

2022-07-22 Thread GitBox
zhuzhurk commented on PR #20299: URL: https://github.com/apache/flink/pull/20299#issuecomment-1192504215 Also verified with TPC-DS benchmarks on real cluster. Speculative execution is working and there is no suspicious error. Merging. -- This is an automated message from the Apache

[GitHub] [flink] liujiawinds commented on a diff in pull request #19844: [FLINK-27805][Connectors/ORC] bump orc version to 1.7.5

2022-07-22 Thread GitBox
liujiawinds commented on code in PR #19844: URL: https://github.com/apache/flink/pull/19844#discussion_r927579106 ## flink-formats/flink-orc/src/test/java/org/apache/flink/orc/writer/OrcBulkWriterTest.java: ## @@ -75,8 +78,105 @@ public void testOrcBulkWriter() throws Exception

[GitHub] [flink] liujiawinds commented on a diff in pull request #19844: [FLINK-27805][Connectors/ORC] bump orc version to 1.7.5

2022-07-22 Thread GitBox
liujiawinds commented on code in PR #19844: URL: https://github.com/apache/flink/pull/19844#discussion_r927578849 ## flink-formats/flink-sql-orc/src/main/resources/META-INF/NOTICE: ## @@ -6,13 +6,14 @@ The Apache Software Foundation (http://www.apache.org/). This project

[GitHub] [flink] liujiawinds commented on a diff in pull request #19844: [FLINK-27805][Connectors/ORC] bump orc version to 1.7.5

2022-07-22 Thread GitBox
liujiawinds commented on code in PR #19844: URL: https://github.com/apache/flink/pull/19844#discussion_r927578181 ## flink-formats/flink-orc/src/test/java/org/apache/flink/orc/writer/OrcBulkWriterTest.java: ## @@ -75,8 +78,105 @@ public void testOrcBulkWriter() throws Exception

[GitHub] [flink] liujiawinds commented on a diff in pull request #19844: [FLINK-27805][Connectors/ORC] bump orc version to 1.7.5

2022-07-22 Thread GitBox
liujiawinds commented on code in PR #19844: URL: https://github.com/apache/flink/pull/19844#discussion_r927577889 ## flink-formats/flink-orc/src/test/java/org/apache/flink/orc/writer/OrcBulkWriterTest.java: ## @@ -75,8 +78,105 @@ public void testOrcBulkWriter() throws Exception

[GitHub] [flink] liujiawinds commented on a diff in pull request #19844: [FLINK-27805][Connectors/ORC] bump orc version to 1.7.5

2022-07-22 Thread GitBox
liujiawinds commented on code in PR #19844: URL: https://github.com/apache/flink/pull/19844#discussion_r927577711 ## flink-formats/flink-orc/src/main/java/org/apache/flink/orc/writer/EncryptionProvider.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] lsyldliu commented on a diff in pull request #20252: [FLINK-28463][flink-sql-parser] Flink dialect supports CREATE TABLE AS SELECT(CTAS) syntax

2022-07-22 Thread GitBox
lsyldliu commented on code in PR #20252: URL: https://github.com/apache/flink/pull/20252#discussion_r927563895 ## flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl: ## @@ -1151,9 +1152,13 @@ SqlCreate SqlCreateTable(Span s, boolean replace, boolean

[GitHub] [flink] liujiawinds commented on a diff in pull request #19844: [FLINK-27805][Connectors/ORC] bump orc version to 1.7.5

2022-07-22 Thread GitBox
liujiawinds commented on code in PR #19844: URL: https://github.com/apache/flink/pull/19844#discussion_r927577474 ## flink-formats/flink-orc/src/test/java/org/apache/flink/orc/writer/OrcBulkWriterTest.java: ## @@ -46,16 +57,8 @@ public class OrcBulkWriterTest { private

[GitHub] [flink] luoyuxia commented on pull request #20211: [FLINK-28451][hive] Use UserCodeClassloader instead of the current thread's classloader to load function

2022-07-22 Thread GitBox
luoyuxia commented on PR #20211: URL: https://github.com/apache/flink/pull/20211#issuecomment-1192481882 > LGTM. I have appended a commit to fix a minor problem. If you don't have concerns, I will merge it when CI passed. Thanks. That's fine. I rebased master and fix the compile

[GitHub] [flink-web] mbalassi commented on a diff in pull request #560: Kubernetes Operator Release 1.1.0

2022-07-22 Thread GitBox
mbalassi commented on code in PR #560: URL: https://github.com/apache/flink-web/pull/560#discussion_r927546290 ## _posts/2022-07-25-release-kubernetes-operator-1.1.0.md: ## @@ -0,0 +1,114 @@ +--- +layout: post +title: "Apache Flink Kubernetes Operator 1.1.0 Release

[GitHub] [flink] leozhangsr commented on pull request #20234: [FLINK-28475] [Connector/kafka] Stopping offset can be 0

2022-07-22 Thread GitBox
leozhangsr commented on PR #20234: URL: https://github.com/apache/flink/pull/20234#issuecomment-1192461458 @PatrickRen waiting a review from you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] Tartarus0zm commented on pull request #20252: [FLINK-28463][flink-sql-parser] Flink dialect supports CREATE TABLE AS SELECT(CTAS) syntax

2022-07-22 Thread GitBox
Tartarus0zm commented on PR #20252: URL: https://github.com/apache/flink/pull/20252#issuecomment-1192460451 @beyond1920 @lsyldliu Thank you for your advice, I have updated the pr, please take a look again! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] Tartarus0zm commented on a diff in pull request #20252: [FLINK-28463][flink-sql-parser] Flink dialect supports CREATE TABLE AS SELECT(CTAS) syntax

2022-07-22 Thread GitBox
Tartarus0zm commented on code in PR #20252: URL: https://github.com/apache/flink/pull/20252#discussion_r927546446 ## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTableAs.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] wuchong commented on a diff in pull request #20211: [FLINK-28451][hive] Use UserCodeClassloader instead of the current thread's classloader to load function

2022-07-22 Thread GitBox
wuchong commented on code in PR #20211: URL: https://github.com/apache/flink/pull/20211#discussion_r927497910 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/HiveFunctionWrapper.java: ## @@ -127,13 +125,26 @@ public Class

[jira] [Comment Edited] (FLINK-28515) The files in local recovery directory hasn't be clean up properly after checkpoint abort

2022-07-22 Thread Jinzhong Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569936#comment-17569936 ] Jinzhong Li edited comment on FLINK-28515 at 7/22/22 10:38 AM: --- Thanks for

[jira] [Comment Edited] (FLINK-28515) The files in local recovery directory hasn't be clean up properly after checkpoint abort

2022-07-22 Thread Jinzhong Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569936#comment-17569936 ] Jinzhong Li edited comment on FLINK-28515 at 7/22/22 10:38 AM: --- Thanks for

[jira] [Comment Edited] (FLINK-28515) The files in local recovery directory hasn't be clean up properly after checkpoint abort

2022-07-22 Thread Jinzhong Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569936#comment-17569936 ] Jinzhong Li edited comment on FLINK-28515 at 7/22/22 10:36 AM: --- Thanks for

  1   2   >