[GitHub] [flink] X-czh commented on pull request #23264: Refactor @Test(expected) with assertThrows

2023-09-03 Thread via GitHub
X-czh commented on PR #23264: URL: https://github.com/apache/flink/pull/23264#issuecomment-1704648003 Hi @Taher-Ghaleb, thanks for your notice on Flink. If you would like to contribute to Flink, you should follow the [guideline](https://flink.apache.org/how-to-contribute/contribute-code/)

[GitHub] [flink] libenchao commented on a diff in pull request #22832: [FLINK-32396][jdbc-driver] Support timestamp and timestamp_ltz for jdbc driver and sql gateway

2023-09-03 Thread via GitHub
libenchao commented on code in PR #22832: URL: https://github.com/apache/flink/pull/22832#discussion_r1314446016 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/rest/serde/ResultInfo.java: ## @@ -64,12 +67,21 @@ public class ResultInfo {

[jira] [Commented] (FLINK-32782) Release Testing: Disable WAL in RocksDBWriteBatchWrapper by default

2023-09-03 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17761683#comment-17761683 ] Yun Tang commented on FLINK-32782: -- Same as I raised in FLINK-32783, why do we need to test this

[jira] [Commented] (FLINK-32783) Release Testing: Improve parallel download of RocksDB incremental state

2023-09-03 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17761682#comment-17761682 ] Yun Tang commented on FLINK-32783: -- Why do we need to test this internal improvement manually? From my

[jira] [Commented] (FLINK-33016) Invalid download url for Flink JDBC Driver page

2023-09-03 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17761680#comment-17761680 ] Benchao Li commented on FLINK-33016: The artifacts are only pushed to nexus after Flink is released.

[jira] [Created] (FLINK-33016) Invalid download url for Flink JDBC Driver page

2023-09-03 Thread xiangyu feng (Jira)
xiangyu feng created FLINK-33016: Summary: Invalid download url for Flink JDBC Driver page Key: FLINK-33016 URL: https://issues.apache.org/jira/browse/FLINK-33016 Project: Flink Issue Type:

[jira] [Commented] (FLINK-32802) Release Testing: Verify FLIP-291: Externalized Declarative Resource Management

2023-09-03 Thread ConradJam (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17761674#comment-17761674 ] ConradJam commented on FLINK-32802: --- I want to synchronize it. Currently, my local test results are as

[GitHub] [flink] wangzzu commented on pull request #23243: [FLINK-32846][runtime][JUnit5 Migration] The metrics package of flink-runtime module

2023-09-03 Thread via GitHub
wangzzu commented on PR #23243: URL: https://github.com/apache/flink/pull/23243#issuecomment-1704527997 @1996fanrui @Jiabao-Sun if you have time, can you help review this again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Updated] (FLINK-31757) Optimize Flink un-balanced tasks scheduling

2023-09-03 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] RocMarshal updated FLINK-31757: --- Labels: pull-request-available (was: pull-request-available stale-assigned) > Optimize Flink

[GitHub] [flink] wangzzu commented on a diff in pull request #22468: FLINK-31889: Add documentation for implementing/loading enrichers

2023-09-03 Thread via GitHub
wangzzu commented on code in PR #22468: URL: https://github.com/apache/flink/pull/22468#discussion_r1314383990 ## docs/content/docs/deployment/advanced/failure_enrichers.md: ## @@ -0,0 +1,93 @@ +--- +title: "Failure Enrichers" +nav-title: failure-enrichers +nav-parent_id:

[GitHub] [flink-ml] zhaozijun109 commented on a diff in pull request #253: [FLINK-33003] Support isolation forest algorithm in Flink ML

2023-09-03 Thread via GitHub
zhaozijun109 commented on code in PR #253: URL: https://github.com/apache/flink-ml/pull/253#discussion_r1314379507 ## flink-ml-lib/src/main/java/org/apache/flink/ml/anomalydetection/isolationforest/IsolationForest.java: ## @@ -0,0 +1,611 @@ +/* + * Licensed to the Apache

[GitHub] [flink-ml] zhaozijun109 commented on a diff in pull request #253: [FLINK-33003] Support isolation forest algorithm in Flink ML

2023-09-03 Thread via GitHub
zhaozijun109 commented on code in PR #253: URL: https://github.com/apache/flink-ml/pull/253#discussion_r1314378789 ## flink-ml-lib/src/main/java/org/apache/flink/ml/anomalydetection/isolationforest/IsolationForest.java: ## @@ -0,0 +1,611 @@ +/* + * Licensed to the Apache

[GitHub] [flink-ml] zhaozijun109 commented on a diff in pull request #253: [FLINK-33003] Support isolation forest algorithm in Flink ML

2023-09-03 Thread via GitHub
zhaozijun109 commented on code in PR #253: URL: https://github.com/apache/flink-ml/pull/253#discussion_r1314378326 ## flink-ml-lib/src/main/java/org/apache/flink/ml/anomalydetection/isolationforest/IsolationForest.java: ## @@ -0,0 +1,611 @@ +/* + * Licensed to the Apache

[GitHub] [flink-ml] zhaozijun109 commented on a diff in pull request #253: [FLINK-33003] Support isolation forest algorithm in Flink ML

2023-09-03 Thread via GitHub
zhaozijun109 commented on code in PR #253: URL: https://github.com/apache/flink-ml/pull/253#discussion_r1314376830 ## flink-ml-lib/src/main/java/org/apache/flink/ml/anomalydetection/isolationforest/IsolationForestModelData.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed to the

[GitHub] [flink-ml] zhaozijun109 commented on a diff in pull request #253: [FLINK-33003] Support isolation forest algorithm in Flink ML

2023-09-03 Thread via GitHub
zhaozijun109 commented on code in PR #253: URL: https://github.com/apache/flink-ml/pull/253#discussion_r1314376355 ## flink-ml-lib/src/main/java/org/apache/flink/ml/anomalydetection/isolationforest/IsolationForest.java: ## @@ -0,0 +1,611 @@ +/* + * Licensed to the Apache

[GitHub] [flink-ml] zhaozijun109 commented on a diff in pull request #253: [FLINK-33003] Support isolation forest algorithm in Flink ML

2023-09-03 Thread via GitHub
zhaozijun109 commented on code in PR #253: URL: https://github.com/apache/flink-ml/pull/253#discussion_r1314376152 ## flink-ml-lib/src/main/java/org/apache/flink/ml/anomalydetection/isolationforest/IsolationForest.java: ## @@ -0,0 +1,611 @@ +/* + * Licensed to the Apache

[GitHub] [flink-ml] zhaozijun109 commented on a diff in pull request #253: [FLINK-33003] Support isolation forest algorithm in Flink ML

2023-09-03 Thread via GitHub
zhaozijun109 commented on code in PR #253: URL: https://github.com/apache/flink-ml/pull/253#discussion_r1314375469 ## flink-ml-lib/src/main/java/org/apache/flink/ml/anomalydetection/isolationforest/IsolationForestParams.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache

[GitHub] [flink-ml] zhaozijun109 commented on a diff in pull request #253: [FLINK-33003] Support isolation forest algorithm in Flink ML

2023-09-03 Thread via GitHub
zhaozijun109 commented on code in PR #253: URL: https://github.com/apache/flink-ml/pull/253#discussion_r1314375629 ## flink-ml-lib/src/main/java/org/apache/flink/ml/anomalydetection/isolationforest/IsolationForestModel.java: ## @@ -0,0 +1,200 @@ +/* + * Licensed to the Apache

[GitHub] [flink-ml] zhaozijun109 commented on a diff in pull request #253: [FLINK-33003] Support isolation forest algorithm in Flink ML

2023-09-03 Thread via GitHub
zhaozijun109 commented on code in PR #253: URL: https://github.com/apache/flink-ml/pull/253#discussion_r1314374284 ## flink-ml-lib/src/main/java/org/apache/flink/ml/anomalydetection/isolationforest/IsolationForestParams.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache

[GitHub] [flink-ml] zhaozijun109 commented on a diff in pull request #253: [FLINK-33003] Support isolation forest algorithm in Flink ML

2023-09-03 Thread via GitHub
zhaozijun109 commented on code in PR #253: URL: https://github.com/apache/flink-ml/pull/253#discussion_r1314373790 ## flink-ml-lib/src/main/java/org/apache/flink/ml/anomalydetection/isolationforest/IsolationForestParams.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache

[GitHub] [flink-ml] zhaozijun109 commented on a diff in pull request #253: [FLINK-33003] Support isolation forest algorithm in Flink ML

2023-09-03 Thread via GitHub
zhaozijun109 commented on code in PR #253: URL: https://github.com/apache/flink-ml/pull/253#discussion_r1314372168 ## flink-ml-lib/src/main/java/org/apache/flink/ml/anomalydetection/isolationforest/IsolationForest.java: ## @@ -0,0 +1,611 @@ +/* + * Licensed to the Apache

[jira] [Updated] (FLINK-32755) Add quick start guide for Flink OLAP

2023-09-03 Thread Fang Yong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fang Yong updated FLINK-32755: -- Fix Version/s: 1.19.0 > Add quick start guide for Flink OLAP > >

[jira] [Closed] (FLINK-32755) Add quick start guide for Flink OLAP

2023-09-03 Thread Fang Yong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fang Yong closed FLINK-32755. - Resolution: Fixed Fixed by fbef3c22757a2352145599487beb84e02aaeb389 > Add quick start guide for Flink

[GitHub] [flink] FangYongs merged pull request #23328: [FLINK-32755][docs] Add doc for OLAP quickstart

2023-09-03 Thread via GitHub
FangYongs merged PR #23328: URL: https://github.com/apache/flink/pull/23328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] FangYongs commented on pull request #23328: [FLINK-32755][docs] Add doc for OLAP quickstart

2023-09-03 Thread via GitHub
FangYongs commented on PR #23328: URL: https://github.com/apache/flink/pull/23328#issuecomment-1704484615 Thanks @xiangyuf , LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (FLINK-32442) DownloadPipelineArtifact fails on AZP

2023-09-03 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-32442: --- Labels: auto-deprioritized-major test-stability (was: stale-major test-stability)

[jira] [Updated] (FLINK-28513) Flink Table API CSV streaming sink throws SerializedThrowable exception

2023-09-03 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-28513: --- Labels: pull-request-available stale-assigned (was: pull-request-available) I am the

[jira] [Updated] (FLINK-31242) Correct the definition of creating functions in the SQL client documentation

2023-09-03 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-31242: --- Labels: auto-deprioritized-minor pull-request-available (was: pull-request-available

[jira] [Updated] (FLINK-28915) Make application mode could support remote DFS schema(e.g. S3, OSS, HDFS, etc.)

2023-09-03 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-28915: --- Labels: pull-request-available stale-assigned (was: pull-request-available) I am the

[jira] [Updated] (FLINK-30629) ClientHeartbeatTest.testJobRunningIfClientReportHeartbeat is unstable

2023-09-03 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-30629: --- Labels: pull-request-available stale-assigned test-stability (was: pull-request-available

[jira] [Updated] (FLINK-32721) agg max/min supports char type

2023-09-03 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-32721: --- Labels: pull-request-available stale-assigned (was: pull-request-available) I am the

[jira] [Updated] (FLINK-31857) Support pluginable observers mechanism

2023-09-03 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-31857: --- Labels: pull-request-available stale-major (was: pull-request-available) I am the [Flink

[jira] [Updated] (FLINK-32445) BlobStore.closeAndCleanupAllData doesn't do any close action

2023-09-03 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-32445: --- Labels: auto-deprioritized-major starter (was: stale-major starter) Priority: Minor

[jira] [Updated] (FLINK-32565) Support cast from NUMBER to BYTES

2023-09-03 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-32565: --- Labels: pull-request-available stale-assigned (was: pull-request-available) I am the

[GitHub] [flink] zhangyy91 commented on a diff in pull request #23265: [FLINK-32853][runtime][JUnit5 Migration] The security, taskmanager an…

2023-09-03 Thread via GitHub
zhangyy91 commented on code in PR #23265: URL: https://github.com/apache/flink/pull/23265#discussion_r1314270371 ## flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java: ## @@ -540,9 +527,9 @@ public void testFailExternallyDuringInvoke() throws

[GitHub] [flink] zhangyy91 commented on a diff in pull request #23265: [FLINK-32853][runtime][JUnit5 Migration] The security, taskmanager an…

2023-09-03 Thread via GitHub
zhangyy91 commented on code in PR #23265: URL: https://github.com/apache/flink/pull/23265#discussion_r1314270221 ## flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskCancelAsyncProducerConsumerITCase.java: ## @@ -150,10 +147,11 @@ public void

[jira] [Commented] (FLINK-15922) Show "Warn - received late message for checkpoint" only when checkpoint actually expired

2023-09-03 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17761602#comment-17761602 ] Zakelly Lan commented on FLINK-15922: - This makes perfect sense. I'd like to take this. > Show

[jira] [Commented] (FLINK-12486) RocksDB State Backend docs don't explain that operator state is kept on heap

2023-09-03 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-12486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17761594#comment-17761594 ] Zakelly Lan commented on FLINK-12486: - Hi [~aitozi] , may I ask why the PR is closed.. >

[jira] [Commented] (FLINK-20886) Add the option to get a threaddump on checkpoint timeouts

2023-09-03 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17761591#comment-17761591 ] Zakelly Lan commented on FLINK-20886: - Hi [~yunta], I finished my PR for this issue. In current

[jira] [Updated] (FLINK-20886) Add the option to get a threaddump on checkpoint timeouts

2023-09-03 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan updated FLINK-20886: Priority: Minor (was: Not a Priority) > Add the option to get a threaddump on checkpoint

[jira] [Commented] (FLINK-22059) add a new option is rocksdb statebackend to enable job threads setting

2023-09-03 Thread xiaogang zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17761587#comment-17761587 ] xiaogang zhou commented on FLINK-22059: --- [~Zakelly] yes > add a new option is rocksdb

[jira] [Commented] (FLINK-32749) Sql gateway supports default catalog loaded by CatalogStore

2023-09-03 Thread xy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17761578#comment-17761578 ] xy commented on FLINK-32749: [~zjureel]  can i get your wechar id,some problem want to talk with you, best

[GitHub] [flink] asha-boyapati commented on pull request #23298: [FLINK-32963][Test] Remove flakiness from testKeyedMapStateStateMigration

2023-09-03 Thread via GitHub
asha-boyapati commented on PR #23298: URL: https://github.com/apache/flink/pull/23298#issuecomment-1704040989 I want to add that this PR not only removes flakiness from the test mentioned in the title and description