[GitHub] [flink] JunRuiLee commented on pull request #23429: test

2023-09-16 Thread via GitHub


JunRuiLee commented on PR #23429:
URL: https://github.com/apache/flink/pull/23429#issuecomment-1722367758

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink] JunRuiLee closed pull request #23420: test

2023-09-16 Thread via GitHub


JunRuiLee closed pull request #23420: test
URL: https://github.com/apache/flink/pull/23420


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (FLINK-30519) Add e2e tests for operator dynamic config

2023-09-16 Thread Flink Jira Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-30519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flink Jira Bot updated FLINK-30519:
---
Labels: stale-assigned stale-critical starter  (was: stale-assigned starter)

I am the [Flink Jira Bot|https://github.com/apache/flink-jira-bot/] and I help 
the community manage its development. I see this issues has been marked as 
Critical but is unassigned and neither itself nor its Sub-Tasks have been 
updated for 14 days. I have gone ahead and marked it "stale-critical". If this 
ticket is critical, please either assign yourself or give an update. 
Afterwards, please remove the label or in 7 days the issue will be 
deprioritized.


> Add e2e tests for operator dynamic config
> -
>
> Key: FLINK-30519
> URL: https://issues.apache.org/jira/browse/FLINK-30519
> Project: Flink
>  Issue Type: Technical Debt
>  Components: Kubernetes Operator
>Reporter: Gyula Fora
>Priority: Critical
>  Labels: stale-assigned, stale-critical, starter
>
> The dynamic config feature is currently not covered by e2e tests and is 
> subject to accidental regressions, as shown in:
> https://issues.apache.org/jira/browse/FLINK-30329
> We should add an e2e test that covers this



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (FLINK-32522) Kafka connector should depend on commons-collections instead of inherit from flink

2023-09-16 Thread Flink Jira Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-32522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flink Jira Bot updated FLINK-32522:
---
  Labels: auto-deprioritized-major pull-request-available  (was: 
pull-request-available stale-major)
Priority: Minor  (was: Major)

This issue was labeled "stale-major" 7 days ago and has not received any 
updates so it is being deprioritized. If this ticket is actually Major, please 
raise the priority and ask a committer to assign you the issue or revive the 
public discussion.


> Kafka connector should depend on commons-collections instead of inherit from 
> flink
> --
>
> Key: FLINK-32522
> URL: https://issues.apache.org/jira/browse/FLINK-32522
> Project: Flink
>  Issue Type: Improvement
>  Components: Connectors / Kafka
>Affects Versions: 1.17.1
>Reporter: Ran Tao
>Priority: Minor
>  Labels: auto-deprioritized-major, pull-request-available
> Attachments: image-2023-07-03-20-15-47-608.png, 
> image-2023-07-03-20-16-03-031.png
>
>
> Currently, externalized sql connector rely on flink main repo. but flink main 
> repo has many test cases(especially in flink-python) reference 
> flink-sql-kafka-connector.
> If we change the dependencies(e.g.  commons-collections) in flink main repo, 
> it cause exception:
> !image-2023-07-03-20-15-47-608.png!
>  
> !https://user-images.githubusercontent.com/11287509/250120522-6b096a4f-83f0-4287-b7ad-d46b9371de4c.png!
>  
> So must add this dependency explicitly. Otherwise, it will cause external 
> connectors block the upgrade of flink main. Connectors shouldn't rely on 
> dependencies that may or may not be
> available in Flink itself. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-26088) Add Elasticsearch 8.0 support

2023-09-16 Thread Matheus Felisberto (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-26088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766017#comment-17766017
 ] 

Matheus Felisberto commented on FLINK-26088:


Hi everyone, I hope you are well.

 

I just finished writing tests and marked the pull request as ready to review.

I have working hours dedicated to this project in the following weeks to 
address implementation issues or suggestions from the reviewers.

I would appreciate some guidance on how to create the documentation, and if 
makes sense we can create a subtask for that, so I don't block the project 
progress.

 

I'm looking forward to your feedback :)

> Add Elasticsearch 8.0 support
> -
>
> Key: FLINK-26088
> URL: https://issues.apache.org/jira/browse/FLINK-26088
> Project: Flink
>  Issue Type: Improvement
>  Components: Connectors / ElasticSearch
>Reporter: Yuhao Bi
>Assignee: Matheus Felisberto
>Priority: Major
>  Labels: pull-request-available, stale-assigned
>
> Since Elasticsearch 8.0 is officially released, I think it's time to consider 
> adding es8 connector support.
> The High Level REST Client we used for connection [is marked deprecated in es 
> 7.15.0|https://www.elastic.co/guide/en/elasticsearch/client/java-rest/current/java-rest-high.html].
>  Maybe we can migrate to use the new [Java API 
> Client|https://www.elastic.co/guide/en/elasticsearch/client/java-api-client/8.0/index.html]
>  at this time.
> Elasticsearch8.0 release note: 
> [https://www.elastic.co/guide/en/elasticsearch/reference/8.0/release-notes-8.0.0.html]
> release highlights: 
> [https://www.elastic.co/guide/en/elasticsearch/reference/8.0/release-highlights.html]
> REST API compatibility: 
> https://www.elastic.co/guide/en/elasticsearch/reference/8.0/rest-api-compatibility.html



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [flink-connector-elasticsearch] mtfelisb commented on pull request #53: [FLINK-26088][Connectors/ElasticSearch] Add Elasticsearch 8.0 support

2023-09-16 Thread via GitHub


mtfelisb commented on PR #53:
URL: 
https://github.com/apache/flink-connector-elasticsearch/pull/53#issuecomment-1722311553

   Guys, I wrote a bunch of tests heavily inspired by 
https://github.com/apache/flink-connector-opensearch/pull/5 since they have 
very similar implementations. Thanks @reta for sharing, it helped a lot!
   I need to create the documentation and would appreciate some guidance on how 
to generate that.
   
   I'm looking forward to your feedback :) 
   cc @MartijnVisser @reswqa 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink] Jiabao-Sun commented on pull request #23200: [FLINK-32850][flink-runtime][JUnit5 Migration] Module: The io package of flink-runtime

2023-09-16 Thread via GitHub


Jiabao-Sun commented on PR #23200:
URL: https://github.com/apache/flink/pull/23200#issuecomment-1722273836

   Hi @reswqa, could you help review this PR when you have time?
   Many thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #23429: test

2023-09-16 Thread via GitHub


flinkbot commented on PR #23429:
URL: https://github.com/apache/flink/pull/23429#issuecomment-1722243119

   
   ## CI report:
   
   * 6bfa6a72d3191544cb7e94375d935cf0bcc2293d UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink] JunRuiLee opened a new pull request, #23429: test

2023-09-16 Thread via GitHub


JunRuiLee opened a new pull request, #23429:
URL: https://github.com/apache/flink/pull/23429

   run ci


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink-connector-aws] Samrat002 closed pull request #97: [POC]Flink Connector Redshift

2023-09-16 Thread via GitHub


Samrat002 closed pull request #97: [POC]Flink Connector Redshift
URL: https://github.com/apache/flink-connector-aws/pull/97


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink-connector-aws] Samrat002 opened a new pull request, #97: [POC]Flink Connector Redshift

2023-09-16 Thread via GitHub


Samrat002 opened a new pull request, #97:
URL: https://github.com/apache/flink-connector-aws/pull/97

   
   
   ## Purpose of the change
   
   *For example: Implements the Table API for the Kinesis Source.*
   
   ## Verifying this change
   
   Please make sure both new and modified tests in this PR follows the 
conventions defined in our code quality guide: 
https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe 
tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   - *Added integration tests for end-to-end deployment*
   - *Added unit tests*
   - *Manually verified by running the Kinesis connector on a local Flink 
cluster.*
   
   ## Significant changes
   *(Please check any boxes [x] if the answer is "yes". You can first publish 
the PR and check them afterwards, for convenience.)*
   - [ ] Dependencies have been added or upgraded
   - [ ] Public API has been changed (Public API is any class annotated with 
`@Public(Evolving)`)
   - [ ] Serializers have been changed
   - [ ] New feature has been introduced
 - If yes, how is this documented? (not applicable / docs / JavaDocs / not 
documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #23428: [FLINK-33095] Job jar issue should be reported as BAD_REQUEST instead of INTERNAL_SERVER_ERROR.

2023-09-16 Thread via GitHub


flinkbot commented on PR #23428:
URL: https://github.com/apache/flink/pull/23428#issuecomment-1722170441

   
   ## CI report:
   
   * 87add303df04bf86b615e4b01ad865438f91292f UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (FLINK-33095) Job jar related issue should be reported as BAD_REQUEST instead of INTERNAL_SERVER_ERROR

2023-09-16 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-33095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated FLINK-33095:
---
Labels: pull-request-available  (was: )

> Job jar related issue should be reported as BAD_REQUEST instead of 
> INTERNAL_SERVER_ERROR
> 
>
> Key: FLINK-33095
> URL: https://issues.apache.org/jira/browse/FLINK-33095
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / REST
>Affects Versions: 1.16.0
>Reporter: Surendra Singh Lilhore
>Priority: Major
>  Labels: pull-request-available
> Attachments: image-2023-09-16-13-20-15-052.png, 
> image-2023-09-16-13-21-24-634.png
>
>
> When submitting a job with incorrect parameters, such as an invalid entry 
> class, the current response is an internal server error.
> To enhance the user experience and consistency, it is recommended to throw a 
> Rest exception and return a BAD_REQUEST response code in such cases.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [flink] surendralilhore opened a new pull request, #23428: [FLINK-33095] Job jar issue should be reported as BAD_REQUEST instead of INTERNAL_SERVER_ERROR.

2023-09-16 Thread via GitHub


surendralilhore opened a new pull request, #23428:
URL: https://github.com/apache/flink/pull/23428

   When submitting a job with incorrect parameters, such as an invalid entry 
class, the current response is an internal server error.
   
   To enhance the user experience and consistency, it is recommended to throw a 
Rest exception and return a BAD_REQUEST response code in such cases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (FLINK-33095) Job jar related issue should be reported as BAD_REQUEST instead of INTERNAL_SERVER_ERROR

2023-09-16 Thread Surendra Singh Lilhore (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-33095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Surendra Singh Lilhore updated FLINK-33095:
---
Attachment: image-2023-09-16-13-21-24-634.png

> Job jar related issue should be reported as BAD_REQUEST instead of 
> INTERNAL_SERVER_ERROR
> 
>
> Key: FLINK-33095
> URL: https://issues.apache.org/jira/browse/FLINK-33095
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / REST
>Affects Versions: 1.16.0
>Reporter: Surendra Singh Lilhore
>Priority: Major
> Attachments: image-2023-09-16-13-20-15-052.png, 
> image-2023-09-16-13-21-24-634.png
>
>
> When submitting a job with incorrect parameters, such as an invalid entry 
> class, the current response is an internal server error.
> To enhance the user experience and consistency, it is recommended to throw a 
> Rest exception and return a BAD_REQUEST response code in such cases.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-33095) Job jar related issue should be reported as BAD_REQUEST instead of INTERNAL_SERVER_ERROR

2023-09-16 Thread Surendra Singh Lilhore (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-33095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17765922#comment-17765922
 ] 

Surendra Singh Lilhore commented on FLINK-33095:


Current response from server :

!image-2023-09-16-13-20-15-052.png!

==

It should be something like this :

!image-2023-09-16-13-21-24-634.png!

 

> Job jar related issue should be reported as BAD_REQUEST instead of 
> INTERNAL_SERVER_ERROR
> 
>
> Key: FLINK-33095
> URL: https://issues.apache.org/jira/browse/FLINK-33095
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / REST
>Affects Versions: 1.16.0
>Reporter: Surendra Singh Lilhore
>Priority: Major
> Attachments: image-2023-09-16-13-20-15-052.png, 
> image-2023-09-16-13-21-24-634.png
>
>
> When submitting a job with incorrect parameters, such as an invalid entry 
> class, the current response is an internal server error.
> To enhance the user experience and consistency, it is recommended to throw a 
> Rest exception and return a BAD_REQUEST response code in such cases.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (FLINK-33095) Job jar related issue should be reported as BAD_REQUEST instead of INTERNAL_SERVER_ERROR

2023-09-16 Thread Surendra Singh Lilhore (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-33095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Surendra Singh Lilhore updated FLINK-33095:
---
Attachment: image-2023-09-16-13-20-15-052.png

> Job jar related issue should be reported as BAD_REQUEST instead of 
> INTERNAL_SERVER_ERROR
> 
>
> Key: FLINK-33095
> URL: https://issues.apache.org/jira/browse/FLINK-33095
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / REST
>Affects Versions: 1.16.0
>Reporter: Surendra Singh Lilhore
>Priority: Major
> Attachments: image-2023-09-16-13-20-15-052.png
>
>
> When submitting a job with incorrect parameters, such as an invalid entry 
> class, the current response is an internal server error.
> To enhance the user experience and consistency, it is recommended to throw a 
> Rest exception and return a BAD_REQUEST response code in such cases.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (FLINK-33095) Job jar related issue should be reported as BAD_REQUEST instead of INTERNAL_SERVER_ERROR

2023-09-16 Thread Surendra Singh Lilhore (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-33095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Surendra Singh Lilhore updated FLINK-33095:
---
Attachment: (was: image-2023-09-16-13-17-14-869.png)

> Job jar related issue should be reported as BAD_REQUEST instead of 
> INTERNAL_SERVER_ERROR
> 
>
> Key: FLINK-33095
> URL: https://issues.apache.org/jira/browse/FLINK-33095
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / REST
>Affects Versions: 1.16.0
>Reporter: Surendra Singh Lilhore
>Priority: Major
>
> When submitting a job with incorrect parameters, such as an invalid entry 
> class, the current response is an internal server error.
> To enhance the user experience and consistency, it is recommended to throw a 
> Rest exception and return a BAD_REQUEST response code in such cases.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (FLINK-33095) Job jar related issue should be reported as BAD_REQUEST instead of INTERNAL_SERVER_ERROR

2023-09-16 Thread Surendra Singh Lilhore (Jira)
Surendra Singh Lilhore created FLINK-33095:
--

 Summary: Job jar related issue should be reported as BAD_REQUEST 
instead of INTERNAL_SERVER_ERROR
 Key: FLINK-33095
 URL: https://issues.apache.org/jira/browse/FLINK-33095
 Project: Flink
  Issue Type: Bug
  Components: Runtime / REST
Affects Versions: 1.16.0
Reporter: Surendra Singh Lilhore


When submitting a job with incorrect parameters, such as an invalid entry 
class, the current response is an internal server error.

To enhance the user experience and consistency, it is recommended to throw a 
Rest exception and return a BAD_REQUEST response code in such cases.

 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (FLINK-33095) Job jar related issue should be reported as BAD_REQUEST instead of INTERNAL_SERVER_ERROR

2023-09-16 Thread Surendra Singh Lilhore (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-33095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Surendra Singh Lilhore updated FLINK-33095:
---
Attachment: (was: image-2023-09-16-13-17-49-945.png)

> Job jar related issue should be reported as BAD_REQUEST instead of 
> INTERNAL_SERVER_ERROR
> 
>
> Key: FLINK-33095
> URL: https://issues.apache.org/jira/browse/FLINK-33095
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / REST
>Affects Versions: 1.16.0
>Reporter: Surendra Singh Lilhore
>Priority: Major
>
> When submitting a job with incorrect parameters, such as an invalid entry 
> class, the current response is an internal server error.
> To enhance the user experience and consistency, it is recommended to throw a 
> Rest exception and return a BAD_REQUEST response code in such cases.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)