Re: [PR] [FLINK-33737][Scheduler] Merge multiple Exceptions into one attempt for exponential-delay restart-strategy [flink]

2023-12-29 Thread via GitHub
RocMarshal commented on code in PR #23867: URL: https://github.com/apache/flink/pull/23867#discussion_r1438460593 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/ExponentialDelayRestartBackoffTimeStrategy.java: ## Review Comment: @1996fanrui

Re: [PR] [FLINK-33737][Scheduler] Merge multiple Exceptions into one attempt for exponential-delay restart-strategy [flink]

2023-12-29 Thread via GitHub
1996fanrui commented on code in PR #23867: URL: https://github.com/apache/flink/pull/23867#discussion_r1438458380 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/ExponentialDelayRestartBackoffTimeStrategy.java: ## Review Comment: Thanks

Re: [PR] [FLINK-33737][Scheduler] Merge multiple Exceptions into one attempt for exponential-delay restart-strategy [flink]

2023-12-29 Thread via GitHub
RocMarshal commented on code in PR #23867: URL: https://github.com/apache/flink/pull/23867#discussion_r1438455564 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/ExponentialDelayRestartBackoffTimeStrategy.java: ## Review Comment: how about

[jira] [Updated] (FLINK-33959) Unstable test case ChangelogRecoveryITCase.testMaterialization on 1.17 release branch

2023-12-29 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] RocMarshal updated FLINK-33959: --- Summary: Unstable test case ChangelogRecoveryITCase.testMaterialization on 1.17 release branch

[jira] [Resolved] (FLINK-33947) Fix bugs about prefix in DelegatingConfiguration

2023-12-29 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-33947. - Resolution: Fixed > Fix bugs about prefix in DelegatingConfiguration >

[jira] [Comment Edited] (FLINK-33947) Fix bugs about prefix in DelegatingConfiguration

2023-12-29 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801114#comment-17801114 ] Rui Fan edited comment on FLINK-33947 at 12/29/23 3:19 PM: --- Merged to

Re: [PR] [FLINK-33947][configuration] Fix bugs about prefix attribute in the DelegatingConfiguration class. [flink]

2023-12-29 Thread via GitHub
1996fanrui merged PR #24011: URL: https://github.com/apache/flink/pull/24011 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-33932) Support retry mechanism for rocksdb uploader

2023-12-29 Thread xiangyu feng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801162#comment-17801162 ] xiangyu feng commented on FLINK-33932: -- [~martijnvisser] AFAIK, this retry is not about "retry"

[jira] [Comment Edited] (FLINK-33932) Support retry mechanism for rocksdb uploader

2023-12-29 Thread xiangyu feng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800258#comment-17800258 ] xiangyu feng edited comment on FLINK-33932 at 12/29/23 12:24 PM: - Hi

Re: [PR] [FLINK-33935][checkpoint] Improve the default value logic related to `execution.checkpointing.tolerable-failed-checkpoints` and `state.backend.type` [flink]

2023-12-29 Thread via GitHub
1996fanrui commented on code in PR #23987: URL: https://github.com/apache/flink/pull/23987#discussion_r1438177364 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java: ## @@ -1040,8 +1041,9 @@ public void

[jira] [Commented] (FLINK-33959) Unstable test case

2023-12-29 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801150#comment-17801150 ] Rui Fan commented on FLINK-33959: - Hi [~masteryhx] [~Feifan Wang] ,  the

[jira] [Updated] (FLINK-33959) Unstable test case

2023-12-29 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-33959: Description:

Re: [PR] [FLINK-33947][configuration] Fix bugs about prefix attribute in the DelegatingConfiguration class. [flink]

2023-12-29 Thread via GitHub
RocMarshal commented on PR #24011: URL: https://github.com/apache/flink/pull/24011#issuecomment-1871990581 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-33959) Unstable test case

2023-12-29 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801149#comment-17801149 ] RocMarshal commented on FLINK-33959: Hi, could someone help to check it ? Thank you very much :) >

[jira] [Updated] (FLINK-33959) Unstable test case

2023-12-29 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] RocMarshal updated FLINK-33959: --- Attachment: image-2023-12-29-19-51-35-996.png > Unstable test case > --- > >

[jira] [Updated] (FLINK-33959) Unstable test case

2023-12-29 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] RocMarshal updated FLINK-33959: --- Description:

[jira] [Created] (FLINK-33959) Unstable test case

2023-12-29 Thread RocMarshal (Jira)
RocMarshal created FLINK-33959: -- Summary: Unstable test case Key: FLINK-33959 URL: https://issues.apache.org/jira/browse/FLINK-33959 Project: Flink Issue Type: Bug Components: Tests

[jira] [Updated] (FLINK-33959) Unstable test case

2023-12-29 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] RocMarshal updated FLINK-33959: --- Description:

[jira] [Commented] (FLINK-24379) Support AWS Glue Schema Registry Avro for Table API

2023-12-29 Thread Lorenzo Nicora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801142#comment-17801142 ] Lorenzo Nicora commented on FLINK-24379: I picked up the work and submitted a PR to

Re: [PR] [FLINK-24379][Formats] Avro Glue Schema Registry table format [flink-connector-aws]

2023-12-29 Thread via GitHub
boring-cyborg[bot] commented on PR #122: URL: https://github.com/apache/flink-connector-aws/pull/122#issuecomment-1871969671 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is

[PR] [FLINK-24379][Formats] Avro Glue Schema Registry table format [flink-connector-aws]

2023-12-29 Thread via GitHub
nicusX opened a new pull request, #122: URL: https://github.com/apache/flink-connector-aws/pull/122 ## Purpose of the change Implement Table API support for Avro with AWS Glue Schema Registry ## Verifying this change - Added unit tests - Manually verified by running a

Re: [PR] [FLINK-33935][checkpoint] Improve the default value logic related to `execution.checkpointing.tolerable-failed-checkpoints` and `state.backend.type` [flink]

2023-12-29 Thread via GitHub
Zakelly commented on code in PR #23987: URL: https://github.com/apache/flink/pull/23987#discussion_r1438117996 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java: ## @@ -1040,8 +1041,9 @@ public void

Re: [PR] [FLINK-33935][checkpoint] Improve the default value logic related to `execution.checkpointing.tolerable-failed-checkpoints` and `state.backend.type` [flink]

2023-12-29 Thread via GitHub
Zakelly commented on code in PR #23987: URL: https://github.com/apache/flink/pull/23987#discussion_r1438117996 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java: ## @@ -1040,8 +1041,9 @@ public void

[jira] [Comment Edited] (FLINK-33947) Fix bugs about prefix in DelegatingConfiguration

2023-12-29 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801114#comment-17801114 ] Rui Fan edited comment on FLINK-33947 at 12/29/23 9:04 AM: --- Merged to

[jira] [Commented] (FLINK-33950) Update max aggregate functions to new type system

2023-12-29 Thread Jacky Lau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801120#comment-17801120 ] Jacky Lau commented on FLINK-33950: --- hi [~martijnvisser] [~twalthr]  the reason of  the ci of my pr

Re: [PR] [FLINK-33947][configuration] Fix bugs about prefix attribute in the DelegatingConfiguration class. [flink]

2023-12-29 Thread via GitHub
1996fanrui merged PR #24010: URL: https://github.com/apache/flink/pull/24010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33792] Generate the same code for the same logic [flink]

2023-12-29 Thread via GitHub
zoudan commented on PR #23984: URL: https://github.com/apache/flink/pull/23984#issuecomment-1871831781 @libenchao CI is passed, please take a look when you have time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use