Re: [PR] [Flink 32701] [cep] Fix CEP Operator Memory Leak Issue [flink]

2024-01-20 Thread via GitHub
pdream17 commented on PR #24084: URL: https://github.com/apache/flink/pull/24084#issuecomment-1902191249 @MartijnVisser Its done and CI phase is success as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]

2024-01-20 Thread via GitHub
X-czh commented on PR #24133: URL: https://github.com/apache/flink/pull/24133#issuecomment-1902132296 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-34174][runtime] Remove SlotMatchingStrategy related logic [flink]

2024-01-20 Thread via GitHub
flinkbot commented on PR #24158: URL: https://github.com/apache/flink/pull/24158#issuecomment-1902119044 ## CI report: * d6ee9757bba4a976747a4c4a5a15f97107982fbe UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-34174) Remove SlotMatchingStrategy related logic

2024-01-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34174: --- Labels: pull-request-available (was: ) > Remove SlotMatchingStrategy related logic >

[PR] [FLINK-34174][runtime] Remove SlotMatchingStrategy related logic [flink]

2024-01-20 Thread via GitHub
RocMarshal opened a new pull request, #24158: URL: https://github.com/apache/flink/pull/24158 ## What is the purpose of the change Remove SlotMatchingStrategy related logic ## Verifying this change This change is a trivial rework / code cleanup without

Re: [PR] [Draft] Change the default conf file to standard yaml file. [flink]

2024-01-20 Thread via GitHub
flinkbot commented on PR #24157: URL: https://github.com/apache/flink/pull/24157#issuecomment-1902116478 ## CI report: * aeb74d31fb0b5fe505e85f3f75113ae8a5d834a1 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [Draft] Change the default conf file to standard yaml file. [flink]

2024-01-20 Thread via GitHub
JunRuiLee opened a new pull request, #24157: URL: https://github.com/apache/flink/pull/24157 [Draft] Change the default conf file to standard yaml file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-20 Thread via GitHub
davidradl commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1460466435 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcRowDataLookupFunction.java: ## @@ -116,6 +124,15 @@ public void

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-20 Thread via GitHub
davidradl commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1460463528 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcTablePlanTest.java: ## @@ -70,6 +98,51 @@ public void testFilterPushdown()

[jira] [Created] (FLINK-34174) Remove SlotMatchingStrategy related logic

2024-01-20 Thread RocMarshal (Jira)
RocMarshal created FLINK-34174: -- Summary: Remove SlotMatchingStrategy related logic Key: FLINK-34174 URL: https://issues.apache.org/jira/browse/FLINK-34174 Project: Flink Issue Type: Technical

Re: [PR] [FLINK-33768] Support dynamic source parallelism inference for batch jobs [flink]

2024-01-20 Thread via GitHub
SinBex commented on PR #24087: URL: https://github.com/apache/flink/pull/24087#issuecomment-1902104169 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-30935][connector/kafka] Add kafka serializers version check when using SimpleVersionedSerializer [flink-connector-kafka]

2024-01-20 Thread via GitHub
chucheng92 commented on PR #10: URL: https://github.com/apache/flink-connector-kafka/pull/10#issuecomment-1902035620 > @chucheng92 Can you please rebase your PR? Yes, I have rebased it and passed ci. If you have time, pls help to review it again. thanks a lot. -- This is an