Re: [PR] [FLINK-34058][table] Support optional parameters for named parameters [flink]

2024-01-26 Thread via GitHub
hackergin commented on code in PR #24183: URL: https://github.com/apache/flink/pull/24183#discussion_r1468374197 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/StringCallGen.scala: ## @@ -237,6 +238,9 @@ object StringCallGen {

Re: [PR] [FLINK-34058][table] Support optional parameters for named parameters [flink]

2024-01-26 Thread via GitHub
hackergin commented on code in PR #24183: URL: https://github.com/apache/flink/pull/24183#discussion_r1468374158 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/extraction/TypeInferenceExtractor.java: ## @@ -286,6 +305,15 @@ private static void

Re: [PR] [FLINK-34058][table] Support optional parameters for named parameters [flink]

2024-01-26 Thread via GitHub
hackergin commented on code in PR #24183: URL: https://github.com/apache/flink/pull/24183#discussion_r1468373906 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/ExprCodeGenerator.scala: ## @@ -465,20 +467,38 @@ class

Re: [PR] [FLINK-34058][table] Support optional parameters for named parameters [flink]

2024-01-26 Thread via GitHub
hackergin commented on code in PR #24183: URL: https://github.com/apache/flink/pull/24183#discussion_r1468373785 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/extraction/FunctionTemplate.java: ## @@ -194,14 +194,17 @@ private static T

Re: [PR] [FLINK-34251][core] ClosureCleaner to include reference classes for non-serialization exception [flink]

2024-01-26 Thread via GitHub
flinkbot commented on PR #24205: URL: https://github.com/apache/flink/pull/24205#issuecomment-1913010923 ## CI report: * 154e41a43c45a2bb59f0b1a4af37e7652434f8b7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-34251) ClosureCleaner to include reference classes for non-serialization exception

2024-01-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34251: --- Labels: pull-request-available (was: ) > ClosureCleaner to include reference classes for

[PR] [FLINK-34251][core] ClosureCleaner to include reference classes for non-serialization exception [flink]

2024-01-26 Thread via GitHub
liuml07 opened a new pull request, #24205: URL: https://github.com/apache/flink/pull/24205 ## What is the purpose of the change Currently the ClosureCleaner throws exception if {{checkSerializable} is enabled while some object is non-serializable. It includes the

[jira] [Created] (FLINK-34251) ClosureCleaner to include reference classes for non-serialization exception

2024-01-26 Thread Mingliang Liu (Jira)
Mingliang Liu created FLINK-34251: - Summary: ClosureCleaner to include reference classes for non-serialization exception Key: FLINK-34251 URL: https://issues.apache.org/jira/browse/FLINK-34251

[jira] [Updated] (FLINK-34251) ClosureCleaner to include reference classes for non-serialization exception

2024-01-26 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated FLINK-34251: -- Priority: Minor (was: Major) > ClosureCleaner to include reference classes for

[jira] [Commented] (FLINK-34246) Allow only archive failed job to history server

2024-01-26 Thread Wencong Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811468#comment-17811468 ] Wencong Liu commented on FLINK-34246: - Thanks [~qingwei91], for suggesting this. Are you suggesting

[jira] [Commented] (FLINK-33297) FLIP-366: Support standard YAML for FLINK configuration

2024-01-26 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811466#comment-17811466 ] lincoln lee commented on FLINK-33297: - [~JunRuiLi] Thank you for the update. > FLIP-366: Support

[jira] [Created] (FLINK-34250) Add formats options to docs

2024-01-26 Thread Zhenqiu Huang (Jira)
Zhenqiu Huang created FLINK-34250: - Summary: Add formats options to docs Key: FLINK-34250 URL: https://issues.apache.org/jira/browse/FLINK-34250 Project: Flink Issue Type: Improvement

Re: [PR] [FLINK-34249][runtime] Remove DefaultSlotTracker related logic. [flink]

2024-01-26 Thread via GitHub
flinkbot commented on PR #24204: URL: https://github.com/apache/flink/pull/24204#issuecomment-1912942087 ## CI report: * 026ba82a56b2171f6e07cb870e63a7fddb8f5e51 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-34249) Remove DefaultSlotTracker related logic.

2024-01-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34249: --- Labels: pull-request-available (was: ) > Remove DefaultSlotTracker related logic. >

[PR] [FLINK-34249][runtime] Remove DefaultSlotTracker related logic. [flink]

2024-01-26 Thread via GitHub
RocMarshal opened a new pull request, #24204: URL: https://github.com/apache/flink/pull/24204 ## What is the purpose of the change Remove DefaultSlotTracker related logic. The main reason for initiating this ticket is

[jira] [Commented] (FLINK-34249) Remove DefaultSlotTracker related logic.

2024-01-26 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811463#comment-17811463 ] RocMarshal commented on FLINK-34249: pre step: https://issues.apache.org/jira/browse/FLINK-34174

[jira] [Created] (FLINK-34249) Remove DefaultSlotTracker related logic.

2024-01-26 Thread RocMarshal (Jira)
RocMarshal created FLINK-34249: -- Summary: Remove DefaultSlotTracker related logic. Key: FLINK-34249 URL: https://issues.apache.org/jira/browse/FLINK-34249 Project: Flink Issue Type: Technical

Re: [PR] [FLINK-34248] Implement restore tests for changelog normalize node [flink]

2024-01-26 Thread via GitHub
flinkbot commented on PR #24203: URL: https://github.com/apache/flink/pull/24203#issuecomment-1912908978 ## CI report: * 776ffbde30fa754b06a2858fa572800c5edd8ffa UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-34248) Implement restore tests for ChangelogNormalize node

2024-01-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34248: --- Labels: pull-request-available (was: ) > Implement restore tests for ChangelogNormalize

[PR] [FLINK-34248] Implement restore tests for changelog normalize node [flink]

2024-01-26 Thread via GitHub
bvarghese1 opened a new pull request, #24203: URL: https://github.com/apache/flink/pull/24203 ## What is the purpose of the change *Add restore tests for ChangelogNormalize node* ## Verifying this change This change added tests and can be verified as follows:

Re: [PR] [FLINK-34113] Update flink-connector-elasticsearch to be compatible with updated SinkV2 interfaces [flink-connector-elasticsearch]

2024-01-26 Thread via GitHub
Jiabao-Sun commented on PR #88: URL: https://github.com/apache/flink-connector-elasticsearch/pull/88#issuecomment-1912905198 > @Jiabao-Sun Thanks for this, but then we also need to make sure that this is tested against 1.19-SNAPSHOT if I'm not mistaken. Can you add that to this PR, so we

[jira] [Created] (FLINK-34248) Implement restore tests for ChangelogNormalize node

2024-01-26 Thread Bonnie Varghese (Jira)
Bonnie Varghese created FLINK-34248: --- Summary: Implement restore tests for ChangelogNormalize node Key: FLINK-34248 URL: https://issues.apache.org/jira/browse/FLINK-34248 Project: Flink

Re: [PR] [FLINK-34234] Apply ShadeOptionalChecker for flink-shaded [flink-shaded]

2024-01-26 Thread via GitHub
snuyanzin commented on code in PR #136: URL: https://github.com/apache/flink-shaded/pull/136#discussion_r1468176508 ## pom.xml: ## @@ -65,6 +65,7 @@ under the License. 4.1.100.Final 2.15.3 32.1.3-jre +true Review Comment: that was the plan

Re: [PR] [FLINK-34234] Apply ShadeOptionalChecker for flink-shaded [flink-shaded]

2024-01-26 Thread via GitHub
snuyanzin commented on code in PR #136: URL: https://github.com/apache/flink-shaded/pull/136#discussion_r1467969251 ## flink-shaded-zookeeper-parent/flink-shaded-zookeeper-38/pom.xml: ## @@ -128,6 +131,7 @@ under the License. org.apache.zookeeper

Re: [PR] [FLINK-34234] Apply ShadeOptionalChecker for flink-shaded [flink-shaded]

2024-01-26 Thread via GitHub
snuyanzin commented on code in PR #136: URL: https://github.com/apache/flink-shaded/pull/136#discussion_r1467969251 ## flink-shaded-zookeeper-parent/flink-shaded-zookeeper-38/pom.xml: ## @@ -128,6 +131,7 @@ under the License. org.apache.zookeeper

Re: [PR] [FLINK-34152] Tune heap memory of autoscaled jobs [flink-kubernetes-operator]

2024-01-26 Thread via GitHub
mxm commented on PR #762: URL: https://github.com/apache/flink-kubernetes-operator/pull/762#issuecomment-1912465655 @gyfora @1996fanrui I created a doc to go over the rational and the ideas behind this PR:

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-01-26 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1467930051 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusSink.java: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-01-26 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1467925863 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusTimeSeries.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to the

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-01-26 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1467921494 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusSinkWriter.java: ## @@ -0,0 +1,267 @@ +/* + * Licensed to the

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-01-26 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1467886908 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusSinkWriter.java: ## @@ -0,0 +1,267 @@ +/* + * Licensed to the

Re: [PR] [FLINK-33914][ci] Adds basic Flink CI workflow [flink]

2024-01-26 Thread via GitHub
XComp commented on PR #23970: URL: https://github.com/apache/flink/pull/23970#issuecomment-1912346703 Deprecation warning started to appear which forced me to update the version for `actions/checkout` and `actions/cache` to `v4`. ![Uploading Screenshot from 2024-01-26 17-32-23.png…]()

[jira] [Commented] (FLINK-33297) FLIP-366: Support standard YAML for FLINK configuration

2024-01-26 Thread Junrui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811331#comment-17811331 ] Junrui Li commented on FLINK-33297: --- [~lincoln.86xy] Not yet, sorry for the misleading information. I

[jira] [Created] (FLINK-34247) Document FLIP-366: Support standard YAML for FLINK configuration

2024-01-26 Thread Junrui Li (Jira)
Junrui Li created FLINK-34247: - Summary: Document FLIP-366: Support standard YAML for FLINK configuration Key: FLINK-34247 URL: https://issues.apache.org/jira/browse/FLINK-34247 Project: Flink

[jira] [Created] (FLINK-34246) Allow only archive failed job to history server

2024-01-26 Thread Lim Qing Wei (Jira)
Lim Qing Wei created FLINK-34246: Summary: Allow only archive failed job to history server Key: FLINK-34246 URL: https://issues.apache.org/jira/browse/FLINK-34246 Project: Flink Issue Type:

[jira] [Closed] (FLINK-33006) Add e2e test for Kubernetes Operator HA

2024-01-26 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-33006. -- Resolution: Fixed merged to main 6be277cd0c7421f4822c49296198f4a34b2cd721 > Add e2e test for

Re: [PR] [FLINK-33006] add e2e for Flink operator HA [flink-kubernetes-operator]

2024-01-26 Thread via GitHub
gyfora merged PR #756: URL: https://github.com/apache/flink-kubernetes-operator/pull/756 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33006] add e2e for Flink operator HA [flink-kubernetes-operator]

2024-01-26 Thread via GitHub
HuangZhenQiu commented on code in PR #756: URL: https://github.com/apache/flink-kubernetes-operator/pull/756#discussion_r1467819326 ## e2e-tests/test_flink_operator_ha.sh: ## @@ -0,0 +1,71 @@ +#!/usr/bin/env bash

Re: [PR] [FLINK-33006] add e2e for Flink operator HA [flink-kubernetes-operator]

2024-01-26 Thread via GitHub
gyfora commented on code in PR #756: URL: https://github.com/apache/flink-kubernetes-operator/pull/756#discussion_r1467821898 ## e2e-tests/test_flink_operator_ha.sh: ## @@ -0,0 +1,71 @@ +#!/usr/bin/env bash

Re: [PR] [FLINK-33006] add e2e for Flink operator HA [flink-kubernetes-operator]

2024-01-26 Thread via GitHub
HuangZhenQiu commented on code in PR #756: URL: https://github.com/apache/flink-kubernetes-operator/pull/756#discussion_r1467815393 ## .github/workflows/ci.yml: ## @@ -113,12 +114,18 @@ jobs: test: test_autoscaler.sh - version: v1_15 test:

Re: [PR] [FLINK-33006] add e2e for Flink operator HA [flink-kubernetes-operator]

2024-01-26 Thread via GitHub
HuangZhenQiu commented on code in PR #756: URL: https://github.com/apache/flink-kubernetes-operator/pull/756#discussion_r1467819326 ## e2e-tests/test_flink_operator_ha.sh: ## @@ -0,0 +1,71 @@ +#!/usr/bin/env bash

Re: [PR] [FLINK-33006] add e2e for Flink operator HA [flink-kubernetes-operator]

2024-01-26 Thread via GitHub
gyfora commented on code in PR #756: URL: https://github.com/apache/flink-kubernetes-operator/pull/756#discussion_r1467818628 ## .github/workflows/ci.yml: ## @@ -113,12 +114,18 @@ jobs: test: test_autoscaler.sh - version: v1_15 test:

[jira] [Comment Edited] (FLINK-34115) TableAggregateITCase.testFlagAggregateWithOrWithoutIncrementalUpdate fails

2024-01-26 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811328#comment-17811328 ] Matthias Pohl edited comment on FLINK-34115 at 1/26/24 3:44 PM: 1.18

Re: [PR] [FLINK-33006] add e2e for Flink operator HA [flink-kubernetes-operator]

2024-01-26 Thread via GitHub
HuangZhenQiu commented on code in PR #756: URL: https://github.com/apache/flink-kubernetes-operator/pull/756#discussion_r1467815393 ## .github/workflows/ci.yml: ## @@ -113,12 +114,18 @@ jobs: test: test_autoscaler.sh - version: v1_15 test:

[jira] [Commented] (FLINK-34206) CacheITCase.testRetryOnCorruptedClusterDataset(Path) failed

2024-01-26 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811329#comment-17811329 ] Matthias Pohl commented on FLINK-34206: --- The following builds don't have the test disabled, yet.

[jira] [Comment Edited] (FLINK-34115) TableAggregateITCase.testFlagAggregateWithOrWithoutIncrementalUpdate fails

2024-01-26 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811328#comment-17811328 ] Matthias Pohl edited comment on FLINK-34115 at 1/26/24 3:44 PM: 1.18

[jira] [Comment Edited] (FLINK-34115) TableAggregateITCase.testFlagAggregateWithOrWithoutIncrementalUpdate fails

2024-01-26 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811328#comment-17811328 ] Matthias Pohl edited comment on FLINK-34115 at 1/26/24 3:42 PM: 1.18:

[jira] [Commented] (FLINK-34115) TableAggregateITCase.testFlagAggregateWithOrWithoutIncrementalUpdate fails

2024-01-26 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811328#comment-17811328 ] Matthias Pohl commented on FLINK-34115: ---

[jira] [Commented] (FLINK-31472) AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread

2024-01-26 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811327#comment-17811327 ] Matthias Pohl commented on FLINK-31472: --- 1.18:

[jira] [Commented] (FLINK-31472) AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread

2024-01-26 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811326#comment-17811326 ] Matthias Pohl commented on FLINK-31472: ---

[jira] [Created] (FLINK-34245) CassandraSinkTest.test_cassandra_sink fails under JDK17 and JDK21 due to InaccessibleObjectException

2024-01-26 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-34245: - Summary: CassandraSinkTest.test_cassandra_sink fails under JDK17 and JDK21 due to InaccessibleObjectException Key: FLINK-34245 URL:

Re: [PR] [FLINK-34178][autoscaler] Fix the bug that observed scaling restart time is always great than `stabilization.interval` [flink-kubernetes-operator]

2024-01-26 Thread via GitHub
mxm commented on PR #759: URL: https://github.com/apache/flink-kubernetes-operator/pull/759#issuecomment-1912256491 > Hi @1996fanrui , thanks for catching this, I did not realize that "history" only ever spans for one rescale cycle. There is the metrics history and the scaling

Re: [PR] [FLINK-34178][autoscaler] Fix the bug that observed scaling restart time is always great than `stabilization.interval` [flink-kubernetes-operator]

2024-01-26 Thread via GitHub
mxm commented on code in PR #759: URL: https://github.com/apache/flink-kubernetes-operator/pull/759#discussion_r1467799834 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobAutoScalerImpl.java: ## @@ -160,14 +160,23 @@ private void runScalingLogic(Context ctx,

Re: [PR] [FLINK-34244] Upgrade Confluent Platform Avro Schema Registry [flink]

2024-01-26 Thread via GitHub
flinkbot commented on PR #24202: URL: https://github.com/apache/flink/pull/24202#issuecomment-1912236603 ## CI report: * 627b53ac7e8fa8a17102aa77b4e2de30e85a00b4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-34229) Duplicate entry in InnerClasses attribute in class file FusionStreamOperator

2024-01-26 Thread xingbe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811321#comment-17811321 ] xingbe commented on FLINK-34229: [~FrankZou] Sure, I have uploaded all the debug logs from CompileUtils

[jira] [Updated] (FLINK-34229) Duplicate entry in InnerClasses attribute in class file FusionStreamOperator

2024-01-26 Thread xingbe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xingbe updated FLINK-34229: --- Attachment: taskmanager_log.txt > Duplicate entry in InnerClasses attribute in class file

[jira] [Updated] (FLINK-34244) Upgrade Confluent Platform to latest compatible version

2024-01-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34244: --- Labels: pull-request-available (was: ) > Upgrade Confluent Platform to latest compatible

[PR] [FLINK-34244] Upgrade Confluent Platform Avro Schema Registry [flink]

2024-01-26 Thread via GitHub
MartijnVisser opened a new pull request, #24202: URL: https://github.com/apache/flink/pull/24202 ## What is the purpose of the change * Decrease tech debt ## Brief change log * Update used Confluent Platform version for Avro Schema Registry format ## Verifying

Re: [PR] [FLINK-34234] Apply ShadeOptionalChecker for flink-shaded [flink-shaded]

2024-01-26 Thread via GitHub
XComp commented on code in PR #136: URL: https://github.com/apache/flink-shaded/pull/136#discussion_r1467771500 ## .github/workflows/ci.yml: ## @@ -51,6 +52,14 @@ jobs: - name: Check licensing run: | - mvn ${MVN_COMMON_OPTIONS}

Re: [PR] [FLINK-34234] Apply ShadeOptionalChecker for flink-shaded [flink-shaded]

2024-01-26 Thread via GitHub
XComp commented on code in PR #136: URL: https://github.com/apache/flink-shaded/pull/136#discussion_r1467765454 ## .github/workflows/ci.yml: ## @@ -51,6 +52,14 @@ jobs: - name: Check licensing run: | - mvn ${MVN_COMMON_OPTIONS}

Re: [PR] [FLINK-34234] Apply ShadeOptionalChecker for flink-shaded [flink-shaded]

2024-01-26 Thread via GitHub
snuyanzin commented on code in PR #136: URL: https://github.com/apache/flink-shaded/pull/136#discussion_r1467762581 ## .github/workflows/ci.yml: ## @@ -51,6 +52,14 @@ jobs: - name: Check licensing run: | - mvn ${MVN_COMMON_OPTIONS}

Re: [PR] [FLINK-34234] Apply ShadeOptionalChecker for flink-shaded [flink-shaded]

2024-01-26 Thread via GitHub
snuyanzin commented on code in PR #136: URL: https://github.com/apache/flink-shaded/pull/136#discussion_r1467761466 ## .github/workflows/ci.yml: ## @@ -51,6 +52,14 @@ jobs: - name: Check licensing run: | - mvn ${MVN_COMMON_OPTIONS}

Re: [PR] [FLINK-34234] Apply ShadeOptionalChecker for flink-shaded [flink-shaded]

2024-01-26 Thread via GitHub
XComp commented on code in PR #136: URL: https://github.com/apache/flink-shaded/pull/136#discussion_r1467749847 ## pom.xml: ## @@ -65,6 +65,7 @@ under the License. 4.1.100.Final 2.15.3 32.1.3-jre +true Review Comment: I see, those were

Re: [PR] [FLINK-27891][Table] Add ARRAY_APPEND and ARRAY_PREPEND functions [flink]

2024-01-26 Thread via GitHub
snuyanzin commented on PR #19873: URL: https://github.com/apache/flink/pull/19873#issuecomment-1912192870 ah.. sorry completely forgot abou it yeah, I'm going to fix the conflicts and merge after build is green -- This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (FLINK-34193) Remove usage of Flink-Shaded Jackson and Snakeyaml in flink-connector-kafka

2024-01-26 Thread Jinsui Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811307#comment-17811307 ] Jinsui Chen commented on FLINK-34193: - Hi, [~martijnvisser]. Thank you for you response. I have one

Re: [PR] [FLINK-33006] add e2e for Flink operator HA [flink-kubernetes-operator]

2024-01-26 Thread via GitHub
gyfora commented on code in PR #756: URL: https://github.com/apache/flink-kubernetes-operator/pull/756#discussion_r1467714636 ## e2e-tests/test_flink_operator_ha.sh: ## @@ -0,0 +1,71 @@ +#!/usr/bin/env bash

[jira] [Commented] (FLINK-34200) AutoRescalingITCase#testCheckpointRescalingInKeyedState fails

2024-01-26 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811298#comment-17811298 ] Matthias Pohl commented on FLINK-34200: --- I attached the [debug

[jira] [Updated] (FLINK-34200) AutoRescalingITCase#testCheckpointRescalingInKeyedState fails

2024-01-26 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34200: -- Attachment: FLINK-34200.failure.log.gz >

[jira] [Commented] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2024-01-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811296#comment-17811296 ] Sergey Nuyanzin commented on FLINK-33365: - Merged to 3.1.x as 

[jira] [Updated] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2024-01-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-33365: Fix Version/s: jdbc-3.1.2 > Missing filter condition in execution plan containing lookup

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-26 Thread via GitHub
davidradl commented on PR #97: URL: https://github.com/apache/flink-connector-jdbc/pull/97#issuecomment-1912127835 Thanks @snuyanzin :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-33365][BP-3.1] include filters with Lookup joins [flink-connector-jdbc]

2024-01-26 Thread via GitHub
snuyanzin commented on PR #96: URL: https://github.com/apache/flink-connector-jdbc/pull/96#issuecomment-1912126016 superceded by #97 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-33365][BP-3.1] include filters with Lookup joins [flink-connector-jdbc]

2024-01-26 Thread via GitHub
snuyanzin closed pull request #96: [FLINK-33365][BP-3.1] include filters with Lookup joins URL: https://github.com/apache/flink-connector-jdbc/pull/96 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-26 Thread via GitHub
boring-cyborg[bot] commented on PR #97: URL: https://github.com/apache/flink-connector-jdbc/pull/97#issuecomment-1912124003 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-26 Thread via GitHub
snuyanzin merged PR #97: URL: https://github.com/apache/flink-connector-jdbc/pull/97 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33365][BP-3.1] include filters with Lookup joins [flink-connector-jdbc]

2024-01-26 Thread via GitHub
davidradl commented on PR #96: URL: https://github.com/apache/flink-connector-jdbc/pull/96#issuecomment-1912118063 @snuyanzin I did the same with https://github.com/apache/flink-connector-jdbc/pull/97 . I cherry picked and fixed up the conflict in one commit. I can close my pr if you are

Re: [PR] [hotfix] Add jakarta.activation required after changes in Flink main repo [flink-connector-jdbc]

2024-01-26 Thread via GitHub
snuyanzin closed pull request #93: [hotfix] Add jakarta.activation required after changes in Flink main repo URL: https://github.com/apache/flink-connector-jdbc/pull/93 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [hotfix] Add jakarta.activation required after changes in Flink main repo [flink-connector-jdbc]

2024-01-26 Thread via GitHub
snuyanzin commented on PR #93: URL: https://github.com/apache/flink-connector-jdbc/pull/93#issuecomment-1912104156 closing since the issue was fixed in upstream -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-26 Thread via GitHub
davidradl commented on PR #97: URL: https://github.com/apache/flink-connector-jdbc/pull/97#issuecomment-1912096605 @snuyanzin as discussed here is the pr for the back port. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [FLINK-34234] Apply ShadeOptionalChecker for flink-shaded [flink-shaded]

2024-01-26 Thread via GitHub
snuyanzin commented on code in PR #136: URL: https://github.com/apache/flink-shaded/pull/136#discussion_r1467672006 ## pom.xml: ## @@ -341,21 +342,41 @@ under the License. java + +

[jira] [Closed] (FLINK-34145) File source connector support dynamic source parallelism inference in batch jobs

2024-01-26 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu closed FLINK-34145. --- Fix Version/s: 1.19.0 Resolution: Done master/release-1.19: 11631cb59568df60d40933fb13c8433062ed9290

Re: [PR] [FLINK-34145][connector/filesystem] support dynamic source parallelism inference in batch jobs [flink]

2024-01-26 Thread via GitHub
zhuzhurk closed pull request #24186: [FLINK-34145][connector/filesystem] support dynamic source parallelism inference in batch jobs URL: https://github.com/apache/flink/pull/24186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [FLINK-34234] Apply ShadeOptionalChecker for flink-shaded [flink-shaded]

2024-01-26 Thread via GitHub
XComp commented on code in PR #136: URL: https://github.com/apache/flink-shaded/pull/136#discussion_r1467669315 ## pom.xml: ## @@ -341,21 +342,41 @@ under the License. java + +

[jira] [Assigned] (FLINK-34222) Get minibatch join operator involved

2024-01-26 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee reassigned FLINK-34222: --- Assignee: Shuai Xu > Get minibatch join operator involved >

[jira] [Resolved] (FLINK-33264) Support source parallelism setting for DataGen connector

2024-01-26 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li resolved FLINK-33264. Fix Version/s: 1.19.0 Resolution: Fixed Implemented via

Re: [PR] [FLINK-34222][table] End-to-end implementation of minibatch join [flink]

2024-01-26 Thread via GitHub
xishuaidelin commented on PR #24161: URL: https://github.com/apache/flink/pull/24161#issuecomment-1912079018 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]

2024-01-26 Thread via GitHub
libenchao closed pull request #24133: [FLINK-33264][table] Support source parallelism setting for DataGen connector URL: https://github.com/apache/flink/pull/24133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Comment Edited] (FLINK-34200) AutoRescalingITCase#testCheckpointRescalingInKeyedState fails

2024-01-26 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811275#comment-17811275 ] Matthias Pohl edited comment on FLINK-34200 at 1/26/24 1:32 PM: Another

[jira] [Commented] (FLINK-34200) AutoRescalingITCase#testCheckpointRescalingInKeyedState fails

2024-01-26 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811275#comment-17811275 ] Matthias Pohl commented on FLINK-34200: --- Another local repeated test run for

[jira] [Comment Edited] (FLINK-34200) AutoRescalingITCase#testCheckpointRescalingInKeyedState fails

2024-01-26 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811275#comment-17811275 ] Matthias Pohl edited comment on FLINK-34200 at 1/26/24 1:30 PM: Another

[jira] [Commented] (FLINK-34115) TableAggregateITCase.testFlagAggregateWithOrWithoutIncrementalUpdate fails

2024-01-26 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811273#comment-17811273 ] Matthias Pohl commented on FLINK-34115: --- {quote} I think this build does not include

[PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-26 Thread via GitHub
davidradl opened a new pull request, #97: URL: https://github.com/apache/flink-connector-jdbc/pull/97 This closes apache/flink-connector-jdbc#79 Creating as draft while testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (FLINK-34200) AutoRescalingITCase#testCheckpointRescalingInKeyedState fails

2024-01-26 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811271#comment-17811271 ] Matthias Pohl commented on FLINK-34200: --- btw. I was able to reproduce the test instability locally

[jira] [Commented] (FLINK-33297) FLIP-366: Support standard YAML for FLINK configuration

2024-01-26 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811270#comment-17811270 ] lincoln lee commented on FLINK-33297: - [~JunRuiLi] Is all the work on FLIP-366 done? If so, we can

[jira] [Commented] (FLINK-34200) AutoRescalingITCase#testCheckpointRescalingInKeyedState fails

2024-01-26 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811268#comment-17811268 ] Matthias Pohl commented on FLINK-34200: --- Not sure whether that helps, but from the three builds

Re: [PR] [FLINK-33365][BP-3.1] include filters with Lookup joins [flink-connector-jdbc]

2024-01-26 Thread via GitHub
snuyanzin commented on PR #96: URL: https://github.com/apache/flink-connector-jdbc/pull/96#issuecomment-1912058646 @davidradl could you please have a look here I created a backport of #79 it was not a cherry-pick because of some inconsistent changes between branches -- This is an

[PR] [BP-3.1][FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-26 Thread via GitHub
snuyanzin opened a new pull request, #96: URL: https://github.com/apache/flink-connector-jdbc/pull/96 This is a backport of FLINK-33365 it also backports FLINK-33883 to simplify backport of FLINK-33365 -- This is an automated message from the Apache Git Service. To respond to the

[PR] Add Kafka 3.1.0 connector [flink-web]

2024-01-26 Thread via GitHub
MartijnVisser opened a new pull request, #718: URL: https://github.com/apache/flink-web/pull/718 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [FLINK-34178][autoscaler] Fix the bug that observed scaling restart time is always great than `stabilization.interval` [flink-kubernetes-operator]

2024-01-26 Thread via GitHub
afedulov commented on code in PR #759: URL: https://github.com/apache/flink-kubernetes-operator/pull/759#discussion_r1467614975 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobAutoScalerImpl.java: ## @@ -160,14 +160,23 @@ private void runScalingLogic(Context

Re: [PR] [FLINK-34178][autoscaler] Fix the bug that observed scaling restart time is always great than `stabilization.interval` [flink-kubernetes-operator]

2024-01-26 Thread via GitHub
afedulov commented on code in PR #759: URL: https://github.com/apache/flink-kubernetes-operator/pull/759#discussion_r1467622312 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobAutoScalerImpl.java: ## @@ -160,14 +160,23 @@ private void runScalingLogic(Context

[jira] [Updated] (FLINK-30400) Stop bundling connector-base in externalized connectors

2024-01-26 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-30400: --- Issue Type: Technical Debt (was: Improvement) > Stop bundling connector-base in

  1   2   3   >