[GitHub] [flink] dawidwys commented on a diff in pull request #21635: [FLINK-30613] Improve resolving schema compatibility -- Milestone one

dawidwys commented on code in PR #21635: URL: https://github.com/apache/flink/pull/21635#discussion_r1081388117 ## flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializerSnapshot.java: ## @@ -56,6 +55,9 @@ /** Contains the actual content for the

[GitHub] [flink] dawidwys commented on a diff in pull request #21635: [FLINK-30613] Improve resolving schema compatibility -- Milestone one

dawidwys commented on code in PR #21635: URL: https://github.com/apache/flink/pull/21635#discussion_r1081243028 ## flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializerSnapshot.java: ## @@ -56,6 +55,9 @@ /** Contains the actual content for the

[GitHub] [flink] lincoln-lil closed pull request #21683: [FLINK-30672][table] Support 'EXPLAIN PLAN_ADVICE' statement

lincoln-lil closed pull request #21683: [FLINK-30672][table] Support 'EXPLAIN PLAN_ADVICE' statement URL: https://github.com/apache/flink/pull/21683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] luoyuxia commented on pull request #21676: [FLINK-30662][table] Planner supports delete

luoyuxia commented on PR #21676: URL: https://github.com/apache/flink/pull/21676#issuecomment-1397093090 Thanks for the detail check. Sorry for missing some thing while merge these commits to two commit. Now, I fix it, each commit should compile and pass test sucessfully. Thank you

[GitHub] [flink] fsk119 merged pull request #21725: [FLINK-29000][python] Support python UDF in the SQL Gateway

fsk119 merged PR #21725: URL: https://github.com/apache/flink/pull/21725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] XComp closed pull request #21734: [FLINK-30756] Revert "[FLINK-30191][python] Update net.sf.py4j:py4j dependency to 0.10.9.7"

XComp closed pull request #21734: [FLINK-30756] Revert "[FLINK-30191][python] Update net.sf.py4j:py4j dependency to 0.10.9.7" URL: https://github.com/apache/flink/pull/21734 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] XComp commented on pull request #21734: [FLINK-30756] Revert "[FLINK-30191][python] Update net.sf.py4j:py4j dependency to 0.10.9.7"

XComp commented on PR #21734: URL: https://github.com/apache/flink/pull/21734#issuecomment-1397074229 The issue was already fixed through PR #21730. No revert necessary. See succeeding build

[GitHub] [flink] flinkbot commented on pull request #21734: [FLINK-30756] Revert "[FLINK-30191][python] Update net.sf.py4j:py4j dependency to 0.10.9.7"

flinkbot commented on PR #21734: URL: https://github.com/apache/flink/pull/21734#issuecomment-1397054878 ## CI report: * e5764802ea403f6a0226ef5577c9ad2ab7393c6d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] XComp opened a new pull request, #21734: Revert "[FLINK-30191][python] Update net.sf.py4j:py4j dependency to 0.10.9.7"

XComp opened a new pull request, #21734: URL: https://github.com/apache/flink/pull/21734 ## What is the purpose of the change This reverts commit 0bbc7b1e9fed89b8c3e8ec67b7b0dad5999c2c01 to PR #21680 to stabilize master again. ## Brief change log `git revert

[GitHub] [flink] flinkbot commented on pull request #21733: [WIP] assert that memory usage deviation is within bounds instead of …

flinkbot commented on PR #21733: URL: https://github.com/apache/flink/pull/21733#issuecomment-1397030682 ## CI report: * 6e994eed6d8f7d4a96cf64b05aaed8ac6b5e9c3f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] rkhachatryan opened a new pull request, #21733: [WIP] assert that memory usage deviation is within bounds instead of …

rkhachatryan opened a new pull request, #21733: URL: https://github.com/apache/flink/pull/21733 …min/max ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid

[GitHub] [flink] flinkbot commented on pull request #21732: [FLINK-30754][tests] Fix ExceptionThrowingDelegationTokenProvider/Receiver multi-threaded test issues

flinkbot commented on PR #21732: URL: https://github.com/apache/flink/pull/21732#issuecomment-1397021603 ## CI report: * 66179da2139a8a1678ff53416661c4c744fa8ed1 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] gaborgsomogyi commented on pull request #21732: [FLINK-30754][tests] Fix ExceptionThrowingDelegationTokenProvider/Receiver multi-threaded test issues

gaborgsomogyi commented on PR #21732: URL: https://github.com/apache/flink/pull/21732#issuecomment-1397011089 cc @gyfora @mbalassi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] gaborgsomogyi opened a new pull request, #21732: [FLINK-30754][tests] Fix ExceptionThrowingDelegationTokenProvider/Receiver multi-threaded test issues

gaborgsomogyi opened a new pull request, #21732: URL: https://github.com/apache/flink/pull/21732 ## What is the purpose of the change At the moment tests using `ExceptionThrowingDelegationTokenProvider` and `ExceptionThrowingDelegationTokenReceiver` are not thread safe because of the

[GitHub] [flink] snuyanzin commented on a diff in pull request #20922: [DRAFT] Apply changes for calcite 1.3x

snuyanzin commented on code in PR #20922: URL: https://github.com/apache/flink/pull/20922#discussion_r1081247923 ## flink-table/pom.xml: ## @@ -76,10 +76,10 @@ under the License. - 1.26.0 + 1.32.0

[GitHub] [flink] snuyanzin commented on pull request #21500: [FLINK-27995][table] Upgrade Janino version

snuyanzin commented on PR #21500: URL: https://github.com/apache/flink/pull/21500#issuecomment-1396962825 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] dawidwys commented on a diff in pull request #21635: [FLINK-30613] Improve resolving schema compatibility -- Milestone one

dawidwys commented on code in PR #21635: URL: https://github.com/apache/flink/pull/21635#discussion_r1081243028 ## flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializerSnapshot.java: ## @@ -56,6 +55,9 @@ /** Contains the actual content for the

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #506: fix md style

gyfora commented on PR #506: URL: https://github.com/apache/flink-kubernetes-operator/pull/506#issuecomment-1396955111 I am closing this as the `*` in the page is intended as a reference to the footnote of the table -- This is an automated message from the Apache Git Service. To respond

[GitHub] [flink-kubernetes-operator] gyfora closed pull request #506: fix md style

gyfora closed pull request #506: fix md style URL: https://github.com/apache/flink-kubernetes-operator/pull/506 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #504: [FLINK-30669] update recent job status in flinkdeployment object

gyfora commented on PR #504: URL: https://github.com/apache/flink-kubernetes-operator/pull/504#issuecomment-1396953247 I agree @kmozaid if this doesn't affect existing jobs and improves some others then the change makes sense :) Could you please add a unit test to guard this change

[GitHub] [flink] libenchao closed pull request #21613: [FLINK-30093][formats] Fix compile errors for google.protobuf.Timestamp type

libenchao closed pull request #21613: [FLINK-30093][formats] Fix compile errors for google.protobuf.Timestamp type URL: https://github.com/apache/flink/pull/21613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] kristoffSC commented on a diff in pull request #21393: [FLINK-27246][TableSQL/Runtime][master] - Include WHILE blocks in split generated java methods

kristoffSC commented on code in PR #21393: URL: https://github.com/apache/flink/pull/21393#discussion_r1081214977 ## flink-table/flink-table-code-splitter/src/main/java/org/apache/flink/table/codesplit/BlockStatementSplitter.java: ## @@ -0,0 +1,326 @@ +/* + * Licensed to the

[GitHub] [flink] libenchao commented on pull request #21613: [FLINK-30093][formats] Fix compile errors for google.protobuf.Timestamp type

libenchao commented on PR #21613: URL: https://github.com/apache/flink/pull/21613#issuecomment-1396915307 @laughingman7743 Thanks for your contribution and @maosuhan thanks for your review. The PR looks good, I'm merging. -- This is an automated message from the Apache Git Service. To

[GitHub] [flink] HuangXingBo closed pull request #21730: [FLINK-30753][python] Fix the invocation process of Table.explain()

HuangXingBo closed pull request #21730: [FLINK-30753][python] Fix the invocation process of Table.explain() URL: https://github.com/apache/flink/pull/21730 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] HuangXingBo closed pull request #21699: [FLINK-29421][python] Support python 3.10

HuangXingBo closed pull request #21699: [FLINK-29421][python] Support python 3.10 URL: https://github.com/apache/flink/pull/21699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] zentol commented on a diff in pull request #21492: [FLINK-30378][docs] Add v2 sql_connector_download_table shortcode

zentol commented on code in PR #21492: URL: https://github.com/apache/flink/pull/21492#discussion_r1081201261 ## docs/setup_docs.sh: ## @@ -27,19 +27,12 @@ function integrate_connector_docs { local connector ref additional_folders connector=$1 ref=$2 -

[GitHub] [flink] flinkbot commented on pull request #21731: [FLINK-30679][hive]Fix IndexOutOfBoundsException for Hive lookup join when column pushdown to Hive lookup table source

flinkbot commented on PR #21731: URL: https://github.com/apache/flink/pull/21731#issuecomment-1396905973 ## CI report: * 482d706d44343a8f86fb27d178385f1fa118ffa9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] kristoffSC commented on a diff in pull request #21393: [FLINK-27246][TableSQL/Runtime][master] - Include WHILE blocks in split generated java methods

kristoffSC commented on code in PR #21393: URL: https://github.com/apache/flink/pull/21393#discussion_r1081192318 ## flink-table/flink-table-code-splitter/src/main/java/org/apache/flink/table/codesplit/BlockStatementSplitter.java: ## @@ -0,0 +1,326 @@ +/* + * Licensed to the

[GitHub] [flink] hehuiyuan opened a new pull request, #21731: [FLINK-30679][hive]Fix IndexOutOfBoundsException for Hive lookup join when column pushdown to Hive lookup table source

hehuiyuan opened a new pull request, #21731: URL: https://github.com/apache/flink/pull/21731 ## What is the purpose of the change Can not load the data of hive dim table when project-push-down is introduced ## Does this pull request potentially affect one of the

[GitHub] [flink] kristoffSC commented on a diff in pull request #21393: [FLINK-27246][TableSQL/Runtime][master] - Include WHILE blocks in split generated java methods

kristoffSC commented on code in PR #21393: URL: https://github.com/apache/flink/pull/21393#discussion_r1081192318 ## flink-table/flink-table-code-splitter/src/main/java/org/apache/flink/table/codesplit/BlockStatementSplitter.java: ## @@ -0,0 +1,326 @@ +/* + * Licensed to the

[GitHub] [flink-connector-gcp-pubsub] MartijnVisser merged pull request #1: [FLINK-30058][Connector/Google PubSub] Move existing Google Cloud PubSub connector code from Flink repo

MartijnVisser merged PR #1: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-connector-gcp-pubsub] boring-cyborg[bot] commented on pull request #1: [FLINK-30058][Connector/Google PubSub] Move existing Google Cloud PubSub connector code from Flink repo

boring-cyborg[bot] commented on PR #1: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/1#issuecomment-1396892642 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [flink] tsreaper commented on a diff in pull request #21393: [FLINK-27246][TableSQL/Runtime][master] - Include WHILE blocks in split generated java methods

tsreaper commented on code in PR #21393: URL: https://github.com/apache/flink/pull/21393#discussion_r1081163322 ## flink-table/flink-table-code-splitter/src/main/java/org/apache/flink/table/codesplit/BlockStatementSplitter.java: ## @@ -0,0 +1,326 @@ +/* + * Licensed to the

[GitHub] [flink] tsreaper commented on a diff in pull request #21393: [FLINK-27246][TableSQL/Runtime][master] - Include WHILE blocks in split generated java methods

tsreaper commented on code in PR #21393: URL: https://github.com/apache/flink/pull/21393#discussion_r1081158207 ## flink-table/flink-table-code-splitter/src/main/java/org/apache/flink/table/codesplit/BlockStatementSplitter.java: ## @@ -0,0 +1,326 @@ +/* + * Licensed to the

[GitHub] [flink] pnowojski commented on a diff in pull request #20151: [FLINK-26803][checkpoint] Merging channel state files

pnowojski commented on code in PR #20151: URL: https://github.com/apache/flink/pull/20151#discussion_r1081119337 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriteRequestExecutorImpl.java: ## @@ -107,49 +119,78 @@ void run() {

[GitHub] [flink-connector-kafka] zentol commented on a diff in pull request #1: [FLINK-30052][Connectors/Kafka] Move existing Kafka connector code from Flink repo to dedicated Kafka repo

zentol commented on code in PR #1: URL: https://github.com/apache/flink-connector-kafka/pull/1#discussion_r1081176388 ## flink-connector-kafka-e2e-tests/flink-end-to-end-tests-common-kafka/src/test/java/org/apache/flink/tests/util/kafka/SQLClientKafkaITCase.java: ## @@ -82,15

[GitHub] [flink-connector-cassandra] zentol commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

zentol commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1081173791 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/split/CassandraSplitSerializer.java: ## @@ -0,0 +1,63 @@ +/* + *

[GitHub] [flink-connector-cassandra] zentol commented on pull request #3: [FLINK-26822] Add Cassandra Source

zentol commented on PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#issuecomment-1396864643 > I did not author the RingRange and SplitsGenerator classes. I got them from the Apache Beam Cassandra connector. If you're copying stuff from other projects it please

[GitHub] [flink] SinBex commented on pull request #21695: [FLINK-30707][runtime] Let speculative execution take input data amount into account when detecting slow tasks.

SinBex commented on PR #21695: URL: https://github.com/apache/flink/pull/21695#issuecomment-1396851350 @zhuzhurk @wanglijie95 Thanks for the review! I have updated this pr in the fix-up commit. Please take a look. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [flink] SinBex commented on a diff in pull request #21695: [FLINK-30707][runtime] Let speculative execution take input data amount into account when detecting slow tasks.

SinBex commented on code in PR #21695: URL: https://github.com/apache/flink/pull/21695#discussion_r1081141135 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/AdaptiveBatchScheduler.java: ## @@ -327,6 +332,41 @@ private ParallelismAndInputInfos

[GitHub] [flink] SinBex commented on a diff in pull request #21695: [FLINK-30707][runtime] Let speculative execution take input data amount into account when detecting slow tasks.

SinBex commented on code in PR #21695: URL: https://github.com/apache/flink/pull/21695#discussion_r1081140610 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionVertex.java: ## @@ -169,6 +169,16 @@ public ExecutionVertexInputInfo

[GitHub] [flink] SinBex commented on a diff in pull request #21695: [FLINK-30707][runtime] Let speculative execution take input data amount into account when detecting slow tasks.

SinBex commented on code in PR #21695: URL: https://github.com/apache/flink/pull/21695#discussion_r1081140387 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/AdaptiveBatchScheduler.java: ## @@ -179,6 +183,7 @@ protected void onTaskFinished(final

[GitHub] [flink] SinBex commented on a diff in pull request #21695: [FLINK-30707][runtime] Let speculative execution take input data amount into account when detecting slow tasks.

SinBex commented on code in PR #21695: URL: https://github.com/apache/flink/pull/21695#discussion_r1081138788 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/AbstractBlockingResultInfo.java: ## @@ -72,4 +73,15 @@ public void

[GitHub] [flink] SinBex commented on a diff in pull request #21695: [FLINK-30707][runtime] Let speculative execution take input data amount into account when detecting slow tasks.

SinBex commented on code in PR #21695: URL: https://github.com/apache/flink/pull/21695#discussion_r1081138221 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/slowtaskdetector/ExecutionTimeBasedSlowTaskDetector.java: ## @@ -168,21 +168,34 @@ private double

[GitHub] [flink] SinBex commented on a diff in pull request #21695: [FLINK-30707][runtime] Let speculative execution take input data amount into account when detecting slow tasks.

SinBex commented on code in PR #21695: URL: https://github.com/apache/flink/pull/21695#discussion_r1081135014 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/slowtaskdetector/ExecutionTimeBasedSlowTaskDetector.java: ## @@ -225,10 +244,56 @@ private long

[GitHub] [flink] SinBex commented on a diff in pull request #21695: [FLINK-30707][runtime] Let speculative execution take input data amount into account when detecting slow tasks.

SinBex commented on code in PR #21695: URL: https://github.com/apache/flink/pull/21695#discussion_r1081134730 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/slowtaskdetector/ExecutionTimeBasedSlowTaskDetector.java: ## @@ -225,10 +244,56 @@ private long

[GitHub] [flink] SinBex commented on a diff in pull request #21695: [FLINK-30707][runtime] Let speculative execution take input data amount into account when detecting slow tasks.

SinBex commented on code in PR #21695: URL: https://github.com/apache/flink/pull/21695#discussion_r1081134448 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/slowtaskdetector/ExecutionTimeBasedSlowTaskDetector.java: ## @@ -225,10 +244,56 @@ private long

[GitHub] [flink] SinBex commented on a diff in pull request #21695: [FLINK-30707][runtime] Let speculative execution take input data amount into account when detecting slow tasks.

SinBex commented on code in PR #21695: URL: https://github.com/apache/flink/pull/21695#discussion_r1081130568 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/AbstractBlockingResultInfo.java: ## @@ -72,4 +73,15 @@ public void

[GitHub] [flink] SinBex commented on a diff in pull request #21695: [FLINK-30707][runtime] Let speculative execution take input data amount into account when detecting slow tasks.

SinBex commented on code in PR #21695: URL: https://github.com/apache/flink/pull/21695#discussion_r1081130568 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/AbstractBlockingResultInfo.java: ## @@ -72,4 +73,15 @@ public void

[GitHub] [flink] SinBex commented on a diff in pull request #21695: [FLINK-30707][runtime] Let speculative execution take input data amount into account when detecting slow tasks.

SinBex commented on code in PR #21695: URL: https://github.com/apache/flink/pull/21695#discussion_r1081130145 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/PointwiseBlockingResultInfo.java: ## @@ -60,4 +61,23 @@ public long

[GitHub] [flink] SinBex commented on a diff in pull request #21695: [FLINK-30707][runtime] Let speculative execution take input data amount into account when detecting slow tasks.

SinBex commented on code in PR #21695: URL: https://github.com/apache/flink/pull/21695#discussion_r1081129947 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/AllToAllBlockingResultInfo.java: ## @@ -119,4 +120,17 @@ public List

[GitHub] [flink] SinBex commented on a diff in pull request #21695: [FLINK-30707][runtime] Let speculative execution take input data amount into account when detecting slow tasks.

SinBex commented on code in PR #21695: URL: https://github.com/apache/flink/pull/21695#discussion_r1081128283 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/AdaptiveBatchScheduler.java: ## @@ -179,6 +183,7 @@ protected void onTaskFinished(final

[GitHub] [flink] yunfengzhou-hub commented on pull request #21730: [FLINK-30753][python] Fix the invocation process of Table.explain()

yunfengzhou-hub commented on PR #21730: URL: https://github.com/apache/flink/pull/21730#issuecomment-1396816878 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-benchmarks] zentol merged pull request #64: [FLINK-30717][ci] Migrate to GitHub Actions

zentol merged PR #64: URL: https://github.com/apache/flink-benchmarks/pull/64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] pnowojski commented on a diff in pull request #20151: [FLINK-26803][checkpoint] Merging channel state files

pnowojski commented on code in PR #20151: URL: https://github.com/apache/flink/pull/20151#discussion_r1081118070 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriteRequestExecutorImpl.java: ## @@ -51,27 +66,40 @@ class

[GitHub] [flink] lsyldliu commented on a diff in pull request #21703: [FLINK-29880][hive] Introduce auto compaction for Hive sink in batch mode

lsyldliu commented on code in PR #21703: URL: https://github.com/apache/flink/pull/21703#discussion_r1081042620 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableCompactSinkITCase.java: ## @@ -0,0 +1,209 @@ +/* + * Licensed to the

[GitHub] [flink] Myasuka merged pull request #21714: [FLINK-30724][docs] Update kafka-per-partition watermark to new source

Myasuka merged PR #21714: URL: https://github.com/apache/flink/pull/21714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot commented on pull request #21730: [FLINK-30753][python] Fix the invocation process of Table.explain()

flinkbot commented on PR #21730: URL: https://github.com/apache/flink/pull/21730#issuecomment-1396706686 ## CI report: * 8bdcb25e0f606d7055d5541b6349d37bd98fac8b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] yunfengzhou-hub commented on pull request #21730: [FLINK-30753][python] Fix the invocation process of Table.explain()

yunfengzhou-hub commented on PR #21730: URL: https://github.com/apache/flink/pull/21730#issuecomment-1396705985 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] yunfengzhou-hub opened a new pull request, #21730: [FLINK-30753][python] Fix the invocation process of Table.explain()

yunfengzhou-hub opened a new pull request, #21730: URL: https://github.com/apache/flink/pull/21730 ## What is the purpose of the change This PR fixes the bug that PyFlink cannot invoke `Explainable.explain()` method through py4j. ## Brief change log - invoke

[GitHub] [flink] zentol merged pull request #21691: [FLINK-30678][tests] Use random port

zentol merged PR #21691: URL: https://github.com/apache/flink/pull/21691 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-shaded] MartijnVisser merged pull request #118: [FLINK-30232][Build/Shaded] Include all platforms incl ARM64 while shading Netty

MartijnVisser merged PR #118: URL: https://github.com/apache/flink-shaded/pull/118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] pnowojski commented on pull request #21690: [FLINK-30623][runtime][bug] The canEmitBatchOfRecords should check recordWriter and changelogWriterAvailabilityProvider are available

pnowojski commented on PR #21690: URL: https://github.com/apache/flink/pull/21690#issuecomment-1396636736 @lindong28 I don't understand your concerns. With separate functional interface as you are proposing you will have exact same "problems". If you add functional interface to the

[GitHub] [flink] Myasuka commented on a diff in pull request #21729: [FLINK-30751] [docs] Remove references to disableDataSync in RocksDB documentation

Myasuka commented on code in PR #21729: URL: https://github.com/apache/flink/pull/21729#discussion_r1080950829 ## flink-python/pyflink/datastream/state_backend.py: ## @@ -956,16 +956,20 @@ class PredefinedOptions(Enum): determined to be beneficial for performance under

[GitHub] [flink] ruanhang1993 commented on a diff in pull request #21589: [FLINK-25509][connector-base] Add RecordEvaluator to dynamically stop source based on de-serialized records

ruanhang1993 commented on code in PR #21589: URL: https://github.com/apache/flink/pull/21589#discussion_r1080945750 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/reader/fetcher/FinishSplitsTask.java: ## @@ -0,0 +1,69 @@ +/* + *

[GitHub] [flink] ruanhang1993 commented on a diff in pull request #21589: [FLINK-25509][connector-base] Add RecordEvaluator to dynamically stop source based on de-serialized records

ruanhang1993 commented on code in PR #21589: URL: https://github.com/apache/flink/pull/21589#discussion_r1080938338 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/reader/SourceReaderBase.java: ## @@ -328,14 +348,82 @@ private

[GitHub] [flink] lincoln-lil commented on pull request #21676: [FLINK-30662][table] Planner supports delete

lincoln-lil commented on PR #21676: URL: https://github.com/apache/flink/pull/21676#issuecomment-1396596929 @luoyuxia the merged commits look like there are some changes and commits that are not aligned, so could you merge them again when you have time？ Chinese New Year is coming,

[GitHub] [flink] ruanhang1993 commented on a diff in pull request #21589: [FLINK-25509][connector-base] Add RecordEvaluator to dynamically stop source based on de-serialized records

ruanhang1993 commented on code in PR #21589: URL: https://github.com/apache/flink/pull/21589#discussion_r1080920855 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/reader/SingleThreadMultiplexSourceReaderBase.java: ## @@ -113,4

[GitHub] [flink] fsk119 commented on a diff in pull request #21725: [FLINK-29000][python] Support python UDF in the SQL Gateway

fsk119 commented on code in PR #21725: URL: https://github.com/apache/flink/pull/21725#discussion_r1080917570 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/context/DefaultContext.java: ## @@ -55,15 +58,31 @@ public

[GitHub] [flink] HuangXingBo commented on a diff in pull request #21725: [FLINK-29000][python] Support python UDF in the SQL Gateway

HuangXingBo commented on code in PR #21725: URL: https://github.com/apache/flink/pull/21725#discussion_r1080914005 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/context/DefaultContext.java: ## @@ -55,15 +58,31 @@ public

[GitHub] [flink] HuangXingBo commented on a diff in pull request #21725: [FLINK-29000][python] Support python UDF in the SQL Gateway

HuangXingBo commented on code in PR #21725: URL: https://github.com/apache/flink/pull/21725#discussion_r1080913833 ## flink-connectors/flink-connector-hive/pom.xml: ## @@ -1097,6 +1097,12 @@ under the License. ${project.version}

[GitHub] [flink] HuangXingBo commented on a diff in pull request #21725: [FLINK-29000][python] Support python UDF in the SQL Gateway

HuangXingBo commented on code in PR #21725: URL: https://github.com/apache/flink/pull/21725#discussion_r1080912316 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/context/DefaultContext.java: ## @@ -55,15 +58,31 @@ public

[GitHub] [flink] fsk119 commented on pull request #17830: [FLINK-24893][Table SQL/Client][FLIP-189] SQL Client prompts customization

fsk119 commented on PR #17830: URL: https://github.com/apache/flink/pull/17830#issuecomment-1396569697 Sorry for closing the PR. I hit the wrong button... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink] snuyanzin opened a new pull request, #17830: [FLINK-24893][Table SQL/Client][FLIP-189] SQL Client prompts customization

snuyanzin opened a new pull request, #17830: URL: https://github.com/apache/flink/pull/17830 ## What is the purpose of the change This PR is a part of FLIP-189 about prompt customization. There are left and right prompt which could be customized in the same way. Left prompt

[GitHub] [flink] fsk119 closed pull request #17830: [FLINK-24893][Table SQL/Client][FLIP-189] SQL Client prompts customization

fsk119 closed pull request #17830: [FLINK-24893][Table SQL/Client][FLIP-189] SQL Client prompts customization URL: https://github.com/apache/flink/pull/17830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink] fsk119 commented on pull request #17830: [FLINK-24893][Table SQL/Client][FLIP-189] SQL Client prompts customization

fsk119 commented on PR #17830: URL: https://github.com/apache/flink/pull/17830#issuecomment-1396566805 Okay. Because #21717 totally changes the architecture of the SQL Client. You may need to rebase again and again... So I just suggest rebasing all refactoring. The design of the

[GitHub] [flink] ruanhang1993 commented on a diff in pull request #21589: [FLINK-25509][connector-base] Add RecordEvaluator to dynamically stop source based on de-serialized records

ruanhang1993 commented on code in PR #21589: URL: https://github.com/apache/flink/pull/21589#discussion_r1080899530 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/reader/splitreader/SplitsDeletion.java: ## @@ -0,0 +1,40 @@ +/* + *

[GitHub] [flink] fsk119 commented on a diff in pull request #21725: [FLINK-29000][python] Support python UDF in the SQL Gateway

fsk119 commented on code in PR #21725: URL: https://github.com/apache/flink/pull/21725#discussion_r1080884303 ## flink-connectors/flink-connector-hive/pom.xml: ## @@ -1097,6 +1097,12 @@ under the License. ${project.version} test

[GitHub] [flink] ruanhang1993 commented on a diff in pull request #21589: [FLINK-25509][connector-base] Add RecordEvaluator to dynamically stop source based on de-serialized records

ruanhang1993 commented on code in PR #21589: URL: https://github.com/apache/flink/pull/21589#discussion_r1080899530 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/reader/splitreader/SplitsDeletion.java: ## @@ -0,0 +1,40 @@ +/* + *

[GitHub] [flink] ruanhang1993 commented on a diff in pull request #21589: [FLINK-25509][connector-base] Add RecordEvaluator to dynamically stop source based on de-serialized records

ruanhang1993 commented on code in PR #21589: URL: https://github.com/apache/flink/pull/21589#discussion_r1080897687 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/reader/splitreader/SplitsDeletion.java: ## @@ -0,0 +1,40 @@ +/* + *

[GitHub] [flink] snuyanzin commented on pull request #17830: [FLINK-24893][Table SQL/Client][FLIP-189] SQL Client prompts customization

snuyanzin commented on PR #17830: URL: https://github.com/apache/flink/pull/17830#issuecomment-1396549855 thanks for the response and reference to https://github.com/apache/flink/pull/21717. I will have a look. I noticed conflicts and try to solve them. For it's sometimes easier to

[GitHub] [flink] flinkbot commented on pull request #21729: [FLINK-30751] [docs] Remove references to disableDataSync in RocksDB documentation

flinkbot commented on PR #21729: URL: https://github.com/apache/flink/pull/21729#issuecomment-1396544048 ## CI report: * c3a904a93192be9bf612e76edbfa39465b398404 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #21728: [FLINK-30667] decouple hive connector with planner internal class

flinkbot commented on PR #21728: URL: https://github.com/apache/flink/pull/21728#issuecomment-1396543949 ## CI report: * be0fcfcfa931339826e99a8b09550be8385d6fd5 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-ml] jiangxin369 opened a new pull request, #201: [FLINK-27716] Add Python API docs in ML

jiangxin369 opened a new pull request, #201: URL: https://github.com/apache/flink-ml/pull/201 ## What is the purpose of the change Add Python API docs in ML. ## Brief change log - Adds Sphinx config to generate Python API doc automatically. - Sets the

[GitHub] [flink] chenqin commented on pull request #21728: [FLINK-30667] decouple hive connector with planner internal class

chenqin commented on PR #21728: URL: https://github.com/apache/flink/pull/21728#issuecomment-1396541490 @luoyuxia please help take a look, here is a bit rationale - parser should be PublicEvolving interface while both Flink and hive has own internal implementation. so hive connector

[GitHub] [flink] dchristle opened a new pull request, #21729: [FLINK-30751] [docs] Remove references to disableDataSync in RocksDB documentation

dchristle opened a new pull request, #21729: URL: https://github.com/apache/flink/pull/21729 ## What is the purpose of the change This PR corrects and improves the readability of the documentation for RocksDB predefined option sets. References to `disableDataSync`, which

[GitHub] [flink] chenqin opened a new pull request, #21728: [FLINK-30667] decouple hive connector with planner internal class

chenqin opened a new pull request, #21728: URL: https://github.com/apache/flink/pull/21728 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[GitHub] [flink] fsk119 commented on pull request #17830: [FLINK-24893][Table SQL/Client][FLIP-189] SQL Client prompts customization

fsk119 commented on PR #17830: URL: https://github.com/apache/flink/pull/17830#issuecomment-1396537732 I think some features may not be easily to support in the gateway mode. We may introduce some REST API to fetch the current catalog and database. WDYT? -- This is an automated message

[GitHub] [flink] fsk119 commented on pull request #17830: [FLINK-24893][Table SQL/Client][FLIP-189] SQL Client prompts customization

fsk119 commented on PR #17830: URL: https://github.com/apache/flink/pull/17830#issuecomment-1396536467 Sorry for the late response. I am refactoring the SQL Client in the #21717 . Do you mind we support this features after the refactor finishes? I can help to rebase this when most codes

[GitHub] [flink] flinkbot commented on pull request #21727: [FLINK-30752][python] Support 'EXPLAIN PLAN_ADVICE' statement in PyFlink

flinkbot commented on PR #21727: URL: https://github.com/apache/flink/pull/21727#issuecomment-1396534110 ## CI report: * 65b5f8395b61ec1ee0040217f02ff202d0ad7c0e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] fsk119 closed pull request #21700: [FLINK-30677][Test] Fix unstable SqlGatewayServiceStatementITCase.testFlinkSqlStatements

fsk119 closed pull request #21700: [FLINK-30677][Test] Fix unstable SqlGatewayServiceStatementITCase.testFlinkSqlStatements URL: https://github.com/apache/flink/pull/21700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink] LadyForest opened a new pull request, #21727: [FLINK-30752][python] Support 'EXPLAIN PLAN_ADVICE' statement in PyFlink

LadyForest opened a new pull request, #21727: URL: https://github.com/apache/flink/pull/21727 ## What is the purpose of the change This PR supports the `EXPLAIN PLAN_ADVICE` statement in PyFlink (need to rebase once FLINK-30672 is merged). ## Brief change log Introduce

[GitHub] [flink] snuyanzin commented on pull request #17830: [FLINK-24893][Table SQL/Client][FLIP-189] SQL Client prompts customization

snuyanzin commented on PR #17830: URL: https://github.com/apache/flink/pull/17830#issuecomment-1396515924 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] 1996fanrui commented on pull request #21690: [FLINK-30623][runtime][bug] The canEmitBatchOfRecords should check recordWriter and changelogWriterAvailabilityProvider are available

1996fanrui commented on PR #21690: URL: https://github.com/apache/flink/pull/21690#issuecomment-1396507794 > Are you suggesting that we should now couple the caller of DataOutput with the code that constructed it? In fact, the code in the master branch did this a long time ago.

[GitHub] [flink] hehuiyuan commented on a diff in pull request #21668: [FLINK-30679][HIVE]Can not load the data of hive dim table when project-push-down is introduced

hehuiyuan commented on code in PR #21668: URL: https://github.com/apache/flink/pull/21668#discussion_r1080847440 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveLookupJoinITCase.java: ## @@ -378,6 +378,31 @@ public void

[GitHub] [flink] chenqin closed pull request #21710: [FLINK-30667] [Table/Planner] remove hive-connector dep on table-planner internal class

chenqin closed pull request #21710: [FLINK-30667] [Table/Planner] remove hive-connector dep on table-planner internal class URL: https://github.com/apache/flink/pull/21710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink-connector-kafka] mas-chen commented on a diff in pull request #1: [FLINK-30052][Connectors/Kafka] Move existing Kafka connector code from Flink repo to dedicated Kafka repo

mas-chen commented on code in PR #1: URL: https://github.com/apache/flink-connector-kafka/pull/1#discussion_r1080844703 ## flink-connector-kafka-e2e-tests/flink-end-to-end-tests-common-kafka/src/test/java/org/apache/flink/tests/util/kafka/SQLClientKafkaITCase.java: ## @@

[GitHub] [flink] snuyanzin commented on pull request #17830: [FLINK-24893][Table SQL/Client][FLIP-189] SQL Client prompts customization

snuyanzin commented on PR #17830: URL: https://github.com/apache/flink/pull/17830#issuecomment-1396484993 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] hehuiyuan commented on a diff in pull request #21668: [FLINK-30679][HIVE]Can not load the data of hive dim table when project-push-down is introduced

hehuiyuan commented on code in PR #21668: URL: https://github.com/apache/flink/pull/21668#discussion_r1080838455 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveLookupJoinITCase.java: ## @@ -378,6 +378,31 @@ public void

[GitHub] [flink] flinkbot commented on pull request #21726: [FLINK-30748][docs]Translate "Overview" page of "Querys" into Chinese

flinkbot commented on PR #21726: URL: https://github.com/apache/flink/pull/21726#issuecomment-1396471685 ## CI report: * 92a18af335774a0f49b3a22f26b8abbd576dd4bd UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

<    1   2   3   4   5   6   7   8   9   10   >