[GitHub] xccui commented on issue #6003: [FLINK-9289][Dataset] Parallelism of generated operators should have max parallelism of input

2018-08-15 Thread GitBox
xccui commented on issue #6003: [FLINK-9289][Dataset] Parallelism of generated operators should have max parallelism of input URL: https://github.com/apache/flink/pull/6003#issuecomment-413163702 Hi @fhueske. I just added some tests for the union operator. Thanks, Xingcan

[GitHub] buptljy commented on a change in pull request #6541: [FLINK-9964] [table] Add a CSV table format factory

2018-08-15 Thread GitBox
buptljy commented on a change in pull request #6541: [FLINK-9964] [table] Add a CSV table format factory URL: https://github.com/apache/flink/pull/6541#discussion_r210247786 ## File path:

[GitHub] pavel-shvetsov-git opened a new pull request #6559: [FLINK-10045] [Startup Shell Scripts] .bat script to start/stop Flink daemon

2018-08-15 Thread GitBox
pavel-shvetsov-git opened a new pull request #6559: [FLINK-10045] [Startup Shell Scripts] .bat script to start/stop Flink daemon URL: https://github.com/apache/flink/pull/6559 Created scripts to start/stop Flink as daemon ## Does this pull request potentially affect one of the

[GitHub] yanghua commented on a change in pull request #6367: [FLINK-9850] Add a string to the print method to identify output for DataStream

2018-08-15 Thread GitBox
yanghua commented on a change in pull request #6367: [FLINK-9850] Add a string to the print method to identify output for DataStream URL: https://github.com/apache/flink/pull/6367#discussion_r210299902 ## File path:

[GitHub] klion26 opened a new pull request #6558: [FLINK-9116] Introduce getAll and removeAll for MapState

2018-08-15 Thread GitBox
klion26 opened a new pull request #6558: [FLINK-9116] Introduce getAll and removeAll for MapState URL: https://github.com/apache/flink/pull/6558 ## What is the purpose of the change Introduce getAll and removeAll for MapState ## Verifying this change This change

[GitHub] yanghua removed a comment on issue #6494: [FLINK-10059] [table] Add LTRIM supported in Table API and SQL

2018-08-15 Thread GitBox
yanghua removed a comment on issue #6494: [FLINK-10059] [table] Add LTRIM supported in Table API and SQL URL: https://github.com/apache/flink/pull/6494#issuecomment-413246632 @xccui refactored this PR and will also refactor `RTRIM` soon.

[GitHub] yanghua commented on issue #6494: [FLINK-10059] [table] Add LTRIM supported in Table API and SQL

2018-08-15 Thread GitBox
yanghua commented on issue #6494: [FLINK-10059] [table] Add LTRIM supported in Table API and SQL URL: https://github.com/apache/flink/pull/6494#issuecomment-413246632 @xccui refactored this PR and will also refactor `RTRIM` soon.

[GitHub] aljoscha commented on issue #5304: [FLINK-8290]Modify clientId to groupId in flink-connector-kafka-0.8

2018-08-15 Thread GitBox
aljoscha commented on issue #5304: [FLINK-8290]Modify clientId to groupId in flink-connector-kafka-0.8 URL: https://github.com/apache/flink/pull/5304#issuecomment-413204273 Merged, thanks all!  This is an automated message

[GitHub] aljoscha closed pull request #5304: [FLINK-8290]Modify clientId to groupId in flink-connector-kafka-0.8

2018-08-15 Thread GitBox
aljoscha closed pull request #5304: [FLINK-8290]Modify clientId to groupId in flink-connector-kafka-0.8 URL: https://github.com/apache/flink/pull/5304 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] alpinegizmo commented on issue #6434: [FLINK-6968] [table] Add Queryable table sink.

2018-08-15 Thread GitBox
alpinegizmo commented on issue #6434: [FLINK-6968] [table] Add Queryable table sink. URL: https://github.com/apache/flink/pull/6434#issuecomment-413203702 The documentation is pretty thin. It would be nice to explain that the queryable table sink can only be used in retract mode, and

[GitHub] tillrohrmann commented on issue #6451: [FLINK-9936] Resource manager connect to mesos after leadership granted. .

2018-08-15 Thread GitBox
tillrohrmann commented on issue #6451: [FLINK-9936] Resource manager connect to mesos after leadership granted. . URL: https://github.com/apache/flink/pull/6451#issuecomment-413195708 Subsumed by #6464 This is an automated

[GitHub] tillrohrmann closed pull request #6451: [FLINK-9936] Resource manager connect to mesos after leadership granted. .

2018-08-15 Thread GitBox
tillrohrmann closed pull request #6451: [FLINK-9936] Resource manager connect to mesos after leadership granted. . URL: https://github.com/apache/flink/pull/6451 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] alpinegizmo commented on a change in pull request #6504: [FLINK-10068][docs] Add documentation for RocksDB-based timers and st…

2018-08-15 Thread GitBox
alpinegizmo commented on a change in pull request #6504: [FLINK-10068][docs] Add documentation for RocksDB-based timers and st… URL: https://github.com/apache/flink/pull/6504#discussion_r210268466 ## File path: docs/ops/state/large_state_tuning.md ## @@ -142,6 +142,17 @@

[GitHub] alpinegizmo commented on a change in pull request #6504: [FLINK-10068][docs] Add documentation for RocksDB-based timers and st…

2018-08-15 Thread GitBox
alpinegizmo commented on a change in pull request #6504: [FLINK-10068][docs] Add documentation for RocksDB-based timers and st… URL: https://github.com/apache/flink/pull/6504#discussion_r210269211 ## File path: docs/ops/state/large_state_tuning.md ## @@ -177,12 +188,11 @@

[GitHub] alpinegizmo commented on a change in pull request #6504: [FLINK-10068][docs] Add documentation for RocksDB-based timers and st…

2018-08-15 Thread GitBox
alpinegizmo commented on a change in pull request #6504: [FLINK-10068][docs] Add documentation for RocksDB-based timers and st… URL: https://github.com/apache/flink/pull/6504#discussion_r210267407 ## File path: docs/ops/state/large_state_tuning.md ## @@ -142,6 +142,17 @@

[GitHub] alpinegizmo commented on a change in pull request #6504: [FLINK-10068][docs] Add documentation for RocksDB-based timers and st…

2018-08-15 Thread GitBox
alpinegizmo commented on a change in pull request #6504: [FLINK-10068][docs] Add documentation for RocksDB-based timers and st… URL: https://github.com/apache/flink/pull/6504#discussion_r210269294 ## File path: docs/ops/state/large_state_tuning.md ## @@ -177,12 +188,11 @@

[GitHub] tillrohrmann opened a new pull request #6562: [Backport 1.6][FLINK-10001][docs] Update Docker and Kubernetes documentation

2018-08-15 Thread GitBox
tillrohrmann opened a new pull request #6562: [Backport 1.6][FLINK-10001][docs] Update Docker and Kubernetes documentation URL: https://github.com/apache/flink/pull/6562 ## What is the purpose of the change Backport of #6561 for `release-1.6`. This PR updates Flink's Docker

[GitHub] asfgit closed pull request #6135: [FLINK-9546][core] Fix the checking of heartbeatTimeoutIntervalMs in HeartbeatMonitor.

2018-08-15 Thread GitBox
asfgit closed pull request #6135: [FLINK-9546][core] Fix the checking of heartbeatTimeoutIntervalMs in HeartbeatMonitor. URL: https://github.com/apache/flink/pull/6135 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] yanghua commented on issue #6494: [FLINK-10059] [table] Add LTRIM supported in Table API and SQL

2018-08-15 Thread GitBox
yanghua commented on issue #6494: [FLINK-10059] [table] Add LTRIM supported in Table API and SQL URL: https://github.com/apache/flink/pull/6494#issuecomment-413246553 @xccui refactored this PR and will also refactor `RTRIM` soon.

[GitHub] dawidwys closed pull request #6294: [FLINK-9013][docs] Document yarn.containers.vcores only being effective whe…

2018-08-15 Thread GitBox
dawidwys closed pull request #6294: [FLINK-9013][docs] Document yarn.containers.vcores only being effective whe… URL: https://github.com/apache/flink/pull/6294 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] pavel-shvetsov-git opened a new pull request #6560: [FLINK-9889] [Startup Shell Scripts] create .bat script to start Flink task manager

2018-08-15 Thread GitBox
pavel-shvetsov-git opened a new pull request #6560: [FLINK-9889] [Startup Shell Scripts] create .bat script to start Flink task manager URL: https://github.com/apache/flink/pull/6560 Created .bat script to start Flink task manager. Uses scripts flink-console.bat and flink-daemon.bat -

[GitHub] tillrohrmann opened a new pull request #6561: [FLINK-10001][docs] Update Docker and Kubernetes documentation

2018-08-15 Thread GitBox
tillrohrmann opened a new pull request #6561: [FLINK-10001][docs] Update Docker and Kubernetes documentation URL: https://github.com/apache/flink/pull/6561 ## What is the purpose of the change This PR updates Flink's Docker and Kubernetes documentation to include the job mode for

[GitHub] Guibo-Pan commented on issue #6544: [FLINK-8532] [Streaming] modify RebalancePartitioner to use a random partition as its first partition

2018-08-15 Thread GitBox
Guibo-Pan commented on issue #6544: [FLINK-8532] [Streaming] modify RebalancePartitioner to use a random partition as its first partition URL: https://github.com/apache/flink/pull/6544#issuecomment-413236534 cc @zentol @StephanEwen

[GitHub] yanghua commented on issue #6367: [FLINK-9850] Add a string to the print method to identify output for DataStream

2018-08-15 Thread GitBox
yanghua commented on issue #6367: [FLINK-9850] Add a string to the print method to identify output for DataStream URL: https://github.com/apache/flink/pull/6367#issuecomment-413245077 cc @pnowojski This is an automated

[GitHub] bowenli86 commented on issue #6564: [FLINK-10154] [kinesis connector] Make sure we always read at least one record in Kinesis Connector.

2018-08-15 Thread GitBox
bowenli86 commented on issue #6564: [FLINK-10154] [kinesis connector] Make sure we always read at least one record in Kinesis Connector. URL: https://github.com/apache/flink/pull/6564#issuecomment-413363019 +1 This is an

[GitHub] buptljy commented on issue #6359: [FLINK-6895][table]Add STR_TO_DATE supported in SQL

2018-08-15 Thread GitBox
buptljy commented on issue #6359: [FLINK-6895][table]Add STR_TO_DATE supported in SQL URL: https://github.com/apache/flink/pull/6359#issuecomment-413141040 @twalthr I add a literalValue in GeneratedExpression, because the case class cannot be inherited. And the default value is None, so

[GitHub] fhueske opened a new pull request #6565: [FLINK-10153] [docs] Add Tutorials section and rework structure.

2018-08-15 Thread GitBox
fhueske opened a new pull request #6565: [FLINK-10153] [docs] Add Tutorials section and rework structure. URL: https://github.com/apache/flink/pull/6565 ## What is the purpose of the change This PR is restructuring some parts of the documentation and mostly moving docs pages

[GitHub] asfgit closed pull request #6530: [FLINK-10110][tests] Harden Kafka component shut down for E2E tests

2018-08-15 Thread GitBox
asfgit closed pull request #6530: [FLINK-10110][tests] Harden Kafka component shut down for E2E tests URL: https://github.com/apache/flink/pull/6530 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] azagrebin commented on issue #6563: [FLINK-10151] [State TTL] Fix false recursion call in TransformingStateTableKeyGroupPartitioner.tryAddToSource

2018-08-15 Thread GitBox
azagrebin commented on issue #6563: [FLINK-10151] [State TTL] Fix false recursion call in TransformingStateTableKeyGroupPartitioner.tryAddToSource URL: https://github.com/apache/flink/pull/6563#issuecomment-413270072 cc @StefanRRichter

[GitHub] azagrebin opened a new pull request #6563: [FLINK-10151] [State TTL] Fix false recursion call in TransformingStateTableKeyGroupPartitioner.tryAddToSource

2018-08-15 Thread GitBox
azagrebin opened a new pull request #6563: [FLINK-10151] [State TTL] Fix false recursion call in TransformingStateTableKeyGroupPartitioner.tryAddToSource URL: https://github.com/apache/flink/pull/6563 ## What is the purpose of the change This PR fixes bug in

[GitHub] asfgit closed pull request #6003: [FLINK-9289][Dataset] Parallelism of generated operators should have max parallelism of input

2018-08-15 Thread GitBox
asfgit closed pull request #6003: [FLINK-9289][Dataset] Parallelism of generated operators should have max parallelism of input URL: https://github.com/apache/flink/pull/6003 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below

[GitHub] buptljy commented on issue #6541: [FLINK-9964] [table] Add a CSV table format factory

2018-08-15 Thread GitBox
buptljy commented on issue #6541: [FLINK-9964] [table] Add a CSV table format factory URL: https://github.com/apache/flink/pull/6541#issuecomment-413285602 @twalthr I've replied a few coments above and optimize some codes according to your coments. I've finished: 1. Null value

[GitHub] tillrohrmann commented on issue #6530: [FLINK-10110][tests] Harden Kafka component shut down for E2E tests

2018-08-15 Thread GitBox
tillrohrmann commented on issue #6530: [FLINK-10110][tests] Harden Kafka component shut down for E2E tests URL: https://github.com/apache/flink/pull/6530#issuecomment-413307845 Merging this PR since it only affects the Kafka e2e test tooling.

[GitHub] jgrier opened a new pull request #6564: [FLINK-10154] [kinesis connector] Make sure we always read at least one record in Kinesis Connector.

2018-08-15 Thread GitBox
jgrier opened a new pull request #6564: [FLINK-10154] [kinesis connector] Make sure we always read at least one record in Kinesis Connector. URL: https://github.com/apache/flink/pull/6564 ## What is the purpose of the change Fixing a bug that can cause the Kinesis Connector to

[GitHub] xccui commented on a change in pull request #6565: [FLINK-10153] [docs] Add Tutorials section and rework structure.

2018-08-15 Thread GitBox
xccui commented on a change in pull request #6565: [FLINK-10153] [docs] Add Tutorials section and rework structure. URL: https://github.com/apache/flink/pull/6565#discussion_r210453174 ## File path: docs/examples/index.md ## @@ -25,15 +25,24 @@ specific language governing

[GitHub] xccui commented on a change in pull request #6565: [FLINK-10153] [docs] Add Tutorials section and rework structure.

2018-08-15 Thread GitBox
xccui commented on a change in pull request #6565: [FLINK-10153] [docs] Add Tutorials section and rework structure. URL: https://github.com/apache/flink/pull/6565#discussion_r210453136 ## File path: docs/examples/index.md ## @@ -25,15 +25,24 @@ specific language governing

[GitHub] TisonKun commented on a change in pull request #6565: [FLINK-10153] [docs] Add Tutorials section and rework structure.

2018-08-15 Thread GitBox
TisonKun commented on a change in pull request #6565: [FLINK-10153] [docs] Add Tutorials section and rework structure. URL: https://github.com/apache/flink/pull/6565#discussion_r210446790 ## File path: docs/building/ide_setup.md ## @@ -1,6 +1,6 @@ --- -title: "IDE Setup"

[GitHub] TisonKun commented on a change in pull request #6565: [FLINK-10153] [docs] Add Tutorials section and rework structure.

2018-08-15 Thread GitBox
TisonKun commented on a change in pull request #6565: [FLINK-10153] [docs] Add Tutorials section and rework structure. URL: https://github.com/apache/flink/pull/6565#discussion_r210446227 ## File path: docs/dev/batch/examples.md ## @@ -27,8 +27,7 @@ The following example

[GitHub] TisonKun commented on a change in pull request #6565: [FLINK-10153] [docs] Add Tutorials section and rework structure.

2018-08-15 Thread GitBox
TisonKun commented on a change in pull request #6565: [FLINK-10153] [docs] Add Tutorials section and rework structure. URL: https://github.com/apache/flink/pull/6565#discussion_r210447328 ## File path: docs/dev/projectsetup/index.md ## @@ -0,0 +1,25 @@ +--- +title:

[GitHub] TisonKun commented on a change in pull request #6565: [FLINK-10153] [docs] Add Tutorials section and rework structure.

2018-08-15 Thread GitBox
TisonKun commented on a change in pull request #6565: [FLINK-10153] [docs] Add Tutorials section and rework structure. URL: https://github.com/apache/flink/pull/6565#discussion_r210446630 ## File path: docs/building/index.md ## @@ -1,10 +1,10 @@ --- section-break: true

[GitHub] TisonKun commented on a change in pull request #6565: [FLINK-10153] [docs] Add Tutorials section and rework structure.

2018-08-15 Thread GitBox
TisonKun commented on a change in pull request #6565: [FLINK-10153] [docs] Add Tutorials section and rework structure. URL: https://github.com/apache/flink/pull/6565#discussion_r210446691 ## File path: docs/building/index.md ## @@ -1,10 +1,10 @@ --- section-break: true

[GitHub] TisonKun commented on a change in pull request #6565: [FLINK-10153] [docs] Add Tutorials section and rework structure.

2018-08-15 Thread GitBox
TisonKun commented on a change in pull request #6565: [FLINK-10153] [docs] Add Tutorials section and rework structure. URL: https://github.com/apache/flink/pull/6565#discussion_r210445845 ## File path: docs/tutorials/local_setup.md ## @@ -1,8 +1,8 @@ --- -title:

[GitHub] tragicjun removed a comment on issue #6508: [Flink-10079] [table] Automatically register sink table from external catalogs

2018-08-15 Thread GitBox
tragicjun removed a comment on issue #6508: [Flink-10079] [table] Automatically register sink table from external catalogs URL: https://github.com/apache/flink/pull/6508#issuecomment-411243850 @zentol already fixed, thanks.

[GitHub] asfgit closed pull request #6522: [FLINK-10101][mesos] Add web ui url for mesos.

2018-08-16 Thread GitBox
asfgit closed pull request #6522: [FLINK-10101][mesos] Add web ui url for mesos. URL: https://github.com/apache/flink/pull/6522 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] tragicjun commented on a change in pull request #6508: [Flink-10079] [table] Automatically register sink table from external catalogs

2018-08-15 Thread GitBox
tragicjun commented on a change in pull request #6508: [Flink-10079] [table] Automatically register sink table from external catalogs URL: https://github.com/apache/flink/pull/6508#discussion_r210471287 ## File path:

[GitHub] morenn520 commented on issue #5987: [FLINK-9043][CLI]Automatically search for the last successful checkpoint when recover the job from externalized checkpoint

2018-08-15 Thread GitBox
morenn520 commented on issue #5987: [FLINK-9043][CLI]Automatically search for the last successful checkpoint when recover the job from externalized checkpoint URL: https://github.com/apache/flink/pull/5987#issuecomment-413432296 @sihuazhou Has this feature been completed or tested?We met

[GitHub] tragicjun commented on a change in pull request #6508: [Flink-10079] [table] Automatically register sink table from external catalogs

2018-08-15 Thread GitBox
tragicjun commented on a change in pull request #6508: [Flink-10079] [table] Automatically register sink table from external catalogs URL: https://github.com/apache/flink/pull/6508#discussion_r210471287 ## File path:

[GitHub] StefanRRichter commented on a change in pull request #6558: [FLINK-9116] Introduce getAll and removeAll for MapState

2018-08-16 Thread GitBox
StefanRRichter commented on a change in pull request #6558: [FLINK-9116] Introduce getAll and removeAll for MapState URL: https://github.com/apache/flink/pull/6558#discussion_r210509286 ## File path:

[GitHub] StefanRRichter commented on a change in pull request #6558: [FLINK-9116] Introduce getAll and removeAll for MapState

2018-08-16 Thread GitBox
StefanRRichter commented on a change in pull request #6558: [FLINK-9116] Introduce getAll and removeAll for MapState URL: https://github.com/apache/flink/pull/6558#discussion_r210509235 ## File path:

[GitHub] TisonKun commented on issue #6345: [FLINK-9869][runtime] Send PartitionInfo in batch to Improve perfornance

2018-08-16 Thread GitBox
TisonKun commented on issue #6345: [FLINK-9869][runtime] Send PartitionInfo in batch to Improve perfornance URL: https://github.com/apache/flink/pull/6345#issuecomment-413463126 ping @tillrohrmann FYI, travis fails on `BucketingSinkFaultToleranceITCase`, but I run ~1000 times locally

[GitHub] pnowojski commented on a change in pull request #6367: [FLINK-9850] Add a string to the print method to identify output for DataStream

2018-08-16 Thread GitBox
pnowojski commented on a change in pull request #6367: [FLINK-9850] Add a string to the print method to identify output for DataStream URL: https://github.com/apache/flink/pull/6367#discussion_r210511275 ## File path:

[GitHub] pnowojski commented on a change in pull request #6367: [FLINK-9850] Add a string to the print method to identify output for DataStream

2018-08-16 Thread GitBox
pnowojski commented on a change in pull request #6367: [FLINK-9850] Add a string to the print method to identify output for DataStream URL: https://github.com/apache/flink/pull/6367#discussion_r210509687 ## File path:

[GitHub] StefanRRichter edited a comment on issue #6498: [FLINK-10065] InstantiationUtil.deserializeObject(InputStream in, ClassLoader cl, boolean isFailureTolerant) will close the inputStream

2018-08-16 Thread GitBox
StefanRRichter edited a comment on issue #6498: [FLINK-10065] InstantiationUtil.deserializeObject(InputStream in, ClassLoader cl, boolean isFailureTolerant) will close the inputStream URL: https://github.com/apache/flink/pull/6498#issuecomment-413465964 @klion26 The mentioned method is a

[GitHub] StefanRRichter commented on issue #6498: [FLINK-10065] InstantiationUtil.deserializeObject(InputStream in, ClassLoader cl, boolean isFailureTolerant) will close the inputStream

2018-08-16 Thread GitBox
StefanRRichter commented on issue #6498: [FLINK-10065] InstantiationUtil.deserializeObject(InputStream in, ClassLoader cl, boolean isFailureTolerant) will close the inputStream URL: https://github.com/apache/flink/pull/6498#issuecomment-413465964 @klion26 The mentioned method is a legacy

[GitHub] zentol commented on issue #6367: [FLINK-9850] Add a string to the print method to identify output for DataStream

2018-08-16 Thread GitBox
zentol commented on issue #6367: [FLINK-9850] Add a string to the print method to identify output for DataStream URL: https://github.com/apache/flink/pull/6367#issuecomment-413476883 yes. This is an automated message from

[GitHub] rickhofstede commented on a change in pull request #6503: [FLINK-10072] [docs] Syntax and consistency issues in "The Broadcast State Pattern"

2018-08-16 Thread GitBox
rickhofstede commented on a change in pull request #6503: [FLINK-10072] [docs] Syntax and consistency issues in "The Broadcast State Pattern" URL: https://github.com/apache/flink/pull/6503#discussion_r210502182 ## File path: docs/dev/stream/state/broadcast_state.md ## @@

[GitHub] tillrohrmann closed pull request #6531: [release-1.6][FLINK-10110][tests] Harden Kafka component shut down for E2E tests

2018-08-16 Thread GitBox
tillrohrmann closed pull request #6531: [release-1.6][FLINK-10110][tests] Harden Kafka component shut down for E2E tests URL: https://github.com/apache/flink/pull/6531 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] tillrohrmann commented on issue #6531: [release-1.6][FLINK-10110][tests] Harden Kafka component shut down for E2E tests

2018-08-16 Thread GitBox
tillrohrmann commented on issue #6531: [release-1.6][FLINK-10110][tests] Harden Kafka component shut down for E2E tests URL: https://github.com/apache/flink/pull/6531#issuecomment-413458673 Merged via 17eeb5aa665b8fa8ae49e6d7179af67136f377bd

[GitHub] StefanRRichter commented on a change in pull request #6558: [FLINK-9116] Introduce getAll and removeAll for MapState

2018-08-16 Thread GitBox
StefanRRichter commented on a change in pull request #6558: [FLINK-9116] Introduce getAll and removeAll for MapState URL: https://github.com/apache/flink/pull/6558#discussion_r210507286 ## File path:

[GitHub] zentol commented on a change in pull request #6367: [FLINK-9850] Add a string to the print method to identify output for DataStream

2018-08-16 Thread GitBox
zentol commented on a change in pull request #6367: [FLINK-9850] Add a string to the print method to identify output for DataStream URL: https://github.com/apache/flink/pull/6367#discussion_r210514030 ## File path:

[GitHub] yanghua commented on a change in pull request #6367: [FLINK-9850] Add a string to the print method to identify output for DataStream

2018-08-16 Thread GitBox
yanghua commented on a change in pull request #6367: [FLINK-9850] Add a string to the print method to identify output for DataStream URL: https://github.com/apache/flink/pull/6367#discussion_r210513770 ## File path:

[GitHub] zhijiangW commented on issue #6417: [FLINK-9913][runtime] Improve output serialization only once in RecordWriter

2018-08-16 Thread GitBox
zhijiangW commented on issue #6417: [FLINK-9913][runtime] Improve output serialization only once in RecordWriter URL: https://github.com/apache/flink/pull/6417#issuecomment-413468551 @pnowojski , I think I got the reason of regression in some non-broadcast cases. The key point is

[GitHub] zentol commented on issue #6367: [FLINK-9850] Add a string to the print method to identify output for DataStream

2018-08-16 Thread GitBox
zentol commented on issue #6367: [FLINK-9850] Add a string to the print method to identify output for DataStream URL: https://github.com/apache/flink/pull/6367#issuecomment-413468227 Personally I would prefer if we'd not change the python API in this PR, because we're now in the exact

[GitHub] TisonKun commented on issue #6339: [FLINK-9859] [runtime] More Akka config

2018-08-16 Thread GitBox
TisonKun commented on issue #6339: [FLINK-9859] [runtime] More Akka config URL: https://github.com/apache/flink/pull/6339#issuecomment-413458376 @tillrohrmann The original purpose of this PR is to distinguish akka config of JM and TM, since JM would require more resource. Now we

[GitHub] TisonKun edited a comment on issue #6339: [FLINK-9859] [runtime] More Akka config

2018-08-16 Thread GitBox
TisonKun edited a comment on issue #6339: [FLINK-9859] [runtime] More Akka config URL: https://github.com/apache/flink/pull/6339#issuecomment-413458376 @tillrohrmann The original purpose of this PR is to distinguish akka config of JM and TM, since JM would require more resource.

[GitHub] StefanRRichter commented on a change in pull request #6558: [FLINK-9116] Introduce getAll and removeAll for MapState

2018-08-16 Thread GitBox
StefanRRichter commented on a change in pull request #6558: [FLINK-9116] Introduce getAll and removeAll for MapState URL: https://github.com/apache/flink/pull/6558#discussion_r210507581 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapMapState.java

[GitHub] StefanRRichter commented on a change in pull request #6558: [FLINK-9116] Introduce getAll and removeAll for MapState

2018-08-16 Thread GitBox
StefanRRichter commented on a change in pull request #6558: [FLINK-9116] Introduce getAll and removeAll for MapState URL: https://github.com/apache/flink/pull/6558#discussion_r210508829 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapMapState.java

[GitHub] StefanRRichter commented on a change in pull request #6558: [FLINK-9116] Introduce getAll and removeAll for MapState

2018-08-16 Thread GitBox
StefanRRichter commented on a change in pull request #6558: [FLINK-9116] Introduce getAll and removeAll for MapState URL: https://github.com/apache/flink/pull/6558#discussion_r210510928 ## File path:

[GitHub] tillrohrmann closed pull request #6561: [FLINK-10001][docs] Update Docker and Kubernetes documentation

2018-08-16 Thread GitBox
tillrohrmann closed pull request #6561: [FLINK-10001][docs] Update Docker and Kubernetes documentation URL: https://github.com/apache/flink/pull/6561 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] tillrohrmann opened a new pull request #6561: [FLINK-10001][docs] Update Docker and Kubernetes documentation

2018-08-16 Thread GitBox
tillrohrmann opened a new pull request #6561: [FLINK-10001][docs] Update Docker and Kubernetes documentation URL: https://github.com/apache/flink/pull/6561 ## What is the purpose of the change This PR updates Flink's Docker and Kubernetes documentation to include the job mode for

[GitHub] StefanRRichter commented on issue #6563: [FLINK-10151] [State TTL] Fix false recursion call in TransformingStateTableKeyGroupPartitioner.tryAddToSource

2018-08-16 Thread GitBox
StefanRRichter commented on issue #6563: [FLINK-10151] [State TTL] Fix false recursion call in TransformingStateTableKeyGroupPartitioner.tryAddToSource URL: https://github.com/apache/flink/pull/6563#issuecomment-413466827 LGTM  Merging.

[GitHub] zentol commented on a change in pull request #6367: [FLINK-9850] Add a string to the print method to identify output for DataStream

2018-08-16 Thread GitBox
zentol commented on a change in pull request #6367: [FLINK-9850] Add a string to the print method to identify output for DataStream URL: https://github.com/apache/flink/pull/6367#discussion_r210515127 ## File path:

[GitHub] asfgit closed pull request #6563: [FLINK-10151] [State TTL] Fix false recursion call in TransformingStateTableKeyGroupPartitioner.tryAddToSource

2018-08-16 Thread GitBox
asfgit closed pull request #6563: [FLINK-10151] [State TTL] Fix false recursion call in TransformingStateTableKeyGroupPartitioner.tryAddToSource URL: https://github.com/apache/flink/pull/6563 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is

[GitHub] zentol commented on a change in pull request #6367: [FLINK-9850] Add a string to the print method to identify output for DataStream

2018-08-16 Thread GitBox
zentol commented on a change in pull request #6367: [FLINK-9850] Add a string to the print method to identify output for DataStream URL: https://github.com/apache/flink/pull/6367#discussion_r210514892 ## File path:

[GitHub] zentol commented on a change in pull request #6367: [FLINK-9850] Add a string to the print method to identify output for DataStream

2018-08-16 Thread GitBox
zentol commented on a change in pull request #6367: [FLINK-9850] Add a string to the print method to identify output for DataStream URL: https://github.com/apache/flink/pull/6367#discussion_r210514892 ## File path:

[GitHub] yanghua commented on issue #6367: [FLINK-9850] Add a string to the print method to identify output for DataStream

2018-08-16 Thread GitBox
yanghua commented on issue #6367: [FLINK-9850] Add a string to the print method to identify output for DataStream URL: https://github.com/apache/flink/pull/6367#issuecomment-413470612 @zentol Do you mean that we don't change the python API here and remove the tests for the Python API?

[GitHub] fhueske commented on a change in pull request #6565: [FLINK-10153] [docs] Add Tutorials section and rework structure.

2018-08-16 Thread GitBox
fhueske commented on a change in pull request #6565: [FLINK-10153] [docs] Add Tutorials section and rework structure. URL: https://github.com/apache/flink/pull/6565#discussion_r210521666 ## File path: docs/tutorials/local_setup.md ## @@ -1,8 +1,8 @@ --- -title:

[GitHub] maqingxiang opened a new pull request #6566: Feature add host in checkpoint detail

2018-08-16 Thread GitBox
maqingxiang opened a new pull request #6566: Feature add host in checkpoint detail URL: https://github.com/apache/flink/pull/6566 Add the host information to the checkpoint so that if the checkpoint fails, you can specifically login to the appropriate machine to see the cause of the

[GitHub] fhueske commented on a change in pull request #6565: [FLINK-10153] [docs] Add Tutorials section and rework structure.

2018-08-16 Thread GitBox
fhueske commented on a change in pull request #6565: [FLINK-10153] [docs] Add Tutorials section and rework structure. URL: https://github.com/apache/flink/pull/6565#discussion_r210522579 ## File path: docs/dev/batch/examples.md ## @@ -27,8 +27,7 @@ The following example

[GitHub] alpinegizmo commented on a change in pull request #6561: [FLINK-10001][docs] Update Docker and Kubernetes documentation

2018-08-16 Thread GitBox
alpinegizmo commented on a change in pull request #6561: [FLINK-10001][docs] Update Docker and Kubernetes documentation URL: https://github.com/apache/flink/pull/6561#discussion_r210523296 ## File path: docs/ops/deployment/kubernetes.md ## @@ -23,51 +23,78 @@ specific

[GitHub] alpinegizmo commented on a change in pull request #6561: [FLINK-10001][docs] Update Docker and Kubernetes documentation

2018-08-16 Thread GitBox
alpinegizmo commented on a change in pull request #6561: [FLINK-10001][docs] Update Docker and Kubernetes documentation URL: https://github.com/apache/flink/pull/6561#discussion_r210522820 ## File path: docs/ops/deployment/kubernetes.md ## @@ -23,51 +23,78 @@ specific

[GitHub] alpinegizmo commented on a change in pull request #6561: [FLINK-10001][docs] Update Docker and Kubernetes documentation

2018-08-16 Thread GitBox
alpinegizmo commented on a change in pull request #6561: [FLINK-10001][docs] Update Docker and Kubernetes documentation URL: https://github.com/apache/flink/pull/6561#discussion_r210522416 ## File path: docs/ops/deployment/kubernetes.md ## @@ -23,51 +23,78 @@ specific

[GitHub] yanghua opened a new pull request #6567: [FLINK-10074] Allowable number of checkpoint failures

2018-08-16 Thread GitBox
yanghua opened a new pull request #6567: [FLINK-10074] Allowable number of checkpoint failures URL: https://github.com/apache/flink/pull/6567 ## What is the purpose of the change *This pull request allows number of checkpoint failures* ## Brief change log - *Add a new

[GitHub] pnowojski commented on a change in pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl options

2018-08-16 Thread GitBox
pnowojski commented on a change in pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl options URL: https://github.com/apache/flink/pull/6355#discussion_r210531098 ## File path:

[GitHub] pnowojski commented on a change in pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl options

2018-08-16 Thread GitBox
pnowojski commented on a change in pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl options URL: https://github.com/apache/flink/pull/6355#discussion_r210523907 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/net/SSLUtils.java ##

[GitHub] pnowojski commented on a change in pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl options

2018-08-16 Thread GitBox
pnowojski commented on a change in pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl options URL: https://github.com/apache/flink/pull/6355#discussion_r210529443 ## File path:

[GitHub] pnowojski commented on a change in pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl options

2018-08-16 Thread GitBox
pnowojski commented on a change in pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl options URL: https://github.com/apache/flink/pull/6355#discussion_r210514431 ## File path:

[GitHub] pnowojski commented on a change in pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl options

2018-08-16 Thread GitBox
pnowojski commented on a change in pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl options URL: https://github.com/apache/flink/pull/6355#discussion_r210515177 ## File path:

[GitHub] pnowojski commented on a change in pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl options

2018-08-16 Thread GitBox
pnowojski commented on a change in pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl options URL: https://github.com/apache/flink/pull/6355#discussion_r210515882 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/net/SSLUtils.java ##

[GitHub] pnowojski commented on a change in pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl options

2018-08-16 Thread GitBox
pnowojski commented on a change in pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl options URL: https://github.com/apache/flink/pull/6355#discussion_r210515985 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/net/SSLUtils.java ##

[GitHub] yanghua commented on issue #6567: [FLINK-10074] Allowable number of checkpoint failures

2018-08-16 Thread GitBox
yanghua commented on issue #6567: [FLINK-10074] Allowable number of checkpoint failures URL: https://github.com/apache/flink/pull/6567#issuecomment-413486884 cc @tillrohrmann This is an automated message from the Apache Git

[GitHub] TisonKun commented on a change in pull request #6565: [FLINK-10153] [docs] Add Tutorials section and rework structure.

2018-08-16 Thread GitBox
TisonKun commented on a change in pull request #6565: [FLINK-10153] [docs] Add Tutorials section and rework structure. URL: https://github.com/apache/flink/pull/6565#discussion_r210527451 ## File path: docs/dev/batch/examples.md ## @@ -27,8 +27,7 @@ The following example

[GitHub] TisonKun commented on a change in pull request #6565: [FLINK-10153] [docs] Add Tutorials section and rework structure.

2018-08-16 Thread GitBox
TisonKun commented on a change in pull request #6565: [FLINK-10153] [docs] Add Tutorials section and rework structure. URL: https://github.com/apache/flink/pull/6565#discussion_r210527451 ## File path: docs/dev/batch/examples.md ## @@ -27,8 +27,7 @@ The following example

[GitHub] yanghua commented on issue #6367: [FLINK-9850] Add a string to the print method to identify output for DataStream

2018-08-16 Thread GitBox
yanghua commented on issue #6367: [FLINK-9850] Add a string to the print method to identify output for DataStream URL: https://github.com/apache/flink/pull/6367#issuecomment-413483130 @pnowojski Python-related changes have been removed, only changes to Java and Scala

[GitHub] pnowojski commented on issue #6417: [FLINK-9913][runtime] Improve output serialization only once in RecordWriter

2018-08-16 Thread GitBox
pnowojski commented on issue #6417: [FLINK-9913][runtime] Improve output serialization only once in RecordWriter URL: https://github.com/apache/flink/pull/6417#issuecomment-413491900 Nice find. I missed that :) This is an

[GitHub] TisonKun commented on issue #6339: [FLINK-9859] [runtime] More Akka config

2018-08-13 Thread GitBox
TisonKun commented on issue #6339: [FLINK-9859] [runtime] More Akka config URL: https://github.com/apache/flink/pull/6339#issuecomment-412743884 ping @tillrohrmann :-) This is an automated message from the Apache Git

[GitHub] alexeyt820 opened a new pull request #6549: [FLINK-10127] Add Instant to basic types

2018-08-13 Thread GitBox
alexeyt820 opened a new pull request #6549: [FLINK-10127] Add Instant to basic types URL: https://github.com/apache/flink/pull/6549 ## What is the purpose of the change This pull requests add JDK8 Instant type as basic type to Flink type system ## Brief change log -

[GitHub] xccui commented on issue #6535: [FLINK-9977] [table][doc] Refine the SQL/Table built-in function docs

2018-08-13 Thread GitBox
xccui commented on issue #6535: [FLINK-9977] [table][doc] Refine the SQL/Table built-in function docs URL: https://github.com/apache/flink/pull/6535#issuecomment-412717935 Thanks for the review, @fhueske. Will merge this.

[GitHub] yanghua edited a comment on issue #6542: [FLINK-6437][History Server] Move history server configuration to a separate file

2018-08-13 Thread GitBox
yanghua edited a comment on issue #6542: [FLINK-6437][History Server] Move history server configuration to a separate file URL: https://github.com/apache/flink/pull/6542#issuecomment-412736043 hi @StephanEwen @zentol , Currently, the history server runs as a single JVM process,

[GitHub] yanghua commented on issue #6542: [FLINK-6437][History Server] Move history server configuration to a separate file

2018-08-13 Thread GitBox
yanghua commented on issue #6542: [FLINK-6437][History Server] Move history server configuration to a separate file URL: https://github.com/apache/flink/pull/6542#issuecomment-412736043 hi @StephanEwen @zentol , Currently, the history server runs as a standalone JVM process, which

<    6   7   8   9   10   11   12   13   14   15   >