[jira] [Commented] (FLINK-14057) Add Remove Other Timers to TimerService

[Jesse Anderson (Jira)]

[ 
https://issues.apache.org/jira/browse/FLINK-14057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928708#comment-16928708
 ] 

Jesse Anderson commented on FLINK-14057:


Of the ideas put forth, I like Elias' the best. I would change it slightly to 
replaceAllProcessingTimeTimers to reinforce that everything else gets removed.

> Add Remove Other Timers to TimerService
> ---
>
> Key: FLINK-14057
> URL: https://issues.apache.org/jira/browse/FLINK-14057
> Project: Flink
>  Issue Type: Improvement
>Reporter: Jesse Anderson
>Priority: Major
>
> The TimerService service has the ability to add timers with 
> registerProcessingTimeTimer. This method can be called many times and have 
> different timer times.
> If you want to add a new timer and delete other timers, you have to keep 
> track of all previous timer times and call deleteProcessingTimeTimer for each 
> time. This method forces you to keep track of all previous (unexpired) timers 
> for a key.
> Instead, I suggest overloading registerProcessingTimeTimer with a second 
> boolean argument that will remove all previous timers and set the new timer.
> Note: although I'm using registerProcessingTimeTimer, this applies to 
> registerEventTimeTimer as well.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Created] (FLINK-14057) Add Remove Other Timers to TimerService

[Jesse Anderson (Jira)]

Jesse Anderson created FLINK-14057:
--

 Summary: Add Remove Other Timers to TimerService
 Key: FLINK-14057
 URL: https://issues.apache.org/jira/browse/FLINK-14057
 Project: Flink
  Issue Type: Improvement
Reporter: Jesse Anderson


The TimerService service has the ability to add timers with 
registerProcessingTimeTimer. This method can be called many times and have 
different timer times.

If you want to add a new timer and delete other timers, you have to keep track 
of all previous timer times and call deleteProcessingTimeTimer for each time. 
This method forces you to keep track of all previous (unexpired) timers for a 
key.

Instead, I suggest overloading registerProcessingTimeTimer with a second 
boolean argument that will remove all previous timers and set the new timer.

Note: although I'm using registerProcessingTimeTimer, this applies to 
registerEventTimeTimer as well.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)