[GitHub] flink pull request: [FLINK-3435] Proparly separate IngestionTime a...

2016-02-24 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1699#issuecomment-188431435 There's also some commented out code but I guess we'll leave that in until we fix the timestamp handling? --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-3435] Proparly separate IngestionTime a...

2016-02-24 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1699#issuecomment-188406380 +1 changes look good, I had some minor comments but that's just naming preferences. Btw, this PR also removes the distinction between `EventTimeSourceFunction

[GitHub] flink pull request: [FLINK-3315] Fix Slot Sharing in Streaming API

2016-02-23 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/1641#discussion_r53817674 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/SlotAllocationTest.java --- @@ -40,17 +48,142 @@ public void test

[GitHub] flink pull request: [FLINK-3450] Duplicate TypeSerializer in State...

2016-02-22 Thread aljoscha
Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/1686 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-3174] Add merging WindowAssigner

2016-02-22 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1460#issuecomment-187187459 This will have to be reworked now that windows use the keyed state abstraction. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request: [FLINK-3418] Don't run RocksDB copy utils in e...

2016-02-22 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/1687 [FLINK-3418] Don't run RocksDB copy utils in external process This was causing to many problems with security tokens and yarn. Now, let the RocksDB backup run in a thread but don't

[GitHub] flink pull request: [FLINK-3174] Add merging WindowAssigner

2016-02-22 Thread aljoscha
Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/1460 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-3439] Remove final Long.MAX_VALUE Water...

2016-02-22 Thread aljoscha
Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/1677 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-3418] Don't run RocksDB copy utils in e...

2016-02-22 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1687#issuecomment-187202268 Should be the correct code now. :smile: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: [FLINK-3418] Don't run RocksDB copy utils in e...

2016-02-22 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/1687#discussion_r53629014 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/util/HDFSCopyFromLocal.java --- @@ -26,32 +25,46 @@ import java.io.File

[GitHub] flink pull request: [FLINK-3035] Redis as State Backend

2016-02-22 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1617#issuecomment-187201289 I don't know enough about redis. Not sure how we can deal with the testing situation. --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: [FLINK-3521] Make Iterable part of method sign...

2016-02-26 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1723#issuecomment-189462738 The `PassThroughFunction` is created because at that point it is not yet clear what type of `InternalWindowFunction` will be created. I can fix it by duplicating all

[GitHub] flink pull request: [FLINK-3521] Make Iterable part of method sign...

2016-02-26 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1723#issuecomment-189463014 1. Is very hard to fix, ditching the non-keyed window operators altogether and using a dummy key selector would be easier. --- If your project is set up for it, you

[GitHub] flink pull request: [FLINK-3527] Add Scala DataStream.transform()

2016-02-26 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/1728 [FLINK-3527] Add Scala DataStream.transform() You can merge this pull request into a Git repository by running: $ git pull https://github.com/aljoscha/flink scala-transform Alternatively

[GitHub] flink pull request: [FLINK-3399] CountWithTimeoutTrigger

2016-02-25 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1636#issuecomment-188874847 I would prefer to just add the compassable way, yes. Sorry that you now already put effort into this. --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-3538] Streamline Scala DataStream.join/...

2016-02-29 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/1740 [FLINK-3538] Streamline Scala DataStream.join/coGroup This enforces that the user always has to specify keys for both inputs before .window() can be called. You can merge this pull request

[GitHub] flink pull request: [FLINK-3536] Make clearer distinction between ...

2016-02-29 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/1739 [FLINK-3536] Make clearer distinction between event time and processi… …ng time This brings it more in line with *ProcessingTimeWindows and makes it clear what type of window

[GitHub] flink pull request: [FLINK-3536] Make clearer distinction between ...

2016-02-29 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1739#issuecomment-190319471 I think it would be good to have it in, yes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: [FLINK-3548] [api-breaking] Remove unnecessary...

2016-02-29 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/1742 [FLINK-3548] [api-breaking] Remove unnecessary generic parameter from… … SingleOutputStreamOperator You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] flink pull request: [FLINK-3538] Streamline Scala DataStream.join/...

2016-02-29 Thread aljoscha
Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/1740 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-3536] Make clearer distinction between ...

2016-02-29 Thread aljoscha
Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/1739 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-3538] Streamline Scala DataStream.join/...

2016-02-29 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1740#issuecomment-190315085 I think it's simply "api breaking". Will add the tag and merge. ok? Will then also put it on the release-1.0 branch. --- If your project is set up for i

[GitHub] flink pull request: [FLINK-3521] Make Iterable part of method sign...

2016-02-26 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/1723 [FLINK-3521] Make Iterable part of method signature for WindowFunction You can merge this pull request into a Git repository by running: $ git pull https://github.com/aljoscha/flink window

[GitHub] flink pull request: [FLINK-3527] Add Scala DataStream.transform()

2016-02-26 Thread aljoscha
Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/1728 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-3521] Make Iterable part of method sign...

2016-02-26 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1723#issuecomment-189458811 Yes, this is correct. (about the fold() on non-keyed windows) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request: [FLINK-3315] Fix Slot Sharing in Streaming API

2016-02-22 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1641#issuecomment-187190568 Updated on top of master again. This should have the behavior that we want for 1.0. --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: [FLINK-3035] Redis as State Backend

2016-02-23 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1617#issuecomment-187716265 Have you thought about how the state backups would work if there was only one previously running instance of redis available? --- If your project is set up

[GitHub] flink pull request: [FLINK-3526] [streaming] Fix Processing Time W...

2016-02-26 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1727#issuecomment-189445750 It worked before because of this setProcessingTime flag in the WindowOperator that would put the current processing time into that timestamp field

[GitHub] flink pull request: [FLINK-3526] [streaming] Fix Processing Time W...

2016-02-26 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1727#issuecomment-189447001 It was removed in the first commit that changed the interplay with StreamTimeCharacteristic --- If your project is set up for it, you can reply to this email and have

[GitHub] flink pull request: [hotfix] Add logging for RocksDB backup durati...

2016-02-24 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/1702 [hotfix] Add logging for RocksDB backup durations You can merge this pull request into a Git repository by running: $ git pull https://github.com/aljoscha/flink rocksdb-time-logging

[GitHub] flink pull request: [FLINK-3435] Proparly separate IngestionTime a...

2016-02-24 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1699#issuecomment-188424651 That's fine with me. As I said, that's just personal preferences. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-3513] [FLINK-3512] Fix savepoint issues

2016-02-25 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1712#issuecomment-188858495 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [refactor] Rename OperatorState to ValueState,...

2016-01-21 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1347#issuecomment-173528182 Closing for now, I have a bigger PR coming up --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: [refactor] Rename OperatorState to ValueState,...

2016-01-21 Thread aljoscha
Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/1347 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [hotfix] Fix interaction of Async calls/checkp...

2016-01-21 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/1532 [hotfix] Fix interaction of Async calls/checkpointing/canceling Before, it could happen that a Task is canceled during snapshotting. Some State Backends would silently swallow exceptions

[GitHub] flink pull request: [FLINK-3261] Allow Task to decline checkpoint ...

2016-01-21 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/1537 [FLINK-3261] Allow Task to decline checkpoint request if not ready Before, it could happen that a StreamingTask receives a Checkpoint Trigger message while internally not being ready

[GitHub] flink pull request: [FLINK-3178] Don't Emit In-Flight Windows When...

2016-01-22 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/1542 [FLINK-3178] Don't Emit In-Flight Windows When Closing Window Operator You can merge this pull request into a Git repository by running: $ git pull https://github.com/aljoscha/flink window

[GitHub] flink pull request: [FLINK-2933] Flink scala libraries exposed wit...

2016-01-23 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1529#issuecomment-174176173 Yes, I know about `flink-java`, that's why I mentioned that it would seem strange to users that `flink-java8` has a scala version suffix. --- If your project is set

[GitHub] flink pull request: [FLINK-2933] Flink scala libraries exposed wit...

2016-01-23 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1529#issuecomment-174171530 Can it not be prevented that flink-java8 and flink-storm and flink-gelly have the scala dependency? I think that would be very strange for java programmers. flink-java

[GitHub] flink pull request: [FLINK-3261] Allow Task to decline checkpoint ...

2016-01-25 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1537#issuecomment-174505573 @senorcarbone Yes, it works correctly with the timeouts, the job can just hang for a long time, especially in tests this occurred several times. --- If your project

[GitHub] flink pull request: [FLINK-3178] Don't Emit In-Flight Windows When...

2016-01-25 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/1542#discussion_r50714080 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/complex/ComplexIntegrationTest.java --- @@ -214,6 +214,7 @@ public void

[GitHub] flink pull request: [FLINK-3261] Allow Task to decline checkpoint ...

2016-01-25 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1537#issuecomment-174448455 Ok, I'm addressing the comments about code-style and merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request: [FLINK-3261] Allow Task to decline checkpoint ...

2016-01-25 Thread aljoscha
Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/1537 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [hotfix] Fix interaction of Async calls/checkp...

2016-01-27 Thread aljoscha
Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/1532 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-3354] Determine correct size for RocksD...

2016-02-15 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1638#issuecomment-184192170 Thanks :smile: You tried this on a cluster, I guess? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: [FLINK-3354] Determine correct size for RocksD...

2016-02-15 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1638#issuecomment-184195688 Ok, could you please go ahead and merge it if no one else objects. :+1: --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-3354] Determine correct size for RocksD...

2016-02-15 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1638#issuecomment-184196345 thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-3243] Fix Interplay of TimeCharacterist...

2016-02-15 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1513#issuecomment-184196790 I rebased on top of current master. Btw, still still has the issue that the time characteristic only applies to window operations that are created after

[GitHub] flink pull request: [FLINK-3315] Fix Slot Sharing in Streaming API

2016-02-16 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/1641 [FLINK-3315] Fix Slot Sharing in Streaming API This changes slot sharing settings to single method slotSharingGroup(String) on DataStream. Operations inherit the slot sharing group

[GitHub] flink pull request: [FLINK-3315] Fix Slot Sharing in Streaming API

2016-02-16 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/1641#discussion_r53017220 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/transformations/StreamTransformation.java --- @@ -202,6 +203,29 @@ public

[GitHub] flink pull request: [FLINK-3243] Fix Interplay of TimeCharacterist...

2016-02-16 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1513#issuecomment-184715239 @rmetzger @StephanEwen Do you still have objections? I think this should go in ASAP. --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: [FLINK-3400] Move RocksDB Copy Utils to flink-...

2016-02-16 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/1644 [FLINK-3400] Move RocksDB Copy Utils to flink-streaming-java They are not specific to RocksDB, just utilities for copying local folders to/from HDFS. Moving them to flink-streaming-java means

[GitHub] flink pull request: Refactor Common Parts of Stream/Batch Document...

2016-02-16 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/1645 Refactor Common Parts of Stream/Batch Documentation The main bit is the refactoring, I also added a basic RocksDB documentation and created a new "Working with Time" section for the

[GitHub] flink pull request: Refactor Common Parts of Stream/Batch Document...

2016-02-17 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/1645#discussion_r53139897 --- Diff: docs/apis/common/index.md --- @@ -0,0 +1,1356 @@ +--- +title: "Basic Concepts" + +# Top-level navigation +top-nav-g

[GitHub] flink pull request: [FLINK-3400] Move RocksDB Copy Utils to flink-...

2016-02-17 Thread aljoscha
Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/1644 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-3436] Remove ComplexIntegrationITCase

2016-02-17 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/1659 [FLINK-3436] Remove ComplexIntegrationITCase You can merge this pull request into a Git repository by running: $ git pull https://github.com/aljoscha/flink complex-remove Alternatively you

[GitHub] flink pull request: Refactor Common Parts of Stream/Batch Document...

2016-02-17 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1645#issuecomment-185126063 @uce Yes, they could also be moved to separate pages. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: [FLINK-3315] Fix Slot Sharing in Streaming API

2016-02-17 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1641#issuecomment-185230357 rebasing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-3430] Remove "no POJO" warning in TypeA...

2016-02-17 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/1655 [FLINK-3430] Remove "no POJO" warning in TypeAnalyzer You can merge this pull request into a Git repository by running: $ git pull https://github.com/aljoscha/flink scala-remove-po

[GitHub] flink pull request: Refactor Common Parts of Stream/Batch Document...

2016-02-17 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1645#issuecomment-185132226 Manually merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-3243] Fix Interplay of TimeCharacterist...

2016-02-17 Thread aljoscha
Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/1513 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: Refactor Common Parts of Stream/Batch Document...

2016-02-17 Thread aljoscha
Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/1645 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-3243] Fix Interplay of TimeCharacterist...

2016-02-17 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1513#issuecomment-185132200 Manually merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-3420] [api-breaking] Remove utility fun...

2016-02-17 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1648#issuecomment-185083603 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink pull request: [FLINK-3379] [FLINK-3415] [streaming] Refactor...

2016-02-17 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1646#issuecomment-185083361 +1 This should go into 1.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-3438] ExternalProcessRunner fails to de...

2016-02-18 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1665#issuecomment-185636882 Anyone against merging this as a (maybe temporary) solution? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request: [FLINK-3436] Remove ComplexIntegrationITCase

2016-02-18 Thread aljoscha
Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/1659 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-3439] Remove final Long.MAX_VALUE Water...

2016-02-19 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/1677 [FLINK-3439] Remove final Long.MAX_VALUE Watermark in StreamSource You can merge this pull request into a Git repository by running: $ git pull https://github.com/aljoscha/flink watermark

[GitHub] flink pull request: [FLINK-3439] Remove final Long.MAX_VALUE Water...

2016-02-20 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1677#issuecomment-186605514 I added the checks, will merge later once travis runs through. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request: [FLINK-3359] Make RocksDB File Copies Asynchro...

2016-02-12 Thread aljoscha
Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/1629 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-3352] Use HDFS Config in RocksDB Copy U...

2016-02-12 Thread aljoscha
Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/1631 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: Enhance Partitioned State and use it in Window...

2016-02-01 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1562#issuecomment-178111578 @StephanEwen @gyfora I have the changes reflected in this PR already. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-3450] Duplicate TypeSerializer in State...

2016-02-22 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/1686 [FLINK-3450] Duplicate TypeSerializer in StateDescriptor.writeObject The StateDescriptor can be serializer asynchronously in case of asynchronous checkpoints. In that case two threads would try

[GitHub] flink pull request: [hotfix] Remove obsolete "Working with Time" S...

2016-03-10 Thread aljoscha
Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/1779 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [hotfix] Remove obsolete "Working with Time" S...

2016-03-10 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/1779 [hotfix] Remove obsolete "Working with Time" Section from Doc You can merge this pull request into a Git repository by running: $ git pull https://github.com/aljoscha/flink doc-r

[GitHub] flink pull request: [FLINK-3614] Remove Non-Keyed Window Operator

2016-03-18 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/1805 [FLINK-3614] Remove Non-Keyed Window Operator Instead we use a dummy KeySelector and the regular WindowOperator now. You can merge this pull request into a Git repository by running: $ git

[GitHub] flink pull request: [FLINK-3583] User configuration visible in web...

2016-03-14 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1768#issuecomment-196251716 Hi @fijolekProjects, could you please confirm that everything works now that #1583 is merged. If yes, then I would like to merge this one as well. --- If your

[GitHub] flink pull request: [FLINK-3583] User configuration visible in web...

2016-03-14 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1768#issuecomment-196300410 Thanks a lot! I merged it. Could you please close this PR if github does not do so automatically. --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-3174] Add MergingWindowAssigner and Ses...

2016-03-19 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/1802 [FLINK-3174] Add MergingWindowAssigner and SessionWindows This introduces MergingWindowAssigner, an extension of WindowAssigner that can merge windows. When using a MergingWindowAssigner

[GitHub] flink pull request: [FLINK-3629] Fix quick start description for t...

2016-03-19 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1809#issuecomment-197872846 Thanks for the fix! :smile: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-3620] [streaming] Remove DbStateBackend

2016-03-19 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1800#issuecomment-197299652 :+1 if it builds. Thanks for the effort. :smile: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: [FLINK-3659] Allow ConnectedStreams to Be Keye...

2016-03-31 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1831#issuecomment-203821429 Closing this for now... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-3659] Allow ConnectedStreams to Be Keye...

2016-03-31 Thread aljoscha
Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/1831 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-3659] Allow ConnectedStreams to Be Keye...

2016-03-31 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1831#issuecomment-203821406 Yes, I'll try and come up with Ideas in that direction then. :+1: --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-3174] Add MergingWindowAssigner and Ses...

2016-04-05 Thread aljoscha
Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/1802 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-3614] Remove Non-Keyed Window Operator

2016-04-05 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1805#issuecomment-205855000 Manually merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-3614] Remove Non-Keyed Window Operator

2016-04-05 Thread aljoscha
Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/1805 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-2828] [table] Add interfaces for Table ...

2016-04-05 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1237#issuecomment-205881346 @twalthr is this still valid with the changes in the Table API or can it be closed? --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: FLINK-2166. Add fromCsvFile() method to TableE...

2016-04-05 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/939#issuecomment-205882687 @twalthr @fhueske @vasia Is this still valid with the recent changes in the Table API? --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: [FLINK-3637] Refactor rolling sink writer

2016-04-06 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1826#issuecomment-206292450 Great to hear! Could you please close this PR, github didn't close automatically. --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: FLINK-2166. Add fromCsvFile() method to TableE...

2016-04-06 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/939#issuecomment-206327407 Ah, I forgot, it was @jamescao who opened it... :sweat_smile: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request: [FLINK-2143] Added ReduceFunctionWithInverse

2016-04-05 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/856#issuecomment-205883786 @ggevay The windowing system changed a while back. Is this still valid or can it be closed? --- If your project is set up for it, you can reply to this email and have

[GitHub] flink pull request: [FLINK-3637] Refactor rolling sink writer

2016-04-05 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1826#issuecomment-205883214 hi @dalegaard this must have slipped my mind. I'll review it tomorrow and merge if possible. --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request: [FLINK-3637] Refactor rolling sink writer

2016-04-05 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1826#issuecomment-205885519 The changes look good. One thing I would like to have changed is to rename `SimpleWriterBase` to `StreamWriterBase` or `StreamWriter` based to reflect the fact

[GitHub] flink pull request: [FLINK-3637] Refactor rolling sink writer

2016-04-06 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1826#issuecomment-206257162 True, true... :smile: Very nice work! I'm merging. Are you planning to also work on an ORC writer for this? --- If your project is set up for it, you

[GitHub] flink pull request: [FLINK-3654] Disable Write-Ahead-Log in RocksD...

2016-04-06 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1850#issuecomment-206259647 I think we have a winner now. I changed the backup options to not back up the WAL. This seems to have been the problem. Only logical since there is no WAL anymore

[GitHub] flink pull request: [FLINK-3730] Fix RocksDB Local Directory Initi...

2016-04-13 Thread aljoscha
Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/1873 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-3747] Consolidate TimestampAssigner Met...

2016-04-13 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/1877 [FLINK-3747] Consolidate TimestampAssigner Methods in Kafka Consumer You can merge this pull request into a Git repository by running: $ git pull https://github.com/aljoscha/flink kafka-fix

[GitHub] flink pull request: [FLINK-3740] Make Session Window State Checkpo...

2016-04-13 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/1878 [FLINK-3740] Make Session Window State Checkpointed You can merge this pull request into a Git repository by running: $ git pull https://github.com/aljoscha/flink window-snapshot-test

[GitHub] flink pull request: [FLINK-3718] Add Option For Completely Async B...

2016-04-13 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/1879 [FLINK-3718] Add Option For Completely Async Backup in RocksDB State Backend This also refactors the RocksDB backend to keep one RocksDB data base in the backend where all key/value state

<    3   4   5   6   7   8   9   10   11   12   >