[GitHub] flink pull request #2471: Broken links on website

2016-09-03 Thread apivovarov
GitHub user apivovarov opened a pull request: https://github.com/apache/flink/pull/2471 Broken links on website Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all

[GitHub] flink pull request #2471: Broken links on website

2016-09-06 Thread apivovarov
Github user apivovarov closed the pull request at: https://github.com/apache/flink/pull/2471 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink issue #2471: Broken links on website

2016-09-06 Thread apivovarov
Github user apivovarov commented on the issue: https://github.com/apache/flink/pull/2471 https://issues.apache.org/jira/browse/FLINK-4585 I'll submit a PR to flink-web --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request #2478: [FLINK-4595] Close FileOutputStream in ParameterTo...

2016-09-07 Thread apivovarov
GitHub user apivovarov opened a pull request: https://github.com/apache/flink/pull/2478 [FLINK-4595] Close FileOutputStream in ParameterTool https://issues.apache.org/jira/browse/FLINK-4595 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] flink pull request #2492: [FLINK-4612] Close FileWriter using try with resou...

2016-09-11 Thread apivovarov
GitHub user apivovarov opened a pull request: https://github.com/apache/flink/pull/2492 [FLINK-4612] Close FileWriter using try with resources https://issues.apache.org/jira/browse/FLINK-4612 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] flink issue #2489: [FLINK-4608] Use short-circuit AND in Max/Min Aggregation...

2016-09-13 Thread apivovarov
Github user apivovarov commented on the issue: https://github.com/apache/flink/pull/2489 @zentol Can you merge it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink issue #2488: [FLINK-4607] Close FileInputStream in ParameterTool and o...

2016-09-13 Thread apivovarov
Github user apivovarov commented on the issue: https://github.com/apache/flink/pull/2488 @zentol Time to merge it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink pull request #2490: [FLINK-4609] Remove redundant check for null in Cr...

2016-09-13 Thread apivovarov
Github user apivovarov commented on a diff in the pull request: https://github.com/apache/flink/pull/2490#discussion_r78631478 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/CrossOperator.java --- @@ -129,14 +129,11 @@ private String getDefaultName

[GitHub] flink pull request #2491: [FLINK-4610] Replace keySet/getValue with entrySet...

2016-09-10 Thread apivovarov
GitHub user apivovarov opened a pull request: https://github.com/apache/flink/pull/2491 [FLINK-4610] Replace keySet/getValue with entrySet in UdfAnalyzerUtils https://issues.apache.org/jira/browse/FLINK-4610 You can merge this pull request into a Git repository by running

[GitHub] flink pull request #2483: [FLINK-4601] Check for empty string properly

2016-09-09 Thread apivovarov
GitHub user apivovarov opened a pull request: https://github.com/apache/flink/pull/2483 [FLINK-4601] Check for empty string properly https://issues.apache.org/jira/browse/FLINK-4601 You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] flink issue #2491: [FLINK-4610] Replace keySet/getValue with entrySet in Udf...

2016-09-10 Thread apivovarov
Github user apivovarov commented on the issue: https://github.com/apache/flink/pull/2491 @twalthr Can you look at this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request #2490: [FLINK-4609] Remove redundant check for null in Cr...

2016-09-10 Thread apivovarov
Github user apivovarov commented on a diff in the pull request: https://github.com/apache/flink/pull/2490#discussion_r78283317 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/CrossOperator.java --- @@ -133,10 +133,6 @@ public DefaultCross(DataSet input1

[GitHub] flink pull request #2490: [FLINK-4609] Remove redundant check for null in Cr...

2016-09-10 Thread apivovarov
Github user apivovarov commented on a diff in the pull request: https://github.com/apache/flink/pull/2490#discussion_r78285322 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/CrossOperator.java --- @@ -133,10 +133,6 @@ public DefaultCross(DataSet input1

[GitHub] flink issue #2490: [FLINK-4609] Remove redundant check for null in CrossOper...

2016-09-10 Thread apivovarov
Github user apivovarov commented on the issue: https://github.com/apache/flink/pull/2490 Ok, I added null check for input1 and input2 with a message before calling super in DefaultCross --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request #2490: [FLINK-4609] Remove redundant check for null in Cr...

2016-09-10 Thread apivovarov
Github user apivovarov commented on a diff in the pull request: https://github.com/apache/flink/pull/2490#discussion_r78287335 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/CrossOperator.java --- @@ -129,14 +129,11 @@ private String getDefaultName

[GitHub] flink pull request #2490: [FLINK-4609] Remove redundant check for null in Cr...

2016-09-10 Thread apivovarov
Github user apivovarov commented on a diff in the pull request: https://github.com/apache/flink/pull/2490#discussion_r78288200 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/CrossOperator.java --- @@ -129,14 +129,11 @@ private String getDefaultName

[GitHub] flink pull request #2492: [FLINK-4612] Close FileWriter using try with resou...

2016-09-12 Thread apivovarov
Github user apivovarov commented on a diff in the pull request: https://github.com/apache/flink/pull/2492#discussion_r78447379 --- Diff: flink-core/src/test/java/org/apache/flink/testutils/TestFileUtils.java --- @@ -55,11 +55,8 @@ public static String createTempFileInDirectory

[GitHub] flink pull request #2488: [FLINK-4607] Close FileInputStream in ParameterToo...

2016-09-09 Thread apivovarov
GitHub user apivovarov opened a pull request: https://github.com/apache/flink/pull/2488 [FLINK-4607] Close FileInputStream in ParameterTool and other https://issues.apache.org/jira/browse/FLINK-4607 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] flink pull request #2487: [FLINK-4520][flink-siddhi] Integrate Siddhi as a l...

2016-09-09 Thread apivovarov
Github user apivovarov commented on a diff in the pull request: https://github.com/apache/flink/pull/2487#discussion_r78270750 --- Diff: flink-contrib/flink-siddhi/src/main/java/org/apache/flink/contrib/siddhi/SiddhiCEP.java --- @@ -0,0 +1,118 @@ +/* + * Licensed

[GitHub] flink pull request #2487: [FLINK-4520][flink-siddhi] Integrate Siddhi as a l...

2016-09-09 Thread apivovarov
Github user apivovarov commented on a diff in the pull request: https://github.com/apache/flink/pull/2487#discussion_r78270764 --- Diff: flink-contrib/flink-siddhi/src/main/java/org/apache/flink/contrib/siddhi/SiddhiCEP.java --- @@ -0,0 +1,118 @@ +/* + * Licensed

[GitHub] flink pull request #2487: [FLINK-4520][flink-siddhi] Integrate Siddhi as a l...

2016-09-09 Thread apivovarov
Github user apivovarov commented on a diff in the pull request: https://github.com/apache/flink/pull/2487#discussion_r78270757 --- Diff: flink-contrib/flink-siddhi/src/main/java/org/apache/flink/contrib/siddhi/SiddhiCEP.java --- @@ -0,0 +1,118 @@ +/* + * Licensed

[GitHub] flink pull request #2485: [Flink 4599] - Add 'explain()' also to StreamTable...

2016-09-09 Thread apivovarov
Github user apivovarov commented on a diff in the pull request: https://github.com/apache/flink/pull/2485#discussion_r78270796 --- Diff: docs/dev/table_api.md --- @@ -2457,3 +2457,27 @@ The Table API provides a configuration (the so-called `TableConfig`) to modify r

[GitHub] flink pull request #2485: [Flink 4599] - Add 'explain()' also to StreamTable...

2016-09-09 Thread apivovarov
Github user apivovarov commented on a diff in the pull request: https://github.com/apache/flink/pull/2485#discussion_r78270826 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/StreamTableEnvironment.scala --- @@ -271,5 +271,21 @@ abstract class

[GitHub] flink pull request #2485: [Flink 4599] - Add 'explain()' also to StreamTable...

2016-09-09 Thread apivovarov
Github user apivovarov commented on a diff in the pull request: https://github.com/apache/flink/pull/2485#discussion_r78270846 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/StreamTableEnvironment.scala --- @@ -271,5 +271,21 @@ abstract class

[GitHub] flink pull request #2485: [Flink 4599] - Add 'explain()' also to StreamTable...

2016-09-09 Thread apivovarov
Github user apivovarov commented on a diff in the pull request: https://github.com/apache/flink/pull/2485#discussion_r78270898 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/stream/ExplainStreamTest.scala --- @@ -0,0 +1,64

[GitHub] flink pull request #2489: [FLINK-4608] Use short-circuit AND in Max/Min Aggr...

2016-09-09 Thread apivovarov
GitHub user apivovarov opened a pull request: https://github.com/apache/flink/pull/2489 [FLINK-4608] Use short-circuit AND in Max/Min AggregationFunction https://issues.apache.org/jira/browse/FLINK-4608 You can merge this pull request into a Git repository by running: $ git

[GitHub] flink pull request #2490: [FLINK-4609] Remove redundant check for null in Cr...

2016-09-09 Thread apivovarov
GitHub user apivovarov opened a pull request: https://github.com/apache/flink/pull/2490 [FLINK-4609] Remove redundant check for null in CrossOperator https://issues.apache.org/jira/browse/FLINK-4609 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] flink pull request #2490: [FLINK-4609] Remove redundant check for null in Cr...

2016-09-19 Thread apivovarov
Github user apivovarov commented on a diff in the pull request: https://github.com/apache/flink/pull/2490#discussion_r79441284 --- Diff: flink-java/src/test/java/org/apache/flink/api/java/sca/UdfAnalyzerTest.java --- @@ -971,10 +971,7 @@ public void

[GitHub] flink pull request #2538: [FLINK-4666] Make constants to be final in Paramet...

2016-09-22 Thread apivovarov
GitHub user apivovarov opened a pull request: https://github.com/apache/flink/pull/2538 [FLINK-4666] Make constants to be final in ParameterTool https://issues.apache.org/jira/browse/FLINK-4666 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] flink pull request #2537: [FLINK-4665] Remove boxing/unboxing to parse a pri...

2016-09-22 Thread apivovarov
GitHub user apivovarov opened a pull request: https://github.com/apache/flink/pull/2537 [FLINK-4665] Remove boxing/unboxing to parse a primitive https://issues.apache.org/jira/browse/FLINK-4665 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] flink pull request #2539: [FLINK-4668] Fix positive random int generation

2016-09-23 Thread apivovarov
GitHub user apivovarov opened a pull request: https://github.com/apache/flink/pull/2539 [FLINK-4668] Fix positive random int generation https://issues.apache.org/jira/browse/FLINK-4668 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] flink issue #2539: [FLINK-4668] Fix positive random int generation

2016-09-23 Thread apivovarov
Github user apivovarov commented on the issue: https://github.com/apache/flink/pull/2539 it's not even convenient to work with files started with `-`, e.g. ```$ vi -44.txt VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Aug 1 2016 19:37:21) Unknown option argument: "-4