Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r37138063
--- Diff: docs/libs/ml/statistics.md ---
@@ -0,0 +1,108 @@
+---
+mathjax: include
+htmlTitle: FlinkML - Statistics
+title: a href
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r37138093
--- Diff: docs/libs/ml/statistics.md ---
@@ -0,0 +1,108 @@
+---
+mathjax: include
+htmlTitle: FlinkML - Statistics
+title: a href
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/861#issuecomment-131425060
Hi @sachingoel0101, Thanks for your contribution. I reviewed this PR and
commented the source code.
There are some problems which aren't commented
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/696#issuecomment-131086738
@kno10 Thanks for the comment. In this case we don't need to parallelize
R-Tree because R-Tree is only used in reducer for matching records of the given
block pair
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1007#issuecomment-129850783
Why the permissions of file are changed from 644 to 755? Other changes
seems good.
---
If your project is set up for it, you can reply to this email and have your
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/861#issuecomment-129336972
Hi, I just discovered the review request. I'll review this PR soon. Because
I'm busy in working for my graduation essay, maybe I can start reviewing on
weekend
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/808#issuecomment-128638172
[Your last
commit](https://github.com/PieterJanVanAeken/flink/commit/463a1f30b3b0785f46c76f9c290da3deec26)
includes all updates of master branch. Please remove
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/997#discussion_r36478648
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/FileSourceFunction.java
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/939#issuecomment-126621482
Just my opinion, `TableEnvironment` is located under
`org.apache.flink.api.java.table` because of unifying of Table API
implementation. But Table API is implemented
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/965#issuecomment-12669
Nice catch! Looks good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/941#issuecomment-125185305
Hi, pom.xml file of flink-scala module has also profile based dependency
setting. Is it okay without modification?
---
If your project is set up for it, you can
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-125271970
There is wrong description in building documentation. Because Scala 2.11
profile activation is determined by property scala-2.11, Scala 2.10 profile
is activated when
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-125319617
When we upgrade version of maven-shade-plugin to 2.4.1, the property in
current project artifactId is interpolated properly. But the property in parent
artifactId
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-124521433
Could you post your command to compile Flink with Scala 2.11? The current
setting works well in my environment. Maven module definitions is not artifact
id
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-123642852
Hi, currently this PR is not ready to merge, because this PR doesn't
contain changes for #677. I'll update soon. Unfortunately I'm outside now.
Maybe I can update
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/924#issuecomment-122893574
Great catch! Looks good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/907#issuecomment-122376238
Hi, I am reviewing this changes. I'm not done yet but I found some points
which are able to improve.
First, there are some duplicated classes
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/912#issuecomment-121515483
Hi, Thanks for your contribution. But I think this PR is not necessary
because the change is not specific to Flink but about the general of git.
---
If your project
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/909#issuecomment-121246257
Looks good. :)
+1 for merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/905#issuecomment-121283389
@pp86 Looks good to merge. :)
If another committer gives LGTM to this PR, I'll merge this PR.
---
If your project is set up for it, you can reply to this email
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/677#issuecomment-121441621
Looks good to merge. After merging this PR, we need to modify PR #885.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/905#issuecomment-120913343
Hi, @pp86 Thanks for your contribution.
But I think that using `AutoSelector` is not the best approach to improve
distinct transformation. In Flink
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/905#issuecomment-121119196
@pp86 It seems okay but we need to check this change with some test cases.
Could you add some test cases into `DistinctITCase` in `flink-tests` module?
---
If your
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/905#issuecomment-120922707
@pp86 Hi you can modify this pull request by adding commit in your branch.
(pp86:master)
I think reopening this pull request and adding commit is better than
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/904#issuecomment-120707231
+1 for renaming. I confused the difference between the options and
arguments.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/903#issuecomment-120603967
+1 for merging :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/897#issuecomment-120384704
Merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-120554092
If I get 1 more LGTM, I'll merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-120411775
Hi, I updated PR :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/885#discussion_r34067611
--- Diff: docs/apis/programming_guide.md ---
@@ -187,7 +187,17 @@ that creates the type information for Flink operations.
/div
/div
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/696#discussion_r34017778
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/classification/KNN.scala
---
@@ -0,0 +1,204 @@
+/*
+ * Licensed to the Apache
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/696#issuecomment-119163944
@thvasilo Yeah exact k-NN is not scalable for gigabytes-sized,
terabytes-sized data. If I add R-Tree to this algorithm, the algorithm would be
better. But I agree
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/696#issuecomment-118792663
@thvasilo Thanks :) I'll update this pull request soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/696#discussion_r33921518
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/classification/KNN.scala
---
@@ -0,0 +1,204 @@
+/*
+ * Licensed to the Apache
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-118611879
@aalexandrov Thank you for review. :) I will applying your suggestion and
update this PR. But in this changes, all modules require the suffix if the
module is linked
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/887#issuecomment-118644497
FLINK-2319,
I leave a commit with the JIRA ticket to track changes of this PR. :)
---
If your project is set up for it, you can reply to this email and have your
GitHub user chiwanpark opened a pull request:
https://github.com/apache/flink/pull/885
[FLINK-2200] Add Flink with Scala 2.11 in Maven Repository
Hi, This PR contains following changes:
* Add a suffix `_2.11` to all maven modules by profile setting.
(`-Pscala-2.11
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/864#issuecomment-117860517
Good. +1 for merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/696#issuecomment-117059705
Hi, I updated this PR. I reimplemented kNN Join with `zipWithIndex` and
fitted to changed pipeline architecture.
---
If your project is set up for it, you can reply
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/832#discussion_r33419462
--- Diff:
flink-tests/src/test/scala/org/apache/flink/api/scala/util/DataSetUtilsITCase.scala
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/832#issuecomment-116208070
Hi, I added some minor comments about coding style in Scala test case. The
rest things is okay.
I think we can merge this after fixing the style.
---
If your
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/832#discussion_r33419461
--- Diff:
flink-tests/src/test/scala/org/apache/flink/api/scala/util/DataSetUtilsITCase.scala
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/832#discussion_r33419459
--- Diff:
flink-tests/src/test/scala/org/apache/flink/api/scala/util/DataSetUtilsITCase.scala
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/832#issuecomment-116252016
Looks good :) merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/832#issuecomment-116252346
Oops! I forgot add This closes #832 into commit message. I mistook
because this is my first commit to upload Apache repository. Sorry. How can I
fix it?
---
If your
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/869#issuecomment-115636110
Nice catch and looks good to merge. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/808#issuecomment-113147981
Hi. I'm very excited about Gelly's Scala API. I'm reading the changes from
this PR. I found a problem about re-formatting. Unlike Flink's Java code,
Flink's Scala
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/696#issuecomment-112745989
@thvasilo Good! Thank you. I'll update the implementation after #801 is
merged.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/696#issuecomment-112733734
Hi. I updated the implementation of kNN using pipeline architecture.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/751#issuecomment-107478713
I fixed the bug related to non-null memory segment. The bug was caused by
non-clearing `writeBehindBuffersAvailable` variable in `close()` method of
`MutableHashTable
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/751#issuecomment-107287836
I was debugging with ConnectedComponents example and found the bug caused
by null memory segment. I tried adding a test case to test re-openable hash
table with small
GitHub user chiwanpark opened a pull request:
https://github.com/apache/flink/pull/751
[FLINK-2076] [runtime] Fix memory leakage in MutableHashTable
Hi. This PR contains a bug fix for
[FLINK-2076](https://issues.apache.org/jira/browse/FLINK-2076).
When
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/734#issuecomment-106313923
Okay. :)
Because there is Stephen's email address in test code, I modified test code.
---
If your project is set up for it, you can reply to this email and have
GitHub user chiwanpark opened a pull request:
https://github.com/apache/flink/pull/734
[FLINK-2061] CSVReader: quotedStringParsing and includeFields yields
ParseException
Fix the bug in `GenericCsvInputFormat` when skipped field is quoted string.
I also added a unit test
GitHub user chiwanpark opened a pull request:
https://github.com/apache/flink/pull/696
[FLINK-1745] [ml] [WIP] Add exact k-nearest-neighbours algorithm to machine
learning library
This PR is not final but work in progress. You can see detail description
in [JIRA](https
GitHub user chiwanpark opened a pull request:
https://github.com/apache/flink/pull/668
[FLINK-2001] [ml] Fix DistanceMetric serialization error
* `DistanceMetric` extends Serializable
* Add simple serialization test
You can merge this pull request into a Git repository
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/629#discussion_r29837576
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/math/metrics/distances/CosineDistanceMeasure.scala
---
@@ -0,0 +1,45
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/629#issuecomment-99803730
@tillrohrmann I just renamed the classes. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/629#issuecomment-99803806
Oh, the commit logs contains distance measure. I will fix them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/629#issuecomment-99531887
I added a overview documentation. Please review and comment if there are
some errors.
---
If your project is set up for it, you can reply to this email and have your
GitHub user chiwanpark opened a pull request:
https://github.com/apache/flink/pull/644
[FLINK-1855] SocketTextStreamWordCount example cannot be run from the
webclient
This PR fixes
[FLINK-1855](https://issues.apache.org/jira/browse/FLINK-1855). Tested in Local
Cluster
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/636#issuecomment-97100649
Looks good to merge. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user chiwanpark opened a pull request:
https://github.com/apache/flink/pull/629
[FLINK-1933] Add distance measure interface and basic implementation to
machine learning library
This PR contains following changes:
* Add `dot` method and `magnitude` method.
* Add
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/572#issuecomment-94512484
I updated this PR. Thanks for advice. :)
* Remove `setParallelism(1)` in test code.
* Simplify `testGroupReduceWithAtomicValue` in `GroupReduceITCase
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/572#issuecomment-94188129
Hi. I updated this PR. The changes are following.
* Re-implement this feature with generalizing `ExpressionKeys`.
* Modify `CoGroupOperatorBase
GitHub user chiwanpark opened a pull request:
https://github.com/apache/flink/pull/611
[FLINK-1906] [docs] Add tip to work around plain Tuple return type of
project operator
Add a tip about project transformation with type hinting in documentation.
Related JIRA is [here](https
GitHub user chiwanpark opened a pull request:
https://github.com/apache/flink/pull/572
[FLINK-703] Use complete element as join key
Hello. I open a pull request about FLINK-703. You can find more detail
description in [JIRA](https://issues.apache.org/jira/browse/FLINK-703). This PR
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/426#issuecomment-86011099
Oops, I pushed a intermediate commit a8a5c37. I will fix it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/426#issuecomment-86011782
@fhueske You can check it now :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/426#issuecomment-85830275
Hi, I updated this PR.
* Remove `pojoType(Class? targetType)` method in `CsvReader` to force the
user to explicitly specify the fields order.
* Add
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/426#issuecomment-85285193
@fhueske Hi, Thanks for your kindly advice! I will fix them soon.
About the order of POJO fields, I think also that the option 3 is good.
However, [FLINK-1665
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/426#issuecomment-82885499
I updated this PR.
* Change method of obtaining `Field` object from using `PojoTypeInfo` to
saving field names. (Thanks @fhueske for advice
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/426#issuecomment-78876571
Hello. I have a question about object reuse in `readRecord` method of
`ScalaCsvInputFormat`. In java implementation, `CsvInputFormat` reuse result
object
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/426#issuecomment-79066240
@aljoscha Thanks! I understand about it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/478#issuecomment-78228121
As I wrote in JIRA, Fields of Scala class (not case class) are private.
([Reference](http://stackoverflow.com/questions/1589603/scala-set-a-field-value-reflectively
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/426#issuecomment-78401359
@fhueske Thanks for your kindly advice. I will fix as soon as possible.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user chiwanpark opened a pull request:
https://github.com/apache/flink/pull/478
[FLINK-1654] Wrong scala example of POJO type in documentation
More detail description and discussion in
[JIRA](https://issues.apache.org/jira/browse/FLINK-1654).
You can merge this pull request
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/426#issuecomment-77293135
@fhueske Oh, you are right. Currently, users cannot decide order of fields.
I will add a parameter to set order of fields.
---
If your project is set up for it, you
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/426#discussion_r25760453
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/io/CsvInputFormat.java ---
@@ -235,8 +252,21 @@ public OUT readRecord(OUT reuse, byte[] bytes
GitHub user chiwanpark opened a pull request:
https://github.com/apache/flink/pull/426
[FLINK-1512] Add CsvReader for reading into POJOs.
This PR contains following changes.
* `CsvInputFormat` and `ScalaCsvInputFormat` can receive POJO type as
generic parameter
* Add
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/374#issuecomment-73509674
@StephanEwen Thanks for your advice! I fixed it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/374#issuecomment-73410413
@tillrohrmann Thanks for your advice. I will fix it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user chiwanpark opened a pull request:
https://github.com/apache/flink/pull/374
[FLINK-1179] Add button to JobManager web interface to request stack trace
of a TaskManager
This PR contains following changes:
* Add public constructors
501 - 583 of 583 matches
Mail list logo
