GitHub user dyanarose opened a pull request:
https://github.com/apache/flink/pull/2077
[FLINK-4026] Fix code, grammar, and link issues in the Streaming
documentation
* fixing grammar issues with he streaming API section of the documentation
that make it hard to follow in places
Github user dyanarose commented on a diff in the pull request:
https://github.com/apache/flink/pull/2040#discussion_r65137533
--- Diff: docs/build_docs.sh ---
@@ -54,7 +54,7 @@ JEKYLL_CMD="build"
while getopts ":p" opt; do
case $opt
GitHub user dyanarose opened a pull request:
https://github.com/apache/flink/pull/2040
[FLINK-3975] [docs] Override baseurl when serving docs locally
Updating build_docs.sh to serve the docs locally with the correct url.
This change makes build_docs.sh run the equivalent serve
GitHub user dyanarose opened a pull request:
https://github.com/apache/flink/pull/5295
[FLINK-8384] [streaming] Session Window Assigner with Dynamic Gaps
## What is the purpose of the change
This PR adds the ability for the Session Window assigners to to have
dynamic
Github user dyanarose commented on a diff in the pull request:
https://github.com/apache/flink/pull/5295#discussion_r161807828
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/DynamicEventTimeSessionWindows.java
---
@@ -0,0 +1,101
Github user dyanarose commented on a diff in the pull request:
https://github.com/apache/flink/pull/5295#discussion_r161807850
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/DynamicProcessingTimeSessionWindows.java
---
@@ -0,0
Github user dyanarose commented on a diff in the pull request:
https://github.com/apache/flink/pull/5295#discussion_r161807869
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/DynamicProcessingTimeSessionWindows.java
---
@@ -0,0
Github user dyanarose commented on a diff in the pull request:
https://github.com/apache/flink/pull/5295#discussion_r161807837
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/DynamicEventTimeSessionWindows.java
---
@@ -0,0 +1,101
Github user dyanarose commented on a diff in the pull request:
https://github.com/apache/flink/pull/5295#discussion_r161807900
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/SessionWindowTimeGapExtractor.java
---
@@ -0,0 +1,30
Github user dyanarose commented on the issue:
https://github.com/apache/flink/pull/5295
looks like the build failed on:
org.apache.flink.test.streaming.runtime.StreamTaskTimerITCase
testOperatorChainedToSource
I can't see why this change would cause that to fail, after
Github user dyanarose commented on a diff in the pull request:
https://github.com/apache/flink/pull/5295#discussion_r163692223
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/DynamicEventTimeSessionWindows.java
---
@@ -0,0 +1,101
Github user dyanarose commented on a diff in the pull request:
https://github.com/apache/flink/pull/5295#discussion_r163796598
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/DynamicEventTimeSessionWindows.java
---
@@ -0,0 +1,101
Github user dyanarose commented on the issue:
https://github.com/apache/flink/pull/5295
I'm not the biggest fan of unchecked casts, but testing this in our POC
environment casting the existing EventTimeTrigger to a typed Trigger<T, W> is
working. So if the unchecke
Github user dyanarose commented on the issue:
https://github.com/apache/flink/pull/5295
the ci fail looks to be a known flaky test:
FlinkKafkaProducer011ITCase.testScaleDownBeforeFirstCheckpoint
---
Github user dyanarose commented on the issue:
https://github.com/apache/flink/pull/5295
erf, I see what you mean, as well as the creation of all those Time objects.
---
Github user dyanarose commented on the issue:
https://github.com/apache/flink/pull/5295
I like long myself, but I think that's only because I'm quite used to
working in milliseconds. As the existing static Session Windows take Time as
the gap, I think it made sense to have
Github user dyanarose commented on the issue:
https://github.com/apache/flink/pull/5295
Ah, I hadn't thought to keep both in place. So unless the Dynamic
SessionWindow classes had withDynamicGap made package private, you would then
be able to instantiate them from two different
Github user dyanarose commented on the issue:
https://github.com/apache/flink/pull/5295
the change to return Time has been backed out, so extract returns a long
again.
PublicEvolving annotations have been added to the new classes and methods.
---
Github user dyanarose commented on the issue:
https://github.com/apache/flink/pull/5295
I can see it's gone through Travis and is now in master, so closing as
requested
---
Github user dyanarose closed the pull request at:
https://github.com/apache/flink/pull/5295
---
20 matches
Mail list logo
