Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1129#discussion_r39489755
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -1586,32 +1586,29 @@ object TaskManager
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1129#discussion_r39488999
--- Diff: flink-dist/src/main/flink-bin/bin/taskmanager.sh ---
@@ -51,13 +51,41 @@ if [[ $STARTSTOP == "start" ]]; then
fi
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1097#discussion_r39492715
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/RequiredParameter.java
---
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apache
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1097#discussion_r39493290
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/RequiredParameter.java
---
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apache
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1097#issuecomment-140343995
Thanks for the PR @mliesenberg!
Can you add the checks (and tests to verify the checks are working) that I
mentioned in my comments?
The original JIRA issue also
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1129#issuecomment-140336732
Thanks for the PR @mxm.
I left a few comments inline.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1097#discussion_r39492448
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/Option.java ---
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1097#issuecomment-140347951
If you add a type field (or enum) to the option, you can check if you can
cast the string into the requested type. Since we would only support a fixed
set of types
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1129#issuecomment-140349703
Thanks for the update.
Good to merge, IMO
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1097#discussion_r39495292
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/RequiredParameter.java
---
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apache
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1137#discussion_r39676482
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/util/ClassLoaderUtilsTest.java
---
@@ -46,13 +46,16 @@ public void testWithURLClassLoader
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1137#issuecomment-140868278
Hi @tedyu,
Thanks for the pull request!
It's good to merge after the the indention is fixed.
---
If your project is set up for it, you can reply to this email
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1132#issuecomment-140869851
Thanks for the update.
I will merge this PR tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1098#issuecomment-140877442
Hi @HuangWHWHW, your PR #1131 has been merged.
Can you update this PR and remove those changes?
Thanks!
---
If your project is set up for it, you can reply
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1135#issuecomment-140898273
Tricky bug :-)
If it does not depend on #1046, why not merge it?
Or would you like to have somebody else looking over the code?
---
If your project is set up
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1135#issuecomment-140901138
#1046 seems to be almost done. Porting to the ExecutionConfig, shouldn't be
too hard. I'd rather try to drive #1046 forward and merge it first, but it's up
to you
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1140#issuecomment-141021568
Thanks for the patch!
Will merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1137#issuecomment-141006345
Thanks for the update.
Will merge this now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1136#issuecomment-141006389
Thanks for the review.
Will merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r39763329
--- Diff:
flink-staging/flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellITSuite.scala
---
@@ -212,6 +212,49 @@ class ScalaShellITSuite
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r39763373
--- Diff:
flink-staging/flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellLocalStartupITCase.scala
---
@@ -0,0 +1,58
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1106#issuecomment-141131210
Thanks for the update @nikste! I have only one minor thing to add.
After that it's good to merge, IMO.
Thanks!
---
If your project is set up for it, you can
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1123#issuecomment-141102303
I agree with @uce and I don't think we should add the Scala example JARs
again.
@chenliang613, could you please close this PR?
I am really sorry that we
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1077#discussion_r39749641
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/SocketTextStreamFunction.java
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1138#issuecomment-14654
@jkovacs and @r-pogalz, thank you very much for this PR and the detailed
description!
It's quite a bit of code so it will take some time to be reviewed. I hope
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/945#discussion_r39265532
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobSubmitTest.java
---
@@ -192,4 +193,78 @@ public void initializeOnMaster
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/945#discussion_r39266023
--- Diff: flink-core/src/main/java/org/apache/flink/util/VersionUtils.java
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1118#issuecomment-139544590
Thanks for the PR @greghogan.
Good to merge, IMO.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1105#discussion_r39278109
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/library/TriangleCount.java
---
@@ -0,0 +1,208 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1105#discussion_r39277765
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/library/TriangleCount.java
---
@@ -0,0 +1,208 @@
+/*
+ * Licensed
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1105#issuecomment-139565546
I think having TriangleCounting (and TriangleEnumeration as well) would be
very good additions for Gelly. As such they should be implemented as efficient
as possible
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1116#issuecomment-139559991
will merge this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1097#discussion_r39496768
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/RequiredParameter.java
---
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apache
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1104#issuecomment-140387087
@tillrohrmann You are extending this PR and opening a new one, right?
Can you close this PR?
---
If your project is set up for it, you can reply to this email
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1105#issuecomment-13460
As I said, I did not look at the actual implementation of the PR besides
counting expensive operators.
Since we have implementations for both, we could simply run
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1084#issuecomment-139994388
Yes, we just had a discussion on the user mailing list about a partitioned
output format for batch processing. Definitely a good addition for both DataSet
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1046#issuecomment-141550369
Hi @ffbin,
not sure if you followed the discussion on the mailing list, but we
discussed to use the ExecutionConfig instead of the JobConfig. The reason
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1138#issuecomment-143252740
As I said in my previous comments, I would prefer to support projection
joins initially.
Instead, it would be good, if we could ensure by API design that an outer
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1138#discussion_r40440502
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/operators/base/JoinOperatorBase.java
---
@@ -47,99 +45,29 @@
/**
* @see
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1138#issuecomment-143253277
Hi @jkovacs and @r-pogalz,
really good work! I left a few comments inline but overall the PR is in a
pretty good shape. Please let me know, if you have
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1138#discussion_r40439650
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/operators/JoinOperator.java
---
@@ -281,233 +315,225 @@ protected boolean
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1138#discussion_r40439571
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/operators/JoinOperator.java
---
@@ -281,233 +315,225 @@ protected boolean
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1138#discussion_r40439511
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/operators/JoinOperator.java
---
@@ -281,233 +315,225 @@ protected boolean
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1138#discussion_r40441316
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/OuterJoinITCase.java
---
@@ -0,0 +1,679 @@
+/*
+ * Licensed to the Apache
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1138#discussion_r40439495
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/operators/JoinOperator.java
---
@@ -281,233 +315,225 @@ protected boolean
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1138#issuecomment-143250678
We have a couple of unit tests to check the correctness of the API, i.e.,
check that valid use is working and invalid use throws an early exceptions. See
for example
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/1182
[FLINK-2756] Fix start/stop scripts for paths with spaces
Checked the following scripts:
- `start-local.sh`
- `stop-local.sh`
- `start-cluster.sh`
- `stop-cluster.sh
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1138#issuecomment-142723198
Hi @jkovacs, thanks for all your efforts to make the projection work. Going
for a `GenericeTypeInfo` would work in many cases but unfortunately not in all.
For example
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1138#discussion_r40431134
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/operators/base/OuterJoinOperatorBase.java
---
@@ -0,0 +1,314 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1138#discussion_r40431242
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/operators/base/OuterJoinOperatorBase.java
---
@@ -0,0 +1,314 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1138#discussion_r40434251
--- Diff:
flink-optimizer/src/main/java/org/apache/flink/optimizer/dag/OuterJoinNode.java
---
@@ -0,0 +1,139 @@
+/*
+ * Licensed to the Apache
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1138#discussion_r40434718
--- Diff:
flink-optimizer/src/main/java/org/apache/flink/optimizer/dag/OuterJoinNode.java
---
@@ -0,0 +1,139 @@
+/*
+ * Licensed to the Apache
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1138#discussion_r40434856
--- Diff:
flink-optimizer/src/main/java/org/apache/flink/optimizer/dag/MatchNode.java ---
@@ -22,15 +22,16 @@
import java.util.Collections;
import
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1003#issuecomment-145854816
@sachingoel0101 Sounds good! Can you open a new PR once you are done with
the Parameter Server interface and close this PR? Thanks
---
If your project is set up
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/439#issuecomment-145854280
@qmlmoon We merged a new web dashboard a few days ago which makes this PR
obsolete. Sorry for not merging it earlier. Could you close this PR please?
Thank you
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1077#issuecomment-145855031
Hi @ogokal, do you plan to update this PR? If not, could you please close
it? Thank you.
---
If your project is set up for it, you can reply to this email and have
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1205#discussion_r41284498
--- Diff: docs/libs/gelly_guide.md ---
@@ -194,6 +194,27 @@ val edgeTuples = env.readCsvFile[String, String,
Double]("path/to/edge/input")
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1205#discussion_r41284938
--- Diff:
flink-staging/flink-gelly-scala/src/main/scala/org/apache/flink/graph/scala/Graph.scala
---
@@ -126,6 +126,122 @@ object Graph
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1205#discussion_r41287065
--- Diff:
flink-staging/flink-gelly-scala/src/main/scala/org/apache/flink/graph/scala/Graph.scala
---
@@ -126,6 +126,122 @@ object Graph
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1205#discussion_r41284820
--- Diff:
flink-staging/flink-gelly-scala/src/main/scala/org/apache/flink/graph/scala/Graph.scala
---
@@ -126,6 +126,122 @@ object Graph
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1205#discussion_r41287202
--- Diff: docs/libs/gelly_guide.md ---
@@ -194,6 +194,27 @@ val edgeTuples = env.readCsvFile[String, String,
Double]("path/to/edge/input")
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1218#issuecomment-145873239
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1160#discussion_r41279675
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/ReusingHashMatchIteratorITCase.java
---
@@ -639,9 +632,9 @@ public String
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1160#discussion_r41280171
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/ReusingHashMatchIteratorITCase.java
---
@@ -735,33 +728,31 @@ public void
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1160#discussion_r41280094
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/ReusingHashMatchIteratorITCase.java
---
@@ -692,24 +685,24 @@ public void join
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1435#issuecomment-162550891
`DataDistribution` is actually adapted and used in the range partition PR
#1255.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1436#issuecomment-162530467
Good catch, @jaoki and thanks for making me aware of this @zentol.
`Plan` was originally implemented for the Record API. For the later DataSet
API, `JavaPlan
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1255#issuecomment-162935419
Thanks for the fast update!
Your last commit seems to include changes that have already been merged to
the master branch. Can you revert it and rebase the second
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1442#issuecomment-162991974
Thanks for the patch!
Can you apply the same changes to
`org.apache.flink.api.java.hadoop.mapred.HadoopOutputFormatBase`, the base
class for `mapred` API
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1255#discussion_r46674245
--- Diff:
flink-optimizer/src/main/java/org/apache/flink/optimizer/traversals/RangePartitionRewriter.java
---
@@ -0,0 +1,194 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1255#discussion_r46555497
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/distributions/CommonRangeBoundaries.java
---
@@ -0,0 +1,76 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1255#discussion_r46556467
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/distributions/SampledDataDistribution.java
---
@@ -0,0 +1,49 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1255#discussion_r46556636
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/distributions/SampledDataDistribution.java
---
@@ -0,0 +1,49 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1255#discussion_r46558726
--- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java
---
@@ -1246,7 +1246,46 @@ public long count() throws Exception
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/1436
[FLINK-3112] Remove unused RecordModelPostPass
Class is not used and a leftover of the Record API.
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/1435
[FLINK-3113] Remove unused and unsupported global-order methods from
GenericDataSinkBase
Methods are unused and not supported by DataSet API.
You can merge this pull request into a Git repository
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1255#issuecomment-161725286
Hi @ChengXiangLi, sorry for long time until until I pick the PR up again.
It looks really good, just added a few minor comments and the one about
removing the target
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1255#discussion_r46575587
--- Diff:
flink-optimizer/src/main/java/org/apache/flink/optimizer/traversals/RangePartitionRewriter.java
---
@@ -0,0 +1,194 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1255#discussion_r46566247
--- Diff:
flink-optimizer/src/main/java/org/apache/flink/optimizer/traversals/RangePartitionRewriter.java
---
@@ -0,0 +1,194 @@
+/*
+ * Licensed
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1255#discussion_r46564786
--- Diff:
flink-optimizer/src/main/java/org/apache/flink/optimizer/traversals/RangePartitionRewriter.java
---
@@ -0,0 +1,194 @@
+/*
+ * Licensed
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1255#issuecomment-161465668
Sorry, I forgot about this PR. Thanks for reminding me.
Will check it in the next days.
---
If your project is set up for it, you can reply to this email and have
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1426#issuecomment-161045370
Hi @rmetzger, thanks for taking the initiative for this issue!
I tried to review the PR, but the diff set it too large for the Github
viewer. I know, I could
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1436#issuecomment-162680884
Going to merge this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1440#issuecomment-162680769
Going to merge this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1435#issuecomment-162680969
Going to merge this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1255#issuecomment-162608149
Hi @ChengXiangLi, I tried the PR locally on my machine and it was working
quite well.
I found a few minor issues:
- You don't need to set keys and sort order
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1442#issuecomment-164883472
I will cherry-pick the commit over to the 0.10 branch. Thanks @ndimiduk!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1442#issuecomment-164880422
Thanks for the PR! I'll merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1255#issuecomment-165404528
Thanks @uce! I extended the `RangePartitionRewriter` to cover that case and
will include the changes when I merge the PR.
I also found that no combiners
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1463#issuecomment-165406300
Hi @petervandenabeele, thanks for the patch!
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1255#issuecomment-163873769
Thanks for the update. Looks good. Will try it once more on a cluster.
@uce, @StephanEwen , we inject a `DataExchangeMode.BATCH` for range
partitioning
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1255#issuecomment-165453966
I executed the Flink WordCount example on 4 nodes with 8 parallel tasks and
roughly 17GB of input data once with hash partitioning and once with range
partitioning
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1255#issuecomment-165732606
Range partitioning serves two purposes:
1. producing fully sorted results.
2. evenly balancing the load in case of skewed key distributions
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1469#issuecomment-165740727
Thanks for the PR! I will shepherd it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1455#issuecomment-164880926
Looks good. 1+ for removing `toShortString` in a separate issue.
I'll merge this PR.
---
If your project is set up for it, you can reply to this email and have your
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1427#issuecomment-165171199
Hi,
I had a look and have some comments as well
- `ExecutionConfig`: Do we want to make the whole class public? Are we sure
that we do not change
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1459#issuecomment-165031211
Hi @guochuanzhi, it looks like your PR does not include any commits of you
but just already committed changes. It does also not have a description. Can
you please close
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1482#discussion_r48831214
--- Diff: flink-dist/pom.xml ---
@@ -85,13 +85,7 @@ under the License.
org.apache.flink
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1482#discussion_r48831157
--- Diff:
flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/graph/EnumTrianglesOpt.java
---
@@ -18,25 +18,23
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1482#discussion_r48831257
--- Diff:
flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/ml/util/LinearRegressionData.java
---
@@ -20,8 +20,7
701 - 800 of 6115 matches
Mail list logo
