Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4295#discussion_r126928311
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/StreamCheckpointNotifierITCase.java
---
@@ -324,7 +322,7 @@ public void
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4295#discussion_r126928351
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/misc/SuccessAfterNetworkBuffersFailureITCase.java
---
@@ -168,6 +173,6 @@ private static void
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4295#discussion_r126928229
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/accumulators/AccumulatorIterativeITCase.java
---
@@ -30,6 +29,9 @@
import
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4295#discussion_r126928374
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/windowing/sessionwindows/GeneratorEventFactory.java
---
@@ -39,9 +39,9 @@
* @return
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4295#discussion_r126928363
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/windowing/sessionwindows/GeneratorConfiguration.java
---
@@ -36,9 +36,9 @@
private
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4305#discussion_r126921674
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/Configuration.java ---
@@ -843,7 +843,7 @@ private float convertToFloat(Object o, float
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/4304
[FLINK-6648] [gelly] Transforms for Gelly examples
Replaces GeneratedGraph class (which was extended by inputs) with the
GraphKeyTypeTransform which can also transform the algorithm result to
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4283
Okay, thanks @StephanEwen. I've added a simple starter
`BulkIterationTranslationTest` based on your `DeltaIterationTranslationTest`.
---
If your project is set up for it, you can reply to
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4205
No one has raised an objection to this update and Avro 1.8 is ~18 months
old so I'll merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4196
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r126645324
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -174,9 +210,38 @@ public void testUnrequestedByte
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4099
@zentol not sure if this was overlooked. I have rebased to master, is there
anyone you think we should check with before including this package?
---
If your project is set up for it, you can
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/4295
[FLINK-6731] [tests] Activate strict checkstyle for flink-tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3511
@heytitle apologies for the long delay. I've been working to improve the
Gelly examples to process with each of the standard data types (from byte to
string). I think we can validate bot
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r126452583
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -278,6 +518,26 @@ public void testUnrequestedRequired
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r126450338
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -174,9 +210,38 @@ public void testUnrequestedByte
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4110#discussion_r126446702
--- Diff: docs/monitoring/metrics.md ---
@@ -376,6 +376,7 @@ Parameters:
- `dmax` - hard limit for how long an old metric should be retained
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r126318967
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -34,8 +36,7 @@
@Test(expected
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r126319040
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -154,4 +149,149 @@ public void
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r126318935
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/utils/ParameterTool.java ---
@@ -548,6 +565,7 @@ protected Object clone() throws
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r126374745
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -154,4 +149,149 @@ public void
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4170#discussion_r126312918
--- Diff:
flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/Runner.java
---
@@ -103,6 +113,18 @@
.addClass
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4170#discussion_r126312909
--- Diff:
flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/Runner.java
---
@@ -103,6 +113,18 @@
.addClass
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4170#discussion_r126313414
--- Diff:
flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/Runner.java
---
@@ -305,6 +334,41 @@ public static void main(String
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4170#discussion_r126313013
--- Diff:
flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/Runner.java
---
@@ -103,6 +113,18 @@
.addClass
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4170#discussion_r126312916
--- Diff:
flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/Runner.java
---
@@ -103,6 +113,18 @@
.addClass
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4170#discussion_r126312914
--- Diff:
flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/Runner.java
---
@@ -103,6 +113,18 @@
.addClass
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4170#discussion_r126312925
--- Diff:
flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/Runner.java
---
@@ -103,6 +113,18 @@
.addClass
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4170#discussion_r126312866
--- Diff:
flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/Runner.java
---
@@ -70,7 +79,8 @@
* Algorithms must explicitly
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3643
@zentol I'm getting a build error:
[ERROR]
/home/ec2-user/flink-upstream/flink-tests/src/test/java/org/apache/flink/test/query/AbstractQueryableStateITCase.java:[365,72]
cannot
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4112
LGTM on a second look. Don't have any suggestion on NettyBufferPool. @uce?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4264
Merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4219
Thanks for the contribution @zhangminglei. Merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/4283
[FLINK-7132] [java] Fix BulkIteration parallelism
Copy the parallelism when translating a BulkIteration.
`translateBulkIteration` now mirrors the setup of the following function
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/4282
[FLINK-7019] [gelly] Rework parallelism in Gelly algorithms and examples
Flink job parallelism is set with ExecutionConfig#setParallelism or with -p
on the command-line. The Gelly algorithms
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4219
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4110
That sounds reasonable. Can we add a warning as in #4109 and replace `80`
with a constant (I see just now in `TaskMetricGroup.java` that `80` is
hard-coded in the log string rather than using the
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4219#discussion_r125902757
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/fs/hdfs/HadoopFileSystem.java
---
@@ -459,17 +459,14 @@ public boolean isDistributedFS
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4110
What can cause such a long metric identifier? It seems risky to truncate
the full identifier which could even completely remove the base name.
---
If your project is set up for it, you can reply
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4219#discussion_r125893611
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/fs/hdfs/HadoopFileSystem.java
---
@@ -459,17 +459,14 @@ public boolean isDistributedFS
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4230
@zhangminglei thanks for the contributions. Merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4064
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4110
@zentol since this has not yet been reviewed I'll chance a question: is
this needed in addition to #4109?
---
If your project is set up for it, you can reply to this email and have your
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4114
@zentol is this worthwhile to review and commit?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4201
Thanks for the review @vasia, I somehow missed the notification.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4219
The call to `hadoopConf.getClass` is no longer needed and the early `return
null` could be removed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/4264
[FLINK-7042] [yarn] Fix jar file discovery flink-yarn-tests
Add dependencies for batch and streaming WordCount programs and copies the
jar files into a new target/programs directory. The
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4233
@aljoscha this may be caused by publishing pom's with unresolved
`${scala.binary.version}`. I am planning to file a ticket after #4221 is
merged. The StackOverflow link looks promising.
-
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4068
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4221
+1. Test failure is unrelated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4221#discussion_r125350366
--- Diff: flink-examples/flink-examples-table/pom.xml ---
@@ -24,7 +24,7 @@ under the License.
org.apache.flink
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4213
LGTM thanks for the PR @pnowojski and for confirming the issue
@StefanRRichter and @aljoscha
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4233
@zentol could you start a mailing list discussion and describe your
preference for splitting the tests in this manner or splitting the repo?
Despite heroic efforts by you and Robert keeping the
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4227
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4226
+1!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4095
@zentol what is the status of the checkstyle changes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4213
Okay, I am using the latest stable release (2017.1.4) and the bundled
version is 3.3.9. Perhaps different versions are shipped for different OS.
---
If your project is set up for it, you can
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4213
No, that's what I and I assume many other have configured. I'm just
surprised that this has not been previously reported and I have not been able
to replicate the issue in IntelliJ.
-
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/4222
[FLINK-7039] [build] Increase forkCountTestPackage for sudo-enabled TravisCI
The switch from the container-based to sudo-enabled environment in TravisCI
has increased available memory from 4 GB
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4213
Are you using the Maven bundled with IntelliJ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4179
@vasia I don't think there has been much Gelly development lately :) I'll
start working on a ticket to add a Gelly documentation page covering the
examples.
---
If your project is set
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4179#discussion_r124521762
--- Diff:
flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/drivers/parameter/Parameter.java
---
@@ -40,6 +40,15
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/4203
[FLINK-7023] [gelly] Remaining types for Gelly ValueArrays
Add implementations of Byte/Char/Double/Float/ShortValueArray. Along with
the existing implementations of Int/Long/Null/StringValueArray
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/4201
[FLINK-7006] [gelly] Base class using POJOs for Gelly algorithms
Gelly algorithms commonly have a Result class extending a Tuple type and
implementing one of the Unary/Binary/TertiaryResult
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4175
Why do we have both `flink-docs-master` and `flink-docs-release-1.4`? The
main page only links to 1.3 and 1.4 but the flink-docs-master documentation
links to 1.3, 1.2, 1.1, and 1.0. But each of
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4109
Update looks good. Do we want to define `80` as a constant?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/4179
[FLINK-6989] [gelly] Refactor examples with Output interface
The current organization of the Gelly examples retains full flexibility by
handling the Graph input to the algorithm Driver and having
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/4177
[FLINK-6999] [build] Print TravisCI CPU, memory, and filesystem info
Search for or scroll down to "CPU information" near the start of the logs.
Note: had to replace {{Filesys
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4167
I'm working on a PR to print some system information (with output folding)
to the TravisCI log which may be useful in debugging these sort of changes. It
would be nice if we could fold each
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/4170
[FLINK-6358] [gelly] Write job details for Gelly examples
Add an option to write job details to a file in JSON format. Job details
include: job ID, runtime, parameters with values, and
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/4169
[FLINK-6357] [java] ParameterTool get unrequested parameters
Adds ParameterTool#getUnrequestedParameters returning a Set of
parameter arguments names not yet requested by ParameterTool#has or any
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4167
May also be able to revert `-Dflink.forkCountTestPackage=1` to 2 in
`tools/travis_mvn_watchdog.sh` with memory increased from 4 GB to 7.5 GB
(https://docs.travis-ci.com/user/ci-environment
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4159
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4148
Did we overlook adding a test to run the table examples? I think we do this
for streaming and batch.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4148#discussion_r123014213
--- Diff:
flink-examples/flink-examples-table/src/main/java/org/apache/flink/table/examples/java/WordCountSQL.java
---
@@ -65,7 +65,10 @@ public static
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4109
Is it safe to set the full `operatorName` in the parent constructor scope
but truncate in the local info and variables map? Would it be better to
explicitly fail rather than implicitly truncate
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4115
I was thinking more along the lines of a future refactoring allowing for a
larger or unlimited corpus, to include for both batch and streaming, but the
git annotations are sufficient to document
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4116
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4115
+1 and would it be good to add a note referencing the duplication in the
JavaDoc of the two (now duplicated) `WordCountData`?
---
If your project is set up for it, you can reply to this email and
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4116
Is there another usage in `DistCp.java:132: outputStream =
targetFs.create(outPath, true)`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4124
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4131#discussion_r122263994
--- Diff: docs/dev/event_time.md ---
@@ -146,7 +146,7 @@ to use timestamp assignment and watermark generation in
the Flink DataStream API
*Note
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4112
+1 and my apologies for overlooking your comprehensive description.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4114
@zentol updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/4114
[FLINK-6903] [runtime] Activate checkstyle for runtime/akka
Re-opening with corrected title.
@zentol I had this nearly done last week so am creating the pull request
for when we are
Github user greghogan closed the pull request at:
https://github.com/apache/flink/pull/4113
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/4113
[FLINk-6903] [runtime] Activate checkstyle for runtime/akka
@zentol I had this nearly done last week so am creating the pull request
for when we are ready to review `flink-runtime`.
You can
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4095
@hsaputra thanks for the review. @zentol thanks for checking on the ongoing
development so as not to interfere. If a delay is necessary then at least new
contributions will be influenced by the
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4112#discussion_r121463726
--- Diff: tools/maven/suppressions-runtime.xml ---
@@ -0,0 +1,29 @@
+
+
+
+http://www.puppycrawl.com/dtds/suppressions_1_1.dtd";>
+
+
+
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4112#discussion_r121465225
--- Diff:
flink-core/src/main/java/org/apache/flink/util/StringValueUtils.java ---
@@ -114,15 +114,17 @@ public boolean next(StringValue target
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4112
@zentol did you mean to include `[FLINK-6902] Activate strict checkstyle
for flink-streaming-scala` as the first commit?
---
If your project is set up for it, you can reply to this email and have
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4074
@zhangminglei, the ticket also lists having `start-local.sh` call
`start-cluster.sh` rather than starting a JobManager in local mode.
---
If your project is set up for it, you can reply to this
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/4099
[FLINK-6882] [runtime] Activate checkstyle for runtime/registration
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/4098
[FLINK-6880] [runtime] Activate checkstyle for runtime/iterative
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/4097
[FLINK-6879] [runtime] Activate checkstyle for runtime/memory
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/4096
[FLINK-6878] [runtime] Activate checkstyle for runtime/query
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/4095
[FLINK-6877] [runtime] Activate checkstyle for runtime/security
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/4091
[FLINK-6874] [docs] Static and transient fields ignored for POJOs
Note that static and transient fields are ignored when TypeExtrator
validates a POJO.
You can merge this pull request into a Git
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4089
A hotfix is for when no FLINK ticket has been created, and typically no PR.
This commit header should be something like `[FLINK-6783] [streaming]`.
---
If your project is set up for it, you can
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4086
Okay, second best may be to create an IntelliJ Code Style configuration for
developers to import.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
201 - 300 of 1193 matches
Mail list logo
