[GitHub] flink issue #4086: [FLINK-6865] Update checkstyle documentation

2017-06-07 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4086 If the long-term plan is to have one checkstyle then we should keep the current plain name. We may be at the point where we can rename the checkstyles and update the in-progress modules to use

[GitHub] flink issue #3998: [FLINK-6661][web] Merge "Subtasks" and "SubtasksByTaskMan...

2017-06-06 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3998 LGTM. My only suggestion would be to ask if the checkbox description should be lengthened to ""Aggregate statistics by TaskManager" or even "Aggregate task stati

[GitHub] flink pull request #4068: [FLINK-6823] Activate checkstyle for runtime/broad...

2017-06-06 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/4068#discussion_r120427357 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/broadcast/BroadcastVariableManager.java --- @@ -18,34 +18,42 @@ package

[GitHub] flink pull request #4068: [FLINK-6823] Activate checkstyle for runtime/broad...

2017-06-06 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/4068#discussion_r120427634 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/broadcast/BroadcastVariableManager.java --- @@ -18,34 +18,42 @@ package

[GitHub] flink issue #4067: [FLINK-6825] Activate checkstyle for runtime/heartbeat

2017-06-06 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4067 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #4066: [FLINK-6828] Activate checkstyle for runtime/deployment

2017-06-06 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4066 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #4065: [FLINK-6826] Activate checkstyle for runtime/net

2017-06-06 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4065 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #4064: [FLINK-6822] Activate checkstyle for runtime/pluga...

2017-06-06 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/4064#discussion_r120417811 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/plugable/ReusingDeserializationDelegate.java --- @@ -16,33 +16,31 @@ * limitations

[GitHub] flink issue #4063: [FLINK-6821] Activate checkstyle for runtime/fs

2017-06-06 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4063 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #4069: [FLINK-6723] Activate strict checkstyle for flink-librari...

2017-06-06 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4069 Thanks @tzulitai. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #4062: [FLINK-6820] Activate checkstyle for runtime/filecache

2017-06-06 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4062 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #4069: [FLINK-6723] Activate strict checkstyle for flink-librari...

2017-06-06 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4069 +1 Are the tests failing for lack of the fix reordering the pom in `flink-dist`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink issue #4077: [FLINK-6852] Fix misuse of GCD

2017-06-06 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4077 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #4056: [FLINK-6824] Activate checkstyle for runtime/event

2017-06-02 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4056 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #4057: [FLINK-6831] Activate checkstyle for runtime/*

2017-06-02 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4057 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #4054: [FLINK-6827] Activate checkstyle for runtime/webmonitor

2017-06-02 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4054 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #4053: [FLINK-6819] Activate checkstyle for runtime/leaderretrie...

2017-06-02 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4053 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #4051: [FLINK-6818] Activate checkstyle for runtime/history

2017-06-02 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4051 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #4037: [FLINK-6793] Activate checkstyle for runtime/metrics

2017-06-01 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4037 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #3832: [FLINK-6466] [build] Build Hadoop 2.8.0 convenience binar...

2017-06-01 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3832 Merging ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #4040: [FLINK-6795] Activate checkstyle for runtime/process

2017-06-01 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4040 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #4038: [FLINK-6794] Activate checkstyle for migration/**

2017-06-01 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4038 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #3975: [FLINK-6038][docs] Added deep links to Bahir connectors

2017-05-31 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3975 @alpinegizmo thanks for the contribution! Merging ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request #4029: [FLINK-6777] [shell] Activate strict checkstyle

2017-05-31 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/4029#discussion_r119376183 --- Diff: flink-scala-shell/src/main/java/org/apache/flink/api/java/JarHelper.java --- @@ -71,144 +71,151 @@ public JarHelper() {} public void

[GitHub] flink issue #4032: [Proposal] Gradually introduce checkstyle into flink-runt...

2017-05-31 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4032 +1 very nice! Also, once other modules are complete we can move the "strict checkstyle" to be just the "checkstyle" while this work is finished. --- If your project is se

[GitHub] flink pull request #4031: [FLINK-6778] [dist] Activate strict checkstyle

2017-05-31 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/4031 [FLINK-6778] [dist] Activate strict checkstyle You can merge this pull request into a Git repository by running: $ git pull https://github.com/greghogan/flink

[GitHub] flink pull request #4030: [FLINK-6779] [scala] Activate strict checkstyle

2017-05-31 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/4030 [FLINK-6779] [scala] Activate strict checkstyle You can merge this pull request into a Git repository by running: $ git pull https://github.com/greghogan/flink

[GitHub] flink pull request #4029: [FLINK-6777] [shell] Activate strict checkstyle

2017-05-31 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/4029 [FLINK-6777] [shell] Activate strict checkstyle You can merge this pull request into a Git repository by running: $ git pull https://github.com/greghogan/flink

[GitHub] flink issue #4004: [FLINK-6695] Activate strict checkstyle in flink-contrib

2017-05-31 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4004 +1! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #4027: [FLINK-6752] Apply non-invasive checkstyle rules to flink...

2017-05-31 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4027 How much value is there in keeping the checkstyle changes to a single commit per module? It would mean fewer rebase conflicts for outstanding PRs and WIPs. The long-running tickets for large

[GitHub] flink pull request #4021: [FLINK-6722] [table] Activate strict checkstyle

2017-05-30 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/4021 [FLINK-6722] [table] Activate strict checkstyle You can merge this pull request into a Git repository by running: $ git pull https://github.com/greghogan/flink

[GitHub] flink issue #3911: [FLINK-6539] Add end-to-end tests

2017-05-30 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3911 @aljoscha, okay, here the directory is perhaps mistyped `.test-infa`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink issue #3911: [FLINK-6539] Add end-to-end tests

2017-05-30 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3911 @aljoscha why a hidden directory? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink pull request #4004: [FLINK-6695] Activate strict checkstyle in flink-c...

2017-05-30 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/4004#discussion_r119082485 --- Diff: flink-contrib/flink-storm-examples/src/test/java/org/apache/flink/storm/split/SplitBoltTopology.java --- @@ -28,7 +28,7 @@ import

[GitHub] flink pull request #4004: [FLINK-6695] Activate strict checkstyle in flink-c...

2017-05-28 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/4004#discussion_r118850077 --- Diff: flink-contrib/flink-storm-examples/src/test/java/org/apache/flink/storm/split/SplitBoltTopology.java --- @@ -28,7 +28,7 @@ import

[GitHub] flink pull request #4004: [FLINK-6695] Activate strict checkstyle in flink-c...

2017-05-28 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/4004#discussion_r118850085 --- Diff: flink-contrib/flink-storm-examples/src/test/java/org/apache/flink/storm/tests/operators/FiniteRandomSpout.java --- @@ -32,8 +32,8

[GitHub] flink pull request #4004: [FLINK-6695] Activate strict checkstyle in flink-c...

2017-05-28 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/4004#discussion_r118850095 --- Diff: flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/split/operators/VerifyAndEnrichBolt.java --- @@ -30,7 +30,7

[GitHub] flink issue #4005: [FLINK-6699] Add checkstyle plugin to flink-yarn-tests po...

2017-05-28 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4005 +1 failing test is unrelated. Thanks for correcting this @zentol! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request #4004: [FLINK-6695] Activate strict checkstyle in flink-c...

2017-05-28 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/4004#discussion_r118845656 --- Diff: flink-contrib/flink-storm-examples/src/test/java/org/apache/flink/storm/tests/operators/VerifyMetaDataBolt.java --- @@ -28,6 +27,11

[GitHub] flink pull request #4004: [FLINK-6695] Activate strict checkstyle in flink-c...

2017-05-28 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/4004#discussion_r118845592 --- Diff: flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/split/operators/VerifyAndEnrichBolt.java --- @@ -27,6 +26,12

[GitHub] flink pull request #4004: [FLINK-6695] Activate strict checkstyle in flink-c...

2017-05-28 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/4004#discussion_r118845646 --- Diff: flink-contrib/flink-storm-examples/src/test/java/org/apache/flink/storm/tests/operators/FiniteRandomSpout.java --- @@ -30,6 +28,13

[GitHub] flink pull request #4004: [FLINK-6695] Activate strict checkstyle in flink-c...

2017-05-28 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/4004#discussion_r118845633 --- Diff: flink-contrib/flink-storm-examples/src/test/java/org/apache/flink/storm/split/SplitBoltTopology.java --- @@ -15,23 +15,28 @@ * See

[GitHub] flink issue #3992: [FLINK-6711] Activate strict checkstyle for flink-connect...

2017-05-27 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3992 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #3999: [FLINK-6720] Activate strict checkstyle in flink-java8

2017-05-27 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3999 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #3999: [FLINK-6720] Activate strict checkstyle in flink-j...

2017-05-26 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3999#discussion_r118787991 --- Diff: flink-java8/src/test/java/org/apache/flink/cep/CEPLambdaTest.java --- @@ -33,23 +33,31 @@ import java.util.List; import java.util.Map

[GitHub] flink pull request #3999: [FLINK-6720] Activate strict checkstyle in flink-j...

2017-05-26 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3999#discussion_r118791491 --- Diff: flink-java8/src/test/java/org/apache/flink/test/api/java/operators/lambdas/FilterITCase.java --- @@ -35,27 +38,38 @@ public static

[GitHub] flink pull request #3992: [FLINK-6711] Activate strict checkstyle for flink-...

2017-05-26 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3992#discussion_r118738325 --- Diff: flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/RollingSink.java --- @@ -266,7 +265,7

[GitHub] flink pull request #3992: [FLINK-6711] Activate strict checkstyle for flink-...

2017-05-26 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3992#discussion_r118738883 --- Diff: flink-connectors/flink-connector-filesystem/src/test/java/org/apache/flink/streaming/connectors/fs/RollingSinkSecuredITCase.java --- @@ -47,21

[GitHub] flink pull request #3992: [FLINK-6711] Activate strict checkstyle for flink-...

2017-05-26 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3992#discussion_r118739552 --- Diff: flink-connectors/flink-avro/src/main/java/org/apache/flink/api/avro/FSDataInputStreamWrapper.java --- @@ -16,20 +16,19 @@ * limitations

[GitHub] flink pull request #3992: [FLINK-6711] Activate strict checkstyle for flink-...

2017-05-26 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3992#discussion_r118738236 --- Diff: flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/Kafka08JsonTableSink.java --- @@ -42,7

[GitHub] flink pull request #3992: [FLINK-6711] Activate strict checkstyle for flink-...

2017-05-26 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3992#discussion_r118730394 --- Diff: flink-connectors/flink-connector-kafka-0.10/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer010.java --- @@ -62,11

[GitHub] flink pull request #3992: [FLINK-6711] Activate strict checkstyle for flink-...

2017-05-26 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3992#discussion_r118726185 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSource.java --- @@ -105,7 +105,7

[GitHub] flink pull request #3992: [FLINK-6711] Activate strict checkstyle for flink-...

2017-05-26 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3992#discussion_r118735031 --- Diff: flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/testutils/FailingIdentityMapper.java

[GitHub] flink pull request #3992: [FLINK-6711] Activate strict checkstyle for flink-...

2017-05-26 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3992#discussion_r118725529 --- Diff: flink-connectors/flink-connector-nifi/src/main/java/org/apache/flink/streaming/connectors/nifi/NiFiDataPacket.java --- @@ -14,13 +14,14

[GitHub] flink pull request #3992: [FLINK-6711] Activate strict checkstyle for flink-...

2017-05-26 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3992#discussion_r118729203 --- Diff: flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkBase.java

[GitHub] flink pull request #3992: [FLINK-6711] Activate strict checkstyle for flink-...

2017-05-26 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3992#discussion_r118732112 --- Diff: flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/Kafka08JsonTableSink.java --- @@ -15,23

[GitHub] flink pull request #3992: [FLINK-6711] Activate strict checkstyle for flink-...

2017-05-26 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3992#discussion_r118734813 --- Diff: flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSourceTestBase.java

[GitHub] flink pull request #3992: [FLINK-6711] Activate strict checkstyle for flink-...

2017-05-26 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3992#discussion_r118727020 --- Diff: flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/split/GenericParameterValuesProvider.java --- @@ -15,22 +15,22

[GitHub] flink pull request #3992: [FLINK-6711] Activate strict checkstyle for flink-...

2017-05-26 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3992#discussion_r118732131 --- Diff: flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/Kafka08JsonTableSink.java --- @@ -42,7

[GitHub] flink pull request #3992: [FLINK-6711] Activate strict checkstyle for flink-...

2017-05-26 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3992#discussion_r118728159 --- Diff: flink-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/example/HBaseWriteStreamExample.java --- @@ -17,27 +17,27

[GitHub] flink pull request #3992: [FLINK-6711] Activate strict checkstyle for flink-...

2017-05-26 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3992#discussion_r118731513 --- Diff: flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer08.java --- @@ -102,21

[GitHub] flink issue #3990: [FLINK-6701] Activate strict checkstyle for flink-yarn

2017-05-26 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3990 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #3997: [FLINK-6709] [gelly] Activate strict checkstyle fo...

2017-05-26 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3997#discussion_r118729917 --- Diff: flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/examples/data/TriangleCountData.java --- @@ -33,7 +33,15

[GitHub] flink issue #3991: [FLINK-6721] Activate strict checkstyle for flink-fs-test...

2017-05-26 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3991 @zentol did you receive notification of my "approval"? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] flink pull request #3990: [FLINK-6701] Activate strict checkstyle for flink-...

2017-05-26 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3990#discussion_r118719900 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java --- @@ -984,11 +983,10 @@ private void

[GitHub] flink pull request #3990: [FLINK-6701] Activate strict checkstyle for flink-...

2017-05-26 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3990#discussion_r118720449 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnApplicationMasterRunner.java --- @@ -494,10 +485,10 @@ protected int runApplicationMaster

[GitHub] flink pull request #3990: [FLINK-6701] Activate strict checkstyle for flink-...

2017-05-26 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3990#discussion_r118723341 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java --- @@ -37,75 +37,74 @@ import

[GitHub] flink pull request #3996: [FLINK-6728] Activate strict checkstyle for flink-...

2017-05-26 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3996#discussion_r118713891 --- Diff: flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/src/main/java/SocketTextStreamWordCount.java --- @@ -27,26 +27,23

[GitHub] flink pull request #3997: [FLINK-6709] [gelly] Activate strict checkstyle fo...

2017-05-26 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3997#discussion_r118697559 --- Diff: flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/examples/data/TriangleCountData.java --- @@ -33,7 +33,15

[GitHub] flink pull request #3997: [FLINK-6709] [gelly] Activate strict checkstyle fo...

2017-05-26 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/3997 [FLINK-6709] [gelly] Activate strict checkstyle for flink-gellies You can merge this pull request into a Git repository by running: $ git pull https://github.com/greghogan/flink

[GitHub] flink pull request #3989: [FLINK-6719] Activate strict checkstyle for flink-...

2017-05-25 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3989#discussion_r118492307 --- Diff: flink-clients/src/test/java/org/apache/flink/client/program/ClientTest.java --- @@ -369,68 +372,87 @@ public static void main(String[] args

[GitHub] flink issue #3989: [FLINK-6719] Activate strict checkstyle for flink-clients

2017-05-25 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3989 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #3988: [FLINK-6715] Activate strict checkstyle for flink-...

2017-05-25 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3988#discussion_r118477940 --- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java --- @@ -284,8 +286,8 @@ public String

[GitHub] flink pull request #3986: [FLINK-6707] [examples] Activate strict checkstyle...

2017-05-24 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/3986 [FLINK-6707] [examples] Activate strict checkstyle for flink-examples You can merge this pull request into a Git repository by running: $ git pull https://github.com/greghogan/flink

[GitHub] flink issue #3985: [FLINK-6699] Activate strict checkstyle for flink-yarn-te...

2017-05-24 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3985 +1 with green from Travis --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink pull request #3975: [FLINK-6038][docs] Added deep links to Bahir conne...

2017-05-24 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3975#discussion_r118245299 --- Diff: docs/dev/connectors/index.md --- @@ -54,6 +54,16 @@ Note also that while the streaming connectors listed in this section are part of Flink

[GitHub] flink issue #3983: [FLINK-6688] Activate strict checkstyle for flink-test-ut...

2017-05-24 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3983 +1 if Travis --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #3973: [FLINK-6687] [web] Activate strict checkstyle for flink-r...

2017-05-23 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3973 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #3973: [FLINK-6687] [web] Activate strict checkstyle for ...

2017-05-23 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3973#discussion_r118071367 --- Diff: flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/handlers/checkpoints/CheckpointStatsSubtaskDetailsHandlerTest.java

[GitHub] flink pull request #3973: [FLINK-6687] [web] Activate strict checkstyle for ...

2017-05-23 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3973#discussion_r118060440 --- Diff: flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/metrics/MetricStoreTest.java --- @@ -15,17 +15,22 @@ * See

[GitHub] flink pull request #3973: [FLINK-6687] [web] Activate strict checkstyle for ...

2017-05-23 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3973#discussion_r118071671 --- Diff: flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/metrics/TaskManagerMetricsHandlerTest.java --- @@ -33,6 +34,9

[GitHub] flink pull request #3973: [FLINK-6687] [web] Activate strict checkstyle for ...

2017-05-23 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3973#discussion_r118058165 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/TaskManagerLogHandler.java --- @@ -100,26 +101,27

[GitHub] flink pull request #3973: [FLINK-6687] [web] Activate strict checkstyle for ...

2017-05-23 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3973#discussion_r118056115 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/RuntimeMonitorHandler.java --- @@ -29,15 +34,8 @@ import

[GitHub] flink pull request #3973: [FLINK-6687] [web] Activate strict checkstyle for ...

2017-05-23 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3973#discussion_r118057623 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/RequestHandler.java --- @@ -36,13 +37,15 @@ * respond

[GitHub] flink issue #3969: [FLINK-6432] [py] Activate strict checkstyle for flink-py...

2017-05-23 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3969 +1 to merge after Travis gives the green light. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #3970: [FLINK-6675] Activate strict checkstyle for flink-annotat...

2017-05-23 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3970 +1 to merge after Travis gives the green light. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #3968: [FLINK-6431] [metrics] Activate strict checkstyle in flin...

2017-05-23 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3968 +1 to merge after Travis gives the green light. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request #3968: [FLINK-6431] [metrics] Activate strict checkstyle ...

2017-05-23 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3968#discussion_r117987690 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -146,44 +146,38 @@ public

[GitHub] flink pull request #3968: [FLINK-6431] [metrics] Activate strict checkstyle ...

2017-05-23 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3968#discussion_r117989481 --- Diff: flink-metrics/pom.xml --- @@ -60,4 +60,42 @@ under the License

[GitHub] flink pull request #3968: [FLINK-6431] [metrics] Activate strict checkstyle ...

2017-05-23 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3968#discussion_r117988627 --- Diff: flink-metrics/pom.xml --- @@ -60,4 +60,42 @@ under the License

[GitHub] flink issue #3964: [FLINK-6660][docs] expand the connectors overview page

2017-05-23 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3964 I have a question on the names "predefined" and "bundled". There is also the 3rd category of connectors from Bahir. Perhaps this can be reconsidered in the following update.

[GitHub] flink pull request #3964: [FLINK-6660][docs] expand the connectors overview ...

2017-05-22 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3964#discussion_r117838617 --- Diff: docs/dev/connectors/index.md --- @@ -25,22 +25,54 @@ specific language governing permissions and limitations under the License

[GitHub] flink issue #3941: [FLINK-6603] [streaming] Enable checkstyle on test source...

2017-05-22 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3941 @zentol added `EmptyLineSeparator` to the strict checkstyle. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request #3946: [FLINK-6446] Fix some small issues in the web UI

2017-05-22 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3946#discussion_r117775128 --- Diff: flink-runtime-web/web-dashboard/app/partials/jobs/job.plan.jade --- @@ -28,10 +28,10 @@ split a(ui-sref=".subtasks({n

[GitHub] flink pull request #3957: [FLINK-6332] [build] Upgrade Scala versions

2017-05-19 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/3957 [FLINK-6332] [build] Upgrade Scala versions Upgrade to the last maintenance releases of Scala 2.10 and 2.11. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] flink issue #3941: [FLINK-6603] [streaming] Enable checkstyle on test source...

2017-05-19 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3941 @StephanEwen please verify the first commit implements the desired/traditional import order. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink issue #3955: [FLINK-6644] Don't register HUP signal handler on Windows

2017-05-19 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3955 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #3954: [FLINK-6628] Fix start scripts on Windows

2017-05-19 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3954 +1 and to fix in 1.3.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] flink issue #3953: [FLINK-6551] Reject empty OutputTag names

2017-05-19 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3953 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #3907: [FLINK-6586] InputGateMetrics return 0 as minimum for loc...

2017-05-19 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3907 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

<    1   2   3   4   5   6   7   8   9   10   >