[GitHub] flink issue #2352: [FLINK-4370] Add an IntelliJ Inspections Profile

2017-04-26 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2352 @StephanEwen can these be shared under `tools/idea/...`? If they are installed by default then any user modifications will be noted by git. Conversely, most contributors won't notice these files

[GitHub] flink issue #3511: [Flink-5734] code generation for normalizedkey sorter

2017-04-26 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3511 @heytitle please remove the old FLINK-3722 commits and rebase to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request #3779: [FLINK-6382] [gelly] Support all numeric types for...

2017-04-26 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/3779 [FLINK-6382] [gelly] Support all numeric types for generated graphs in Gelly examples The Gelly examples current support IntValue, LongValue, and StringValue for RMatGraph. Allow transformations

[GitHub] flink pull request #3757: (refactor) some opportunities to use multi-catch

2017-04-24 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3757#discussion_r112941684 --- Diff: flink-connectors/flink-avro/src/main/java/org/apache/flink/api/java/io/AvroOutputFormat.java --- @@ -125,9 +125,7 @@ public void open(int

[GitHub] flink pull request #3747: [FLINK-5623] [runtime] Fix TempBarrier dam has bee...

2017-04-20 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/3747 [FLINK-5623] [runtime] Fix TempBarrier dam has been closed Properly reset the "pipeline breaker" upon closing. You can merge this pull request into a Git repository by running:

[GitHub] flink issue #3701: [FLINK-6280] [scripts] Allow logging with Java flags

2017-04-20 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3701 @StephanEwen added some documentation covering use and examples. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink issue #3701: [FLINK-6280] [scripts] Allow logging with Java flags

2017-04-19 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3701 I had provided some examples in the JIRA, but yes, it allows delaying evaluation of the java opts (with double quotes) until immediately before the daemon is started. This allows creating

[GitHub] flink issue #3734: [FLINK-6300] Use 'exec' in start-foreground calls

2017-04-18 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3734 @patricklucas yes, had just come back to say that :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #3734: [FLINK-6300] Use 'exec' in start-foreground calls

2017-04-18 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3734 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #3711: [FLINK-6286] [script] Fix the hbase command not found err...

2017-04-18 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3711 @fhueske can grant you Jira permissions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #3711: [FLINK-6286] [script] Fix the hbase command not found err...

2017-04-16 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3711 @lingjinjiang thanks for your contribution! Merging ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink issue #3717: [FLINK-6304][table]Clear a lot of useless import

2017-04-13 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3717 Thanks for the cleanup. Looks good, tests have passed, merging ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request #3711: [FLINK-6286] [script] Fix the hbase command not fo...

2017-04-13 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3711#discussion_r111397645 --- Diff: flink-dist/src/main/flink-bin/bin/config.sh --- @@ -310,8 +310,16 @@ fi INTERNAL_HADOOP_CLASSPATHS="${HADOOP_CLASSPATH}:${HADOOP_CON

[GitHub] flink issue #3716: [FLINK-6298]Local execution is not setting RuntimeContext...

2017-04-13 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3716 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #3711: [FLINK-6286] [script] Fix the hbase command not found err...

2017-04-12 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3711 Would it be better to replace the outer if-statement (line 312) with the test for the presence of `hbase`? And to log a message that `HBASE_CONF_DIR` is defined but `hbase` was not found so

[GitHub] flink issue #3711: [FLINK-6286] [script] Fix the hbase command not found err...

2017-04-12 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3711 Hi @lingjinjiang, I am not familiar with configuring HBase for Flink and we don't seem to have documentation on this. What does it mean to have `HBASE_CONF_DIR` set but not have `hbase` available

[GitHub] flink issue #3703: [FLINK-5005] WIP: publish scala 2.12 artifacts

2017-04-08 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3703 @DieBauer thanks for taking this on! I haven't been using Flink with Scala but I think this will be important to have for the May release. The required changes for type inferences

[GitHub] flink issue #3702: [FLINK-6282] Fix some spelling mistake

2017-04-08 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3702 +1. Merging ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #3595: [FLINK-6162]Fix bug in ByteArrayOutputStreamWithPos#setPo...

2017-04-07 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3595 @wenlong88 thanks for the contribution (and the ping)! Merging ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request #3701: [FLINK-6280] [scripts] Allow logging with Java fla...

2017-04-07 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/3701 [FLINK-6280] [scripts] Allow logging with Java flags Evaluate user-defined Java options immediately before starting services and rotate all log files. You can merge this pull request into a Git

[GitHub] flink issue #3632: [FLINK-6176] [scripts] Add JARs to CLASSPATH deterministi...

2017-04-07 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3632 Updated for YARN @StephanEwen @EronWright --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request #3691: [FLINK-6195] [build] Move gelly-examples jar from ...

2017-04-06 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/3691 [FLINK-6195] [build] Move gelly-examples jar from opt to examples The opt directory should be reserved for Flink JARs which users may optionally move to lib to be loaded by the runtime. flink

[GitHub] flink pull request #3690: [FLINK-6173] [build] Move gelly-examples jar from ...

2017-04-06 Thread greghogan
Github user greghogan closed the pull request at: https://github.com/apache/flink/pull/3690 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request #3690: [FLINK-6173] [build] Move gelly-examples jar from ...

2017-04-06 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/3690 [FLINK-6173] [build] Move gelly-examples jar from opt to examples The opt directory should be reserved for Flink JARs which users may optionally move to lib to be loaded by the runtime. flink

[GitHub] flink issue #3680: [FLINK-6268] [core] Object reuse for Either type

2017-04-06 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3680 @zentol thanks for the review. I pushed a second commit to mark the added static methods as `@Internal` and renamed from `asLeft/Right` to `obtainLeft/Right`. --- If your project is set up

[GitHub] flink pull request #3680: [FLINK-6268] [core] Object reuse for Either type

2017-04-05 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/3680 [FLINK-6268] [core] Object reuse for Either type Implement object reuse for Flink's Either type by storing a reference to Right in Left and Left in Right. These references are private and remain

[GitHub] flink pull request #3382: [FLINK-3695] [gelly] ValueArray types

2017-03-31 Thread greghogan
Github user greghogan closed the pull request at: https://github.com/apache/flink/pull/3382 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink issue #2029: [FLINK-2814] Fix for DualInputPlanNode cannot be cast to ...

2017-03-31 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2029 @rehevkor5 thanks for this identifying bug and submitting this PR. My apologies for taking so long to look into this issue. With #3563 accepted I think you can go ahead and close this PR

[GitHub] flink issue #3595: [FLINK-6162]Fix bug in ByteArrayOutputStreamWithPos#setPo...

2017-03-31 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3595 @wenlong88 you are right that the position can currently be moved beyond written data. This still feels a bit like feature creep as we've added to the PR. Do you need to expand the array

[GitHub] flink issue #3382: [FLINK-3695] [gelly] ValueArray types

2017-03-31 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3382 Failing test is unrelated. Merging this after offline discussion with @vasia ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request #3616: [FLINK-6188] Correctly handle PARALLELISM_DEFAULT ...

2017-03-30 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3616#discussion_r108948674 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/transformations/StreamTransformation.java --- @@ -202,7 +203,17 @@ public int

[GitHub] flink issue #3595: [FLINK-6162]Fix bug in ByteArrayOutputStreamWithPos#setPo...

2017-03-30 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3595 When expanding with `write` the new capacity (up to `position` of course) is filled with data. Expanding with `setPosition` can leave holes in the data and may mask a bug. Since these classes

[GitHub] flink issue #3632: [FLINK-6176] [scripts] Add JARs to CLASSPATH deterministi...

2017-03-29 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3632 @EronWright this will not fix conflicts but will make debugging easier since the classpath will be consistent across filesystems and Flink installations. We currently have no order

[GitHub] flink issue #3629: [FLINK-5655][table]Add event time OVER RANGE BETWEEN x PR...

2017-03-29 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3629 @sunjincheng121 tests are failing for scalastyle line length violations. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink issue #3632: [FLINK-6176] [scripts] Add JARs to CLASSPATH deterministi...

2017-03-29 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3632 @StephanEwen will look at refactoring this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request #3595: [FLINK-6162]Fix bug in ByteArrayOutputStreamWithPo...

2017-03-29 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3595#discussion_r108438856 --- Diff: flink-core/src/test/java/org/apache/flink/core/memory/ByteArrayInputStreamWithPosTest.java --- @@ -0,0 +1,50 @@ +/* + * Licensed

[GitHub] flink pull request #3595: [FLINK-6162]Fix bug in ByteArrayOutputStreamWithPo...

2017-03-29 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3595#discussion_r108437565 --- Diff: flink-core/src/main/java/org/apache/flink/core/memory/ByteArrayInputStreamWithPos.java --- @@ -118,7 +118,8 @@ public int getPosition

[GitHub] flink pull request #3595: [FLINK-6162]Fix bug in ByteArrayOutputStreamWithPo...

2017-03-29 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3595#discussion_r108437640 --- Diff: flink-core/src/main/java/org/apache/flink/core/memory/ByteArrayOutputStreamWithPos.java --- @@ -110,7 +110,7 @@ public int getPosition

[GitHub] flink issue #3563: [FLINK-2814] [optimizer] DualInputPlanNode cannot be cast...

2017-03-29 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3563 @StephanEwen thanks for the reminder. Do you think this should also be merged to 1.2 or 1.1? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request #3635: [FLINK-5913] [gelly] Example drivers

2017-03-28 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/3635 [FLINK-5913] [gelly] Example drivers Replace existing and create new algorithm Driver implementations for each of the library methods. You can merge this pull request into a Git repository

[GitHub] flink pull request #3632: [FLINK-6176] [scripts] Add JARs to CLASSPATH deter...

2017-03-28 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/3632 [FLINK-6176] [scripts] Add JARs to CLASSPATH deterministically Sorts files read from Flink's lib directory and places the distribution JAR to the end of the CLASSPATH. You can merge this pull

[GitHub] flink pull request #3626: [FLINK-5912] [gelly] Inputs for CSV and graph gene...

2017-03-27 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/3626 [FLINK-5912] [gelly] Inputs for CSV and graph generators Create Input classes for reading graphs from CSV as well as for each of the graph generators. Inputs are tested in driver

[GitHub] flink issue #3615: [FLINK-2720] support flink-storm metrics

2017-03-27 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3615 Multiple PRs are added to one ticket but the commit header must reference the Jira ID. I think the comments here are sufficient so there is no need to close and open a new PR. --- If your

[GitHub] flink pull request #3433: [FLINK-5911] [gelly] Command-line parameters

2017-03-26 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3433#discussion_r108069363 --- Diff: flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/drivers/parameter/Parameter.java --- @@ -0,0 +1,55

[GitHub] flink issue #3567: [FLINK-6107] Add custom checkstyle for flink-streaming-ja...

2017-03-26 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3567 Google's style seems sensible since IntelliJ's style cannot be modeled in Checkstyle, the import listing is folded by default, and developers will need to load other non-default configuration

[GitHub] flink issue #3615: support flink-storm metrics

2017-03-26 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3615 Is there a Jira ticket for this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #3604: [FLINK-5998] Un-fat Hadoop from Flink fat jar

2017-03-25 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3604 @rmetzger thanks for the clarification. Sounds good! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #3567: [FLINK-6107] Add custom checkstyle for flink-streaming-ja...

2017-03-25 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3567 @aljoscha, I likewise have no great preference for import order. I do think it is important for the checkstyle to match IntelliJ's code style, either the default or a provided Flink style

[GitHub] flink pull request #3567: [FLINK-6107] Add custom checkstyle for flink-strea...

2017-03-25 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3567#discussion_r108035621 --- Diff: tools/maven/strict-checkstyle.xml --- @@ -0,0 +1,550 @@ + + +http://www.puppycrawl.com/dtds/configuration_1_3.dtd

[GitHub] flink pull request #3567: [FLINK-6107] Add custom checkstyle for flink-strea...

2017-03-24 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3567#discussion_r10860 --- Diff: tools/maven/strict-checkstyle.xml --- @@ -0,0 +1,550 @@ + + +http://www.puppycrawl.com/dtds/configuration_1_3.dtd

[GitHub] flink issue #3571: [FLINK-6128] Optimize JVM options for improve test perfor...

2017-03-24 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3571 Merging ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #3604: [FLINK-5998] Un-fat Hadoop from Flink fat jar

2017-03-24 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3604 @rmetzger, how would users know which Hadoop dependencies to include in `flink-dist-hadoop.jar`? Would they be copying multiple component jars into `lib/`? --- If your project is set up

[GitHub] flink issue #3605: [FLINK-6181][Start scripts] Fix regex in start scripts

2017-03-24 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3605 Thanks @rmetzger! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #3595: [FLINK-6162]Fix bug in ByteArrayOutputStreamWithPo...

2017-03-23 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3595#discussion_r107696959 --- Diff: flink-core/src/test/java/org/apache/flink/core/memory/ByteArrayOutputStreamWithPosTest.java --- @@ -0,0 +1,31 @@ +/* + * Licensed

[GitHub] flink pull request #3595: [FLINK-6162]Fix bug in ByteArrayOutputStreamWithPo...

2017-03-23 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3595#discussion_r107697744 --- Diff: flink-core/src/test/java/org/apache/flink/core/memory/ByteArrayOutputStreamWithPosTest.java --- @@ -0,0 +1,31 @@ +/* + * Licensed

[GitHub] flink issue #3515: [FLINK-5890] [gelly] GatherSumApply broken when object re...

2017-03-22 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3515 Not an issue of spilling memory but at least three elements are required to trigger two reduces and the error condition depends on which value is returned. @StephanEwen is this a +1

[GitHub] flink pull request #3595: [FLINK-6162]Fix bug in ByteArrayOutputStreamWithPo...

2017-03-22 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3595#discussion_r107423467 --- Diff: flink-core/src/test/java/org/apache/flink/core/memory/ByteArrayOutputStreamWithPosTest.java --- @@ -0,0 +1,31 @@ +/* + * Licensed

[GitHub] flink issue #3567: [FLINK-6107] Add custom checkstyle for flink-streaming-ja...

2017-03-20 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3567 @aljoscha should we host the new checkstyle under tools/maven/ alongside the existing checkstyle? There is already a ticket (FLINK-6137) to add a custom checkstyle to flink-cep and I don't see any

[GitHub] flink issue #3567: [FLINK-6107] Add custom checkstyle for flink-streaming-ja...

2017-03-20 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3567 @aljoscha do you think we can use a single checkstyle or will this need to be customized per module? Is this enforced by IntelliJ? --- If your project is set up for it, you can reply

[GitHub] flink issue #2029: [FLINK-2814] Fix for DualInputPlanNode cannot be cast to ...

2017-03-17 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2029 I created #3563 which combines this PR and my suggestion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request #3563: [FLINK-2814] [optimizer] DualInputPlanNode cannot ...

2017-03-17 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/3563 [FLINK-2814] [optimizer] DualInputPlanNode cannot be cast to SingleInputPlanNode WorksetIterationNode#instantiate loops over all solution and work set candidates. Since the solution set

[GitHub] flink issue #3392: [FLINK-5883] Re-adding the Exception-thrown code for List...

2017-03-16 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3392 This change also effects running in a cluster environment where the UDF requests multiple iterators but accepts that the same iterator is returned, as in the modified test. Since

[GitHub] flink issue #3392: [FLINK-5883] Re-adding the Exception-thrown code for List...

2017-03-16 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3392 @lincoln-lil @StephanEwen should this PR wait until 2.0? The modified example shows a breaking change for valid usage. --- If your project is set up for it, you can reply to this email and have

[GitHub] flink issue #3511: [Flink-5734] code generation for normalizedkey sorter

2017-03-12 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3511 Has the FLIP been [posted](https://cwiki.apache.org/confluence/display/FLINK/Flink+Improvement+Proposals) and officially discussed on the mailing list? --- If your project is set up for it, you

[GitHub] flink pull request #3516: [FLINK-6009] [java api] Deprecate DataSetUtils#che...

2017-03-11 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/3516 [FLINK-6009] [java api] Deprecate DataSetUtils#checksumHashCode This is likely only used by Gelly and we have a more featureful implementation allowing for multiple outputs and setting the job

[GitHub] flink issue #3515: [FLINK-5890] [gelly] GatherSumApply broken when object re...

2017-03-11 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3515 @StephanEwen deja vu FLINK-2883 / FLINK-3340. I'm also looking to run the FLINK-4949 IT tests with object reuse both enabled and disabled which would have highlighted this issue

[GitHub] flink pull request #3515: [FLINK-5890] [gelly] GatherSumApply broken when ob...

2017-03-11 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/3515 [FLINK-5890] [gelly] GatherSumApply broken when object reuse enabled The initial fix for this ticket is not working on larger data sets. Reduce supports returning the left input, right

[GitHub] flink issue #3433: [FLINK-5911] [gelly] Command-line parameters

2017-03-10 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3433 @vasia reusable parameters will make it much easier to add drivers and inputs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink issue #2029: [FLINK-2814] Fix for DualInputPlanNode cannot be cast to ...

2017-03-10 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2029 @StephanEwen should I create an alternate PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #3402: [FLINK-5890] [gelly] GatherSumApply broken when object re...

2017-03-10 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3402 @StephanEwen my last comment was ambiguous, I had originally modified a test and then with yesterday's commit reverted that change and added as a new test. Will merge. --- If your

[GitHub] flink issue #3402: [FLINK-5890] [gelly] GatherSumApply broken when object re...

2017-03-09 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3402 @StephanEwen, I updated the test to include the original test plus a new test with object reuse enabled. @vasia, would you be also be able to review this change? --- If your project

[GitHub] flink issue #3431: [FLINK-5910] [gelly] Framework for Gelly examples

2017-03-09 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3431 @vasia, I was only thinking of this being used in gelly examples. The documentation for the use of the example drivers will be updated but I am anticipating that users will enclose new

[GitHub] flink issue #3434: [FLINK-5909] [gelly] Interface for GraphAlgorithm results

2017-03-08 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3434 @vasia, I created `PrintableResult` with a `toPrintableString` method and is now used for both algorithms and analytics. --- If your project is set up for it, you can reply to this email and have

[GitHub] flink issue #3434: [FLINK-5909] [gelly] Interface for GraphAlgorithm results

2017-03-06 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3434 @vasia, thinking again on `AnalyticResult`, as an empty interface I could simply replace with `GraphAnalytic<K, VV, EV, ? extends AnalyticResult>` with `GraphAnalytic<K, VV, EV, ? exten

[GitHub] flink issue #3434: [FLINK-5909] [gelly] Interface for GraphAlgorithm results

2017-03-05 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3434 Thanks for the review @vasia. The Unary/Binary/TertiaryResult interfaces will allow follow-on algorithms to work with POJOs or non-conforming Tuples (where we don't assume source and target

[GitHub] flink issue #3382: [FLINK-3695] [gelly] ValueArray types

2017-03-02 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3382 @vasia, if you are available to review, I think the easiest way to do so is to first review the classes for `LongValue` then compare the diff for `IntValue` and `StringValue`. I think we

[GitHub] flink issue #3453: [FLINK-5945] [core] Close function in OuterJoinOperatorBa...

2017-03-02 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3453 @fhueske thanks for the review. The bug was affecting a test in `HITSTest` for which I have added the simple fix since I am improving the tests in FLINK-4896. Will merge after

[GitHub] flink pull request #3453: [FLINK-5945] [core] Close function in OuterJoinOpe...

2017-03-01 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/3453 [FLINK-5945] [core] Close function in OuterJoinOperatorBase#executeOnCollections Conclude OuterJoinOperatorBase#executeOnCollections with a call to FunctionUtils.closeFunction(function) in order

[GitHub] flink issue #2733: [FLINK-4896] [gelly] PageRank algorithm for directed grap...

2017-03-01 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2733 @vasia moved SG and GSA implementations to examples and updated docs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request #3434: [FLINK-5909] [gelly] Interface for GraphAlgorithm ...

2017-02-28 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/3434 [FLINK-5909] [gelly] Interface for GraphAlgorithm results Create AlgorithmResult and AnalyticResult interfaces for library algorithms to implement. This flattens algorithm results to a single

[GitHub] flink pull request #3432: [FLINK-5109] [gelly] Interface for GraphAlgorithm ...

2017-02-28 Thread greghogan
Github user greghogan closed the pull request at: https://github.com/apache/flink/pull/3432 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request #3433: [FLINK-5911] [gelly] Command-line parameters

2017-02-28 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/3433 [FLINK-5911] [gelly] Command-line parameters Create interface for parsing command-line parameters using ParameterTool and generic implementations for boolean, long, double, string, choice. You

[GitHub] flink pull request #3432: [FLINK-5109] [gelly] Interface for GraphAlgorithm ...

2017-02-28 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/3432 [FLINK-5109] [gelly] Interface for GraphAlgorithm results Create AlgorithmResult and AnalyticResult interfaces for library algorithms to implement. This flattens algorithm results to a single

[GitHub] flink pull request #3431: [FLINK-5910] [gelly] Framework for Gelly examples

2017-02-28 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/3431 [FLINK-5910] [gelly] Framework for Gelly examples Driver jobs are composed of an input, an algorithm driver, and an output. Create the interfaces for inputs, drivers, and outputs. You can merge

[GitHub] flink issue #2733: [FLINK-4896] [gelly] PageRank algorithm for directed grap...

2017-02-28 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2733 @vasia was there more you wanted to review here? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #2029: [FLINK-2814] Fix for DualInputPlanNode cannot be cast to ...

2017-02-28 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2029 @StephanEwen it is line 454: `solutionSetCandidate = siSolutionDeltaCandidate.getInput().getSource();` where I am seeing `solutionSetCandidate` changed from a `SingleInputPlanNode

[GitHub] flink pull request #2986: [FLINK-4648] Implement BipartiteGraph generator

2017-02-24 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2986#discussion_r103018907 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/bipartite/generator/CompleteBipartiteGraph.java --- @@ -0,0 +1,109

[GitHub] flink issue #2987: [FLINK-4647] Read bipartite graph

2017-02-24 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2987 @mushketyk what do you think of refactoring `GraphCsvReader` and `BipartiteGraphCsvReader` to use configuration objects using the builder patter? It would be nice to have `CsvReaderConfiguration

[GitHub] flink pull request #2885: [FLINK-1707] Affinity propagation

2017-02-24 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2885#discussion_r102992726 --- Diff: flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/ap/AffinityPropagationBulk.java --- @@ -0,0 +1,449

[GitHub] flink pull request #2885: [FLINK-1707] Affinity propagation

2017-02-24 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2885#discussion_r103001816 --- Diff: flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/ap/AffinityPropagationBulk.java --- @@ -0,0 +1,449

[GitHub] flink pull request #2885: [FLINK-1707] Affinity propagation

2017-02-24 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2885#discussion_r102998039 --- Diff: flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/ap/AffinityPropagationBulk.java --- @@ -0,0 +1,449

[GitHub] flink pull request #2885: [FLINK-1707] Affinity propagation

2017-02-24 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2885#discussion_r102994488 --- Diff: flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/ap/AffinityPropagationBulk.java --- @@ -0,0 +1,449

[GitHub] flink pull request #2885: [FLINK-1707] Affinity propagation

2017-02-24 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2885#discussion_r102995093 --- Diff: flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/ap/AffinityPropagationBulk.java --- @@ -0,0 +1,449

[GitHub] flink pull request #2885: [FLINK-1707] Affinity propagation

2017-02-24 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2885#discussion_r102991610 --- Diff: flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/ap/AffinityPropagationBulk.java --- @@ -0,0 +1,449

[GitHub] flink pull request #2885: [FLINK-1707] Affinity propagation

2017-02-24 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2885#discussion_r102996700 --- Diff: flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/ap/AffinityPropagationBulk.java --- @@ -0,0 +1,449

[GitHub] flink pull request #2885: [FLINK-1707] Affinity propagation

2017-02-24 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2885#discussion_r102999629 --- Diff: flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/ap/AffinityPropagationBulk.java --- @@ -0,0 +1,449

[GitHub] flink pull request #2885: [FLINK-1707] Affinity propagation

2017-02-24 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2885#discussion_r102994673 --- Diff: flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/ap/AffinityPropagationBulk.java --- @@ -0,0 +1,449

[GitHub] flink pull request #2885: [FLINK-1707] Affinity propagation

2017-02-24 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2885#discussion_r102998489 --- Diff: flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/ap/AffinityPropagationBulk.java --- @@ -0,0 +1,449

[GitHub] flink pull request #2885: [FLINK-1707] Affinity propagation

2017-02-24 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2885#discussion_r103001003 --- Diff: flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/ap/AffinityPropagationBulk.java --- @@ -0,0 +1,449

[GitHub] flink pull request #2885: [FLINK-1707] Affinity propagation

2017-02-24 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2885#discussion_r102998952 --- Diff: flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/ap/AffinityPropagationBulk.java --- @@ -0,0 +1,449

<    1   2   3   4   5   6   7   8   9   10   >