Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/887#issuecomment-118642591
Hello,
I have integrated the changes you suggested, so now:
1) notes are no longer in the .gitignore
2) the collect example is not in the created jars
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/887
Collect(): Fixing the akka.framesize size limitation.
In Apache Flink the results of the collect() call were returned through
akka to the client. This led to an inherent limitation to the size
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/934#issuecomment-126076384
Hi @mxm ,
Thanks a lot for the comments!
I integrated most of them. Please have a look and let me know what you
think.
For the merging
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/934#issuecomment-131208217
Just rebased with the new version of the master.
Please have a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/934#issuecomment-131209661
No problem!
This message was just a reminder.
Thanks a lot!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/887#issuecomment-123752371
Hi @mxm. Thanks a lot!
I don't have your email unfortunately.
Could you somehow send it to me?
---
If your project is set up for it, you can reply to this email
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/887#issuecomment-123756855
Thanks a lot!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/887#issuecomment-123738197
Hello,
The latest changes are pretty invasive and have a big overlap with the ones
in my pull request.
More specifically, the abstraction
Github user kl0u closed the pull request at:
https://github.com/apache/flink/pull/887
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/934
Framesize fix
In Apache Flink the results of the collect() call were returned through
akka to the client. This led to an inherent limitation to the size of the
output of a job, as this could
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/934#issuecomment-124500486
FLINK-2319
This pull request targets this ticket.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/934#issuecomment-124500737
Hello guys,
This is a new pull request, for a previous ticket.
It is aligned with recent changes in the master branch.
---
If your project is set up
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/887#issuecomment-119140624
Ok, sounds good!
Could you give the number of the ticket of the changes @mxm is doing?
Just to have a look.
---
If your project is set up for it, you can reply
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/934#issuecomment-135033380
Hello!
I just rebased. Please have a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/934#issuecomment-136782152
@mxm Sounds good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/934#issuecomment-136775729
Thanks @mxm.
Although I don't think I will have time to fix it right now.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/934#issuecomment-136765583
Hi @mxm. What do you mean?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/934#issuecomment-136771159
When I did the latest rebase it was saying that the two branches were ready
to be merged.
Is there a way to see where they have diverged?
---
If your project is set
Github user kl0u closed the pull request at:
https://github.com/apache/flink/pull/1231
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/1231
Create a deep-copy of the record when changing timestamps.
This is too fix the problem of changing the timestamps in-place, versus
creating a deep-copy and changing the timestamp in the new copy
Github user kl0u closed the pull request at:
https://github.com/apache/flink/pull/2020
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user kl0u reopened a pull request:
https://github.com/apache/flink/pull/2020
[FLINK-2314] Make Streaming File Sources Persistent
This PR solves FLINK-2314 and combines a number of sub-tasks. In addition,
it solves FLINK-3896 which was introduced as part of this task
Github user kl0u closed the pull request at:
https://github.com/apache/flink/pull/1984
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user kl0u closed the pull request at:
https://github.com/apache/flink/pull/1895
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/2093
[FLINK-3714] Add Support for "Allowed Lateness"
Allows the user to specify an "allowed lateness" for elements, before they
are dropped as late arrivals.
In addition, it defin
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/2100
[FLINK-4024] FileSourceFunction not adjusted to new IF lifecycle
Refactors the FileSourceFunction to respect the lifecycle of a
RichInputFormat.
You can merge this pull request into a Git repository
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/2093#discussion_r66787353
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/WindowedStream.java
---
@@ -121,6 +124,23 @@ public WindowedStream
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/2093#discussion_r66789406
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/WindowedStream.java
---
@@ -121,6 +124,23 @@ public WindowedStream
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/2100#discussion_r67008351
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/source/FileSourceFunctionTest.java
---
@@ -0,0 +1,258
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/2100
Thanks @fhueske for the comments.
Now that also https://github.com/apache/flink/pull/2020 is merged I will
also update that one to handle RichInputFormats.
---
If your project is set up
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/2100#discussion_r67006905
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/source/FileSourceFunctionTest.java
---
@@ -0,0 +1,258
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/2100
Hi @fhueske ! I integrated your comments and also updated the
https://github.com/apache/flink/pull/2020.
Thanks.
---
If your project is set up for it, you can reply to this email and have
Github user kl0u closed the pull request at:
https://github.com/apache/flink/pull/2020
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/2100
Thanks @fhueske ! I integrated the comments.
Let me know if you have any more.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/2100
Done! Thanks @fhueske .
Kostas
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/2142
[FLINK-3752] Add Per-Kafka-Partition Watermark Generation to the docs
As the name implies, this PR only touches the documentation and describes
how to assign timestamps and emit watermarks from within
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/2093
Thanks for merging it @aljoscha ! I am closing this PR and the issue
related to it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user kl0u closed the pull request at:
https://github.com/apache/flink/pull/2093
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/2124
@aljoscha I integrated the comments.
Let me know if there are any followups.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/2142
@rmetzger I integrated your comments.
Let me know if there are any follow-ups.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/2142
Thanks @rmetzger
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/2124
[FLINK-3647] Change StreamSource to use Processing-Time Clock Service
This PR changes the AutomaticWatermarkContext to user a pluggable
processing time clock. This
allows for better testability
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/2121
[FLINK-4075] ContinuousFileProcessingCheckpointITCase failed on Travis
Fixes the stability of the test.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/2109
Recently we added the FilePathFilter abstract class that is now used by
some user-facing functions for exactly the same reason. I would suggest that
this abstraction is also used by this PR, so that we
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/2100
Thanks @fhueske !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/2109
Hello @mushketyk and sorry for the late response.
Great that you are working on that also for the Batch API!
Recently we introduced in the Streaming API (not batch) the notion
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/2154#discussion_r68731283
--- Diff: docs/apis/streaming/windows.md ---
@@ -24,1023 +24,593 @@ specific language governing permissions and
limitations
under the License
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/2154#discussion_r68731488
--- Diff: docs/apis/streaming/windows.md ---
@@ -24,1023 +24,593 @@ specific language governing permissions and
limitations
under the License
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/2154#discussion_r68731685
--- Diff: docs/apis/streaming/windows.md ---
@@ -24,1023 +24,593 @@ specific language governing permissions and
limitations
under the License
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/2154#discussion_r68731943
--- Diff: docs/apis/streaming/windows.md ---
@@ -24,1023 +24,593 @@ specific language governing permissions and
limitations
under the License
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/2154#discussion_r68732942
--- Diff: docs/apis/streaming/windows.md ---
@@ -24,1023 +24,593 @@ specific language governing permissions and
limitations
under the License
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/2154#discussion_r68743505
--- Diff: docs/apis/streaming/windows.md ---
@@ -24,1023 +24,593 @@ specific language governing permissions and
limitations
under the License
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/2154#discussion_r68732802
--- Diff: docs/apis/streaming/windows.md ---
@@ -24,1023 +24,593 @@ specific language governing permissions and
limitations
under the License
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/2154#discussion_r68733572
--- Diff: docs/apis/streaming/windows.md ---
@@ -24,1023 +24,593 @@ specific language governing permissions and
limitations
under the License
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/2154#discussion_r68743168
--- Diff: docs/apis/streaming/windows.md ---
@@ -24,1023 +24,593 @@ specific language governing permissions and
limitations
under the License
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/2154#discussion_r68731626
--- Diff: docs/apis/streaming/windows.md ---
@@ -24,1023 +24,593 @@ specific language governing permissions and
limitations
under the License
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/2154#discussion_r68732411
--- Diff: docs/apis/streaming/windows.md ---
@@ -24,1023 +24,593 @@ specific language governing permissions and
limitations
under the License
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/2174
[FLINK-4075] ContinuousFileProcessingCheckpointITCase failed on Travis
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kl0u/flink hotfix_file_src
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/2154#discussion_r68742875
--- Diff: docs/apis/streaming/windows.md ---
@@ -24,1023 +24,593 @@ specific language governing permissions and
limitations
under the License
Github user kl0u closed the pull request at:
https://github.com/apache/flink/pull/2121
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1588#issuecomment-180847040
Thanks a lot for the comments @rmetzger and @StephanEwen .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1583#issuecomment-182414285
Please review the new pull request.
This pull request is the first step for the one about FLINK-2523.
Thanks a lot!
---
If your project is set up
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1612#issuecomment-182413649
Thanks a lot for the comments @rmetzger and @tillrohrmann . I integrated
them.
Please review the new pull request.
This pull request is based upon the one about
Github user kl0u closed the pull request at:
https://github.com/apache/flink/pull/1546
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/1588#discussion_r52106077
--- Diff: docs/setup/config.md ---
@@ -211,6 +211,8 @@ The parameters define the behavior of tasks that create
result files.
yarn.application
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1583#issuecomment-181917384
Thanks a lot @StephanEwen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1524#issuecomment-183330257
Thanks for the comment @rmetzger. I changed the error message. Please
review and let me know.
---
If your project is set up for it, you can reply to this email and have
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/1612#discussion_r52388927
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java ---
@@ -102,60 +101,150
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/1612#discussion_r52388853
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java ---
@@ -102,60 +101,150
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/1612#discussion_r52388350
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/deployment/TaskDeploymentDescriptor.java
---
@@ -141,9 +146,16 @@ public
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/1612#discussion_r52388830
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java ---
@@ -102,60 +101,150
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/1612
FLINK-2523: Makes the task cancellation interval configurable.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kl0u/flink
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1524#issuecomment-182817638
Thanks @rmetzger for the comment. Will fix it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/1588
FLINK-2213 Makes the number of vcores per YARN container configurable.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kl0u/flink vcores_param
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1548#issuecomment-174917008
Thanks a lot @fhueske !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1524#issuecomment-178507931
Could you explain what more tests do you have in mind? So far I am testing
1) if the scheme provided in the configuration is used when one is not
explicitly provided, 2
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/1583
ExecutionConfig to JobGraph.
This makes the ExecutionConfig available to the Task. In a nutshell, the
ExecutionConfig is attached to the JobGraph which is sent to the JobManager.
The JobManager
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/1568
FLINK-3254: Adding functionality to support the CombineFunction contract.
Solves ISSUE-3254: now a function that implements the GroupReduceFunction
and the CombineFunction interfaces will be executed
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/1568#discussion_r51427689
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/operators/GroupReduceOperator.java
---
@@ -156,8 +162,8 @@ public boolean isCombinable
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1583#issuecomment-187143786
Just rebased. Please review this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1662#issuecomment-187144324
Just rebased. Please review this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1588#issuecomment-187700884
Thanks @rmetzger
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/1524
FLINK-2380: allow to specify the default filesystem scheme in the flink
configuration file.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kl0u
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/1546#discussion_r50694370
--- Diff:
flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/wordcount/WordCount.java
---
@@ -60,6 +60,7 @@ public static void
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/1548
FLINK-3198: Renames and documents the getDataSet() method in Grouping.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kl0u/flink groupBy_renaming
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/1546
FLINK-2523: making the task cancellation interval configurable.
FLINK-2523: Makes the task cancellation interval configurable.
You can merge this pull request into a Git repository by running
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1546#issuecomment-174548688
Hi @StephanEwen ,
Could you please elaborate more on how you think that the ExecutionConfig
could be accessed differently by the Task?
Thanks
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/1524#discussion_r50253291
--- Diff: docs/setup/config.md ---
@@ -52,6 +52,14 @@ The configuration files for the TaskManagers can be
different, Flink does
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1583#issuecomment-184236773
Hello! Just rebased to the new master. Please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1612#issuecomment-184236866
Hello! Just rebased to the new master. Please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1635#issuecomment-184688675
Thanks a lot @rmetzger !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/1524#discussion_r53014739
--- Diff:
flink-yarn/src/main/scala/org/apache/flink/yarn/ApplicationMasterBase.scala ---
@@ -176,6 +184,8 @@ abstract class ApplicationMasterBase
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1524#issuecomment-184703065
Perfect! Thanks a lot @rmetzger
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user kl0u closed the pull request at:
https://github.com/apache/flink/pull/1612
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/1662
FLINK-2523: Makes the task cancellation interval configurable.
This PR is rebased on top of https://github.com/apache/flink/pull/1583 .
Please review that first.
You can merge this pull request
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1583#issuecomment-185271802
Hello!
I just rebased to the new master.
Please review this new PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1583#issuecomment-185210139
Hello! I just rebased to the new master.
Please review this new PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1583#issuecomment-185637076
Please Review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1662#issuecomment-185637228
Please review.
IMPORTANT NOTE: This PR is rebased on top of #1583 . Please review that
first.
---
If your project is set up for it, you can reply to this email
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1583#issuecomment-185734236
The problem is the CRLF vs LF characters in the committed versions of the
files.
---
If your project is set up for it, you can reply to this email and have your
reply
1 - 100 of 952 matches
Mail list logo
