[GitHub] flink pull request: FLINK-2380: allow to specify the default files...

2016-02-16 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/1524#discussion_r53014739 --- Diff: flink-yarn/src/main/scala/org/apache/flink/yarn/ApplicationMasterBase.scala --- @@ -176,6 +184,8 @@ abstract class ApplicationMasterBase

[GitHub] flink pull request: FLINK-3304: Making the Avro Schema serializabl...

2016-02-16 Thread kl0u
Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/1635#issuecomment-184688675 Thanks a lot @rmetzger ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: FLINK-2523: Makes the task cancellation interv...

2016-02-15 Thread kl0u
Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/1612#issuecomment-184236866 Hello! Just rebased to the new master. Please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: FLINK-3327: ExecutionConfig to JobGraph.

2016-02-15 Thread kl0u
Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/1583#issuecomment-184236773 Hello! Just rebased to the new master. Please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: FLINK-3304: Making the Avro Schema serializabl...

2016-02-14 Thread kl0u
Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/1635#issuecomment-183938932 Thanks a lot @rmetzger --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: FLINK-3304: Making the Avro Schema serializabl...

2016-02-14 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/1635 FLINK-3304: Making the Avro Schema serializable. This solves the issue FLINK-3304 by making the Avro Schema serializable. This is done by having a custom serializer which transforms the Schema

[GitHub] flink pull request: FLINK-2380: allow to specify the default files...

2016-02-12 Thread kl0u
Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/1524#issuecomment-183330257 Thanks for the comment @rmetzger. I changed the error message. Please review and let me know. --- If your project is set up for it, you can reply to this email and have

[GitHub] flink pull request: FLINK-2380: allow to specify the default files...

2016-02-11 Thread kl0u
Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/1524#issuecomment-182817638 Thanks @rmetzger for the comment. Will fix it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: FLINK-2380: allow to specify the default files...

2016-02-11 Thread kl0u
Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/1524#issuecomment-182951707 I have updated the PR with the new comments. Please review the new PR. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: FLINK-3327: ExecutionConfig to JobGraph.

2016-02-10 Thread kl0u
Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/1583#issuecomment-182414285 Please review the new pull request. This pull request is the first step for the one about FLINK-2523. Thanks a lot! --- If your project is set up

[GitHub] flink pull request: FLINK-2523: Makes the task cancellation interv...

2016-02-10 Thread kl0u
Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/1612#issuecomment-182413649 Thanks a lot for the comments @rmetzger and @tillrohrmann . I integrated them. Please review the new pull request. This pull request is based upon the one about

[GitHub] flink pull request: ExecutionConfig to JobGraph.

2016-02-09 Thread kl0u
Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/1583#issuecomment-181917384 Thanks a lot @StephanEwen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: FLINK-2523: Makes the task cancellation interv...

2016-02-09 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/1612#discussion_r52388927 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java --- @@ -102,60 +101,150

[GitHub] flink pull request: FLINK-2523: Makes the task cancellation interv...

2016-02-09 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/1612#discussion_r52388853 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java --- @@ -102,60 +101,150

[GitHub] flink pull request: FLINK-2523: Makes the task cancellation interv...

2016-02-09 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/1612#discussion_r52388350 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/deployment/TaskDeploymentDescriptor.java --- @@ -141,9 +146,16 @@ public

[GitHub] flink pull request: FLINK-2523: Makes the task cancellation interv...

2016-02-09 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/1612#discussion_r52388830 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java --- @@ -102,60 +101,150

[GitHub] flink pull request: FLINK-2523: Makes the task cancellation interv...

2016-02-09 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/1612 FLINK-2523: Makes the task cancellation interval configurable. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kl0u/flink

[GitHub] flink pull request: FLINK-2213 Makes the number of vcores per YARN...

2016-02-06 Thread kl0u
Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/1588#issuecomment-180847040 Thanks a lot for the comments @rmetzger and @StephanEwen . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: FLINK-2213 Makes the number of vcores per YARN...

2016-02-06 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/1588#discussion_r52106077 --- Diff: docs/setup/config.md --- @@ -211,6 +211,8 @@ The parameters define the behavior of tasks that create result files. yarn.application

[GitHub] flink pull request: FLINK-2523: making the task cancellation inter...

2016-02-04 Thread kl0u
Github user kl0u closed the pull request at: https://github.com/apache/flink/pull/1546 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: FLINK-2213 Makes the number of vcores per YARN...

2016-02-04 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/1588 FLINK-2213 Makes the number of vcores per YARN container configurable. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kl0u/flink vcores_param

[GitHub] flink pull request: ExecutionConfig to JobGraph.

2016-02-03 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/1583 ExecutionConfig to JobGraph. This makes the ExecutionConfig available to the Task. In a nutshell, the ExecutionConfig is attached to the JobGraph which is sent to the JobManager. The JobManager

[GitHub] flink pull request: FLINK-2380: allow to specify the default files...

2016-02-02 Thread kl0u
Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/1524#issuecomment-178507931 Could you explain what more tests do you have in mind? So far I am testing 1) if the scheme provided in the configuration is used when one is not explicitly provided, 2

[GitHub] flink pull request: FLINK-3254: Adding functionality to support th...

2016-02-01 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/1568 FLINK-3254: Adding functionality to support the CombineFunction contract. Solves ISSUE-3254: now a function that implements the GroupReduceFunction and the CombineFunction interfaces will be executed

[GitHub] flink pull request: FLINK-3254: Adding functionality to support th...

2016-02-01 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/1568#discussion_r51427689 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/GroupReduceOperator.java --- @@ -156,8 +162,8 @@ public boolean isCombinable

[GitHub] flink pull request: FLINK-3198: Renames and documents the getDataS...

2016-01-26 Thread kl0u
Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/1548#issuecomment-174917008 Thanks a lot @fhueske ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: FLINK-2523: making the task cancellation inter...

2016-01-25 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/1546#discussion_r50694370 --- Diff: flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/wordcount/WordCount.java --- @@ -60,6 +60,7 @@ public static void

[GitHub] flink pull request: FLINK-3198: Renames and documents the getDataS...

2016-01-25 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/1548 FLINK-3198: Renames and documents the getDataSet() method in Grouping. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kl0u/flink groupBy_renaming

[GitHub] flink pull request: FLINK-2523: making the task cancellation inter...

2016-01-25 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/1546 FLINK-2523: making the task cancellation interval configurable. FLINK-2523: Makes the task cancellation interval configurable. You can merge this pull request into a Git repository by running

[GitHub] flink pull request: FLINK-2523: making the task cancellation inter...

2016-01-25 Thread kl0u
Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/1546#issuecomment-174548688 Hi @StephanEwen , Could you please elaborate more on how you think that the ExecutionConfig could be accessed differently by the Task? Thanks

[GitHub] flink pull request: FLINK-2380: allow to specify the default files...

2016-01-20 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/1524#discussion_r50253291 --- Diff: docs/setup/config.md --- @@ -52,6 +52,14 @@ The configuration files for the TaskManagers can be different, Flink does

[GitHub] flink pull request: FLINK-2380: allow to specify the default files...

2016-01-19 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/1524 FLINK-2380: allow to specify the default filesystem scheme in the flink configuration file. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kl0u

[GitHub] flink pull request: Create a deep-copy of the record when changing...

2015-10-06 Thread kl0u
Github user kl0u closed the pull request at: https://github.com/apache/flink/pull/1231 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: Create a deep-copy of the record when changing...

2015-10-06 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/1231 Create a deep-copy of the record when changing timestamps. This is too fix the problem of changing the timestamps in-place, versus creating a deep-copy and changing the timestamp in the new copy

[GitHub] flink pull request: Framesize fix

2015-09-01 Thread kl0u
Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/934#issuecomment-136782152 @mxm Sounds good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: Framesize fix

2015-09-01 Thread kl0u
Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/934#issuecomment-136775729 Thanks @mxm. Although I don't think I will have time to fix it right now. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: Framesize fix

2015-09-01 Thread kl0u
Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/934#issuecomment-136765583 Hi @mxm. What do you mean? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: Framesize fix

2015-09-01 Thread kl0u
Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/934#issuecomment-136771159 When I did the latest rebase it was saying that the two branches were ready to be merged. Is there a way to see where they have diverged? --- If your project is set

[GitHub] flink pull request: Framesize fix

2015-08-26 Thread kl0u
Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/934#issuecomment-135033380 Hello! I just rebased. Please have a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: Framesize fix

2015-08-14 Thread kl0u
Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/934#issuecomment-131208217 Just rebased with the new version of the master. Please have a look. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: Framesize fix

2015-08-14 Thread kl0u
Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/934#issuecomment-131209661 No problem! This message was just a reminder. Thanks a lot! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: Framesize fix

2015-07-29 Thread kl0u
Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/934#issuecomment-126076384 Hi @mxm , Thanks a lot for the comments! I integrated most of them. Please have a look and let me know what you think. For the merging

[GitHub] flink pull request: Collect(): Fixing the akka.framesize size limi...

2015-07-24 Thread kl0u
Github user kl0u closed the pull request at: https://github.com/apache/flink/pull/887 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: Framesize fix

2015-07-24 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/934 Framesize fix In Apache Flink the results of the collect() call were returned through akka to the client. This led to an inherent limitation to the size of the output of a job, as this could

[GitHub] flink pull request: Framesize fix

2015-07-24 Thread kl0u
Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/934#issuecomment-124500486 FLINK-2319 This pull request targets this ticket. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: Framesize fix

2015-07-24 Thread kl0u
Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/934#issuecomment-124500737 Hello guys, This is a new pull request, for a previous ticket. It is aligned with recent changes in the master branch. --- If your project is set up

[GitHub] flink pull request: Collect(): Fixing the akka.framesize size limi...

2015-07-22 Thread kl0u
Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/887#issuecomment-123752371 Hi @mxm. Thanks a lot! I don't have your email unfortunately. Could you somehow send it to me? --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request: Collect(): Fixing the akka.framesize size limi...

2015-07-22 Thread kl0u
Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/887#issuecomment-123756855 Thanks a lot! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: Collect(): Fixing the akka.framesize size limi...

2015-07-22 Thread kl0u
Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/887#issuecomment-123738197 Hello, The latest changes are pretty invasive and have a big overlap with the ones in my pull request. More specifically, the abstraction

[GitHub] flink pull request: Collect(): Fixing the akka.framesize size limi...

2015-07-07 Thread kl0u
Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/887#issuecomment-119140624 Ok, sounds good! Could you give the number of the ticket of the changes @mxm is doing? Just to have a look. --- If your project is set up for it, you can reply

[GitHub] flink pull request: Collect(): Fixing the akka.framesize size limi...

2015-07-05 Thread kl0u
Github user kl0u commented on the pull request: https://github.com/apache/flink/pull/887#issuecomment-118642591 Hello, I have integrated the changes you suggested, so now: 1) notes are no longer in the .gitignore 2) the collect example is not in the created jars

[GitHub] flink pull request: Collect(): Fixing the akka.framesize size limi...

2015-07-05 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/887 Collect(): Fixing the akka.framesize size limitation. In Apache Flink the results of the collect() call were returned through akka to the client. This led to an inherent limitation to the size

<    5   6   7   8   9   10