Github user kmurra commented on the issue:
https://github.com/apache/flink/pull/4746
The biggest change here is in the test cases -- I generalized the test
table source to have some basic filtering logic and allow for generic datasets.
I moved the Literal build logic
Github user kmurra commented on the issue:
https://github.com/apache/flink/pull/4746
Regarding the time zones, I think I understand your argument here. Is
there anything in particular that you would want me to change overall that you
haven't already outlined to account for that? I
Github user kmurra commented on a diff in the pull request:
https://github.com/apache/flink/pull/4746#discussion_r142801455
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/literals.scala
---
@@ -49,10 +50,51 @@ object Literal
Github user kmurra commented on a diff in the pull request:
https://github.com/apache/flink/pull/4746#discussion_r142801313
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/literals.scala
---
@@ -49,10 +50,51 @@ object Literal
Github user kmurra commented on a diff in the pull request:
https://github.com/apache/flink/pull/4746#discussion_r142800631
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/utils/TableTestBase.scala
---
@@ -200,10 +201,30 @@ case class
Github user kmurra commented on a diff in the pull request:
https://github.com/apache/flink/pull/4746#discussion_r142800611
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/utils/CheckExpressionsTableSource.scala
---
@@ -0,0 +1,65
Github user kmurra commented on a diff in the pull request:
https://github.com/apache/flink/pull/4746#discussion_r142800400
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/literals.scala
---
@@ -103,13 +148,21 @@ case class Literal(value
Github user kmurra commented on a diff in the pull request:
https://github.com/apache/flink/pull/4746#discussion_r142799362
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/literals.scala
---
@@ -49,10 +50,51 @@ object Literal
GitHub user kmurra opened a pull request:
https://github.com/apache/flink/pull/4746
[FLINK-7657] [Table] Adding logic to convert RexLiteral to expected SQL
Date/Time/Timestamp classes
## What is the purpose of the change
This change fixes handling of date, time
