GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/437
fixed package statement
package statement was not updated after class movement
also added a missing import
You can merge this pull request into a Git repository by running:
$ git pull https
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/573#discussion_r30117019
--- Diff:
flink-staging/flink-streaming/flink-storm-compatibility/src/main/java/org/apache/flink/stormcompatibility/api/FlinkClient.java
---
@@ -0,0 +1,321
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/573#discussion_r30116720
--- Diff:
flink-staging/flink-streaming/flink-storm-examples/src/main/java/org/apache/flink/stormcompatibility/wordcount/StormWordCountLocal.java
---
@@ -0,0
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/573#discussion_r30117273
--- Diff:
flink-staging/flink-streaming/flink-storm-compatibility/src/test/java/org/apache/flink/stormcompatibility/wrappers/StormWrapperSetupHelperTest.java
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/682
[Flink-1985] Streaming does not correctly forward ExecutionConfig to runtime
added ExecutionConfig serialization for streaming jobs
closes #1985
You can merge this pull request into a Git
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/682#issuecomment-103457498
Done.
Remove changes in ExecutionConfig. Adopted JUnit test. Rebased on current
master. Travis is green.
---
If your project is set up for it, you can reply
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/573#issuecomment-101301921
Hi, I addressed all your comments. The latest build was successful, too.
Please let me know if there is anything else to improve the pull request.
---
If your project
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/682#issuecomment-102780139
Changed LocalStreamEnvironment to TestStreamEnvironment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/682#discussion_r30469207
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java ---
@@ -543,6 +542,144 @@ public void disableAutoTypeRegistration
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/573#discussion_r28344339
--- Diff:
flink-staging/flink-streaming/flink-storm-compatibility/src/main/java/org/apache/flink/stormcompatibility/api/FlinkSubmitter.java
---
@@ -0,0 +1,258
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/573#discussion_r28517070
--- Diff:
flink-staging/flink-streaming/flink-storm-compatibility/src/main/java/org/apache/flink/stormcompatibility/api/FlinkClient.java
---
@@ -0,0 +1,362
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/573#discussion_r27822848
--- Diff:
flink-staging/flink-streaming/flink-storm-compatibility/src/main/java/org/apache/flink/stormcompatibility/wrappers/StormSpoutWrapper.java
---
@@ -0,0
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/573#discussion_r27822694
--- Diff:
flink-staging/flink-streaming/flink-storm-compatibility/src/main/java/org/apache/flink/stormcompatibility/api/FlinkOutputFieldsDeclarer.java
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/573#discussion_r27822552
--- Diff:
flink-staging/flink-streaming/flink-storm-compatibility/src/main/java/org/apache/flink/stormcompatibility/api/FlinkClient.java
---
@@ -0,0 +1,362
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/573#issuecomment-90209580
I fixed the rebase problem to remove the unnecessary commits. I also
squashed the commits you mentioned, removed author tags, and improved commit
messages.
---
If your
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/573
Flink Storm compatibility
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mjsax/flink flink-storm-compatibility
Alternatively you can review
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/573#discussion_r27811153
--- Diff:
flink-staging/flink-streaming/flink-storm-compatibility/src/main/java/org/apache/flink/stormcompatibility/wrappers/StormWrapperSetupHelper.java
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/573#discussion_r27810138
--- Diff:
flink-staging/flink-streaming/flink-storm-compatibility/src/main/java/org/apache/flink/stormcompatibility/api/FlinkClient.java
---
@@ -0,0 +1,362
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/573#discussion_r27810581
--- Diff:
flink-staging/flink-streaming/flink-storm-compatibility/src/main/java/org/apache/flink/stormcompatibility/api/FlinkTopology.java
---
@@ -0,0 +1,113
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/573#discussion_r27811027
--- Diff:
flink-staging/flink-streaming/flink-storm-compatibility/src/main/java/org/apache/flink/stormcompatibility/wrappers/StormTuple.java
---
@@ -0,0 +1,251
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/707#issuecomment-108990592
Done. I added it to this PR (corrected an error in docs/README.md, too).
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/707#issuecomment-108982112
Done. Sorry for the huge diff in JobSubmissionServlet: the line endings
have not been correct (in UNIX now). The actual changes are in lines 74(+),
120(+), 126(+), 132
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/707#issuecomment-108985448
One more issue: the documentation you pointed to says, that if no entry
class is provided in Manifest file, it can be specified via assembler
assemblerClass programArgs
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/707#issuecomment-108987358
Do I have access to the documentation? If yes, where can I find it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/796#issuecomment-110096269
No worries :) I am used to it. And I think it's good to ensure high code
quality!
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/796
[FLINK-2174] Allow comments in 'slaves' file
added skipping of #-comments in slaves file in start/stop scripts
You can merge this pull request into a Git repository by running:
$ git pull https
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/707#issuecomment-109447546
My Travis is green (https://travis-ci.org/mjsax/flink/builds/65609726).
From my point of view, this PR can be merged. Let me know if you request any
changes.
---
If your
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/796#issuecomment-109480303
My Travis is green (https://travis-ci.org/mjsax/flink/builds/65612778). Any
comments? Can be merged from my point of view.
---
If your project is set up for it, you can
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/796#issuecomment-109572648
Just realized, that it is better to put it into extractHostName function
within bin/config.sh.
---
If your project is set up for it, you can reply to this email and have
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/764#issuecomment-109940058
It should be possible to put your last commit on top, after the rebase is
done. I will do it in a new branch to preserve this one and cherry pick your
last commit
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/764#issuecomment-109936662
Hey, if the new API is stable I am happy to rebase and fix it up. I was
just thinking, that it might be the easiest way to got back to commit 2d200c0
or b06ec1b (both
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/796#issuecomment-110004370
See your point. But we need to come to a conclusion.
- I like my single line comment better (of course ;)) -- I thinks it's
easier to read than any regex -- and I
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/796#issuecomment-109997007
No. The variable $SLAVE in unchanged... The comment line is not removed (I
just drop the else here and print $SLAVE after the if-then):
mjsax@T420s-dbis-mjsax:~$ SLAVE
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/796#issuecomment-110005377
Ok. So I remove the first if-then and update this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/796#issuecomment-110001000
And I don't think it a compatibility problem. I think, '#' is no valid
characters for host names. Thus, nobody can have it in any slave file anyway.
---
If your project
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/796#issuecomment-109982446
This does not work on my system... and obviously not on other system
either. Otherwise, the feature would not have been requested.
---
If your project is set up
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/796#issuecomment-10868
I did not understand the purpose of the second if-then at all... But the
first does not remove comment lines. My introduces code works perfectly fine.
IMHO, it's cleaner
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/796#issuecomment-109992966
The regex matches everything up to the first character that is not
'0-9a-zA-Z/.-' Thus, any non matching character is uses as cut-off (e.g. blank,
tab, @, |, ...).
I
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/764#issuecomment-108292671
I thought this is a clean branch. I am working on this currently...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/707#issuecomment-108908174
Thanks for the feedback. I will fix it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/707#issuecomment-109033136
One of the five builds failed (Kafka test). I guess, it one of the randomly
failing once. The build is green in my own Travis:
https://travis-ci.org/mjsax/flink/builds
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/707#issuecomment-109036073
This makes sense. There is no read confusion. I just need to learn more
about git and the correct process. What is asf_flink ? Why not git fetch flink
git rebase flink
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/573#issuecomment-110540528
Hi, I rebased to the current master (and new streaming API) as discussed
and cleaned up everything. Unfortunately, I was not able to cherry-pick the
last commits
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/853#discussion_r32919318
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/singlejoin
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/764#issuecomment-114054802
Sure. Why not. Let's discuss tomorrow at the Meetup.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/853#discussion_r32925744
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/singlejoin
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/853#discussion_r32914310
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/wordcount
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/642#issuecomment-114043438
@rainiraj replied, that he is still on it (see
https://issues.apache.org/jira/browse/FLINK-1818)
---
If your project is set up for it, you can reply to this email
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/866
[FLINK-2275] Migrate test from package
'org.apache.flink.test.javaApiOperators'
migrated test from execute() to collect()
subtask of https://issues.apache.org/jira/browse/FLINK-2032
You can merge
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/866#issuecomment-115173704
I adapted all tests except for DataSinkITCase and
ExecutionEnvironmentITCase.
- DataSinkITCase - seems to test writing to file explicit; would not make
sense
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/764#issuecomment-113435843
Thanks. :) Cool that people are interested. Missing features are in the
pipeline already. Stay tuned ;)
---
If your project is set up for it, you can reply to this email
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-114123970
I agree that extending the state graph is critical. However, IMHO it is the
right way to go. I would rather spend more time on getting it right in the
first place, than
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/707#issuecomment-114409476
Travis failed in flink-tachyon (what happens regularly). My travis passed
https://travis-ci.org/mjsax/flink/builds/67863816
Should be ready to get merged.
---
If your
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/866#issuecomment-116060075
Done. Failing tests revile a Kafka problem (in my Travis, too
https://travis-ci.org/mjsax/flink/builds/68598571). Is it known? Module
flink-tests passed in all runs
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/573#issuecomment-112023822
Nice :)
Why did you turn off logging? I have some randomized tests and if they
fail, the test error cannot be reproduces without the seed value that goes to
the log
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/845
[FLINK-2232] StormWordCountLocalITCase fails
increased sleeping time for IT-Cases to make tests more stable
additional bug fix: isRunning was not volatile in AbstractStormSpoutWrapper
You can
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/845#issuecomment-112599473
IHMO, ready to be merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/707#issuecomment-111755732
Any news on this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/642#issuecomment-111755816
Any news on this PR? I thinks it is a nice feature? @rainiraj do you still
work on this?
---
If your project is set up for it, you can reply to this email and have your
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/573#issuecomment-111755768
Any news on this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/840
[FLINK-2120] Rename AbstractJobVertex to JobVertex
Renamed AbstractJobVertex to JobVertex
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mjsax
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/840#issuecomment-112232247
My build is green: https://travis-ci.org/mjsax/flink/builds/66925468
IMHO, ready to be merged. It's only a renaming thing.
---
If your project is set up for it, you
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/750
[FLINK-2111] Add terminate signal to cleanly stop streaming jobs
added TERMINATE signal
- JobManager, TaskManager, ExecutionGraph
- CliFrontend, JobManagerFrontend
- StreamTask
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-107926235
Hi,
after thinking about the signal name again, I disagree. terminate does
not mean kill, but is a request to gracefully shut down. stop from my point
of view is too
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/875#issuecomment-117549613
There is no JIRA, but I can of course open one (it the policy to open a
JIRA for each new feature?). I can also add documentation. But this should be
done in a different
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/878
[FLINK-2304] Add named attribute access to Storm compatibility layer
- extended FlinkTuple to enable named attribute access
- extended BoltWrapper for user defined input schema
- extended
Github user mjsax closed the pull request at:
https://github.com/apache/flink/pull/875
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/875#issuecomment-117649187
Close and re-open in new branch to link to JIRA.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/879#discussion_r33868446
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/runtime/streamrecord/StreamRecord.java
---
@@ -17,87
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/879#discussion_r33864108
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/runtime/streamrecord/StreamRecord.java
---
@@ -17,87
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/879#discussion_r33864125
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/runtime/streamrecord/StreamRecord.java
---
@@ -17,87
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/878#issuecomment-118356433
Ok. So this PR in put on hold and #884 can be merged right way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/879#discussion_r33865507
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/runtime/streamrecord/StreamRecord.java
---
@@ -17,87
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/879#discussion_r33864243
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/runtime/streamrecord/StreamRecord.java
---
@@ -17,87
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/880#issuecomment-118020199
From my understanding, provided would mean that a project that uses stuff
from flink-contrib would not need to include the code from flink-contrib into
the own program jar
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/880#issuecomment-118047809
I see. But changing the scope to provided is the wrong way to go. You
need to exclude unnecessary sub-module dependencies:
```
dependency
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/879#discussion_r33874602
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/runtime/streamrecord/StreamRecord.java
---
@@ -17,87
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/880#issuecomment-118074166
The PR from @tammymendt is outdated. The `flink-contrib` is packaging to
jar (not pom) in this old version.
---
If your project is set up for it, you can reply
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/866#issuecomment-116165324
Done. If Travis is green, please merge. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/884
[FLINK-2305] Add documenation about Storm compatibility layer
additional improvements
- added RawOutputFormatter
- bug fix in SimpleOutputFormatter
- enable default output formatter
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/878#issuecomment-118286784
FYI: this PR is related to #884 - if #884 is merged before, this PR
needs an update.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/884#issuecomment-118287253
FYI: this PR is related to #878 - if #878 is merged before, this PR needs
an update.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user mjsax commented on the pull request:
https://github.com/apache/flink/commit/35d7b5be823e3c4578b8d51f8d03f53018fb1066#commitcomment-11303380
In flink-clients/src/main/java/org/apache/flink/client/web/JobsServlet.java:
In flink-clients/src/main/java/org/apache/flink
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/707
[FLINK-2068] WebUI support multiple jobs per jar file
- program-class can contain multiple comma seperated entry classes
- WebClient shows checkbox for each entry class and can display plan
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/682#issuecomment-104231736
Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/974#issuecomment-127283992
Failing test is unrelated. This should be ready for merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/983#issuecomment-130323723
I did the following changes:
- added Tuple0 to `TupleGenerator.modifyTupleType()`
- changes `LinkedList` to `ArrayList` in TupleGenerator to create code
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/1011
[FLINK-2306] Add support for named streams in Storm compatibility layer
- enabled .declareStream() and connect via stream name
- enabled multiplt output streams
- added .split
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-131800322
Failing KafkaConnector test. This in unrelated. Failing run is green on
personal Travis ((https://travis-ci.org/mjsax/flink/builds/75910791).
---
If your project is set
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1037#discussion_r37640464
--- Diff: docs/apis/storm_compatibility.md ---
@@ -224,4 +224,12 @@ DataStreamString rawInput = env.addSource(
You can find more examples in Maven
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1037#issuecomment-133477238
I got it now. Can be merged from my point of view.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/1041
[FLINK-2560] Flink-Avro Plugin cannot be handled by Eclipse
- disabled avro-maven-plugin within Eclipse via pluginManagement ...
lifecyleMappingMetaData
You can merge this pull request into a Git
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1037#discussion_r37687901
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/wordcount
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r37746515
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/api/FlinkLocalCluster.java
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r37745589
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/wrappers
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1046#issuecomment-134190885
It fails in two test. You should actually see it, if you execute test
locally. You should run test each time before you open/update an PR (at least
for the module you did
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r37745701
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/api/FlinkLocalCluster.java
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r37746137
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/api/FlinkLocalCluster.java
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1011#issuecomment-131623875
Fixed. This should be ready to get merged. Please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-131633170
I just rebased to current master. What is the status of this PR? Can it get
merged (from my point of view, yes)?
---
If your project is set up for it, you can reply
1 - 100 of 694 matches
Mail list logo
