[GitHub] flink pull request: Merge pull request #1 from apache/master

2015-05-27 Thread pp86
Github user pp86 closed the pull request at: https://github.com/apache/flink/pull/737 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: Merge pull request #1 from apache/master

2015-05-27 Thread pp86
Github user pp86 closed the pull request at: https://github.com/apache/flink/pull/737 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: Merge pull request #1 from apache/master

2015-05-27 Thread pp86
GitHub user pp86 reopened a pull request: https://github.com/apache/flink/pull/737 Merge pull request #1 from apache/master test update You can merge this pull request into a Git repository by running: $ git pull https://github.com/pp86/flink master Alternatively you can

[GitHub] flink pull request: Merge pull request #1 from apache/master

2015-05-27 Thread pp86
GitHub user pp86 opened a pull request: https://github.com/apache/flink/pull/737 Merge pull request #1 from apache/master test update You can merge this pull request into a Git repository by running: $ git pull https://github.com/pp86/flink master Alternatively you can review

[GitHub] flink pull request: [FLINK-2043] Change the KMeansDataGenerator to...

2015-05-24 Thread pp86
GitHub user pp86 opened a pull request: https://github.com/apache/flink/pull/721 [FLINK-2043] Change the KMeansDataGenerator to allow passing a custom path https://issues.apache.org/jira/browse/FLINK-2043 You can merge this pull request into a Git repository by running: $ git

[GitHub] flink pull request: [FLINK-1963] Improve distinct() transformation

2015-07-13 Thread pp86
GitHub user pp86 opened a pull request: https://github.com/apache/flink/pull/905 [FLINK-1963] Improve distinct() transformation - add the possibility to use distinct() on Atomic data types - add the possibility to use distinct(_)/distinct(*) on Atomic data types You can

[GitHub] flink pull request: [FLINK-1963] Improve distinct() transformation

2015-07-13 Thread pp86
Github user pp86 commented on the pull request: https://github.com/apache/flink/pull/905#issuecomment-120922481 Dear Chiwan, thanks for you suggestions. I'll integrate them and open a new pull request. --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request: [FLINK-1963] Improve distinct() transformation

2015-07-13 Thread pp86
Github user pp86 closed the pull request at: https://github.com/apache/flink/pull/905 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-1963] Improve distinct() transformation

2015-07-14 Thread pp86
Github user pp86 commented on the pull request: https://github.com/apache/flink/pull/905#issuecomment-121192327 hello @chiwanpark! what do you think about the tests? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: [FLINK-1963] Improve distinct() transformation

2015-07-14 Thread pp86
Github user pp86 commented on the pull request: https://github.com/apache/flink/pull/905#issuecomment-121187436 sure thing! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-1963] Improve distinct() transformation

2015-07-14 Thread pp86
Github user pp86 commented on the pull request: https://github.com/apache/flink/pull/905#issuecomment-121406113 Hi guys, I added some tests. I also added a test on a generic data type which does not implement Comparable. --- If your project is set up for it, you can

[GitHub] flink pull request: [FLINK-1963] Improve distinct() transformation

2015-07-15 Thread pp86
Github user pp86 commented on the pull request: https://github.com/apache/flink/pull/905#issuecomment-121739943 Dear @fhueske , I hope I satisfied your requests! Let me know if some other changes are needed. As you suggested I took the issue on documentation

[GitHub] flink pull request: [FLINK-1963] Improve distinct() transformation

2015-07-16 Thread pp86
Github user pp86 commented on the pull request: https://github.com/apache/flink/pull/905#issuecomment-122118573 Hi @fhueske , I'm very sorry, this is the first time I work with github, I am doing some mess :| But, I think I finally succeeded in removing the unwanted

[GitHub] flink pull request: [FLINK-2362] - distinct is missing in DataSet ...

2015-07-19 Thread pp86
GitHub user pp86 opened a pull request: https://github.com/apache/flink/pull/922 [FLINK-2362] - distinct is missing in DataSet API documentation add scala and java documentation for the distinct transformation. You can merge this pull request into a Git repository by running

[GitHub] flink pull request: [FLINK-2312][ml][WIP] Randomly Splitting a Dat...

2015-07-19 Thread pp86
Github user pp86 commented on the pull request: https://github.com/apache/flink/pull/921#issuecomment-122709103 Hi @sachingoel0101 , wouldn't it be better to implement the method for a generic DataSet rather than a DataSet of LabeledVector? --- If your project is set up

[GitHub] flink pull request: [FLINK-2362] - distinct is missing in DataSet ...

2015-07-20 Thread pp86
Github user pp86 commented on the pull request: https://github.com/apache/flink/pull/922#issuecomment-122815918 Thanks for the suggestion @mxm , I updated the documentation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well