Github user tedyu commented on the pull request:
https://github.com/apache/flink/pull/928#issuecomment-126021923
Anything I can do to move this forward ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user tedyu commented on the pull request:
https://github.com/apache/flink/pull/928#issuecomment-127074789
I looked at https://travis-ci.org/apache/flink/jobs/73803261 but couldn't
figure out which test failed.
---
If your project is set up for it, you can reply to this email
Github user tedyu commented on the pull request:
https://github.com/apache/flink/pull/928#issuecomment-125010977
I used the following command:
mvn clean package -DskipTests eclipse:eclipse
However, under flink-java, I only found one .classpath file:
/Users/tyu/flink
Github user tedyu commented on the pull request:
https://github.com/apache/flink/pull/928#issuecomment-123689320
I did use tabs. I have the following in .vimrc:
set tabstop=2numbers of spaces of tab character
---
If your project is set up for it, you can reply
GitHub user tedyu opened a pull request:
https://github.com/apache/flink/pull/1282
FLINK-2866 Potential resource leak due to unclosed ObjectInputStream in
FileSerializableStateHandle
Use try-with-resources to close FSDataInputStream
You can merge this pull request into a Git
GitHub user tedyu opened a pull request:
https://github.com/apache/flink/pull/1339
FLINK-2826 transformed is modified in BroadcastVariableMaterializatioâ¦
â¦n#decrementReferenceInternal without proper locking
You can merge this pull request into a Git repository by running
GitHub user tedyu opened a pull request:
https://github.com/apache/flink/pull/1353
[FLINK-2913] Close of ObjectOutputStream should be enclosed in finallâ¦
â¦y block in FsStateBackend
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user tedyu opened a pull request:
https://github.com/apache/flink/pull/1089
FLINK-2605 Unclosed RandomAccessFile may leak resource in StaticFileSâ¦
â¦erverHandler
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tedyu
Github user tedyu commented on the pull request:
https://github.com/apache/flink/pull/1089#issuecomment-137772269
Your reasoning w.r.t. current scope of try block was the same as mine.
I think it is good to make the scope as accurate as possible. Generally
speaking, we don't
GitHub user tedyu opened a pull request:
https://github.com/apache/flink/pull/1137
FLINK-2595 Unclosed JarFile may leak resource in ClassLoaderUtilsTest
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tedyu/flink master
Github user tedyu closed the pull request at:
https://github.com/apache/flink/pull/1474
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user tedyu opened a pull request:
https://github.com/apache/flink/pull/1474
FLINK-3103 Remove synchronization in
FsStateBackend#FsCheckpointStateOutputStream#close()
Stephan made the following comment:
I would actually suggest to not use a lock in the close
GitHub user tedyu opened a pull request:
https://github.com/apache/flink/pull/1381
FLINK-3005 Commons-collections object deserialization remote command â¦
â¦execution vulnerability
You can merge this pull request into a Git repository by running:
$ git pull https
Github user tedyu closed the pull request at:
https://github.com/apache/flink/pull/1560
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user tedyu opened a pull request:
https://github.com/apache/flink/pull/1560
FLINK-3301 Ineffective synchronization in
MessageAcknowledgingSourceBase#restoreState
This PR changes synchronization on pendingCheckpoints to this
(MessageAcknowledgingSourceBase)
You can merge
GitHub user tedyu opened a pull request:
https://github.com/apache/flink/pull/3235
FLINK-5517 Upgrade hbase version to 1.3.0
In the thread 'Help using HBase with Flink 1.1.4', Giuliano reported seeing:
```
java.lang.IllegalAccessError: tried to access method
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/2421
The test failure in flink-mesos is unrelated to the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user tedyu opened a pull request:
https://github.com/apache/flink/pull/2421
FLINK-4482 numUnsuccessfulCheckpointsTriggers is accessed without holding
triggerLock
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list
Github user tedyu closed the pull request at:
https://github.com/apache/flink/pull/2409
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user tedyu opened a pull request:
https://github.com/apache/flink/pull/2409
FLINK-4437 Lock evasion around lastTriggeredCheckpoint may lead to lost
updates to related fields
Thanks for contributing to Apache Flink. Before you open your pull request,
please take
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/flink/pull/2402#discussion_r75874655
--- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java ---
@@ -164,6 +164,7 @@ public static void setTokensFor(ContainerLaunchContext
amContainer
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/2409
What's the command line for running EventTimeWindowCheckpointingITCase
alone ?
I tried 'mvn test -Dtest=EventTimeWindowCheckpointingITCase' which didn't
work.
Thanks
---
If your
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/2409
```
Executing Maven: -B -f
/home/jenkins/jenkins-slave/workspace/flink-github-ci/pom.xml
-Dmaven.repo.local=/home/jenkins/jenkins-slave/maven-repositories/1 clean
install -Dflink.forkCount=1C
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/2409
I ran test suite which patch which failed here:
```
Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 201.106 sec
<<<
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/2409
Pardon.
See if the current formation is the same as your reproduction.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/2824
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user tedyu opened a pull request:
https://github.com/apache/flink/pull/3608
FLINK-6169 yarnClient should be stopped in AbstractYarnClusterDescriptor in
case of error
Stop yarnClient before throwing exception
You can merge this pull request into a Git repository by running
Github user tedyu closed the pull request at:
https://github.com/apache/flink/pull/3608
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/3677
lgtm
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/flink/pull/3541#discussion_r112071560
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/SubEvent.java ---
@@ -31,6 +31,18 @@ public double getVolume
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/flink/pull/3541#discussion_r112071274
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/AbstractKeyedCEPPatternOperator.java
---
@@ -385,4 +393,25 @@ public int
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4328#discussion_r130235370
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/RegisteredOperatorBackendStateMetaInfo.java
---
@@ -175,14 +175,21 @@ public boolean
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/4315
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4345#discussion_r127532176
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/asm/translate/TranslateGraphIds.java
---
@@ -56,7 +56,9 @@ public
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/4345
Fine by me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/4356
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4260#discussion_r127075409
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
---
@@ -0,0 +1,290 @@
+/*
+ * Licensed to the Apache
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/4202
Can you take a look at the error in CI ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4404#discussion_r131511583
--- Diff: docs/dev/table/sql.md ---
@@ -497,6 +497,23 @@ FROM (
{% endhighlight
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4404#discussion_r131823213
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/subquery.scala
---
@@ -0,0 +1,95 @@
+/*
+ * Licensed
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/4404
@fhueske
Can you take a look at #4493 ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4404#discussion_r131726341
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/subquery.scala
---
@@ -0,0 +1,95 @@
+/*
+ * Licensed
GitHub user tedyu opened a pull request:
https://github.com/apache/flink/pull/4493
[FLINK-4565] [table] Support for SQL IN operator - move case of equal check
*Thank you very much for contributing to Apache Flink - we are happy that
you want to help us improve Flink. To help
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4404#discussion_r131654308
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/subquery.scala
---
@@ -0,0 +1,95 @@
+/*
+ * Licensed
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4404#discussion_r131519235
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/subquery.scala
---
@@ -0,0 +1,95 @@
+/*
+ * Licensed
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/4356
Run QA again ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4410#discussion_r134647310
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
---
@@ -1044,10 +1049,23 @@ public boolean
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4238#discussion_r134142624
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobCache.java ---
@@ -108,11 +139,63 @@ public BlobCache
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4238#discussion_r134142721
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobCache.java ---
@@ -108,11 +139,63 @@ public BlobCache
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4320#discussion_r134687041
--- Diff: docs/dev/libs/cep.md ---
@@ -1279,63 +1279,75 @@ and `flatSelect` API calls allow a timeout handler
to be specified. This timeout
partial event
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4320#discussion_r134689181
--- Diff:
flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/PatternStream.scala
---
@@ -84,37 +79,54 @@ class PatternStream[T
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4320#discussion_r134692032
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/AbstractKeyedCEPPatternOperator.java
---
@@ -348,7 +353,18 @@ private void
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4320#discussion_r134692117
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/AbstractKeyedCEPPatternOperator.java
---
@@ -348,7 +353,18 @@ private void
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/4482
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4562#discussion_r133980441
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -220,6 +220,10 @@ void releaseBuffer
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/flink/pull/3919#discussion_r117121382
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamGroupWindowAggregate.scala
---
@@ -245,6 +264,7
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/flink/pull/3919#discussion_r117122323
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamGroupWindowAggregate.scala
---
@@ -131,6 +135,19
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/3938
Lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/3892
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/flink/pull/3885#discussion_r116611287
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraph.java
---
@@ -318,9 +318,10 @@ public void
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/2422
Hadoop has switched to spotbugs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/4151
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/4140
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/flink/pull/3981#discussion_r118304278
--- Diff:
flink-yarn/src/main/scala/org/apache/flink/yarn/YarnJobManager.scala ---
@@ -89,5 +92,37 @@ class YarnJobManager
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/3957
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4039#discussion_r122570865
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractionUtils.java
---
@@ -161,6 +164,77 @@ public static LambdaExecutable
Github user tedyu closed the pull request at:
https://github.com/apache/flink/pull/3839
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/3839
@StefanRRichter
Can you take a look ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user tedyu opened a pull request:
https://github.com/apache/flink/pull/3839
FLINK-6474 Potential loss of precision in 32 bit integer multiplication
Cast numNetworkBuffers to long before multiplication.
You can merge this pull request into a Git repository by running
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/3837
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/flink/pull/3825#discussion_r114923660
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/conditions/AndCondition.java
---
@@ -32,8 +34,8 @@
private final
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/4356
retest this please
---
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/4568
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4296#discussion_r135366122
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
---
@@ -421,6 +437,15 @@ private void
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4296#discussion_r135366609
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
---
@@ -526,18 +551,32 @@ private boolean
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4296#discussion_r135367240
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
---
@@ -526,18 +551,32 @@ private boolean
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/4570
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/4562
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/4621
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/4316
I think InterruptedException should be handled uniformly in
HadoopInputFormatBase.java
---
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/5920
lgtm
---
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/flink/pull/5991#discussion_r187647275
--- Diff:
flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer08.java
---
@@ -221,7 +221,8
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/flink/pull/5991#discussion_r187648458
--- Diff:
flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/flink/pull/5991#discussion_r187647828
--- Diff:
flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java
---
@@ -80,6
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/flink/pull/6040#discussion_r189036753
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcher.java
---
@@ -507,7
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/5892
lgtm
---
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/5205
+1 on @StephanEwen's suggestion.
---
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/flink/pull/6181#discussion_r196368052
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/partitioner/FlinkKeyHashPartitioner.java
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/6378
No particular reason - considering the date when JIRA was first logged :-)
---
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/6365
That would be ideal - a new connector for hbase 2.x considering that:
hbase 1.x is stable
hbase 2.y is newly released.
---
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/6378
lgtm
Pending QA bot
---
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/6335
lgtm
---
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/6335
From https://travis-ci.org/apache/flink/jobs/404127448 :
```
Failed tests:
BlobServerPutTest.testPutBufferFailsIncomingForJob
Expected: (an instance of java.io.IOException
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/5205
Looks like the PR needs to be rebased.
---
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/5777
@yuqi1129
What do you think ?
---
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/5848
lgtm
---
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/5488
Should be good after 1.4.1 is filled in
---
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/5894
lgtm
Please check test failure.
---
98 matches
Mail list logo
