Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2194#discussion_r69735446
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/savepoint/SavepointStore.java
---
@@ -0,0 +1,71 @@
+/*
+ * Licensed
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2194#discussion_r69728549
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/savepoint/FsSavepointStoreTest.java
---
@@ -0,0 +1,308 @@
+/*
+ * Licensed
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2194#discussion_r69728577
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/savepoint/FsSavepointStoreTest.java
---
@@ -0,0 +1,308 @@
+/*
+ * Licensed
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2194#discussion_r69728416
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/savepoint/SavepointV0Serializer.java
---
@@ -0,0 +1,58 @@
+/*
+ * Licensed
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2194#discussion_r69728188
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/savepoint/SavepointStore.java
---
@@ -0,0 +1,71 @@
+/*
+ * Licensed
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2194#discussion_r69728283
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/savepoint/SavepointV0Serializer.java
---
@@ -0,0 +1,58 @@
+/*
+ * Licensed
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2194#discussion_r69727662
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/savepoint/FsSavepointStore.java
---
@@ -0,0 +1,225 @@
+/*
+ * Licensed
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2194#discussion_r69725285
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/savepoint/FsSavepointStore.java
---
@@ -0,0 +1,225 @@
+/*
+ * Licensed
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2194#discussion_r69723923
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/savepoint/FsSavepointStore.java
---
@@ -0,0 +1,225 @@
+/*
+ * Licensed
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2194#discussion_r69723989
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/savepoint/FsSavepointStore.java
---
@@ -0,0 +1,225 @@
+/*
+ * Licensed
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2194#discussion_r69723478
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StandaloneCheckpointRecoveryFactory.java
---
@@ -37,10 +37,10 @@ public void stop
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2194#discussion_r69723425
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpoint.java
---
@@ -109,13 +109,13 @@ public boolean isDiscarded
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2194#discussion_r69723013
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointRecoveryFactory.java
---
@@ -41,13 +41,13 @@
void stop
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2194#discussion_r69722894
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/Checkpoint.java
---
@@ -0,0 +1,135 @@
+/*
+ * Licensed to the Apache Software
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2194
@greghogan You fixed the murmur hash in the mentioned commit. Do you think
it's OK to revert back to the wrong version we had before? Did you actually
observe bad behaviour of the wrong murmur hash
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2083
I've addressed the comments:
- Moved the JAR uploading to a helper:
```java
// Retrieve blob server address and upload JARs to server
uploadJarFiles(ActorGateway, FiniteDuration
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2195
Makes sense :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2195
Sorry for not responding earlier in the JIRA issue. I've somehow missed
your mentions. I agree with what Stephan said in JIRA. Before trying to fix
something here, we would have to think about
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2194
Thanks for the thorough review! I didn't catch that by my manual test. I
would also be in favour of 1) for the same reasons.
---
If your project is set up for it, you can reply to this email and have
Github user uce closed the pull request at:
https://github.com/apache/flink/pull/2193
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2193
I'm closing this after an offline chat with @zentol who will fix this
properly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2123
This problem sounds like it might cause very hard to debug problems.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2135
In which cases do the collisions occur?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2153
+1 to what Till and Jamie said.
Regarding the removed joda-time exclusion: that's independent of the
testing skeleton, right?
---
If your project is set up for it, you can reply to this email
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/2194
[FLINK-4067] [runtime] Add savepoint headers
Savepoints were previously persisted without any meta data using default
Java serialization of a `CompletedCheckpoint`. This PR introduces a savepoint
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/2193
[FLINK-4145] [core] Configure port range for JMXReporterTest
I saw multiple failures of the JmxReporterTest most likely due to a port
conflicts. The test relies on the default JMX reporter port range
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2154
Thanks! +1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2185
Changes look good. Test failures are most likely unrelated. Feel free to
merge. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2158
Good job Chesnay! Reads very well. I like the way the text and code
examples are mixed. I had some minor inline comments.
My biggest concern (not reflected in the inline comments) is the `Scope
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2158#discussion_r69166838
--- Diff: docs/apis/common/index.md ---
@@ -1350,3 +1350,397 @@ You may specify program arguments before the job is
executed. The plan visualiza
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2158#discussion_r69166767
--- Diff: docs/apis/common/index.md ---
@@ -1350,3 +1350,397 @@ You may specify program arguments before the job is
executed. The plan visualiza
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2158#discussion_r69166536
--- Diff: docs/apis/common/index.md ---
@@ -1350,3 +1350,397 @@ You may specify program arguments before the job is
executed. The plan visualiza
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2158#discussion_r69166443
--- Diff: docs/apis/common/index.md ---
@@ -1350,3 +1350,397 @@ You may specify program arguments before the job is
executed. The plan visualiza
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2158#discussion_r69166266
--- Diff: docs/apis/common/index.md ---
@@ -1350,3 +1350,397 @@ You may specify program arguments before the job is
executed. The plan visualiza
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2158#discussion_r69165992
--- Diff: docs/apis/common/index.md ---
@@ -1350,3 +1350,397 @@ You may specify program arguments before the job is
executed. The plan visualiza
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2158#discussion_r69165872
--- Diff: docs/apis/common/index.md ---
@@ -1350,3 +1350,397 @@ You may specify program arguments before the job is
executed. The plan visualiza
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2158#discussion_r69165738
--- Diff: docs/apis/common/index.md ---
@@ -1350,3 +1350,397 @@ You may specify program arguments before the job is
executed. The plan visualiza
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2158#discussion_r69165618
--- Diff: docs/apis/common/index.md ---
@@ -1350,3 +1350,397 @@ You may specify program arguments before the job is
executed. The plan visualiza
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2158#discussion_r69163034
--- Diff: docs/apis/common/index.md ---
@@ -1350,3 +1350,397 @@ You may specify program arguments before the job is
executed. The plan visualiza
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2158#discussion_r69163863
--- Diff: docs/apis/common/index.md ---
@@ -1350,3 +1350,397 @@ You may specify program arguments before the job is
executed. The plan visualiza
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2158#discussion_r69163770
--- Diff: docs/apis/common/index.md ---
@@ -1350,3 +1350,397 @@ You may specify program arguments before the job is
executed. The plan visualiza
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2158#discussion_r69163472
--- Diff: docs/apis/common/index.md ---
@@ -1350,3 +1350,397 @@ You may specify program arguments before the job is
executed. The plan visualiza
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2158#discussion_r69163196
--- Diff: docs/apis/common/index.md ---
@@ -1350,3 +1350,397 @@ You may specify program arguments before the job is
executed. The plan visualiza
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2158#discussion_r69162949
--- Diff: docs/apis/common/index.md ---
@@ -1350,3 +1350,397 @@ You may specify program arguments before the job is
executed. The plan visualiza
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2158#discussion_r69162793
--- Diff: docs/apis/common/index.md ---
@@ -1350,3 +1350,397 @@ You may specify program arguments before the job is
executed. The plan visualiza
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2158#discussion_r69162546
--- Diff: docs/apis/common/index.md ---
@@ -1350,3 +1350,397 @@ You may specify program arguments before the job is
executed. The plan visualiza
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2158#discussion_r69162434
--- Diff: docs/apis/common/index.md ---
@@ -1350,3 +1350,397 @@ You may specify program arguments before the job is
executed. The plan visualiza
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2158#discussion_r69162378
--- Diff: docs/apis/common/index.md ---
@@ -1350,3 +1350,397 @@ You may specify program arguments before the job is
executed. The plan visualiza
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2158#discussion_r69162153
--- Diff: docs/apis/common/index.md ---
@@ -1350,3 +1350,397 @@ You may specify program arguments before the job is
executed. The plan visualiza
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2158#discussion_r69161650
--- Diff: docs/apis/common/index.md ---
@@ -1350,3 +1350,397 @@ You may specify program arguments before the job is
executed. The plan visualiza
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2158#discussion_r69160791
--- Diff: docs/apis/common/index.md ---
@@ -1350,3 +1350,211 @@ You may specify program arguments before the job is
executed. The plan visualiza
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2154
Great work, Aljoscha. The figures are awesome. I had some minor comments
inline.
For the lateness section, should we add some notes about that the late
element will trigger a window
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2154#discussion_r69159773
--- Diff: docs/apis/streaming/windows.md ---
@@ -24,1023 +24,608 @@ specific language governing permissions and
limitations
under the License
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2154#discussion_r69159608
--- Diff: docs/apis/streaming/windows.md ---
@@ -24,1023 +24,608 @@ specific language governing permissions and
limitations
under the License
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2154#discussion_r69159118
--- Diff: docs/apis/streaming/windows.md ---
@@ -24,1023 +24,608 @@ specific language governing permissions and
limitations
under the License
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2154#discussion_r69158879
--- Diff: docs/apis/streaming/windows.md ---
@@ -24,1023 +24,608 @@ specific language governing permissions and
limitations
under the License
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2154#discussion_r69158778
--- Diff: docs/apis/streaming/windows.md ---
@@ -24,1023 +24,608 @@ specific language governing permissions and
limitations
under the License
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2154#discussion_r69158646
--- Diff: docs/apis/streaming/windows.md ---
@@ -24,1023 +24,608 @@ specific language governing permissions and
limitations
under the License
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2154#discussion_r69158483
--- Diff: docs/apis/streaming/windows.md ---
@@ -24,1023 +24,608 @@ specific language governing permissions and
limitations
under the License
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2154#discussion_r69157901
--- Diff: docs/apis/streaming/windows.md ---
@@ -24,1023 +24,608 @@ specific language governing permissions and
limitations
under the License
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2154#discussion_r69157149
--- Diff: docs/apis/streaming/windows.md ---
@@ -24,1023 +24,608 @@ specific language governing permissions and
limitations
under the License
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2154#discussion_r69157148
--- Diff: docs/apis/streaming/windows.md ---
@@ -24,1023 +24,608 @@ specific language governing permissions and
limitations
under the License
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2154#discussion_r69152891
--- Diff: docs/apis/streaming/windows.md ---
@@ -24,1023 +24,608 @@ specific language governing permissions and
limitations
under the License
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2154#discussion_r69154010
--- Diff: docs/apis/streaming/windows.md ---
@@ -24,1023 +24,608 @@ specific language governing permissions and
limitations
under the License
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2154#discussion_r69152634
--- Diff: docs/apis/streaming/windows.md ---
@@ -24,1023 +24,608 @@ specific language governing permissions and
limitations
under the License
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2154#discussion_r69152469
--- Diff: docs/apis/streaming/windows.md ---
@@ -24,1023 +24,608 @@ specific language governing permissions and
limitations
under the License
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2154#discussion_r69152314
--- Diff: docs/apis/streaming/windows.md ---
@@ -24,1023 +24,608 @@ specific language governing permissions and
limitations
under the License
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2154#discussion_r69151712
--- Diff: docs/apis/streaming/windows.md ---
@@ -24,1023 +24,608 @@ specific language governing permissions and
limitations
under the License
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2154#discussion_r69151295
--- Diff: docs/apis/streaming/windows.md ---
@@ -24,1023 +24,608 @@ specific language governing permissions and
limitations
under the License
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2154#discussion_r69151195
--- Diff: docs/apis/streaming/windows.md ---
@@ -24,1023 +24,608 @@ specific language governing permissions and
limitations
under the License
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2177#discussion_r68904419
--- Diff: docs/setup/config.md ---
@@ -85,6 +85,8 @@ The default fraction for managed memory can be adjusted
using the `taskmanager.m
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2083
Thanks for review. I will propagate the errors, make the job ID/JAR
arguments optional, and try to simplify parts of the CLI as you suggested.
Regarding including the RocksDB jar in dist, I
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2083#discussion_r68590084
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -790,39 +767,95 @@ else if (result instanceof TriggerSavepointFailure
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2083#discussion_r68588080
--- Diff: docs/apis/cli.md ---
@@ -279,13 +289,27 @@ guarantees for a stop request.
Action "savepoint" triggers savepoints for a r
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2083#discussion_r68588625
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -790,39 +767,95 @@ else if (result instanceof TriggerSavepointFailure
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2083#discussion_r68587921
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java
---
@@ -305,6 +307,11 @@ public static void printHelpForSavepoint
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2095
Agreed. I had the same thought regarding checking for any final state right
after posting this. ;) +1 to merge.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2069
Test failure is unrelated, going to merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2143
Test failure is unrelated, I'm going to merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2096
PS As another follow up we can probably get rid of some of the
`JobManagerProcess` tests, which tried -- in a way -- to work around the
missing suspended state. Your approach
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2096
Really good changes and great that you added the `JobStatus` graph
transitions figure to the docs.
I looked at all changes and tests. Furthermore, I've tested this with lost
ZooKeeper
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2096#discussion_r68077449
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
---
@@ -1029,21 +1061,25 @@ else if (current
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2096#discussion_r68046896
--- Diff: flink-runtime/src/test/resources/log4j-test.properties ---
@@ -16,7 +16,7 @@
# limitations under the License
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2095
PS: Should the early abort check for the `CANCELED` state in
`ExecutionGraph.restart()` be extended to any terminal state? The `restart`
method assumes that it's the only one transitioning away from
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2096#discussion_r68039992
--- Diff: docs/internals/job_scheduling.md ---
@@ -74,7 +74,28 @@ Besides the vertices, the ExecutionGraph also contains
the {% gh_link /flink-run
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2096#discussion_r68039809
--- Diff: docs/internals/job_scheduling.md ---
@@ -74,7 +74,28 @@ Besides the vertices, the ExecutionGraph also contains
the {% gh_link /flink-run
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2095
+1 to merge. Both the direct state transition and test are good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2069
Thanks for the suggestion Fabian. I've added the table to the docs and
added an example about the Kafka JSON source. Furthermore, I've added the
configuration flag for the missing field failure
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/2143
[FLINK-4040] [dist] Allow JobManager/TaskManager-specific JVM args
- Adds two new config keys for the start up scripts:
* `env.java.opts.jobmanager`
* `env.java.opts.taskmanager
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2113
Thanks! Looks good to merge. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2141
Thank you for this PR. I will try to look into it next week. I think we
should wait for the 1.1 release before we merge this though.
---
If your project is set up for it, you can reply to this email
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2113
Changes look good, but did you skip the `CombiningUnilateralSortMerger` on
purpose?
It's hard to tell, because the `handleLargeRecords` argument was existing
before your changes
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2116
Looks very good! Thanks. The build failure is unrelated. I'll merge this
after you address the inline comments.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2116#discussion_r67514718
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/CoGroupITCase.java
---
@@ -334,6 +335,124 @@ public void
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2116#discussion_r67514396
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/CoGroupITCase.java
---
@@ -334,6 +335,124 @@ public void
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2083
Full ack, but the problem is not just RocksDB, but also savepoints, which
reference a user class in the state descriptor, including FS snapshots. So if
you configure a file backend and use folding
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2069
Thanks for the review Fabian. I've addressed all comments except the
ObjectMapper configuration. The EvenTimeTableSource makes sense. We can make
the Kafka source extend from that one later on. Do you
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2069#discussion_r66606860
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaJsonTableSource.java
---
@@ -0,0
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2069#discussion_r66606216
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2069#discussion_r66606072
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSource.java
---
@@ -0,0
701 - 800 of 1497 matches
Mail list logo
