[GitHub] flink pull request #3557: [FLINK-6087] Fix file-path filtering in Continuous...

2018-06-01 Thread ymarzougui
Github user ymarzougui closed the pull request at: https://github.com/apache/flink/pull/3557 ---

[GitHub] flink pull request #3557: [FLINK-6087] Fix file-path filtering in Continuous...

2017-03-16 Thread ymarzougui
GitHub user ymarzougui opened a pull request: https://github.com/apache/flink/pull/3557 [FLINK-6087] Fix file-path filtering in ContinuousFileMonitoringFunction The Files Filter is only applied to directories, so there is no way to filter individual files. This fixes it. You can

[GitHub] flink pull request #3090: [FLINK-5432] Fix nested files enumeration in Conti...

2017-01-13 Thread ymarzougui
Github user ymarzougui commented on a diff in the pull request: https://github.com/apache/flink/pull/3090#discussion_r95976740 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileMonitoringFunction.java --- @@ -282,7 +282,7

[GitHub] flink issue #3090: [FLINK-5432] Fix nested files enumeration in ContinuousFi...

2017-01-13 Thread ymarzougui
Github user ymarzougui commented on the issue: https://github.com/apache/flink/pull/3090 @aljoscha Added a test and changed Path type according to @zentol's suugestion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink issue #2995: [FLINK-5320] Fix result TypeInformation in WindowedStream...

2017-01-11 Thread ymarzougui
Github user ymarzougui commented on the issue: https://github.com/apache/flink/pull/2995 Thanks @aljoscha for merging and adding the appropriate tests. Closing the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request #2995: [FLINK-5320] Fix result TypeInformation in Windowe...

2017-01-11 Thread ymarzougui
Github user ymarzougui closed the pull request at: https://github.com/apache/flink/pull/2995 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request #3090: [FLINK-5432] fix nested files enumeration in Conti...

2017-01-10 Thread ymarzougui
GitHub user ymarzougui opened a pull request: https://github.com/apache/flink/pull/3090 [FLINK-5432] fix nested files enumeration in ContinuousFileMonitoringFunction This PR fixes reading nested files when the InputFormat has NestedFileEnumeration set to true. Nested files were

[GitHub] flink issue #2995: [FLINK-5320] Fix result TypeInformation in WindowedStream...

2016-12-14 Thread ymarzougui
Github user ymarzougui commented on the issue: https://github.com/apache/flink/pull/2995 @StephanEwen @aljoscha, I added a test for `WindowedStream.fold()` similar to the one in [EventTimeAllWindowCheckpointingITCase](https://github.com/apache/flink/blob/master/flink-tests/src/test

[GitHub] flink issue #2995: [FLINK-5320] Fix result TypeInformation in WindowedStream...

2016-12-13 Thread ymarzougui
Github user ymarzougui commented on the issue: https://github.com/apache/flink/pull/2995 Yes, I will see how to add a unit test and try to add a commit to this PR by the end of the day or tomorrow. Fortunately the fold in `AllWindowStream` is correct, the problem in `WindowStream

[GitHub] flink pull request #2995: [FLINK-5320] Fix result TypeInformation in Windowe...

2016-12-13 Thread ymarzougui
GitHub user ymarzougui opened a pull request: https://github.com/apache/flink/pull/2995 [FLINK-5320] Fix result TypeInformation in WindowedStream.fold The resultType of the WindowFunction in WindowedStream.fold(ACC, FoldFunction, WindowFunction) can not be inferred correctly

[GitHub] flink issue #2835: [FLINK-3869] WindowedStream.apply with FoldFunction is to...

2016-11-22 Thread ymarzougui
Github user ymarzougui commented on the issue: https://github.com/apache/flink/pull/2835 Thanks @aljoscha for looking at it and for merging. Closing the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request #2835: [FLINK-3869] WindowedStream.apply with FoldFunctio...

2016-11-22 Thread ymarzougui
Github user ymarzougui closed the pull request at: https://github.com/apache/flink/pull/2835 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request #2835: [FLINK-3869] WindowedStream.apply with FoldFunctio...

2016-11-20 Thread ymarzougui
GitHub user ymarzougui opened a pull request: https://github.com/apache/flink/pull/2835 [FLINK-3869] WindowedStream.apply with FoldFunction is too restrictive This pull request removes the restriction that a WindowFunction in a fold/apply should emit the same type