[GitHub] flink pull request #3557: [FLINK-6087] Fix file-path filtering in Continuous...
Github user ymarzougui closed the pull request at: https://github.com/apache/flink/pull/3557 ---
[GitHub] flink pull request #3557: [FLINK-6087] Fix file-path filtering in Continuous...
GitHub user ymarzougui opened a pull request: https://github.com/apache/flink/pull/3557 [FLINK-6087] Fix file-path filtering in ContinuousFileMonitoringFunction The Files Filter is only applied to directories, so there is no way to filter individual files. This fixes it. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ymarzougui/flink patch-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3557.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3557 commit 0731a0ca5c6566e1c2a9d49d223b83223f92a450 Author: Yassine Marzougui <y.marzou...@mindlytix.com> Date: 2017-03-16T23:21:38Z [FLINK-6087] Fix file-path filtering in ContinuousFileMonitoringFunction --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #3090: [FLINK-5432] Fix nested files enumeration in Conti...
Github user ymarzougui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3090#discussion_r95976740
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileMonitoringFunction.java
---
@@ -282,7 +282,7 @@ private void monitorDirAndForwardSplits(FileSystem fs,
* Returns the paths of the files not yet processed.
* @param fileSystem The filesystem where the monitored directory
resides.
*/
- private Map<Path, FileStatus> listEligibleFiles(FileSystem fileSystem)
throws IOException {
+ private Map<Path, FileStatus> listEligibleFiles(FileSystem fileSystem,
String path) throws IOException {
--- End diff --
Thanks, changed in the last commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3090: [FLINK-5432] Fix nested files enumeration in ContinuousFi...
Github user ymarzougui commented on the issue: https://github.com/apache/flink/pull/3090 @aljoscha Added a test and changed Path type according to @zentol's suugestion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2995: [FLINK-5320] Fix result TypeInformation in WindowedStream...
Github user ymarzougui commented on the issue: https://github.com/apache/flink/pull/2995 Thanks @aljoscha for merging and adding the appropriate tests. Closing the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #2995: [FLINK-5320] Fix result TypeInformation in Windowe...
Github user ymarzougui closed the pull request at: https://github.com/apache/flink/pull/2995 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #3090: [FLINK-5432] fix nested files enumeration in Conti...
GitHub user ymarzougui opened a pull request: https://github.com/apache/flink/pull/3090 [FLINK-5432] fix nested files enumeration in ContinuousFileMonitoringFunction This PR fixes reading nested files when the InputFormat has NestedFileEnumeration set to true. Nested files were not read because the code in listEligibleFiles did not recursively enumerate the input paths. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ymarzougui/flink FLINK-5432 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3090.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3090 commit c74996b278187e348af7043ddc0aa9a500373502 Author: Yassine Marzougui <y.marzou...@mindlytix.com> Date: 2017-01-11T00:43:19Z [FLINK-5432] recursively scan nested files in ContinuousFileMonitoringFunction --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2995: [FLINK-5320] Fix result TypeInformation in WindowedStream...
Github user ymarzougui commented on the issue: https://github.com/apache/flink/pull/2995 @StephanEwen @aljoscha, I added a test for `WindowedStream.fold()` similar to the one in [EventTimeAllWindowCheckpointingITCase](https://github.com/apache/flink/blob/master/flink-tests/src/test/java/org/apache/flink/test/checkpointing/EventTimeAllWindowCheckpointingITCase.java#L285). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2995: [FLINK-5320] Fix result TypeInformation in WindowedStream...
Github user ymarzougui commented on the issue: https://github.com/apache/flink/pull/2995 Yes, I will see how to add a unit test and try to add a commit to this PR by the end of the day or tomorrow. Fortunately the fold in `AllWindowStream` is correct, the problem in `WindowStream` is due to a mistake by me when I contributed FLINK-3869. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #2995: [FLINK-5320] Fix result TypeInformation in Windowe...
GitHub user ymarzougui opened a pull request: https://github.com/apache/flink/pull/2995 [FLINK-5320] Fix result TypeInformation in WindowedStream.fold The resultType of the WindowFunction in WindowedStream.fold(ACC, FoldFunction, WindowFunction) can not be inferred correctly because it has the wrong argument, which can lead to an "InvalidTypesException: Input mismatch" exception. This PR corrects its. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ymarzougui/flink FLINK-5320 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2995.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2995 commit 2472d718b603d7989fa87d5c8a441381e00bd60f Author: Yassine Marzougui <y.marzou...@mindlytix.com> Date: 2016-12-13T10:05:50Z [FLINK-5320] Fix result TypeInformation in WindowedStream.fold --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2835: [FLINK-3869] WindowedStream.apply with FoldFunction is to...
Github user ymarzougui commented on the issue: https://github.com/apache/flink/pull/2835 Thanks @aljoscha for looking at it and for merging. Closing the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #2835: [FLINK-3869] WindowedStream.apply with FoldFunctio...
Github user ymarzougui closed the pull request at: https://github.com/apache/flink/pull/2835 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request #2835: [FLINK-3869] WindowedStream.apply with FoldFunctio...
GitHub user ymarzougui opened a pull request: https://github.com/apache/flink/pull/2835 [FLINK-3869] WindowedStream.apply with FoldFunction is too restrictive This pull request removes the restriction that a WindowFunction in a fold/apply should emit the same type as the accumulator type of the fold. It brings the following changes to the Java and Scala APIs: - Deprecating `apply(ReduceFunction, WindowFunction)` and the restrictive `apply(Initial, FoldFunction, WindowFunction)` methods. - Replacing them with two methods : `reduce(ReduceFunction, WindowFunction)` and a non-restrictive `fold(Initial, FoldFunction, WindowFunction)`. - Changing some test classes to use the new methods. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ymarzougui/flink FLINK-3869 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2835.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2835 commit df65335dd2193d8a2b956085b0f375db5eb75863 Author: Yassine Marzougui <y.marzou...@mindlytix.com> Date: 2016-11-19T23:19:10Z [FLINK-3869] WindowedStream.apply with FoldFunction is too restrictive --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
