Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2136
merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2144#discussion_r68026831
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraSinkBase.java
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2144
found a minor formatting issue, otherwise +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2144
merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/2145
[FLINK-4087] [metrics] Improved JMX port handling
This PR modifies the JMX port handling.
Instead of setting a specific configured port on JVM start-up we use an
ephemeral port for the
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/2146
[FLINK-1550/FLINK-4057] Add JobManager Metrics
This PR relies on #2145.
This PR exposes several Metrics on the JobManager.
The first change made was the separation of the
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2105#discussion_r68036496
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/MetricRegistry.java ---
@@ -170,8 +170,12 @@ public ScopeFormats getScopeFormats
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2105#discussion_r68036583
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/MetricRegistry.java ---
@@ -86,11 +88,11 @@ public MetricRegistry(Configuration config
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2105#discussion_r68037781
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/MetricRegistry.java ---
@@ -118,40 +120,38 @@ public MetricRegistry(Configuration config
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2145#discussion_r68041836
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/reporter/JMXReporter.java ---
@@ -73,10 +86,61 @@ public JMXReporter
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2145#discussion_r68043651
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/reporter/JMXReporter.java ---
@@ -265,4 +329,72 @@ public Object getValue
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68069551
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/groups/TaskManagerJobMetricGroup.java
---
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68070204
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/groups/JobManagerMetricGroup.java
---
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68070738
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/groups/scope/ScopeFormat.java
---
@@ -240,7 +305,7 @@ public OperatorScopeFormat(String format
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68070694
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/groups/scope/ScopeFormat.java
---
@@ -66,23 +68,44 @@
// Scope Variables
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68070632
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/groups/JobManagerMetricGroup.java
---
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68070903
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -78,6 +82,7 @@ import org.apache.flink.util
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r6807
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -149,6 +154,9 @@ class JobManager(
var
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68071264
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -149,6 +154,9 @@ class JobManager(
var
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68071458
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -270,6 +284,17 @@ class JobManager(
// shut down
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68071928
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1737,6 +1766,149 @@ class JobManager
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68072122
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1737,6 +1766,149 @@ class JobManager
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68090624
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -149,6 +154,9 @@ class JobManager(
var
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2105#discussion_r68201901
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/MetricRegistry.java ---
@@ -118,40 +120,38 @@ public MetricRegistry(Configuration config
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68203446
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -149,6 +154,9 @@ class JobManager(
var
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68203613
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -78,6 +82,7 @@ import org.apache.flink.util
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68204004
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/groups/JobManagerMetricGroup.java
---
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2145#discussion_r68209115
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/reporter/JMXReporter.java ---
@@ -265,4 +329,72 @@ public Object getValue
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2145#discussion_r68209148
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/reporter/JMXReporter.java ---
@@ -73,10 +86,61 @@ public JMXReporter
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2145#discussion_r68209393
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/reporter/JMXReporter.java ---
@@ -73,10 +86,61 @@ public JMXReporter
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2105#discussion_r68247987
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/MetricRegistry.java ---
@@ -118,40 +120,38 @@ public MetricRegistry(Configuration config
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2134#discussion_r68255328
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/groups/AbstractMetricGroup.java
---
@@ -146,7 +147,16 @@ public Counter counter(int name
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2134#discussion_r68256978
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/groups/AbstractMetricGroup.java
---
@@ -146,7 +147,16 @@ public Counter counter(int name
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2134#discussion_r68268650
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/groups/AbstractMetricGroup.java
---
@@ -146,7 +147,16 @@ public Counter counter(int name
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2151
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2147#discussion_r68269922
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
@@ -750,13 +751,16 @@ protected YarnClusterClient
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2147
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2105
@tillrohrmann Addressed all your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/2158
[FLINK-4116] Metrics documentation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink metrics_docs
Alternatively you can review and
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2145#discussion_r68396189
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/reporter/JMXReporter.java ---
@@ -265,4 +329,72 @@ public Object getValue
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2145
@tillrohrmann I've addressed your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2128#discussion_r68406562
--- Diff:
flink-streaming-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/common/Utils.java
---
@@ -0,0
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2128#discussion_r68406896
--- Diff:
flink-streaming-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/common/RMQSinkTest.java
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2128#discussion_r68408173
--- Diff:
flink-streaming-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/common/RMQSinkTest.java
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2112
merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2134
merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2163
merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2151
merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2151
Forgot to add the close message, can you close this PR manually @rmetzger ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/2167
[FLINK-4122] Disable root shading in Cassandra jar
This PR overrides the root pom's guava shading configuration, so that the
JAR does not contain both shaded versions of guava.
You can merge
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2105
merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2145
merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2158#discussion_r68567416
--- Diff: docs/apis/common/index.md ---
@@ -1350,3 +1350,211 @@ You may specify program arguments before the job is
executed. The plan visualiza
the
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2158#discussion_r68571093
--- Diff: docs/apis/common/index.md ---
@@ -1350,3 +1350,211 @@ You may specify program arguments before the job is
executed. The plan visualiza
the
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2146
@tillrohrmann I've addressed your comments and rebased the PR. You should
now be able to try it out locally.
---
If your project is set up for it, you can reply to this email and have your
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2109#discussion_r68578183
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/io/FileInputFormatTest.java
---
@@ -314,41 +297,101 @@ public void testIgnoredUnderscoreFiles
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2128#discussion_r68580911
--- Diff:
flink-streaming-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java
---
@@ -76,6 +76,9
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2128
I tihnk this looks good.
One remark for future contributions though: I think some of your tests are
too specific.
These include `openCallDeclaresQueue`, `throwExceptionIfChannelIsNull
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68729588
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1727,6 +1764,160 @@ class JobManager
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68731503
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1082,6 +1110,13 @@ class JobManager
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68732963
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1727,6 +1764,160 @@ class JobManager
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68734570
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1082,6 +1110,13 @@ class JobManager
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2146
fixed the issue with the group being null.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2146
I moved the checkpoint metrics into the Tracker (and reverted the changed
to ExecutionGraph). Currently trying it out locally.
Regarding the exception catching in the metrics: I can't d
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2158#discussion_r68910582
--- Diff: docs/apis/common/index.md ---
@@ -1350,3 +1350,211 @@ You may specify program arguments before the job is
executed. The plan visualiza
the
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68913433
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/stats/SimpleCheckpointStatsTracker.java
---
@@ -106,10 +108,12 @@
* The
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68914059
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1235,7 +1234,7 @@ class JobManager
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2146
Can you point me to a test that does this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2158
I've addressed all comments, except the config page.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2158
also missing: specific reporter naming
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2146
@tillrohrmann I've added a test case
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/2183
[FLINK-4123] Cassandra sink checks for exceptions in ack phase
This PR prevents the Cassandra Sink from locking up during the
acknowledgement phase.
We know check for exceptions in the ack
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68983836
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerMetricTest.java
---
@@ -0,0 +1,249 @@
+/*
+ * Licensed to the
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68984285
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerMetricTest.java
---
@@ -0,0 +1,249 @@
+/*
+ * Licensed to the
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2146
That is a known and intended behavior. It is the users responsibility to
make sure that no naming conflicts arise, either by providing unique
job/task/operator names or modifying the scope formats
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2158#discussion_r68987851
--- Diff: docs/apis/common/index.md ---
@@ -1350,3 +1350,397 @@ You may specify program arguments before the job is
executed. The plan visualiza
the
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2146
What is this discussion about; changing the default format or finding a
general way to avoid naming collisions?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r69094834
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerMetricTest.java
---
@@ -0,0 +1,249 @@
+/*
+ * Licensed to the
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2146
For clarification: including the JobID is exactly what the user is supposed
to do when he runs multiple jobs with the same name.
The current scope format is designed to provide the most
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r69107628
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerMetricTest.java
---
@@ -0,0 +1,249 @@
+/*
+ * Licensed to the
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r69145972
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerMetricTest.java
---
@@ -0,0 +1,249 @@
+/*
+ * Licensed to the
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2158#discussion_r69163084
--- Diff: docs/apis/common/index.md ---
@@ -1350,3 +1350,397 @@ You may specify program arguments before the job is
executed. The plan visualiza
the
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2158#discussion_r69163312
--- Diff: docs/apis/common/index.md ---
@@ -1350,3 +1350,397 @@ You may specify program arguments before the job is
executed. The plan visualiza
the
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2183#discussion_r69163543
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraTupleWriteAheadSink.java
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2158#discussion_r69173467
--- Diff: docs/apis/common/index.md ---
@@ -1350,3 +1350,397 @@ You may specify program arguments before the job is
executed. The plan visualiza
the
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2158#discussion_r69173750
--- Diff: docs/apis/common/index.md ---
@@ -1350,3 +1350,397 @@ You may specify program arguments before the job is
executed. The plan visualiza
the
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2158#discussion_r69173815
--- Diff: docs/apis/common/index.md ---
@@ -1350,3 +1350,397 @@ You may specify program arguments before the job is
executed. The plan visualiza
the
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2128
Thank your for reminding me, i forgot about this PR a bit :(
The PR is fine imo, +1 to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2158#discussion_r69270577
--- Diff: docs/apis/common/index.md ---
@@ -1350,3 +1350,397 @@ You may specify program arguments before the job is
executed. The plan visualiza
the
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2158#discussion_r69278183
--- Diff: docs/apis/common/index.md ---
@@ -1350,3 +1350,397 @@ You may specify program arguments before the job is
executed. The plan visualiza
the
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2158
I've made the following changes:
- rewritte scope section
- removed ... from examples
- FIX ALL THE TYPOS
- better line breaking
- added dependency&example for D
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2183
@tillrohrmann Addressed your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2146
Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2189
Please provide some context for this PR, the referenced JIRA is marked as
closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2189
there are also some test failures in flink-clients:
```
testManualOptionsOverridesConfig(org.apache.flink.client.CliFrontendAddressConfigurationTest)
Time elapsed: 0.031 sec
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2172#discussion_r69295166
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/util/JarFileCreator.java
---
@@ -189,33 +189,33 @@ public synchronized void createJarFile
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2167
merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user zentol closed the pull request at:
https://github.com/apache/flink/pull/2167
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2115
Please write a comment when you update the PR, we don't get any
notifications for pushed commits :)
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2115
I'll have to try it out to be sure, but i can't a problem looking through
the code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
401 - 500 of 5315 matches
Mail list logo
