[GitHub] flink pull request #2836: [FLINK-5092] Add maven profile with code coverage ...

2017-04-12 Thread BorisOsipov
Github user BorisOsipov closed the pull request at: https://github.com/apache/flink/pull/2836 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request #2836: [FLINK-5092] Add maven profile with code coverage ...

2017-02-04 Thread BorisOsipov
GitHub user BorisOsipov reopened a pull request: https://github.com/apache/flink/pull/2836 [FLINK-5092] Add maven profile with code coverage report generation Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list

[GitHub] flink pull request #2836: [FLINK-5092] Add maven profile with code coverage ...

2017-02-03 Thread BorisOsipov
Github user BorisOsipov closed the pull request at: https://github.com/apache/flink/pull/2836 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink issue #2836: [FLINK-5092] Add maven profile with code coverage report ...

2017-02-03 Thread BorisOsipov
Github user BorisOsipov commented on the issue: https://github.com/apache/flink/pull/2836 @zentol I've rebased pr and excluded mentioned above flink-examples-streaming and flink-storm-examples modules. --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request #2836: [FLINK-5092] Add maven profile with code coverage ...

2017-01-25 Thread BorisOsipov
Github user BorisOsipov commented on a diff in the pull request: https://github.com/apache/flink/pull/2836#discussion_r97863068 --- Diff: flink-contrib/flink-storm-examples/pom.xml --- @@ -364,6 +363,18 @@ under the License

[GitHub] flink issue #2836: [FLINK-5092] Add maven profile with code coverage report ...

2017-01-18 Thread BorisOsipov
Github user BorisOsipov commented on the issue: https://github.com/apache/flink/pull/2836 @zentol > Is there a way to exclude certain files? Sure. It setups like in other plugins by include\exclude section in plugin configuration. >Is there a way to s

[GitHub] flink issue #2836: [FLINK-5092] Add maven profile with code coverage report ...

2017-01-17 Thread BorisOsipov
Github user BorisOsipov commented on the issue: https://github.com/apache/flink/pull/2836 @zentol Hi. Any news? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink issue #3019: [FLINK-4255] Unstable test WebRuntimeMonitorITCase.testNo...

2016-12-16 Thread BorisOsipov
Github user BorisOsipov commented on the issue: https://github.com/apache/flink/pull/3019 @zentol Thank you for the review. I've resolved your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request #3019: [FLINK-4255] Unstable test WebRuntimeMonitorITCase...

2016-12-16 Thread BorisOsipov
Github user BorisOsipov commented on a diff in the pull request: https://github.com/apache/flink/pull/3019#discussion_r92832659 --- Diff: flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitorITCase.java --- @@ -262,8 +247,8 @@ public void

[GitHub] flink issue #2836: [FLINK-5092] Add maven profile with code coverage report ...

2016-12-16 Thread BorisOsipov
Github user BorisOsipov commented on the issue: https://github.com/apache/flink/pull/2836 Pay attention that Jacoco does not support parallel test execution. Your experiment will be longer than usual full tests execution --- If your project is set up for it, you can reply

[GitHub] flink pull request #3019: [FLINK-4255] Unstable test WebRuntimeMonitorITCase...

2016-12-16 Thread BorisOsipov
Github user BorisOsipov commented on a diff in the pull request: https://github.com/apache/flink/pull/3019#discussion_r92807445 --- Diff: flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitorITCase.java --- @@ -262,8 +247,8 @@ public void

[GitHub] flink pull request #3019: [FLINK-4255] Unstable test WebRuntimeMonitorITCase...

2016-12-16 Thread BorisOsipov
GitHub user BorisOsipov opened a pull request: https://github.com/apache/flink/pull/3019 [FLINK-4255] Unstable test WebRuntimeMonitorITCase.testNoEscape Fix two issues: [FLINK-4255] Unstable test WebRuntimeMonitorITCase.testNoEscape [FLINK-3746

[GitHub] flink pull request #3010: [minor] Fix String formats in FlinkDistributionOve...

2016-12-15 Thread BorisOsipov
GitHub user BorisOsipov opened a pull request: https://github.com/apache/flink/pull/3010 [minor] Fix String formats in FlinkDistributionOverlay and Task Fix a couple mistakes in String.format(..) You can merge this pull request into a Git repository by running: $ git pull

[GitHub] flink issue #2843: [FLINK-4798] CEPITCase.testSimpleKeyedPatternCEP test fai...

2016-12-14 Thread BorisOsipov
Github user BorisOsipov commented on the issue: https://github.com/apache/flink/pull/2843 These changes not needed after FLINK-5332 fix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request #2843: [FLINK-4798] CEPITCase.testSimpleKeyedPatternCEP t...

2016-12-14 Thread BorisOsipov
Github user BorisOsipov closed the pull request at: https://github.com/apache/flink/pull/2843 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink issue #2836: [FLINK-5092] Add maven profile with code coverage report ...

2016-12-14 Thread BorisOsipov
Github user BorisOsipov commented on the issue: https://github.com/apache/flink/pull/2836 @zentol Yes plugin cannot detect out of box cross-module coverage, but there are some tricks how it could be done. I've implemented and tested one of them. I squash older commits

[GitHub] flink pull request #2967: [FLINK-5169] Fix String.format() wildcards

2016-12-08 Thread BorisOsipov
GitHub user BorisOsipov opened a pull request: https://github.com/apache/flink/pull/2967 [FLINK-5169] Fix String.format() wildcards Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your

[GitHub] flink pull request #2843: [FLINK-4798] CEPITCase.testSimpleKeyedPatternCEP t...

2016-11-29 Thread BorisOsipov
Github user BorisOsipov commented on a diff in the pull request: https://github.com/apache/flink/pull/2843#discussion_r89996713 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/CEPITCase.java --- @@ -361,17 +351,18 @@ public String select(Map<String, Ev

[GitHub] flink issue #2843: FLINK-4798] CEPITCase.testSimpleKeyedPatternCEP test fail...

2016-11-25 Thread BorisOsipov
Github user BorisOsipov commented on the issue: https://github.com/apache/flink/pull/2843 @zentol this one: https://issues.apache.org/jira/browse/FLINK-2020 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink issue #2836: [FLINK-5092] Add maven profile with code coverage report ...

2016-11-25 Thread BorisOsipov
Github user BorisOsipov commented on the issue: https://github.com/apache/flink/pull/2836 You can find report in ${project.basedir}/target/jacoco-report folder. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink issue #2836: [FLINK-5092] Add maven profile with code coverage report ...

2016-11-25 Thread BorisOsipov
Github user BorisOsipov commented on the issue: https://github.com/apache/flink/pull/2836 @zentol I aggregated results by SonarQube. I can share some overall report. [flink.pdf](https://github.com/apache/flink/files/612971/flink.pdf) --- If your project is set up for it, you

[GitHub] flink issue #2836: [FLINK-5092] Add maven profile with code coverage report ...

2016-11-25 Thread BorisOsipov
Github user BorisOsipov commented on the issue: https://github.com/apache/flink/pull/2836 @mxm I tried to use late property evaluation approach in `argLine`. Unfortunately, it doesn't work well with different profiles. In some cases it breaks test run by maven without

[GitHub] flink issue #2859: [FLINK-5147] Prevent NPE in LocalFS#delete()

2016-11-23 Thread BorisOsipov
Github user BorisOsipov commented on the issue: https://github.com/apache/flink/pull/2859 @zentol Thank you! Sorry for off topic. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #2859: [FLINK-5147] Prevent NPE in LocalFS#delete()

2016-11-23 Thread BorisOsipov
Github user BorisOsipov commented on the issue: https://github.com/apache/flink/pull/2859 @zentol I'd like to ask you, why FileSystem#initOutPathLocalFS() is not properly synchronized? Recently I faced with issues like FLINK-4798, FLINK-5077. In such issues one thread removes

[GitHub] flink issue #2836: [FLINK-5092] Add maven profile with code coverage report ...

2016-11-23 Thread BorisOsipov
Github user BorisOsipov commented on the issue: https://github.com/apache/flink/pull/2836 @mxm Thank you for review. I ran into some issues with collecting coverage data. I am going to do additional tests and come back to you. --- If your project is set up for it, you can reply

[GitHub] flink pull request #2852: Fix misprint in condition

2016-11-22 Thread BorisOsipov
GitHub user BorisOsipov opened a pull request: https://github.com/apache/flink/pull/2852 Fix misprint in condition Fix misprint in condition You can merge this pull request into a Git repository by running: $ git pull https://github.com/BorisOsipov/flink

[GitHub] flink pull request #2843: FLINK-4798] CEPITCase.testSimpleKeyedPatternCEP te...

2016-11-21 Thread BorisOsipov
GitHub user BorisOsipov opened a pull request: https://github.com/apache/flink/pull/2843 FLINK-4798] CEPITCase.testSimpleKeyedPatternCEP test failure I've reproduced this issue and found that it is a known issue. You can merge this pull request into a Git repository by running

[GitHub] flink pull request #2836: [FLINK-5092] Add maven profile with code coverage ...

2016-11-20 Thread BorisOsipov
GitHub user BorisOsipov opened a pull request: https://github.com/apache/flink/pull/2836 [FLINK-5092] Add maven profile with code coverage report generation Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list

[GitHub] flink issue #2785: [FLINK-5006] SystemProcessingTimeServiceTest.testTimerSor...

2016-11-10 Thread BorisOsipov
Github user BorisOsipov commented on the issue: https://github.com/apache/flink/pull/2785 Yes it is. The ThreadPoolExecutor is not claiming to be a real-time system with any sort of timing guarantees. The only thing it will guarantee is that it doesn't run tasks too early

[GitHub] flink pull request #2785: [FLINK-5006] SystemProcessingTimeServiceTest.testT...

2016-11-10 Thread BorisOsipov
GitHub user BorisOsipov opened a pull request: https://github.com/apache/flink/pull/2785 [FLINK-5006] SystemProcessingTimeServiceTest.testTimerSorting fails Hello! I'v reproduced this issue on my environment several times. I found that the test uses

[GitHub] flink pull request #2775: [hotfix] Fix wrong arguments order in assert

2016-11-08 Thread BorisOsipov
GitHub user BorisOsipov opened a pull request: https://github.com/apache/flink/pull/2775 [hotfix] Fix wrong arguments order in assert Fix wrong arguments order in assert You can merge this pull request into a Git repository by running: $ git pull https://github.com/BorisOsipov

[GitHub] flink pull request #2774: [hotfix] PartitionerITCase replace comparing Integ...

2016-11-08 Thread BorisOsipov
GitHub user BorisOsipov opened a pull request: https://github.com/apache/flink/pull/2774 [hotfix] PartitionerITCase replace comparing Integers by != to equals Replace comparing Integers by != to equals You can merge this pull request into a Git repository by running: $ git

[GitHub] flink pull request #2769: [FLINK-5032] CsvOutputFormatTest fails on Windows ...

2016-11-08 Thread BorisOsipov
GitHub user BorisOsipov opened a pull request: https://github.com/apache/flink/pull/2769 [FLINK-5032] CsvOutputFormatTest fails on Windows OS I've checked fix on my local environment. You can merge this pull request into a Git repository by running: $ git pull https