[jira] [Commented] (FLINK-14508) google protobuf is not shaded

2019-10-23 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957791#comment-16957791 ] Timo Walther commented on FLINK-14508: -- Actually, protobuf should not be required in Flink's

[jira] [Commented] (FLINK-14042) Different RelDataTypes generated for same TemporalTableFunction

2019-10-21 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956050#comment-16956050 ] Timo Walther commented on FLINK-14042: -- The Blink planner should not have this problem because it

[jira] [Closed] (FLINK-12848) Method equals() in RowTypeInfo should consider fieldsNames

2019-10-18 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-12848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-12848. Fix Version/s: 1.9.2 1.8.3 1.10.0 Resolution: Fixed

[jira] [Closed] (FLINK-9378) Improve TableException message with TypeName usage

2019-10-17 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-9378. --- Resolution: Won't Fix Due to type system rework in FLIP-37, this PR is not relevant anymore. I will

[jira] [Closed] (FLINK-5413) Convert TableEnvironmentITCases to unit tests

2019-10-17 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-5413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-5413. --- Resolution: Won't Fix Not relevant anymore as the code will be replaced by the new Blink planner. >

[jira] [Commented] (FLINK-12848) Method equals() in RowTypeInfo should consider fieldsNames

2019-10-17 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-12848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953700#comment-16953700 ] Timo Walther commented on FLINK-12848: -- I created FLINK-14438. > Method equals() in RowTypeInfo

[jira] [Created] (FLINK-14438) Fix RowTypeInfo.equals()

2019-10-17 Thread Timo Walther (Jira)
Timo Walther created FLINK-14438: Summary: Fix RowTypeInfo.equals() Key: FLINK-14438 URL: https://issues.apache.org/jira/browse/FLINK-14438 Project: Flink Issue Type: Improvement

[jira] [Created] (FLINK-14437) Drop the legacy planner

2019-10-17 Thread Timo Walther (Jira)
Timo Walther created FLINK-14437: Summary: Drop the legacy planner Key: FLINK-14437 URL: https://issues.apache.org/jira/browse/FLINK-14437 Project: Flink Issue Type: Sub-task

[jira] [Commented] (FLINK-12848) Method equals() in RowTypeInfo should consider fieldsNames

2019-10-17 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-12848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953674#comment-16953674 ] Timo Walther commented on FLINK-12848: -- I investigated this issue further and came to the

[jira] [Commented] (FLINK-14432) Add 'SHOW SYSTEM FUNCTIONS' support in SQL CLI

2019-10-17 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953602#comment-16953602 ] Timo Walther commented on FLINK-14432: -- Actually, we plan to let the SQL parser parse such

[jira] [Commented] (FLINK-14171) Add 'SHOW USER FUNCTIONS' support in SQL CLI

2019-10-17 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953598#comment-16953598 ] Timo Walther commented on FLINK-14171: -- As far as I can see FLIP-57 also discusses a rough design.

[jira] [Commented] (FLINK-14432) Add 'SHOW SYSTEM FUNCTIONS' support in SQL CLI

2019-10-17 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953596#comment-16953596 ] Timo Walther commented on FLINK-14432: -- Please make sure that this issue is aligned with FLIP-57.

[jira] [Commented] (FLINK-14171) Add 'SHOW USER FUNCTIONS' support in SQL CLI

2019-10-17 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953589#comment-16953589 ] Timo Walther commented on FLINK-14171: -- Hi Ashwin, the community decided to create a

[jira] [Commented] (FLINK-12848) Method equals() in RowTypeInfo should consider fieldsNames

2019-10-17 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-12848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953575#comment-16953575 ] Timo Walther commented on FLINK-12848: -- [~jark] I think SQL's behavior is fine. But we should

[jira] [Closed] (FLINK-13224) TupleTypeInfoBase equals function can't distinguish different struct type

2019-10-17 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-13224. Resolution: Duplicate This is a duplicate of FLINK-12848. Let's continue the discussion there. >

[jira] [Commented] (FLINK-12848) Method equals() in RowTypeInfo should consider fieldsNames

2019-10-17 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-12848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953529#comment-16953529 ] Timo Walther commented on FLINK-12848: -- This is not the first time that this topic is an issue for

[jira] [Commented] (FLINK-14364) Allow comments fail when not ignore parse errors in CsvRowDeserializationSchema

2019-10-17 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953467#comment-16953467 ] Timo Walther commented on FLINK-14364: -- [~wind_ljy] we can also use

[jira] [Closed] (FLINK-14409) MapType doesn't accept any subclass of java.util.Map

2019-10-16 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-14409. Fix Version/s: 1.10.0 Resolution: Fixed Fixed in 1.10.0:

[jira] [Closed] (FLINK-12979) Sending data to kafka with CsvRowSerializationSchema always adding a "\n", "\r","\r\n" at the end of the message

2019-10-16 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-12979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-12979. Fix Version/s: 1.10.0 Resolution: Fixed Fixed in 1.10.0:

[jira] [Commented] (FLINK-14364) Allow comments fail when not ignore parse errors in CsvRowDeserializationSchema

2019-10-16 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952878#comment-16952878 ] Timo Walther commented on FLINK-14364: -- [~lzljs3620320] I just saw that this is actually intended

[jira] [Commented] (FLINK-14398) Codegen produced larger-than-64kb method

2019-10-16 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952771#comment-16952771 ] Timo Walther commented on FLINK-14398: -- I assigned it to you [~haodang]. It would be great to not

[jira] [Assigned] (FLINK-14398) Codegen produced larger-than-64kb method

2019-10-16 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther reassigned FLINK-14398: Assignee: Hao Dang > Codegen produced larger-than-64kb method >

[jira] [Commented] (FLINK-14395) Refactor ES 6 connector to split table-specific code into flink-sql-connector-elasticsearch6

2019-10-16 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952692#comment-16952692 ] Timo Walther commented on FLINK-14395: -- Jark is correct. The {{sql-connector-xxx}} modules should

[jira] [Commented] (FLINK-14409) MapType doesn't accept any subclass of java.util.Map

2019-10-16 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952689#comment-16952689 ] Timo Walther commented on FLINK-14409: -- Maybe we are too restrictive in

[jira] [Commented] (FLINK-14398) Codegen produced larger-than-64kb method

2019-10-16 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952684#comment-16952684 ] Timo Walther commented on FLINK-14398: -- [~jark] I agree, I think for the Blink planner we need a

[jira] [Commented] (FLINK-14398) Codegen produced larger-than-64kb method

2019-10-16 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952607#comment-16952607 ] Timo Walther commented on FLINK-14398: -- [~jark] the code splitting is limited at the moment. It

[jira] [Commented] (FLINK-14380) Type Extractor POJO setter check does not allow for Immutable Case Class

2019-10-16 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952597#comment-16952597 ] Timo Walther commented on FLINK-14380: -- Hi [~elliotvilhelm], I agree that we should support

[jira] [Commented] (FLINK-14367) Fully support for converting RexNode to Expression

2019-10-11 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949316#comment-16949316 ] Timo Walther commented on FLINK-14367: -- FLIP-51 should simplify the implementation of

[jira] [Commented] (FLINK-14364) Allow comments fail when not ignore parse errors in CsvRowDeserializationSchema

2019-10-11 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949247#comment-16949247 ] Timo Walther commented on FLINK-14364: -- Yes, this seems like a bug. It should be null. Jackson

[jira] [Commented] (FLINK-14356) Introduce "single-field" format to (de)serialize message to a single field

2019-10-11 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949244#comment-16949244 ] Timo Walther commented on FLINK-14356: -- If we go for STRING as well, I suggest to implement at

[jira] [Commented] (FLINK-7151) Add a basic function SQL DDL

2019-10-11 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-7151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949235#comment-16949235 ] Timo Walther commented on FLINK-7151: - Thank you [~ZhenqiuHuang]. We also have a discussion about

[jira] [Commented] (FLINK-14364) Allow comments fail when not ignore parse errors in CsvRowDeserializationSchema

2019-10-11 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949221#comment-16949221 ] Timo Walther commented on FLINK-14364: -- If {{setIgnoreParseErrors}} is set to {{false}}, it is fine

[jira] [Commented] (FLINK-14356) Introduce "single-field" format to (de)serialize message to a single field

2019-10-10 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948608#comment-16948608 ] Timo Walther commented on FLINK-14356: -- Alternatively, we could call it {{raw}} and really only

[jira] [Commented] (FLINK-7151) Add a basic function SQL DDL

2019-10-10 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-7151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948606#comment-16948606 ] Timo Walther commented on FLINK-7151: - [~ZhenqiuHuang] I published FLIP-65 on the mailing list. The

[jira] [Commented] (FLINK-14355) Example code in state processor API docs doesn't compile

2019-10-10 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948508#comment-16948508 ] Timo Walther commented on FLINK-14355: -- CC [~sjwiesman] > Example code in state processor API docs

[jira] [Commented] (FLINK-14356) Support some special RowDeserializationSchema and RowSerializationSchema

2019-10-10 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948355#comment-16948355 ] Timo Walther commented on FLINK-14356: -- +1 for this. It was also mentioned in some early [design

[jira] [Comment Edited] (FLINK-14211) Add jobManager address configuration for SqlClient

2019-10-04 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944562#comment-16944562 ] Timo Walther edited comment on FLINK-14211 at 10/4/19 2:50 PM: --- [~arugal]

[jira] [Comment Edited] (FLINK-14211) Add jobManager address configuration for SqlClient

2019-10-04 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944562#comment-16944562 ] Timo Walther edited comment on FLINK-14211 at 10/4/19 2:49 PM: --- [~arugal]

[jira] [Commented] (FLINK-14211) Add jobManager address configuration for SqlClient

2019-10-04 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944562#comment-16944562 ] Timo Walther commented on FLINK-14211: -- [~arugal] most of the deployment parameters are the ones

[jira] [Commented] (FLINK-13656) Upgrade Calcite dependency to 1.21

2019-10-04 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944548#comment-16944548 ] Timo Walther commented on FLINK-13656: -- [~ykt836] this issue has been closed but still has

[jira] [Commented] (FLINK-7151) Add a basic function SQL DDL

2019-10-04 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-7151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944492#comment-16944492 ] Timo Walther commented on FLINK-7151: - Hi everyone, sorry for entering the discussion so late.

[jira] [Commented] (FLINK-14055) Add advanced function DDL syntax "USING JAR/FILE/ACHIVE"

2019-10-04 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944462#comment-16944462 ] Timo Walther commented on FLINK-14055: -- [~hpeter] I am a bit confused here. This issue covers

[jira] [Commented] (FLINK-14293) Lazy execution of queries might produce wrong results

2019-09-30 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940932#comment-16940932 ] Timo Walther commented on FLINK-14293: -- [~xuefuz] I think you also had concerns about this

[jira] [Commented] (FLINK-14092) Upgrade Calcite version to 1.21 for Flink SQL

2019-09-17 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931917#comment-16931917 ] Timo Walther commented on FLINK-14092: -- [~danny0405] can you check if this is a duplicate issue?

[jira] [Commented] (FLINK-14099) SQL supports timestamp in Long

2019-09-17 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931915#comment-16931915 ] Timo Walther commented on FLINK-14099: -- Could you share a use case/example with us? Actually, we

[jira] [Commented] (FLINK-13943) Provide api to convert flink table to java List

2019-09-03 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921298#comment-16921298 ] Timo Walther commented on FLINK-13943: -- For streaming, it should be more like a `List` consisting

[jira] [Commented] (FLINK-13943) Provide api to convert flink table to java List

2019-09-03 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921285#comment-16921285 ] Timo Walther commented on FLINK-13943: -- Having this functionality also in the Table API makes

[jira] [Commented] (FLINK-13900) Add a built-in "console" sink to print results in console

2019-09-03 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921267#comment-16921267 ] Timo Walther commented on FLINK-13900: -- {{TableSink.configure}} is deprecated. If we want to

[jira] [Assigned] (FLINK-13896) Scala 2.11 maven compile should target Java 1.8

2019-08-30 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther reassigned FLINK-13896: Assignee: Terry Wang > Scala 2.11 maven compile should target Java 1.8 >

[jira] [Commented] (FLINK-13900) Add a built-in "console" sink to print results in console

2019-08-29 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16918678#comment-16918678 ] Timo Walther commented on FLINK-13900: -- In general this would be useful, but it would be the first

[jira] [Commented] (FLINK-13896) Scala 2.11 maven compile should target Java 1.8

2019-08-29 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16918585#comment-16918585 ] Timo Walther commented on FLINK-13896: -- Hi [~Terry1897], the environment field is rather used for

[jira] [Commented] (FLINK-13879) It seems that there might be some problem with the DataStream.keyBy(xx).maxBy(yy)

2019-08-28 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16917713#comment-16917713 ] Timo Walther commented on FLINK-13879: -- Historical reasons I guess. Type information needs a

[jira] [Commented] (FLINK-13857) Remove remaining UdfAnalyzer configurations

2019-08-27 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916548#comment-16916548 ] Timo Walther commented on FLINK-13857: -- +1 to this > Remove remaining UdfAnalyzer configurations >

[jira] [Assigned] (FLINK-13828) Deprecate ConfigConstants.LOCAL_START_WEBSERVER

2019-08-27 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther reassigned FLINK-13828: Assignee: TisonKun > Deprecate ConfigConstants.LOCAL_START_WEBSERVER >

[jira] [Commented] (FLINK-13828) Deprecate ConfigConstants.LOCAL_START_WEBSERVER

2019-08-27 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916545#comment-16916545 ] Timo Walther commented on FLINK-13828: -- Thanks [~Tison]. I assigned it to you. > Deprecate

[jira] [Commented] (FLINK-13741) "SHOW FUNCTIONS" should include Flink built-in functions' names

2019-08-16 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908896#comment-16908896 ] Timo Walther commented on FLINK-13741: -- I think we should start to align the TableEnvironment with

[jira] [Commented] (FLINK-13563) TumblingGroupWindow should implement toString method

2019-08-15 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907956#comment-16907956 ] Timo Walther commented on FLINK-13563: -- Hi [~jark], I just saw that this PR touches also plan tests

[jira] [Closed] (FLINK-13603) Flink Table ApI not working with nested Json schema starting From 1.6.x

2019-08-14 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-13603. Resolution: Duplicate Duplicate of FLINK-12848. Let's continue the discussion there. > Flink

[jira] [Commented] (FLINK-12848) Method equals() in RowTypeInfo should consider fieldsNames

2019-08-14 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907331#comment-16907331 ] Timo Walther commented on FLINK-12848: -- Sorry, for not responding earlier. Somehow this issue

[jira] [Commented] (FLINK-13603) Flink Table ApI not working with nested Json schema starting From 1.6.x

2019-08-14 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907324#comment-16907324 ] Timo Walther commented on FLINK-13603: -- Thanks for reporting this bug [~jacky.du0...@gmail.com].

[jira] [Commented] (FLINK-9412) Add a REST-based SQL Client Gateway

2019-08-14 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907306#comment-16907306 ] Timo Walther commented on FLINK-9412: - Hi Simon, currently FLIP-24 is the only design document we

[jira] [Commented] (FLINK-13563) TumblingGroupWindow should implement toString method

2019-08-14 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907302#comment-16907302 ] Timo Walther commented on FLINK-13563: -- [~jark] we should watch out what we currently merge to the

[jira] [Created] (FLINK-13691) Remove deprecated query config

2019-08-12 Thread Timo Walther (JIRA)
Timo Walther created FLINK-13691: Summary: Remove deprecated query config Key: FLINK-13691 URL: https://issues.apache.org/jira/browse/FLINK-13691 Project: Flink Issue Type: Improvement

[jira] [Closed] (FLINK-13600) TableEnvironment.connect() is not usable

2019-08-08 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-13600. Resolution: Fixed Fixed in 1.10.0: d544d302bdd640edb5432c2df9c424057a5548e9 Fixed in 1.9.0:

[jira] [Commented] (FLINK-6962) Add a create table SQL DDL

2019-08-08 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903058#comment-16903058 ] Timo Walther commented on FLINK-6962: - [~simonss]:[~jark] is working on a FLIP. I guess the issue is

[jira] [Closed] (FLINK-13441) Add batch sql E2E test which runs with fewer slots than parallelism

2019-08-08 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-13441. Resolution: Fixed Fixed in 1.10.0: ae56cd7ab4d2f4811bddd1f4c7a40e5e97e01848 Fixed in 1.9.0:

[jira] [Created] (FLINK-13649) Improve error message when job submission was not successful

2019-08-08 Thread Timo Walther (JIRA)
Timo Walther created FLINK-13649: Summary: Improve error message when job submission was not successful Key: FLINK-13649 URL: https://issues.apache.org/jira/browse/FLINK-13649 Project: Flink

[jira] [Comment Edited] (FLINK-13225) Introduce type inference for hive functions in blink

2019-08-08 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902788#comment-16902788 ] Timo Walther edited comment on FLINK-13225 at 8/8/19 8:41 AM: -- I'm not sure

[jira] [Commented] (FLINK-13225) Introduce type inference for hive functions in blink

2019-08-08 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902788#comment-16902788 ] Timo Walther commented on FLINK-13225: -- I'm not sure if there was really consensus on having a

[jira] [Commented] (FLINK-13225) Introduce type inference for hive functions in blink

2019-08-07 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902649#comment-16902649 ] Timo Walther commented on FLINK-13225: -- [~ykt836] The feature freeze was over 1 month ago and this

[jira] [Closed] (FLINK-13521) Allow setting configuration in SQL CLI

2019-08-07 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-13521. Resolution: Fixed Fixed in 1.10.0: 6cb6dc1a7074406651b1d547eee45b14f29033c4 Fixed in 1.9.0:

[jira] [Commented] (FLINK-13441) Add batch sql E2E test which runs with fewer slots than parallelism

2019-08-07 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901879#comment-16901879 ] Timo Walther commented on FLINK-13441: -- [~ykt836] we should run the TPC-H test with more than one

[jira] [Updated] (FLINK-13600) TableEnvironment.connect() is not usable

2019-08-06 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-13600: - Fix Version/s: 1.9.0 > TableEnvironment.connect() is not usable >

[jira] [Created] (FLINK-13600) TableEnvironment.connect() is not usable

2019-08-06 Thread Timo Walther (JIRA)
Timo Walther created FLINK-13600: Summary: TableEnvironment.connect() is not usable Key: FLINK-13600 URL: https://issues.apache.org/jira/browse/FLINK-13600 Project: Flink Issue Type: Bug

[jira] [Closed] (FLINK-13569) DDL table property key is defined as indentifier but should be string literal instead

2019-08-06 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-13569. Resolution: Duplicate Fixed in FLINK-13540. > DDL table property key is defined as indentifier

[jira] [Commented] (FLINK-13441) Add batch sql E2E test which runs with fewer slots than parallelism

2019-08-06 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900742#comment-16900742 ] Timo Walther commented on FLINK-13441: -- I will review this shortly. > Add batch sql E2E test which

[jira] [Closed] (FLINK-13119) Add blink table config to documentation

2019-08-05 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-13119. Resolution: Fixed Fixed in 1.10.0: 00e0baae8664cf06dbba88542af102c764fb7730 Fixed in 1.9.0:

[jira] [Closed] (FLINK-13463) SQL VALUES might fail for Blink planner

2019-08-05 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-13463. Resolution: Fixed [FLINK-13463][table-planner-blink] Add test case for VALUES with char literal

[jira] [Commented] (FLINK-13580) Add overload support for user defined function to blink-planner

2019-08-05 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899928#comment-16899928 ] Timo Walther commented on FLINK-13580: -- This issue should be solved after FLIP-37 part 2 has been

[jira] [Commented] (FLINK-13569) DDL table property key is defined as indentifier but should be string literal instead

2019-08-05 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899889#comment-16899889 ] Timo Walther commented on FLINK-13569: -- But what are the implications of using identifier? Can

[jira] [Commented] (FLINK-13569) DDL table property key is defined as indentifier but should be string literal instead

2019-08-05 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899873#comment-16899873 ] Timo Walther commented on FLINK-13569: -- I would also vote for string instead of identifier because

[jira] [Closed] (FLINK-13335) Bring the SQL CREATE TABLE DDL closer to FLIP-37

2019-08-02 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-13335. Resolution: Fixed Release Note: The identifiers "string" and "bytes" are reserved keywords

[jira] [Updated] (FLINK-13335) Bring the SQL CREATE TABLE DDL closer to FLIP-37

2019-08-02 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-13335: - Description: At a first glance it does not seem that the newly introduced DDL is compliant

[jira] [Updated] (FLINK-13335) Bring the SQL CREATE TABLE DDL closer to FLIP-37

2019-08-02 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-13335: - Summary: Bring the SQL CREATE TABLE DDL closer to FLIP-37 (was: Align the SQL CREATE TABLE DDL

[jira] [Closed] (FLINK-13338) Sql conformance is hard to config in TableConfig

2019-08-02 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-13338. Resolution: Fixed Fixed in 1.10.0: 687425db49e332225bfdba63325ca68bef53 Fixed in 1.9.0:

[jira] [Commented] (FLINK-13540) DDL do not support key of properties contains number or "-"

2019-08-02 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898735#comment-16898735 ] Timo Walther commented on FLINK-13540: -- I'm also fine with marking it as a blocker. > DDL do not

[jira] [Commented] (FLINK-13377) Streaming SQL e2e test failed on travis

2019-08-02 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898627#comment-16898627 ] Timo Walther commented on FLINK-13377: -- [~jark] I would vote for closing it for now. A lot of fixes

[jira] [Commented] (FLINK-13525) Improve Expression validation test

2019-08-01 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897967#comment-16897967 ] Timo Walther commented on FLINK-13525: -- I think we can improve this situation when porting the

[jira] [Commented] (FLINK-13279) not able to query table registered in catalogs in SQL CLI

2019-08-01 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897884#comment-16897884 ] Timo Walther commented on FLINK-13279: -- Hi [~xuefuz], I totally agree that the usability is not

[jira] [Commented] (FLINK-13521) Allow set configuration in SQL CLI

2019-08-01 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897879#comment-16897879 ] Timo Walther commented on FLINK-13521: -- I'm fine with having a {{config}} (or {{configuration}}?)

[jira] [Comment Edited] (FLINK-13340) Add more Kafka topic option of flink-connector-kafka

2019-07-31 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897160#comment-16897160 ] Timo Walther edited comment on FLINK-13340 at 7/31/19 1:08 PM: --- Hi

[jira] [Assigned] (FLINK-13340) Add more Kafka topic option of flink-connector-kafka

2019-07-31 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther reassigned FLINK-13340: Assignee: DuBin > Add more Kafka topic option of flink-connector-kafka >

[jira] [Commented] (FLINK-13340) Add more Kafka topic option of flink-connector-kafka

2019-07-31 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897160#comment-16897160 ] Timo Walther commented on FLINK-13340: -- Hi [~dubin555], your proposed changes sound reasonable to

[jira] [Commented] (FLINK-13446) Row count sliding window outputs incorrectly in blink planner

2019-07-31 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897140#comment-16897140 ] Timo Walther commented on FLINK-13446: -- I just had an offline discussion with [~aljoscha] about

[jira] [Closed] (FLINK-13273) Allow switching planners in SQL Client

2019-07-31 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-13273. Resolution: Fixed Fixed in 1.10.0: fea90644005d32af5a5b8ff79c2baafad687d3f7 Fixed in 1.9.0:

[jira] [Updated] (FLINK-10257) Incorrect CHAR type support in Flink SQL and Table API

2019-07-31 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-10257: - Fix Version/s: (was: 1.10) 1.10.0 > Incorrect CHAR type support in Flink

[jira] [Commented] (FLINK-10257) Incorrect CHAR type support in Flink SQL and Table API

2019-07-31 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896975#comment-16896975 ] Timo Walther commented on FLINK-10257: -- For you information, I also did some testing of different

[jira] [Updated] (FLINK-10257) Incorrect CHAR type support in Flink SQL and Table API

2019-07-31 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-10257: - Fix Version/s: 1.10 > Incorrect CHAR type support in Flink SQL and Table API >

[jira] [Updated] (FLINK-10257) Incorrect CHAR type support in Flink SQL and Table API

2019-07-31 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-10257: - Priority: Blocker (was: Critical) > Incorrect CHAR type support in Flink SQL and Table API >

[jira] [Closed] (FLINK-13466) Rename Batch/StreamTableSourceFactory methods for avoiding name clashes

2019-07-30 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-13466. Resolution: Won't Fix It seems that the clashes are acceptable given that both context are

  1   2   3   4   5   6   7   8   9   10   >