Github user aalexandrov commented on the issue:
https://github.com/apache/flink/pull/2337
@greghogan I see, IMHO then the `1.0.0` tag should be dropped from the "Fix
versions" field (if possible).
---
If your project is set up for it, you can reply to this email and have
Github user aalexandrov commented on the issue:
https://github.com/apache/flink/pull/2337
@twalthr The issue is marked with "Fix versions: 1.0.0, 1.2.0" but I could
only fin the `TypeInfoFactory` in the `master` branch. Shouldn't this be
visible in the `release-1.
Github user aalexandrov commented on the issue:
https://github.com/apache/flink/pull/1517
@ggevay :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/1517#issuecomment-208083609
We've summarized the use-case around the hash aggregation experiments in [a
blog post on the Peel
webpage](http://peel-framework.org/2016/04/07/hash-aggregations
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/1517#issuecomment-202868272
Overall it seems that the hash-based combiner works better than the
sort-based one for (a) uniform, or normal key distribution, and (b)
fixed-length records
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/1517#issuecomment-202864630
@fhueske We have used the Easter break to conduct the experiments. A
preliminary writeup is in the Google Doc. @ggevay will provide the results
analysis later today
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/1517#issuecomment-187243415
I've added a [Google
Doc](https://docs.google.com/document/d/12yx7olVrkooceaQPoR1nkk468lIq0xOObY5ukWuNEcM/edit?usp=sharing)
where we can collaborate on the design
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/1517#issuecomment-186257996
@fhueske We will propose three experiments based on your suggestions in a
Google Doc on Monday. Once we have fixed the setup we will prepare a Peel
bundle an run
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/1517#issuecomment-186226154
@ggevay I would be interesting in helping you prepare a
[`peel-flink-bundle`](http://peel-framework.org/getting-started.html) for the
benchmarks @fhueske mentioned
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/1260#issuecomment-149848186
@tillrohrmann The list of TODOs from the JIRA issue is referring concretely
to IntelliJ. Is there some Eclipse user who can see what the corresponding
actions
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/1217#issuecomment-148901986
> Not all methods without paremeters should translate to methods without
parenthesis...
@StephanEwen I agree with that, but I cannot understand
GitHub user aalexandrov opened a pull request:
https://github.com/apache/flink/pull/1259
Removed broken dependency to flink-spargel.
I think that this should have been removed as part of #1229.
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user aalexandrov opened a pull request:
https://github.com/apache/flink/pull/1260
[docs] Fix documentation for building Flink with Scala 2.11 or 2.10
This fixes some dead anchor links and aligns the text in "Build Flink for a
specific Scala version" against th
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/593#issuecomment-145974916
@mxm The issue is probably related to Scala 2.10, since the two passing
builds have `Dscala-2.11`. I'll investigate tonight if I can get a hold on the
PR commits
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/593#issuecomment-145984551
It could be that the test is not executed for Scala 2.11.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/593#issuecomment-142960455
@mxm The jars in which folder? The main motivation point of the pull
request is to add the option to add a classpaths where one can generate code at
runtime
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/593#issuecomment-141455406
@twalthr @rmetzger is there a chance to include this PR in the 10.0 release?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/593#issuecomment-141459804
@rmetzger the final 10.0, this and the Scala 2.11 compatibility are the two
pending issues that make the current Emma master incompatible with vanilla
Flink
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/605#issuecomment-127558961
@StephanEwen To be honest I'm kind of puzzled and somewhat annoyed that a
PR that
1) adds a feature that has been on the list for at least 2 years,
2
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/941#issuecomment-125192692
I guess the s in the name is the giveaway...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/941#issuecomment-125189988
If sbt can resolve profile-based dependencies this should be OK.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/941#issuecomment-125182364
Then it should be good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/941#issuecomment-125180542
Is the removal of the property-based activation (`-Dscala-2.11`) also
intentional? I think this might be used in the travis.yml.
---
If your project is set up
GitHub user aalexandrov opened a pull request:
https://github.com/apache/flink/pull/935
[FLINK-2231] Create a Serializer for Scala Enumerations.
This closes FLINK-2231.
The code should work for all objects which follow [the Enumeration idiom
outlined in the
ScalaDoc](http
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/935#issuecomment-124582468
PS. The third commit fixes a compilation error in IntelliJ when the
'scala_2.11' profile is active.
---
If your project is set up for it, you can reply
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-120423639
Looks very neat!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-119622710
@rmetzger if you can hack your way with regex's in IntelliJ / Eclipse most
of the work should be handled by the IDE.
---
If your project is set up for it, you can
Github user aalexandrov commented on a diff in the pull request:
https://github.com/apache/flink/pull/885#discussion_r33857654
--- Diff: docs/apis/programming_guide.md ---
@@ -136,7 +136,7 @@ mvn archetype:generate /
/div
/div
-The archetypes are working
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/885#issuecomment-118326627
I think that a cleaner solution would be to
1. Add a `scala.suffix` to the Scala profiles. This should be set as the
empty string for 2.10
Github user aalexandrov commented on a diff in the pull request:
https://github.com/apache/flink/pull/885#discussion_r33858383
--- Diff: docs/apis/programming_guide.md ---
@@ -187,7 +187,17 @@ that creates the type information for Flink operations.
/div
/div
Github user aalexandrov commented on a diff in the pull request:
https://github.com/apache/flink/pull/885#discussion_r33858475
--- Diff: docs/apis/programming_guide.md ---
@@ -187,7 +187,17 @@ that creates the type information for Flink operations.
/div
/div
GitHub user aalexandrov opened a pull request:
https://github.com/apache/flink/pull/880
[FLINK-2311] Fixes 'flink-*' dependency scope in flink-contrib.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aalexandrov/flink FLINK-2311
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/880#issuecomment-118035911
@mjsax exactly. Let's at the moment I land in the following situtaion.
1. I want to create a job which includes the [statistics collection
facility proposed
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/880#issuecomment-118036089
@StephanEwen can you tell me what package doesn't work so I can test it out?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/880#issuecomment-118066010
OK thanks for the remark.
Although somewhat verbose, this solves my concrete issue. I wonder if the
list can be exclusive, e.g.
```xml
!-- use
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/880#issuecomment-118063336
The PR is still open and can be adapted.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/880#issuecomment-118083599
OK then we can close the issue as wontfix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user aalexandrov commented on a diff in the pull request:
https://github.com/apache/flink/pull/730#discussion_r32620391
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/feature/TfIdfTransformer.scala
---
@@ -0,0 +1,128 @@
+/*
+ * Licensed
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/656#issuecomment-106907665
This needs a PR before it is merged. @jojo19893, @mguldner please cherry
pick your changes such that you have only one or two commits and force push in
this branch
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/700#issuecomment-106911412
Can anybody with more Apache insight answer to @peedeeX21 concerns?
Otherwise I suggest to merge this and open a follow-up issue that extends the
current
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/730#issuecomment-106910157
@rbraeunlich please squash the commits and prepare this for merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/665#issuecomment-106914608
@FelixNeutatz I think this needs to be squashed before mergning as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user aalexandrov commented on a diff in the pull request:
https://github.com/apache/flink/pull/730#discussion_r31113442
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/feature/TfIdfTransformer.scala
---
@@ -0,0 +1,107 @@
+package
Github user aalexandrov commented on a diff in the pull request:
https://github.com/apache/flink/pull/730#discussion_r31113926
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/feature/TfIdfTransformer.scala
---
@@ -0,0 +1,107 @@
+package
Github user aalexandrov commented on a diff in the pull request:
https://github.com/apache/flink/pull/730#discussion_r31114073
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/feature/TfIdfTransformer.scala
---
@@ -0,0 +1,107 @@
+package
Github user aalexandrov commented on a diff in the pull request:
https://github.com/apache/flink/pull/665#discussion_r30004988
--- Diff:
flink-staging/flink-ml/src/test/scala/org/apache/flink/ml/feature/extraction/FeatureHasherSuite.scala
---
@@ -0,0 +1,245
Github user aalexandrov commented on a diff in the pull request:
https://github.com/apache/flink/pull/665#discussion_r30005062
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/feature/extraction/FeatureHasher.scala
---
@@ -0,0 +1,142 @@
+/*
+ * Licensed
Github user aalexandrov commented on a diff in the pull request:
https://github.com/apache/flink/pull/665#discussion_r30005080
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/feature/extraction/FeatureHasher.scala
---
@@ -0,0 +1,142 @@
+/*
+ * Licensed
Github user aalexandrov commented on a diff in the pull request:
https://github.com/apache/flink/pull/665#discussion_r30005092
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/feature/extraction/FeatureHasher.scala
---
@@ -0,0 +1,142 @@
+/*
+ * Licensed
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/665#issuecomment-100685242
Nice job! :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/593#issuecomment-95559261
@aljoscha I'm sorry, I cannot follow? Can you elaborate?
The idea is to add support for proper folders next to jars when opening an
execution environment
Github user aalexandrov commented on a diff in the pull request:
https://github.com/apache/flink/pull/605#discussion_r28818529
--- Diff:
flink-contrib/src/test/java/org/apache/flink/contrib/operatorstatistics/OperatorStatsAccumulatorsTest.java
---
@@ -0,0 +1,144
Github user aalexandrov commented on a diff in the pull request:
https://github.com/apache/flink/pull/605#discussion_r28799879
--- Diff:
flink-contrib/src/test/java/org/apache/flink/contrib/operatorstatistics/OperatorStatsAccumulatorsTest.java
---
@@ -0,0 +1,144
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/593#issuecomment-92841182
:clap:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user aalexandrov opened a pull request:
https://github.com/apache/flink/pull/559
Fixup ReusingKeyGroupedIterator value iterators in
NonReusingSortMergeCoGroupIterator.
Correct me if I'm wrong, but I think that the
NonReusingSortMergeCoGroupIterator should construct value
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/477#issuecomment-83985616
All but one of the profiles (including the two scala 2.11 profiles) build
with the latest rebase:
https://travis-ci.org/stratosphere/flink/builds/55147681
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/477#issuecomment-83989884
I changed it as @StephanEwen suggested. Can somebody with admin access
please cancel all previous pending builds for this PR here:
https://travis-ci.org
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/477#issuecomment-83491250
One more thing. If we agree to add suffixes and ship multi-build artifacts,
and we are going to restructure the maven projects anyway, why not add suffixes
to both
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/477#issuecomment-83521096
Rebased against the current master
(798e59523f0599096a214c24045a8f011b53ddbc).
Can we please proceed with merging? The POMs are changing on a daily basis
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/477#issuecomment-83614068
If I understand correctly, this does not affect the default mode of
building against Scala 2.10
Correct. It just adds a profile that (optionally) builds
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/477#issuecomment-83613932
Can we retrofit some of the other builds to use Scala 2.11 ?
I guess @rmetzger should answer this.
---
If your project is set up for it, you can reply
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/477#issuecomment-82930555
Can we merge this before handling
[FLINK-1712](https://issues.apache.org/jira/browse/FLINK-1712)?
I can open a separate PR that adds the suffixes
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/477#issuecomment-82266786
If we go with the suffix, we basically have two options:
1. Add the suffix only to modules that use Scala
1. Add the suffix to all maven modules
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/477#issuecomment-8159
H... now it passes. This is weird...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/477#issuecomment-79048001
The scala-2.11 build
```bash
mvn -Dscala-2.11 clean install
```
fails on travis when trying to build the quickstart (@rmetzger reported
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/477#issuecomment-78262466
Why are you using Scala 2.11.4? The mentioned bug seems to be fixed in
2.11.6.
2.11.6 will be out in April. It is between 2.11.5 (which is known to have
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/477#issuecomment-78307840
Any remarks on the my reply to the general comments from @rmetzger (scala
version, suffix)?
---
If your project is set up for it, you can reply to this email
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/477#issuecomment-78502251
[Some of the tests
failed](https://travis-ci.org/apache/flink/builds/53879571) but I'm not sure
whether this is related to the changes or not. I get the following
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/477#issuecomment-78333617
The reason why I asked regarding Scala 2.11.6 was because this version is
shown on the scala-lang website next to the download button.
Snap, I guess
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/477#issuecomment-78348901
I rebased on the current master (includes the changes from PR #454 merged
today). I'll take a look at the errors thrown on building later.
---
If your project is set
Github user aalexandrov commented on a diff in the pull request:
https://github.com/apache/flink/pull/477#discussion_r26210582
--- Diff: pom.xml ---
@@ -599,6 +599,38 @@ under the License.
profiles
profile
+ idscala-2.10/id
GitHub user aalexandrov opened a pull request:
https://github.com/apache/flink/pull/477
Add support for building Flink with Scala 2.11
This adds support for building Flink with Scala 2.11 as [per mailing list
discussion](http://apache-flink-incubator-mailing-list-archive.1008284.n3
GitHub user aalexandrov opened a pull request:
https://github.com/apache/flink/pull/371
Remove 'incubator-' prefix from README.md.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aalexandrov/flink patch-1
Alternatively you can
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/354#issuecomment-72857627
I think that this only happens for the primitive types. I think this is by
design.
If you want to inspect generic parameters, Scala forces you to use
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/354#issuecomment-72660318
I would advocate to adding this one as well as a fallback option.
I have a situation where I want to use KeySelector that might return Java
TupleXX instances
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/354#issuecomment-72660810
I think that [this StackOverflow article explains my
problem](http://stackoverflow.com/questions/11586944/how-to-obtain-the-raw-datatype-of-a-parameter-of-a-field
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/349#issuecomment-72284550
@hsaputra: I just did:
[FLINK-1464](https://issues.apache.org/jira/browse/FLINK-1464).
---
If your project is set up for it, you can reply to this email and have
Github user aalexandrov commented on commit
9ee74f3cf7b04740d6b00edf45d9413ff40322cf:
https://github.com/apache/flink/commit/9ee74f3cf7b04740d6b00edf45d9413ff40322cf#commitcomment-9297124
In .gitignore:
In .gitignore on line 1:
Is removing all these lines a standard procedure
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/254#issuecomment-69539129
YES!!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/254#issuecomment-69343812
I am excited!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
80 matches
Mail list logo
