Github user casidiablo commented on the issue:
https://github.com/apache/flink/pull/5399
Just to be clear, we would revert all the changes, except the ones for
`flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java`,
right?
---
Github user casidiablo commented on the issue:
https://github.com/apache/flink/pull/5399
Sure, that makes sense!
---
Github user casidiablo commented on the issue:
https://github.com/apache/flink/pull/5399
The reason I proposed the change is that any unexpected behavior, even when
you can recover from it, can be indicative of a potential bug/misconfiguration.
INFO logs are by far noisier than
GitHub user casidiablo opened a pull request:
https://github.com/apache/flink/pull/5399
[hotfix] Use LOG.error() when logging failure state changes
It's very inconvenient to have these logged with `INFO`. It makes it hard
to detect errors when inspecting logs with, say, Kibana
Github user casidiablo commented on a diff in the pull request:
https://github.com/apache/flink/pull/5182#discussion_r160841610
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
Github user casidiablo commented on a diff in the pull request:
https://github.com/apache/flink/pull/5182#discussion_r160763163
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
Github user casidiablo commented on the issue:
https://github.com/apache/flink/pull/4150
Since EMR only supports Flink 1.3 I had to checkout release-1.3 and compile
the connector from there. Then I was getting this `Socket not created by this
factory` error.
I then patched
Github user casidiablo commented on the issue:
https://github.com/apache/flink/pull/4150
This actually worked for me. I ran it on EMR 5.10, compiling the kinesis
connector from the release-1.3 branch (since EMR provides Flink 1.3)
---
Github user casidiablo commented on a diff in the pull request:
https://github.com/apache/flink/pull/5182#discussion_r160139807
--- Diff:
flink-metrics/flink-metrics-core/src/main/java/org/apache/flink/metrics/groups/UnregisteredMetricsGroup.java
---
@@ -107,7 +107,7 @@ public
Github user casidiablo commented on a diff in the pull request:
https://github.com/apache/flink/pull/5182#discussion_r159950881
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
Github user casidiablo commented on a diff in the pull request:
https://github.com/apache/flink/pull/5182#discussion_r158496021
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
Github user casidiablo commented on the issue:
https://github.com/apache/flink/pull/5178
ð
---
GitHub user casidiablo opened a pull request:
https://github.com/apache/flink/pull/5199
[hotfix] [javadoc] Fix typos in MemorSegment class
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/casidiablo/flink hotfix/typos-memory
Github user casidiablo commented on a diff in the pull request:
https://github.com/apache/flink/pull/5182#discussion_r158194237
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
---
@@ -96,6
Github user casidiablo commented on a diff in the pull request:
https://github.com/apache/flink/pull/5182#discussion_r158192923
--- Diff: docs/monitoring/metrics.md ---
@@ -1293,6 +1293,29 @@ Thus, in order to infer the metric identifier:
+ Kinesis
GitHub user casidiablo opened a pull request:
https://github.com/apache/flink/pull/5182
[FLINK-8162] [kinesis-connector] Emit Kinesis' millisBehindLatest metric
## What is the purpose of the change
- Emits [Kinesis'
millisBehindLatest](http://docs.aws.amazon.com/kinesis
GitHub user casidiablo opened a pull request:
https://github.com/apache/flink/pull/5178
[hotfix] Fix typo in TestableKinesisDataFetcher
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/casidiablo/flink hotfix/typo-gst
Github user casidiablo commented on the issue:
https://github.com/apache/flink/pull/5133
OK
---
Github user casidiablo commented on a diff in the pull request:
https://github.com/apache/flink/pull/5134#discussion_r155667757
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/benchmark/SerializingLongReceiver.java
---
@@ -0,0 +1,101
GitHub user casidiablo opened a pull request:
https://github.com/apache/flink/pull/5135
[hotfix] [doc] Fix typo in TaskManager and EnvironmentInformation doc
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/casidiablo/flink
Github user casidiablo commented on the issue:
https://github.com/apache/flink/pull/5073
> I thought this was mainly about making the time triggers more relaxed so
that they accept a Window in addition to only TimeWindow.
That's exactly what this PR is about.
---
GitHub user casidiablo opened a pull request:
https://github.com/apache/flink/pull/5133
[hotfix] Fix typo in AkkaUtils method
Also, removed unused code:
- `StandaloneHaServices#RESOURCE_MANAGER_RPC_ENDPOINT_NAME`
- AkkaRpcServiceUtils#createInetSocketAddressFromAkkaURL
GitHub user casidiablo opened a pull request:
https://github.com/apache/flink/pull/5075
[hotfix] [docs] Fix typos in State Backends doc
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/casidiablo/flink wording-state-backends
GitHub user casidiablo opened a pull request:
https://github.com/apache/flink/pull/5073
[FLINK-8124] Make Trigger implementations more generic
# What is the purpose of the change
Flink provides implementations of the `Trigger<T, W extend Window>`
GitHub user casidiablo opened a pull request:
https://github.com/apache/flink/pull/5051
[hotfix] [javadocs] Fixed typo in Trigger doc
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/casidiablo/flink patch-1
Alternatively you
25 matches
Mail list logo
