Github user ch33hau commented on the issue:
https://github.com/apache/flink/pull/2761
@fhueske Sorry for the problems you have raised, I can see the painful now,
I will avoid the same mistake.
Thanks for your time I really appreciate it.
---
If your project is set up
Github user ch33hau commented on the issue:
https://github.com/apache/flink/pull/4178
Thank you @zentol !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ch33hau commented on a diff in the pull request:
https://github.com/apache/flink/pull/4181#discussion_r123957141
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala
---
@@ -924,6 +924,19 @@ object pi
Github user ch33hau commented on a diff in the pull request:
https://github.com/apache/flink/pull/4178#discussion_r123912353
--- Diff:
flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/StreamExecutionEnvironment.scala
---
@@ -768,6 +768,18 @@ object
Github user ch33hau commented on the issue:
https://github.com/apache/flink/pull/4178
Hi @zentol ,
I have updated PR by adding a new method without default values.
Thanks =)
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user ch33hau commented on the issue:
https://github.com/apache/flink/pull/4178
Do you mean a new method with `createLocalEnvironment(Int, conf)`?
By this way compiler won't complain, just both the value have to be
entered.
However, I do agree that the way that you
Github user ch33hau commented on the issue:
https://github.com/apache/flink/pull/4178
Hi @zentol , thanks for taking time for reviewing :)
It was my original thought.
However turns out due to `Scala` supports `default value` in parameters, in
order to achieve same
GitHub user ch33hau opened a pull request:
https://github.com/apache/flink/pull/4178
[FLINK-7000] Add custom configuration local environment in Scala
StreamExecutionEnvironment
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following
Github user ch33hau commented on the issue:
https://github.com/apache/flink/pull/2761
Hi @fhueske this is ready for review.
I have moved Java's IT cases to
`org.apache.flink.streaming.test.StreamingExamplesITCase` and Scala's IT cases
Github user ch33hau commented on the issue:
https://github.com/apache/flink/pull/2761
@fhueske very sorry about this decade-long delay... I was working on some
relocation stuff for the past few months.
I have rebased and push a commit for fixing the PR comments
Github user ch33hau commented on the issue:
https://github.com/apache/flink/pull/2761
@fhueske it is ok, and thanks for the review =)
I couldn't fix them now and I might start working on your comments in 1 day.
---
If your project is set up for it, you can reply to this email
Github user ch33hau commented on the issue:
https://github.com/apache/flink/pull/2761
Hi @fhueske , any update on this? =)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user ch33hau commented on the issue:
https://github.com/apache/flink/pull/2761
Hi @thvasilo, thanks for the help, it's ok, knew that everyone is quite
busy =)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user ch33hau commented on the issue:
https://github.com/apache/flink/pull/2761
Hi @thvasilo thank you for taking your time on this PR again.
I have fixed the typos and couple of one-line-if statements, sorry for
those mistakes =( .
---
If your project is set up
Github user ch33hau commented on the issue:
https://github.com/apache/flink/pull/2761
Hi @thvasilo , sorry for the late.
I have updated my PR according to above comments, however, I'm not
confident on the explanations for `GroupedProcessingTimeWindowExample
Github user ch33hau commented on a diff in the pull request:
https://github.com/apache/flink/pull/2761#discussion_r89644293
--- Diff:
flink-examples/flink-examples-streaming/src/main/scala/org/apache/flink/streaming/scala/examples/kafka/ReadFromKafka.scala
---
@@ -0,0 +1,72
Github user ch33hau commented on the issue:
https://github.com/apache/flink/pull/2761
@thvasilo thanks! I will do that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user ch33hau opened a pull request:
https://github.com/apache/flink/pull/2761
[FLINK-3551] [examples] Sync Scala Streaiming Examples
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration
Github user ch33hau closed the pull request at:
https://github.com/apache/flink/pull/2682
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ch33hau commented on the issue:
https://github.com/apache/flink/pull/2682
Sorry I just noticed that similar PR
(https://github.com/apache/flink/pull/2658) has been created, in a way more
complete compare to my PR.
So I will close mine and sorry for creating
GitHub user ch33hau opened a pull request:
https://github.com/apache/flink/pull/2682
[FLINK-4886] [docs] Update ML quickstart loading svm test data example
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list
21 matches
Mail list logo
