Github user delding commented on the issue:
https://github.com/apache/flink/pull/2332
Hi @ramkrish86 , sorry I don't have bandwidth working on it..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user delding commented on the issue:
https://github.com/apache/flink/pull/2332
I agree it might be an overkill. But in case of having an sink that only
supports Put/Delete, it would be better to have ordered execution than not,
after all HBase has this API so there could
Github user delding commented on the issue:
https://github.com/apache/flink/pull/2332
Hi @ramkrish86 , I'm thinking replace batch() with mutateRow() because it
provides atomic ordered mutations for a single row, but it only supports Put
and Delete which should be fine since only Put
Github user delding commented on the issue:
https://github.com/apache/flink/pull/2332
Thanks for very detailed and helpful comments, let me work on it :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user delding commented on the issue:
https://github.com/apache/flink/pull/2332
Hi @ramkrish86 , CassandraTupleWriteAheadSink extends GenericWriteAheadSink
that deals with the checkpoint mechanism
---
If your project is set up for it, you can reply to this email and have your
Github user delding commented on the issue:
https://github.com/apache/flink/pull/2332
I can change back to HBase 1.1.2. The reason of using 2.0.0-SNAPSHOT is
because this bug (https://issues.apache.org/jira/browse/HBASE-14963 ). It's
only fixed for version 1.3.0+ and 2.0.0 and my
Github user delding commented on the issue:
https://github.com/apache/flink/pull/2332
Hi @fhueske , in HBase writes to a single row have ACID guarantee. The
exactly once semantic can be implemented the way CassandraSink did, storing
input records in a state backend and flushing
Github user delding commented on the issue:
https://github.com/apache/flink/pull/2332
Hi @fhueske , I have updated this PR to address your comments. In this
change, only one MutationActions and two ArralyList are needed for entire
stream, MutationActions is now resettable. But I
Github user delding commented on a diff in the pull request:
https://github.com/apache/flink/pull/2332#discussion_r78478766
--- Diff:
flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/HBaseMapper.java
---
@@ -0,0 +1,46
Github user delding commented on a diff in the pull request:
https://github.com/apache/flink/pull/2332#discussion_r78478455
--- Diff:
flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/HBaseMapper.java
---
@@ -0,0 +1,46
Github user delding commented on a diff in the pull request:
https://github.com/apache/flink/pull/2332#discussion_r78418366
--- Diff:
flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/HBaseMapper.java
---
@@ -0,0 +1,46
Github user delding commented on a diff in the pull request:
https://github.com/apache/flink/pull/2332#discussion_r77676668
--- Diff:
flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/HBaseMapper.java
---
@@ -0,0 +1,46
Github user delding commented on a diff in the pull request:
https://github.com/apache/flink/pull/2332#discussion_r77676350
--- Diff:
flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/HBaseMapper.java
---
@@ -0,0 +1,46
Github user delding commented on the issue:
https://github.com/apache/flink/pull/2332
Hi @ramkrish86 , I squashed my recent commit into the one you reviewed
before, then merged the upstream and pushed --force the commits which is why
you only see two commits. The first commit
Github user delding commented on the issue:
https://github.com/apache/flink/pull/2332
Hi @ramkrish86 , I squashed the commits before pushing.. Sorry about making
it unable to see those recent changes. If you could still review this PR when
you have time?
---
If your project is set
Github user delding commented on the issue:
https://github.com/apache/flink/pull/2332
Hi, I have updated the PR based on @ramkrish86 's comments.
1. rename MutationActionList to MutationActions which has a public method
createMutations that
return HBase Mutations
2
Github user delding commented on the issue:
https://github.com/apache/flink/pull/2332
Hi @rmetzger , Thanks for your comment. I am totally ok with contributing
the connector to Apache Bahir :-)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user delding commented on a diff in the pull request:
https://github.com/apache/flink/pull/2332#discussion_r74886606
--- Diff:
flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/MutationActionList.java
---
@@ -0,0
Github user delding commented on the issue:
https://github.com/apache/flink/pull/2332
Hi @ramkrish86 , thanks for your reviews and detailed comments :-)
I will update this PR soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user delding commented on a diff in the pull request:
https://github.com/apache/flink/pull/2332#discussion_r74711908
--- Diff:
flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/HBaseClient.java
---
@@ -0,0 +1,69
Github user delding commented on a diff in the pull request:
https://github.com/apache/flink/pull/2332#discussion_r74711889
--- Diff:
flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/MutationActionList.java
---
@@ -0,0
Github user delding commented on a diff in the pull request:
https://github.com/apache/flink/pull/2332#discussion_r74711637
--- Diff:
flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/MutationActionList.java
---
@@ -0,0
Github user delding commented on a diff in the pull request:
https://github.com/apache/flink/pull/2332#discussion_r74711470
--- Diff:
flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/MutationActionList.java
---
@@ -0,0
Github user delding commented on a diff in the pull request:
https://github.com/apache/flink/pull/2332#discussion_r74711244
--- Diff:
flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/MutationActionList.java
---
@@ -0,0
Github user delding commented on a diff in the pull request:
https://github.com/apache/flink/pull/2332#discussion_r74711022
--- Diff:
flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/MutationActionList.java
---
@@ -0,0
Github user delding commented on a diff in the pull request:
https://github.com/apache/flink/pull/2332#discussion_r74710964
--- Diff:
flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/MutationActionList.java
---
@@ -0,0
Github user delding commented on the issue:
https://github.com/apache/flink/pull/2332
BTW, the example runs well on my machine when I set hbase-client version to
2.0.0-SNAPSHOT, but travis-ci build failed due to "Failed to collect
dependencies at org.apache.habse:hbase-clien
Github user delding commented on the issue:
https://github.com/apache/flink/pull/2332
Hi, I have updated this PR, adding javadoc and an example as @tzulitai
advised and created Enums for PUT, DELETE, INCREMENT and APPEND as @ramkrish86
advised.
---
If your project is set up
Github user delding commented on a diff in the pull request:
https://github.com/apache/flink/pull/2332#discussion_r73939778
--- Diff:
flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/HBaseSink.java
---
@@ -0,0 +1,100
Github user delding commented on the issue:
https://github.com/apache/flink/pull/2332
Hi @tzulitai Thank you for all the comments :-) I will update the PR and
add an example in next a few days
---
If your project is set up for it, you can reply to this email and have your
reply
Github user delding commented on the issue:
https://github.com/apache/flink/pull/2332
BTW, failing tests are results of this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user delding commented on the issue:
https://github.com/apache/flink/pull/2332
Hi, this is my second PR to Flink, any comments or suggestions will be very
appreciated :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user delding opened a pull request:
https://github.com/apache/flink/pull/2332
[FLINK-2055] Implement Streaming HBaseSink
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes
Github user delding commented on the issue:
https://github.com/apache/flink/pull/2233
Hi, I have updated the PR as @StephanEwen suggested, adding two new methods
named socketTextStream that take string delimiter as parameter and delegating
the old method to the new one
---
If your
Github user delding commented on the issue:
https://github.com/apache/flink/pull/2233
Hi @zentol , If you agree with @StephanEwen 's suggestion, I will update
this PR in his way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user delding commented on the issue:
https://github.com/apache/flink/pull/2233
Hi @zentol , thanks for your comments. I have updated this PR. Please let
me know if there are further improvements that need to be done.
---
If your project is set up for it, you can reply
Github user delding commented on the issue:
https://github.com/apache/flink/pull/2233
This is my first pull request to Flink. Any comments would be very
appreciative.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user delding opened a pull request:
https://github.com/apache/flink/pull/2233
[FLINK-2125][streaming] Delimiter change from char to string
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration
38 matches
Mail list logo
