[GitHub] flink pull request #5009: [FLINK-8045] Add Internal DATE/TIME/TIMESTAMP as i...

GitHub user docete opened a pull request: https://github.com/apache/flink/pull/5009 [FLINK-8045] Add Internal DATE/TIME/TIMESTAMP as internal representata... …ion of DATE/TIME/TIMESTAMP *Thank you very much for contributing to Apache Flink - we are happy that you

[GitHub] flink issue #3338: [FLINK-5414] [table] Bump up Calcite version to 1.11

Github user docete commented on the issue: https://github.com/apache/flink/pull/3338 @wuchong @haohui Could u help to check FLINK-6173 ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink pull request #3579: [FLINK-6124] [Table API & SQL] support max/min agg...

Github user docete commented on a diff in the pull request: https://github.com/apache/flink/pull/3579#discussion_r107081399 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -916,6 +916,10 @@ object

[GitHub] flink pull request #3579: [FLINK-6124] [Table API & SQL] support max/min agg...

GitHub user docete opened a pull request: https://github.com/apache/flink/pull/3579 [FLINK-6124] [Table API & SQL] support max/min aggregations for strin… currently min/max aggregations on string type is not supported and should be added. When min/max aggregations are use

[GitHub] flink issue #3111: [FLINK-3475] [Table] DISTINCT aggregate function support ...

Github user docete commented on the issue: https://github.com/apache/flink/pull/3111 @fhueske Fixed according to your comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #3111: [FLINK-3475] [Table] DISTINCT aggregate function support ...

Github user docete commented on the issue: https://github.com/apache/flink/pull/3111 Agree. If we have more than one distinct agg with groupings, do the partition first and reuse the subsets would improve the performance. Could we merge this PR first and create another JIRA to

[GitHub] flink issue #3111: [FLINK-3475] [Table] DISTINCT aggregate function support ...

Github user docete commented on the issue: https://github.com/apache/flink/pull/3111 @fhueske Yes, I have checked the execution plan. It's very similar to your description: Take example for SQL "select sum(distinct a), sum(distinct b), sum(c) from expr",

[GitHub] flink pull request #3111: [FLINK-3475] [Table] DISTINCT aggregate function s...

Github user docete commented on a diff in the pull request: https://github.com/apache/flink/pull/3111#discussion_r96628698 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/FlinkRuleSets.scala --- @@ -96,6 +96,13 @@ object FlinkRuleSets

[GitHub] flink pull request #3111: [FLINK-3475] [Table] DISTINCT aggregate function s...

Github user docete commented on a diff in the pull request: https://github.com/apache/flink/pull/3111#discussion_r96568781 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/dataSet/FlinkAggregateExpandDistinctAggregatesRule.java --- @@ -0,0

[GitHub] flink pull request #3111: [FLINK-3475] [Table] DISTINCT aggregate function s...

Github user docete commented on a diff in the pull request: https://github.com/apache/flink/pull/3111#discussion_r96568191 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/AggregationTest.scala --- @@ -165,9 +165,13 @@ class AggregationTest extends

[GitHub] flink pull request #3111: [FLINK-3475] [Table] DISTINCT aggregate function s...

GitHub user docete opened a pull request: https://github.com/apache/flink/pull/3111 [FLINK-3475] [Table] DISTINCT aggregate function support for SQL queries Copy calcite's AggregateExpandDistinctAggregatesRule to Flink project, and do a quick fix to avoid some bad case mention