[GitHub] flink pull request #5202: [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT ...
Github user dubin555 closed the pull request at: https://github.com/apache/flink/pull/5202 ---
[GitHub] flink issue #5202: [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT support...
Github user dubin555 commented on the issue: https://github.com/apache/flink/pull/5202 Hi @sunjincheng121 , thanks for the overall review of my code. I've done some typo fix and add some test case base on your comment. Really appreciate for your careful review! Du Bin ---
[GitHub] flink issue #5202: [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT support...
Github user dubin555 commented on the issue: https://github.com/apache/flink/pull/5202 Hi @sunjincheng121 . Thanks for the review. I already finished some changed for code cleaning and remove the duplicate test case base on your comment. There are some similar implements in other Database, like MySQL, https://dev.mysql.com/doc/refman/5.7/en/bit-functions.html Oracle, https://docs.oracle.com/cd/E22583_01/DR/help/BitShift.html In Apache Spark, also exists similar implements, https://issues.apache.org/jira/browse/SPARK-8223 Thanks, Du Bin ---
[GitHub] flink pull request #5202: [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT ...
Github user dubin555 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5202#discussion_r159151505
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarFunctionsTest.scala
---
@@ -1216,6 +1216,69 @@ class ScalarFunctionsTest extends
ScalarTypesTestBase {
)
}
+ @Test
+ def testShiftLeft(): Unit = {
+testSqlApi(
+ "SHIFT_LEFT(1,1)",
+ "2"
+)
+
+testSqlApi(
+ "SHIFT_LEFT(21,1)",
+ "42"
+)
+
+testSqlApi(
+ "SHIFT_LEFT(21,1)",
+ "42"
+)
+
--- End diff --
removed
---
[GitHub] flink pull request #5202: [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT ...
GitHub user dubin555 opened a pull request: https://github.com/apache/flink/pull/5202 [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT supported in SQL In this PR, SHIFT_LEFT and SHIFT_RIGHT are added. ## General The pull request references the related JIRA issue, [FLINK-8302]Support shift_left and shift_right in TableAPI The pull request addresses only one issue Each commit in the PR has a meaningful commit message (including the JIRA id) ## Tests & Build Functionality added by the pull request is covered by tests ## Documentation Does this pull request introduce a new feature? (yes ) If yes, how is the feature documented? (docs / JavaDocs) You can merge this pull request into a Git repository by running: $ git pull https://github.com/dubin555/flink master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/5202.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5202 commit 3db3a65178a91fce8d92b741cf58d4e02c96212e Author: DuBin <bdu2@...> Date: 2017-12-21T09:02:33Z [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT supported in SQL commit 89ac219a65e4b6b0dc03873b13b8b997cfb474fe Author: DuBin <bdu2@...> Date: 2017-12-21T10:00:19Z [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT supported in SQL commit 4212107079b5b5a5d7d2669bc106b2463f0e8f7d Author: DuBin <bdu2@...> Date: 2017-12-21T10:11:01Z [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT supported in SQL commit 28852dffdeeb4facb95b84e0294fea7788e7eaed Author: DuBin <bdu2@...> Date: 2017-12-22T00:14:28Z [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT supported in SQL ---
[GitHub] flink pull request #5198: [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT ...
Github user dubin555 closed the pull request at: https://github.com/apache/flink/pull/5198 ---
[GitHub] flink pull request #5198: [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT ...
GitHub user dubin555 opened a pull request: https://github.com/apache/flink/pull/5198 [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT supported in SQL In this PR, SHIFT_LEFT and SHIFT_RIGHT are added. General The pull request references the related JIRA issue, [FLINK-8302]Support shift_left and shift_right in TableAPI The pull request addresses only one issue Each commit in the PR has a meaningful commit message (including the JIRA id) Tests & Build Functionality added by the pull request is covered by tests Documentation Does this pull request introduce a new feature? (yes ) If yes, how is the feature documented? (docs / JavaDocs) You can merge this pull request into a Git repository by running: $ git pull https://github.com/dubin555/flink master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/5198.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5198 commit 3db3a65178a91fce8d92b741cf58d4e02c96212e Author: DuBin <bdu2@...> Date: 2017-12-21T09:02:33Z [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT supported in SQL commit 89ac219a65e4b6b0dc03873b13b8b997cfb474fe Author: DuBin <bdu2@...> Date: 2017-12-21T10:00:19Z [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT supported in SQL commit 4212107079b5b5a5d7d2669bc106b2463f0e8f7d Author: DuBin <bdu2@...> Date: 2017-12-21T10:11:01Z [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT supported in SQL ---
[GitHub] flink pull request #5197: [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT ...
Github user dubin555 closed the pull request at: https://github.com/apache/flink/pull/5197 ---
[GitHub] flink pull request #5197: [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT ...
GitHub user dubin555 opened a pull request: https://github.com/apache/flink/pull/5197 [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT supported in SQL In this PR, SHIFT_LEFT and SHIFT_RIGHT are added. ## General - *The pull request references the related JIRA issue, [FLINK-8302]Support shift_left and shift_right in TableAPI* - *The pull request addresses only one issue* - *Each commit in the PR has a meaningful commit message (including the JIRA id)* ## Tests & Build - Functionality added by the pull request is covered by tests ## Documentation - Does this pull request introduce a new feature? (yes ) - If yes, how is the feature documented? (docs / JavaDocs) You can merge this pull request into a Git repository by running: $ git pull https://github.com/dubin555/flink master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/5197.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5197 commit 3db3a65178a91fce8d92b741cf58d4e02c96212e Author: DuBin <bdu2@...> Date: 2017-12-21T09:02:33Z [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT supported in SQL commit 89ac219a65e4b6b0dc03873b13b8b997cfb474fe Author: DuBin <bdu2@...> Date: 2017-12-21T10:00:19Z [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT supported in SQL ---
[GitHub] flink pull request #5196: [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT ...
Github user dubin555 closed the pull request at: https://github.com/apache/flink/pull/5196 ---
[GitHub] flink pull request #5196: [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT ...
GitHub user dubin555 opened a pull request: https://github.com/apache/flink/pull/5196 [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT supported in SQL In this PR, SHIFT_LEFT and SHIFT_RIGHT are added. *(General:)* - *The pull request references the related JIRA issue, [FLINK-8302]Support shift_left and shift_right in TableAPI* - *The pull request addresses only one issue* - *Each commit in the PR has a meaningful commit message (including the JIRA id)* ## Tests & Build - Functionality added by the pull request is covered by tests - mvn clean verify has been executed successfully locally or a Travis build has passed ## Documentation - Does this pull request introduce a new feature? (yes ) - If yes, how is the feature documented? (docs / JavaDocs) You can merge this pull request into a Git repository by running: $ git pull https://github.com/dubin555/flink master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/5196.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5196 commit 3db3a65178a91fce8d92b741cf58d4e02c96212e Author: DuBin <bdu2@...> Date: 2017-12-21T09:02:33Z [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT supported in SQL ---
