Github user ffbin closed the pull request at:
https://github.com/apache/flink/pull/973
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/1046#issuecomment-141851757
Hi @fhueske , i will update the PR to use ExecutionConfig. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/1046#issuecomment-139959540
@StephanEwen @rmetzger Can you have a look at it if it can be merged? I am
also work on storm task hooks and it depend on this PR. Thank you very much!
---
If your
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/1046#issuecomment-138865484
@mjsax Thanks. I have finish the change about all comments.
@StephanEwen @rmetzger Can you have a look at it if it can be merged?
Thank you very much!
---
If your
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/1046#issuecomment-138470052
@mjsax @StephanEwen @rmetzger I have finish the change about all comments
and update documentation. Can you have a look at it if it can be merged? Thank
you very much
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/1046#issuecomment-138292133
@mjsax @StephanEwen @rmetzger I have finish the change about all comments.
Can you have a look at it if it can be merged? Thank you very much!
---
If your project is set
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/1046#issuecomment-138267349
@rmetzger Thanks.I have use the classloader of `StormWrapperSetupHelper´
instead of 'map' and change the fashion of creating Strings.
---
If your project is set up
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/1046#issuecomment-138051794
@mjsax @StephanEwen Thanks. I have finish the changes at the core classes.
when user use env.getConfig().setGlobalJobParameters(conf); to set storm
configuration, I
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/1046#issuecomment-136636200
@mjsax @StephanEwen I have finish the code change.Can you give me some
comment? Thank you very much!
---
If your project is set up for it, you can reply to this email
Github user ffbin commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r38382368
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/wrappers
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/1046#issuecomment-136301903
@mjsax Thanks.
I have a question:
In my windows machine, the textPath of ExclamationWithStormSpoutITCase is
file:/C:/Users/xxx/AppData/Local/Temp
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/1046#issuecomment-136304296
Oh, So not all test case can run successfully in windows?
I have change this and commit again.
---
If your project is set up for it, you can reply to this email
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/1046#issuecomment-136241503
@mjsax @StephanEwen I have finish the code changes.
1.serialize Storm Config as a byte[] into the Flink configuration
2.extend ExclamationTopology
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/1046#issuecomment-135412789
Oh. you are right. Serialize the whole Map into a single byte[] is
better.Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/1046#issuecomment-135403187
@StephanEwen Thansk.The key of storm config is object, so maybe the
confData(HashMapString, Object) of Configuration is not enough.
---
If your project is set up
Github user ffbin commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r37745377
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/api/FlinkLocalCluster.java
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/1046#issuecomment-134198533
@mjsax .The reason why i can not see Travis details is that(from reply
mail):
The problem is that our CDN is currently blocked in mainland China. I'm
talking to our
Github user ffbin commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r37746734
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/test/java/org/apache/flink/stormcompatibility/wrappers
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/1046#issuecomment-134184818
@mjsax Thank you very much.I miss the change in FlinkClient.I will fix it
and test via bin/start-local.sh.In china, now we can not see the CI details and
it is hard
Github user ffbin commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r37744576
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/wrappers
Github user ffbin commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r37745758
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/test/java/org/apache/flink/stormcompatibility/wrappers
Github user ffbin commented on a diff in the pull request:
https://github.com/apache/flink/pull/1046#discussion_r37746694
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/test/java/org/apache/flink/stormcompatibility/wrappers
GitHub user ffbin opened a pull request:
https://github.com/apache/flink/pull/1046
[FLINK-2525]Add configuration support in Storm-compatibility
- enable config can used in Spouts.open() and Bout.prepare().
Example like this:
public static void main(final String[] args
Github user ffbin closed the pull request at:
https://github.com/apache/flink/pull/1020
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/1020#issuecomment-131495368
@StephanEwen Thanks. I think you pull request has fixes this.I will close
my pull request and view your code.
---
If your project is set up for it, you can reply
Github user ffbin commented on a diff in the pull request:
https://github.com/apache/flink/pull/1017#discussion_r37142604
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/runtime/tasks/TwoInputStreamTask.java
---
@@ -27,114
GitHub user ffbin opened a pull request:
https://github.com/apache/flink/pull/1024
[FLINK-2530]optimize equal() of AcknowledgeCheckpoint
optimize repeated check of this.state == null
You can merge this pull request into a Git repository by running:
$ git pull https
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/1024#issuecomment-131523209
@zentol hi. You are right.I want to change
(this.state == null ? that.state == null : (that.state != null
this.state.equals(that.state))) to
(this.state == null
Github user ffbin closed the pull request at:
https://github.com/apache/flink/pull/1024
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/1024#issuecomment-131657696
@zentol @StephanEwen Thanks.This is not performance critical code and some
check is better.
---
If your project is set up for it, you can reply to this email and have
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/1020#issuecomment-131314931
@zentol Hello! Thank you for your suggestion.I have add exception message
in log.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user ffbin opened a pull request:
https://github.com/apache/flink/pull/1020
[FLINK-2526]Add try-catch for task when it stop running
inputProcessor cleanup() may throw IOException.If do not catch it, the next
line outputHandler .flushOutputs() will not work and cause output
Github user ffbin closed the pull request at:
https://github.com/apache/flink/pull/989
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/989#issuecomment-131276961
@StephanEwen Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user ffbin closed the pull request at:
https://github.com/apache/flink/pull/1012
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/1012#issuecomment-131276733
@StephanEwen @chiwanpark Thank you very much.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/1009#issuecomment-131287408
@hsaputra @StephanEwen Thanks. I have fix my code error.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/1009#issuecomment-130509029
@uce @hsaputra Thanks. I have move the try up and rely on finally to close
the client.
---
If your project is set up for it, you can reply to this email and have your
GitHub user ffbin opened a pull request:
https://github.com/apache/flink/pull/1012
[FLINK-2516]Remove unwanted log.isInfoEnabled check
The function has call log.info() at the head of it.So i think the check of
log.isInfoEnabled after call log.info() is unwanted.
You can merge
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/1009#issuecomment-130233136
@uce Thanks. What about remove if(client.getTopologyJobId(name) != null)
{...} in line 103, because submitTopologyWithOpts() has check it at the head
of function
GitHub user ffbin opened a pull request:
https://github.com/apache/flink/pull/1007
[FLINK-2507]Rename the function tansformAndEmit
I think the function name tansformAndEmit in '
org.apache.flink.stormcompatibility.wrappers.AbstractStormCollector' is a wrong
spelling, it should
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/1007#issuecomment-129854098
@chiwanpark Thank you very much. I submit code in linux and modify the
permissions Incorrectly.I will submit again,.
---
If your project is set up for it, you can reply
GitHub user ffbin opened a pull request:
https://github.com/apache/flink/pull/1009
[FLINK-2512]Add client.close() before throw RuntimeException
In line 129, it close client in finally{} before throw exception.
But in line 105, it throw exception without close client.
So I
Github user ffbin closed the pull request at:
https://github.com/apache/flink/pull/998
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/998#issuecomment-128610658
enableCheckpointing() will call forceCheckpoint() and set forceCheckpoint
true.The old code(if (isIterative() isCheckpointingEnabled()
!forceCheckpoint) ) will not throw
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/998#issuecomment-128637022
@gyfora Thanks.
I have check IterateTest#testWithCheckpointing(), it is for the mentioned
case.
But the comment (// temporarily forbid checkpointing for iterative
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/998#issuecomment-128642091
@zentol @gyfora Thank you very much.I have learn it.The code comment (//
temporarily forbid checkpointing for iterative jobs) maybe is misleading.
---
If your project
GitHub user ffbin opened a pull request:
https://github.com/apache/flink/pull/998
Fix StreamGraph getJobGraph bug
When forceCheckpoint is true,checkpointing will be enabled for iterative
jobs.But now temporarily forbid checkpointing for iterative jobs, so if
forceCheckpoint
GitHub user ffbin opened a pull request:
https://github.com/apache/flink/pull/984
[FLINK-2483]Add default branch of switch(scheduleMode) in
scheduleForExecution function
The scheduleMode in executionGraph is get from JobGraph, and JobGraph has
not check the scheduleMode.So
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/973#issuecomment-127259881
hi, I can run successfully in local computer,but CI is failed,How can i see
why CI is failed?
I can not see the details content ,it is Do you have a question
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/973#issuecomment-127445514
Hi , i can not access https://travis-ci.org/apache/flink/builds/73886757.
Open it , i can only see Do you have a question?.
---
If your project is set up for it, you can
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/973#issuecomment-127449876
hi, System.currentTimeMillis() is cost performance very much.I want to use
a thread to call System.currentTimeMillis and update a static long variable
millTime.All other
GitHub user ffbin opened a pull request:
https://github.com/apache/flink/pull/978
Remove unwanted check null of input1 in ConnectedDataStream
input1 is used in line 61.If input1 is null ,it will throw
NullPointException in line 61.So check null of input1 after use input1
GitHub user ffbin opened a pull request:
https://github.com/apache/flink/pull/972
[FLINK-2465] Fix SocketClientSink closeConnection function memory leak
When closeConnection, should call dataOutputStream.close() instead of
dataOutputStream.flush() because close() will call flush
GitHub user ffbin opened a pull request:
https://github.com/apache/flink/pull/973
[FLINK-2471]FileSinkFunction invoke performance optimize
FileSinkFunction invoke funtion always call updateCondition, so we can use
a variable updateTime to avoid frequent operate
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/973#issuecomment-127253382
In one millisecond, it will call updateCondition about 1 times and it
will do minus operate 1 times.But update lastTime is less than times of
call
Github user ffbin closed the pull request at:
https://github.com/apache/flink/pull/964
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user ffbin opened a pull request:
https://github.com/apache/flink/pull/965
[FLINK-2446]Fix SocketTextStreamFunction has memory leak when reconnect
server
When reconnect server failed, it should call socket.close() to avoid memory
leak.
You can merge this pull request
GitHub user ffbin opened a pull request:
https://github.com/apache/flink/pull/964
[FLINK-2446] Fix SocketTextStreamFunction has memory leak when reconnect
server
When reconnect server failed, it should call socket.close() to avoid
memory leak.
You can merge this pull request
Github user ffbin closed the pull request at:
https://github.com/apache/flink/pull/932
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ffbin commented on the pull request:
https://github.com/apache/flink/pull/940#issuecomment-125192161
Thank you very much!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user ffbin opened a pull request:
https://github.com/apache/flink/pull/940
[FLINK-2391]Fix Storm-compatibility FlinkTopologyBuilder.createTopology bug
where get streaming group attribute index, it get upstream operator
outputFields.
You can merge this pull request
GitHub user ffbin opened a pull request:
https://github.com/apache/flink/pull/932
[FLINK-2391]Fix Storm-compatibility FlinkTopologyBuilder.createTopology bug
1.Error Scene:
Error happend in program like this:
builder.setSpout(source0, new Generator(pt),
pt.getInt
63 matches
Mail list logo
