[GitHub] flink pull request #2487: [FLINK-4520][flink-siddhi] Integrate Siddhi as a l...

2017-11-26 Thread haoch
Github user haoch closed the pull request at: https://github.com/apache/flink/pull/2487 ---

[GitHub] flink issue #2487: [FLINK-4520][flink-siddhi] Integrate Siddhi as a light-we...

2017-11-26 Thread haoch
Github user haoch commented on the issue: https://github.com/apache/flink/pull/2487 Finally, the PR merged into https://github.com/apache/bahir-flink/pull/22, thanks everyone for the review! ---

[GitHub] flink issue #2487: [FLINK-4520][flink-siddhi] Integrate Siddhi as a light-we...

2017-11-21 Thread haoch
Github user haoch commented on the issue: https://github.com/apache/flink/pull/2487 Keep this PR open until https://github.com/apache/bahir-flink/pull/22 merged. ---

[GitHub] flink issue #2487: [FLINK-4520][flink-siddhi] Integrate Siddhi as a light-we...

2017-11-18 Thread haoch
Github user haoch commented on the issue: https://github.com/apache/flink/pull/2487 As mentioned above, moved the patch to Apache Bahir at https://github.com/apache/bahir/pull/54, resolve this one. ---

[GitHub] flink issue #2487: [FLINK-4520][flink-siddhi] Integrate Siddhi as a light-we...

2017-06-14 Thread haoch
Github user haoch commented on the issue: https://github.com/apache/flink/pull/2487 @asdf2014 sorry for delayed response, will find some time to finalize this PR and propose to Bahir project . --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink issue #2487: [FLINK-4520][flink-siddhi] Integrate Siddhi as a light-we...

2017-02-21 Thread haoch
Github user haoch commented on the issue: https://github.com/apache/flink/pull/2487 @uce sure, will fix it and resend PR to Bahir. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #2487: [FLINK-4520][flink-siddhi] Integrate Siddhi as a light-we...

2016-09-21 Thread haoch
Github user haoch commented on the issue: https://github.com/apache/flink/pull/2487 @StephanEwen sure, that's all ok. :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink issue #2487: [FLINK-4520][flink-siddhi] Integrate Siddhi as a light-we...

2016-09-20 Thread haoch
Github user haoch commented on the issue: https://github.com/apache/flink/pull/2487 @StephanEwen thanks for the comments, I think it's both ok to keep this in the core or as an separated project, but the concern is it maybe better for community development to centralize qualified

[GitHub] flink issue #2487: [FLINK-4520][flink-siddhi] Integrate Siddhi as a light-we...

2016-09-20 Thread haoch
Github user haoch commented on the issue: https://github.com/apache/flink/pull/2487 @mushketyk I have added lots of java docs as required in latest commit: https://github.com/apache/flink/pull/2487/commits/4699f9c3dfc4ce0a9837eb60579c76d50b346f03, please continue to help review

[GitHub] flink issue #2487: [FLINK-4520][flink-siddhi] Integrate Siddhi as a light-we...

2016-09-12 Thread haoch
Github user haoch commented on the issue: https://github.com/apache/flink/pull/2487 @mushketyk thanks very much for reviewing, will fix as required soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink issue #2487: [FLINK-4520][flink-siddhi] Integrate Siddhi as a light-we...

2016-09-10 Thread haoch
Github user haoch commented on the issue: https://github.com/apache/flink/pull/2487 @apivovarov thanks very much for the comments. I have formatted all code as required. Pls. kindly help continue reviewing. --- If your project is set up for it, you can reply to this email and have

[GitHub] flink issue #2486: [FLINK-4520][flink-siddhi] Integrate Siddhi as a light-we...

2016-09-09 Thread haoch
Github user haoch commented on the issue: https://github.com/apache/flink/pull/2486 Closed this PR for cleaning commit history and recreated another PR #2487 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request #2487: [FLINK-4520][flink-siddhi] Integrate Siddhi as a l...

2016-09-09 Thread haoch
GitHub user haoch opened a pull request: https://github.com/apache/flink/pull/2487 [FLINK-4520][flink-siddhi] Integrate Siddhi as a light-weight Streaming CEP Library Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list

[GitHub] flink pull request #2486: [FLINK-4520][flink-siddhi] Integrate Siddhi as a l...

2016-09-09 Thread haoch
Github user haoch closed the pull request at: https://github.com/apache/flink/pull/2486 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request #2486: FLINK-4520 Integrate Siddhi as a light-weight Stre...

2016-09-09 Thread haoch
GitHub user haoch opened a pull request: https://github.com/apache/flink/pull/2486 FLINK-4520 Integrate Siddhi as a light-weight Streaming CEP Library Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration

[GitHub] flink issue #2420: [hotfix] Fix invalid url link in documentation

2016-08-25 Thread haoch
Github user haoch commented on the issue: https://github.com/apache/flink/pull/2420 @fhueske sure and thanks for the comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request #2420: [hotfix] Fix invalid url link in documentation

2016-08-25 Thread haoch
Github user haoch closed the pull request at: https://github.com/apache/flink/pull/2420 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request #2420: [hotfix] Fix invalid elasticsearch url link in doc...

2016-08-25 Thread haoch
GitHub user haoch opened a pull request: https://github.com/apache/flink/pull/2420 [hotfix] Fix invalid elasticsearch url link in documentation Fix invalid elasticsearch url link from `http://elastic.com` to `http://elastic.co` in documentation You can merge this pull request