Github user ifndef-SleePy commented on the issue:
https://github.com/apache/flink/pull/5580
@zentol All right, got your point. That's a problem indeed.
---
Github user ifndef-SleePy commented on the issue:
https://github.com/apache/flink/pull/5580
If some day the behavior of `RestClusterClient` changes. Maybe uploading
the jars via REST API. We could just upload the user-defined files via REST API
either. That's not a big problem, right?
---
Github user ifndef-SleePy commented on the issue:
https://github.com/apache/flink/pull/5580
Hi @zentol
In Flip-6 the client communicates with cluster via REST API, that's true.
However this not include blobs. Currently in `RestClusterClient.submit()`
method, the client
Github user ifndef-SleePy commented on a diff in the pull request:
https://github.com/apache/flink/pull/5580#discussion_r170804963
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
---
@@ -314,6 +315,9 @@ public static TaskExecutor
Github user ifndef-SleePy commented on the issue:
https://github.com/apache/flink/pull/5048
Hi @tillrohrmann , I just updated the PR, sorry for delaying so long.
---
GitHub user ifndef-SleePy opened a pull request:
https://github.com/apache/flink/pull/5322
[hotfix] [REST] Fix WebMonitorEndpoint that missing parameters while
initializing handlers
## What is the purpose of the change
* Fix bugs in my recent PRs about migrating subtask
GitHub user ifndef-SleePy opened a pull request:
https://github.com/apache/flink/pull/5287
[FLINK-8367] [REST] Migrate SubtaskCurrentAttemptDetailsHandler to Flip-6
REST handler
## What is the purpose of the change
* Migrate
GitHub user ifndef-SleePy opened a pull request:
https://github.com/apache/flink/pull/5285
[FLINK-8369] [REST] Migrate SubtaskExecutionAttemptAccumulatorsHandler to
new a REST handler
## What is the purpose of the change
* MigrateÂ
GitHub user ifndef-SleePy opened a pull request:
https://github.com/apache/flink/pull/5270
[FLINK-8368] [REST] Migrate SubtaskExecutionAttemptDetailsHandler to new a
REST handler
## What is the purpose of the change
* Migrate
Github user ifndef-SleePy commented on a diff in the pull request:
https://github.com/apache/flink/pull/5091#discussion_r156621784
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java
---
@@ -266,104 +279,367 @@ public void
Github user ifndef-SleePy commented on a diff in the pull request:
https://github.com/apache/flink/pull/5091#discussion_r154871284
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/scheduler/ScheduledUnit.java
---
@@ -19,68 +19,104 @@
package
Github user ifndef-SleePy commented on the issue:
https://github.com/apache/flink/pull/5048
Hi Till, thank you for reviewing.
I agree that it is much simpler to use `scheduleRunAsync`.
[PR-5091](https://github.com/apache/flink/pull/5091) is not a small
reworking. But
GitHub user ifndef-SleePy opened a pull request:
https://github.com/apache/flink/pull/5048
[Flink-7871] [flip6] SlotPool should release unused slots to RM
## What is the purpose of the change
* This pull request makes SlotPool release unused slots back to RM if the
slots
Github user ifndef-SleePy commented on the issue:
https://github.com/apache/flink/pull/3810
Nice work!
I have rebased master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user ifndef-SleePy commented on the issue:
https://github.com/apache/flink/pull/3810
OK, got it. Thank you for explanation. Is there any more problems with this
pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user ifndef-SleePy commented on the issue:
https://github.com/apache/flink/pull/3810
Hi, I updated this review. I don't know why there is no reminding in jira
and email.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user ifndef-SleePy commented on a diff in the pull request:
https://github.com/apache/flink/pull/3810#discussion_r115170542
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MultipleProgramsTestBase.java
---
@@ -80,29 +80,36
Github user ifndef-SleePy commented on the issue:
https://github.com/apache/flink/pull/3810
I think Till has implemented a static unsetAsContext method in
TestEnvironment recently. I rebased the implementation from master, and
recommit the pull request.
---
If your project is set
Github user ifndef-SleePy commented on a diff in the pull request:
https://github.com/apache/flink/pull/3810#discussion_r115133175
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MultipleProgramsTestBase.java
---
@@ -80,29 +80,36
Github user ifndef-SleePy commented on a diff in the pull request:
https://github.com/apache/flink/pull/3810#discussion_r114693043
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MultipleProgramsTestBase.java
---
@@ -80,29 +80,36
Github user ifndef-SleePy commented on the issue:
https://github.com/apache/flink/pull/3810
@StephanEwen
I agree that a static unset method would be a much easier implementation.
Do you think it's acceptable that the unset method is static but set method is
not stat
GitHub user ifndef-SleePy opened a pull request:
https://github.com/apache/flink/pull/3810
[Flink-6397] MultipleProgramsTestBase does not reset ContextEnvironment
Reset ContextEnvironment when finished testing in
MultipleProgramsTestBase.java and some other ITCase.
Remove some
Github user ifndef-SleePy commented on the issue:
https://github.com/apache/flink/pull/3395
Hi Till, I almost miss this comments! I didn't see it until a few minutes
ago.
I fully understand your concern. Just let me explain more about your
comments.
1. I agree mo
Github user ifndef-SleePy closed the pull request at:
https://github.com/apache/flink/pull/3395
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ifndef-SleePy commented on the issue:
https://github.com/apache/flink/pull/3487
Thank you, Stephan and zentol.
Good question and suggestion. I didn't consider it too much for batch jobs.
Also I think it's a bad idea that naming the variable "numberO
Github user ifndef-SleePy commented on a diff in the pull request:
https://github.com/apache/flink/pull/3487#discussion_r104825967
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/functions/RuntimeContext.java
---
@@ -85,6 +85,13 @@
int getIndexOfThisSubtask
GitHub user ifndef-SleePy opened a pull request:
https://github.com/apache/flink/pull/3487
[FLINK-5980] Expose max-parallelism value in RuntimeContext.
Add new method named getMaxParallelismOfSubtasks in RuntimeContext.
You can merge this pull request into a Git repository by
Github user ifndef-SleePy closed the pull request at:
https://github.com/apache/flink/pull/3396
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ifndef-SleePy commented on the issue:
https://github.com/apache/flink/pull/3396
Ah, you are right. I think I mixed up this issue with another one. Thank
you for pointing it out.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user ifndef-SleePy opened a pull request:
https://github.com/apache/flink/pull/3396
[FLINK-5879] Fix bug about ExecutionAttemptID, add super() in constructor.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alibaba/flink
GitHub user ifndef-SleePy opened a pull request:
https://github.com/apache/flink/pull/3395
[FLINK-5861] Components of TaskManager support updating JobManagerConnection
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alibaba
GitHub user ifndef-SleePy opened a pull request:
https://github.com/apache/flink/pull/3296
[FLINK-5784] Fix bug about registering JobManagerLeaderListener in
LeaderRetrievalService multiple times
[FLINK-5784] Fix bug about registering JobManagerLeaderListener in
Github user ifndef-SleePy closed the pull request at:
https://github.com/apache/flink/pull/2877
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ifndef-SleePy closed the pull request at:
https://github.com/apache/flink/pull/2828
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ifndef-SleePy closed the pull request at:
https://github.com/apache/flink/pull/2817
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user ifndef-SleePy opened a pull request:
https://github.com/apache/flink/pull/2877
[FLINK-5141] Implement Flip6LocalStreamEnvironment to run new mini cluster
in flip-6 branch
Implement a StreamEnvironment to run flip-6 mini cluster. According to
Till's suggestion, I
GitHub user ifndef-SleePy opened a pull request:
https://github.com/apache/flink/pull/2828
[FLINK-5093] java.util.ConcurrentModificationException is thrown when
stopping TimerService
[FLINK-5093] Fix bug about java.util.ConcurrentModificationException thrown
while stopping
GitHub user ifndef-SleePy opened a pull request:
https://github.com/apache/flink/pull/2817
[FLINK-5076] Shutting down TM when shutting down mini cluster.
This PR [#5076](https://issues.apache.org/jira/browse/FLINK-5076) adds
shutting down task manager when shutting down new mini
38 matches
Mail list logo
